From patchwork Mon Oct 5 21:31:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 268037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01084C47095 for ; Mon, 5 Oct 2020 21:32:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9FCC20FC3 for ; Mon, 5 Oct 2020 21:32:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jyV5eB05" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbgJEVcI (ORCPT ); Mon, 5 Oct 2020 17:32:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbgJEVcI (ORCPT ); Mon, 5 Oct 2020 17:32:08 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBD3DC0613CE; Mon, 5 Oct 2020 14:32:07 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id l15so858233wmh.1; Mon, 05 Oct 2020 14:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=o3Ej3LavHo/S663DnWXhpENRkd1MBuaBAhHjxbMV30s=; b=jyV5eB05miHoZqZ0XtU79dn4XyVWl5bBvj4y6c/qdqgb7oUCoG45AZ0/1VbwBHHDP2 qogvIKBEX4MeuFVH/coQvrR5GLJXRAh9RrmQg7F5OtLSQ0XkDqBZg+eN6mPN0GahEi/P pIrlK8rpMeS6zHCSfaBdCWeqWSPy1917Ic2D3bvGzx7M2r3tSXWFeSfPTe7LGRqKcxEL CC24abMJ0KFZ7aK2DG2WMLt1RIRWs85Z0KNaFIssjIQ33xU3VhUg4KJ/HW2lLPChYHrN sEAtCg6AIPjddhnq+cTi6b2Hro/C0jh+12ngjZ6rgM3HgfVv72t5yu+9qfJ8rw5w0/A3 sGWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=o3Ej3LavHo/S663DnWXhpENRkd1MBuaBAhHjxbMV30s=; b=tlgMkaSzglOFHEVolmeHyJdA/3uv6tFKy/uPSwYM1e/qx3dmERhha6x1rjd0PMqGgH 72tgOoRpNIBq5+IcSd+OADrn1ad+O4P2ZILEj5DFDoOpZm51Y6MrNBRaJXHUhxT+e8ie NlWiNQquGYoOKJDCkNG6+/D5L8zktnDtOOt4sX8HGpEVHBiBEbHEKcw4O9iV7yP1GVPb HlLC1Nw511kqonMCex2S/SO9ofHz68Wu5Ih28QVRxfIqFSNpdmSkZUeLjQfcIkjZDoem 3QKHiR85o7bgXG8U4SvFJBJFR2QlP2hRcyBhqf9sQxBntNhuNA4pCb/n7sn0JRKSIBvC oNJQ== X-Gm-Message-State: AOAM533y94X9jv+eETq+PbP+hAbAW33hcupgj3R2W2xjY++pdw7KF+Xm 7ZrVmNY1Vu5wl/Ztw0Y1TUCB9A5pjC4afw== X-Google-Smtp-Source: ABdhPJzZRxNQ/305lZa0njFqzSW0QW0eoQM1oNffk9v2kzF6D9dfQMiMJZvwTogMHAlr2n5+uPeulQ== X-Received: by 2002:a1c:f214:: with SMTP id s20mr1302967wmc.84.1601933526399; Mon, 05 Oct 2020 14:32:06 -0700 (PDT) Received: from localhost.localdomain (host-92-5-241-147.as43234.net. [92.5.241.147]) by smtp.gmail.com with ESMTPSA id q9sm1474013wrd.57.2020.10.05.14.32.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Oct 2020 14:32:05 -0700 (PDT) From: Sudip Mukherjee To: Alan Stern , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech, linux-usb@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference Date: Mon, 5 Oct 2020 22:31:49 +0100 Message-Id: <20201005213149.12332-1-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 2.11.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org find_tt() can return NULL or the error value in ERR_PTR() and dereferencing the return value without checking for the error can lead to a possible dereference of NULL pointer or ERR_PTR(). Signed-off-by: Sudip Mukherjee Reviewed-by: Harley A.W. Lorenzo ps.udev); + if (IS_ERR_OR_NULL(tt)) + return; if (sign > 0) list_add_tail(&qh->ps.ps_list, &tt->ps_list); else @@ -1338,6 +1340,8 @@ static void reserve_release_iso_bandwidth(struct ehci_hcd *ehci, } tt = find_tt(stream->ps.udev); + if (IS_ERR_OR_NULL(tt)) + return; if (sign > 0) list_add_tail(&stream->ps.ps_list, &tt->ps_list); else