From patchwork Wed Oct 18 17:00:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 116319 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp6285190qgn; Wed, 18 Oct 2017 10:00:56 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SELh1RwzhCBN+LnLRUi2lWuzAfzNj0x1Xw7uFlvy3GmLQg0+PlnR3bwpsTk83pDibzFyeh X-Received: by 10.237.35.58 with SMTP id h55mr3959594qtc.108.1508346055907; Wed, 18 Oct 2017 10:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508346055; cv=none; d=google.com; s=arc-20160816; b=c/Q1hldA9/qeQLcRlzXcDKX/eX0/rYDI9ft4kOdn/I02hpgZNb1yb58u+M0ux5vkR5 CvMXBoxADI78oIo5tC70aUdDRpTtthGyeKPICagTk76cVzzcQZhB0qBPXBDEK4rP0k6s UzIiKk0u/661pm1VejcbrNcSCgh+ockR7ibC4Oe2AAEJC0/FpJEMZA5npx+j4V2hglQG CzbXLiRHGWCVIqDlJWfnHq/Voi13gbQVG0xQS7neTMDnq4fhfyCNSmLoqGaVAT+jhUzj Mwk+x606rCzAOux+MRru0afuVtA4bMmuuIDiOtkSZ3NcYQz4hXQoTW1Ucv6ep1XISPtt Uoow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=kuR/XBZxQyVZ0Ryo9VcSArF4rPCsP57oMSxDA0wNA40=; b=i88Ygr/7VH7BYZZDOwY6SNO0lioy6SxkzJHD/3O+r7hRucrcSJYVe7LDJxYuEa5sLU xhL+Xn83gbI7wa/6zYkhEgHf90Rie+WFfNh9QPBADu3yGxKTVA9UuggAO6lsk8IFA/tB lH7MM3BTwMLxGYnW+vtsIuHXqfqpKUNNzyknkmY2RCgEGUY1dO/EBvF7nOGt+wNXXU6W i5dggOqE5BnPapEI/4LO1HD6NikKWpGzvaihfvbTWHOd8Gw6o+0vq8G4JIE8latriaL6 9plyTk7tOD5/oglUaqG+L2b17LKmk+3W/jtvfCbd1ml3ti70OzcLSvYrrDvdkLW/BMfn u/nw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id 45si6928034qtz.249.2017.10.18.10.00.55; Wed, 18 Oct 2017 10:00:55 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 7160D62DEC; Wed, 18 Oct 2017 17:00:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 3A8DD62DA1; Wed, 18 Oct 2017 17:00:33 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 656A162A92; Wed, 18 Oct 2017 17:00:23 +0000 (UTC) Received: from forward103j.mail.yandex.net (forward103j.mail.yandex.net [5.45.198.246]) by lists.linaro.org (Postfix) with ESMTPS id DC83C628C5 for ; Wed, 18 Oct 2017 17:00:18 +0000 (UTC) Received: from mxback11g.mail.yandex.net (mxback11g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:90]) by forward103j.mail.yandex.net (Yandex) with ESMTP id 780C434C27B3 for ; Wed, 18 Oct 2017 20:00:17 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback11g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 28shGmwFSM-0HNCpo3D; Wed, 18 Oct 2017 20:00:17 +0300 Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id y9Gipky45e-0HMSlUQ4; Wed, 18 Oct 2017 20:00:17 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Wed, 18 Oct 2017 20:00:06 +0300 Message-Id: <1508346006-5616-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1508346006-5616-1-git-send-email-odpbot@yandex.ru> References: <1508346006-5616-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 240 Subject: [lng-odp] [PATCH v1 1/1] linux-gen: pktio: ignore num_queues parameter if classifier enabled X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Maxim Uvarov Api defines statemet: "When classifier is enabled in odp_pktin_queue_config() this value is ignored, otherwise at least one queue is required." https://bugs.linaro.org/show_bug.cgi?id=3289 Signed-off-by: Maxim Uvarov --- /** Email created from pull request 240 (muvarov:master_bug3289) ** https://github.com/Linaro/odp/pull/240 ** Patch: https://github.com/Linaro/odp/pull/240.patch ** Base sha: ec0c3145fcafa09ae3a79875e7e07dd4794583cc ** Merge commit sha: 60bc1a69f6144605f6a6139d66169f911390a6a9 **/ platform/linux-generic/odp_packet_io.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_packet_io.c b/platform/linux-generic/odp_packet_io.c index 5cf94a146..2b6fceae5 100644 --- a/platform/linux-generic/odp_packet_io.c +++ b/platform/linux-generic/odp_packet_io.c @@ -1229,7 +1229,12 @@ int odp_pktin_queue_config(odp_pktio_t pktio, if (mode == ODP_PKTIN_MODE_DISABLED) return 0; - num_queues = param->num_queues; + if (param->classifier_enable) { + ODP_DBG("num_queues ignored if classifier is enabled\n"); + num_queues = 1; + } else { + num_queues = param->num_queues; + } if (num_queues == 0) { ODP_DBG("pktio %s: zero input queues\n", entry->s.name);