From patchwork Mon Oct 16 13:24:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 115916 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp3683300qgn; Mon, 16 Oct 2017 06:24:57 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDbx6GOIU/RH8pKmL5J3tXozHjNxQ/FDkIX4y/gKqZ0lJDImRjstfvNi3v87HJQ78EfdZyf X-Received: by 10.99.8.5 with SMTP id 5mr8230777pgi.28.1508160297445; Mon, 16 Oct 2017 06:24:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508160297; cv=none; d=google.com; s=arc-20160816; b=bPdrKhIpAentpQEu0LUtbonpifphWkrrKMm7C9XZjzgLTQbfsXdySDwtKCOCVYqN24 xYmsj31PqAzHcsMSUydZJSfw5CFuHxnhUuqy1Q4/1/rwIc8jZ6OkebXzLbybZUGOCIKF v74SgqZ+De05UdwNLvot0UvkTiJQjZu4uREma8erlhTs2/kebJ0M6OU2ag7mRenqoVRR 55yHGRrIpsMi9s7oh2nWSRiK9mwb/P7u0nicrZdbm/5Lb3Nvi8xXfk5l/6KOkjXn71vn t6NnRxS9KDPCkf5Hv4sizVXf+HrlR/TA3W3xSSPF1RgQyMgx8EmtOMBaVv+Hs75OTxPu 2wKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=si+kID9eleHMCb5YjXWaluugzW2xB0A6cEPymspFK6o=; b=cjMkC7fZw0LOAXxsEOahCmDFydu9XYFoQQ3JJr8zdVSv+NlWrA7I/mKyciV1Z1bEYD UPwhEJM9PjzduU4Wp7sGNrIpNjsFe95EchkGhS9QvCRqLEaudvjLhyMOstFURmP9pnEu KBbqvhR8W0buUlzeX6+IntZS6dpNZJj0ZkPXphLHjAUiutfKxBK9NM6qFV09P8y248q8 iRGSVC72kChobNA5gaePMrBBfpz4PbEW6hVT7OVgcZyR7SEeaCr7s/wSwyl0FHI6dBrt TrXOUURvAyc2dd8sMLyNPWJHJcyulNA4dA7Fr/BkHP1VWQ8N/AXuD7DGXQFe5/jSeIJU Wkpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si4392751pfl.429.2017.10.16.06.24.57; Mon, 16 Oct 2017 06:24:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753046AbdJPNY4 (ORCPT + 27 others); Mon, 16 Oct 2017 09:24:56 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:56914 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753024AbdJPNYv (ORCPT ); Mon, 16 Oct 2017 09:24:51 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 49189164F; Mon, 16 Oct 2017 06:24:51 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 110CF3F53D; Mon, 16 Oct 2017 06:24:48 -0700 (PDT) From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, adech.fo@gmail.com, aryabinin@virtuozzo.com, catalin.marinas@arm.com, christoffer.dall@linaro.org, dvyukov@google.com, linux-kbuild@vger.kernel.org, mark.rutland@arm.com, mark.zyngier@arm.com, mmarek@suse.com, will.deacon@arm.com, yamada.masahiro@socionext.com Subject: [PATCH 1/4] kbuild: allow global override of CC instrumentation Date: Mon, 16 Oct 2017 14:24:37 +0100 Message-Id: <20171016132440.38098-2-mark.rutland@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171016132440.38098-1-mark.rutland@arm.com> References: <20171016132440.38098-1-mark.rutland@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, we have a number of compiler instrumentation features, each with its own overrides to disable instrumentation of a file or directory. In a few cases, there are files with special ABI requirements, for which we need to avoid all instrumentation. Having to apply each override manually is tedious, and error-prone as new instrumentation features are introduced. To make matters easier, this patch adds a new CC_INSTRUMENT override, allowing instrumentation to be avoided for certain files or directories. This can also be overridden on a per-file or per-directory basis, to allow opting in to some instrumentation. Signed-off-by: Mark Rutland Cc: Andrey Konovalov Cc: Andrey Ryabinin Cc: Dmitry Vyukov Cc: Masahiro Yamada Cc: Michal Marek Cc: Will Deacon Cc: linux-kbuild@vger.kernel.org --- scripts/Makefile.lib | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) -- 2.11.0 Acked-by: Will Deacon diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 5e975fee0f5b..c7d71f482b57 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -109,6 +109,15 @@ orig_a_flags = $(KBUILD_CPPFLAGS) $(KBUILD_AFLAGS) $(KBUILD_SUBDIR_ASFLAGS) \ _a_flags = $(filter-out $(AFLAGS_REMOVE_$(basetarget).o), $(orig_a_flags)) _cpp_flags = $(KBUILD_CPPFLAGS) $(cppflags-y) $(CPPFLAGS_$(@F)) +# Each of the compiler instrumentation features below can be selectively +# enabled or disable for files or directoies. In decreasing order of +# predence, each option foo is controlled by: +# FOO_obj.o := [yn] +# CC_INSTRUMENT_obj.o := [yn] +# FOO := [yn] +# CC_INSTRUMENT := [yn] +# FOO_all := [yn] + # # Enable gcov profiling flags for a file, directory or for all files depending # on variables GCOV_PROFILE_obj.o, GCOV_PROFILE and CONFIG_GCOV_PROFILE_ALL @@ -116,7 +125,7 @@ _cpp_flags = $(KBUILD_CPPFLAGS) $(cppflags-y) $(CPPFLAGS_$(@F)) # ifeq ($(CONFIG_GCOV_KERNEL),y) _c_flags += $(if $(patsubst n%,, \ - $(GCOV_PROFILE_$(basetarget).o)$(GCOV_PROFILE)$(CONFIG_GCOV_PROFILE_ALL)), \ + $(GCOV_PROFILE_$(basetarget).o)$(CC_INSTRUMENT_$(basetarget).o)$(GCOV_PROFILE)$(CC_INSTRUMENT)$(CONFIG_GCOV_PROFILE_ALL)), \ $(CFLAGS_GCOV)) endif @@ -126,19 +135,19 @@ endif # ifeq ($(CONFIG_KASAN),y) _c_flags += $(if $(patsubst n%,, \ - $(KASAN_SANITIZE_$(basetarget).o)$(KASAN_SANITIZE)y), \ + $(KASAN_SANITIZE_$(basetarget).o)$(CC_INSTRUMENT_$(basetarget).o)$(KASAN_SANITIZE)$(CC_INSTRUMENT)y), \ $(CFLAGS_KASAN)) endif ifeq ($(CONFIG_UBSAN),y) _c_flags += $(if $(patsubst n%,, \ - $(UBSAN_SANITIZE_$(basetarget).o)$(UBSAN_SANITIZE)$(CONFIG_UBSAN_SANITIZE_ALL)), \ + $(UBSAN_SANITIZE_$(basetarget).o)$(CC_INSTRUMENT_$(basetarget).o)$(UBSAN_SANITIZE)$(CC_INSTRUMENT)$(CONFIG_UBSAN_SANITIZE_ALL)), \ $(CFLAGS_UBSAN)) endif ifeq ($(CONFIG_KCOV),y) _c_flags += $(if $(patsubst n%,, \ - $(KCOV_INSTRUMENT_$(basetarget).o)$(KCOV_INSTRUMENT)$(CONFIG_KCOV_INSTRUMENT_ALL)), \ + $(KCOV_INSTRUMENT_$(basetarget).o)$(CC_INSTRUMENT_$(basetarget).o)$(KCOV_INSTRUMENT)$(CC_INSTRUMENT)$(CONFIG_KCOV_INSTRUMENT_ALL)), \ $(CFLAGS_KCOV)) endif From patchwork Mon Oct 16 13:24:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 115917 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp3683378qgn; Mon, 16 Oct 2017 06:25:03 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCHh3m0bTMc7FsnGWP4QA38xHjFIo8HJUhB+R+AsC2MY7Ds1Tqt71U2igCokDQZh3ZhqzSw X-Received: by 10.98.158.66 with SMTP id s63mr8679080pfd.293.1508160303539; Mon, 16 Oct 2017 06:25:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508160303; cv=none; d=google.com; s=arc-20160816; b=yIDcOYIsI6RAimQ7DNUcT5u+4eoVkW+V4AkstrjivE9mj6TalVl+EVHF/HYqTklxA8 DOz43u9jZ7o3qSYNB8yorakKIHTxrRwx3SvYPLbftq4DSBTZoik5NJr7VjlOx+pWuSgy vcdlOH8aLz9jglWvBbrK1R9jNqqjGHcnIGMZRPxoB8f1wmNyXrTKsrhXNGgNOMt5lpu9 T53X02W3H2sB5CvP1AL8zsfD7Bw3+XDV9h8TtcV6QjMc2dGGRDxr2xEc++DERnjf6fGK AIaEUnmT526Krd5fYe0DRm2iuwGax8W1M8kRw98CeDkxplg9D+nHD5HbFWkOIHfOo47R oSvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=KJqLHUIk9vAmdVKxjTsAt0ngfbB7iv2R60vYp4cwVHo=; b=vhKaGxEESBn2lu36tv4PjA/cmHMJNell2q77zidvYQtuQ/Tvnz921hlVhBdL63Y0s3 9Z0TKOFZLGKVU8/TD81f4gdTO827bNxItwE+x6XjhhyH3rsBUS6xlKOP+6BNWbA7zfAL J9t1C21ZRVAw/uRZq6fZZpd61t5d1Sl3xAc8BjcscMipFz4hIJwqdvNf/GS5ccnj1Krz TZN71X6MYUGgjfEpGw0zpaMfhdjJPBhB2uuWErscINd3M56H3i7RzH7UQ7YeVpe0oKFN vMaGg86zEOoAmltmeM3/HnxkSJEIsHLkPF477ZCKGvKyvmuH+BIyJdVxb0cdpVgqYvCQ wsrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n19si4092776pgd.755.2017.10.16.06.25.03; Mon, 16 Oct 2017 06:25:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753069AbdJPNZB (ORCPT + 27 others); Mon, 16 Oct 2017 09:25:01 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:56942 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753048AbdJPNY5 (ORCPT ); Mon, 16 Oct 2017 09:24:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3815B165C; Mon, 16 Oct 2017 06:24:57 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0175A3F53D; Mon, 16 Oct 2017 06:24:54 -0700 (PDT) From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, adech.fo@gmail.com, aryabinin@virtuozzo.com, catalin.marinas@arm.com, christoffer.dall@linaro.org, dvyukov@google.com, linux-kbuild@vger.kernel.org, mark.rutland@arm.com, mark.zyngier@arm.com, mmarek@suse.com, will.deacon@arm.com, yamada.masahiro@socionext.com Subject: [PATCH 2/4] arm64: prevent instrumentation of LL/SC atomics Date: Mon, 16 Oct 2017 14:24:38 +0100 Message-Id: <20171016132440.38098-3-mark.rutland@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171016132440.38098-1-mark.rutland@arm.com> References: <20171016132440.38098-1-mark.rutland@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While we build the LL/SC atomics as a C object file, this does not follow the AAPCS. This does not interoperate with other C code, and can only be called from special wrapper assembly. Bulding a kernel with CONFIG_KCOV and CONFIG_ARM64_LSE_ATOMICS results in the cmopiler inserting calls to __sanitizer_cov_trace_pc within the LL/SC atomics. As __sanitizer_cov_trace_pc is built per the AAPCS, these calls corrupt register values, resulting in failures at boot time. Avoid this (and other similar issues) by opting out of all compiler instrumentation. We can opt-in to specific instrumentation in future if we want to. Signed-off-by: Mark Rutland Cc: Catalin Marinas Cc: Will Deacon --- arch/arm64/lib/Makefile | 1 + 1 file changed, 1 insertion(+) -- 2.11.0 diff --git a/arch/arm64/lib/Makefile b/arch/arm64/lib/Makefile index a0abc142c92b..af77516f71b2 100644 --- a/arch/arm64/lib/Makefile +++ b/arch/arm64/lib/Makefile @@ -17,5 +17,6 @@ CFLAGS_atomic_ll_sc.o := -fcall-used-x0 -ffixed-x1 -ffixed-x2 \ -fcall-saved-x10 -fcall-saved-x11 -fcall-saved-x12 \ -fcall-saved-x13 -fcall-saved-x14 -fcall-saved-x15 \ -fcall-saved-x18 +CC_INSTRUMENT_atomic_ll_sc.o := n lib-$(CONFIG_ARCH_HAS_UACCESS_FLUSHCACHE) += uaccess_flushcache.o From patchwork Mon Oct 16 13:24:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 115918 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp3683403qgn; Mon, 16 Oct 2017 06:25:04 -0700 (PDT) X-Google-Smtp-Source: AOwi7QA2kR01IHa19Dtz5weK+2AiobhVS9q7eIZoz6YKmzz9rIhnxsc8yPWiJrJ5jZVQErTiRpdh X-Received: by 10.98.87.74 with SMTP id l71mr8808059pfb.204.1508160304575; Mon, 16 Oct 2017 06:25:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508160304; cv=none; d=google.com; s=arc-20160816; b=C5qN0lTUK0RfxalZxLX1nMDBH7BqGe4GTtGyf3Ns3dy0my3aAVe3S9pdIVrnkDO2Vt LUcvXBrAYl7IuI+UiAOu+483M5XndnSlJ08f0PiIukjT0/ec5RvHO6F62S5AigwV0aB1 7VDvt57xx424OrbjranEbxAmFl6IBDdpTPtMczSLPR/RnRyZ5RC074tdkevfSxMmnsJq GpKPmEras0SIGOKIIEQdO11JhnFw0pVAYnMbjEHKeEK4/qcm13y0ZgworuIULpp4jsKT iOBTYbsONh6NhR/Q22ZGGju1bBem+uX5rHZeiofboMbzRzT1qU3Dxyhpz/+x5BI2QE9g rygw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=bhkPgZSCqJ4DwMv+2sZFZOJBU3dpngJ12tCTBXUYpGo=; b=UM0FA4u1/yMZ2Q2Xs0amFs95yql6rINuHehKPpOMc1HsdKI5OD+iauSI1hWmqUjrem jQoQIQzXr0gW0jVevtwHJYJx2GiIBfjxnNkRWQ2lt7/O7QWWZd2hYLehHY1gTH6it5NJ Qfj4qUJ3aisOM3sfSf4MfaWdjfku43cTJnu8IMQMUtAKvBgbuTDQR3ORvUy46zLJf9ha HlEhWOtFdy+OEwm/yPSOJPg91ko2FpmMHduxkFIpKOHwYBihJenaS34uMUmJ7zIhzwef 4Cncdhmja806BY4aBwdqnPSbgRumZH1a/FE50WXu5+ftckfd3497osRqfKApS4Wt+b4/ 8Oqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n19si4092776pgd.755.2017.10.16.06.25.04; Mon, 16 Oct 2017 06:25:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753086AbdJPNZD (ORCPT + 27 others); Mon, 16 Oct 2017 09:25:03 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:56948 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753066AbdJPNZB (ORCPT ); Mon, 16 Oct 2017 09:25:01 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EABF81684; Mon, 16 Oct 2017 06:25:00 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AB72D3F53D; Mon, 16 Oct 2017 06:24:58 -0700 (PDT) From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, adech.fo@gmail.com, aryabinin@virtuozzo.com, catalin.marinas@arm.com, christoffer.dall@linaro.org, dvyukov@google.com, linux-kbuild@vger.kernel.org, mark.rutland@arm.com, mark.zyngier@arm.com, mmarek@suse.com, will.deacon@arm.com, yamada.masahiro@socionext.com Subject: [PATCH 3/4] kvm/arm64: simplify CC instrumentation opt-out Date: Mon, 16 Oct 2017 14:24:39 +0100 Message-Id: <20171016132440.38098-4-mark.rutland@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171016132440.38098-1-mark.rutland@arm.com> References: <20171016132440.38098-1-mark.rutland@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that we can opt out of all instrumentation with a single option, make use of this in the KVM hyp code. Hopefully, this will also avoid fragility as new options are introduced. Signed-off-by: Mark Rutland Cc: Catalin Marinas Cc: Christoffer Dall Cc: Marc Zyngier Cc: Will Deacon --- arch/arm64/kvm/hyp/Makefile | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.11.0 Acked-by: Christoffer Dall diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile index 14c4e3b14bcb..a8a212eb66f1 100644 --- a/arch/arm64/kvm/hyp/Makefile +++ b/arch/arm64/kvm/hyp/Makefile @@ -22,7 +22,4 @@ obj-$(CONFIG_KVM_ARM_HOST) += s2-setup.o # KVM code is run at a different exception code with a different map, so # compiler instrumentation that inserts callbacks or checks into the code may # cause crashes. Just disable it. -GCOV_PROFILE := n -KASAN_SANITIZE := n -UBSAN_SANITIZE := n -KCOV_INSTRUMENT := n +CC_INSTRUMENT := n From patchwork Mon Oct 16 13:24:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 115919 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp3683487qgn; Mon, 16 Oct 2017 06:25:10 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDUrhTiODRWrbGu3zGOzSFD43szjaAd2Eo4rWyJI2LM1XVp7b/C1z3ZtwTc/qQMC/kExpTo X-Received: by 10.84.176.100 with SMTP id u91mr9197323plb.10.1508160310623; Mon, 16 Oct 2017 06:25:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508160310; cv=none; d=google.com; s=arc-20160816; b=PhMJCHlpOnPsqChxdP4c6lYqnGPa3wb1liZUnL0lEylLxCfYZ2w8W1BLj7YJFf5e5Q Lzbtu0dL13rZ9cWY0cyKgtb7H4ZxMgOcH7ga4NR3xEUBPq5vZSXCpIMr1PnIJ4A734Wl XSIvjogDrSmD6QuMZ4+Vr/bjzFDx2/qtdeJy+HGkNkmM1tXYxS1mQ3NVcZeK5Hto3a6r JGJrIkBKzp22OfB1lpvmsN24z+AyJzZ92lBiZhAPjJ6Umt3OC+Cxj4bsvS+8ov3KkzFj 2yvZIPZFGz7SY+M3yxLrcAL2D/Ol49rn1v8D6xwAotgz7RMcY8Ch+jI2z7O0aGSDN2sr mAZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=4tZaABhuGOfaHxwHEVp1dAmKmXHXky6oYatnw8Lt2zA=; b=ihgQT6+jDcmiAfABohGyGj+LYkqS/aMMmieNcrWId3UFQP0JyFr5BWwJP0+Wtp+b5z LEWsMWOfanlmRQatA/I1AvfovT7NgZTiRUl4IIlf20FgiSEVoBTbLvmQbLWuuGqCYIOx QaMJJPnykvYeKMFh1hg+MdIXe9rJ3FwmomxgVQtDvYHbDdzMn557qRAbfv8VctfnmTtx B51UZ1WJoqwraZk1f2qkSVABs0RdtRg15JoTAdr4pZstN6B1RgPSP299EserQ/w8ob3J ij2zlMBvZOgwzPg6YbyKzCMO8UiPf+L9o6HeZwRq2ByfoCnU/DrXkNHb5ELW0vUYW8Cw mKeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n19si4092776pgd.755.2017.10.16.06.25.10; Mon, 16 Oct 2017 06:25:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753108AbdJPNZH (ORCPT + 27 others); Mon, 16 Oct 2017 09:25:07 -0400 Received: from foss.arm.com ([217.140.101.70]:56968 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbdJPNZF (ORCPT ); Mon, 16 Oct 2017 09:25:05 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50821169E; Mon, 16 Oct 2017 06:25:05 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 110883F53D; Mon, 16 Oct 2017 06:25:02 -0700 (PDT) From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, adech.fo@gmail.com, aryabinin@virtuozzo.com, catalin.marinas@arm.com, christoffer.dall@linaro.org, dvyukov@google.com, linux-kbuild@vger.kernel.org, mark.rutland@arm.com, mark.zyngier@arm.com, mmarek@suse.com, will.deacon@arm.com, yamada.masahiro@socionext.com Subject: [PATCH 4/4] arm64: vdso: remove pointless gcov option Date: Mon, 16 Oct 2017 14:24:40 +0100 Message-Id: <20171016132440.38098-5-mark.rutland@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171016132440.38098-1-mark.rutland@arm.com> References: <20171016132440.38098-1-mark.rutland@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The arm64 VDSO Makefile explicitly disables gcov; a practice we seem to have inherited from other VDSO Makefiles. The arm64 VDSO is written entirely in assembly, so this is not necessary. Further, if the VDSO were written in C it would be necessary to disable all other instrumentation, and this alone would not be sufficient. This patch remosves the redundant GCOV option for now. Cc: Catalin Marinas Reported-by: Will Deacon Signed-off-by: Mark Rutland --- arch/arm64/kernel/vdso/Makefile | 3 --- 1 file changed, 3 deletions(-) -- 2.11.0 diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile index 62c84f7cb01b..350190b749dd 100644 --- a/arch/arm64/kernel/vdso/Makefile +++ b/arch/arm64/kernel/vdso/Makefile @@ -15,9 +15,6 @@ ccflags-y := -shared -fno-common -fno-builtin ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \ $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) -# Disable gcov profiling for VDSO code -GCOV_PROFILE := n - # Workaround for bare-metal (ELF) toolchains that neglect to pass -shared # down to collect2, resulting in silent corruption of the vDSO image. ccflags-y += -Wl,-shared