From patchwork Wed Sep 30 20:01:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Pandit-Subedi X-Patchwork-Id: 252633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42A29C4727E for ; Wed, 30 Sep 2020 20:01:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E939120739 for ; Wed, 30 Sep 2020 20:01:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="m4W9sJpp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730357AbgI3UBt (ORCPT ); Wed, 30 Sep 2020 16:01:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730276AbgI3UBp (ORCPT ); Wed, 30 Sep 2020 16:01:45 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF32EC0613D0 for ; Wed, 30 Sep 2020 13:01:45 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id b124so1918873pfg.13 for ; Wed, 30 Sep 2020 13:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0yd6l4FulTeamGjzLY1tF0TQenwZuapAs4XC6TJqnsI=; b=m4W9sJpp/0kJj76A36B+GEkq0kcB6lzObEAEWV9HgmqYP5Z4FSXlp//IVN6jAsyni3 yX3uCp7Xr+AvTwLF1NwXvQULbnanZ1ehU82eBky0+babTwllriyZ/QjJbDoj85LNvQOc R26G+QOyY5sDEaG9uqsQExuJ//Iw4vQBHAL6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0yd6l4FulTeamGjzLY1tF0TQenwZuapAs4XC6TJqnsI=; b=ecoZIAWMSdeGcCKTQg1c8no0DaxOXUIn44+kDWqPamnUxfZuOKXKnkUsIsgn+EOR93 u+JlFd8+MX1d/MuzAVs7QMynpeBfuVxCFxZgadvujJ/piysfD0sUIoIBBOdpsza7X2YM Tibbw5d6nVfgrmq3MT2kT/pLI4doWmiv9TOAhuZPF11U35MGkAmBqfEaMqRgJkFJaErZ wWQcAb64v/MSmFy09OOAhrb+YNesYzxLOJ601GeWiPfc8YKf7NHNfmvMjrwTnasV2oln xARABjlKYq3CFNvcuxZTo3xP11/2ubdKx+6qlOBlAwosrd240UEWCVVdXzyQYI+wR9vg thhw== X-Gm-Message-State: AOAM532DygJcYmgBIMwNVNDBT31FAKCF8qyaITeq9+fmQVEnfEEy6PQd ODwRmW5/jWJYsLxOfMdQUS+KOQ== X-Google-Smtp-Source: ABdhPJzAUKYXF1dekvreSmIR1ZdIcd3TMlw2eUoM1hHVFsTCtHW2Jrsu0mXZBjl40aJa0CFSqCWMLg== X-Received: by 2002:a63:1657:: with SMTP id 23mr3522143pgw.168.1601496105262; Wed, 30 Sep 2020 13:01:45 -0700 (PDT) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:7220:84ff:fe09:2b94]) by smtp.gmail.com with ESMTPSA id 75sm2998874pgg.22.2020.09.30.13.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 13:01:44 -0700 (PDT) From: Abhishek Pandit-Subedi To: marcel@holtmann.org Cc: chromeos-bluetooth-upstreaming@chromium.org, linux-bluetooth@vger.kernel.org, Abhishek Pandit-Subedi , Johan Hedberg , linux-kernel@vger.kernel.org Subject: [PATCH] Bluetooth: btqca: Add valid le states quirk Date: Wed, 30 Sep 2020 13:01:38 -0700 Message-Id: <20200930130108.1.Iaa2fcfb9b4fbfe4b4887464a6b4f12ac4b831c84@changeid> X-Mailer: git-send-email 2.28.0.709.gb0816b6eb0-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org WCN3991 supports connectable advertisements so we need to add the valid le states quirk so the 'central-peripheral' role is exposed in userspace. Signed-off-by: Abhishek Pandit-Subedi --- Example result showing the central-peripheral role correctly. localhost # bluetoothctl show Controller 3C:28:6D:4F:A0:1F (public) Name: BlueZ 5.54 Alias: Chromebook_63FC Class: 0x00480000 Powered: yes Discoverable: no DiscoverableTimeout: 0x000000b4 Pairable: yes UUID: A/V Remote Control (0000110e-0000-1000-8000-00805f9b34fb) UUID: Audio Source (0000110a-0000-1000-8000-00805f9b34fb) UUID: Handsfree Audio Gateway (0000111f-0000-1000-8000-00805f9b34fb) UUID: PnP Information (00001200-0000-1000-8000-00805f9b34fb) UUID: A/V Remote Control Target (0000110c-0000-1000-8000-00805f9b34fb) UUID: Generic Access Profile (00001800-0000-1000-8000-00805f9b34fb) UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb) UUID: Device Information (0000180a-0000-1000-8000-00805f9b34fb) Modalias: bluetooth:v00E0pC405d0057 Discovering: no Roles: central Roles: peripheral Roles: central-peripheral drivers/bluetooth/hci_qca.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 244b8feba52327..2d3f1f179a1e3d 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -78,6 +78,7 @@ enum qca_flags { enum qca_capabilities { QCA_CAP_WIDEBAND_SPEECH = BIT(0), + QCA_CAP_VALID_LE_STATES = BIT(1), }; /* HCI_IBS transmit side sleep protocol states */ @@ -1780,7 +1781,7 @@ static const struct qca_device_data qca_soc_data_wcn3991 = { { "vddch0", 450000 }, }, .num_vregs = 4, - .capabilities = QCA_CAP_WIDEBAND_SPEECH, + .capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES, }; static const struct qca_device_data qca_soc_data_wcn3998 = { @@ -2017,11 +2018,17 @@ static int qca_serdev_probe(struct serdev_device *serdev) hdev->shutdown = qca_power_off; } - /* Wideband speech support must be set per driver since it can't be - * queried via hci. - */ - if (data && (data->capabilities & QCA_CAP_WIDEBAND_SPEECH)) - set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks); + if (data) { + /* Wideband speech support must be set per driver since it can't + * be queried via hci. Same with the valid le states quirk. + */ + if (data->capabilities & QCA_CAP_WIDEBAND_SPEECH) + set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, + &hdev->quirks); + + if (data->capabilities & QCA_CAP_VALID_LE_STATES) + set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks); + } return 0; }