From patchwork Mon Sep 21 07:43:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loic Poulain X-Patchwork-Id: 292742 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7715CC43464 for ; Mon, 21 Sep 2020 07:37:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3318420719 for ; Mon, 21 Sep 2020 07:37:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eg8GQYRb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726328AbgIUHhR (ORCPT ); Mon, 21 Sep 2020 03:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbgIUHhR (ORCPT ); Mon, 21 Sep 2020 03:37:17 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38F54C061755 for ; Mon, 21 Sep 2020 00:37:17 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id s12so11576049wrw.11 for ; Mon, 21 Sep 2020 00:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=N3NUdo+DwpnJaRzbu3ClRmdDKBhnsZkqlLToVcKy1Wc=; b=eg8GQYRbCOsZtUi5Kl4zm67GzO6te2SL2d9mOpZjX8lyadDMcRNo7fsDUDxV+wuDn9 g0SzdglOGxuZsxrznxn1Ie0mOkNaFParV0nhuGit5gHihKOU/n3H6q7Z6cqFIiAhpeSv wATs5JLfIUeSRNqdp4nDLCEEZQrc7H4i4lIfJrNBioqkumKHCqN56zv1jDAvKh5UkJv3 VdHHHiC2Yn5osWzJCAs5i+rzGO/vxe3pzwuFOB5HN8jdimyldYmxDRgje5U5OcMqq682 1gPyoX/TIOUh9Mb7I5IlA9iY0fGkLkNtASlHso4VYJKmoxNu5uAwiMeeeB54lXvtZZ+R oCxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=N3NUdo+DwpnJaRzbu3ClRmdDKBhnsZkqlLToVcKy1Wc=; b=Xd8u6uCJC/+AoKBrM1sGD+Q5YT8fzCbFC3nLoS0z4zWN8/1iNzDlGyKIxbDV8CxlUw 2UiVEJpwcjKTYGeJF9GLJs8qBPs6MmIbiaUqLF06gphV4RloPoEVok515F4sxSyVF1h1 uYhdOP0Uioq4PJ5Ju0YRoX1PCxxBClldnvYakND10gfeEDbSja+v1vdWLz7zgIrQUw+v 2naiKJRl9wJxb/UkGzYyRR2gkrJDOjaFhpGgokldpuA7ikZDdQoAMKphveCtbDr6CHSq CMKE1ksd+9qM7LdQ/d1s/yM9//babqDEWUIq7tOGyy3kDRgcUUbzL2AE17zSWueVsE1I NvSQ== X-Gm-Message-State: AOAM532arac7S+i9DThdR/IKdEVaxGoGi6bmUyBXxWlGmk0nkoTdzLnF EpHYHhNTghrUJpJaGVBL63/Fs20bZ2anDA== X-Google-Smtp-Source: ABdhPJzdhBhEeyzI9dWn6DZf412QQCk747FGLZw6+1cXqj1V/SmzBVdPTBP2oQPlXeeU7j+jmhA19w== X-Received: by 2002:adf:f10a:: with SMTP id r10mr48960861wro.86.1600673835750; Mon, 21 Sep 2020 00:37:15 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:490:8730:5875:9da3:b857:e7f4]) by smtp.gmail.com with ESMTPSA id v9sm19976761wrv.35.2020.09.21.00.37.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2020 00:37:14 -0700 (PDT) From: Loic Poulain To: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, Loic Poulain Subject: [PATCH v2 1/2] bus: mhi: Remove auto-start option Date: Mon, 21 Sep 2020 09:43:03 +0200 Message-Id: <1600674184-3537-1-git-send-email-loic.poulain@linaro.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org There is really no point having an auto-start for channels. This is confusing for the device drivers, some have to enable the channels, others don't have... and waste resources (e.g. pre allocated buffers) that may never be used. This is really up to the MHI device(channel) driver to manage the state of its channels. Signed-off-by: Loic Poulain Reviewed-by: Manivannan Sadhasivam --- v2: split MHI and qrtr changes in dedicated commits drivers/bus/mhi/core/init.c | 9 --------- drivers/bus/mhi/core/internal.h | 1 - include/linux/mhi.h | 2 -- 3 files changed, 12 deletions(-) diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c index dccc824..8798deb 100644 --- a/drivers/bus/mhi/core/init.c +++ b/drivers/bus/mhi/core/init.c @@ -721,7 +721,6 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl, mhi_chan->offload_ch = ch_cfg->offload_channel; mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch; mhi_chan->pre_alloc = ch_cfg->auto_queue; - mhi_chan->auto_start = ch_cfg->auto_start; /* * If MHI host allocates buffers, then the channel direction @@ -1119,11 +1118,6 @@ static int mhi_driver_probe(struct device *dev) goto exit_probe; ul_chan->xfer_cb = mhi_drv->ul_xfer_cb; - if (ul_chan->auto_start) { - ret = mhi_prepare_channel(mhi_cntrl, ul_chan); - if (ret) - goto exit_probe; - } } ret = -EINVAL; @@ -1157,9 +1151,6 @@ static int mhi_driver_probe(struct device *dev) if (ret) goto exit_probe; - if (dl_chan && dl_chan->auto_start) - mhi_prepare_channel(mhi_cntrl, dl_chan); - mhi_device_put(mhi_dev); return ret; diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h index 5a81a42..73b52a0 100644 --- a/drivers/bus/mhi/core/internal.h +++ b/drivers/bus/mhi/core/internal.h @@ -563,7 +563,6 @@ struct mhi_chan { bool configured; bool offload_ch; bool pre_alloc; - bool auto_start; bool wake_capable; }; diff --git a/include/linux/mhi.h b/include/linux/mhi.h index 811e686..0d277c7 100644 --- a/include/linux/mhi.h +++ b/include/linux/mhi.h @@ -214,7 +214,6 @@ enum mhi_db_brst_mode { * @offload_channel: The client manages the channel completely * @doorbell_mode_switch: Channel switches to doorbell mode on M0 transition * @auto_queue: Framework will automatically queue buffers for DL traffic - * @auto_start: Automatically start (open) this channel * @wake-capable: Channel capable of waking up the system */ struct mhi_channel_config { @@ -232,7 +231,6 @@ struct mhi_channel_config { bool offload_channel; bool doorbell_mode_switch; bool auto_queue; - bool auto_start; bool wake_capable; }; From patchwork Mon Sep 21 07:43:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loic Poulain X-Patchwork-Id: 250143 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C873EC43464 for ; Mon, 21 Sep 2020 07:37:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F1F82158C for ; Mon, 21 Sep 2020 07:37:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sUQGXw3W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726324AbgIUHhX (ORCPT ); Mon, 21 Sep 2020 03:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726318AbgIUHhT (ORCPT ); Mon, 21 Sep 2020 03:37:19 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F056DC061755 for ; Mon, 21 Sep 2020 00:37:18 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id x14so11565083wrl.12 for ; Mon, 21 Sep 2020 00:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NROX0bNqDI7FiJUF4YVflXDepbR7cwfa195+TAp7FqI=; b=sUQGXw3W8ui6W7UW369yPnoa8QnsVfzpFzRk+yz8aIrOp3Tmms9uqhuYD7DfokVb/L osUVCqbl+aTyxWJWIEOs5Y0vwjvEbawxdlFktY7qVaTnsz3d+ZxxEecwnNkbf4j31sOw AHY7pQyCucaxwt9rPcnG12nT/LfdqDV6Rzn4NAMZZxlkLispA+gqm333Ej79LNMAG8RV 6YAYWKk5tbRWGqhS1c+uyfGn72Iq3++pzCRNSDwb46pkKw4aCyPIMHu6NypP7o+Cllh2 F96YHK98ncy3AZ/fOMaUBP8OGausbuY5jiAJ3Y/jWeMxfaHuYGmWpGZSvqmni6807C8M U0hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NROX0bNqDI7FiJUF4YVflXDepbR7cwfa195+TAp7FqI=; b=QOloGY/iouskQUtN7m5FlqRBjm+uoMqdVnnCglBG/Ryw6WXZ12+k7LudlPKcfXO5Ik E81XZuA3hSRibuzeBm+T+tYgtUezb/dViJBrkLfr2zeEsQgC+GD3dFW6c7xhtTV0tftw suDVhc9deK2b8UTH4QFUKP2FdevBbbjeb2ZWIKNTuQ+1rsb9LEGjgps5hTBp815UPOsr M8mR1EOIBTER80fU29vkE6JaDbeiN81kSWIZPYNjO6HpF5Woi1lWMt31aWp43Ls4VbHl XJJvlO3h+S1HTebsCnuKKD07wBd5AWdBWUbVqOCJoP9o0zVljxExHfYiEoIEzeDKXy4G nnTQ== X-Gm-Message-State: AOAM532W3kotqo/1z0c9NH2vAbAuPiDfCXaYrSW6P7V68rFBwEOK687Q jL6QkEmkYZJfemr0mFbAbYboKA== X-Google-Smtp-Source: ABdhPJyUkazSF0v/Gm+h2UP/98/PEaQBIlc5UJ6gJvjQmbcaVK8BZGumzpDTykPTQpPOH3TP4MyNoQ== X-Received: by 2002:adf:ee8d:: with SMTP id b13mr55137256wro.249.1600673837648; Mon, 21 Sep 2020 00:37:17 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:490:8730:5875:9da3:b857:e7f4]) by smtp.gmail.com with ESMTPSA id v9sm19976761wrv.35.2020.09.21.00.37.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2020 00:37:17 -0700 (PDT) From: Loic Poulain To: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, Loic Poulain Subject: [PATCH v2 2/2] net: qrtr: Start MHI channels during init Date: Mon, 21 Sep 2020 09:43:04 +0200 Message-Id: <1600674184-3537-2-git-send-email-loic.poulain@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1600674184-3537-1-git-send-email-loic.poulain@linaro.org> References: <1600674184-3537-1-git-send-email-loic.poulain@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Start MHI device channels so that transfers can be performed. The MHI stack does not auto-start channels anymore. Signed-off-by: Loic Poulain Reviewed-by: Manivannan Sadhasivam Acked-by: David S. Miller --- v2: split MHI and qrtr changes in dedicated commits net/qrtr/mhi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c index ff0c414..7100f0b 100644 --- a/net/qrtr/mhi.c +++ b/net/qrtr/mhi.c @@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev, struct qrtr_mhi_dev *qdev; int rc; + /* start channels */ + rc = mhi_prepare_for_transfer(mhi_dev); + if (rc) + return rc; + qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL); if (!qdev) return -ENOMEM;