From patchwork Tue Sep 8 18:25:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249346 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp4792245ilg; Tue, 8 Sep 2020 11:25:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7xqIoAzlXgirZbBr7RS2Q7IkmmjT29fitJ42C3dJetTSn2cUZMZUEyvkixhwilr7J+FUG X-Received: by 2002:a92:4001:: with SMTP id n1mr38224ila.69.1599589513809; Tue, 08 Sep 2020 11:25:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599589513; cv=none; d=google.com; s=arc-20160816; b=Q9pah3svuio1Q3Hp5ce0MUJ/NiJwBpwTbVgjlkf5jl/YbBOFKKUkMmQP9+ELpXnipU wliOJrecM9PlYDmcjWfSHcCCxik/TFKL5gvBUpsSrg/ulAJ6enWl3Mi0NNrEsElEg0xg Fxs0LMt7DepWySVuwVFjYNtFaOPlqp1N8QfagXZfooDQ2Dqn84DjPHiFgqKDTZObsfNu 35GWHyF4RcCTWMLsz+Mm7soPXenaP8JGh+SQc9jYCkCJ3XvjeFWpTBMUsH+Y9DUGcIQa U4Ndpp7IP7+8c87OYlgrg/Vx68NnRS7+Jgd5S0YIBNP4GZrAYmjxGeMF06G9E1SeJ5IJ yBag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=akv0ewQhb/gCQ1sEkREjHfjQgm4366CZK+SM8MEtzB0=; b=z0viVhbxaswSob0TEvmhKWQx6KVvdDffUsIJLztqCdcpAT3L6hUZZEN5F1XLIbNqYp vnLEQjEDZWNwPK39qr754+B2WKo73Pth8RnsR/99jDuEmZGdieoGK7WeLUIzEHb7RqFl CoofsyLqR8M6pfALPstS1rrnuO844twQPe3Jcy+moAg7aoIu2VxwYg6YvLmk70nbYnHk /1OTKoVapH6QqugWOIIa7OrVPDZ+pREZ1fnn/sWaEvrgkkJDB+9/J/Yxm5S5pVyLC4AY i0E/kYpQb3okKT8QuCvtVFSbIEx0q5tUy9iaCIxODS4wLzMD5cPzO/fVldUZ3MbvrGEf +WiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=eg7wqtrO; dkim=neutral (body hash did not verify) header.i=@nexus-software-ie.20150623.gappssmtp.com header.s=20150623 header.b=CyNel8Fr; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id n2si126945iox.11.2020.09.08.11.25.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:25:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=eg7wqtrO; dkim=neutral (body hash did not verify) header.i=@nexus-software-ie.20150623.gappssmtp.com header.s=20150623 header.b=CyNel8Fr; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=akv0ewQhb/gCQ1sEkREjHfjQgm4366CZK+SM8MEtzB0=; b=eg7wqtrOf6NkOH9gpWA4Myj9N lLiVzTUdhUCLGe9vqldugC40HRjKGHOVCvDHoYYvd8kY2WXFgVTmkhKEL4g/nJV+oFSc+F1PjxNth xDLb+MrN5J6GMHBVx3KfO0lvKN8a61/DVGUExh5mGent8TcfCJVl9J2J6a2Xu0Zi4h3oaI+fD7tQs Nl+am4ItwA/+4/si8vVBjAvVRZhFebwwTAtx2SGqXLJHr7yiGVLOh0VbyA20sQ6iz1pljbaB0rKI0 xwrcFg8AjNdeJxDehxnkmOBiG5D39m0VtAr0zDnaAgIcxTseRC2hwNBMr2+2R7/hHO3hKFwBfY66F RtPX830Eg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiIo-0005ai-5X; Tue, 08 Sep 2020 18:25:10 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiIl-0005Yw-OF for wcn36xx@lists.infradead.org; Tue, 08 Sep 2020 18:25:08 +0000 Received: by mail-wm1-x343.google.com with SMTP id k18so294291wmj.5 for ; Tue, 08 Sep 2020 11:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DAf97sptdgLCg/oA6L8vy5HwNzKTVCMj55H39bkxfx4=; b=CyNel8Fr0KQA8GWBzuf0PVqYs0SJ7zHsWSGVXSRDMAc4/i+rzHkGlDe+VdMywSFxRw JiBVorsUnAw33nkk6rf536t8cDBWD3oksA/Og6oEYudkAitMrJP0y0FcbGuaB6lbpL94 L62nO8Jhb/KhxanIsc8OqyEtOPsza4BQ9U3X69Rv+ScOll72RP0lDmutDzRjtFQRvgpD c+RlljaF7oGLSCUzgawbNreV3/6GhlBRE/nI46Wm3SaW1/ICh9UZwG5DC4egTSDrAFRl gqgujj4gWqQkf8Th1o/8Ff1l+CalNoAf3mTitYjurzC6G1yEAFom4VgeSz6IcZ3/+tT2 /wTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DAf97sptdgLCg/oA6L8vy5HwNzKTVCMj55H39bkxfx4=; b=FFxmnhtSl98q6hkBM+KyDAa4fz0006k15nVkglMjhvlM808imRJJxCq7lFtnZ9kGZQ SsvfxZ97rpnu1pFBf/rt7VUB6/B1TMS+THRy5LhVU96Y7SEZEcAaC1+ONtbwKol/Nskx XM0vLkr7vUP+FaDjDM3lduP+nkllBhF8w7d234eM3+CrmB7KMVCXk7yuO2urVgCHFCev AI8lviuvpCPCZH5FzwRKcRmTyZeBFJIFLtl6X/zGQbp1wMA3ITyV+sRQhmEeXjsViKbF 1pXqE7LJsga5s0cO9vk64t4uUJuUxY7QjNYrNGBwaON3E7c97bhiehIKnKZf6wJ8hVGi +ffw== X-Gm-Message-State: AOAM532Nfgs5hXgs5B/jd3maCsXdX8MLK6umoHXio/bBYbFhMZjiVokb x2vdaCkAYMaOGxYRh/9GqqmHzA== X-Received: by 2002:a1c:dd45:: with SMTP id u66mr369833wmg.117.1599589506833; Tue, 08 Sep 2020 11:25:06 -0700 (PDT) Received: from localhost.localdomain ([176.61.57.127]) by smtp.gmail.com with ESMTPSA id c18sm376908wrx.63.2020.09.08.11.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:25:06 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v3 1/2] wcn36xx: Mark internal smd functions static Date: Tue, 8 Sep 2020 19:25:52 +0100 Message-Id: <20200908182553.2870585-2-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200908182553.2870585-1-pure.logic@nexus-software.ie> References: <20200908182553.2870585-1-pure.logic@nexus-software.ie> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_142507_816289_FACCFBF4 X-CRM114-Status: GOOD ( 15.70 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org From: Bryan O'Donoghue This commit marks all smd.c functions that are only used inside of smd.c as static. Previous commits added some VHT specific setup functions non-static which is the right thing to do in terms of having granular git commits that compile warning free. What we really want is for local not global scope on those functions. This patch makes the conversion from global to local scope. Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/smd.c | 34 ++++++++++++++------------ 1 file changed, 18 insertions(+), 16 deletions(-) -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index ac10789332d8..a8d2af74ef62 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -80,7 +80,7 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] = { WCN36XX_CFG_VAL(ENABLE_DYNAMIC_RA_START_RATE, 133), /* MCS 5 */ }; -struct wcn36xx_cfg_val wcn3680_cfg_vals[] = { +static struct wcn36xx_cfg_val wcn3680_cfg_vals[] = { WCN36XX_CFG_VAL(CURRENT_TX_ANTENNA, 1), WCN36XX_CFG_VAL(CURRENT_RX_ANTENNA, 1), WCN36XX_CFG_VAL(LOW_GAIN_OVERRIDE, 0), @@ -242,7 +242,7 @@ static void wcn36xx_smd_set_bss_ht_params(struct ieee80211_vif *vif, } } -void +static void wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif, struct ieee80211_sta *sta, struct wcn36xx_hal_config_bss_params_v1 *bss) @@ -279,7 +279,7 @@ static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta, } } -void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, struct ieee80211_sta *sta, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { @@ -299,7 +299,7 @@ void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, } } -void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta, +static void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (sta->ht_cap.ht_supported) { @@ -324,7 +324,7 @@ static void wcn36xx_smd_set_sta_default_ht_params( sta_params->dsss_cck_mode_40mhz = 1; } -void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (wcn->rf_id == RF_IRIS_WCN3680) { @@ -340,7 +340,7 @@ void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, sta_params->vht_tx_bf_enabled = 0; } -void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (wcn->rf_id == RF_IRIS_WCN3680) @@ -1361,7 +1361,7 @@ static void wcn36xx_smd_convert_sta_to_v1(struct wcn36xx *wcn, v1->p2p = orig->p2p; } -void +static void wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn, struct ieee80211_vif *vif, struct ieee80211_sta *sta, @@ -1500,12 +1500,12 @@ int wcn36xx_smd_config_sta(struct wcn36xx *wcn, struct ieee80211_vif *vif, return ret; } -void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn, - struct ieee80211_vif *vif, - struct ieee80211_sta *sta, - const u8 *bssid, - bool update, - struct wcn36xx_hal_config_bss_params *bss) +static void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + const u8 *bssid, + bool update, + struct wcn36xx_hal_config_bss_params *bss) { struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif); struct wcn36xx_hal_config_sta_params *sta_params; @@ -1713,9 +1713,11 @@ static int wcn36xx_smd_config_bss_v1(struct wcn36xx *wcn, return ret; } -int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, struct ieee80211_vif *vif, - struct ieee80211_sta *sta, const u8 *bssid, - bool update) +static int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + const u8 *bssid, + bool update) { struct wcn36xx_hal_config_bss_req_msg *msg; struct wcn36xx_hal_config_bss_params *bss; From patchwork Tue Sep 8 18:25:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249347 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp4792254ilg; Tue, 8 Sep 2020 11:25:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzo0SLwk3vUa2zq7ofXbWb0Jm5Y0H0fhpziAHeAfJwmOYapgb06iJE/5yVAs4x5U/BJeEbE X-Received: by 2002:a6b:5804:: with SMTP id m4mr156297iob.14.1599589514229; Tue, 08 Sep 2020 11:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599589514; cv=none; d=google.com; s=arc-20160816; b=mEHW4uwlgJsunvIuEjF51Z89uL1AyDg0d7ynoKFaouSKSMtJjZ5XWdePdg2BhsbRyQ 4XmIku/17ReIihSSUN9ZRKugP4NBfhQi3e3LcsBZJjO0122V5vn8XtamHCb3DColmqhp xdEYac5M9kXdUfYk1PA3CVv3m6dK0vrjM20gKIbEXJHe37GrqUM8uRliTjo/n24OUCLg DI0T0PH4EbOwBEhOzlRmyDFFeWZdxrd1/5NLByyMyRymGBEkfZhz5ShecWAMc6+It9Cz K19IVJNrqX/Bcl3C69aCwC/EghmQ7jXeW+Sa+7BZgQi13Q1CwXo5nzRIDaoe/ExQCJKW IbtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=4ubeTgxZrxdbftZrbDkl1huHrzJaXD0sNYc8UFRW3Wc=; b=gBL/ym/BXMpLq4pIre50Q4q1AjIbHX5MmD/WuE5/fDf2OHMVIW6W0WCNkZN5xfpILr JLMaKMpnTVk9AIe20nE9qIxnaPftzpleCDIuRgR9680rXBEmv22F2ztNwvxAf6eFOg2D toodSJ7G7xFmHMoChbRjCh2CjckEULd6Qhp5Tpbx7DyTbDNyqCCHn4fVGY6AJw1SsWeD 0X5m1QM9ctpNSMInsz5ckraGnsbpCD6/zwH/mrfr7FNAA4alWM7GqLx42+nV6345Si9X DZ5qIdOtqHTw4vjfZvBuqWAyDi76+TSZ2y0WqekRNG36ebTwc+QTjyCcAFUxJ4Hn98XZ S9ZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=QTB+0o9W; dkim=neutral (body hash did not verify) header.i=@nexus-software-ie.20150623.gappssmtp.com header.s=20150623 header.b="Nw8zH73/"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id x124si109074iof.70.2020.09.08.11.25.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:25:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=QTB+0o9W; dkim=neutral (body hash did not verify) header.i=@nexus-software-ie.20150623.gappssmtp.com header.s=20150623 header.b="Nw8zH73/"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4ubeTgxZrxdbftZrbDkl1huHrzJaXD0sNYc8UFRW3Wc=; b=QTB+0o9WAHU8xg7F6DWooL708 Awc8J9WvNRDOcdbJwFaur+aI0GqUP/oNt/72UcB8RP3akCFOZhNjNu/k7wHYkjU+F1AYJf8u0PaMa fScg50GSTdvWJtWm8cA31C287qoVMsncmr2cDloeD9bH7gEg5K5MOxW/eKuzOtpSjlykVXCARGITx WXDDdz6tmBesp36uv+4hGEN909d8k8zWRCTt8YpB92ftIMPW4zPe9eLiSQ5v8XMeP6OXXg3+k6w3b Y5iB+yJ1tr0XBxwcAACyKYdSzbWe6BhPTtRf2B9n7bCV4/W1PnTGHNM0Uc0rQ7P9slQagsePNCQ76 xt7EfTrig==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiIo-0005bF-Uq; Tue, 08 Sep 2020 18:25:11 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiIm-0005ZR-J4 for wcn36xx@lists.infradead.org; Tue, 08 Sep 2020 18:25:09 +0000 Received: by mail-wm1-x344.google.com with SMTP id z9so314503wmk.1 for ; Tue, 08 Sep 2020 11:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6pAkxtOoFSvNi7RPnLSu55Y7kA0XCbGAAZQbWlXlijY=; b=Nw8zH73/LEfHreHLQOgQhBKMtwTyVQ37S/nC4WcGslQWk0hDJY0kZJVP0xFq3mixYj uqDAPJlvIFyksbk6CxyWRoOe1ideRXfdC/aP/TWiFZFwLCK+LvTj34waXeLcD9WvafDA RNl7dLAe4nMyRRobJMRIWFE70AkyNzH1eo+sYhWvWXYOp+wHBhJvY8f/Wiy4JoVGbz+C IV0yu3DHJoisek4A7NlnWxx0xdY55TJq6g3UfAXuRyarsowql0FwsPOO4Z2rzoEelSvA 1cEE+0BfwSCQxEGvDxrXbGt23af3jHUfvPSvkcHpqlN9//+H1eT5zekE8IhbAD/qId2F RF5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6pAkxtOoFSvNi7RPnLSu55Y7kA0XCbGAAZQbWlXlijY=; b=q449BVeBvEkJXMrSW8F9fjRbsXi5HQR0GXWWldrwfOuuCi98eccxczdWH9sNuZjNgT vSaP+VhI4pIrd8FQKiq+I9D/wYcwqbwOJlFxUyKMmtrqwu1Bcnp9BGFfJIohhaE7sNdD pw8yhu52viImfbvlZw1hGWxqg3qeysJUsO+dh5eAsNJx2aTW5/xyHJP66S3MVgefKahg MMq/6fXFErzn/0X0fKfjjL+9vWiqTIZWiLytYo52ZxukrR6698p6ZpXNAhQjTC8l3vzm PpGaIlZOEmPkDyREYXwd1reioarUS6xDpnBbvTDt2DNPXdDO2aYG1YMhI+B8QolL1xrV 7ybg== X-Gm-Message-State: AOAM530j0M93l96/UXH6j3KSLDammKXMM/U2YmDbS8UV0Ek42hcORJmD geO2jGlUw8RCQoyqeFDSTmECTQ== X-Received: by 2002:a7b:c749:: with SMTP id w9mr361320wmk.29.1599589507701; Tue, 08 Sep 2020 11:25:07 -0700 (PDT) Received: from localhost.localdomain ([176.61.57.127]) by smtp.gmail.com with ESMTPSA id c18sm376908wrx.63.2020.09.08.11.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:25:07 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v3 2/2] wcn36xx: Ensure spaces between functions Date: Tue, 8 Sep 2020 19:25:53 +0100 Message-Id: <20200908182553.2870585-3-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200908182553.2870585-1-pure.logic@nexus-software.ie> References: <20200908182553.2870585-1-pure.logic@nexus-software.ie> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_142508_901302_6CB72F6A X-CRM114-Status: GOOD ( 14.14 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org From: Bryan O'Donoghue This is a small update to fix an error I saw where a few functions do not have a blank line in between them. Affects smd.c and main.c - no logic is affected by this change. Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/main.c | 1 + drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++++ 2 files changed, 5 insertions(+) -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 9e97513feeb5..929425415d05 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -775,6 +775,7 @@ static void wcn36xx_update_allowed_rates(struct ieee80211_sta *sta, sta->vht_cap.vht_mcs.tx_mcs_map; } } + void wcn36xx_set_default_rates(struct wcn36xx_hal_supported_rates *rates) { u16 ofdm_rates[WCN36XX_HAL_NUM_OFDM_RATES] = { diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index a8d2af74ef62..b6e49f8f029b 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -218,6 +218,7 @@ static inline u8 is_cap_supported(unsigned long caps, unsigned long flag) { return caps & flag ? 1 : 0; } + static void wcn36xx_smd_set_bss_ht_params(struct ieee80211_vif *vif, struct ieee80211_sta *sta, struct wcn36xx_hal_config_bss_params *bss_params) @@ -2192,6 +2193,7 @@ int wcn36xx_smd_exit_bmps(struct wcn36xx *wcn, struct ieee80211_vif *vif) mutex_unlock(&wcn->hal_mutex); return ret; } + int wcn36xx_smd_set_power_params(struct wcn36xx *wcn, bool ignore_dtim) { struct wcn36xx_hal_set_power_params_req_msg msg_body; @@ -2221,6 +2223,7 @@ int wcn36xx_smd_set_power_params(struct wcn36xx *wcn, bool ignore_dtim) mutex_unlock(&wcn->hal_mutex); return ret; } + /* Notice: This function should be called after associated, or else it * will be invalid */ @@ -2900,6 +2903,7 @@ static void wcn36xx_ind_smd_work(struct work_struct *work) kfree(hal_ind_msg); } } + int wcn36xx_smd_open(struct wcn36xx *wcn) { wcn->hal_ind_wq = create_freezable_workqueue("wcn36xx_smd_ind");