From patchwork Thu Aug 27 07:34:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248426 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp193063ils; Thu, 27 Aug 2020 00:34:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcJdpw7dCoz81Y/+2dD4Ohg1dyCrCl7R5zmGzAEhV+bIXCbTUqtwDtpuAEnfOael/HlYv2 X-Received: by 2002:a17:906:b2d7:: with SMTP id cf23mr19328230ejb.113.1598513690404; Thu, 27 Aug 2020 00:34:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598513690; cv=none; d=google.com; s=arc-20160816; b=P+oESz7kv0q7hI3ixCrbYw0aoJdIkPLzbmTAv16waspq8u+iaNhndcTdQMnUjrzfss oDJyabddM4sGu7Qka1NdtYCEFFH5chWmwUhjriFsUV26RniUQ2RNYxo3dq8mefM9xGpm vmA6AuRnq+XsWhK3HW0eJ8dogJK6MHyaNFQTEmIup5vyxwyEjrPTuNkMj9GGOTsTP+tl SuJFDeYW7oMEOdgW2n71B+ngXvoyJ+QroFrFhVCpOiwR1jBEnQfn/evENDw1Jnu6ndGT OBRU8JLu3dWEMGPJ9lSuewX+e1nTbe1LP+1YnRHCq4F2cDjQD49cOlbpJuWh7oD5Fbrs lLKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=nMutSp2j8lDpsARJd2bf3g5RNBU3idpv78njSHIfOe8=; b=eicTZW2pexV08zvXXZsiM32DgNLPUYHC15DOMGDgVI167ELr5HC4B0xp36/kf0Sg05 Ol8l85sua4JmoIs48gQ5aXps+3bSDHYcOXZGDIcn2cHI6wG8tB/8b6kP7n6KqNUkXhBk D3nnZ+nxsuWv+ENf/MFdHVTvnIYc6gk3/9lU8Y+OyyO2Fik5hn4DqO86ut+wpvt9MsXB /ij8Y49n5onPxuxYQndxLOA6kp81ZG3a3HFFYabiEy2NO3brEg0gJNATTdXFi54sWvcZ iv//9Q+3f9CD+tUoykcsZAA5zQoQqnLnhbZ4TCihyE5XdzLievzZGCBttZ2MY8hfEVdr pWPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eBmPFLnE; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 25si960532ejl.76.2020.08.27.00.34.50; Thu, 27 Aug 2020 00:34:50 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eBmPFLnE; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728233AbgH0Het (ORCPT + 9 others); Thu, 27 Aug 2020 03:34:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727986AbgH0Heq (ORCPT ); Thu, 27 Aug 2020 03:34:46 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB233C06121B for ; Thu, 27 Aug 2020 00:34:45 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id l7so507247wrx.8 for ; Thu, 27 Aug 2020 00:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nMutSp2j8lDpsARJd2bf3g5RNBU3idpv78njSHIfOe8=; b=eBmPFLnENcqBUmxoVeQzsC8krhJde4fyDRfTOapBPl3kr/0SvF8s+Uuh6i31uAGSc2 vWS2B5lBX0s59zd+AZGm8Lb2YtVGpXVfpvID0LnN9JrfBLX5fLGtk4OBSqaQlhXoq2va tHiP+M9SfFwiCh+ZEWG5634cTaGa4qfqJ+/QrqSMdQrQ0WicHDkCKWSeAZtlpshQm59q 91TnkDu4pC+2H595isJymY2OSLFDLG6yItrmIq/f0JMd7HllxaFU9PkphgqcpvRCIlas bhXtgFCYSRZ7wWDf/iVprkZWEmEV3Mom2RuVDWd4SPuSu8dPHnXmE8m16FkG01f3EOMj OnkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nMutSp2j8lDpsARJd2bf3g5RNBU3idpv78njSHIfOe8=; b=Lce5mR8s2aXildpw0V7ESJJBfWdLs3Do8l++UbYFXuipVP+6eKSo+tr9Im+3wt2F31 9cylk/25x0BJxHhMiRAFSvxSH+Fs/qZwmwx90UvoLdyFJeJwLeK+3VxOJhUZucpb+fXO OEKTy4RRU+Gz0+j57SE5dt9xoWjiJd3DpupJqsN9DD3eimpOQg16BaAINA3r03lGUs/o KU85Tpg/WhWkr0t9P+qJPrRFenbGTpCat/mVA7awbwbZ+EOTA+SbIWxtEIioInfO1XTK LFl4CZ+50af2n5zpHANAJTO2Sb3ru6kWvtOgjNYFuKxtKi4L1+n/uKS08hpVLxxDuw6u +hfg== X-Gm-Message-State: AOAM533mWwvUML40b5mWyP987jILTuLseMNLEEyoOj9i36XpxEMQvIq2 9udQWqkf5ZvW7bBCfX5NTtK6qA== X-Received: by 2002:adf:a287:: with SMTP id s7mr20425857wra.103.1598513684404; Thu, 27 Aug 2020 00:34:44 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id c9sm3383642wmf.3.2020.08.27.00.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 00:34:43 -0700 (PDT) Date: Thu, 27 Aug 2020 08:34:42 +0100 From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH v2 27/32] wireless: ath: wil6210: txrx: Demote obvious abuse of kernel-doc Message-ID: <20200827073442.GT3248864@dell> References: <20200821071644.109970-1-lee.jones@linaro.org> <20200821071644.109970-28-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821071644.109970-28-lee.jones@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org None of these headers provide any parameter documentation. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Function parameter or member 'wil' not described in 'wil_vring_alloc_skb' drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Function parameter or member 'vring' not described in 'wil_vring_alloc_skb' drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Function parameter or member 'i' not described in 'wil_vring_alloc_skb' drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Function parameter or member 'headroom' not described in 'wil_vring_alloc_skb' drivers/net/wireless/ath/wil6210/txrx.c:309: warning: Function parameter or member 'wil' not described in 'wil_rx_add_radiotap_header' drivers/net/wireless/ath/wil6210/txrx.c:309: warning: Function parameter or member 'skb' not described in 'wil_rx_add_radiotap_header' drivers/net/wireless/ath/wil6210/txrx.c:444: warning: Function parameter or member 'wil' not described in 'wil_vring_reap_rx' drivers/net/wireless/ath/wil6210/txrx.c:444: warning: Function parameter or member 'vring' not described in 'wil_vring_reap_rx' drivers/net/wireless/ath/wil6210/txrx.c:610: warning: Function parameter or member 'wil' not described in 'wil_rx_refill' drivers/net/wireless/ath/wil6210/txrx.c:610: warning: Function parameter or member 'count' not described in 'wil_rx_refill' drivers/net/wireless/ath/wil6210/txrx.c:1011: warning: Function parameter or member 'wil' not described in 'wil_rx_handle' drivers/net/wireless/ath/wil6210/txrx.c:1011: warning: Function parameter or member 'quota' not described in 'wil_rx_handle' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'd' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'skb' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'tso_desc_type' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'is_ipv4' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'tcp_hdr_len' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'skb_net_hdr_len' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1674: warning: Function parameter or member 'd' not described in 'wil_tx_desc_offload_setup' drivers/net/wireless/ath/wil6210/txrx.c:1674: warning: Function parameter or member 'skb' not described in 'wil_tx_desc_offload_setup' drivers/net/wireless/ath/wil6210/txrx.c:2240: warning: Function parameter or member 'wil' not described in '__wil_update_net_queues' drivers/net/wireless/ath/wil6210/txrx.c:2240: warning: Function parameter or member 'vif' not described in '__wil_update_net_queues' drivers/net/wireless/ath/wil6210/txrx.c:2240: warning: Function parameter or member 'ring' not described in '__wil_update_net_queues' drivers/net/wireless/ath/wil6210/txrx.c:2240: warning: Function parameter or member 'check_stop' not described in '__wil_update_net_queues' drivers/net/wireless/ath/wil6210/txrx.c:2430: warning: Function parameter or member 'vif' not described in 'wil_tx_complete' drivers/net/wireless/ath/wil6210/txrx.c:2430: warning: Function parameter or member 'ringid' not described in 'wil_tx_complete' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/txrx.c | 30 +++++++++---------------- 1 file changed, 10 insertions(+), 20 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c index 080e5aa60bea4..cc830c795b33c 100644 --- a/drivers/net/wireless/ath/wil6210/txrx.c +++ b/drivers/net/wireless/ath/wil6210/txrx.c @@ -249,8 +249,7 @@ static void wil_vring_free(struct wil6210_priv *wil, struct wil_ring *vring) vring->ctx = NULL; } -/** - * Allocate one skb for Rx VRING +/* Allocate one skb for Rx VRING * * Safe to call from IRQ */ @@ -295,8 +294,7 @@ static int wil_vring_alloc_skb(struct wil6210_priv *wil, struct wil_ring *vring, return 0; } -/** - * Adds radiotap header +/* Adds radiotap header * * Any error indicated as "Bad FCS" * @@ -432,8 +430,7 @@ static int wil_rx_get_cid_by_skb(struct wil6210_priv *wil, struct sk_buff *skb) return cid; } -/** - * reap 1 frame from @swhead +/* reap 1 frame from @swhead * * Rx descriptor copied to skb->cb * @@ -597,8 +594,7 @@ static struct sk_buff *wil_vring_reap_rx(struct wil6210_priv *wil, return skb; } -/** - * allocate and fill up to @count buffers in rx ring +/* allocate and fill up to @count buffers in rx ring * buffers posted at @swtail * Note: we have a single RX queue for servicing all VIFs, but we * allocate skbs with headroom according to main interface only. This @@ -1002,8 +998,7 @@ void wil_netif_rx_any(struct sk_buff *skb, struct net_device *ndev) wil_netif_rx(skb, ndev, cid, stats, true); } -/** - * Proceed all completed skb's from Rx VRING +/* Proceed all completed skb's from Rx VRING * * Safe to call from NAPI poll, i.e. softirq with interrupts enabled */ @@ -1629,8 +1624,7 @@ void wil_tx_desc_set_nr_frags(struct vring_tx_desc *d, int nr_frags) d->mac.d[2] |= (nr_frags << MAC_CFG_DESC_TX_2_NUM_OF_DESCRIPTORS_POS); } -/** - * Sets the descriptor @d up for csum and/or TSO offloading. The corresponding +/* Sets the descriptor @d up for csum and/or TSO offloading. The corresponding * @skb is used to obtain the protocol and headers length. * @tso_desc_type is a descriptor type for TSO: 0 - a header, 1 - first data, * 2 - middle, 3 - last descriptor. @@ -1660,8 +1654,7 @@ static void wil_tx_desc_offload_setup_tso(struct vring_tx_desc *d, d->dma.d0 |= BIT(DMA_CFG_DESC_TX_0_PSEUDO_HEADER_CALC_EN_POS); } -/** - * Sets the descriptor @d up for csum. The corresponding +/* Sets the descriptor @d up for csum. The corresponding * @skb is used to obtain the protocol and headers length. * Returns the protocol: 0 - not TCP, 1 - TCPv4, 2 - TCPv6. * Note, if d==NULL, the function only returns the protocol result. @@ -2216,8 +2209,7 @@ static int wil_tx_ring(struct wil6210_priv *wil, struct wil6210_vif *vif, return rc; } -/** - * Check status of tx vrings and stop/wake net queues if needed +/* Check status of tx vrings and stop/wake net queues if needed * It will start/stop net queues of a specific VIF net_device. * * This function does one of two checks: @@ -2419,8 +2411,7 @@ void wil_tx_latency_calc(struct wil6210_priv *wil, struct sk_buff *skb, sta->stats.tx_latency_max_us = skb_time_us; } -/** - * Clean up transmitted skb's from the Tx VRING +/* Clean up transmitted skb's from the Tx VRING * * Return number of descriptors cleared * @@ -2460,8 +2451,7 @@ int wil_tx_complete(struct wil6210_vif *vif, int ringid) while (!wil_ring_is_empty(vring)) { int new_swtail; struct wil_ctx *ctx = &vring->ctx[vring->swtail]; - /** - * For the fragmented skb, HW will set DU bit only for the + /* For the fragmented skb, HW will set DU bit only for the * last fragment. look for it. * In TSO the first DU will include hdr desc */