From patchwork Wed Aug 26 09:33:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248376 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155168ils; Wed, 26 Aug 2020 02:34:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwctG0d6X94B+4PNiVHXUnNSidJLZKHFDPyUAiQXIqHQp6B574p3oPvUOrX/eDX5OH5oiD2 X-Received: by 2002:a17:906:8688:: with SMTP id g8mr6587883ejx.25.1598434487317; Wed, 26 Aug 2020 02:34:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434487; cv=none; d=google.com; s=arc-20160816; b=Z2wxikKqSgAgKk0rGhz1U+zi1i2OmY70IYAj89XeqtlVL/lYTEhAMNQngn5bawkd5g oETeOhYe+PFhTNg9Xb9ubGpLrMSvmzw8uEAURP5U8lHsFE/f9yQEcuC6I6j4QMi9aFNW vIedQTt/bxYAv9jA3NlLjFuTXhmcAjBHBX0JODmfCLoTNw09xpJ/mLVU6I2yfqB3bsdH 0XXL7Elr0XBhDQj4+K2ZU4RhzXrGLUWTcNQsZbId+B5lIjctREeEUlRUCvKhKTSH/a3J /GOWgQAOLlpKWGPBRDbfvRyhIyy/i1XgZRC8hyp+i913y2lPTMhbGmsZBy+XKnfgoWaa yo7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uwbCqiTBl/wKxh4DcTsocNb+vRBe+bY6F3lNqQhTk0s=; b=qS27rZhhi1pOhGMwfVHXzVpweRsqD7JC5imiACHesKAEX1NwhCcHzYCSCJ0f0zBvi0 Qa+UGI8v8gqc5Yt6SZOdAWXTcDwHYfQioHwk02ib9nPWOyZCUQXkvgH7hbZWIM2m9c3v uPDknFSj80//lQMERMYKsVhacx/eSvYLpoldkNwhuSqntuIT/oUYu0AAO3NgibO0qHgT 6jfbFiNJsZhl9zAfetPuG9e/3TXNFVU+0O7FYf0TUokS99LjJNk2JZG51mRY9KxolHaM ObRRJ9VCYRrwemhTLUVGt6huHPkaLXxrJwysT5tKOAq2HvkUozEK6UkZ/0L8U//btYMR TGew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DJRPaWgT; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1209847eja.203.2020.08.26.02.34.47; Wed, 26 Aug 2020 02:34:47 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DJRPaWgT; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728276AbgHZJe3 (ORCPT + 9 others); Wed, 26 Aug 2020 05:34:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728218AbgHZJeM (ORCPT ); Wed, 26 Aug 2020 05:34:12 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BB17C061796 for ; Wed, 26 Aug 2020 02:34:07 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id t14so1075044wmi.3 for ; Wed, 26 Aug 2020 02:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uwbCqiTBl/wKxh4DcTsocNb+vRBe+bY6F3lNqQhTk0s=; b=DJRPaWgTTIrZ0n3QQ+Am6nHcew+nES64DHCa3mD4TYh2BjYwbfXF1iWQMTCo1q4Lv2 D3Q8tLVe8Eu9qrpuLAcUU0jbM2a8yXelCzXiQ5caz7Ctnn5rC0DXINCEcL+fuOFCoJsC OTTD6FbsUTPTfEEpRiox7e0NqdyYv6m4KiSWk4hudvOgWd5c0lTRFfC2qPMMbjKItvh3 djxLse9kccPsQMFq53Q76Ca2PFXRECn0EN/JAf7iWEslf3K7XK6uvOFuI3moGGvDtI2/ OP6LxVshT6ZXonfN9k6zzLBiwGd3FfRfp20Ow4dLZ/pyvn0E7O+RRiNqGlZYhs+IVs26 dLrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uwbCqiTBl/wKxh4DcTsocNb+vRBe+bY6F3lNqQhTk0s=; b=dFHGoRlvku5FHfttJbfZ9KQG8FdUOz4U4j7nrdcKplbxfNtRBzsSaZiYOKnoaX/hYY rz17lbTub1XXa9lt7nepp6bL5JsLCNnvJ4cFlaK2Y1cPFGuIKuPfoJPuKqLFUhq2f8zQ SauP9G4sl8xJv8i0fp+FFMINOqybieGx7N4KOq8NsVAcBss7RvtQcfqcsGZpmjjrdcNy eJNzLTmL94dVO6+L3kkWy8NuwUPw6/2gufNFc05B9PIr6ZvnAM4GFgKiNgWIUU2trNj5 GA/RaNmFgsqd3rShnRpyuA52dTufbQh4C6mui1yII1iZPkhJ3BvPhbo465SzUxqr6b4e UTRg== X-Gm-Message-State: AOAM531zXUA7MxqP0nkPXfCp2ofDol2WCFIK/lO37k9dwE4gor2kSX3j Dk0VvVEolhdTWO8tHjmDhvoQ0A== X-Received: by 2002:a1c:c913:: with SMTP id f19mr5943965wmb.173.1598434445831; Wed, 26 Aug 2020 02:34:05 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:05 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu Subject: [PATCH 01/30] wireless: marvell: mwifiex: pcie: Move tables to the only place they're used Date: Wed, 26 Aug 2020 10:33:32 +0100 Message-Id: <20200826093401.1458456-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Saves on 10's of complains about 'defined but not used' variables. Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/marvell/mwifiex/main.h:57, from drivers/net/wireless/marvell/mwifiex/main.c:22: drivers/net/wireless/marvell/mwifiex/pcie.h:310:41: warning: ‘mwifiex_pcie8997’ defined but not used [-Wunused-const-variable=] 310 | static const struct mwifiex_pcie_device mwifiex_pcie8997 = { | ^~~~~~~~~~~~~~~~ drivers/net/wireless/marvell/mwifiex/pcie.h:300:41: warning: ‘mwifiex_pcie8897’ defined but not used [-Wunused-const-variable=] 300 | static const struct mwifiex_pcie_device mwifiex_pcie8897 = { | ^~~~~~~~~~~~~~~~ drivers/net/wireless/marvell/mwifiex/pcie.h:292:41: warning: ‘mwifiex_pcie8766’ defined but not used [-Wunused-const-variable=] 292 | static const struct mwifiex_pcie_device mwifiex_pcie8766 = { | ^~~~~~~~~~~~~~~~ NB: Repeats 10's of times - snipped for brevity. Cc: Amitkumar Karwar Cc: Ganapathi Bhat Cc: Xinming Hu Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/marvell/mwifiex/pcie.c | 149 ++++++++++++++++++++ drivers/net/wireless/marvell/mwifiex/pcie.h | 149 -------------------- 2 files changed, 149 insertions(+), 149 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 87b4ccca4b9a2..a9173a88e6151 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -33,6 +33,155 @@ static struct mwifiex_if_ops pcie_ops; +static const struct mwifiex_pcie_card_reg mwifiex_reg_8766 = { + .cmd_addr_lo = PCIE_SCRATCH_0_REG, + .cmd_addr_hi = PCIE_SCRATCH_1_REG, + .cmd_size = PCIE_SCRATCH_2_REG, + .fw_status = PCIE_SCRATCH_3_REG, + .cmdrsp_addr_lo = PCIE_SCRATCH_4_REG, + .cmdrsp_addr_hi = PCIE_SCRATCH_5_REG, + .tx_rdptr = PCIE_SCRATCH_6_REG, + .tx_wrptr = PCIE_SCRATCH_7_REG, + .rx_rdptr = PCIE_SCRATCH_8_REG, + .rx_wrptr = PCIE_SCRATCH_9_REG, + .evt_rdptr = PCIE_SCRATCH_10_REG, + .evt_wrptr = PCIE_SCRATCH_11_REG, + .drv_rdy = PCIE_SCRATCH_12_REG, + .tx_start_ptr = 0, + .tx_mask = MWIFIEX_TXBD_MASK, + .tx_wrap_mask = 0, + .rx_mask = MWIFIEX_RXBD_MASK, + .rx_wrap_mask = 0, + .tx_rollover_ind = MWIFIEX_BD_FLAG_ROLLOVER_IND, + .rx_rollover_ind = MWIFIEX_BD_FLAG_ROLLOVER_IND, + .evt_rollover_ind = MWIFIEX_BD_FLAG_ROLLOVER_IND, + .ring_flag_sop = 0, + .ring_flag_eop = 0, + .ring_flag_xs_sop = 0, + .ring_flag_xs_eop = 0, + .ring_tx_start_ptr = 0, + .pfu_enabled = 0, + .sleep_cookie = 1, + .msix_support = 0, +}; + +static const struct mwifiex_pcie_card_reg mwifiex_reg_8897 = { + .cmd_addr_lo = PCIE_SCRATCH_0_REG, + .cmd_addr_hi = PCIE_SCRATCH_1_REG, + .cmd_size = PCIE_SCRATCH_2_REG, + .fw_status = PCIE_SCRATCH_3_REG, + .cmdrsp_addr_lo = PCIE_SCRATCH_4_REG, + .cmdrsp_addr_hi = PCIE_SCRATCH_5_REG, + .tx_rdptr = PCIE_RD_DATA_PTR_Q0_Q1, + .tx_wrptr = PCIE_WR_DATA_PTR_Q0_Q1, + .rx_rdptr = PCIE_WR_DATA_PTR_Q0_Q1, + .rx_wrptr = PCIE_RD_DATA_PTR_Q0_Q1, + .evt_rdptr = PCIE_SCRATCH_10_REG, + .evt_wrptr = PCIE_SCRATCH_11_REG, + .drv_rdy = PCIE_SCRATCH_12_REG, + .tx_start_ptr = 16, + .tx_mask = 0x03FF0000, + .tx_wrap_mask = 0x07FF0000, + .rx_mask = 0x000003FF, + .rx_wrap_mask = 0x000007FF, + .tx_rollover_ind = MWIFIEX_BD_FLAG_TX_ROLLOVER_IND, + .rx_rollover_ind = MWIFIEX_BD_FLAG_RX_ROLLOVER_IND, + .evt_rollover_ind = MWIFIEX_BD_FLAG_EVT_ROLLOVER_IND, + .ring_flag_sop = MWIFIEX_BD_FLAG_SOP, + .ring_flag_eop = MWIFIEX_BD_FLAG_EOP, + .ring_flag_xs_sop = MWIFIEX_BD_FLAG_XS_SOP, + .ring_flag_xs_eop = MWIFIEX_BD_FLAG_XS_EOP, + .ring_tx_start_ptr = MWIFIEX_BD_FLAG_TX_START_PTR, + .pfu_enabled = 1, + .sleep_cookie = 0, + .fw_dump_ctrl = PCIE_SCRATCH_13_REG, + .fw_dump_start = PCIE_SCRATCH_14_REG, + .fw_dump_end = 0xcff, + .fw_dump_host_ready = 0xee, + .fw_dump_read_done = 0xfe, + .msix_support = 0, +}; + +static const struct mwifiex_pcie_card_reg mwifiex_reg_8997 = { + .cmd_addr_lo = PCIE_SCRATCH_0_REG, + .cmd_addr_hi = PCIE_SCRATCH_1_REG, + .cmd_size = PCIE_SCRATCH_2_REG, + .fw_status = PCIE_SCRATCH_3_REG, + .cmdrsp_addr_lo = PCIE_SCRATCH_4_REG, + .cmdrsp_addr_hi = PCIE_SCRATCH_5_REG, + .tx_rdptr = 0xC1A4, + .tx_wrptr = 0xC174, + .rx_rdptr = 0xC174, + .rx_wrptr = 0xC1A4, + .evt_rdptr = PCIE_SCRATCH_10_REG, + .evt_wrptr = PCIE_SCRATCH_11_REG, + .drv_rdy = PCIE_SCRATCH_12_REG, + .tx_start_ptr = 16, + .tx_mask = 0x0FFF0000, + .tx_wrap_mask = 0x1FFF0000, + .rx_mask = 0x00000FFF, + .rx_wrap_mask = 0x00001FFF, + .tx_rollover_ind = BIT(28), + .rx_rollover_ind = BIT(12), + .evt_rollover_ind = MWIFIEX_BD_FLAG_EVT_ROLLOVER_IND, + .ring_flag_sop = MWIFIEX_BD_FLAG_SOP, + .ring_flag_eop = MWIFIEX_BD_FLAG_EOP, + .ring_flag_xs_sop = MWIFIEX_BD_FLAG_XS_SOP, + .ring_flag_xs_eop = MWIFIEX_BD_FLAG_XS_EOP, + .ring_tx_start_ptr = MWIFIEX_BD_FLAG_TX_START_PTR, + .pfu_enabled = 1, + .sleep_cookie = 0, + .fw_dump_ctrl = PCIE_SCRATCH_13_REG, + .fw_dump_start = PCIE_SCRATCH_14_REG, + .fw_dump_end = 0xcff, + .fw_dump_host_ready = 0xcc, + .fw_dump_read_done = 0xdd, + .msix_support = 0, +}; + +static struct memory_type_mapping mem_type_mapping_tbl_w8897[] = { + {"ITCM", NULL, 0, 0xF0}, + {"DTCM", NULL, 0, 0xF1}, + {"SQRAM", NULL, 0, 0xF2}, + {"IRAM", NULL, 0, 0xF3}, + {"APU", NULL, 0, 0xF4}, + {"CIU", NULL, 0, 0xF5}, + {"ICU", NULL, 0, 0xF6}, + {"MAC", NULL, 0, 0xF7}, +}; + +static struct memory_type_mapping mem_type_mapping_tbl_w8997[] = { + {"DUMP", NULL, 0, 0xDD}, +}; + +static const struct mwifiex_pcie_device mwifiex_pcie8766 = { + .reg = &mwifiex_reg_8766, + .blksz_fw_dl = MWIFIEX_PCIE_BLOCK_SIZE_FW_DNLD, + .tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_2K, + .can_dump_fw = false, + .can_ext_scan = true, +}; + +static const struct mwifiex_pcie_device mwifiex_pcie8897 = { + .reg = &mwifiex_reg_8897, + .blksz_fw_dl = MWIFIEX_PCIE_BLOCK_SIZE_FW_DNLD, + .tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K, + .can_dump_fw = true, + .mem_type_mapping_tbl = mem_type_mapping_tbl_w8897, + .num_mem_types = ARRAY_SIZE(mem_type_mapping_tbl_w8897), + .can_ext_scan = true, +}; + +static const struct mwifiex_pcie_device mwifiex_pcie8997 = { + .reg = &mwifiex_reg_8997, + .blksz_fw_dl = MWIFIEX_PCIE_BLOCK_SIZE_FW_DNLD, + .tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K, + .can_dump_fw = true, + .mem_type_mapping_tbl = mem_type_mapping_tbl_w8997, + .num_mem_types = ARRAY_SIZE(mem_type_mapping_tbl_w8997), + .can_ext_scan = true, +}; + static const struct of_device_id mwifiex_pcie_of_match_table[] = { { .compatible = "pci11ab,2b42" }, { .compatible = "pci1b4b,2b42" }, diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.h b/drivers/net/wireless/marvell/mwifiex/pcie.h index fc59b522f6701..843d57eda8201 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.h +++ b/drivers/net/wireless/marvell/mwifiex/pcie.h @@ -158,127 +158,6 @@ struct mwifiex_pcie_card_reg { u8 msix_support; }; -static const struct mwifiex_pcie_card_reg mwifiex_reg_8766 = { - .cmd_addr_lo = PCIE_SCRATCH_0_REG, - .cmd_addr_hi = PCIE_SCRATCH_1_REG, - .cmd_size = PCIE_SCRATCH_2_REG, - .fw_status = PCIE_SCRATCH_3_REG, - .cmdrsp_addr_lo = PCIE_SCRATCH_4_REG, - .cmdrsp_addr_hi = PCIE_SCRATCH_5_REG, - .tx_rdptr = PCIE_SCRATCH_6_REG, - .tx_wrptr = PCIE_SCRATCH_7_REG, - .rx_rdptr = PCIE_SCRATCH_8_REG, - .rx_wrptr = PCIE_SCRATCH_9_REG, - .evt_rdptr = PCIE_SCRATCH_10_REG, - .evt_wrptr = PCIE_SCRATCH_11_REG, - .drv_rdy = PCIE_SCRATCH_12_REG, - .tx_start_ptr = 0, - .tx_mask = MWIFIEX_TXBD_MASK, - .tx_wrap_mask = 0, - .rx_mask = MWIFIEX_RXBD_MASK, - .rx_wrap_mask = 0, - .tx_rollover_ind = MWIFIEX_BD_FLAG_ROLLOVER_IND, - .rx_rollover_ind = MWIFIEX_BD_FLAG_ROLLOVER_IND, - .evt_rollover_ind = MWIFIEX_BD_FLAG_ROLLOVER_IND, - .ring_flag_sop = 0, - .ring_flag_eop = 0, - .ring_flag_xs_sop = 0, - .ring_flag_xs_eop = 0, - .ring_tx_start_ptr = 0, - .pfu_enabled = 0, - .sleep_cookie = 1, - .msix_support = 0, -}; - -static const struct mwifiex_pcie_card_reg mwifiex_reg_8897 = { - .cmd_addr_lo = PCIE_SCRATCH_0_REG, - .cmd_addr_hi = PCIE_SCRATCH_1_REG, - .cmd_size = PCIE_SCRATCH_2_REG, - .fw_status = PCIE_SCRATCH_3_REG, - .cmdrsp_addr_lo = PCIE_SCRATCH_4_REG, - .cmdrsp_addr_hi = PCIE_SCRATCH_5_REG, - .tx_rdptr = PCIE_RD_DATA_PTR_Q0_Q1, - .tx_wrptr = PCIE_WR_DATA_PTR_Q0_Q1, - .rx_rdptr = PCIE_WR_DATA_PTR_Q0_Q1, - .rx_wrptr = PCIE_RD_DATA_PTR_Q0_Q1, - .evt_rdptr = PCIE_SCRATCH_10_REG, - .evt_wrptr = PCIE_SCRATCH_11_REG, - .drv_rdy = PCIE_SCRATCH_12_REG, - .tx_start_ptr = 16, - .tx_mask = 0x03FF0000, - .tx_wrap_mask = 0x07FF0000, - .rx_mask = 0x000003FF, - .rx_wrap_mask = 0x000007FF, - .tx_rollover_ind = MWIFIEX_BD_FLAG_TX_ROLLOVER_IND, - .rx_rollover_ind = MWIFIEX_BD_FLAG_RX_ROLLOVER_IND, - .evt_rollover_ind = MWIFIEX_BD_FLAG_EVT_ROLLOVER_IND, - .ring_flag_sop = MWIFIEX_BD_FLAG_SOP, - .ring_flag_eop = MWIFIEX_BD_FLAG_EOP, - .ring_flag_xs_sop = MWIFIEX_BD_FLAG_XS_SOP, - .ring_flag_xs_eop = MWIFIEX_BD_FLAG_XS_EOP, - .ring_tx_start_ptr = MWIFIEX_BD_FLAG_TX_START_PTR, - .pfu_enabled = 1, - .sleep_cookie = 0, - .fw_dump_ctrl = PCIE_SCRATCH_13_REG, - .fw_dump_start = PCIE_SCRATCH_14_REG, - .fw_dump_end = 0xcff, - .fw_dump_host_ready = 0xee, - .fw_dump_read_done = 0xfe, - .msix_support = 0, -}; - -static const struct mwifiex_pcie_card_reg mwifiex_reg_8997 = { - .cmd_addr_lo = PCIE_SCRATCH_0_REG, - .cmd_addr_hi = PCIE_SCRATCH_1_REG, - .cmd_size = PCIE_SCRATCH_2_REG, - .fw_status = PCIE_SCRATCH_3_REG, - .cmdrsp_addr_lo = PCIE_SCRATCH_4_REG, - .cmdrsp_addr_hi = PCIE_SCRATCH_5_REG, - .tx_rdptr = 0xC1A4, - .tx_wrptr = 0xC174, - .rx_rdptr = 0xC174, - .rx_wrptr = 0xC1A4, - .evt_rdptr = PCIE_SCRATCH_10_REG, - .evt_wrptr = PCIE_SCRATCH_11_REG, - .drv_rdy = PCIE_SCRATCH_12_REG, - .tx_start_ptr = 16, - .tx_mask = 0x0FFF0000, - .tx_wrap_mask = 0x1FFF0000, - .rx_mask = 0x00000FFF, - .rx_wrap_mask = 0x00001FFF, - .tx_rollover_ind = BIT(28), - .rx_rollover_ind = BIT(12), - .evt_rollover_ind = MWIFIEX_BD_FLAG_EVT_ROLLOVER_IND, - .ring_flag_sop = MWIFIEX_BD_FLAG_SOP, - .ring_flag_eop = MWIFIEX_BD_FLAG_EOP, - .ring_flag_xs_sop = MWIFIEX_BD_FLAG_XS_SOP, - .ring_flag_xs_eop = MWIFIEX_BD_FLAG_XS_EOP, - .ring_tx_start_ptr = MWIFIEX_BD_FLAG_TX_START_PTR, - .pfu_enabled = 1, - .sleep_cookie = 0, - .fw_dump_ctrl = PCIE_SCRATCH_13_REG, - .fw_dump_start = PCIE_SCRATCH_14_REG, - .fw_dump_end = 0xcff, - .fw_dump_host_ready = 0xcc, - .fw_dump_read_done = 0xdd, - .msix_support = 0, -}; - -static struct memory_type_mapping mem_type_mapping_tbl_w8897[] = { - {"ITCM", NULL, 0, 0xF0}, - {"DTCM", NULL, 0, 0xF1}, - {"SQRAM", NULL, 0, 0xF2}, - {"IRAM", NULL, 0, 0xF3}, - {"APU", NULL, 0, 0xF4}, - {"CIU", NULL, 0, 0xF5}, - {"ICU", NULL, 0, 0xF6}, - {"MAC", NULL, 0, 0xF7}, -}; - -static struct memory_type_mapping mem_type_mapping_tbl_w8997[] = { - {"DUMP", NULL, 0, 0xDD}, -}; - struct mwifiex_pcie_device { const struct mwifiex_pcie_card_reg *reg; u16 blksz_fw_dl; @@ -289,34 +168,6 @@ struct mwifiex_pcie_device { bool can_ext_scan; }; -static const struct mwifiex_pcie_device mwifiex_pcie8766 = { - .reg = &mwifiex_reg_8766, - .blksz_fw_dl = MWIFIEX_PCIE_BLOCK_SIZE_FW_DNLD, - .tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_2K, - .can_dump_fw = false, - .can_ext_scan = true, -}; - -static const struct mwifiex_pcie_device mwifiex_pcie8897 = { - .reg = &mwifiex_reg_8897, - .blksz_fw_dl = MWIFIEX_PCIE_BLOCK_SIZE_FW_DNLD, - .tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K, - .can_dump_fw = true, - .mem_type_mapping_tbl = mem_type_mapping_tbl_w8897, - .num_mem_types = ARRAY_SIZE(mem_type_mapping_tbl_w8897), - .can_ext_scan = true, -}; - -static const struct mwifiex_pcie_device mwifiex_pcie8997 = { - .reg = &mwifiex_reg_8997, - .blksz_fw_dl = MWIFIEX_PCIE_BLOCK_SIZE_FW_DNLD, - .tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K, - .can_dump_fw = true, - .mem_type_mapping_tbl = mem_type_mapping_tbl_w8997, - .num_mem_types = ARRAY_SIZE(mem_type_mapping_tbl_w8997), - .can_ext_scan = true, -}; - struct mwifiex_evt_buf_desc { u64 paddr; u16 len; From patchwork Wed Aug 26 09:33:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 261908 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F811C433E1 for ; Wed, 26 Aug 2020 09:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D13A20897 for ; Wed, 26 Aug 2020 09:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S2CmOO6z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728555AbgHZJkQ (ORCPT ); Wed, 26 Aug 2020 05:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728226AbgHZJeN (ORCPT ); Wed, 26 Aug 2020 05:34:13 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94313C061798 for ; Wed, 26 Aug 2020 02:34:08 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id x5so1083312wmi.2 for ; Wed, 26 Aug 2020 02:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i2KGeJSrcx/f0sl9IxgJehFn4dP40Mv7ju8hYZZhmHM=; b=S2CmOO6zGDkBWEgPuXFWOPordeJwDLVLAI2n79heI2Imt9csW1njAXNoAue6rqjwy6 3B2Ga34gD1kBdIoilsSvQE1uNW9hpBIvnQa30YdZvWD1wA1Wol3EMxqHRzFi1XrjfbAD 9WasQOTM7WFO9pw6uS7+qnQCab9TM1l8uINNZGoU9U92tzbyf4tVP/g0QOes2eYcLrzJ imy9PQ4I9pRiteBOeJenYCVcAdYk8U/HZZjCNjCYJZa/j6UYKxJUQ6BtTvGYBaKjpQQC CHZeTzzgOOlQUS7S+R4x3shf5wCwqEHqZ907ws845F8Qda63OvpToJPtyUWKm1/ajuVt wkyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i2KGeJSrcx/f0sl9IxgJehFn4dP40Mv7ju8hYZZhmHM=; b=bl2sq+hoqDBN6D4x1QyS7PycfkfkX0u/MVocNauXzoGhSjd07h1RI0R2rb0wM0or8G bacLKRpDBw8j50w8j8GDpfcVo8tljhtFIwCqOV98WyDpEY0TLslIbazbYMXmKr4pGg3G h6ZjW/Aj/yHU01Xn+zDCm//VnPa7IfpCsWY9/Y5xkdIL8DnOo+I0QnS/w8k7YO+fwofW tfdjKMVuAhm/rZ1FbxxHdDCQFCGy2hzWej7NXKHajlDodY/putRxxkiH82MgACNhdjOU E/fxiyJrdZ8iLrn6AeTYLe5b2vb6zNVfleer1dLW2LfMj0nY4QuB5aGjfpllM7EyRuXE tdEw== X-Gm-Message-State: AOAM533A7XU3pygdaSSOiq7nA6x/d9B29OHiTpL5P5CF2Szu1W/c924I NgmQ7XwLeD9sVpw+u2vLOJm48A== X-Google-Smtp-Source: ABdhPJwlIijd7UrnKwjo8KchXhpkB+tbjfjKJ4VU3DJLPxvkUuccn08hqCsuw1MbWZrE0uZPel7smg== X-Received: by 2002:a1c:5a87:: with SMTP id o129mr3115105wmb.145.1598434447276; Wed, 26 Aug 2020 02:34:07 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:06 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 02/30] wireless: broadcom: brcmsmac: ampdu: Remove a couple set but unused variables Date: Wed, 26 Aug 2020 10:33:33 +0100 Message-Id: <20200826093401.1458456-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): from drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:18: drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function ‘brcms_c_ampdu_dotxstatus_complete’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:850:7: warning: variable ‘update_rate’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function ‘brcms_c_ampdu_dotxstatus’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1027:20: warning: variable ‘scb_ampdu’ set but not used [-Wunused-but-set-variable] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Lee Jones Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c index cbad1a11673ae..c9fb4b0cffaf5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c @@ -847,7 +847,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb, bool ba_recd = false, ack_recd = false; u8 suc_mpdu = 0, tot_mpdu = 0; uint supr_status; - bool update_rate = true, retry = true; + bool retry = true; u16 mimoantsel = 0; u8 retry_limit; struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(p); @@ -867,9 +867,6 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb, supr_status = txs->status & TX_STATUS_SUPR_MASK; if (txs->status & TX_STATUS_ACK_RCV) { - if (TX_STATUS_SUPR_UF == supr_status) - update_rate = false; - WARN_ON(!(txs->status & TX_STATUS_INTERMEDIATE)); start_seq = txs->sequence >> SEQNUM_SHIFT; bitmap[0] = (txs->status & TX_STATUS_BA_BMAP03_MASK) >> @@ -893,7 +890,6 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb, ba_recd = true; } else { if (supr_status) { - update_rate = false; if (supr_status == TX_STATUS_SUPR_BADCH) { brcms_dbg_ht(wlc->hw->d11core, "%s: Pkt tx suppressed, illegal channel possibly %d\n", @@ -921,7 +917,6 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb, brcms_c_ffpld_check_txfunfl(wlc, queue); } } else if (txs->phyerr) { - update_rate = false; brcms_dbg_ht(wlc->hw->d11core, "%s: ampdu tx phy error (0x%x)\n", __func__, txs->phyerr); @@ -1024,7 +1019,6 @@ void brcms_c_ampdu_dotxstatus(struct ampdu_info *ampdu, struct scb *scb, struct sk_buff *p, struct tx_status *txs) { - struct scb_ampdu *scb_ampdu; struct brcms_c_info *wlc = ampdu->wlc; u32 s1 = 0, s2 = 0; @@ -1050,7 +1044,6 @@ brcms_c_ampdu_dotxstatus(struct ampdu_info *ampdu, struct scb *scb, } if (scb) { - scb_ampdu = &scb->scb_ampdu; brcms_c_ampdu_dotxstatus_complete(ampdu, scb, p, txs, s1, s2); } else { /* loop through all pkts and free */ From patchwork Wed Aug 26 09:33:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248403 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4158059ils; Wed, 26 Aug 2020 02:40:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZsTkGFswYowJEMkLc96/OMNDklUvB9dRHgLsedYegy5xHEXcREPU0bflw6pLotPrKaUfV X-Received: by 2002:a17:906:14ca:: with SMTP id y10mr12116655ejc.466.1598434803652; Wed, 26 Aug 2020 02:40:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434803; cv=none; d=google.com; s=arc-20160816; b=gdz68dpqdNE2XXA6GIVsKLMJwcuL1kG89SM8NpUALeI4Q/smOsTk+vEcimBlAy3//r BCS0HntzqLGXdU6AfI8GHygzVpxtjrQ4WvPtsnPLdKagGRrZl7JT7ZZDz8O3DVNg/wyO UZjTRZMDxs0pg+2RhOqltDd2IkAxFe/PIWmn+hTIg/lmV9SEYH8vzh+ulDyB8QrxJKpB AFhYyr6uXeQAcdXHHpO/xUtY3ZqNWwTn514hK56jdH56FirwcgfSq4NatvRhTjiN/vHG b/lwsgQU0KwhpHl9UqhXArIIT513bOo4A8nsOne6SUyU+XCk45T/ozdTjt/okZNAf0VZ P6wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oekAdSRdWeQGb7KHnNCwUm4X9s+jdekjgVn8syGtQMg=; b=ISEEtWQ+AOyjo26kUcIN+uDt5jtDoRNVs6gQK7wI3ehW2n87x3IdmWYeQhwCsV0C/x VFOTtYtT7aXC6mfN8/ZlI4TqfPysIVMejH5wvZ0x6oMr3GYrRazI4tA+iH49U4Qs5Q37 /AguxVCi++eN5EbrBau/u6/Z/QNGtO7mvKWdJeR511limklSNgdPEMLPePvYEzzE748e AW8AEMTfE03kpWTz0v5SGO1advbQYLm3m5ReKo4WSZMW44rx2XGKXyW5LdgI0kf18jPX rP32SAj3sLsj7k7CifoUu4SJ6aCkAwh/KnluuWK+jU+rPxgM2ojzcuzqnhCdd0JMHOSE UByg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g4XtCs3d; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q3si1189713ejb.543.2020.08.26.02.40.03; Wed, 26 Aug 2020 02:40:03 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g4XtCs3d; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728717AbgHZJkC (ORCPT + 9 others); Wed, 26 Aug 2020 05:40:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728246AbgHZJeY (ORCPT ); Wed, 26 Aug 2020 05:34:24 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10635C0617A1 for ; Wed, 26 Aug 2020 02:34:11 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id x9so1077177wmi.2 for ; Wed, 26 Aug 2020 02:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oekAdSRdWeQGb7KHnNCwUm4X9s+jdekjgVn8syGtQMg=; b=g4XtCs3dFNDuVsKSQJBUwGxM1zqKaMl9GznNvdQ8VL3/b1U5zLzI6WrjAe2SuR0sZD oRxiJXmRQILu7EVorZuvPBDgGRVy7dCUO671Trm+oHmwuMY2a9lJ+0yOTBxFEA5fjID3 uDVKgDV1pTedgO+RkNAGJuTNckTG2AuQvwPE1PBWJVo6TnkjGyw27FQZd0ySwr4vtH0M qjymyE86k6OCWULBDmokPuptRPB2KEUWNXYraMZ/v2oinOA3I2FDy0FBNnvxTf2rUvOC lu9JGW6ip3oqI2GflDtj5wfdhBbDU8KLFdZFSkYO4xN9I2b/JPUWEyyMKOlD7XNoNUk1 +O9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oekAdSRdWeQGb7KHnNCwUm4X9s+jdekjgVn8syGtQMg=; b=lmD+xQq4r1DWPtf+wMHGMjagDckxyAvzLJsRlWuhnt6Q5CPwB481YheeiuM4x4f57/ gFm7OAcVIHOKiFNAZhx0FkD8ki95BAz7gDzSXahlz/I/5Ox2Q6/OhUwaqymAihLPCg0i qtx+q9N8oreGELE3hb6Tcxs1K8ShL2RMS3fVCQ5a8xPDTwh1UiantHRvyOl72FPVtigW 9YT7TLbOvIeG1v8C8WS493Fyc3xJnvbDOkmKYmQO+1AcMfu4fr+9+8MlgnQajzPJvH5o RPXWh7YUJq9EDPTt0sUBZhLFakAakGuTUuesgBq8SLl7nZa6KPKCor8ZgHX2h06Ht/zB uB7Q== X-Gm-Message-State: AOAM533b7P/Ty0A3p2w4XPyA3ak0ccQAH+sFGQNLgFu6rr+l6EKWuVET noQepjTB1ni7/0gheq5kJnHSYQ== X-Received: by 2002:a1c:dd85:: with SMTP id u127mr6530261wmg.65.1598434449691; Wed, 26 Aug 2020 02:34:09 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:09 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Stanislaw Gruszka , Linux Wireless Subject: [PATCH 04/30] wireless: intel: iwlegacy: 3945-rs: Remove all non-conformant kernel-doc headers Date: Wed, 26 Aug 2020 10:33:35 +0100 Message-Id: <20200826093401.1458456-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlegacy/3945-rs.c:136: warning: Function parameter or member 'rs_sta' not described in 'il3945_rate_scale_flush_wins' drivers/net/wireless/intel/iwlegacy/3945-rs.c:243: warning: Function parameter or member 'rs_sta' not described in 'il3945_collect_tx_data' drivers/net/wireless/intel/iwlegacy/3945-rs.c:243: warning: Function parameter or member 'win' not described in 'il3945_collect_tx_data' drivers/net/wireless/intel/iwlegacy/3945-rs.c:243: warning: Function parameter or member 'success' not described in 'il3945_collect_tx_data' drivers/net/wireless/intel/iwlegacy/3945-rs.c:243: warning: Function parameter or member 'retries' not described in 'il3945_collect_tx_data' drivers/net/wireless/intel/iwlegacy/3945-rs.c:243: warning: Function parameter or member 'idx' not described in 'il3945_collect_tx_data' drivers/net/wireless/intel/iwlegacy/3945-rs.c:429: warning: Function parameter or member 'il_rate' not described in 'il3945_rs_tx_status' drivers/net/wireless/intel/iwlegacy/3945-rs.c:429: warning: Function parameter or member 'sband' not described in 'il3945_rs_tx_status' drivers/net/wireless/intel/iwlegacy/3945-rs.c:429: warning: Function parameter or member 'sta' not described in 'il3945_rs_tx_status' drivers/net/wireless/intel/iwlegacy/3945-rs.c:429: warning: Function parameter or member 'il_sta' not described in 'il3945_rs_tx_status' drivers/net/wireless/intel/iwlegacy/3945-rs.c:429: warning: Function parameter or member 'skb' not described in 'il3945_rs_tx_status' drivers/net/wireless/intel/iwlegacy/3945-rs.c:606: warning: Function parameter or member 'il_r' not described in 'il3945_rs_get_rate' drivers/net/wireless/intel/iwlegacy/3945-rs.c:606: warning: Function parameter or member 'sta' not described in 'il3945_rs_get_rate' drivers/net/wireless/intel/iwlegacy/3945-rs.c:606: warning: Function parameter or member 'il_sta' not described in 'il3945_rs_get_rate' drivers/net/wireless/intel/iwlegacy/3945-rs.c:606: warning: Function parameter or member 'txrc' not described in 'il3945_rs_get_rate' Cc: Stanislaw Gruszka Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Linux Wireless Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlegacy/3945-rs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlegacy/3945-rs.c b/drivers/net/wireless/intel/iwlegacy/3945-rs.c index 0af9e997c9f67..b2478cbe558e6 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-rs.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-rs.c @@ -124,7 +124,7 @@ il3945_clear_win(struct il3945_rate_scale_data *win) win->stamp = 0; } -/** +/* * il3945_rate_scale_flush_wins - flush out the rate scale wins * * Returns the number of wins that have gathered data but were @@ -229,7 +229,7 @@ il3945_bg_rate_scale_flush(struct timer_list *t) D_RATE("leave\n"); } -/** +/* * il3945_collect_tx_data - Update the success/failure sliding win * * We keep a sliding win of the last 64 packets transmitted @@ -416,7 +416,7 @@ il3945_rs_free_sta(void *il_priv, struct ieee80211_sta *sta, void *il_sta) del_timer_sync(&rs_sta->rate_scale_flush); } -/** +/* * il3945_rs_tx_status - Update rate control values based on Tx results * * NOTE: Uses il_priv->retry_rate for the # of retries attempted by @@ -584,7 +584,7 @@ il3945_get_adjacent_rate(struct il3945_rs_sta *rs_sta, u8 idx, u16 rate_mask, return (high << 8) | low; } -/** +/* * il3945_rs_get_rate - find the rate for the requested packet * * Returns the ieee80211_rate structure allocated by the driver. From patchwork Wed Aug 26 09:33:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 261909 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A7FC433DF for ; Wed, 26 Aug 2020 09:40:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C55E2087D for ; Wed, 26 Aug 2020 09:40:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JXl7Wb1T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728516AbgHZJkB (ORCPT ); Wed, 26 Aug 2020 05:40:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728247AbgHZJeY (ORCPT ); Wed, 26 Aug 2020 05:34:24 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ECE9C0617A3 for ; Wed, 26 Aug 2020 02:34:12 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id 2so1082423wrj.10 for ; Wed, 26 Aug 2020 02:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZXzMFpauZUbIvXTpTjTk511d7rH3VOBZcuLvH1EPh6E=; b=JXl7Wb1TDc4vtCMn0jU7O2QGXjAE5ZmvNt2UgRowQia4ULjEjnVwFgycqO/xL1xiQL mGwTh6TOAaoCjozXj2v0shvbn57oE3Xbb5yL1zNlrF02tx8FgyqJdJSQ9UBUE7iHQ8Pq WPWeG8MVNOmVmdJCNGy5SV7kEgbOq+/qq+Y0NJ3svO09zeXVLiYNEIt/AkpRr1P8ZkiO NPuBH1yw62bbpTY/ejBsGMKIcy4LOtPiy05IcYX7RwnO3KH9go0bveQTm87bM8i6nI16 rKTfoHx+Xm08R/jH66MdPo3S/AnpzzllpPwufZZhnxpsr6fKuaunZX44bkkmzYRGHhVG S0TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZXzMFpauZUbIvXTpTjTk511d7rH3VOBZcuLvH1EPh6E=; b=f5kW9TqoQ8eDZVUUBM8+4fwS4oEUIIgpuPtWzvL2Jq2al+qTN99U5kTeqUxXaVZX3h e98Ql+TwZu/DQT1Xb0aq+GvOnFm00gDwGoyAJgssQpGmBOdTdT6eldz3nZqrMjr52nGC dqza72WVPzV7lvze5mzVDu/7AEu1oIKaBFE8y/SaD6HNS6XiAKohktvV3ewWnjx6YiKP Pguipb3GAIR7/1mmCzBrLapXFEBmDNmp0zgMroSWK/nQ7KAX9ffjM89LQ4qwVw7NBUj7 71+8HwL1D8eW8cpehbbwsNKmbKAg4SogVWUrCGlg36HnMkYtuY9ThNTic0Dg0eKvdiWd 5Dsg== X-Gm-Message-State: AOAM532focxZihrpDuYfw0MguQ0rkxDk225KXYd8gmQ3VT4bCJJIsqyX K1cQG15X5zqsBzf7eCCSlERjKA== X-Google-Smtp-Source: ABdhPJwKh1AxTI50soH4xYZxFKCweoABWiKp0VX8Td9mesJOaxcHs7pQEGqY4QhzIJmpdZwz5LGtNg== X-Received: by 2002:adf:f041:: with SMTP id t1mr7808292wro.314.1598434450993; Wed, 26 Aug 2020 02:34:10 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:10 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Stanislaw Gruszka , Linux Wireless Subject: [PATCH 05/30] wireless: intel: iwlegacy: 3945: Remove all non-conformant kernel-doc headers Date: Wed, 26 Aug 2020 10:33:36 +0100 Message-Id: <20200826093401.1458456-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlegacy/3945.c:104: warning: Function parameter or member 'il' not described in 'il3945_disable_events' drivers/net/wireless/intel/iwlegacy/3945.c:273: warning: Function parameter or member 'il' not described in 'il3945_tx_queue_reclaim' drivers/net/wireless/intel/iwlegacy/3945.c:273: warning: Function parameter or member 'txq_id' not described in 'il3945_tx_queue_reclaim' drivers/net/wireless/intel/iwlegacy/3945.c:273: warning: Function parameter or member 'idx' not described in 'il3945_tx_queue_reclaim' drivers/net/wireless/intel/iwlegacy/3945.c:299: warning: Function parameter or member 'il' not described in 'il3945_hdl_tx' drivers/net/wireless/intel/iwlegacy/3945.c:299: warning: Function parameter or member 'rxb' not described in 'il3945_hdl_tx' drivers/net/wireless/intel/iwlegacy/3945.c:637: warning: Function parameter or member 'il' not described in 'il3945_hw_txq_free_tfd' drivers/net/wireless/intel/iwlegacy/3945.c:637: warning: Function parameter or member 'txq' not described in 'il3945_hw_txq_free_tfd' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'il' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'cmd' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'info' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'hdr' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:686: warning: Function parameter or member 'sta_id' not described in 'il3945_hw_build_tx_cmd_rate' drivers/net/wireless/intel/iwlegacy/3945.c:838: warning: Function parameter or member 'il' not described in 'il3945_txq_ctx_reset' drivers/net/wireless/intel/iwlegacy/3945.c:1003: warning: Function parameter or member 'il' not described in 'il3945_hw_txq_ctx_free' drivers/net/wireless/intel/iwlegacy/3945.c:1044: warning: Function parameter or member 'new_reading' not described in 'il3945_hw_reg_adjust_power_by_temp' drivers/net/wireless/intel/iwlegacy/3945.c:1044: warning: Function parameter or member 'old_reading' not described in 'il3945_hw_reg_adjust_power_by_temp' drivers/net/wireless/intel/iwlegacy/3945.c:1053: warning: Function parameter or member 'temperature' not described in 'il3945_hw_reg_temp_out_of_range' drivers/net/wireless/intel/iwlegacy/3945.c:1069: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_txpower_get_temperature' drivers/net/wireless/intel/iwlegacy/3945.c:1107: warning: Function parameter or member 'il' not described in 'il3945_is_temp_calib_needed' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'scan_tbl_idx' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'rate_idx' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'clip_pwrs' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'ch_info' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1328: warning: Function parameter or member 'band_idx' not described in 'il3945_hw_reg_set_scan_power' drivers/net/wireless/intel/iwlegacy/3945.c:1383: warning: Function parameter or member 'il' not described in 'il3945_send_tx_power' drivers/net/wireless/intel/iwlegacy/3945.c:1460: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_set_new_power' drivers/net/wireless/intel/iwlegacy/3945.c:1522: warning: Function parameter or member 'ch_info' not described in 'il3945_hw_reg_get_ch_txpower_limit' drivers/net/wireless/intel/iwlegacy/3945.c:1552: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_comp_txpower_temp' drivers/net/wireless/intel/iwlegacy/3945.c:1712: warning: Function parameter or member 'il' not described in 'il3945_commit_rxon' drivers/net/wireless/intel/iwlegacy/3945.c:1845: warning: Function parameter or member 'il' not described in 'il3945_reg_txpower_periodic' drivers/net/wireless/intel/iwlegacy/3945.c:1889: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_get_ch_grp_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1889: warning: Function parameter or member 'ch_info' not described in 'il3945_hw_reg_get_ch_grp_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1924: warning: Function parameter or member 'il' not described in 'il3945_hw_reg_get_matched_power_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1924: warning: Function parameter or member 'requested_power' not described in 'il3945_hw_reg_get_matched_power_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1924: warning: Function parameter or member 'setting_idx' not described in 'il3945_hw_reg_get_matched_power_idx' drivers/net/wireless/intel/iwlegacy/3945.c:1924: warning: Function parameter or member 'new_idx' not described in 'il3945_hw_reg_get_matched_power_idx' drivers/net/wireless/intel/iwlegacy/3945.c:2055: warning: Function parameter or member 'il' not described in 'il3945_txpower_set_from_eeprom' drivers/net/wireless/intel/iwlegacy/3945.c:2313: warning: Function parameter or member 'il' not described in 'il3945_init_hw_rate_table' Cc: Stanislaw Gruszka Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Linux Wireless Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlegacy/3945.c | 46 +++++++++++----------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/3945.c b/drivers/net/wireless/intel/iwlegacy/3945.c index fd63eba47ba22..0597d828bee1e 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945.c +++ b/drivers/net/wireless/intel/iwlegacy/3945.c @@ -90,7 +90,7 @@ il3945_get_prev_ieee_rate(u8 rate_idx) #define IL_EVT_DISABLE (0) #define IL_EVT_DISABLE_SIZE (1532/32) -/** +/* * il3945_disable_events - Disable selected events in uCode event log * * Disable an event by writing "1"s into "disable" @@ -261,7 +261,7 @@ il3945_rs_next_rate(struct il_priv *il, int rate) return next_rate; } -/** +/* * il3945_tx_queue_reclaim - Reclaim Tx queue entries already Tx'd * * When FW advances 'R' idx, all entries between old and new 'R' idx @@ -291,7 +291,7 @@ il3945_tx_queue_reclaim(struct il_priv *il, int txq_id, int idx) il_wake_queue(il, txq); } -/** +/* * il3945_hdl_tx - Handle Tx response */ static void @@ -627,7 +627,7 @@ il3945_hw_txq_attach_buf_to_tfd(struct il_priv *il, struct il_tx_queue *txq, return 0; } -/** +/* * il3945_hw_txq_free_tfd - Free one TFD, those at idx [txq->q.read_ptr] * * Does NOT advance any idxes @@ -675,7 +675,7 @@ il3945_hw_txq_free_tfd(struct il_priv *il, struct il_tx_queue *txq) } } -/** +/* * il3945_hw_build_tx_cmd_rate - Add rate portion to TX_CMD: * */ @@ -828,7 +828,7 @@ il3945_tx_reset(struct il_priv *il) return 0; } -/** +/* * il3945_txq_ctx_reset - Reset TX queue context * * Destroys all DMA structures and initialize them again @@ -993,7 +993,7 @@ il3945_hw_nic_init(struct il_priv *il) return 0; } -/** +/* * il3945_hw_txq_ctx_free - Free TXQ Context * * Destroy all TX DMA queues and structures @@ -1035,7 +1035,7 @@ il3945_hw_txq_ctx_stop(struct il_priv *il) } } -/** +/* * il3945_hw_reg_adjust_power_by_temp * return idx delta into power gain settings table */ @@ -1045,7 +1045,7 @@ il3945_hw_reg_adjust_power_by_temp(int new_reading, int old_reading) return (new_reading - old_reading) * (-11) / 100; } -/** +/* * il3945_hw_reg_temp_out_of_range - Keep temperature in sane range */ static inline int @@ -1060,7 +1060,7 @@ il3945_hw_get_temperature(struct il_priv *il) return _il_rd(il, CSR_UCODE_DRV_GP2); } -/** +/* * il3945_hw_reg_txpower_get_temperature * get the current temperature by reading from NIC */ @@ -1096,7 +1096,7 @@ il3945_hw_reg_txpower_get_temperature(struct il_priv *il) * Both are lower than older versions' 9 degrees */ #define IL_TEMPERATURE_LIMIT_TIMER 6 -/** +/* * il3945_is_temp_calib_needed - determines if new calibration is needed * * records new temperature in tx_mgr->temperature. @@ -1315,7 +1315,7 @@ il3945_hw_reg_fix_power_idx(int idx) /* Kick off thermal recalibration check every 60 seconds */ #define REG_RECALIB_PERIOD (60) -/** +/* * il3945_hw_reg_set_scan_power - Set Tx power for scan probe requests * * Set (in our channel info database) the direct scan Tx power for 1 Mbit (CCK) @@ -1372,7 +1372,7 @@ il3945_hw_reg_set_scan_power(struct il_priv *il, u32 scan_tbl_idx, s32 rate_idx, power_gain_table[band_idx][power_idx].dsp_atten; } -/** +/* * il3945_send_tx_power - fill in Tx Power command with gain settings * * Configures power settings for all rates for the current channel, @@ -1439,7 +1439,7 @@ il3945_send_tx_power(struct il_priv *il) } -/** +/* * il3945_hw_reg_set_new_power - Configures power tables at new levels * @ch_info: Channel to update. Uses power_info.requested_power. * @@ -1510,7 +1510,7 @@ il3945_hw_reg_set_new_power(struct il_priv *il, struct il_channel_info *ch_info) return 0; } -/** +/* * il3945_hw_reg_get_ch_txpower_limit - returns new power limit for channel * * NOTE: Returned power limit may be less (but not more) than requested, @@ -1537,7 +1537,7 @@ il3945_hw_reg_get_ch_txpower_limit(struct il_channel_info *ch_info) return min(max_power, ch_info->max_power_avg); } -/** +/* * il3945_hw_reg_comp_txpower_temp - Compensate for temperature * * Compensate txpower settings of *all* channels for temperature. @@ -1699,7 +1699,7 @@ il3945_send_rxon_assoc(struct il_priv *il) return rc; } -/** +/* * il3945_commit_rxon - commit staging_rxon to hardware * * The RXON command in staging_rxon is committed to the hardware and @@ -1830,7 +1830,7 @@ il3945_commit_rxon(struct il_priv *il) return 0; } -/** +/* * il3945_reg_txpower_periodic - called when time to check our temperature. * * -- reset periodic timer @@ -1873,7 +1873,7 @@ il3945_bg_reg_txpower_periodic(struct work_struct *work) mutex_unlock(&il->mutex); } -/** +/* * il3945_hw_reg_get_ch_grp_idx - find the channel-group idx (0-4) for channel. * * This function is used when initializing channel-info structs. @@ -1912,7 +1912,7 @@ il3945_hw_reg_get_ch_grp_idx(struct il_priv *il, return group_idx; } -/** +/* * il3945_hw_reg_get_matched_power_idx - Interpolate to get nominal idx * * Interpolate to get nominal (i.e. at factory calibration temperature) idx @@ -2035,7 +2035,7 @@ il3945_hw_reg_init_channel_groups(struct il_priv *il) } } -/** +/* * il3945_txpower_set_from_eeprom - Set channel power info based on EEPROM * * Second pass (during init) to set up il->channel_info @@ -2305,7 +2305,7 @@ il3945_manage_ibss_station(struct il_priv *il, struct ieee80211_vif *vif, vif->bss_conf.bssid); } -/** +/* * il3945_init_hw_rate_table - Initialize the hardware rate fallback table */ int @@ -2520,7 +2520,7 @@ il3945_eeprom_release_semaphore(struct il_priv *il) return; } - /** + /* * il3945_load_bsm - Load bootstrap instructions * * BSM operation: From patchwork Wed Aug 26 09:33:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248402 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157898ils; Wed, 26 Aug 2020 02:39:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8h5rqY9yLlQAmLYr09EOeZOlEPX0wYoKyQJtpoqBbn5ywpoqLlgBbyd6Nj2NPsCtIafV2 X-Received: by 2002:a17:906:4f08:: with SMTP id t8mr15079573eju.164.1598434786770; Wed, 26 Aug 2020 02:39:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434786; cv=none; d=google.com; s=arc-20160816; b=HyBAO+zx/4Bwo7AFISJ40yXC0ULHjzuBi6KGv/g+zXrD9FO7VnmFY2VPFq50vQzrHr 8GjTYGIxIGi6eOwbNpC/ecjmlTlze82KX4+NFWDXl86CcvZ13/abem99Sc+OMZ/fDC7t Kvlvj1cvTvYiDUxdeHC4d9fq5Ahc/ySrG3kPX+u8C1vVd1NSfxYwl/SYBXAGqnN3WqU+ cfAtGIvl/vRr79VEOJeF4wsglK6DxfZpdt/jOE0BOngj8X6ujgNDWwLCHjuFbgHzeLaY gR4b2IY4TXvz8xX20GOg19VYQ8/KJEWjOtYObh+aof753IesScpgrUIg1lVGwSLpJjyu tS2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=H1Hym68LxPW6ieroM4xJcJiJE9iF0Bx9WVLyM7RpmKc=; b=HXXGS/2Q5BHq8dSrx6770lBqNQh+hVqj451x7BpTFjSYdNnUR0Ke1l/31d7NedVyQP ArDC0m9byYaYUCnNDCBZfjHN6eQYlr6xYDmU6u80E1buJNXu4dP9RFPPPb50Q7oXJTSD lo2mNhEe32tIynWEi/X16+l+fW5s7+//hne3jV27Hr+1fJitieYJzOK3mZE874lWGFnV RQS95UdEWd4LO/Y6bFu7HS8WNcOTpG/MX/HWczWGW0k4oQ9xMfc9Xv8rSD8e0Z4hoA3Z QpSKV7A/wDvumn6J6x0JAdkvTtT81zW9SgJkhTIBRdlhT45LQ1bV/fcrJjw9TThwf9R+ lBtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VMAJCEXV; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z1si1173783edi.50.2020.08.26.02.39.46; Wed, 26 Aug 2020 02:39:46 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VMAJCEXV; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728259AbgHZJji (ORCPT + 9 others); Wed, 26 Aug 2020 05:39:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728252AbgHZJeZ (ORCPT ); Wed, 26 Aug 2020 05:34:25 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 891E5C0617A9 for ; Wed, 26 Aug 2020 02:34:13 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id x9so1077298wmi.2 for ; Wed, 26 Aug 2020 02:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H1Hym68LxPW6ieroM4xJcJiJE9iF0Bx9WVLyM7RpmKc=; b=VMAJCEXVaQPRQW4gxdp2T0I4w6Fkr+KH5/mhPAGjP1DL6oyleISyvd9DQAKOzs0FX1 eVIf6cJvx9yMkSzp4f0GsVwlGX85gm9hQkwFI34e0LFeLMwJfj+6WSxT0unCNYTCj87I AabQg0KwlhDsrv+LdxMz0xevrNsZmGSBtUOwEyRd2euIkDDsg9DTfzsIygKmREbe0B4J 4VBNrG+t3XHGBzfhHHp0qo5um0VmechaZSEE3DDgCGOU7VJIP6eSaq0ShZmhNkMN8xIC ZNeaaa80cwkuF0CZPTqD3lkdOEMxwzC1orivKyHVJekmnUNEofldDtnPnGWp9dxBZ4Ee z/IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H1Hym68LxPW6ieroM4xJcJiJE9iF0Bx9WVLyM7RpmKc=; b=sICcnN/Zf1C4pCLqwn886s3F9xE6qXjweCBJlnDWqs4wEh0fLp1hhQFejOTbeeaE2d b4l3AeVGCKbpy9Plpy5hbrs0pokOkMagxSyGbcs6gZwzz4TboPqXNX5tw3FTfFvgQDUm /rqp7Fph4qmB1YgcKLAaTcJGCQF1w0dHiVrB7TQum5pM1/nkN9SKMgVu9sJfPl6hLTS8 w1ZpCVOpHIvu9bH9wavaAiatlI+UWsToqHgVRV9ut4hQETU0dlNd32ezujZoy37ho/e2 oCmwQOOknPpal3sVQqH7GJpnO6v92khZSaT5aFnGQySc2WUQZONRxtoqrKZo3oR0luR/ bGRA== X-Gm-Message-State: AOAM533NuM5bL5usKuPhzjBpq3ja3TEHASq1lJfXAOdj4kcRfK2e28M/ Y5URYW3tIskHWQrgTqoEcYUPLA== X-Received: by 2002:a1c:7718:: with SMTP id t24mr3435825wmi.137.1598434452265; Wed, 26 Aug 2020 02:34:12 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:11 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 06/30] wireless: broadcom: brcmfmac: p2p: Fix a couple of function headers Date: Wed, 26 Aug 2020 10:33:37 +0100 Message-Id: <20200826093401.1458456-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Most likely caused by doc-rot. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:977: warning: Function parameter or member 'wdev' not described in 'brcmf_p2p_remain_on_channel' drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2048: warning: Function parameter or member 'cfg' not described in 'brcmf_p2p_ifchange' drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2048: warning: Excess function parameter 'mac' description in 'brcmf_p2p_ifchange' Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index dc0bc1f6c8023..ec6fc7a150a6a 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -966,7 +966,7 @@ brcmf_p2p_discover_listen(struct brcmf_p2p_info *p2p, u16 channel, u32 duration) * brcmf_p2p_remain_on_channel() - put device on channel and stay there. * * @wiphy: wiphy device. - * @wiphy: wireless device. + * @wdev: wireless device. * @channel: channel to stay on. * @duration: time in ms to remain on channel. * @cookie: cookie. @@ -2038,8 +2038,7 @@ static void brcmf_p2p_get_current_chanspec(struct brcmf_p2p_info *p2p, /** * Change a P2P Role. - * Parameters: - * @mac: MAC address of the BSS to change a role + * @cfg: driver private data for cfg80211 interface. * @if_type: interface type. * Returns 0 if success. */ From patchwork Wed Aug 26 09:33:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 261911 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 959C8C433E3 for ; Wed, 26 Aug 2020 09:39:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7277C20897 for ; Wed, 26 Aug 2020 09:39:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wEtprO+k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728690AbgHZJjR (ORCPT ); Wed, 26 Aug 2020 05:39:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728265AbgHZJe0 (ORCPT ); Wed, 26 Aug 2020 05:34:26 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8F3FC061757 for ; Wed, 26 Aug 2020 02:34:14 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id s13so1077024wmh.4 for ; Wed, 26 Aug 2020 02:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7NPqtCpN+MJMO4A/dgMyA434mUf+bmEkPLCWrQ+c5YA=; b=wEtprO+kfdTRh0oBj+5B8Yy4ISBKhQwNoTK2RGOv3zTrbnF9ElfliFrU1265sy2Dlk X/Ql8tuDk3rwEZ/h46rhTJo/9PJUV7zVajAOJBku2X0uO34M80zXe45EDRxYuRqQleDC NAP9JiR0oSCosMNy+oDBMCmD/yLLjTIp8xiMSXLlVqiYG1K+qxxyGamKNF7mIOUuyrb5 2VSYZ/iMRe2lF+4MMY6QZMN5DYTs+DH4vh/WXqjhBMVd/g37WzOUKzu3gn6NxpqqmLqK OxsVrOTqkJx4HfE7sGwpLwgjM/oHqbOrnto26nf/M69S3VNyhRFIPip5KiAAkOn5l5Qw D+tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7NPqtCpN+MJMO4A/dgMyA434mUf+bmEkPLCWrQ+c5YA=; b=AC+hq2kKTls8e3OpWIhn4GYEeV+KuKudBi8oTqeRusoRbz8wfTGr3I0E9dXhDRVQUO VJBIFq9Cvrvf48aMqO676R2gX2aZP3eZzvuQjedaf35Hg95GjT3bNZ1UuwR8P2eHITC7 T+2n02jxIyJXORf9hH8ntU53AJFB1e0dIcIJ3QeMSa8YO0MyvZO2yk4qBQRCtTUdHL7i AAlaFSLYD/QPPUqHq8FOr84WEfJmHbtRB1TbaU8O7Z7rgDlwibyHy7phdE2VDLjT47DS qv6OfmWEHbmGyjogZGhB/zOfrqw7u6F850UD302Y42jd1DENneQnCpM5vECZycB00qi/ B63w== X-Gm-Message-State: AOAM532+KoHE00BZhwzY74JxprCktlHTo422KDa4oGQ/stTKRE6PBBZH JEYsjr01iHtfw86vBBGz7mwXfg== X-Google-Smtp-Source: ABdhPJzqT0DyC5PnoSK/CEUmtrG0VP7Wqe/C2ORblcv2v2YKXnDCylYJ3YnwxTiMZT0M3+HT1whIRA== X-Received: by 2002:a1c:b4c1:: with SMTP id d184mr6449203wmf.26.1598434453548; Wed, 26 Aug 2020 02:34:13 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:12 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Greg Kroah-Hartman Subject: [PATCH 07/30] wireless: intersil: orinoco_usb: Downgrade non-conforming kernel-doc headers Date: Wed, 26 Aug 2020 10:33:38 +0100 Message-Id: <20200826093401.1458456-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intersil/orinoco/orinoco_usb.c:434: warning: Function parameter or member 'upriv' not described in 'ezusb_req_queue_run' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'req' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'length' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'rid' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'data' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'frame_type' not described in 'ezusb_fill_req' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'reply_count' not described in 'ezusb_fill_req' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Greg Kroah-Hartman Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intersil/orinoco/orinoco_usb.c b/drivers/net/wireless/intersil/orinoco/orinoco_usb.c index 11fa38fedd870..645856bc1796c 100644 --- a/drivers/net/wireless/intersil/orinoco/orinoco_usb.c +++ b/drivers/net/wireless/intersil/orinoco/orinoco_usb.c @@ -423,13 +423,13 @@ static void ezusb_ctx_complete(struct request_context *ctx) } } -/** +/* * ezusb_req_queue_run: * Description: * Note: Only one active CTX at any one time, because there's no * other (reliable) way to match the response URB to the correct * CTX. - **/ + */ static void ezusb_req_queue_run(struct ezusb_priv *upriv) { unsigned long flags; @@ -704,7 +704,7 @@ static inline u16 build_crc(struct ezusb_packet *data) return crc; } -/** +/* * ezusb_fill_req: * * if data == NULL and length > 0 the data is assumed to be already in From patchwork Wed Aug 26 09:33:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248377 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155284ils; Wed, 26 Aug 2020 02:34:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPiKxCroT3RnwzH6JiE3Y5fVa4m9+/0ofciea0rm8fLTWHFx0b/Hu6kNhQ2sS5i158RXIs X-Received: by 2002:a05:6402:b45:: with SMTP id bx5mr14552564edb.214.1598434497996; Wed, 26 Aug 2020 02:34:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434497; cv=none; d=google.com; s=arc-20160816; b=ELr8keB6deIKTyD0R0C7OXhC0cGj30DuqjoBSiMGpclcPkXZaAeqKkFXo1gPekRnS3 wSQdKBt4sFsvWX8ps4JA5hgQVRYcXLmstBCXGCWims+HqGKrs39SN6sk6zPuQzGY4h7W u2KQNnWBTFyQ+vo9L9zj9qowmS3lnbAnwWPYA1RA4hlkR7hCn1qc9nc209zWENeVoid3 FjgQVqihhrzYj8LbJiCpInJAs4WORMAIJcVhaCZn3/3pfi9lyMhWG02MG87P+T9tGzHQ 9bvM4iMiPeZ5iz3R35WN1cdXcg3S38w6PiFgrH0iMEYchI61WM4UMh++4Xio7k8J396M Cu6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hbQ7t0QGJIX1BQrFfjs1A3AU9N9ket4sk5RytzzLdJE=; b=ZNPpBqzdsQu2RXDpnqtHd4YOThQhg1XUS/nodUTRLhZOQQGnLhF2aK5BtKrf++tf6k vQhl63hpfq06Pu27wZGJyRYaLE0K99MJkKD0UAU6jlrFKPAXxsYixPWTdNviVALTSCk7 X+g3rwxYWRaaf93DQNZHCo/Hsl3RE+OOzYuV6q/ln0mFeyFECtffpkptAjbqiIgma09H 2H7ozqfLghPVHRMd9eza/fBhWGkKsZwPdF1oAeoJ5+NZLS3R98jWts67R461z2flFD17 kraCddgpsvYyXjQYHbZ9Aq+VOWQHyB4uK53knbuGC1PMjjNhzxPscQZnnWJIAV/mWXVn gTlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PRSz0KIN; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1209847eja.203.2020.08.26.02.34.57; Wed, 26 Aug 2020 02:34:57 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PRSz0KIN; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728361AbgHZJe4 (ORCPT + 9 others); Wed, 26 Aug 2020 05:34:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728273AbgHZJe2 (ORCPT ); Wed, 26 Aug 2020 05:34:28 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA54FC0617BD for ; Wed, 26 Aug 2020 02:34:17 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id w13so1094868wrk.5 for ; Wed, 26 Aug 2020 02:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hbQ7t0QGJIX1BQrFfjs1A3AU9N9ket4sk5RytzzLdJE=; b=PRSz0KINW/7dL8S4WUZCQfxd14f4YMJbSkBmMHyG1/sQbxmgJbiocMe/T8daglorDC 82MT3w5DXKs4BUDFZ9bXUh2OUgS2NbldfNZvjCgcUdBicoWPOyzI/BFV/5DDflpTHbRK zLv56uyXsO0Ewpl/da6nT0Q2P9XMWgRjvzZ0TO4soBXqTnfOGdxr2CYpFowLMwj7bInj rwmedvcZrOsJxhEwALwPT+KAXfokSNPEFhCOM6Mpzo+OlkIKxmpu5wGDQ9HIa79SyM6B evqqzzuLy045QKid+uDUpQSB8Z+5R8GVMJnXM3r1J20fJjwx3uros9QGhioEqP0eQmiE eJOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hbQ7t0QGJIX1BQrFfjs1A3AU9N9ket4sk5RytzzLdJE=; b=nOtF7jnULZHhPvtFrG8D6g1y4G4yShVBoVZLwU6PobRh2GxUR6AJTx4b3JtrNoB9y3 P2xwatyvDlMVshFrW6OBIuAvKWo7IZdTxgtd6PgDMJB15R4dQrvPSx+QVQloBFNuF+ng YFI6cmHv0SxIboBxwBNKLZed+UawfvQKALpE8YSTETiLilyAizw0NoOJ8uU5ZEBsR/6h qDb3WcVVyq8d+RN0arCcYqWH9S13fEjRq17t15hactml7Wyahiqb6ItqM7f2Y1y+gL+a hjpXIMnXLRUJbmoQ83eRIn9+eQkUZz9kK8x/yQ0heLK5Gs1KVG2/SmOp7wXpJcmwo+QP QtPg== X-Gm-Message-State: AOAM533i8MF8wtXiQcQKlgDiMu0Zb/I7+pKG5tHgSIQTl4yrU2V3xtHg 0s1hMMdaoxpeebl/SD4j9mSW6w== X-Received: by 2002:adf:e781:: with SMTP id n1mr4587780wrm.195.1598434456444; Wed, 26 Aug 2020 02:34:16 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:15 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Daniel Drake , Ulrich Kunitz Subject: [PATCH 09/30] wireless: zydas: zd1211rw: zd_chip: Fix formatting Date: Wed, 26 Aug 2020 10:33:40 +0100 Message-Id: <20200826093401.1458456-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Kerneldoc expects attributes/parameters to be in '@*.: ' format and gets confused if the variable does not follow the type/attribute definitions. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Function parameter or member 'rx_frame' not described in 'zd_rx_rate' drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Function parameter or member 'status' not described in 'zd_rx_rate' Cc: Daniel Drake Cc: Ulrich Kunitz Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/zydas/zd1211rw/zd_chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_chip.c b/drivers/net/wireless/zydas/zd1211rw/zd_chip.c index 0af4b1986e487..0216b1583b48b 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_chip.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_chip.c @@ -1375,8 +1375,8 @@ static inline u8 zd_rate_from_ofdm_plcp_header(const void *rx_frame) /** * zd_rx_rate - report zd-rate - * @rx_frame - received frame - * @rx_status - rx_status as given by the device + * @rx_frame: received frame + * @rx_status: rx_status as given by the device * * This function converts the rate as encoded in the received packet to the * zd-rate, we are using on other places in the driver. From patchwork Wed Aug 26 09:33:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248398 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157496ils; Wed, 26 Aug 2020 02:39:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBqHRCk0mehhNdhdpvIP2p28zs48Ln8Y4/YZ6vrsSsUhaFeXNFJERsVJkRjPH87vU2LRr+ X-Received: by 2002:a17:906:3399:: with SMTP id v25mr14398883eja.383.1598434746662; Wed, 26 Aug 2020 02:39:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434746; cv=none; d=google.com; s=arc-20160816; b=qyH3POOSnlcF57CyT929SZUcs0DzDNcBBc2TXUpKEIUrL143k+tnM0aWzkH/pPsToa 0w34mGH7pCZapIeY6wiDEMLfkfUZfxI14g8F/ldj4tNUC8bQYKMFJpFYptrH/hiwFZ3w nIR7ZuiKYp6GMnojZscnHJ9NNDq+EfL6BYkVqEe0kkB8QLWuT5JlrWnANiZtWrr5SvqJ JrISlkg7sBiVr9A383L7EQUZc8xWlh7Rgu8fO6QhSkqQv+LsqZGCvvg6gCDFmMr4O40X tzvfV27N6eWRKci9hQeb/P2alzEvBQc6VbzjN/OyM4rOcZzL2mnHmI2oYwK4RIJBT9/n apYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lOqkWcILbsAeyAfZ0GfzIi50eF5PW2PXQFze4naQS2g=; b=MH7ca/6MMuOi7Pz6FlSS/93V+kHf8/B1snQTx05BCki7hdVjCKeLGGxtus1nFUxgKV N9M1uk784NcfKv6QDDXj96iZILfBkX8QhgeA4kNGwgfcH/BMwdzdnUvwLSOHtGeyG4xt c1L/cQ50KRXF8QzlDZvyeKJI1hZaPbeYhFyEMS1QjbPZnmr5LwFKlktE4I1QJU53zi50 1xUYzYKZqtfLLTPjHdT+DUaUUMEuQcG+6Kx5A0P0O6WOqUrUhsAMasohqoou3RrHXDBv Ncz/SVxp8UQyMEUXid/tT4wCzQeIw9n80PD/BxIFy88ApY2+BTjVqW2B/AhOQnRIPcOp GfPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QHJKMOnZ; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id va1si1202798ejb.558.2020.08.26.02.39.06; Wed, 26 Aug 2020 02:39:06 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QHJKMOnZ; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728025AbgHZJjE (ORCPT + 9 others); Wed, 26 Aug 2020 05:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728218AbgHZJeb (ORCPT ); Wed, 26 Aug 2020 05:34:31 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14CD1C061384 for ; Wed, 26 Aug 2020 02:34:19 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id b79so482679wmb.4 for ; Wed, 26 Aug 2020 02:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lOqkWcILbsAeyAfZ0GfzIi50eF5PW2PXQFze4naQS2g=; b=QHJKMOnZ4tO+oPpdZO1XclI2udxtKXtC1n+sqUbOkrkLwibykUsRORT51V6Hkmmgh/ t2XgThhanyCXXUkHdhqimUKMlX98ujIdPf048s1aR3v7hgOP3/8q7x/nJ8HBBGos6wf8 lSorCwKC8Zxsxlntp2BNMFDaeK0yCVuJD9uU7Uo7WOoeNbsJRrDgCyd5OmboxWIMY+b+ ULLaynAuXVhaNpZirlsqEfKY/DHuk8Qzqjwm4x84UNsBiHXJPjegYxVr+KnAjZFTTFW3 Zk8AF2IVK+2d7F/ED6AGsvg9yf18ULdammO9EEvq9dfHEq7n6Vt5AIRLCwep9X2DZRiD E6PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lOqkWcILbsAeyAfZ0GfzIi50eF5PW2PXQFze4naQS2g=; b=a4//8BRAZ/Ts+6qmQMqedroo/TA4uCeJnmcnQCHWVWZWPt5Q4u+U2G3GW3tkdD6+OU pjIC0Ruyn13BMhb+OHhhGPxgdIk+MyD6ZC0ipO2NsvU41dpoQADmE616LATWfHKHvmZu YPXuQwvBEOWpYaYBg0Nn59rcZz5ftLCAhHDL2naxE56qwCcoGv8aM8yRcgEPa29o6CYV ox4uKonh2fjicj1+93vMrEYC/7Q9O+bEEkB6pEl2VQwfzdOQ+RxQhKCJ2qOQd96SFGas HK2cKh0vPmOIKOySxuB0D5yYeoyNests/byPwfllBtyOy+wGRdi16bpQWenh1M6SqOlB uBbg== X-Gm-Message-State: AOAM531IX7NF865T6gMMAj8ae4WMH80XOS3uEVqreWJ7gNiVTUbPby8A M/IeyIKGZeJnVzCBK8gm0JHI9g== X-Received: by 2002:a1c:cc05:: with SMTP id h5mr5870886wmb.129.1598434457697; Wed, 26 Aug 2020 02:34:17 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:17 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Daniel Drake , Ulrich Kunitz , Michael Wu , "Luis R. Rodriguez" Subject: [PATCH 10/30] wireless: zydas: zd1211rw: zd_mac: Add missing or incorrect function documentation Date: Wed, 26 Aug 2020 10:33:41 +0100 Message-Id: <20200826093401.1458456-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'hw' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'skb' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'tx_status' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Excess function parameter 'flags' description in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:487: warning: Function parameter or member 'urb' not described in 'zd_mac_tx_failed' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:487: warning: Excess function parameter 'dev' description in 'zd_mac_tx_failed' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:927: warning: Function parameter or member 'hw' not described in 'zd_op_tx' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:927: warning: Excess function parameter 'dev' description in 'zd_op_tx' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:963: warning: Function parameter or member 'hw' not described in 'filter_ack' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:963: warning: Excess function parameter 'dev' description in 'filter_ack' Cc: Daniel Drake Cc: Ulrich Kunitz Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Wu Cc: "Luis R. Rodriguez" Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c index a9999d10ae81f..3ef8533205f91 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c @@ -416,11 +416,10 @@ int zd_restore_settings(struct zd_mac *mac) /** * zd_mac_tx_status - reports tx status of a packet if required - * @hw - a &struct ieee80211_hw pointer - * @skb - a sk-buffer - * @flags: extra flags to set in the TX status info + * @hw: a &struct ieee80211_hw pointer + * @skb: a sk-buffer * @ackssi: ACK signal strength - * @success - True for successful transmission of the frame + * @tx_status: success and/or retry * * This information calls ieee80211_tx_status_irqsafe() if required by the * control information. It copies the control information into the status @@ -477,7 +476,7 @@ static void zd_mac_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb, /** * zd_mac_tx_failed - callback for failed frames - * @dev: the mac80211 wireless device + * @urb: pointer to the urb structure * * This function is called if a frame couldn't be successfully * transferred. The first frame from the tx queue, will be selected and @@ -913,9 +912,9 @@ static int fill_ctrlset(struct zd_mac *mac, /** * zd_op_tx - transmits a network frame to the device * - * @dev: mac80211 hardware device - * @skb: socket buffer + * @hw: a &struct ieee80211_hw pointer * @control: the control structure + * @skb: socket buffer * * This function transmit an IEEE 802.11 network frame to the device. The * control block of the skbuff will be initialized. If necessary the incoming @@ -946,7 +945,7 @@ static void zd_op_tx(struct ieee80211_hw *hw, /** * filter_ack - filters incoming packets for acknowledgements - * @dev: the mac80211 device + * @hw: a &struct ieee80211_hw pointer * @rx_hdr: received header * @stats: the status for the received packet * From patchwork Wed Aug 26 09:33:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248395 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157292ils; Wed, 26 Aug 2020 02:38:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxgZ9ItEXG3cOm8O3YsfUsbt7/qavFh0lT7Nms4xkeCv5fDgeY9o8BPNsNvZdi5sgXwNIa X-Received: by 2002:a50:d809:: with SMTP id o9mr13698635edj.12.1598434727773; Wed, 26 Aug 2020 02:38:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434727; cv=none; d=google.com; s=arc-20160816; b=0k0JhjlXIqnKZysINKG3R2e2n0wlRkLUWyoa1KIPrjWiFUaYNFEp5zeiw1jqdGiuch mi9u7wlgiyibIq0XWpHxCRJTG+KepydbSplVNBw8r8FfuvfSkkuq+tE6cyGVWO3vtdGk jn506IQdi9GmZ7YirAXSnhCAA6OBXxFubGuuG1Tavb1+opneAGrArOuJ+TJTtgaFKcVp 2FO6fj0D1eoM/+OdUjD387Yr9bszAdS6uCBOwoLuSzFGUKRMX2NSJgupEy0P53azZFpx pPjN4rfhy1hqSqyiP9Px1gP3Tu5drmaLHGSeM8kyyprlJoZh3zUPGViDQ66stGI/QMHJ cI9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=h4KvSoafFYDL3t+V7I3USug52YwDVapAvje6j/96TQI=; b=ywBxDCqbinQFs2M5dYoWeFkTGCvcGpQSekI3gG2K0MAg2fKW/jRJ+pJwzWVDX8YP54 g0NEK09XTjqYLatbvlBxqSUKbjSGHIWdpCfoYI0usHNlQOYBK53nyE2OnYYDMAujVFdC 0hOQxFe7D7XZr98kt2n8e+rrzdTJoMh8GaWgqqCET9X2rIuQnVUgATemZc0S8EtfqNq7 062TrhAnAhGFgWMSrMkITx0p/h12/X18DDhRLI2Gd2iOiM+wedkS/BtRCIrf2Ko7JgMr w/0ecm3pQg0pIhXPWwXn+N9UHrncVUK4WxAK1hcVOsksUrWtuigzMYbDKqCDNWwmr5he NaLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PKNmYYfm; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r10si1059339eds.138.2020.08.26.02.38.47; Wed, 26 Aug 2020 02:38:47 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PKNmYYfm; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728664AbgHZJiq (ORCPT + 9 others); Wed, 26 Aug 2020 05:38:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728303AbgHZJeq (ORCPT ); Wed, 26 Aug 2020 05:34:46 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93517C061389 for ; Wed, 26 Aug 2020 02:34:21 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id k20so1066036wmi.5 for ; Wed, 26 Aug 2020 02:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h4KvSoafFYDL3t+V7I3USug52YwDVapAvje6j/96TQI=; b=PKNmYYfm7KhX1X3aF0zxsjy6kJJLw8wKggaKS4op9K8gqpo9dM/4rcmvwrH3MDSwix 0oAxkkftzAlBeaNp9Akj/VHuM34NtCusOiLzSTdv/8MNAu0IeXzIpOodLj5E+e3ayJN7 WaiyidZNZVQeAGHn2SQQlxq+8puoEin4AI6rbVerRbL+e93PU86Q1EQDR7cMTmNRv6SS MWGQ7j1RiU1qLICEbZTYdtagogcM8Qdigl0LNk9toA2Lcl8jwwl4SFoh6vPRjl+9PmhJ 1Zb/cTc3MquDK5AF4dUE36QmokwMjuZAWIlfMNa8ztmg5or2QmV1QB1bQeOxwSTbLM4s LOdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h4KvSoafFYDL3t+V7I3USug52YwDVapAvje6j/96TQI=; b=DND/CeTO+xG6XK49B3iKbwRo9ysA4gOwc0VkNr4iNRg2GCTmt973W2aq+N9SIDpgcA dkGBwAo/0Vva1d7sseKQf4Y39XyKImcaQh6R7+qwQylJe7Lu4EmoKNcB2Yv4kDlyjq1v ZrVtiup2U/xXqtNM/UaqHw2oniFfP47a4ThSGXOGqgFhCOmXVrEdbtsDlShiuvJkdguZ tj3vix/xqmuQxTM6B6UArIuuxEkjI84UCBDej9L+hIV7Gxw6FxDhfLDMLjs8cavZLz7m xra+m3lAvG6e0Ex21s+QUkLsVLksGgmPqLNJDJ10omta8AJ2fZFf8aYUwjOfhw9sBiPg leIQ== X-Gm-Message-State: AOAM533ETAgyWaOBbibcxXCbIA3Llw5F/0h5WIk3+EUUDSUTF/sAor9U bcJZPcCOid9moKhvMr64V/4gigPck4/1PA== X-Received: by 2002:a1c:dd85:: with SMTP id u127mr6531092wmg.65.1598434460238; Wed, 26 Aug 2020 02:34:20 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:19 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_' Date: Wed, 26 Aug 2020 10:33:43 +0100 Message-Id: <20200826093401.1458456-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block' drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess function parameter 'ptr' description in 'wmi_buffer_block' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c index 3a6ee85acf6c7..1439737bbb7b2 100644 --- a/drivers/net/wireless/ath/wil6210/wmi.c +++ b/drivers/net/wireless/ath/wil6210/wmi.c @@ -266,7 +266,7 @@ struct fw_map *wil_find_fw_mapping(const char *section) /** * Check address validity for WMI buffer; remap if needed * @wil: driver data - * @ptr: internal (linker) fw/ucode address + * @ptr_: internal (linker) fw/ucode address * @size: if non zero, validate the block does not * exceed the device memory (bar) * From patchwork Wed Aug 26 09:33:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248397 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157362ils; Wed, 26 Aug 2020 02:38:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy35rTEN3xdH1JLjKpo9Xmt8eWVbqtySdMWcC3kt0d0L2UMwDXxKAVXHQVj0XiFA/M0/1X4 X-Received: by 2002:a50:f40d:: with SMTP id r13mr2790041edm.26.1598434734131; Wed, 26 Aug 2020 02:38:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434734; cv=none; d=google.com; s=arc-20160816; b=vnh3ZE3DwlMuYQ3xBOox5hJHGOqkpl0BnPF0PNrw1ECZxlxuxH+jzoOwVtU9sWjQI/ +d4fx2PrMmDZRzZ0WPZLxUtsxiDX9BQAAbmBq5+HrRiwMRHB4e/0woFksoHECAZHXOC7 iebnE/XObzaewtMRHAFNE+gdXbO+8S0tbNBjKHKgsQ9E5+4MYuyZ1L+gbhMfTMFlebSJ h+YZAha4IlmBkUtHeScI1NP+HmePD3hHGvVWinwaEB6PlWN/X77PX8dqA0lljSmPHSMD /o6jwgk0rKGN1zVB2FEoIzra65QKU/CGUxnJcyed9XpmUOQXHWAzVipJhMOzZE73sCw2 Cyyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=P2cOlNLAlJyCxc93Ww/EdcxwprT/u096tFpvtTUHaj4=; b=q9ajc2I3N9i1Ezq+67Iw+nFaGLoBHvSfE44E/JHgS4l/NlkG0aI/S7xKDOYBWd8x8U bsh/wOjG7lHNnk4VqfpL41nPQi6mt2l3EmwyzBmhjhzimujlqYVNFpN2HvAWCh4bMi9r rJjN8BMkgAMBlV6LO1OeWHQ0f49WZ6s1EPydOeLbQEREqszcdZpe1DHXCZ1+svrU1BxP Q/0pPnKAW7h7aVuguDnaUwdp4hG8hwxHOcvRALllNyZRXdXxQ1Df76PB7DGwVsskxmaL bDbrcga6kPNnPc5PMqlGvRsAgQlse0fJY1eguk5twpmV3kdbsU5jQCgDdY++UrHne0+t 7wfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="E6/EOJ6w"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r10si1059339eds.138.2020.08.26.02.38.53; Wed, 26 Aug 2020 02:38:54 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="E6/EOJ6w"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728306AbgHZJit (ORCPT + 9 others); Wed, 26 Aug 2020 05:38:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728307AbgHZJeq (ORCPT ); Wed, 26 Aug 2020 05:34:46 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAEF1C06138B for ; Wed, 26 Aug 2020 02:34:22 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id s13so1077381wmh.4 for ; Wed, 26 Aug 2020 02:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P2cOlNLAlJyCxc93Ww/EdcxwprT/u096tFpvtTUHaj4=; b=E6/EOJ6wDOrgx9PD4VumxceDaZjVO9H0XlF5v5ZN2N091FR4cecJ8IQISgb3YS5DgR S004H2goEX0Cfuo5HLmWBBl6FbxxinmNGCoTqRbiuKrF0gTKk1msqQQiCR4pNOHUqN5V ea6Zenfh75vE4bk2AGt+qXGEEGqLvobBmMmgg7hBicMqhs4wdCTrVEumLM4aSbpidIix Wv4B08RJlXaozPB7KpaALRNl7PhUY3zk+Bzwxwv7h4I40q9qAjiOkg3wHN7ySDm5NMt2 d6B/Go/tW9ihIoMHHfOR4paRfhsJWojjgF4/PnYoINFkURRPRewWN6Z8dNEB5FPnAV8Z Uypw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P2cOlNLAlJyCxc93Ww/EdcxwprT/u096tFpvtTUHaj4=; b=JbghTWygw9OyqK3pkKAEumu+GGJy969ktmdJXaOD1b2mUo68aeXg6QTOwi1qfrlahq IBJ2qnGoz1n9oXNwrhMI8+XMQo0NiUWDUbpKS92LU4BmwBL/irHifvIozBnNQu5meNcb 4qJDXJvOSfJe2Uj+haAk0xzududA92OmwVbpmOJlk3YQGSG3ddb4KRJ0MmghP9Hyi1Hd VbfYBaEt/sadLf6xTCDu3ARuTt+vDBFzxt30bt2RvEB/of1tyAcjuLB6Y9AzLBJ1t/DC sCjDfmdLDL562aLql1PJZY0qmthPeqXsl77C8QcIXHz3V1bLjV+qjO1g2H8fGt0nJL4W KIog== X-Gm-Message-State: AOAM530rzqcfotMrXYiDFPUWixv9d31j7xylQURTqDYk/x8WFSz9aJ8t 19bDcuBFqTILtA9wjDgrz6OWgQ== X-Received: by 2002:a05:600c:230f:: with SMTP id 15mr6103115wmo.186.1598434461430; Wed, 26 Aug 2020 02:34:21 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:20 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 13/30] wireless: broadcom: brcm80211: brcmfmac: fwsignal: Finish documenting 'brcmf_fws_mac_descriptor' Date: Wed, 26 Aug 2020 10:33:44 +0100 Message-Id: <20200826093401.1458456-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:389: warning: Function parameter or member 'name' not described in 'brcmf_fws_mac_descriptor' drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:389: warning: Function parameter or member 'requested_packet' not described in 'brcmf_fws_mac_descriptor' drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:389: warning: Function parameter or member 'suppr_transit_count' not described in 'brcmf_fws_mac_descriptor' drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:389: warning: Function parameter or member 'send_tim_signal' not described in 'brcmf_fws_mac_descriptor' drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:389: warning: Function parameter or member 'traffic_pending_bmp' not described in 'brcmf_fws_mac_descriptor' drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:389: warning: Function parameter or member 'traffic_lastreported_bmp' not described in 'brcmf_fws_mac_descriptor' Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c index 902b2f65d4605..775e0612fa17a 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c @@ -354,6 +354,7 @@ enum brcmf_fws_mac_desc_state { /** * struct brcmf_fws_mac_descriptor - firmware signalling data per node/interface * + * @name: name of the descriptor. * @occupied: slot is in use. * @mac_handle: handle for mac entry determined by firmware. * @interface_id: interface index. @@ -362,10 +363,15 @@ enum brcmf_fws_mac_desc_state { * @generation: generation bit. * @ac_bitmap: ac queue bitmap. * @requested_credit: credits requested by firmware. + * @requested_packet: packet requested by firmware. * @ea: ethernet address. * @seq: per-node free-running sequence. * @psq: power-save queue. * @transit_count: packet in transit to firmware. + * @suppr_transit_count: suppressed packet in transit to firmware. + * @send_tim_signal: if set tim signal will be sent. + * @traffic_pending_bmp: traffic pending bitmap. + * @traffic_lastreported_bmp: traffic last reported bitmap. */ struct brcmf_fws_mac_descriptor { char name[16]; From patchwork Wed Aug 26 09:33:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248394 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157177ils; Wed, 26 Aug 2020 02:38:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2r4ketQ/WsCNEwziPgKMipQT5Whz7nkV75B0++PhLuPIRgLg91q0wOH5O/BN8GYHfnQnT X-Received: by 2002:a17:906:40e:: with SMTP id d14mr10808326eja.455.1598434712622; Wed, 26 Aug 2020 02:38:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434712; cv=none; d=google.com; s=arc-20160816; b=k3ue8GzhzrxWnTwesAUxEBmPdCkfb5WJ7LEJUjMFD12/VKl+kSolBLAh+1YGZ0Xnwh zQiBvyDYYNGTTzqCKYfKCT1liuNXxhaLYEP6rA6QMSwr9/l1jBs0PRDxKaekyeHIGrEh V0m3TrguhXaJz9MnOG6eYqdgSurnLzeEjE0jVuFPd4DWXOjmRLeEXDiCU/hVw1J0J99m 60XAzPrT14G5h4eBs6+P2vHvSDFKRJrSeehBhE0h5TUxt8EqXSkoqqzURdBjU49Ndc3z P3Me2nLdg6lEedcRonDRWE5YMDlbYisxu+QGsGzekdxpSGLmP3v0zA4f7KLpl23Y/B31 Yn1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qElmRnHsar7tn4JV1a4MOU4ECliWfWuqmHMN13MnixU=; b=jIHg4KzXW6Xj6Oei8/MoX3R2t6vyUnHbonjzZjKfwuETbXc9SrktK0UK+UoYnPsjiP 3V5LajHPUXb+qZHEYPmEZNrgNRwRggKDyuNjMn4MjtnFFgu7U0Bzji2HdjTOAgxYGWlS VWhgNuRxbJ1WHaCXHeFMwbk2/C1iRqsviPBUWLfzRWd2zdwSZuFPlLnPlGu+QuZhz1dq ChJvyDuBkZiKwq4M80J/IxwKaOoy3hs/GR5VyU0zKkvf2o3zuox3tjClm5PTGC0eBxe0 48PlxHwSsn+6OjTVd/2kNIWKsg3wM4g3ddLkPK3TBwpdx2Bd4Gg5ODUrMipzXhKxHpEJ r88w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PBwJBdkQ; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i22si1281003eja.737.2020.08.26.02.38.32; Wed, 26 Aug 2020 02:38:32 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PBwJBdkQ; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbgHZJi2 (ORCPT + 9 others); Wed, 26 Aug 2020 05:38:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728324AbgHZJeq (ORCPT ); Wed, 26 Aug 2020 05:34:46 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC26CC061342 for ; Wed, 26 Aug 2020 02:34:23 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id k20so1066143wmi.5 for ; Wed, 26 Aug 2020 02:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qElmRnHsar7tn4JV1a4MOU4ECliWfWuqmHMN13MnixU=; b=PBwJBdkQlk8+/glvNbz0NN9mU9pLT9iRphNJRoCwUkB7TBfg41MLFYDe9JWU4G4eSz iCZgPMD8KHcs2xTrORTWg9H0xYW4xLdiY/VdZDgZ58k8y9+IngWN8V66vafUV9a4j8mv ZMgrcGPYBYdj3/3d1SQ7JqQCHwSZE6fkwTf4ry/wbHo3DGWpzQWmmveF9yLR8HIBxX6E 4txc7BApPS000GyfapvamEZqKo9PpsZ7m1dTFY4Uj144iF4cUUa3nKtjQH39JzVPDoIQ XuwF7EN1CCGOSGA3e6rv9sCVtYV0zOw0RAbFRfsqExehODp8gWDYcuaCSbbz5U1NRWV+ aX5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qElmRnHsar7tn4JV1a4MOU4ECliWfWuqmHMN13MnixU=; b=IXF6/0KJzR+Tqrov0OjfhUF0IMzKYwNzFIWpO+arrFu8zdTYXyvG+OFFTJDKAr7qJd BsOYgbVYX0hLbSM2QxTf+QNMm8m4wsMejLtOCCBnyJKR7zrLvdGMAK5Kg6uDlDAqowu8 3bKIx7GbI02NSCikdrh+ODzOBOZD47GtH6jMfVRw2lgzUBx+lJG4Uo1LlcPhLLzxe97S Z+3ygX1lhxL4PD7ml4PMLebHqcR8W7337ZAYHs7PeWuD43LY0Fsz72hYMigYG5WyiMdX GTq4HT9Z0XfPI+hlLSB+WqaiKxS3lAsgKtngxRH3Z8rxpE+/MqOjYFg6cfnL0/P3AWF7 uiqw== X-Gm-Message-State: AOAM531zpIcys+Zwqu4ZKwrv4PGcwfhnbfgJEwJaRrQBmtp9bce6iax4 yuXX/NyutvONfkfCBSdfw2Pj6g== X-Received: by 2002:a1c:96c5:: with SMTP id y188mr6392874wmd.72.1598434462418; Wed, 26 Aug 2020 02:34:22 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:21 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones Subject: [PATCH 14/30] wireless: ath: ath6kl: wmi: Remove unused variable 'rate' Date: Wed, 26 Aug 2020 10:33:45 +0100 Message-Id: <20200826093401.1458456-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath6kl/wmi.c: In function ‘ath6kl_wmi_bitrate_reply_rx’: drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’ set but not used [-Wunused-but-set-variable] Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath6kl/wmi.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 6885d2ded53a8..a4339cca661f0 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -1201,8 +1201,7 @@ static int ath6kl_wmi_pstream_timeout_event_rx(struct wmi *wmi, u8 *datap, static int ath6kl_wmi_bitrate_reply_rx(struct wmi *wmi, u8 *datap, int len) { struct wmi_bit_rate_reply *reply; - s32 rate; - u32 sgi, index; + u32 index; if (len < sizeof(struct wmi_bit_rate_reply)) return -EINVAL; @@ -1211,15 +1210,10 @@ static int ath6kl_wmi_bitrate_reply_rx(struct wmi *wmi, u8 *datap, int len) ath6kl_dbg(ATH6KL_DBG_WMI, "rateindex %d\n", reply->rate_index); - if (reply->rate_index == (s8) RATE_AUTO) { - rate = RATE_AUTO; - } else { + if (reply->rate_index != (s8) RATE_AUTO) { index = reply->rate_index & 0x7f; if (WARN_ON_ONCE(index > (RATE_MCS_7_40 + 1))) return -EINVAL; - - sgi = (reply->rate_index & 0x80) ? 1 : 0; - rate = wmi_rate_tbl[index][sgi]; } ath6kl_wakeup_event(wmi->parent_dev); From patchwork Wed Aug 26 09:33:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248393 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157003ils; Wed, 26 Aug 2020 02:38:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXtRXiQuFtJ+y7aAPDXFGV0R24IGtNpjoDoPdBxtqYDYrDNeF4GRvOQIPKstO6QiExa1RO X-Received: by 2002:a17:906:1589:: with SMTP id k9mr14396841ejd.115.1598434695799; Wed, 26 Aug 2020 02:38:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434695; cv=none; d=google.com; s=arc-20160816; b=AMDy1a1ymSsHCurLLz1cvMkb54Xohv1y2//Tt4awWxxNQSJ11i+2fAsdSNGMxk6uxZ 6o7JGf9ZvHRrxVhx2dFsSTjM/WZNfl1KI3VMt0E/wSjcE3K9EsdQslZhBOXJ2vr8UYAr fG0Veoe1OKF6Q7j791D+jSPPfIyDwtAyCEJ2HwM3Gggu7EH6y1lEVOwvxDPL/Sr4O39q LUS3h4UQ48GyXhiXiJIiURJeX8dv2rKRNe4jkdH21vbdWJMSs6m9eQtwEyh4GMirUQHQ cYfY1dGPwcOFqQ9sYkckPY0pcnsFY0Hneb9WyTUnsYAD1kGzH3RrL27nWFGse8cQT9kJ MI+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Bx7yNWclgWagoUc19DO980I/LQpudxltdUcBDgMx82s=; b=EMRLTBVmwXxvc2HeyFltVkjEsA7WAevKS5wH5vAwo1jeAfi3NOmEPfV3rEoezijrGy +Fw3Kr7VVHEpaxI8qszLCPuH47oWj/HnfNkksOqwfS8Fmo0WfIB62R3SY3+5BUdYHbDr uQyxCq86QL19Hts7hnt1b90Hd1l4F27I5ir/LU8BhqVhMVCnGIDS3c21PP2+YbcytBn7 dv4eb32kqksrWLXtzTBxGzWbA5YuI4iiw/bLDXBzFnRu1t3WgQC2VyzyfCv/I5n5qB1K l/Yii0d8ec6wnDy7f27l5r02Y/Wzwq88k2bgB/lXC/iNG3sQNOP+v04oBSmOxPRuwJsj VJ+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uUJKLbTU; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk11si1173792ejb.450.2020.08.26.02.38.15; Wed, 26 Aug 2020 02:38:15 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uUJKLbTU; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728630AbgHZJiO (ORCPT + 9 others); Wed, 26 Aug 2020 05:38:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728334AbgHZJer (ORCPT ); Wed, 26 Aug 2020 05:34:47 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D88DCC061795 for ; Wed, 26 Aug 2020 02:34:24 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id a5so1093274wrm.6 for ; Wed, 26 Aug 2020 02:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bx7yNWclgWagoUc19DO980I/LQpudxltdUcBDgMx82s=; b=uUJKLbTU9CLl0GGHDJpGfj9qHXqTE3vmdSY72df5VY22nwMKPTB/gJEbRC16KsVj7V lqf/Msco72OZwC3/z43E9HJuCf6O4FXc4Ln2h+/SPuM85Apb34/d9LJm1+eeVSKbALFc c2rVrF2Sh84an294dpobLgvr2n7+wlJehzkTlL83PcF2HIXgrzahwnvouyL2GQg8BVCy YzEczRcmVW4jKWDL4pBiFlrSkNOCzvJm1JnA04lj/UemOevD3v2UMxrTXE53HxYDN0d2 mIfNdwOUuKYx7/GFEVMKTyGbyVQd+W2euTeJ/u8fddVeUrdSAHX+9rPgTn/5CayY333+ iGVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bx7yNWclgWagoUc19DO980I/LQpudxltdUcBDgMx82s=; b=TjK55LzHwSEu0ZSxC2LNWucjYWvl6VCkssqlvWXQnofREmBCysmlvRqqnHOmdlVTh+ Ni6ZDM6p+AIj1YwaSNniuYX+IwIdxg9Ct8F3lpQWvGqcCCxsX/j36VuIQ8+qFDyKr9ud SWerDZ+vmlmuljmrvhAsgr2rnstixHHwsTaR/JGo6E4kiWq5Zxm4KZekrqVLEkWjlAHD HQammxqpIUXtWj5N/UJLFo6rPoGEy2bciDQXGC30FY4HQ1Scv3Qb0/S9qA9rFXdLD82P WQYd2jOYDhZyOZkdUthCGEgxJEc8E/oLG0Rzj0lP+uH6M7GTw1vQP2K/OODM+ZBu0kIc 8Ymg== X-Gm-Message-State: AOAM530npHLE5pfJ9HZ+hK2VbfSYDdr+sIhYiXnKTDNNK8ALj6UQIl09 3XSELUbYOA5qEIUxx2xdbotQkA== X-Received: by 2002:a5d:4050:: with SMTP id w16mr1517291wrp.412.1598434463554; Wed, 26 Aug 2020 02:34:23 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:22 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Luciano Coelho Subject: [PATCH 15/30] wireless: ti: wlcore: debugfs: Remove unused variable 'res' Date: Wed, 26 Aug 2020 10:33:46 +0100 Message-Id: <20200826093401.1458456-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Luciano Coelho Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ti/wlcore/debugfs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ti/wlcore/debugfs.h b/drivers/net/wireless/ti/wlcore/debugfs.h index fc3bb0d2ab8da..b143293e694f9 100644 --- a/drivers/net/wireless/ti/wlcore/debugfs.h +++ b/drivers/net/wireless/ti/wlcore/debugfs.h @@ -78,13 +78,13 @@ static ssize_t sub## _ ##name## _read(struct file *file, \ struct wl1271 *wl = file->private_data; \ struct struct_type *stats = wl->stats.fw_stats; \ char buf[DEBUGFS_FORMAT_BUFFER_SIZE] = ""; \ - int res, i; \ + int i; \ \ wl1271_debugfs_update_stats(wl); \ \ for (i = 0; i < len; i++) \ - res = snprintf(buf, sizeof(buf), "%s[%d] = %d\n", \ - buf, i, stats->sub.name[i]); \ + snprintf(buf, sizeof(buf), "%s[%d] = %d\n", \ + buf, i, stats->sub.name[i]); \ \ return wl1271_format_buffer(userbuf, count, ppos, "%s", buf); \ } \ From patchwork Wed Aug 26 09:33:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248380 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155624ils; Wed, 26 Aug 2020 02:35:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwLabcaf1e/MYDcqeKRtFFWwoD2Nks5EHwTNkheHLShNyiuSHPIxd0bwbfJi5zVt/Eg+x0 X-Received: by 2002:a17:906:3647:: with SMTP id r7mr10957860ejb.336.1598434535822; Wed, 26 Aug 2020 02:35:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434535; cv=none; d=google.com; s=arc-20160816; b=ne2cC9AtF1i2htoKQUBYgSTqAgTCSfliWc2nTev0X/ccgqF3QXFckgAcAes2O7csWD mBj/fZFB4uD0VapDKUllcWLsUPLinJzvuqeB7rV/HSi/TmuGtrA4HTQiQWV4a40pvEMn hK+pp2+Ry9qEL+kvJ/v2n3s0H6OnT5cFC2Un3i24+wu3MpISGWXDCj0Ea3t9KFvuWwPg ZToPAtqHI69/d/LwatINDbAw5UWTQakFkuq9SBRY7fX7uOXi1zSmGZEGzmyMzebT0Ati iZ1U+ZtLDU+8e+oCxLYQ3JsTA0rPATQhVAO3jveMWUFwa/gbevP8mt16zOjYTsok616q DXhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gXj0QTNi35Mkf/0PfjV36Op7KYk+Sf8/3WVle5YvISs=; b=ULQ0+mk9XlJ91C2DQNOPHuBmqbwEArewd/ZKCMqeMgXdX49baelLKJTt+ZgfDNzZE+ qG9pPHxG1LJMOK51w9T1M8Oyb0cAwQ/NgqvNcvVW+w9TSGeQN54WKu2KgXQhNOgf4jST Xvf0ymcvAtZuNp0uZ7pbFqpw/svS4/dipVjsfzw28WLQp4K3aF56RdZ/qnGANWWG4vU9 Dn+Fsyd/KgsF6oNb5YmUVly7O1E0pi6SvDix5ZBSusbKTi3kqtEpsVayZQzH94PqlR2Y vwGNSnfMCCAJFeUdO4X0DiNIMAetICrBaPWwjQUe56Jbloeo2ePyHRlgNGseDSzxTd1z 9jMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LwLU6UgN; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1160336ejd.721.2020.08.26.02.35.35; Wed, 26 Aug 2020 02:35:35 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LwLU6UgN; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728405AbgHZJfS (ORCPT + 9 others); Wed, 26 Aug 2020 05:35:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728342AbgHZJes (ORCPT ); Wed, 26 Aug 2020 05:34:48 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D18CC061798 for ; Wed, 26 Aug 2020 02:34:26 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id u18so1075151wmc.3 for ; Wed, 26 Aug 2020 02:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gXj0QTNi35Mkf/0PfjV36Op7KYk+Sf8/3WVle5YvISs=; b=LwLU6UgNWRhkAICyUcI0WTYo9m6TXWqPAHELcWqUYunSe14/NoTP2Wi3SxwnjRCPYp P8ToArmn9LBzbGkBXZ5NsJr3JcJPxfj4PgpcLvujetjrJ+klZkFbwpqK7c0ENSxr3mNx TZxfs6nglopjKXRQRLOaqoCUM9q4GccbGnin36RbIYanIqRUXWquVts5sYLDdBZYOzzb vAyKkiZ+aFleQE2DfWIpFhUJ+MAVRqtkvonJgyFAONhAPazcEjwPOHxWz+EVcNksSV7I vfNUXi6Qw+KqfZKelE0ChGdvsvJPlz3owrqDYGcVtd3723oXffVMm074IevYrbmxxaLj Gs8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gXj0QTNi35Mkf/0PfjV36Op7KYk+Sf8/3WVle5YvISs=; b=IV58cYNs/jAhdv3YppI9/XY0fZm5zRJ10H+il+68XNyqPW2fve/7NV6p8HsYtQGfQD LwF7AD0YcXn7D+ssOvSUUpPsQavxFyo+n4+NuC6ZNvhYBMY5Nm2CtzmpK057MsMjj3U+ tjM0nJdPuAsmMVPLJBvfdStCrpwD8CGHl0LoPaninydvJkQofoGvKOKxM1ZU7f89+EV6 XX+5f4SxkleWXFGut2X5pXsX4t0g0Nl9BsXOhmv8wkk39k1/3nbd48zREymNVXedqhPe gAVHmpUMnBieXHgpo1txTbvOX8gRVy3amVE+bYRmSCVmXVb59LL9I/lk10B1MT7r6fLD cvYQ== X-Gm-Message-State: AOAM533hit6FGIBOaE0yPKlfADoRX6c6nsuU+FfP9G3v1jjMDSPbpVYf Ut8AAi5+VVLQkv94uMVavQNnsw== X-Received: by 2002:a1c:c913:: with SMTP id f19mr5945307wmb.173.1598434464899; Wed, 26 Aug 2020 02:34:24 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:24 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Amitkumar Karwar , Siva Rebbagondla Subject: [PATCH 16/30] wireless: rsi: rsi_91x_sdio: Fix a few kernel-doc related issues Date: Wed, 26 Aug 2020 10:33:47 +0100 Message-Id: <20200826093401.1458456-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org - File headers do not make for good kernel-doc candidates - Kernel-doc header lines should start with " *" - Fix doc-rot issue Fixes the following W=1 kernel build warning(s): drivers/net/wireless/rsi/rsi_91x_sdio.c:25: warning: cannot understand function prototype: 'u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL; ' drivers/net/wireless/rsi/rsi_91x_sdio.c:802: warning: bad line: from the device. drivers/net/wireless/rsi/rsi_91x_sdio.c:842: warning: Function parameter or member 'pfunction' not described in 'rsi_init_sdio_interface' drivers/net/wireless/rsi/rsi_91x_sdio.c:842: warning: Excess function parameter 'pkt' description in 'rsi_init_sdio_interface' Cc: Amitkumar Karwar Cc: Siva Rebbagondla Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c index a04ff75c409f4..a7b8684143f46 100644 --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2014 Redpine Signals Inc. * * Permission to use, copy, modify, and/or distribute this software for any @@ -799,7 +799,7 @@ static int rsi_sdio_host_intf_write_pkt(struct rsi_hw *adapter, /** * rsi_sdio_host_intf_read_pkt() - This function reads the packet - from the device. + * from the device. * @adapter: Pointer to the adapter data structure. * @pkt: Pointer to the packet data to be read from the the device. * @length: Length of the data to be read from the device. @@ -832,11 +832,10 @@ int rsi_sdio_host_intf_read_pkt(struct rsi_hw *adapter, * rsi_init_sdio_interface() - This function does init specific to SDIO. * * @adapter: Pointer to the adapter data structure. - * @pkt: Pointer to the packet data to be read from the the device. + * @pfunction: Pointer to the sdio_func structure. * * Return: 0 on success, -1 on failure. */ - static int rsi_init_sdio_interface(struct rsi_hw *adapter, struct sdio_func *pfunction) { From patchwork Wed Aug 26 09:33:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248379 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155517ils; Wed, 26 Aug 2020 02:35:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAKKHZp+AHjvlWcp5+s4dj7KiO64kA6setqbd9mhZMk3hPIVmzJlukxVx/7dvgTfx2tgQ2 X-Received: by 2002:a50:8e58:: with SMTP id 24mr14562360edx.199.1598434522432; Wed, 26 Aug 2020 02:35:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434522; cv=none; d=google.com; s=arc-20160816; b=BELG7KPlhNSNsGdYq7m0chxWW97ihcxLzF5sxpsSG1nV/ObF8EzBphJ3MWGsC3DT12 jouVPXgJ3AkHangK0HL10oXxAiDTq8lNLOEEzn3OISNJQyvu4MvF7qhQ+BiLBJ2SjegN pXlM2+ct5d0RZQAWG6rDoFMYParqbyyChUpzFlLnGMUs98Ta3z5aw2zPn0QhrLXjBiWJ YikJbctNKFFu92D4OYt2UJ18uS+sEQm1yCe3Bd1htlW1wIJWOlNEyXLFmaPnTQkp2IeI aAGNoXbIbY33/H0Q6eOBLWBp7eYDoG8DIvtpFhP1lo0Ew1Y4d73ZClN8j2DYmVzHBnAi uDyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WVfVHRbfLs77xvEowdNmRYJl1Eqf3t8uGBw9b5yOc7s=; b=Cl4hP9YrodESgGa1mgx/xA94mwqIBcQpY13lZJEY9lI3jKJoo1hAPGfh9xZWyWP9y1 5iOeL4silFfiUQcRUJ687sAStU7Ngj/TE/umSopr86wkwlSkIXJlCSZLDVz/6m+WUiqT aHOChXI/tGqcSquZnQm25uWgEIJL2FOVReNPEQzOeYAfvSKYkr78nUztPIBSfKY8YASr tVK261r3psWSk4egwPd6eyRU5ylpVOTxfsYWIjrlcdhr31yootGXEOSJxwfKTvRbQpoB UWt+NvEp/BeHunoRFCkGl+WZxGG+yU8hh4vH4UyCq5rrew8r3+ynMyeCUg0MUTkNL2d5 JOOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JuY0r5yX; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1160336ejd.721.2020.08.26.02.35.22; Wed, 26 Aug 2020 02:35:22 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JuY0r5yX; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728415AbgHZJfT (ORCPT + 9 others); Wed, 26 Aug 2020 05:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728357AbgHZJe4 (ORCPT ); Wed, 26 Aug 2020 05:34:56 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62958C06179B for ; Wed, 26 Aug 2020 02:34:28 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id t14so1076350wmi.3 for ; Wed, 26 Aug 2020 02:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WVfVHRbfLs77xvEowdNmRYJl1Eqf3t8uGBw9b5yOc7s=; b=JuY0r5yXntpWWzZXsdA88BXsBYv590V4Ep8F6jfWf6kGIWp1JSFtrAQadAVxFywmbN RtkCN5MVz8Kb5gEYOUJAvT5dlvGbvkWMLI/pGdjCNsDAXh6K9kvNfg/crGE7jeGkn9uH YqfwFTj4gh/eR0PkX25QY/QvgCmNAqJjUMxUmUuBD7hHDWFW5mfuZcIj04QlMlM6jNji KT1WWvFzTJ9kZXWxDpKk0Alp8YvzaEa1JeM4SwjWhQGblNi93mk/Xr4Q4s2zw+WJB36o Knnsb802yKk5B/vVGx1+qzXlMyRLPWnxnY32BR97sUmGXn7J8XMufW1T5tzJAEiN7aV0 BN0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WVfVHRbfLs77xvEowdNmRYJl1Eqf3t8uGBw9b5yOc7s=; b=fooJ3fA3q5IuWSpoxDCl16UYZXTQIoMDRPOVlDaYbrAINggSkeIJL+ebW7VjRFaztZ ZA01sGuzAyk1aAJOXmfHLq2uIHZWJRhHHKXlnzHfYcGCx36jxq3IoTaQQsjhsBLJ07M1 /ZSlvELD3JXjMRWcnpLW2KnypLz084/i2LptiZ7KHlQc1arLRZxFG1ESImEFy5RS2QLI VYiYxmMgyumIlSUjGATN4HrevDA1G5LhhvBMT0EuPFoAuPZLKyX0a9JfGiiNqJ7lx4UE cawphI6UWC5vrvF215zyus3GjJlT6I9Vjq3UZXq5pXfvG+yVnri70c0XUKrsi2CIxKhf AqMg== X-Gm-Message-State: AOAM532zmzN0IGmRVUYbmwWWOquOMnrQ1Vl5RSd/uwOi2/0YASwaB1Jb 47gVjdozcHZlqAxA1+4Jgkmykg== X-Received: by 2002:a1c:7c11:: with SMTP id x17mr4307425wmc.122.1598434467042; Wed, 26 Aug 2020 02:34:27 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:26 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , QCA ath9k Development Subject: [PATCH 18/30] wireless: ath: ath9k: ar9001_initvals: Remove unused array 'ar5416Bank6_9100' Date: Wed, 26 Aug 2020 10:33:49 +0100 Message-Id: <20200826093401.1458456-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9001_initvals.h:462:18: warning: ‘ar5416Bank6_9100’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar9001_initvals.h | 37 ------------------- 1 file changed, 37 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/ath9k/ar9001_initvals.h b/drivers/net/wireless/ath/ath9k/ar9001_initvals.h index 59524e1d4678c..aa5f086fa3b0b 100644 --- a/drivers/net/wireless/ath/ath9k/ar9001_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9001_initvals.h @@ -459,43 +459,6 @@ static const u32 ar5416Common_9100[][2] = { {0x0000a3e0, 0x000001ce}, }; -static const u32 ar5416Bank6_9100[][3] = { - /* Addr 5G 2G */ - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00e00000, 0x00e00000}, - {0x0000989c, 0x005e0000, 0x005e0000}, - {0x0000989c, 0x00120000, 0x00120000}, - {0x0000989c, 0x00620000, 0x00620000}, - {0x0000989c, 0x00020000, 0x00020000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x005f0000, 0x005f0000}, - {0x0000989c, 0x00870000, 0x00870000}, - {0x0000989c, 0x00f90000, 0x00f90000}, - {0x0000989c, 0x007b0000, 0x007b0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00f50000, 0x00f50000}, - {0x0000989c, 0x00dc0000, 0x00dc0000}, - {0x0000989c, 0x00110000, 0x00110000}, - {0x0000989c, 0x006100a8, 0x006100a8}, - {0x0000989c, 0x004210a2, 0x004210a2}, - {0x0000989c, 0x0014000f, 0x0014000f}, - {0x0000989c, 0x00c40002, 0x00c40002}, - {0x0000989c, 0x003000f2, 0x003000f2}, - {0x0000989c, 0x00440016, 0x00440016}, - {0x0000989c, 0x00410040, 0x00410040}, - {0x0000989c, 0x000180d6, 0x000180d6}, - {0x0000989c, 0x0000c0aa, 0x0000c0aa}, - {0x0000989c, 0x000000b1, 0x000000b1}, - {0x0000989c, 0x00002000, 0x00002000}, - {0x0000989c, 0x000000d4, 0x000000d4}, - {0x000098d0, 0x0000000f, 0x0010000f}, -}; - static const u32 ar5416Bank6TPC_9100[][3] = { /* Addr 5G 2G */ {0x0000989c, 0x00000000, 0x00000000}, From patchwork Wed Aug 26 09:33:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248392 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4156861ils; Wed, 26 Aug 2020 02:37:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5l4/rfW3L7OG/zwOgM6V52W3kEJgxCDyIed7MH37iZvOS8j7koIs4UV44/pkAT/hVpUVP X-Received: by 2002:a17:906:2613:: with SMTP id h19mr14199264ejc.147.1598434678590; Wed, 26 Aug 2020 02:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434678; cv=none; d=google.com; s=arc-20160816; b=wRp+uUPm37uZWsgM+fVayYZqUX7jglzwjeYtZy55vvZJ3M7fR19iNHAP81e3BtFP9v tvO2Lw0xrTcIKwXtZLwbBs62xU0u2HdI/muSN/r1lzgOsP0Z6BI/4s+m3elT94goGbSo EkXka0n56OSI91WZP8Lk5cl/p1Sr7uITuBl/ttMq/Qq89VDWy+fj4VIgbPsVmZQyZsLB VGaT9pOtLtxVQrrSWKjQZVIgBkt2IBiMOtTS6CRHAxTg9tQ2jyMA4TRHC6k+ZHcTnfEV qyz+WltSq1TiilUOo8xJSJmVk+ZbJAelakLz+zkDUT8W8pZCGop995le4UWPzPHs4k4/ jrVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5xYAPYXZqKI3g1GFZmnrzEgVa6jjBFa/aMcqWmXa5Dc=; b=B34nZmPR6GDLZd6+rVQfLKNhIGVnsFCa9ZtFDM4TaV3A5pbLu4G83GjOmBhtZYSkih 4OAvgInK+dMziDzErftdxMXkODciYBGI1RMoN+EX3U0bW2QEnK2B0dDXlKTpI86s/Q8H 08emit9c6AFawYXSE16IPyetrhqIV8szYngIMADLlXaOLq14Mgbah1R6OudkOa4++tkz lCwaTTkeBMKsbhxjGv6VaEOHY+Zcsf3zh60upAe/hQEoS84oU90AigvefcXvPnL1poPC Nn91z9+lwPZBN3jdHqMq2sH0QB9iQVh0tQO+9mwj5VOsb7gZKt9f3fWdB9HRwbrRrw/r j+Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NtAv25hj; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i27si1161344eja.627.2020.08.26.02.37.58; Wed, 26 Aug 2020 02:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NtAv25hj; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728567AbgHZJhy (ORCPT + 9 others); Wed, 26 Aug 2020 05:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728367AbgHZJfD (ORCPT ); Wed, 26 Aug 2020 05:35:03 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B80C8C0617A0 for ; Wed, 26 Aug 2020 02:34:29 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id p17so1090043wrj.8 for ; Wed, 26 Aug 2020 02:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5xYAPYXZqKI3g1GFZmnrzEgVa6jjBFa/aMcqWmXa5Dc=; b=NtAv25hji32BSctbHNSG6hvgojalWPH/q2SbQ6HmZPxPxofhzszwXZbiKeVhObOPRu 9FGE5aT64rD+pIVxs5baems82rqFmheemeohT5g0YqsAUxq4VzJ0QDqpHV8+7kaKCHfM 7g09v5S3ArlX5RSV2C7h+c9p5TXpyTkOVveKkl1BdsSYSftFphmajGgdnfWZUd6TWOn3 V95i0Yav3ECduA2ieGEHHnkRoEckdthoggrF0Hc7vGnmtdWsoz+pbgAWGuTbW+bfOdVJ k03tb/D35hhKdjGQUZLufVJhsvkPrSb9ks8YB8kPodnKxjU/Z0KyjAhF59cMnf/yDq1w bW6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5xYAPYXZqKI3g1GFZmnrzEgVa6jjBFa/aMcqWmXa5Dc=; b=q9nh24pdrzd4PYxmbe9WnGOtpW4nADTNd3oUfAtRrIXrtCBOGKPOPhIzwoShEV0/QH rHOmFk03J5wJ0OIBnvPDszCPTC/5PdxnJF9HkkPurkYf83ggvvWQ9DKxDx5zRc3EIUCK eM9eXTNLt+3nPAZD90u/96YEsk4GZ2+/mNS6aLxd1KsyRT2EYeeq0qG4rprQKaA6rv75 wGbbIlXHCoPemZr2i8j5mCMfrJ1vtBisxM/yednzO0do1OcMEEXJPNpMOAUKK/Rcan6x df5lkoE9evjFZK2SGh6SpbizXL4k/55/zGWKAnfAG2unPPuA7NLx6nI7oHa5aoOkHaJu LGnw== X-Gm-Message-State: AOAM5303MfA+R9xLb/8fvGy+Cb0syPQwjDc0CRyxkMLI+RsmLPEMODXX XjjqvoL97QDbiVX/WotpglSYXA== X-Received: by 2002:adf:f388:: with SMTP id m8mr15137432wro.338.1598434468397; Wed, 26 Aug 2020 02:34:28 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:27 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Jouni Malinen , Cong Wang , Taehee Yoo Subject: [PATCH 19/30] wireless: intersil: hostap: hostap_hw: Remove unused variable 'fc' Date: Wed, 26 Aug 2020 10:33:50 +0100 Message-Id: <20200826093401.1458456-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/intersil/hostap/hostap_cs.c:196: drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_tx_80211’: drivers/net/wireless/intersil/hostap/hostap_hw.c:1806:18: warning: variable ‘fc’ set but not used [-Wunused-but-set-variable] 1806 | u16 tx_control, fc; | ^~ In file included from drivers/net/wireless/intersil/hostap/hostap_plx.c:264: drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_tx_80211’: drivers/net/wireless/intersil/hostap/hostap_hw.c:1806:18: warning: variable ‘fc’ set but not used [-Wunused-but-set-variable] 1806 | u16 tx_control, fc; | ^~ In file included from drivers/net/wireless/intersil/hostap/hostap_pci.c:221: drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_tx_80211’: drivers/net/wireless/intersil/hostap/hostap_hw.c:1806:18: warning: variable ‘fc’ set but not used [-Wunused-but-set-variable] 1806 | u16 tx_control, fc; | ^~ Cc: Jouni Malinen Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Cong Wang Cc: Taehee Yoo Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intersil/hostap/hostap_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intersil/hostap/hostap_hw.c b/drivers/net/wireless/intersil/hostap/hostap_hw.c index b6c497ce12e12..a8aa8f64abe0c 100644 --- a/drivers/net/wireless/intersil/hostap/hostap_hw.c +++ b/drivers/net/wireless/intersil/hostap/hostap_hw.c @@ -1803,7 +1803,7 @@ static int prism2_tx_80211(struct sk_buff *skb, struct net_device *dev) struct hfa384x_tx_frame txdesc; struct hostap_skb_tx_data *meta; int hdr_len, data_len, idx, res, ret = -1; - u16 tx_control, fc; + u16 tx_control; iface = netdev_priv(dev); local = iface->local; @@ -1826,7 +1826,6 @@ static int prism2_tx_80211(struct sk_buff *skb, struct net_device *dev) /* skb->data starts with txdesc->frame_control */ hdr_len = 24; skb_copy_from_linear_data(skb, &txdesc.frame_control, hdr_len); - fc = le16_to_cpu(txdesc.frame_control); if (ieee80211_is_data(txdesc.frame_control) && ieee80211_has_a4(txdesc.frame_control) && skb->len >= 30) { From patchwork Wed Aug 26 09:33:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248391 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4156730ils; Wed, 26 Aug 2020 02:37:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynKQ/z7K2Dg8MndF+9ZVgsijSwZdu+RwgQxlU84yUPStQPdrxRaYLi88U+M7JInrQ+Jt28 X-Received: by 2002:a17:906:768c:: with SMTP id o12mr14266358ejm.269.1598434665483; Wed, 26 Aug 2020 02:37:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434665; cv=none; d=google.com; s=arc-20160816; b=O2SOulCszpXiVx3nx2I8VR/JFri5QsLMMiXg1P5Zg2QnK2U1P6UI0z/MjOx9fFfb2T ZaEFo6iIKRRSHUdMhoLmcDieqcqQ3vWDOf2PjRr2yn9zenu7skf57jYfKptFj736U6rl EofjOP7xYXkb8JcFUVnRKsObLWsrLuam4Wva+/KrVkH3eENwPJBErK6ndDpNJA99gl1W 5ol0TIShURbq8/wto/6d2nyKeM4WnRMUCaN3YeNyHiZzBpj1pfcfJroWnPWsZa7NIISH zFj1mBvPesc6u6cVX6/NHZBYXDTb137b8PTchkOVbEvHFsWzwzewJU9SQ/zq0ByWcWKU mmAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xyQoG+wQHbbYlAwDR9Bn2T0hbUw5R72XJoccL9iEkJo=; b=Imulu6KCJjUDhuzgbAJubxnYTvedM8c9rLCJVtpfDIhZN3c+HKsg8YLfdUTf8yOFU/ U38jeTv4T2r8G6wqCuew3JIawHZHy/9VYAfZ1GTNlaeR/Lj2P+GTwzECrSHCQMOF6cbr ril1Wn4g2fL95Z3nJ7+3nzD1j9aQOmfZvSRRYsOpc+romSQn6T+dLVvJfk6CK8r/GFFr pf1A7H9GzY+U2tZDA9WSypJMk6xDwXi+HGxKeq8GIojISwXsXSu3oIRAOKGf6uQIM0sg GbnCozM7ScNzQQ6XEJ/DiBY6ZKDj0Vu14rD1LlRqtjXPkRVjKZzRYtOxTijR5w+KrGsF skmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FNLJxtoV; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p26si1007848edt.197.2020.08.26.02.37.45; Wed, 26 Aug 2020 02:37:45 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FNLJxtoV; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728590AbgHZJhi (ORCPT + 9 others); Wed, 26 Aug 2020 05:37:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728354AbgHZJfD (ORCPT ); Wed, 26 Aug 2020 05:35:03 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7CFEC061348 for ; Wed, 26 Aug 2020 02:34:30 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id y3so1097976wrl.4 for ; Wed, 26 Aug 2020 02:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xyQoG+wQHbbYlAwDR9Bn2T0hbUw5R72XJoccL9iEkJo=; b=FNLJxtoVrKxlB4vCGPDuiCbB7S8XUvS4J1q45/v6Sr8NhRJ4fqNYXpCC4jETbEERE9 FxJosK13MYeGiugDoo1nLglq3De76KFu635G5p6i4E2KZqLOxscfPcB1eCOW5gMx4FUY qlTX4l31OguD2Dp9d561huIcQI/T+v2mpk6+DOzk2sLo/VOamMqvm+BcEPHf+Ay1xNjJ O1o/W8gkYG9ObrHJe7y2KcQYwOfZDjcDdw1iZV5wVAghQFzizdtHurIlWrk0QoP5gfnQ SxvGVQHSR/AxztB/6C/sZF3+AkIlQO/1Unajvzj3Jv/RqaVVk1yctcZiUqbI0ESq6mh3 BtaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xyQoG+wQHbbYlAwDR9Bn2T0hbUw5R72XJoccL9iEkJo=; b=Gpm7TeuIfoSJtvVPvaGkiWOSiPzQbbj3l5jKrP4mc+AqRWcKHyW1EVEL+kKPfix7iW d0G8jLpd2pxJRrNJgX73hszPXNOzkKNZl3U/fKM1+I2pBMkJzGcwWdhU2Azlzfh+Dj/j H4SQQHyq+I80JqsTKwhdfAMcNiHm1CMG1n9JJevIAOVmcy+ePEJTotgrzAxV+nBpyo3K e8gEEYFDlKm709n0HeeJPlaNlzHFWfVS8dKa4au2OpSzPuJKs8VNqsceBiB4WVGpbSEO J3g+Ve6tKgC68xNwTio/uJq8Qi074GMPenbveGmsRYkRivKaim2bQmx+OxFDik0aiSqi tC3w== X-Gm-Message-State: AOAM533RsLraW+oIxweuBI/hGCULqYu4u9+nLWctUK+niEHdrAhpBX0G JJp1miv+1me/v298BIjeNoE1Cw== X-Received: by 2002:a5d:63c2:: with SMTP id c2mr14485590wrw.346.1598434469550; Wed, 26 Aug 2020 02:34:29 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:29 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Fox Chen , de Melo , Gustavo Niemeyer Subject: [PATCH 20/30] wireless: wl3501_cs: Fix a bunch of formatting issues related to function docs Date: Wed, 26 Aug 2020 10:33:51 +0100 Message-Id: <20200826093401.1458456-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/wl3501_cs.c:57: drivers/net/wireless/wl3501_cs.c:143: warning: Function parameter or member 'reg_domain' not described in 'iw_valid_channel' drivers/net/wireless/wl3501_cs.c:143: warning: Function parameter or member 'channel' not described in 'iw_valid_channel' drivers/net/wireless/wl3501_cs.c:162: warning: Function parameter or member 'reg_domain' not described in 'iw_default_channel' drivers/net/wireless/wl3501_cs.c:248: warning: Function parameter or member 'this' not described in 'wl3501_set_to_wla' drivers/net/wireless/wl3501_cs.c:270: warning: Function parameter or member 'this' not described in 'wl3501_get_from_wla' drivers/net/wireless/wl3501_cs.c:467: warning: Function parameter or member 'this' not described in 'wl3501_send_pkt' drivers/net/wireless/wl3501_cs.c:467: warning: Function parameter or member 'data' not described in 'wl3501_send_pkt' drivers/net/wireless/wl3501_cs.c:467: warning: Function parameter or member 'len' not described in 'wl3501_send_pkt' drivers/net/wireless/wl3501_cs.c:729: warning: Function parameter or member 'this' not described in 'wl3501_block_interrupt' drivers/net/wireless/wl3501_cs.c:746: warning: Function parameter or member 'this' not described in 'wl3501_unblock_interrupt' drivers/net/wireless/wl3501_cs.c:1124: warning: Function parameter or member 'irq' not described in 'wl3501_interrupt' drivers/net/wireless/wl3501_cs.c:1124: warning: Function parameter or member 'dev_id' not described in 'wl3501_interrupt' drivers/net/wireless/wl3501_cs.c:1257: warning: Function parameter or member 'dev' not described in 'wl3501_reset' drivers/net/wireless/wl3501_cs.c:1420: warning: Function parameter or member 'link' not described in 'wl3501_detach' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Fox Chen Cc: de Melo Cc: Gustavo Niemeyer Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/wl3501_cs.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/wl3501_cs.c b/drivers/net/wireless/wl3501_cs.c index 686161db8706c..4e7a2140649b4 100644 --- a/drivers/net/wireless/wl3501_cs.c +++ b/drivers/net/wireless/wl3501_cs.c @@ -134,8 +134,8 @@ static const struct { /** * iw_valid_channel - validate channel in regulatory domain - * @reg_comain - regulatory domain - * @channel - channel to validate + * @reg_comain: regulatory domain + * @channel: channel to validate * * Returns 0 if invalid in the specified regulatory domain, non-zero if valid. */ @@ -154,7 +154,7 @@ static int iw_valid_channel(int reg_domain, int channel) /** * iw_default_channel - get default channel for a regulatory domain - * @reg_comain - regulatory domain + * @reg_domain: regulatory domain * * Returns the default channel for a regulatory domain */ @@ -237,6 +237,7 @@ static int wl3501_get_flash_mac_addr(struct wl3501_card *this) /** * wl3501_set_to_wla - Move 'size' bytes from PC to card + * @this: Card * @dest: Card addressing space * @src: PC addressing space * @size: Bytes to move @@ -259,6 +260,7 @@ static void wl3501_set_to_wla(struct wl3501_card *this, u16 dest, void *src, /** * wl3501_get_from_wla - Move 'size' bytes from card to PC + * @this: Card * @src: Card addressing space * @dest: PC addressing space * @size: Bytes to move @@ -455,7 +457,7 @@ static int wl3501_pwr_mgmt(struct wl3501_card *this, int suspend) /** * wl3501_send_pkt - Send a packet. - * @this - card + * @this: Card * * Send a packet. * @@ -720,7 +722,7 @@ static void wl3501_mgmt_scan_confirm(struct wl3501_card *this, u16 addr) /** * wl3501_block_interrupt - Mask interrupt from SUTRO - * @this - card + * @this: Card * * Mask interrupt from SUTRO. (i.e. SUTRO cannot interrupt the HOST) * Return: 1 if interrupt is originally enabled @@ -737,7 +739,7 @@ static int wl3501_block_interrupt(struct wl3501_card *this) /** * wl3501_unblock_interrupt - Enable interrupt from SUTRO - * @this - card + * @this: Card * * Enable interrupt from SUTRO. (i.e. SUTRO can interrupt the HOST) * Return: 1 if interrupt is originally enabled @@ -1110,8 +1112,8 @@ static inline void wl3501_ack_interrupt(struct wl3501_card *this) /** * wl3501_interrupt - Hardware interrupt from card. - * @irq - Interrupt number - * @dev_id - net_device + * @irq: Interrupt number + * @dev_id: net_device * * We must acknowledge the interrupt as soon as possible, and block the * interrupt from the same card immediately to prevent re-entry. @@ -1247,7 +1249,7 @@ static int wl3501_close(struct net_device *dev) /** * wl3501_reset - Reset the SUTRO. - * @dev - network device + * @dev: network device * * It is almost the same as wl3501_open(). In fact, we may just wl3501_close() * and wl3501_open() again, but I wouldn't like to free_irq() when the driver @@ -1410,7 +1412,7 @@ static struct iw_statistics *wl3501_get_wireless_stats(struct net_device *dev) /** * wl3501_detach - deletes a driver "instance" - * @link - FILL_IN + * @link: FILL_IN * * This deletes a driver "instance". The device is de-registered with Card * Services. If it has been released, all local data structures are freed. From patchwork Wed Aug 26 09:33:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248390 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4156600ils; Wed, 26 Aug 2020 02:37:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMfpJWV0tLRECr5y/JDr1eItu/58K+zZniUWSpn03g1cz65jlxaNE1UBWTkPAIf470D1ZA X-Received: by 2002:a17:906:2f07:: with SMTP id v7mr15445494eji.313.1598434651280; Wed, 26 Aug 2020 02:37:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434651; cv=none; d=google.com; s=arc-20160816; b=d/skZTbkS6Q+jXP6xHzYj/L2EVO0wN653Pda7frUpz6rvbqVsytNW7qkNcRomhisea 5LR/KYiV+++lrN8kswzRlLQJi4HLTH+FecoFN7b+yQ1EaVlAYH3vzpThexVZCDw4smUr qyyZdsjCWnBrCAkFRnlbduOt0XU+ugid02xgxb/Aq8nRFV2OS4TXNKRJ3aYDYGl+pwHL amM/y02A0KJEySTP5mMiINDAwtTyDF6e/Te+pgLo89epYiG4AWPpG8sKZfe3h2WvPMV8 VfPz4JujWWo+FcJGQW3KnB1/aPHU2szVmqd9fhVO7xoH90rpOEObktXY8l/nu1SSWDk+ iFlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=B4E9cSfXHfJFsjO894WOptYPwQ5/EooDFGNjs8a9MbA=; b=bMV8jNPkHCQ1XaZ+eD1Bv8SJkPlDo+u3SJW/92/UY984PiXFzIv4xqzvGyJV2xjlOe uz4hIpE88UvZepF9OqNknGFUQ3Fe7Jv8YMiLNhV+TRaD5MGEczp+Zew/7YnK+dcEter7 Lfvj8zEOhjqqOWwj3B2ZqJ9+z1sYNwRLGlwCvnu4hs2u0PmJ+4Po+sTuSckcGUEqDWYR AnCLJh6J69TWk4F/ZG9uyqnXefx5ANGw8rBUF1vgEPmTf11awbMYXrFu2V+UPwv9bTgX 3o71UFdCnxZefqFbN9lj1MT2IHho+9GgVhG/yEU4+oLP5wf7y6K4SJ86C76hPkJh11Gu lDPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r726au1U; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n23si1229200eja.606.2020.08.26.02.37.31; Wed, 26 Aug 2020 02:37:31 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r726au1U; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728381AbgHZJha (ORCPT + 9 others); Wed, 26 Aug 2020 05:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728360AbgHZJfG (ORCPT ); Wed, 26 Aug 2020 05:35:06 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6B8C06134D for ; Wed, 26 Aug 2020 02:34:33 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o21so1081439wmc.0 for ; Wed, 26 Aug 2020 02:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B4E9cSfXHfJFsjO894WOptYPwQ5/EooDFGNjs8a9MbA=; b=r726au1UQ7kMPGArZ786mhNfI/fKyc+1LUzeKJihwwMlnchKe/lERgKWP64vUe1I1Y Y0gkWO+MPKS9vCVA2CQ+NstGLZ63RejpdbctRvfT/O7Br7lKyGN2whD+FK7eGP6I0w0u Sq6lNnWp4FSZ8OzaKrEziBms5T7UgFNJ3+KNg8l3iN7zNMfgcCvZIckv1RLy+/1a1foE zfbyQo4Ui+txno8sEohJnzczCJrpoaoIp4z/btaJoG/G/DCpeSfEQdE9xuNW5GrxPtxv UwaPGRS5aS9vlfJLt/8F40AvQeYwr5xL+xXX9FEUqRWEatyULgQBmdICjlGQjsnkwmQb 632w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B4E9cSfXHfJFsjO894WOptYPwQ5/EooDFGNjs8a9MbA=; b=nXa8zvieNWriczTRsdljRPfAHYtAd+bqvmg3YRoM5nGV7teneH9BdrBU0wT2UoqSAd qq31DEcHql7zSa1RikQ8jUvvxwNzLNvf4ywbEec/OHrjYPpNnU+oEDma9VS/IbMZ7Chm AHpNWAVww3IwLecmZIn4dE6/ynt9sDPaIf2uftcsgXKL73bgGQi56VdbBX3Pvth33wPR SakEkwyeOzzIBiWV6qUGj91kWP+SVRhkY/HJHn0AD/C8jYg9wfdWNSVXd7bpfNusJMaT 9orUT+7ytcVwYuW/dLIIMkXVRWcwqD890LEIYRP5YnwR+FBTabYgBp+QjW0OZ6FN1o4M oLkw== X-Gm-Message-State: AOAM530L6MZahrsb/opqxniymb6NFNXomIwlRAM6H6NqT/W++lkVC2/W GlBso844skAXNR4/IG1QDRReAA== X-Received: by 2002:a1c:e4c3:: with SMTP id b186mr6112239wmh.84.1598434471957; Wed, 26 Aug 2020 02:34:31 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:31 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Amitkumar Karwar , Siva Rebbagondla Subject: [PATCH 22/30] wireless: rsi: rsi_91x_sdio_ops: File headers are not good kernel-doc candidates Date: Wed, 26 Aug 2020 10:33:53 +0100 Message-Id: <20200826093401.1458456-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/rsi/rsi_91x_sdio_ops.c:24: warning: Incorrect use of kernel-doc format: * rsi_sdio_master_access_msword() - This function sets the AHB master access drivers/net/wireless/rsi/rsi_91x_sdio_ops.c:32: warning: Function parameter or member 'adapter' not described in 'rsi_sdio_master_access_msword' drivers/net/wireless/rsi/rsi_91x_sdio_ops.c:32: warning: Function parameter or member 'ms_word' not described in 'rsi_sdio_master_access_msword' Cc: Amitkumar Karwar Cc: Siva Rebbagondla Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio_ops.c b/drivers/net/wireless/rsi/rsi_91x_sdio_ops.c index 449f6d23c5e36..7825c9a889d36 100644 --- a/drivers/net/wireless/rsi/rsi_91x_sdio_ops.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio_ops.c @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2014 Redpine Signals Inc. * * Permission to use, copy, modify, and/or distribute this software for any From patchwork Wed Aug 26 09:33:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 261917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD0FC433E1 for ; Wed, 26 Aug 2020 09:37:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1F152087D for ; Wed, 26 Aug 2020 09:37:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s03wRDxS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728379AbgHZJh0 (ORCPT ); Wed, 26 Aug 2020 05:37:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728380AbgHZJfH (ORCPT ); Wed, 26 Aug 2020 05:35:07 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F9BAC06134F for ; Wed, 26 Aug 2020 02:34:34 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id p17so1090308wrj.8 for ; Wed, 26 Aug 2020 02:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yvoQanaWTpWNQEXwywlAc7o43dgHa3QRlp1C/cAGUU4=; b=s03wRDxSuZJrkgF2oUckm/dxkHDlEzj7UzMo4Rqm6Jg4UF21WboPJXhBjmsdYI44VB T80Qv+u/ejdXfR88W2SGz656OtO/FWRBPOKx1iuuWvDdQrNMTfC5JE0nyJWAnusYydDc GOPazXC8CxR2wMTlSrN063oegcaXdEmuxL7OHTkh89TSmAWGWQJIp8QMfdTY51HreW3U kc8nEWXR50Oqtd60Nj305DBmXokL7F6Yf9ZUX0h/JTqLq9oSZV5GdQmUxXwIKir3clme AOdeWWnagZRvMsJg5BwaVzJpqvtcPMKSGuJ6WkwKZbXsyz1GFTc1PqqJ+D0GvAOe2vAZ 2yhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yvoQanaWTpWNQEXwywlAc7o43dgHa3QRlp1C/cAGUU4=; b=POg0e7KXgKdTCIYwwyWbR4sJ3Db5ujUEVaeqGnVqZ/60a3fZDAO71YuIxe+jvreq6v Ebyfc5iyRbffQvvEQ+8eTmXZjW5uaXFX9rNnahZroBtth5W/TzDUgG0+CcRIdzxI5iZl GEfpyID8I0H3ZQDlH56vbnw31vd6Rkqsvlu1QAGnq8a9HkOD9UuXKywxGp6VPgZgrTLM rQxwH0kdbPC2Vp5W2D5CE9Vu3ksLIPhkrAM5OXVDsNMWqGQsOwPRu5OeOguA/AWqoxJR ISHDPuHEr+FOAAsZWBXrmQvXOG72x8W0KszdUAzRXZvfznhSlutjrWR/bCIY2TZpap4R rB+A== X-Gm-Message-State: AOAM531SbQx1q8cltvOnyq8QjCMqKyv5XwaJoIvfBYYy010QxoDvAxuL 3yZN3DkhjYJeYbJAoa5Dn8khvA== X-Google-Smtp-Source: ABdhPJxOfF7uQYb9qaD3r7dWTNKRZIkhB0UM17JPesq9XXKWzSzFYvmfyfGy2TKdAm+01oYhG5XIAA== X-Received: by 2002:a5d:43ca:: with SMTP id v10mr14464274wrr.299.1598434473214; Wed, 26 Aug 2020 02:34:33 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:32 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Luis Chamberlain , Aurelien Alleaume , Valerio Riedel , "Luis R. Rodriguez" Subject: [PATCH 23/30] wireless: intersil: prism54: isl_ioctl: Remove unused variable 'j' Date: Wed, 26 Aug 2020 10:33:54 +0100 Message-Id: <20200826093401.1458456-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intersil/prism54/isl_ioctl.c: In function ‘prism54_update_stats’: drivers/net/wireless/intersil/prism54/isl_ioctl.c:166:6: warning: variable ‘j’ set but not used [-Wunused-but-set-variable] Cc: Luis Chamberlain Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Aurelien Alleaume Cc: Valerio Riedel Cc: "Luis R. Rodriguez" Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intersil/prism54/isl_ioctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/intersil/prism54/isl_ioctl.c b/drivers/net/wireless/intersil/prism54/isl_ioctl.c index 3ccf2a4b548c6..5c49b9e52a0c4 100644 --- a/drivers/net/wireless/intersil/prism54/isl_ioctl.c +++ b/drivers/net/wireless/intersil/prism54/isl_ioctl.c @@ -163,7 +163,6 @@ prism54_update_stats(struct work_struct *work) { islpci_private *priv = container_of(work, islpci_private, stats_work); char *data; - int j; struct obj_bss bss, *bss2; union oid_res_t r; @@ -187,7 +186,7 @@ prism54_update_stats(struct work_struct *work) kfree(data); /* now ask for the corresponding bss */ - j = mgt_get_request(priv, DOT11_OID_BSSFIND, 0, (void *) &bss, &r); + mgt_get_request(priv, DOT11_OID_BSSFIND, 0, (void *) &bss, &r); bss2 = r.ptr; /* report the rssi and use it to calculate * link quality through a signal-noise From patchwork Wed Aug 26 09:33:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 261918 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7368EC433E1 for ; Wed, 26 Aug 2020 09:37:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A3EE2087D for ; Wed, 26 Aug 2020 09:37:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oROYULir" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728553AbgHZJhE (ORCPT ); Wed, 26 Aug 2020 05:37:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728384AbgHZJfJ (ORCPT ); Wed, 26 Aug 2020 05:35:09 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA37BC061358 for ; Wed, 26 Aug 2020 02:34:35 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f7so1110994wrw.1 for ; Wed, 26 Aug 2020 02:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wOk7+v5tRA8kQkojRiep+oFsY19pnrxzjDBrN8NxzU0=; b=oROYULirz7RycKlFmz17ODwkIRUf3Ag8qwgHItHR6BX/j/SEk6NQew0g/BRgEMzKRt tt5Jo4BYLTEgPjhR8lr8ljhURcObcNyebw4VhcIRTD8tNDzT+tN9XWFK/g1IEDDze0lo cVcmlCZWZ3+6bIsZPPUPS6/6TB7U+uwepRDGIDC6wHM5H0TXN7N+u6megW0Hfk/fhUh9 7ay25LPBDBt4KObWLrnNxDdAtrhYcz0n+4RItNhX+gnxbxzecxQt4SWzH3BOKu5ViVg0 KQqLjd3R2nlk95hbvc6xpBfj9zdeQaaNiOxwWcq04YmdmBtGeOwgHTAtW9TERdqwx4W4 y2MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wOk7+v5tRA8kQkojRiep+oFsY19pnrxzjDBrN8NxzU0=; b=C9gmQZWRH2MNYKYBGwJoUFgSMyOZ7CIMvps3PhC0IWhWuGUBFj5LcYy66RKFzYX76o 8G/R1lHlDvsueWjcGs4fqYcsI+FXgldST8MfCDCJdBXGd0H6lrdHWa1Ny4rfQT1i2occ +JjtraQP05HONEndbgC1YKaQvpofZsxHpYjk3h0OmqMvk6KOF0Z3XceqCsHYvaho++Fd vWRSFD1os++Io4+cat2DPFbu4AUWBNf1J0bnzWB7XnB2DSgLiC7s7pJJYKYQbsD4N/L/ UIzRYNdmV5GBexqg3uHRcnC5+t+QTVqECuVD7aLYoly6ql+Hy1A/Ga3Xmoq/9QqDSBMg IujQ== X-Gm-Message-State: AOAM530SowIIWSrMWSNNE4Qd8ruGw4KaXd1NoSjaRaXOWLuRIpc5dWQc tTqH8JlZWlapYkcYzco/frU4YA== X-Google-Smtp-Source: ABdhPJycFcwRj1JjehKwx0tcqJuFWgg2Bt6DGFQBYF0/uRC61ugktaO9SXdUglT0sloncVXp09skjQ== X-Received: by 2002:adf:fe90:: with SMTP id l16mr15018301wrr.345.1598434474431; Wed, 26 Aug 2020 02:34:34 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:33 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu Subject: [PATCH 24/30] wireless: marvell: mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as __maybe_unused Date: Wed, 26 Aug 2020 10:33:55 +0100 Message-Id: <20200826093401.1458456-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 'mwifiex_1d_to_wmm_queue' is used in'; main.c, txrx.c and uap_txrx.c ... but not used in 14 other source files which include 'wmm.h'. Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/marvell/mwifiex/init.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/cmdevt.c:26: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/util.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/wmm.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/11n.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/11n_aggr.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/marvell/mwifiex/11n.h:25, from drivers/net/wireless/marvell/mwifiex/scan.c:25: drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; | ^~~~~~~~~~~~~~~~~~~~~~~ NB: Many entries - snipped for brevity. Cc: Amitkumar Karwar Cc: Ganapathi Bhat Cc: Xinming Hu Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/marvell/mwifiex/wmm.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/wmm.h b/drivers/net/wireless/marvell/mwifiex/wmm.h index 60bdbb82277a3..58bcd84b050c5 100644 --- a/drivers/net/wireless/marvell/mwifiex/wmm.h +++ b/drivers/net/wireless/marvell/mwifiex/wmm.h @@ -31,7 +31,8 @@ enum ieee_types_wmm_ecw_bitmasks { MWIFIEX_ECW_MAX = (BIT(4) | BIT(5) | BIT(6) | BIT(7)), }; -static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; +static const u16 __maybe_unused +mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; /* * This function retrieves the TID of the given RA list. From patchwork Wed Aug 26 09:33:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248382 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155754ils; Wed, 26 Aug 2020 02:35:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFts6tRfT8rHuKOwk8x3lXuIBimoPWtvO8V4utNoQAU5gUFr7bZE56IDuAfhtLDtNrhvbN X-Received: by 2002:a50:9e4c:: with SMTP id z70mr13821966ede.384.1598434551697; Wed, 26 Aug 2020 02:35:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434551; cv=none; d=google.com; s=arc-20160816; b=JovcomS3mMnAEnTFa82Z6vni26+MdifX4SwCS1I53pTnXk35iyLpNfpAN7GTlzxFNl tmOYnGMqxlKcQvWm76ui95B0KZKqDS2SchV96YPsLRdSJgBr3q+2MBrvAl8rcfgzSJDO j9S9c0I6T0gsku2PldMtaRryhQVp30ZGosRf046ZV+OLrplgPIHDMirx65LCzF8qyVpx j68fF8evIoammC9nQkjKOjyKwJcfvNYQK3VEJZe8zaPo3fhcFJoYEJB8y70WlLZXNuDw XdaYpdiWbavkylj8uEgm83ENa8eoUmMko0r4Nwd9Ok4trXthQ4EcSROQDtvFmwyOTSiT 29PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7UKR3rYf74POYGl3zWTm2JLEunC4uofhzAPfhP0pocI=; b=L8G2IBdr1dNKC93wFDYkYvAYABgy88hoUlfr0X87HLoUNy9571rACzlQpOFBRuvTMZ m082S8LITdza8gRXtj5rI7fKzfAWoJxwKJVSxUMoh0JFsUtHg0IOhmvVBwIaC3Sw7a6P L0wyqSEtQcEwRTK7C7mjXTQ/iT2ldIcTkoHEDMwWRlzJ7LYYVWjPi0K2egc+ova6YC59 VjBmIc5ZCUq33zfTW6GqYQ91LDetEM2qayPdIFD8OG6RHi6I/eBWK1bZRB3X2n4BWdDG VMKxmK4DAQjzpsmWWfoI6RC/WPJ8m4ToZ8Yck4x6hzIVxNwulM4HrGLnjPiiSVh6iDuK p3zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="AwyjC/u6"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1160336ejd.721.2020.08.26.02.35.51; Wed, 26 Aug 2020 02:35:51 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="AwyjC/u6"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728450AbgHZJfg (ORCPT + 9 others); Wed, 26 Aug 2020 05:35:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728357AbgHZJfV (ORCPT ); Wed, 26 Aug 2020 05:35:21 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 164FEC06135F for ; Wed, 26 Aug 2020 02:34:38 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id h15so1081736wrt.12 for ; Wed, 26 Aug 2020 02:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7UKR3rYf74POYGl3zWTm2JLEunC4uofhzAPfhP0pocI=; b=AwyjC/u6v4PkRTDEUzW5YTwptUu33aZaKickGcM2cAwHsFaZSh3VUhKDX1bvVBJrSO 4bz4KBORUASDwdQfqAKx3d88J5wrfhGzYxAKrmqBGECjC3c7CnDdGYkY9lBhDFCymUQj EDw6sSFzrbfef9cPsOW9n3jp+dy66uiSFPNf83D/FHYRlKG88XLNNq96ZivWt25TfrVT sdHCBVi+qgdfiq6w8seV/4/KZ/BtO3IBixxQ1EQOKk/to29iEE5l7cDQF8IjNQg4bB7S Rc3gzyrMcyijHr9sVaD/IuJGXpKovsNCxwzzB1BfVsNpF+pBAnlBEJs/Qp9ie+YpI0MZ o1lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7UKR3rYf74POYGl3zWTm2JLEunC4uofhzAPfhP0pocI=; b=lGAUhZIDfHdLwbI9R3BgZiuJErpVS/x/KQMFbhLRj8nhDNl8T23LGQFPk7pZf6PYXG qBN19OaymD2D5hezgVGSj02j7xci8FVTBZlFJ0ZvWk8Vevxvtl/L3tgh9Eg/YMSU3bI/ suD3M5fxYPo4V3mZxaP0O/26s3Y6SvoqYBTRN1DC9tzmsXPXlDtUXxnbbmAiqV4gKse0 985gryhfFpEyjXrs0+H3ml90JJFHsI+htTNkGU/mY4xwJeIs4mX5bIANz2lSxlcojSFX UcqhO3+QLTY18SCHpuNx+LaCPPKpEsOrBlLRhOKvUwzh2JFoPGCe+S12g8W8UXsWsecA qoJg== X-Gm-Message-State: AOAM533KsZxZYOpgFIF1pBxGFc7cbplxrbCYTEGCPWokrXgxmlBhbVcp o3JQyfsYHM17siabjqCbJlL1Rg== X-Received: by 2002:adf:fc02:: with SMTP id i2mr8811277wrr.165.1598434476657; Wed, 26 Aug 2020 02:34:36 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:35 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , QCA ath9k Development Subject: [PATCH 26/30] wireless: ath: ath9k: ar5008_initvals: Move ar5416Bank{0, 1, 2, 3, 7} to where they are used Date: Wed, 26 Aug 2020 10:33:57 +0100 Message-Id: <20200826093401.1458456-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar5008_initvals.h:627:18: warning: ‘ar5416Bank7’ defined but not used [-Wunused-const-variable=] 627 | static const u32 ar5416Bank7[][2] = { | ^~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ar5008_initvals.h:548:18: warning: ‘ar5416Bank3’ defined but not used [-Wunused-const-variable=] 548 | static const u32 ar5416Bank3[][3] = { | ^~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ar5008_initvals.h:542:18: warning: ‘ar5416Bank2’ defined but not used [-Wunused-const-variable=] 542 | static const u32 ar5416Bank2[][2] = { | ^~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ar5008_initvals.h:536:18: warning: ‘ar5416Bank1’ defined but not used [-Wunused-const-variable=] 536 | static const u32 ar5416Bank1[][2] = { | ^~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ar5008_initvals.h:462:18: warning: ‘ar5416Bank0’ defined but not used [-Wunused-const-variable=] 462 | static const u32 ar5416Bank0[][2] = { | ^~~~~~~~~~~ Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar5008_initvals.h | 31 ------------------- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 31 ++++++++++++++++++- 2 files changed, 30 insertions(+), 32 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h index 8d251600d8458..7da8365ae69a8 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h @@ -459,12 +459,6 @@ static const u32 ar5416Common[][2] = { {0x0000a3e0, 0x000001ce}, }; -static const u32 ar5416Bank0[][2] = { - /* Addr allmodes */ - {0x000098b0, 0x1e5795e5}, - {0x000098e0, 0x02008020}, -}; - static const u32 ar5416BB_RfGain[][3] = { /* Addr 5G 2G */ {0x00009a00, 0x00000000, 0x00000000}, @@ -533,23 +527,6 @@ static const u32 ar5416BB_RfGain[][3] = { {0x00009afc, 0x000000f9, 0x000000f9}, }; -static const u32 ar5416Bank1[][2] = { - /* Addr allmodes */ - {0x000098b0, 0x02108421}, - {0x000098ec, 0x00000008}, -}; - -static const u32 ar5416Bank2[][2] = { - /* Addr allmodes */ - {0x000098b0, 0x0e73ff17}, - {0x000098e0, 0x00000420}, -}; - -static const u32 ar5416Bank3[][3] = { - /* Addr 5G 2G */ - {0x000098f0, 0x01400018, 0x01c00018}, -}; - static const u32 ar5416Bank6TPC[][3] = { /* Addr 5G 2G */ {0x0000989c, 0x00000000, 0x00000000}, @@ -587,13 +564,6 @@ static const u32 ar5416Bank6TPC[][3] = { {0x000098d0, 0x0000000f, 0x0010000f}, }; -static const u32 ar5416Bank7[][2] = { - /* Addr allmodes */ - {0x0000989c, 0x00000500}, - {0x0000989c, 0x00000800}, - {0x000098cc, 0x0000000e}, -}; - static const u32 ar5416Addac[][2] = { /* Addr allmodes */ {0x0000989c, 0x00000000}, @@ -634,4 +604,3 @@ static const u32 ar5416Addac[][2] = { {0x0000989c, 0x00000000}, {0x000098c4, 0x00000000}, }; - diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c index dae95402eb3a9..55b2d9aa080d5 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c @@ -18,7 +18,6 @@ #include "hw-ops.h" #include "../regd.h" #include "ar9002_phy.h" -#include "ar5008_initvals.h" /* All code below is for AR5008, AR9001, AR9002 */ @@ -51,6 +50,36 @@ static const int m2ThreshLowExt_off = 127; static const int m1ThreshExt_off = 127; static const int m2ThreshExt_off = 127; +static const u32 ar5416Bank0[][2] = { + /* Addr allmodes */ + {0x000098b0, 0x1e5795e5}, + {0x000098e0, 0x02008020}, +}; + +static const u32 ar5416Bank1[][2] = { + /* Addr allmodes */ + {0x000098b0, 0x02108421}, + {0x000098ec, 0x00000008}, +}; + +static const u32 ar5416Bank2[][2] = { + /* Addr allmodes */ + {0x000098b0, 0x0e73ff17}, + {0x000098e0, 0x00000420}, +}; + +static const u32 ar5416Bank3[][3] = { + /* Addr 5G 2G */ + {0x000098f0, 0x01400018, 0x01c00018}, +}; + +static const u32 ar5416Bank7[][2] = { + /* Addr allmodes */ + {0x0000989c, 0x00000500}, + {0x0000989c, 0x00000800}, + {0x000098cc, 0x0000000e}, +}; + static const struct ar5416IniArray bank0 = STATIC_INI_ARRAY(ar5416Bank0); static const struct ar5416IniArray bank1 = STATIC_INI_ARRAY(ar5416Bank1); static const struct ar5416IniArray bank2 = STATIC_INI_ARRAY(ar5416Bank2); From patchwork Wed Aug 26 09:33:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248381 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155704ils; Wed, 26 Aug 2020 02:35:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdiuH3GobFcfO6pSnCM72MtqImzDNG6j/QdosXYwnip+yt2UGzL6xFkUlEko35jnEn4uJt X-Received: by 2002:a17:906:a219:: with SMTP id r25mr15181355ejy.201.1598434547146; Wed, 26 Aug 2020 02:35:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434547; cv=none; d=google.com; s=arc-20160816; b=KG9hPOr7Yg5K6xZIwAv4GIwEto22Mu3f7/mQ9AKXa4b07iEM3fqJXG4G5fQxzajH7I A7Yoj8N/E0RxR0yygP/ZLEhI8frN4OCjQmSuGgv8+UGuVR32fBgqndbpCfRHKYRYDaLN QF9woetk/aClSfuKZry8c6cpn6s8ZBdUfieGhKCX1GnU6LhjOhAyKO+axZfK0xZwlmAy 3KBi8thZa5ZktrpNfgdQ5NusxiKrdtjWLQu8DnLiNlsulwvNDgelUoYRhMSvhVzG8yoe iSGEzwalT7i5rDGZ/2fONNvoh/BZHreIytx8st4L/sMvu9+LjnH8khff2cypVVf8iAgz IayQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rUAO3RuW/3xrjV/jLQoBhZg+qrtryFN4uR4f5U2383M=; b=xjH9nBs5pqd1f+9eKiTFKlmcJMkkvWNlyb9VG2pNYi7TvyaLujhStJHnEDWQSq84qU iUZaXGKRGeNy6QlDG2ZhBzIB39h6gp71coGh9aO6FxCqms55tLiVgn8nUIghR5AosY6j x62rl/vYycuVXNM9u1zp3uWG0ZBgL1gl0mBzaYji4QANeULRMOgKzb269F6QfZYzrBsR 13pHxQKUxQlARo6hvWr7R7ASen9ZUTaN4nw31PrAn7bG6kb2iN/gbxWT/eqxH19utjP5 3/UUd0/E1ja60rIi94pU0By+/XlY3IUpjp92WUni5e8H3TmSiaxnBO6oONy0jvp4stmQ h3Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=As6cWuop; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1160336ejd.721.2020.08.26.02.35.46; Wed, 26 Aug 2020 02:35:47 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=As6cWuop; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728463AbgHZJfl (ORCPT + 9 others); Wed, 26 Aug 2020 05:35:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728013AbgHZJfY (ORCPT ); Wed, 26 Aug 2020 05:35:24 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8F40C0617A1 for ; Wed, 26 Aug 2020 02:34:39 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id h15so1081837wrt.12 for ; Wed, 26 Aug 2020 02:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rUAO3RuW/3xrjV/jLQoBhZg+qrtryFN4uR4f5U2383M=; b=As6cWuop/UitBN8qYzmoyyS8vCPET7V+08ebuq6oQcV6utLW7d2Wq3FC6+itt/QdM6 vJWvBjw4LqqhgSlcfR1SELi/4siTNwvRB6Jm2f3cik6e6/b7x2u4BDO47TPxwO1L4R06 d9SF74TQV6b21kHyDGr+r/5Sh1/eAZ6zYtppbV1UA55rXGMppf4Vplbb/bDgaRpAWLUr EwMvE7zOItgvt5lcKzz6GBg/x7iSpWuPIPW3rdoADPuZNeFe5UKcu6EkPg/iFw9LVAKR 1ZHYlNVyF5FsBso5UfAsFt825rivgBwDix2VBBQxYxYMcMoiOs8n98V25qtafhCAAVV1 H2Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rUAO3RuW/3xrjV/jLQoBhZg+qrtryFN4uR4f5U2383M=; b=W4klB0O/A3R0VMxM85+z/9E1A5VS6PUUFqoGWar/rtocDh0w7u5fMVby34IPbVT0a4 SEnoddIO9enoq/95qSwDXd+SGQHBDjdYXcquJUYMFEs/+YSLDqc9IGyq2v92AnxuClxt /1LopMJrYOpDQ38har7gq2NRTjB890oEXwTkKbmJR3o66GlKAdCqGsZrWAD2Novql8z5 pTuvc/vDf4PpCo1g1Xnb6SxacChhEBoNm2fjaXkpzYN3tPfVW2bkxEqPkFHh94/AumWc 3nq6uUAJxxFZYeP1xN0X9cTefRqy+PLMl5ynNl+NVlVOQTKNTWS6xblsBGtZzQ9ow9oc OXvw== X-Gm-Message-State: AOAM532K1mI3x1PxYCn2A1I+0Axy92f79o5Ql23c99NCHRW1ZSxTB8iu U89RTtU9OqeF56i+pILz0iazuQ== X-Received: by 2002:a5d:43ca:: with SMTP id v10mr14464632wrr.299.1598434478379; Wed, 26 Aug 2020 02:34:38 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:37 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 27/30] wireless: broadcom: brcm80211: phy_lcn: Remove a bunch of unused variables Date: Wed, 26 Aug 2020 10:33:58 +0100 Message-Id: <20200826093401.1458456-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:11: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_rx_iq_cal’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:1366:29: warning: variable ‘RFOverride0_old’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_radio_2064_channel_tune_4313’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:1667:21: warning: variable ‘qFvco’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:1667:14: warning: variable ‘qFref’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:1667:6: warning: variable ‘qFxtal’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_idle_tssi_est’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:2856:6: warning: variable ‘idleTssi’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_tx_iqlo_soft_cal_full’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:3861:53: warning: variable ‘locc4’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:3861:46: warning: variable ‘locc3’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:3861:39: warning: variable ‘locc2’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:3861:32: warning: variable ‘iqcc0’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_periodic_cal’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4196:6: warning: variable ‘rx_iqcomp_sz’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4195:33: warning: variable ‘rx_iqcomp’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4194:16: warning: variable ‘full_cal’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_phy_txpwr_srom_read_lcnphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4919:7: warning: variable ‘opo’ set but not used [-Wunused-but-set-variable] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 40 +++++-------------- 1 file changed, 11 insertions(+), 29 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c index 7ef36234a25dc..b8193c99e8642 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c @@ -1363,7 +1363,7 @@ wlc_lcnphy_rx_iq_cal(struct brcms_phy *pi, u16 tx_pwr_ctrl; u8 tx_gain_index_old = 0; bool result = false, tx_gain_override_old = false; - u16 i, Core1TxControl_old, RFOverride0_old, + u16 i, Core1TxControl_old, RFOverrideVal0_old, rfoverride2_old, rfoverride2val_old, rfoverride3_old, rfoverride3val_old, rfoverride4_old, rfoverride4val_old, afectrlovr_old, afectrlovrval_old; @@ -1404,7 +1404,7 @@ wlc_lcnphy_rx_iq_cal(struct brcms_phy *pi, or_phy_reg(pi, 0x631, 0x0015); - RFOverride0_old = read_phy_reg(pi, 0x44c); + read_phy_reg(pi, 0x44c); /* RFOverride0_old */ RFOverrideVal0_old = read_phy_reg(pi, 0x44d); rfoverride2_old = read_phy_reg(pi, 0x4b0); rfoverride2val_old = read_phy_reg(pi, 0x4b1); @@ -1664,7 +1664,7 @@ wlc_lcnphy_radio_2064_channel_tune_4313(struct brcms_phy *pi, u8 channel) const struct chan_info_2064_lcnphy *ci; u8 rfpll_doubler = 0; u8 pll_pwrup, pll_pwrup_ovr; - s32 qFxtal, qFref, qFvco, qFcal; + s32 qFcal; u8 d15, d16, f16, e44, e45; u32 div_int, div_frac, fvco3, fpfd, fref3, fcal_div; u16 loop_bw, d30, setCount; @@ -1738,10 +1738,7 @@ wlc_lcnphy_radio_2064_channel_tune_4313(struct brcms_phy *pi, u8 channel) fvco3 = (ci->freq * 3); fref3 = 2 * fpfd; - qFxtal = wlc_lcnphy_qdiv_roundup(pi->xtalfreq, PLL_2064_MHZ, 16); - qFref = wlc_lcnphy_qdiv_roundup(fpfd, PLL_2064_MHZ, 16); qFcal = pi->xtalfreq * fcal_div / PLL_2064_MHZ; - qFvco = wlc_lcnphy_qdiv_roundup(fvco3, 2, 16); write_radio_reg(pi, RADIO_2064_REG04F, 0x02); @@ -2853,7 +2850,7 @@ static void wlc_lcnphy_idle_tssi_est(struct brcms_phy_pub *ppi) bool suspend, tx_gain_override_old; struct lcnphy_txgains old_gains; struct brcms_phy *pi = container_of(ppi, struct brcms_phy, pubpi_ro); - u16 idleTssi, idleTssi0_2C, idleTssi0_OB, idleTssi0_regvalue_OB, + u16 idleTssi0_2C, idleTssi0_OB, idleTssi0_regvalue_OB, idleTssi0_regvalue_2C; u16 SAVE_txpwrctrl = wlc_lcnphy_get_tx_pwr_ctrl(pi); u16 SAVE_lpfgain = read_radio_reg(pi, RADIO_2064_REG112); @@ -2863,7 +2860,7 @@ static void wlc_lcnphy_idle_tssi_est(struct brcms_phy_pub *ppi) u16 SAVE_iqadc_aux_en = read_radio_reg(pi, RADIO_2064_REG11F) & 4; u8 SAVE_bbmult = wlc_lcnphy_get_bbmult(pi); - idleTssi = read_phy_reg(pi, 0x4ab); + read_phy_reg(pi, 0x4ab); /* idleTssi */ suspend = (0 == (bcma_read32(pi->d11core, D11REGOFFS(maccontrol)) & MCTL_EN_MAC)); if (!suspend) @@ -2887,8 +2884,7 @@ static void wlc_lcnphy_idle_tssi_est(struct brcms_phy_pub *ppi) wlc_lcnphy_set_bbmult(pi, 0x0); wlc_phy_do_dummy_tx(pi, true, OFF); - idleTssi = ((read_phy_reg(pi, 0x4ab) & (0x1ff << 0)) - >> 0); + read_phy_reg(pi, 0x4ab); /* idleTssi */ idleTssi0_2C = ((read_phy_reg(pi, 0x63e) & (0x1ff << 0)) >> 0); @@ -3858,8 +3854,6 @@ void wlc_lcnphy_get_tx_iqcc(struct brcms_phy *pi, u16 *a, u16 *b) static void wlc_lcnphy_tx_iqlo_soft_cal_full(struct brcms_phy *pi) { - struct lcnphy_unsign16_struct iqcc0, locc2, locc3, locc4; - wlc_lcnphy_set_cc(pi, 0, 0, 0); wlc_lcnphy_set_cc(pi, 2, 0, 0); wlc_lcnphy_set_cc(pi, 3, 0, 0); @@ -3872,10 +3866,10 @@ static void wlc_lcnphy_tx_iqlo_soft_cal_full(struct brcms_phy *pi) wlc_lcnphy_a1(pi, 2, 2, 1); wlc_lcnphy_a1(pi, 0, 4, 3); - iqcc0 = wlc_lcnphy_get_cc(pi, 0); - locc2 = wlc_lcnphy_get_cc(pi, 2); - locc3 = wlc_lcnphy_get_cc(pi, 3); - locc4 = wlc_lcnphy_get_cc(pi, 4); + wlc_lcnphy_get_cc(pi, 0); + wlc_lcnphy_get_cc(pi, 2); + wlc_lcnphy_get_cc(pi, 3); + wlc_lcnphy_get_cc(pi, 4); } u16 wlc_lcnphy_get_tx_locc(struct brcms_phy *pi) @@ -4191,9 +4185,7 @@ static void wlc_lcnphy_glacial_timer_based_cal(struct brcms_phy *pi) static void wlc_lcnphy_periodic_cal(struct brcms_phy *pi) { - bool suspend, full_cal; - const struct lcnphy_rx_iqcomp *rx_iqcomp; - int rx_iqcomp_sz; + bool suspend; u16 SAVE_pwrctrl = wlc_lcnphy_get_tx_pwr_ctrl(pi); s8 index; struct phytbl_info tab; @@ -4203,9 +4195,6 @@ static void wlc_lcnphy_periodic_cal(struct brcms_phy *pi) pi->phy_lastcal = pi->sh->now; pi->phy_forcecal = false; - full_cal = - (pi_lcn->lcnphy_full_cal_channel != - CHSPEC_CHANNEL(pi->radio_chanspec)); pi_lcn->lcnphy_full_cal_channel = CHSPEC_CHANNEL(pi->radio_chanspec); index = pi_lcn->lcnphy_current_index; @@ -4220,9 +4209,6 @@ static void wlc_lcnphy_periodic_cal(struct brcms_phy *pi) wlc_lcnphy_txpwrtbl_iqlo_cal(pi); - rx_iqcomp = lcnphy_rx_iqcomp_table_rev0; - rx_iqcomp_sz = ARRAY_SIZE(lcnphy_rx_iqcomp_table_rev0); - if (LCNREV_IS(pi->pubpi.phy_rev, 1)) wlc_lcnphy_rx_iq_cal(pi, NULL, 0, true, false, 1, 40); else @@ -4916,10 +4902,6 @@ static bool wlc_phy_txpwr_srom_read_lcnphy(struct brcms_phy *pi) offset_ofdm >>= 4; } } else { - u8 opo = 0; - - opo = sprom->opo; - for (i = TXP_FIRST_CCK; i <= TXP_LAST_CCK; i++) pi->tx_srom_max_rate_2g[i] = txpwr; From patchwork Wed Aug 26 09:33:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248384 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155939ils; Wed, 26 Aug 2020 02:36:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFubIaSlhYGjCUDjCq0qa/xHtKRgwULobzwmFJ4PrZz6c4ZFMuutL76mZV1mWMLIexSZzQ X-Received: by 2002:a17:906:82c9:: with SMTP id a9mr9791300ejy.161.1598434572315; Wed, 26 Aug 2020 02:36:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434572; cv=none; d=google.com; s=arc-20160816; b=QPcFJUH/ZIAYWPQTLepGgx+iW7HjMYVzXSoCaOj9bq+FMoySBhFXoyze3oHhlBAv4v on+Ea2o5Y4t1bDqzCLztZfZn8QjpDrJ3Ttq2UzLfn9jt4grbEBGfvzA2/UExPmoSOD1H zXp5bMHnjX0RqiC2ZdMC/g4L+IVaC2gx7UuJgeZSfpm8ya4MzNgJHtVWXhO5OQ1QB5XI +yMbCA05Ae12iFTxbc3c/eDiyc2yafFSnlVFfjLvwR8oK223VemXU8Tm/vpC/TOUfhAg Evqj3KJKhIIFKz6mootbe4ZITo+re4E2cyk+PcnM7Z1yq0trhuUmHAl2tkiKP+OlFWz8 FDWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gIFuAgbU5KsSZartda2wv/vItp6gRgcDSq7Ia+efgpk=; b=isJt8VY8NrU+8inmrdGZyMxQx/txYt5JtsTivnY775ANfJv9rfriZVvQHP8gaBNy/W XeOxseTDAy1ggyjNEk4ME+YesfDwtiUMmmyWP2CUNtANweRpE5ANHfh53Xx2E9R94hEP 84+orOBIAUlhpZyWd0O0uuPcXnqwbI8ub9+K33hA9XVz6RarhBr3fvxlVz00C6CFdXXg C58ga9QXKbSvFHrWNnq7o48rQ4YAskUWWpOKAb+sMf8NXSIT+r6rLH9FLt+Lnx+bP0lD TMUQh8xB1gj+SBP7A05n5fEtU6h/AkRwJGHpBQd5zNvyWw6pw/yQ96oMqTUA0ys0b2x5 aH7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=avYQsDcI; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1160336ejd.721.2020.08.26.02.36.12; Wed, 26 Aug 2020 02:36:12 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=avYQsDcI; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728486AbgHZJgI (ORCPT + 9 others); Wed, 26 Aug 2020 05:36:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728420AbgHZJfa (ORCPT ); Wed, 26 Aug 2020 05:35:30 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19494C061363 for ; Wed, 26 Aug 2020 02:34:41 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id b18so1092940wrs.7 for ; Wed, 26 Aug 2020 02:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gIFuAgbU5KsSZartda2wv/vItp6gRgcDSq7Ia+efgpk=; b=avYQsDcIlHb1v5YkJd/vaqkVLjM5XIcFdZbGcQZAWvKMT1OUpi+Y2PQUXh8dRLs+BR z4rw/6NOguSsCeVFa6gnWDpsAbyQu9Dj83CYvpijW3Qq9SMDOeJepgI4wr+hBDGp5k75 QzcY2wKuN/KWNg89b3So2XrfPhyAytAZQTLKt3aU9yjpqGZ+RlnVWKsHleZDYyoWVtne W6IyLZ8w8hUbG50HFhpg21opLILC1ZNMA93YaWgGQSxfMB9pEPBAE2Ml8222w76w7n8s kFmpRxCZlx8vznMIExuKDi67foRE7NJDwkyaZYAuswIfmY2kEUnh+5R+U2fvcLWM4vN4 TccQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gIFuAgbU5KsSZartda2wv/vItp6gRgcDSq7Ia+efgpk=; b=dFSDVxKsqM49M72yVAANkODw4aqLtHGtoqS/UFko7YiAFtVyQT5O0Nesu+WUVbN8sQ JiVnP8sZVEydkbSWIe2KxgkaE2i3LdJk3OWJBUMO1SUgJ1fQkvfw0+dygSPiSwJXbSt4 HAWVgBPpK9oSp1wbVl503NRsUHSkPoD5qTmqdzxgm6f4uHbht9aRy9cf782hoxfKz/IB C5f8Im5nIk+auj7koX6iNEIRCWRv+aJaNFTjuE5CgciVguFx6ChkZEoO/lbSNNZmqLrD sOaS86qWHY1gXq27Y2JABJcXzEO2nXQtzx86+kQ+Yw6vWPdJq/KXiQRH6M0p2a2SEVJl wRPQ== X-Gm-Message-State: AOAM532hYnlx9JI5ASc3SzBYGWHjJ0gPtrgKBX3DUV/FO7tAu+28A2HA sw4DR03V3jCfab2HmWzeALZcvA== X-Received: by 2002:adf:b1dc:: with SMTP id r28mr14310325wra.242.1598434479728; Wed, 26 Aug 2020 02:34:39 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:39 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , zhong jiang , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 28/30] wireless: broadcom: brcm80211: phy_n: Remove a bunch of unused variables Date: Wed, 26 Aug 2020 10:33:59 +0100 Message-Id: <20200826093401.1458456-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:16: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_spurwar_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:19036:6: warning: variable ‘tempval’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_tempsense_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:21983:28: warning: variable ‘RfctrlMiscReg6_save’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_rssi_compute_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:22986:6: warning: variable ‘phyRx0_l’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_runsamples_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:23101:6: warning: variable ‘lpf_bw_ctl_miscreg4’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:23100:50: warning: variable ‘lpf_bw_ctl_miscreg3’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_iqcal_gainparams_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:23406:6: warning: variable ‘idx’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_a2_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:24707:7: warning: variable ‘phy_a6’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_a3_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:24999:7: warning: variable ‘phy_a11’ set but not used [-Wunused-but-set-variable] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: zhong jiang Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../broadcom/brcm80211/brcmsmac/phy/phy_n.c | 47 ++++--------------- 1 file changed, 8 insertions(+), 39 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c index a3f094568cfb2..8580a27547891 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c @@ -19033,7 +19033,6 @@ static void wlc_phy_spurwar_nphy(struct brcms_phy *pi) u32 nphy_adj_noise_var_buf[] = { 0x3ff, 0x3ff }; bool isAdjustNoiseVar = false; uint numTonesAdjust = 0; - u32 tempval = 0; if (NREV_GE(pi->pubpi.phy_rev, 3)) { if (pi->phyhang_avoid) @@ -19139,9 +19138,6 @@ static void wlc_phy_spurwar_nphy(struct brcms_phy *pi) numTonesAdjust, nphy_adj_tone_id_buf, nphy_adj_noise_var_buf); - - tempval = 0; - } else { wlc_phy_adjust_min_noisevar_nphy(pi, 0, NULL, NULL); @@ -21980,7 +21976,7 @@ s16 wlc_phy_tempsense_nphy(struct brcms_phy *pi) u16 auxADC_rssi_ctrlL, auxADC_rssi_ctrlH; s32 auxADC_Vl; u16 RfctrlOverride5_save, RfctrlOverride6_save; - u16 RfctrlMiscReg5_save, RfctrlMiscReg6_save; + u16 RfctrlMiscReg5_save; u16 RSSIMultCoef0QPowerDet_save; u16 tempsense_Rcal; @@ -21995,7 +21991,7 @@ s16 wlc_phy_tempsense_nphy(struct brcms_phy *pi) RfctrlOverride5_save = read_phy_reg(pi, 0x346); RfctrlOverride6_save = read_phy_reg(pi, 0x347); RfctrlMiscReg5_save = read_phy_reg(pi, 0x344); - RfctrlMiscReg6_save = read_phy_reg(pi, 0x345); + read_phy_reg(pi, 0x345); /* RfctrlMiscReg6_save */ wlc_phy_table_read_nphy(pi, NPHY_TBL_ID_AFECTRL, 1, 0x0A, 16, &auxADC_Vmid_save); @@ -22983,7 +22979,7 @@ int wlc_phy_rssi_compute_nphy(struct brcms_phy *pi, struct d11rxhdr *rxh) { s16 rxpwr, rxpwr0, rxpwr1; - s16 phyRx0_l, phyRx2_l; + s16 phyRx2_l; rxpwr = 0; rxpwr0 = rxh->PhyRxStatus_1 & PRXS1_nphy_PWR0_MASK; @@ -22994,7 +22990,6 @@ wlc_phy_rssi_compute_nphy(struct brcms_phy *pi, struct d11rxhdr *rxh) if (rxpwr1 > 127) rxpwr1 -= 256; - phyRx0_l = rxh->PhyRxStatus_0 & 0x00ff; phyRx2_l = rxh->PhyRxStatus_2 & 0x00ff; if (phyRx2_l > 127) phyRx2_l -= 256; @@ -23097,8 +23092,7 @@ wlc_phy_runsamples_nphy(struct brcms_phy *pi, u16 num_samps, u16 loops, u16 bb_mult; u8 phy_bw, sample_cmd; u16 orig_RfseqCoreActv; - u16 lpf_bw_ctl_override3, lpf_bw_ctl_override4, lpf_bw_ctl_miscreg3, - lpf_bw_ctl_miscreg4; + u16 lpf_bw_ctl_override3, lpf_bw_ctl_override4; if (pi->phyhang_avoid) wlc_phy_stay_in_carriersearch_nphy(pi, true); @@ -23111,12 +23105,7 @@ wlc_phy_runsamples_nphy(struct brcms_phy *pi, u16 num_samps, u16 loops, lpf_bw_ctl_override3 = read_phy_reg(pi, 0x342) & (0x1 << 7); lpf_bw_ctl_override4 = read_phy_reg(pi, 0x343) & (0x1 << 7); - if (lpf_bw_ctl_override3 | lpf_bw_ctl_override4) { - lpf_bw_ctl_miscreg3 = read_phy_reg(pi, 0x340) & - (0x7 << 8); - lpf_bw_ctl_miscreg4 = read_phy_reg(pi, 0x341) & - (0x7 << 8); - } else { + if (!(lpf_bw_ctl_override3 | lpf_bw_ctl_override4)) { wlc_phy_rfctrl_override_nphy_rev7( pi, (0x1 << 7), @@ -23126,12 +23115,9 @@ wlc_phy_runsamples_nphy(struct brcms_phy *pi, u16 num_samps, u16 loops, NPHY_REV7_RFCTRLOVERRIDE_ID1); pi->nphy_sample_play_lpf_bw_ctl_ovr = true; - - lpf_bw_ctl_miscreg3 = read_phy_reg(pi, 0x340) & - (0x7 << 8); - lpf_bw_ctl_miscreg4 = read_phy_reg(pi, 0x341) & - (0x7 << 8); } + read_phy_reg(pi, 0x340); /* lpf_bw_ctl_miscreg3 */ + read_phy_reg(pi, 0x341); /* lpf_bw_ctl_miscreg4 */ } if ((pi->nphy_bb_mult_save & BB_MULT_VALID_MASK) == 0) { @@ -23403,7 +23389,6 @@ wlc_phy_iqcal_gainparams_nphy(struct brcms_phy *pi, u16 core_no, struct nphy_iqcal_params *params) { u8 k; - int idx; u16 gain_index; u8 band_idx = (CHSPEC_IS5G(pi->radio_chanspec) ? 1 : 0); @@ -23436,13 +23421,10 @@ wlc_phy_iqcal_gainparams_nphy(struct brcms_phy *pi, u16 core_no, (target_gain.pga[core_no] << 4) | (target_gain.txgm[core_no] << 8)); - idx = -1; for (k = 0; k < NPHY_IQCAL_NUMGAINS; k++) { if (tbl_iqcal_gainparams_nphy[band_idx][k][0] == - gain_index) { - idx = k; + gain_index) break; - } } params->txgm = tbl_iqcal_gainparams_nphy[band_idx][k][1]; @@ -24704,7 +24686,6 @@ wlc_phy_a2_nphy(struct brcms_phy *pi, struct nphy_ipa_txcalgains *txgains, { u16 phy_a1, phy_a2, phy_a3; u16 phy_a4, phy_a5; - bool phy_a6; u8 phy_a7, m[2]; u32 phy_a8 = 0; struct nphy_txgains phy_a9; @@ -24714,9 +24695,6 @@ wlc_phy_a2_nphy(struct brcms_phy *pi, struct nphy_ipa_txcalgains *txgains, phy_a7 = (core == PHY_CORE_0) ? 1 : 0; - phy_a6 = ((cal_mode == CAL_GCTRL) - || (cal_mode == CAL_SOFT)) ? true : false; - if (NREV_GE(pi->pubpi.phy_rev, 7)) { phy_a9 = wlc_phy_get_tx_gain_nphy(pi); @@ -24996,7 +24974,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) s32 phy_a7, phy_a8; u32 phy_a9; int phy_a10; - bool phy_a11 = false; int phy_a12; u8 phy_a13 = 0; u8 phy_a14; @@ -25064,8 +25041,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) if (!phy_a6 && (phy_a3 != phy_a5)) { if (!phy_a3) phy_a12 -= (u8) phy_a1; - - phy_a11 = true; break; } @@ -25079,8 +25054,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) phy_a12 = phy_a14; else phy_a12 = phy_a13; - - phy_a11 = true; break; } @@ -25110,8 +25083,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) if (!phy_a6 && (phy_a3 != phy_a5)) { if (!phy_a3) phy_a12 -= (u8) phy_a1; - - phy_a11 = true; break; } @@ -25125,8 +25096,6 @@ static u8 wlc_phy_a3_nphy(struct brcms_phy *pi, u8 start_gain, u8 core) phy_a12 = 0; else phy_a12 = 127; - - phy_a11 = true; break; } From patchwork Wed Aug 26 09:34:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248383 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155902ils; Wed, 26 Aug 2020 02:36:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzD36VpYk/pawvdny6c8TR/H/unIZ/RozmmVf5ObsKcYXeUkJNLQPrdwoQFIJgAdcSGUyUN X-Received: by 2002:a17:906:e8f:: with SMTP id p15mr11308582ejf.290.1598434567507; Wed, 26 Aug 2020 02:36:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434567; cv=none; d=google.com; s=arc-20160816; b=vviL3oOXgAAsNoKRXQLynCHJq/tPlg34MklB0j2Wq1uyoXMNpfGJF5xDrNqt4CzduE 4gTvlSpvo2x3B9JDGPsTWS8Q6ciYkltlw74eZGDNaqX3CEY7lfHTXWJqNnnrUhcYJdQw G081dq9YB6n6Sd8xSTAINDcj4pX/7w5RuQ2jGqXCOgrxRTpghW46+yIrqhoFUQzsGMM6 ztx2G+gFh2ixiOPR1JT3f9b1/cOPhyBtbEh4kMlSPuCQoWJln4hKFqJvfpdBLEpbOcE1 W66kXcRAmyRdjV6fqkgXwBaqWIkYlPzVRU4mfFnckX5R7q4P/onJnwgMqhp4Qu82YlVC 2l2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xmeKWj6ihDtxXg7mmV0g02PkzMbJUwVy4vUADq1jq3Y=; b=IvUSomvAunbeB+QR1MY+bXlJvAmoYHEHa9wVcSAZ2McQJgFTKYwYpvbKuMwUrepk5t S/G8sfRWFig4inlrRmG48j60vcxWjKc0k839WMg1pxo3IXr5+KfqNeuAIql9L1cT6KKL ODoqxQlnNACLJtdohNzHrfv60oqlfXuH6qK+KXxy2ZD8k5tVJOEVst+TngLJZPTYfJiC pnRGoEbYOa8OUtVReGP9MwxsDkk/qvf/DJIa/Gquxa77Ws+T6C+Cj0ITbaeIbhaEPAvc 4OpYuHU1SJThF4pf2lvkrz6fJELBUomKkZoSdhH2PKo599jVNvUR59QJDm+K/xF8xRM6 fc2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lHkQ9kbI; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1160336ejd.721.2020.08.26.02.36.07; Wed, 26 Aug 2020 02:36:07 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lHkQ9kbI; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728479AbgHZJgG (ORCPT + 9 others); Wed, 26 Aug 2020 05:36:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728424AbgHZJfd (ORCPT ); Wed, 26 Aug 2020 05:35:33 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405CAC061366 for ; Wed, 26 Aug 2020 02:34:42 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id o4so1107963wrn.0 for ; Wed, 26 Aug 2020 02:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xmeKWj6ihDtxXg7mmV0g02PkzMbJUwVy4vUADq1jq3Y=; b=lHkQ9kbI4YiHrMG+5c1O2DA0EUdgjZyvLmV+8YExFcXi1gdFNdZna7wI1C7eYgwRYz 9Xk1+KxSEYrXF/zIdSTSg24AIl/kZzSC8uzCISjmVpPb5WPvkYGGet2Msnt5AYRohb/9 tdTLogHLdCjhAebO1xjCBX6weShNPfIwXefOeUNOsk4XydWW3Dg3BLWF1dKUkFyUxjFH 89+MNPaKS6ACrOuzatrjQoAYZCgN2RoMGXmYGEZ8aYPqTCfAjVCfkJdUGw7QdeinfKnR fQiS/5nY5m8XV04zepMGobk9n7MVwie/ajSLslD2eTM/u2MZs63wJfpm38MbNLDGKajP esjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xmeKWj6ihDtxXg7mmV0g02PkzMbJUwVy4vUADq1jq3Y=; b=dPqHppyu7eGl7YaYFJkunX0Gy9NApNEUOqZFHFjCKxEfZyITPW5hnZrP2y9S3WEP6C THjTYay37CNlzxgHFE07jye/RdFIyywwU4LqfXuMS+kwEVG51XBfRtmEzAjRzAwnwkJ0 C+iWUuxkYmWbntPUQT7A+qefrBaQL+b9ZyVu74zcylf2/MPkXnU9d0pntR4retH0dabF 0puKJj/OmyRXR4+ot5NU9OqnHosrm02T64cvoVgdh5ch0eGtRfoVr9z+CmxhGiiHP5uB icGAtCIPBdbWziZx30Xj8Y7mxeSGL7V0MvD/tD2x5vXZaWgNEMYbXvyOy93qYdIXBbOy cDEQ== X-Gm-Message-State: AOAM530UGMH9ogA1t0So2TSa13zn2qt3Z0lpwEv3hGl37+PO9s2wnQ2P PGiuQmYO9U7ZDeI9Ltr5QF6Ttw== X-Received: by 2002:adf:ff90:: with SMTP id j16mr477311wrr.105.1598434480972; Wed, 26 Aug 2020 02:34:40 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:40 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 29/30] wireless: broadcom: brcm80211: phytbl_lcn: Remove unused array 'dot11lcnphytbl_rx_gain_info_rev1' Date: Wed, 26 Aug 2020 10:34:00 +0100 Message-Id: <20200826093401.1458456-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c:1510:33: warning: ‘dot11lcnphytbl_rx_gain_info_rev1’ defined but not used [-Wunused-const-variable=] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c | 13 ------------- 1 file changed, 13 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c index be703be34616a..7526aa441de11 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c @@ -1507,19 +1507,6 @@ const struct phytbl_info dot11lcnphytbl_rx_gain_info_rev0[] = { , }; -static const struct phytbl_info dot11lcnphytbl_rx_gain_info_rev1[] = { - {&dot11lcn_gain_tbl_rev1, - ARRAY_SIZE(dot11lcn_gain_tbl_rev1), 18, - 0, 32} - , - {&dot11lcn_aux_gain_idx_tbl_rev0, - ARRAY_SIZE(dot11lcn_aux_gain_idx_tbl_rev0), 14, 0, 16} - , - {&dot11lcn_gain_idx_tbl_rev0, - ARRAY_SIZE(dot11lcn_gain_idx_tbl_rev0), 13, 0, 32} - , -}; - const struct phytbl_info dot11lcnphytbl_rx_gain_info_2G_rev2[] = { {&dot11lcn_gain_tbl_2G, ARRAY_SIZE(dot11lcn_gain_tbl_2G), 18, 0, From patchwork Wed Aug 26 09:34:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 261919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DB9C433E1 for ; Wed, 26 Aug 2020 09:36:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEB882087D for ; Wed, 26 Aug 2020 09:36:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ajx7/Kr/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728464AbgHZJgE (ORCPT ); Wed, 26 Aug 2020 05:36:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728428AbgHZJfe (ORCPT ); Wed, 26 Aug 2020 05:35:34 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 863D1C06136A for ; Wed, 26 Aug 2020 02:34:43 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id o4so1108029wrn.0 for ; Wed, 26 Aug 2020 02:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EWWkC93UJ7xj7BkZ2b7U7Aw6lomOHNe1aGRj0IYiNWw=; b=Ajx7/Kr/e8GtU4LIIPcwjtWRUh0vF1emJA2VjOu2Gia+48u0R30etyRK1i63xNy7L5 hMXIkmWto3dxWPN8FrOWpBl1pqjQ4dLkksZjPNfxFQVcXIlzVqQH+2wEkDf3NQRTgwJ1 VU8abeFTBhMh0hlrVZhbR1ni0bThPfgm0f0QKIidxW2P9i7yEtiTPcKCU0bqCScTrdJl nxse+3AwcjpD7ic6ZCoxS6GYLOOaAEDg2uwmoAY1N3brpUTSEsFzJ2D3I5FCnyPV8ox1 A+5T6/V5cMM2kr6bgevVjvMLYEjkqjoDNFOlGSuF/tKcGg5cfarQsONjK+8TnMoSEND/ FGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EWWkC93UJ7xj7BkZ2b7U7Aw6lomOHNe1aGRj0IYiNWw=; b=GXSEJbKiVrwSM25bAfjcLTy8cdnIPkQFFDOXm1nsx63rUT5MSuddw6Ped0vPVPmG8L 1ubRptfuHo6qLyuO3m1r9R3HCN0VaRRIt51+8S8NktJSncFEofv3m04PMLleU5GPO/ea 7Iy55RpLyB9hck4l/w5yDCjT5/Qd2OznqaJ3MtVifP+5sDCsO57mHJBwPcZ+jeu30sbz jgpNVXjtlCFYganlqx9QyKLOE3/+6IuJ1126Z4vZAL91ai3va+1w1TW4pPcfoA3X8mnV T28GBegG/hiHWwCyNOrfk0rywX4Flk5C1q7oPjFl3P4UYhr+rF4fUcnn0+JGEAc0eVeX X/Tg== X-Gm-Message-State: AOAM532kS4pavB5ZrDzJ4ci6wXJ7js5MzQuZju0Kb3b7n+miAIuqAuOT cAo1zBLj0PWLG+fnLrGC224YzA== X-Google-Smtp-Source: ABdhPJyEEniXrXM8b6V6fPBEVaHRa3glrYLaPukKyjYAcSu/RiB5EgJ/+SOPvpFgOZOkfqNpKXLIAA== X-Received: by 2002:adf:c453:: with SMTP id a19mr1604492wrg.179.1598434482172; Wed, 26 Aug 2020 02:34:42 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:41 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 30/30] wireless: broadcom: brcm80211: phytbl_n: Remove a few unused arrays Date: Wed, 26 Aug 2020 10:34:01 +0100 Message-Id: <20200826093401.1458456-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9218:18: warning: ‘papd_cal_scalars_tbl_core1_rev3’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9151:18: warning: ‘papd_comp_epsilon_tbl_core1_rev3’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9084:18: warning: ‘papd_cal_scalars_tbl_core0_rev3’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9017:18: warning: ‘papd_comp_epsilon_tbl_core0_rev3’ defined but not used [-Wunused-const-variable=] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../brcm80211/brcmsmac/phy/phytbl_n.c | 268 ------------------ 1 file changed, 268 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c index 7607e67d20c75..396d005f4d165 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c @@ -9014,274 +9014,6 @@ static const u16 papd_comp_rfpwr_tbl_core1_rev3[] = { 0x01d6, }; -static const u32 papd_comp_epsilon_tbl_core0_rev3[] = { - 0x00000000, - 0x00001fa0, - 0x00019f78, - 0x0001df7e, - 0x03fa9f86, - 0x03fd1f90, - 0x03fe5f8a, - 0x03fb1f94, - 0x03fd9fa0, - 0x00009f98, - 0x03fd1fac, - 0x03ff9fa2, - 0x03fe9fae, - 0x00001fae, - 0x03fddfb4, - 0x03ff1fb8, - 0x03ff9fbc, - 0x03ffdfbe, - 0x03fe9fc2, - 0x03fedfc6, - 0x03fedfc6, - 0x03ff9fc8, - 0x03ff5fc6, - 0x03fedfc2, - 0x03ff9fc0, - 0x03ff5fac, - 0x03ff5fac, - 0x03ff9fa2, - 0x03ff9fa6, - 0x03ff9faa, - 0x03ff5fb0, - 0x03ff5fb4, - 0x03ff1fca, - 0x03ff5fce, - 0x03fcdfdc, - 0x03fb4006, - 0x00000030, - 0x03ff808a, - 0x03ff80da, - 0x0000016c, - 0x03ff8318, - 0x03ff063a, - 0x03fd8bd6, - 0x00014ffe, - 0x00034ffe, - 0x00034ffe, - 0x0003cffe, - 0x00040ffe, - 0x00040ffe, - 0x0003cffe, - 0x0003cffe, - 0x00020ffe, - 0x03fe0ffe, - 0x03fdcffe, - 0x03f94ffe, - 0x03f54ffe, - 0x03f44ffe, - 0x03ef8ffe, - 0x03ee0ffe, - 0x03ebcffe, - 0x03e8cffe, - 0x03e74ffe, - 0x03e4cffe, - 0x03e38ffe, -}; - -static const u32 papd_cal_scalars_tbl_core0_rev3[] = { - 0x05af005a, - 0x0571005e, - 0x05040066, - 0x04bd006c, - 0x047d0072, - 0x04430078, - 0x03f70081, - 0x03cb0087, - 0x03870091, - 0x035e0098, - 0x032e00a1, - 0x030300aa, - 0x02d800b4, - 0x02ae00bf, - 0x028900ca, - 0x026400d6, - 0x024100e3, - 0x022200f0, - 0x020200ff, - 0x01e5010e, - 0x01ca011e, - 0x01b0012f, - 0x01990140, - 0x01830153, - 0x016c0168, - 0x0158017d, - 0x01450193, - 0x013301ab, - 0x012101c5, - 0x011101e0, - 0x010201fc, - 0x00f4021a, - 0x00e6011d, - 0x00d9012e, - 0x00cd0140, - 0x00c20153, - 0x00b70167, - 0x00ac017c, - 0x00a30193, - 0x009a01ab, - 0x009101c4, - 0x008901df, - 0x008101fb, - 0x007a0219, - 0x00730239, - 0x006d025b, - 0x0067027e, - 0x006102a4, - 0x005c02cc, - 0x005602f6, - 0x00520323, - 0x004d0353, - 0x00490385, - 0x004503bb, - 0x004103f3, - 0x003d042f, - 0x003a046f, - 0x003704b2, - 0x003404f9, - 0x00310545, - 0x002e0596, - 0x002b05f5, - 0x00290640, - 0x002606a4, -}; - -static const u32 papd_comp_epsilon_tbl_core1_rev3[] = { - 0x00000000, - 0x00001fa0, - 0x00019f78, - 0x0001df7e, - 0x03fa9f86, - 0x03fd1f90, - 0x03fe5f8a, - 0x03fb1f94, - 0x03fd9fa0, - 0x00009f98, - 0x03fd1fac, - 0x03ff9fa2, - 0x03fe9fae, - 0x00001fae, - 0x03fddfb4, - 0x03ff1fb8, - 0x03ff9fbc, - 0x03ffdfbe, - 0x03fe9fc2, - 0x03fedfc6, - 0x03fedfc6, - 0x03ff9fc8, - 0x03ff5fc6, - 0x03fedfc2, - 0x03ff9fc0, - 0x03ff5fac, - 0x03ff5fac, - 0x03ff9fa2, - 0x03ff9fa6, - 0x03ff9faa, - 0x03ff5fb0, - 0x03ff5fb4, - 0x03ff1fca, - 0x03ff5fce, - 0x03fcdfdc, - 0x03fb4006, - 0x00000030, - 0x03ff808a, - 0x03ff80da, - 0x0000016c, - 0x03ff8318, - 0x03ff063a, - 0x03fd8bd6, - 0x00014ffe, - 0x00034ffe, - 0x00034ffe, - 0x0003cffe, - 0x00040ffe, - 0x00040ffe, - 0x0003cffe, - 0x0003cffe, - 0x00020ffe, - 0x03fe0ffe, - 0x03fdcffe, - 0x03f94ffe, - 0x03f54ffe, - 0x03f44ffe, - 0x03ef8ffe, - 0x03ee0ffe, - 0x03ebcffe, - 0x03e8cffe, - 0x03e74ffe, - 0x03e4cffe, - 0x03e38ffe, -}; - -static const u32 papd_cal_scalars_tbl_core1_rev3[] = { - 0x05af005a, - 0x0571005e, - 0x05040066, - 0x04bd006c, - 0x047d0072, - 0x04430078, - 0x03f70081, - 0x03cb0087, - 0x03870091, - 0x035e0098, - 0x032e00a1, - 0x030300aa, - 0x02d800b4, - 0x02ae00bf, - 0x028900ca, - 0x026400d6, - 0x024100e3, - 0x022200f0, - 0x020200ff, - 0x01e5010e, - 0x01ca011e, - 0x01b0012f, - 0x01990140, - 0x01830153, - 0x016c0168, - 0x0158017d, - 0x01450193, - 0x013301ab, - 0x012101c5, - 0x011101e0, - 0x010201fc, - 0x00f4021a, - 0x00e6011d, - 0x00d9012e, - 0x00cd0140, - 0x00c20153, - 0x00b70167, - 0x00ac017c, - 0x00a30193, - 0x009a01ab, - 0x009101c4, - 0x008901df, - 0x008101fb, - 0x007a0219, - 0x00730239, - 0x006d025b, - 0x0067027e, - 0x006102a4, - 0x005c02cc, - 0x005602f6, - 0x00520323, - 0x004d0353, - 0x00490385, - 0x004503bb, - 0x004103f3, - 0x003d042f, - 0x003a046f, - 0x003704b2, - 0x003404f9, - 0x00310545, - 0x002e0596, - 0x002b05f5, - 0x00290640, - 0x002606a4, -}; - const struct phytbl_info mimophytbl_info_rev3_volatile[] = { {&ant_swctrl_tbl_rev3, ARRAY_SIZE(ant_swctrl_tbl_rev3), 9, 0, 16}, };