From patchwork Tue Oct 10 09:00:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 115367 Delivered-To: patch@linaro.org Received: by 10.80.163.170 with SMTP id s39csp3284207edb; Tue, 10 Oct 2017 02:07:47 -0700 (PDT) X-Google-Smtp-Source: AOwi7QA4hiUKGVzH3KJDSvu/cRCL78T6SqRuaozrOA/+Gsce7Mr8A4Fe+5zDlkD/aQ2TAPv1rQTH X-Received: by 10.107.82.23 with SMTP id g23mr18246987iob.145.1507626467044; Tue, 10 Oct 2017 02:07:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507626467; cv=none; d=google.com; s=arc-20160816; b=GJBlhvWRS9zwqAiIj98CUw0NXvq+Tfw/19Tkxe1DtQXA119ZPQF9IeEDE75KAg7A1r LmtRlyFPlPnYEOCJNmBCoOuOxN3iPAQqzsFLU/GVY2cgQaltNFF5Ws3GmOWh1grxHBqj 7K4m3FvBhKDRAsfdrQybIIbGpEclXNL2PNXNByCRxJYiCaS9s/XfQ1U2DNngZlaDFty2 VgMdrjp6uoDV+PhO8480F6IUo1HwlqFfriXYnVyrBUWsV8HZ9H05Y1lZ2isTyN0j6yDj X7AHLJ49HT/BT6kAfi+R6gkfw2aZi/gZhDw2Y+yttVht5hQfNTGp/PXhVR/MzsGE0JDU 8DZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=p9Qvp/DyxgAJtbnHOTdu10scwHdBc1ACPFzLeMU+QsU=; b=BYwmAvm8bUP/8OZCKOG+K9PD1blkvDA3afC4qyj8Q5w5pmQQuq5UKNZ+GgXInDEm32 +x0uzqUeaII7GoX8weEaVC/OF4mdvrz7R8oAwPwfphoC3vQ/MRQqxDfWATSEhCvAHyop 49FogNAycFuKGJjw4bhdCmA8VrowjBiiihtqPdjafV2A2lbcqSyd0OFGY/FpNiAp40IR i7ZvV17egSLHskogxoDHr1/5Q1rDG771kFjqrTKY8l/pGt0DeZR86R3fIu1bsgkCXTqs h4cOWUVQKDgCbU59VDaH/3Hi5q3ACpYz12zbjggjfFjHJzsL8Khg0AhrCRH80JI+Bnsi ZwSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 83si7919744iog.361.2017.10.10.02.07.46; Tue, 10 Oct 2017 02:07:47 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 8E5FD60C60; Tue, 10 Oct 2017 09:07:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id E3CED60C63; Tue, 10 Oct 2017 09:03:50 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 443F660CE5; Tue, 10 Oct 2017 09:03:48 +0000 (UTC) Received: from forward106p.mail.yandex.net (forward106p.mail.yandex.net [77.88.28.109]) by lists.linaro.org (Postfix) with ESMTPS id C660760C63 for ; Tue, 10 Oct 2017 09:01:04 +0000 (UTC) Received: from mxback12j.mail.yandex.net (mxback12j.mail.yandex.net [IPv6:2a02:6b8:0:1619::87]) by forward106p.mail.yandex.net (Yandex) with ESMTP id EC99E2D83E37 for ; Tue, 10 Oct 2017 12:01:02 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback12j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id CFtTOgkohQ-12aOevjA; Tue, 10 Oct 2017 12:01:02 +0300 Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id tkOSM1mChE-12rmFYX8; Tue, 10 Oct 2017 12:01:02 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 10 Oct 2017 12:00:35 +0300 Message-Id: <1507626035-15990-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1507626035-15990-1-git-send-email-odpbot@yandex.ru> References: <1507626035-15990-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 197 Subject: [lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: rework ODP_IPSEC_SA_DISABLE into warning bit X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov It is expected that platforms that are not able to support odp_ipsec_sa_disable() status result in a form of separate event will set SA hard expiry time to 0, submit a dummy packet to that SA. Then after receiving this packet after IPsec processing (which should result in hard expiry breach) odp_ipsec_result() will detect this packet through the combination of hard_expiry, size, contents, etc and will report it as a packet with odp_ipsec_warn_t->sa_disabled bit set. Signed-off-by: Dmitry Eremin-Solenikov Cc: Nikhil Agarwal Cc: Balasubramanian Manoharan --- /** Email created from pull request 197 (lumag:ipsec_sa_disable_proposal) ** https://github.com/Linaro/odp/pull/197 ** Patch: https://github.com/Linaro/odp/pull/197.patch ** Base sha: bf803098eb1518dfb9e719071256fe22700b8c72 ** Merge commit sha: 7f84b666e44cc323c7defa4fb3eaaac8984407a2 **/ include/odp/api/spec/ipsec.h | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index 3bd80b266..6265f9501 100644 --- a/include/odp/api/spec/ipsec.h +++ b/include/odp/api/spec/ipsec.h @@ -839,8 +839,10 @@ odp_ipsec_sa_t odp_ipsec_sa_create(const odp_ipsec_sa_param_t *param); * * When in synchronous operation mode, the call will return when it's possible * to destroy the SA. In asynchronous mode, the same is indicated by an - * ODP_EVENT_IPSEC_STATUS event sent to the queue specified for the SA. The - * status event is guaranteed to be the last event for the SA, i.e. all + * sa_disabled bit in odp_ipsec_warn_t. Warning can be delivered either by an + * ODP_EVENT_IPSEC_STATUS event sent to the queue specified for the SA or by + * a packet having this bit set in corresponding odp_ipsec_result_t instance. + * This warning is guaranteed to be the last event for the SA, i.e. all * in-progress operations have completed and resulting events (including status * events) have been enqueued before it. * @@ -923,7 +925,12 @@ typedef struct odp_ipsec_error_t { } odp_ipsec_error_t; -/** IPSEC warnings */ +/** IPSEC warnings + * + * For outbound SAs in ODP_IPSEC_OP_MODE_INLINE mode warnings can be reported + * only as status events. In all other cases warnings can be reported either as + * a part of packet result or via separate ODP status event. + */ typedef struct odp_ipsec_warn_t { /** IPSEC warnings */ union { @@ -934,6 +941,9 @@ typedef struct odp_ipsec_warn_t { /** Soft lifetime expired: packets */ uint32_t soft_exp_packets : 1; + + /** SA was disabled */ + uint32_t sa_disabled : 1, }; /** All warnings bits */ @@ -1129,26 +1139,14 @@ typedef struct odp_ipsec_packet_result_t { * IPSEC status ID */ typedef enum odp_ipsec_status_id_t { - /** Response to SA disable command - * - * Following status event (odp_ipsec_status_t) fields have valid - * content, other fields must be ignored: - * - sa: The SA that was requested to be disabled - * - result: Operation result - */ - ODP_IPSEC_STATUS_SA_DISABLE = 0, - /** Warning from inline IPSEC processing * * Following status event (odp_ipsec_status_t) fields have valid * content, other fields must be ignored: * - sa: The SA that caused the warning * - warn: The warning(s) reported by this event - * - * This status event is generated only for outbound SAs in - * ODP_IPSEC_OP_MODE_INLINE mode. */ - ODP_IPSEC_STATUS_WARN + ODP_IPSEC_STATUS_WARN = 0, } odp_ipsec_status_id_t;