From patchwork Thu Mar 26 14:01:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 244328 List-Id: U-Boot discussion From: michal.simek at xilinx.com (Michal Simek) Date: Thu, 26 Mar 2020 15:01:29 +0100 Subject: [PATCH] net: macb: Fix incorrect write function name when MACB_ZYNQ is enabled. Message-ID: <96d87b35bafab5ac49b3475a2d22ad67ee9afaef.1585231286.git.michal.simek@xilinx.com> When MACB_ZYNQ is enabled there is compilation warnings drivers/net/macb.c: In function ?_macb_init?: drivers/net/macb.h:675:33: error: ?MACB_DMACFG? undeclared (first use in this function); did you mean ?MACB_MCF?? writel((value), (port)->regs + MACB_##reg) ^~~~~ It has been caused by changing macros name by commit below. Fixes: 6c636514d499 ("net: macb: sync header definitions as taken from Linux") Signed-off-by: Michal Simek Acked-by: Joe Hershberger --- Xilinx is not using this driver. We are using zynq_gem one but I found it when I was comparing one setting. Tom: I would consider this as FIX and would be good if you can take it to the current release but up2you. --- drivers/net/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 631b53b0930a..bd588cab06b3 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -807,7 +807,7 @@ static int _macb_init(struct macb_device *macb, const char *name) macb->next_rx_tail = 0; #ifdef CONFIG_MACB_ZYNQ - macb_writel(macb, DMACFG, MACB_ZYNQ_GEM_DMACR_INIT); + gem_writel(macb, DMACFG, MACB_ZYNQ_GEM_DMACR_INIT); #endif macb_writel(macb, RBQP, macb->rx_ring_dma);