From patchwork Wed Mar 25 20:27:51 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jan Kiszka <jan.kiszka@siemens.com>
X-Patchwork-Id: 244290
List-Id: U-Boot discussion <u-boot.lists.denx.de>
From: jan.kiszka at siemens.com (Jan Kiszka)
Date: Wed, 25 Mar 2020 21:27:51 +0100
Subject: [PATCH] fs: ext4: Fix alignment of cache buffers
Message-ID: <c2b25bd8-8f9a-c95d-a309-d18ac755f611@siemens.com>

From: Jan Kiszka <jan.kiszka at siemens.com>

We need to align the cache buffer to ARCH_DMA_MINALIGN in order to avoid
access errors like

CACHE: Misaligned operation at range [be0231e0, be0235e0]

seen on the MCIMX7SABRE.

Fixes: d5aee659f217 ("fs: ext4: cache extent data")
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Reviewed-by: Tom Rini <trini at konsulko.com>
Reviewed-by: Stephen Warren <swarren at nvidia.com>
Tested-by: Peter Robinson <pbrobinson at gmail.com>
---
 fs/ext4/ext4fs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/ext4fs.c b/fs/ext4/ext4fs.c
index 1c616a26a2..966b427a97 100644
--- a/fs/ext4/ext4fs.c
+++ b/fs/ext4/ext4fs.c
@@ -288,7 +288,7 @@ int ext_cache_read(struct ext_block_cache *cache, lbaint_t block, int size)
 	if (cache->buf && cache->block == block && cache->size == size)
 		return 1;
 	ext_cache_fini(cache);
-	cache->buf = malloc(size);
+	cache->buf = memalign(ARCH_DMA_MINALIGN, size);
 	if (!cache->buf)
 		return 0;
 	if (!ext4fs_devread(block, 0, size, cache->buf)) {