From patchwork Tue Mar 10 18:34:14 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Fabio Estevam <festevam@gmail.com>
X-Patchwork-Id: 243482
List-Id: U-Boot discussion <u-boot.lists.denx.de>
From: festevam at gmail.com (Fabio Estevam)
Date: Tue, 10 Mar 2020 15:34:14 -0300
Subject: [PATCH] net: eth-uclass: Do not return error when no MAC is found
In-Reply-To: <CANr=Z=YytxM6WMWwJGAf8M0g3Pb10oY7S3soK8hEYwcSE=Ndcw@mail.gmail.com>
References: <20200109182802.26121-1-festevam@gmail.com>
 <CANr=Z=YytxM6WMWwJGAf8M0g3Pb10oY7S3soK8hEYwcSE=Ndcw@mail.gmail.com>
Message-ID: <CAOMZO5COpzD0PVH3O1qy99psMod=68NOO8j1383Y49N+CJs0QQ@mail.gmail.com>

Hi Joe,

On Tue, Mar 10, 2020 at 2:45 PM Joe Hershberger <joe.hershberger at ni.com> wrote:

> I tried to apply this but it breaks the unit tests. I guess you didn't
> try "ut dm" in sandbox?
>
> https://travis-ci.org/jhershbe/u-boot/builds/660395782
>
> Please test those and update the tests to pass with your change.

Ok, I will revisit this patch after 2020.04.

I think we should probably let net_random_ethaddr() run unconditionally:


Thanks

--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -547,15 +547,9 @@ static int eth_post_probe(struct udevice *dev)
                       dev->name);
        } else if (is_zero_ethaddr(pdata->enetaddr) ||
                   !is_valid_ethaddr(pdata->enetaddr)) {
-#ifdef CONFIG_NET_RANDOM_ETHADDR
                net_random_ethaddr(pdata->enetaddr);
                printf("\nWarning: %s (eth%d) using random MAC address - %pM\n",
                       dev->name, dev->seq, pdata->enetaddr);
-#else
-               printf("\nError: %s address not set.\n",
-                      dev->name);
-               return -EINVAL;
-#endif
        }

        eth_write_hwaddr(dev);