From patchwork Wed Jun 24 08:17:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Delaunay X-Patchwork-Id: 242817 List-Id: U-Boot discussion From: patrick.delaunay at st.com (Patrick Delaunay) Date: Wed, 24 Jun 2020 10:17:50 +0200 Subject: [PATCH] env: add failing trace in env_save Message-ID: <20200624081751.2220-1-patrick.delaunay@st.com> Add trace in env save to indicate any errors to end user and avoid silent output when the command 'env save' is not executed. Signed-off-by: Patrick Delaunay --- env/env.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/env/env.c b/env/env.c index dcc25c030b..7719bc3620 100644 --- a/env/env.c +++ b/env/env.c @@ -240,13 +240,17 @@ int env_save(void) if (drv) { int ret; - if (!drv->save) + printf("Saving Environment to %s... ", drv->name); + if (!drv->save) { + printf("not possible\n"); return -ENODEV; + } - if (!env_has_inited(drv->location)) + if (!env_has_inited(drv->location)) { + printf("not initialized\n"); return -ENODEV; + } - printf("Saving Environment to %s... ", drv->name); ret = drv->save(); if (ret) printf("Failed (%d)\n", ret);