From patchwork Wed Jun 17 19:09:19 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Fabio Estevam <festevam@gmail.com>
X-Patchwork-Id: 242580
List-Id: U-Boot discussion <u-boot.lists.denx.de>
From: festevam at gmail.com (Fabio Estevam)
Date: Wed, 17 Jun 2020 16:09:19 -0300
Subject: U-Boot atheros PHY support and cubox ethernet
In-Reply-To: <20200617190020.GF27801@bill-the-cat>
References: <20200616195505.GA3129@bill-the-cat>
 <CAOMZO5AKiv0xM0i4bkmjbDHNsfTCWx9qEXo42=4wZ8hvjN2SNQ@mail.gmail.com>
 <20200616205108.GB24893@bill-the-cat>
 <CAOMZO5B4gvNR=C6fYycnxR0Xnf8kPCS2A+gWa8oLttbmURRFrw@mail.gmail.com>
 <20200616205812.GC24893@bill-the-cat>
 <CAOMZO5D3vRPXgovWoNvxUPXKUzUc-f-j4ixN_yNeJGVRU-kXOg@mail.gmail.com>
 <20200616223005.GB27801@bill-the-cat>
 <CAOMZO5CFW1gnSUcji3mKxhdyEM-tyvFc+vta-Q9wvb1Uh3rPHg@mail.gmail.com>
 <20200617190020.GF27801@bill-the-cat>
Message-ID: <CAOMZO5Ds0L4TaXOE=mp7B4UF1GJoRLSK0=Y+P+8Pq5Ca=UuLTw@mail.gmail.com>

On Wed, Jun 17, 2020 at 4:00 PM Tom Rini <trini at konsulko.com> wrote:

> +#ifdef CONFIG_FEC_MXC
> +static int setup_fec(void)
> +{
> +       struct iomuxc *const iomuxc_regs = (struct iomuxc *)IOMUXC_BASE_ADDR;
> +       struct gpio_desc desc;
> +
> +       int ret = enable_fec_anatop_clock(0, ENET_25MHZ);
> +       if (ret)
> +               return ret;
> +
> +       /* set gpr1[ENET_CLK_SEL] */
> +       setbits_le32(&iomuxc_regs->gpr[1], IOMUXC_GPR1_ENET_CLK_SEL_MASK);
> +
> +       /* Reset PHY */
> +       ret = dm_gpio_lookup_name("GPIO4_15", &desc);
> +       if (ret) {
> +               printf("%s: phy reset lookup failed\n", __func__);
> +               return ret;
> +       }
> +
> +       ret = dm_gpio_request(&desc, "phy-reset");
> +       if (ret) {
> +               printf("%s: phy reset request failed\n", __func__);
> +               return ret;
> +       }
> +
> +       gpio_direction_output(ETH_PHY_RESET, 0);
> +       mdelay(10);
> +       gpio_set_value(ETH_PHY_RESET, 1);
> +       udelay(100);

The Ethernet PHY reset can be done via device tree.

It seems we need to change it like this:


Does it still probe if you remove the PHY reset from the board code?

--- a/arch/arm/dts/imx6qdl-sr-som.dtsi
+++ b/arch/arm/dts/imx6qdl-sr-som.dtsi
@@ -54,7 +54,8 @@
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_microsom_enet_ar8035>;
        phy-mode = "rgmii-id";
-       phy-reset-duration = <2>;
+       phy-reset-duration = <10>;
+       phy-reset-post-delay = <1>;
        phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>;
        status = "okay";
 };