From patchwork Thu Jul 2 17:08:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Delaunay X-Patchwork-Id: 240656 List-Id: U-Boot discussion From: patrick.delaunay at st.com (Patrick Delaunay) Date: Thu, 2 Jul 2020 19:08:24 +0200 Subject: [PATCH] patman: Detect unexpected END Message-ID: <20200702170824.16293-1-patrick.delaunay@st.com> Detect unexpected 'END' line when a section is not detected. This patch detect issue when tag name for section start is misspelled, for example 'Commit-note:' for 'Commit-notes:' Commit-note: .... END Then 'Commit-note:' is removed silently by re_remove = "Commit-\w*:" but 'END' is kept in commit message. Signed-off-by: Patrick Delaunay Reviewed-by: Simon Glass --- tools/patman/patchstream.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py index 4fe465e9ab..a575c09b47 100644 --- a/tools/patman/patchstream.py +++ b/tools/patman/patchstream.py @@ -260,6 +260,10 @@ class PatchStream: else: self.section.append(line) + # If we are not in a section, it is an unexpected END + elif line == 'END': + raise ValueError("'END' wihout section") + # Detect the commit subject elif not is_blank and self.state == STATE_PATCH_SUBJECT: self.commit.subject = line