From patchwork Mon Jan 6 22:00:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatolij Gustschin X-Patchwork-Id: 239174 List-Id: U-Boot discussion From: agust at denx.de (Anatolij Gustschin) Date: Mon, 6 Jan 2020 23:00:38 +0100 Subject: [PATCH] video: fix Coverity missing break issue Message-ID: <20200106220038.18773-1-agust@denx.de> Fix: >>> CID 280902: Control flow issues (MISSING_BREAK) >>> The case for value "VIDEO_BPP32" is not terminated >>> by a 'break' statement. Reported-by: Tom Rini Signed-off-by: Anatolij Gustschin Reviewed-by: Simon Glass --- drivers/video/vidconsole-uclass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/vidconsole-uclass.c b/drivers/video/vidconsole-uclass.c index 75c7e25095..6c0daa1ee5 100644 --- a/drivers/video/vidconsole-uclass.c +++ b/drivers/video/vidconsole-uclass.c @@ -144,12 +144,14 @@ u32 vid_console_color(struct video_priv *priv, unsigned int idx) ((colors[idx].g >> 2) << 5) | ((colors[idx].b >> 3) << 0); } + break; case VIDEO_BPP32: if (CONFIG_IS_ENABLED(VIDEO_BPP32)) { return (colors[idx].r << 16) | (colors[idx].g << 8) | (colors[idx].b << 0); } + break; default: /* * For unknown bit arrangements just support