From patchwork Mon Apr 27 15:11:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 238668 List-Id: U-Boot discussion From: giulio.benetti at benettiengineering.com (Giulio Benetti) Date: Mon, 27 Apr 2020 17:11:04 +0200 Subject: [PATCH v2 1/4] imxrt1050-evk: README: fix dd command destination In-Reply-To: <20200427151107.101075-1-giulio.benetti@benettiengineering.com> References: <20200427151107.101075-1-giulio.benetti@benettiengineering.com> Message-ID: <20200427151107.101075-2-giulio.benetti@benettiengineering.com> Make "of=" the same for the 2 commands since we're writing to the same sd-card. Signed-off-by: Giulio Benetti --- board/freescale/imxrt1050-evk/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-evk/README index f7e2894025..55b6a0877a 100644 --- a/board/freescale/imxrt1050-evk/README +++ b/board/freescale/imxrt1050-evk/README @@ -11,7 +11,7 @@ This will generate the SPL image called SPL and the u-boot.img. - Flash the SPL image into the micro SD card: -sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync +sudo dd if=SPL of=/dev/sdb bs=1k seek=1; sync - Flash the u-boot.img image into the micro SD card: From patchwork Mon Apr 27 15:11:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 238665 List-Id: U-Boot discussion From: giulio.benetti at benettiengineering.com (Giulio Benetti) Date: Mon, 27 Apr 2020 17:11:05 +0200 Subject: [PATCH v2 2/4] imxrt1020-evk: README: fix dd command destination In-Reply-To: <20200427151107.101075-1-giulio.benetti@benettiengineering.com> References: <20200427151107.101075-1-giulio.benetti@benettiengineering.com> Message-ID: <20200427151107.101075-3-giulio.benetti@benettiengineering.com> Make "of=" the same for the 2 commands since we're writing to the same sd-card. Signed-off-by: Giulio Benetti --- board/freescale/imxrt1020-evk/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/freescale/imxrt1020-evk/README b/board/freescale/imxrt1020-evk/README index 3da72fdad2..bcb3683163 100644 --- a/board/freescale/imxrt1020-evk/README +++ b/board/freescale/imxrt1020-evk/README @@ -11,7 +11,7 @@ This will generate the SPL image called SPL and the u-boot.img. - Flash the SPL image into the micro SD card: -sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync +sudo dd if=SPL of=/dev/sdb bs=1k seek=1; sync - Flash the u-boot.img image into the micro SD card: From patchwork Mon Apr 27 15:11:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 238669 List-Id: U-Boot discussion From: giulio.benetti at benettiengineering.com (Giulio Benetti) Date: Mon, 27 Apr 2020 17:11:06 +0200 Subject: [PATCH v2 3/4] video: mxsfb: add clk_enable() In-Reply-To: <20200427151107.101075-1-giulio.benetti@benettiengineering.com> References: <20200427151107.101075-1-giulio.benetti@benettiengineering.com> Message-ID: <20200427151107.101075-4-giulio.benetti@benettiengineering.com> BROM doesn't enable lcdif by default so add clk_enable() after clk_set_rate(). Signed-off-by: Giulio Benetti Reviewed-by: Anatolij Gustschin Reviewed-by: Fabio Estevam --- V1->V2: * call clk_enable() after clk_set_rate() as suggested by Fabio --- drivers/video/mxsfb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 8a5a61c9fb..12d00b4689 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -77,6 +77,12 @@ static void mxs_lcd_init(struct udevice *dev, u32 fb_addr, dev_err(dev, "Failed to set mxs clk: %d\n", ret); return; } + + ret = clk_enable(&per_clk); + if (ret < 0) { + dev_err(dev, "Failed to enable mxs clk: %d\n", ret); + return; + } #else /* Kick in the LCDIF clock */ mxs_set_lcdclk(MXS_LCDIF_BASE, timings->pixelclock.typ / 1000); From patchwork Mon Apr 27 15:11:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 238667 List-Id: U-Boot discussion From: giulio.benetti at benettiengineering.com (Giulio Benetti) Date: Mon, 27 Apr 2020 17:11:07 +0200 Subject: [PATCH v2 4/4] clk: imx: clk-imxrt1050: fix lcdif clock gate In-Reply-To: <20200427151107.101075-1-giulio.benetti@benettiengineering.com> References: <20200427151107.101075-1-giulio.benetti@benettiengineering.com> Message-ID: <20200427151107.101075-5-giulio.benetti@benettiengineering.com> LCDIF clock gate was wrong so set it according to RM. Signed-off-by: Giulio Benetti Reviewed-by: Anatolij Gustschin Reviewed-by: Fabio Estevam --- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c index 329f4580c5..8279e784fe 100644 --- a/drivers/clk/imx/clk-imxrt1050.c +++ b/drivers/clk/imx/clk-imxrt1050.c @@ -255,7 +255,7 @@ static int imxrt1050_clk_probe(struct udevice *dev) clk_dm(IMXRT1050_CLK_SEMC, imx_clk_gate2("semc", "semc_podf", base + 0x74, 4)); clk_dm(IMXRT1050_CLK_LCDIF, - imx_clk_gate2("lcdif", "lcdif_podf", base + 0x70, 28)); + imx_clk_gate2("lcdif", "lcdif_podf", base + 0x74, 10)); struct clk *clk, *clk1;