From patchwork Mon Apr 27 09:05:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\\(PLT\\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 238583 List-Id: U-Boot discussion From: s.nawrocki at samsung.com (Sylwester Nawrocki) Date: Mon, 27 Apr 2020 11:05:33 +0200 Subject: [PATCH v1 07/10] linux/bitfield.h: Add primitives for manipulating bitfields both in host- and fixed-endian. In-Reply-To: References: <20200424165012.31915-1-s.nawrocki@samsung.com> <20200424165012.31915-8-s.nawrocki@samsung.com> Message-ID: Hi Bin, On 25.04.2020 03:43, Bin Meng wrote: > Could we add blank line between macros and functions to improve some > readablity? Thanks for your review. It might be indeed a bit easier to read with some extra empty lines, given there is no any comments to those macro definitions. I have made a change as follows for the next iteration. ---------------------8<--------------------- --------------------->8--------------------- --- Regards, Sylwester diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h index 4964213..7acba4c 100644 --- a/include/linux/bitfield.h +++ b/include/linux/bitfield.h @@ -117,6 +117,7 @@ static __always_inline u64 field_mask(u64 field) { return field / field_multiplier(field); } + #define ____MAKE_OP(type,base,to,from) \ static __always_inline __##type type##_encode_bits(base v, base field) \ { \ @@ -138,14 +139,17 @@ static __always_inline base type##_get_bits(__##type v, base field) \ { \ return (from(v) & field)/field_multiplier(field); \ } + #define __MAKE_OP(size) \ ____MAKE_OP(le##size,u##size,cpu_to_le##size,le##size##_to_cpu) \ ____MAKE_OP(be##size,u##size,cpu_to_be##size,be##size##_to_cpu) \ ____MAKE_OP(u##size,u##size,,) + ____MAKE_OP(u8,u8,,) __MAKE_OP(16) __MAKE_OP(32) __MAKE_OP(64) + #undef __MAKE_OP #undef ____MAKE_OP