From patchwork Fri Jul 17 13:54:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235696 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724335ilg; Fri, 17 Jul 2020 06:54:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaDNG/nCQ1gwV90ZwkJTsNFGYxbvGmy0lZZYfsWCuVfAOQhOORIFj+IFDawPVJS8IqcdjL X-Received: by 2002:a17:906:40d6:: with SMTP id a22mr9017902ejk.133.1594994074283; Fri, 17 Jul 2020 06:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994074; cv=none; d=google.com; s=arc-20160816; b=Q07Tv0ISu0iHLwrF7+sDxUYMkg2HKCYGboH2q5xa/jM8d+NuwgVDVEZ97B7N6BVwca c4yQKQEqPwn+hC4AqMcSjWzgur+vR7sjredDhJDlOopNrEp62tDcmx8PwxvzT2JUgRMb ESqZBwQ5TsbQwZb4HCubiCXpLcNjGMrY45LwLvrr9bO9AH0s41JyyG+GgGy/GS1YgHcG eDnm4aROp3pFPEzQTh4g4vSZJ05XGmf6NuQciBkZIq45SWcbxuFbtb5zFokyqEN+o3e4 AlixwSrYSVas4vuEDCcG4QH6Qw1IWXhuWimS1c/Zcrh99E7EBNLoY18/0v9/itWpY3El NmMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KGFwubHFzcLZa75OH2QfePfgNHp1yNFJ+5dMrYJqOBc=; b=WRJN+fjuTYaquZDhaYfTVKF4buN4xtsdmGpv3vzwBtcBKmHjAVdi7F4hF5p/xRcX6f 8C/BFseAt4TsrIDRRxZGaYzJRU2+lsECHl441Y7TfxCCbk3J0Y6Rcw/6etgtdUnsB0HM 5UC1t4G1lPXpi23gkWTqmBtg6ZmbSE1gorYuKn4qV7Xl8iKEO/yVF7D9HqKBCo3h6ytN e/Nf5aQD3VoE7WBs7jKFsBLDKNrc9eL2inCySclfK9rDWgzXjXPf8QmhPS75QFQ9YpZD +n3Up+NNqfIf60bycTCXJF25RNvHioMXSq2dxWgSXTqhDU+DhP5YqlFPGHXnhKH3JP55 9u2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LNz53P4v; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z4si5263848ejw.122.2020.07.17.06.54.34; Fri, 17 Jul 2020 06:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LNz53P4v; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726848AbgGQNy3 (ORCPT + 2 others); Fri, 17 Jul 2020 09:54:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726846AbgGQNy2 (ORCPT ); Fri, 17 Jul 2020 09:54:28 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 664C3C0619D3 for ; Fri, 17 Jul 2020 06:54:29 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j4so11179763wrp.10 for ; Fri, 17 Jul 2020 06:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KGFwubHFzcLZa75OH2QfePfgNHp1yNFJ+5dMrYJqOBc=; b=LNz53P4vPM8KOT6MgDZZt6XHv/VQQGMQknAGIrbSBeKWG/DqcokivbaP+KPiPKngn7 wyZfusiKq6wHj1H3NRXBVRRgwn92OZuXpoHoB4COPu/LYEEaBWueviYAs+8vaToPfiIX +5mKXjsrA8Qsw9IgpOUyw9iRWhM+Pqy3/ulzSZ+J/rN5QrKtA3MWoVTDBIrTzip58nzf 78MvBYGi9ddoCLEP8NDJ/ry3KnnDNBWD0fJPc1A6756DJjCdCAN9/A1eh/zaUnKZmG3t JvKl6C0QsjM25XYiStS/XegGKvdBvzcCc4VK+mXGcUrzHGlergl5K2K3pcv73mIL85xQ Grzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KGFwubHFzcLZa75OH2QfePfgNHp1yNFJ+5dMrYJqOBc=; b=MpP0nO4b+U2NWlcaCitJfB2+7oNIdHzId9UqUHtIq0TVeCmziPymrsN6EyympV8PBp mbV2U0Sj659BH2RvHxtCjfP6C5krCnJGz26g6R6+wgOYxchINABYBteJjfGT+VLsD/24 Mu+P7mnHgYjRtzeN8pa/nlqbKJyA+GKZUoQoX0Sc0Em0E9tA48N8aTCcHoI5CMiP70Ex +kgUeh7ksYRHne7zqFKrYC+yaFKYkZjkR5ELsKVG3YKBS9g6GOVVq18IMUOd8Gs1kiuB n2a0RAdQLRJ2NkT8HEWFWiHNg7FYiLhoSyYE///pIY1bmeZbl4G9WNoF8DbnySTWTIM4 ZNDg== X-Gm-Message-State: AOAM530tZqKbjCTccYVxYghjG2TbUMPKSJ9n2a/IHslG6MHOq9KRMPth XcVuvOWdocH4HCmAToEYWmBMSw== X-Received: by 2002:adf:ee4d:: with SMTP id w13mr10311012wro.245.1594994068030; Fri, 17 Jul 2020 06:54:28 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:27 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Martin Sperl Subject: [PATCH v2 01/14] spi: spi-loopback-test: Fix formatting issues in function header blocks Date: Fri, 17 Jul 2020 14:54:11 +0100 Message-Id: <20200717135424.2442271-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Kerneldoc function parameter descriptions must be in '@.*: ' format. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'spi' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'test' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'tx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'rx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'spi' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'test' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'tx' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'rx' not described in 'spi_test_run_test' Cc: Mark Brown Cc: Martin Sperl Cc: linux-spi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/spi/spi-loopback-test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c index b6d79cd156fb5..9522d1b5786d5 100644 --- a/drivers/spi/spi-loopback-test.c +++ b/drivers/spi/spi-loopback-test.c @@ -885,10 +885,10 @@ static int spi_test_run_iter(struct spi_device *spi, /** * spi_test_execute_msg - default implementation to run a test * - * spi: @spi_device on which to run the @spi_message - * test: the test to execute, which already contains @msg - * tx: the tx buffer allocated for the test sequence - * rx: the rx buffer allocated for the test sequence + * @spi: @spi_device on which to run the @spi_message + * @test: the test to execute, which already contains @msg + * @tx: the tx buffer allocated for the test sequence + * @rx: the rx buffer allocated for the test sequence * * Returns: error code of spi_sync as well as basic error checking */ @@ -957,10 +957,10 @@ EXPORT_SYMBOL_GPL(spi_test_execute_msg); * including all the relevant iterations on: * length and buffer alignment * - * spi: the spi_device to send the messages to - * test: the test which we need to execute - * tx: the tx buffer allocated for the test sequence - * rx: the rx buffer allocated for the test sequence + * @spi: the spi_device to send the messages to + * @test: the test which we need to execute + * @tx: the tx buffer allocated for the test sequence + * @rx: the rx buffer allocated for the test sequence * * Returns: status code of spi_sync or other failures */ From patchwork Fri Jul 17 13:54:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235706 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724802ilg; Fri, 17 Jul 2020 06:55:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz50tMfSYfnG6MZIZZNoO5ZrXQz7dC29VYA5sX2Nh1Q0cvvVz2vGBYbpV+vv0h68cxye3TP X-Received: by 2002:a17:906:1492:: with SMTP id x18mr8462806ejc.545.1594994117707; Fri, 17 Jul 2020 06:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994117; cv=none; d=google.com; s=arc-20160816; b=1AEJ3eMX5XJNLo9TyXEydgdw9V7tYjnvC9z9obW7b0oBCCYv/C2WUYi6WP/DqcwagV W3Cz5jU6DEN+0IVF0voODGdBNWxHJrm0p0GIDWSxfhbNGs30b3m1VT3593J3rk6QF/b4 e3xvOohjHQyF1VlWn7oq84DKk75m+w1Tl5RRYkMN//bwwTKMterSxzpG3fTTw/UwUfv9 Tyjob4LuPuczNKDK6ux91uUP3Lfe4LjYX8oyGjpUMY96DUlqvUhtuHKTPROjypPqnfX4 PhnsZlxNYZJ8QT/lRa7S3kSEQu/kKJmuDqmT3VwPK3u5uPs/aokQlizj+ZHxmPBAWam2 gBww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+k3VcTxp8QDyMoYM0yDw+EEU9DorBAQ7cdSI3O9/bb8=; b=n15h9nVD+hgfXYRK6yopGvwcFoYPvgJ+/hrESJ9G3jUBa9tyYyMNGvua2m/uGutTsU x5jdavzWTQhwR5KJxJONN7pCM4N2m98avlNu7AypiCT8a5/rWNZ/FfJ+e3cuOsFL+n5K ZhKjceAx6Ca5OyuLyFsKwVAtfpboz0dIXf20Yo/ahQGP9nfR0uOnOKPbtW7X/IAd0GHB MRfxDvwm7dp5C4KGQxIsIQYe2MxnWIMpQ0SbxPBJY0p4nQUGtzM1WsippJsoIP1vmXyY FjrvHun/SHcN+62vdrvX1PANHonoGqc6D0KG/4dPWKcoN+KGoK8+IQFex+J5SoI45GeS LJ8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sxuSTfoC; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq5si5227174ejb.110.2020.07.17.06.55.17; Fri, 17 Jul 2020 06:55:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sxuSTfoC; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbgGQNye (ORCPT + 2 others); Fri, 17 Jul 2020 09:54:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726852AbgGQNy3 (ORCPT ); Fri, 17 Jul 2020 09:54:29 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5372AC0619D4 for ; Fri, 17 Jul 2020 06:54:30 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id r12so11126546wrj.13 for ; Fri, 17 Jul 2020 06:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+k3VcTxp8QDyMoYM0yDw+EEU9DorBAQ7cdSI3O9/bb8=; b=sxuSTfoC2hrZKKISGmaJt1ryNoM+Mb53vx2VqywQ2dm6pt4TZ3WpIxoolFr/96l5HI zgp/5o581dmdBiSgQH3SacRs4hO0s2WCDSNAoa/pJXkzvrtSt48cyV/mcy5I48v5N6uj xmXqic/H5aJT4crWkPnWZ3OyiIOkd6vfhc8jU3EPrcggEqC2+I1bjp0fuQRPhgEGivWK ha15AuG72HyS/oCVqOEXoBdq9Osq05Ti56BmkcMaSYnI4b8Yl6qBjBfxGW/MIAqK9BRQ 48m14QnuLysn9zQoC8jLbQP5u+0EN6xO+0yHGeuvFjNT3LPCFTTjHa67pDCtydIvFQ9Q GIiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+k3VcTxp8QDyMoYM0yDw+EEU9DorBAQ7cdSI3O9/bb8=; b=JmBXrGuqpDG6cjz8ecDwafzfDwjPgwG+IoWxcThNudRSahvLGq6FJ93+qCQzvHrgE7 5DJoZkt8l8fL1QgNIBTo+EE9zmg3jEnAWF6MrU/kM8GhCbJLxZP/gSC0kEfUh32svo9b szasdJae/CghEEFd1vtt5COas8mj1NLD6cDrX2NyzS1SxOmHGTTuk9B1U3dKxRkqmg5k 3p9g3+sWjpTIUKnuGVP4hBsKuoBcxwZlsINFdQbS4+f5gBfW/fxyltNN5AFahrzOcV1u rYKMA9bjDFVJvwQtcqbSSFztMD/KytwOz6/lArc0hKQ6x8aRN8MH5RUe6wlFrss3GnIA 3MTg== X-Gm-Message-State: AOAM5307qcPtfPF3zPvDsm/D3uJKeg775vo0msf6CxIYdXOJU9TnkDWS sqdSVnhI1QN0govrMWU8h/mdOXOJD9ZJGA== X-Received: by 2002:a5d:5450:: with SMTP id w16mr3244734wrv.155.1594994069010; Fri, 17 Jul 2020 06:54:29 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:28 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones Subject: [PATCH v2 02/14] spi: spi-bitbang: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 17 Jul 2020 14:54:12 +0100 Message-Id: <20200717135424.2442271-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-bitbang.c:181: warning: Function parameter or member 'spi' not described in 'spi_bitbang_setup' drivers/spi/spi-bitbang.c:215: warning: Function parameter or member 'spi' not described in 'spi_bitbang_cleanup' drivers/spi/spi-bitbang.c:434: warning: Function parameter or member 'bitbang' not described in 'spi_bitbang_stop' Signed-off-by: Lee Jones --- drivers/spi/spi-bitbang.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/spi/spi-bitbang.c b/drivers/spi/spi-bitbang.c index 68491a8bf7b5b..1a7352abd8786 100644 --- a/drivers/spi/spi-bitbang.c +++ b/drivers/spi/spi-bitbang.c @@ -174,7 +174,7 @@ int spi_bitbang_setup_transfer(struct spi_device *spi, struct spi_transfer *t) } EXPORT_SYMBOL_GPL(spi_bitbang_setup_transfer); -/** +/* * spi_bitbang_setup - default setup for per-word I/O loops */ int spi_bitbang_setup(struct spi_device *spi) @@ -208,7 +208,7 @@ int spi_bitbang_setup(struct spi_device *spi) } EXPORT_SYMBOL_GPL(spi_bitbang_setup); -/** +/* * spi_bitbang_cleanup - default cleanup for per-word I/O loops */ void spi_bitbang_cleanup(struct spi_device *spi) @@ -427,7 +427,7 @@ int spi_bitbang_start(struct spi_bitbang *bitbang) } EXPORT_SYMBOL_GPL(spi_bitbang_start); -/** +/* * spi_bitbang_stop - stops the task providing spi communication */ void spi_bitbang_stop(struct spi_bitbang *bitbang) From patchwork Fri Jul 17 13:54:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235705 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724788ilg; Fri, 17 Jul 2020 06:55:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtRdYs03MoLmiYyvh8Qh0E1bD88rle+XTdbEQLN1915H593qtguJukyssV3FTccQ2ycbdG X-Received: by 2002:a17:906:1111:: with SMTP id h17mr8423744eja.203.1594994117164; Fri, 17 Jul 2020 06:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994117; cv=none; d=google.com; s=arc-20160816; b=zfDr6l2MMPGt3u+Na2CLm0tg5Ac89RNVLCYD3wY50qeVb0nNqIbcpoSNayKKMzRrhd 9xQZsEn8Ux+crIuuzBEX+0Uv8tqa8/LL56hPeLLYdJCZbWUS71Gfv0/ujJsipukPa0xg /bFqvce46FUQqIZTL5Z/Wwl3dkyD9wD+IajmaHKFzj9FKDx7i0+5jSIdRMB3iSo6qaX/ PQwbU0azv8UL8jMdp76inxJpkD2cFxOehBggyN902s07v5wwCOXhkTEl0SampXBXW0UW 8DcIy6prDGmN0ZtHuRcrkVGHNGgFgJv7Aot5q4BbRq703JgXn3mNTThtPX4+ryC4IQpA FXrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vKemoWjqR6g96Xgsgirmftjm/E0sdVIsOFgpktr/D0I=; b=qSHpi+WCVcybJHEvGZ4hRbYuyLJ05O8EauZJ4lGr2E1yoB+x5JdNijCOMIjeeL3qm5 V3p3rkGAv3VZMDcMyfxZlFcz/AxXPoWTjxny1ocsvCZUJRpfkqSFGSbfNzCdx4E0QSAm tHPJmvWyABtnEnhA0KMECfQaV3UkB0NqS5UaRCn85sIPSTW5+mlEe+9EXlrmPqZqAgcr 9QoiBhyO6CBOa9ozjMCBZMgWhXcrARlDcOFVgg+7csx2y0TrUeoLA4Z5IBwe6i9gnU4H OLFzFzm6OQ7tSRSHK6PKp/cfuU8aQjIo9zXXl8LL88D3+Yv65duh9SbRm37o6lSESxKC D9iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KkJ58wTN; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq5si5227174ejb.110.2020.07.17.06.55.17; Fri, 17 Jul 2020 06:55:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KkJ58wTN; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726983AbgGQNyf (ORCPT + 2 others); Fri, 17 Jul 2020 09:54:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726923AbgGQNya (ORCPT ); Fri, 17 Jul 2020 09:54:30 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A7D4C0619D3 for ; Fri, 17 Jul 2020 06:54:31 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z15so11192597wrl.8 for ; Fri, 17 Jul 2020 06:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vKemoWjqR6g96Xgsgirmftjm/E0sdVIsOFgpktr/D0I=; b=KkJ58wTNLjFEfso6eafu7XHSWYDgIT2QpWO7ZoFkscH8T9bz8ZmXHL/FjjlmZ89szi SaFxtVC+zwUMaS9y7ToZr9FGXrgGE9lajWTHriEwPcmteH93rS1qRDvL4YRUgyiwqVjY j2XI/cb69GWiMEVGLVZJpYOnN7mJxmtOVxzdc5xq7P1QqsKa5UyRwAwgxwGNN4SMhZ9c TqcG0zsLXsFS6Z54kAMk4BtYeysJM7Og48NOlrTAwXyP4f1nYDQ2Co2a33Si6aDn5C8r t84r0SBiYXp9Hn5nQINc7//3xnye6zTLmDHLpUWGwXf2nG1a/uQpGh81nFfjKIfX3oCe TMVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vKemoWjqR6g96Xgsgirmftjm/E0sdVIsOFgpktr/D0I=; b=aDaOH8ze871zRt4ZdTsAWvM3enhEprPjL7BxY0CiTyK+901jhOlSon2Nx2/bTm81Si zS1ad/AlblvBgywIZ3NzjJESqoHsmXEBjDvJR7v1eDuimNsDM+R+G0mE2Caq+LeXjQck /OwwB4d5i4njTmiE+NtnXNfpZgglYGHVV8nq9kLJgpM9379VOrgddToCaYAHHx+3G2N2 cEeVhOWHoUj0XpnCRm2qSsHkXYMTzWLPf+ogKZCGsMWEvIA+fir6oHZzH+zz+ShRMArT smqDbug/SF9BZQ/11v0qCU1vaHRhRUP2l6sSmLYApeJRFrP4mJkbdPRg6WIowaJvwMUy 4W1w== X-Gm-Message-State: AOAM530bj6abbw43aIAZoYb3hAwYfaFzyh5MEMgCufMK55WWPQd6LlnZ NusbLt8L0M17YkhAEIw7Al9N8A== X-Received: by 2002:adf:e44c:: with SMTP id t12mr11315545wrm.103.1594994069964; Fri, 17 Jul 2020 06:54:29 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:29 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones Subject: [PATCH v2 03/14] spi: spi-davinci: Fix a few kerneldoc misspellings and API slippages Date: Fri, 17 Jul 2020 14:54:13 +0100 Message-Id: <20200717135424.2442271-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-davinci.c:249: warning: Function parameter or member 'dspi' not described in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:249: warning: Function parameter or member 'max_speed_hz' not described in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:249: warning: Excess function parameter 'maxspeed_hz' description in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:719: warning: Function parameter or member 'data' not described in 'dummy_thread_fn' drivers/spi/spi-davinci.c:719: warning: Excess function parameter 'context_data' description in 'dummy_thread_fn' drivers/spi/spi-davinci.c:735: warning: Function parameter or member 'data' not described in 'davinci_spi_irq' drivers/spi/spi-davinci.c:735: warning: Excess function parameter 'context_data' description in 'davinci_spi_irq' Signed-off-by: Lee Jones --- drivers/spi/spi-davinci.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index f50c0c79cbdfa..818f2b22875d2 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -236,7 +236,8 @@ static void davinci_spi_chipselect(struct spi_device *spi, int value) /** * davinci_spi_get_prescale - Calculates the correct prescale value - * @maxspeed_hz: the maximum rate the SPI clock can run at + * @dspi: the controller data + * @max_speed_hz: the maximum rate the SPI clock can run at * * This function calculates the prescale value that generates a clock rate * less than or equal to the specified maximum. @@ -710,7 +711,7 @@ static int davinci_spi_bufs(struct spi_device *spi, struct spi_transfer *t) /** * dummy_thread_fn - dummy thread function * @irq: IRQ number for this SPI Master - * @context_data: structure for SPI Master controller davinci_spi + * @data: structure for SPI Master controller davinci_spi * * This is to satisfy the request_threaded_irq() API so that the irq * handler is called in interrupt context. @@ -723,7 +724,7 @@ static irqreturn_t dummy_thread_fn(s32 irq, void *data) /** * davinci_spi_irq - Interrupt handler for SPI Master Controller * @irq: IRQ number for this SPI Master - * @context_data: structure for SPI Master controller davinci_spi + * @data: structure for SPI Master controller davinci_spi * * ISR will determine that interrupt arrives either for READ or WRITE command. * According to command it will do the appropriate action. It will check From patchwork Fri Jul 17 13:54:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235708 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724850ilg; Fri, 17 Jul 2020 06:55:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2LjyDdRbR14bVdPeSW3UYMgOuBpf1KADoJsKJ9PBI0D7Iq6a+J0FV60Z8h9qNSiKVCE3B X-Received: by 2002:aa7:d4c1:: with SMTP id t1mr9317091edr.253.1594994120374; Fri, 17 Jul 2020 06:55:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994120; cv=none; d=google.com; s=arc-20160816; b=tPBT0eLpyGPyUdV4bAbNPLpjgJVHN2gc1mxXb/RX++Y7Uo4jRumQRp1rzPu5gQjL3O LSkswd8DxXx3COv1+BXQ1ASD3+v4kdhJ5gaFYmyjzloRe59t2UUTS+8T/TYmgKowbL3I iCux0sGqPpYmw1wT1Sjg+Eiv+Nu6pvCWwXBSnnBJrSTH1CUoD05fx2DTkP8TYOnIA6/G rguiDnO+65440Z8YkyAfiL/esVmOZ/LW97dwK0zgJgdZGrw9yITqgnbpLqe27RxDisaj o4SdaHTfiezR8N2+jcuCMJMAR5flg0y1d/vB4Ca0D6i8h02ZH2CRF37Ac3dBS4a/QIQu UnTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q0v3MpsT0EiR8b5Jx0N89c4SZ6k9ifhqdf8ekF4nSQ4=; b=PZjYHI7jgHQqaAEZWYBEyfXqIxCA3z6CHWRMpChXbR8XEy2sTl7RGOb526Kr4RGWwj r8VV84R4vG9TObSM8CMeQoSoD/CbS73ESrT1u8VABc59llwzoHASzp4DKipPCgZYJ59j Lz4K4G0lYCBII5A1x0D5QN/P7jaDGxocOmeDW4OYnWXykJ6/Ga6bNBvDJB839//8SYO4 SzUsGc1nSgyH4MDxh1+Uss50D+fpoGog6C/vEi0VWqLI+a5m65B+MExMuw13ZarPN+zF WPn/ChbX7PEyQc1jfD8c8S0XpY9U0j1Bp0SvBjUrhnK/xKqAPpmuAGMwzDZDuDMnLnf+ xF6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Lnb0CtVb; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq5si5227174ejb.110.2020.07.17.06.55.20; Fri, 17 Jul 2020 06:55:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Lnb0CtVb; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727898AbgGQNzR (ORCPT + 2 others); Fri, 17 Jul 2020 09:55:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726947AbgGQNye (ORCPT ); Fri, 17 Jul 2020 09:54:34 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C13CC0619D7 for ; Fri, 17 Jul 2020 06:54:32 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z2so11258082wrp.2 for ; Fri, 17 Jul 2020 06:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q0v3MpsT0EiR8b5Jx0N89c4SZ6k9ifhqdf8ekF4nSQ4=; b=Lnb0CtVbWRFsYcq4I5p0F1kPtzqlpb6+B4HmHr3H+ScjOsj6hVQKmo+YIsjT/9/1Wb Yy2UgzVEDRWavrWMKex3LUCcFe52iG62z/WvSEZ3zI6juSVZPj/pEqEXhfaMh3gIozlj t7HNZjapNynHgojy1h7+YTFwv7Qum3LB6AZh/SMfJecVuhCDb/bMSGw8ZfBrXf59OnzV lZiGC+oV1HLtzifxh7cQfiIOF4+ng7vsehMXUj6Q9InmFvkFup9vjes56JwEP1rkc5bM WAUuYaXko7tWKb7ZE114QTBu1M2OSz72GYWTnkhCU/cozXoZHojS11ZFxsEZ3fmtGekd nM6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q0v3MpsT0EiR8b5Jx0N89c4SZ6k9ifhqdf8ekF4nSQ4=; b=j9wr1rZqw8MDI0BiMAaOTXiJMs1/eqxuerNaQ9P1kih38pmrjwIE2JVyH/k1mjy01V KVK3x8DmBzj1fHvkVCQ7olxRTpykE1O5fLu5oLuxnZOgtng7vAdfaJWI31p/B8jtpu2U JbioxiZgB0UGSGqeTk4/DCFRZM/vPUnj9pKylB6nBeTGE77WjEMIAenacYq0CHDBtP6+ zO1KPXqcAdJLhtPrxWcF6UMpec+ZXaGBt3GR/j0ZZ+Rww+ca2putDcPnn4edjQBsJJk+ DKKJnTOvID2NI47M56WjUFXlYcOZjEMIVvcxEvbN80B8lXHvQj49rbUPZMaHjEvIx1r2 a23w== X-Gm-Message-State: AOAM533LjLgxP9bs/dJHs4L1N2z+8b9x8nkd6hYW02+a1yafQh8KdW3T ZMVmWNGWsIjBI3jzWM+xQlfPNg== X-Received: by 2002:a5d:4f8b:: with SMTP id d11mr9770503wru.147.1594994070888; Fri, 17 Jul 2020 06:54:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:30 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Mika Westerberg Subject: [PATCH v2 04/14] spi: spi-ep93xx: Fix API slippage Date: Fri, 17 Jul 2020 14:54:14 +0100 Message-Id: <20200717135424.2442271-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org ep93xx_spi_read_write() changed is parameters, but the function documentation was left unchanged. Let's realign. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-ep93xx.c:227: warning: Function parameter or member 'master' not described in 'ep93xx_spi_read_write' drivers/spi/spi-ep93xx.c:227: warning: Excess function parameter 'espi' description in 'ep93xx_spi_read_write' Cc: Mika Westerberg Signed-off-by: Lee Jones --- drivers/spi/spi-ep93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index ae7c79a062084..aa676559d2738 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ -214,7 +214,7 @@ static void ep93xx_do_read(struct spi_master *master) /** * ep93xx_spi_read_write() - perform next RX/TX transfer - * @espi: ep93xx SPI controller struct + * @master: SPI master * * This function transfers next bytes (or half-words) to/from RX/TX FIFOs. If * called several times, the whole transfer will be completed. Returns From patchwork Fri Jul 17 13:54:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235707 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724818ilg; Fri, 17 Jul 2020 06:55:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzDX1fowCaSKP3ihKBLq2dXrbURw16gHhc677JzQF3JYUn7jQo1JC05JsXcB4/HR3X7PgB X-Received: by 2002:a17:906:f53:: with SMTP id h19mr8329681ejj.491.1594994118568; Fri, 17 Jul 2020 06:55:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994118; cv=none; d=google.com; s=arc-20160816; b=Kj2yXvlq4xkv0knP0KaB/OMaX0VxgCmU4xPC++wJYK+YrFV0mR9XCiig68W3Nz3z56 EMZs3tUolPjTGKDfQsBgR9+1exzuQsaKGYf7rGML/gsjHU1Yk33OU65RLoWWLm6s1Avg UKcjw6X5RMBl9ebecuwjYJYUXwOK6878VLIRYk3RpqKRXl5Jzb52Ak5HIimSp+KMMPmA 84LNB7dd0u6R1qzFdQ20v/LSeaApaZduIJeXoM+qGrtt+vWFO7d1txi8nG4HfaeYsMac 0F6Fyff8l35v+WBScIC95JLPwGrwkFYZpK/lIBUtCvE0Jy5lgkxjxsK7upCgEu7AFcQx mW+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=R5bZU73kxT5M1JMsvuGC6Lo9dJE8hXmdkV8EdjzvhWs=; b=NPJp+1roZTeaGnBHFk7CnDmzMN8aY4FDMptBkdJHKk48j0pDoWRpi0Ve274H/aCl9v Ocb5Rs8fSlP7hYQWp9H4hr6oR11eYOwncgSNvYVIr1bLO2V0LxDsSUKnG7pyWCA9XALC zAeNERNfge0bqvmD3wsqCI1V7q4U96ImPoaUH8aFY3ymhzdI4fHHWBDy4wIMOmolJKk/ 7ajm1XBIU9Lzz2I1dQHFw6LdpvtFzRXrkhzrttGem/1Jd8xOZmUa4nhj/Vv/u7TscGNJ x+a7Jr600xqeW8BJorzq7lF9nYLtCwP1Iw2DBXCiQT1VgeFr/fOdN43ipn0n/uJWpo8h fzVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZAC5kkae; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq5si5227174ejb.110.2020.07.17.06.55.18; Fri, 17 Jul 2020 06:55:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZAC5kkae; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727888AbgGQNzQ (ORCPT + 2 others); Fri, 17 Jul 2020 09:55:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726949AbgGQNye (ORCPT ); Fri, 17 Jul 2020 09:54:34 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30173C0619D9 for ; Fri, 17 Jul 2020 06:54:33 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z2so11258151wrp.2 for ; Fri, 17 Jul 2020 06:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R5bZU73kxT5M1JMsvuGC6Lo9dJE8hXmdkV8EdjzvhWs=; b=ZAC5kkaeD48hDzasHcMFBgI5ok3om/Ag5jSHoowWVEUw02KGIjIWhow3DY2EWpzj1k xGIQfKuwkO6ETxRSTvlinnPUEMJh5/qXsllh3rX9yQQ5qtv6gB5OoR9meWBkVvG+GZFV aJWhSVmI/c5AX1aCSjblRbbyZkqfNY8nX0kmHTI4kACCAYFjKYyHj9YMFXsOA0U2gl7k JPPPn5HFtj+Aq3tDCoBEZqm00dLcmf8Me76bz9eW43D6ng60idi56pggV1F3MsRrKQe0 aYxadZEomTMoFaJKKr+DcDh6tNOFHztWuOeSlU+oyVZKjITYbEoH53/73ocvYz5aFLxK WtKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R5bZU73kxT5M1JMsvuGC6Lo9dJE8hXmdkV8EdjzvhWs=; b=uYWEIonpXH90zZ+uX8fLhIqU9L8cKMr3lWS7BT3HfiCDlVYoFnzk/R7mWfjpv3wLJ0 3LPyqOPilYswZHfSXlZtDwS5l4zJyrn3B/BxPjzCSY/EfcEnBpvYiXUYJo+8U0ThNUgL k/A2EbhaVD3B7qWDXROzLWGYI2xgvxRLk+38HsdaC809l43EAqZFCWQ1dmzWMRmj7J4l AqdGNQkZCm+hTL6C3rx0BDE50b64FSBnti5xKIT5aYmS1f8NNlfDfWTDJU3qcxbtLfgn aO+72XpXLMPnXxOaFpOQPaKloqF23BpibPLCm7FVvV1b02Ij/HpiDMNn4InzAhPrJD3v u1Lg== X-Gm-Message-State: AOAM530n9t6GPxCtovsJFOckmC2Pykv4dDuUmpANFsF+7j7MUKux0wDl do5UOpZfhOpBfvXe8fi8+RtSkw== X-Received: by 2002:a5d:4607:: with SMTP id t7mr11203477wrq.251.1594994071957; Fri, 17 Jul 2020 06:54:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:31 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Kevin Hilman , Beniamino Galvani , linux-amlogic@lists.infradead.org Subject: [PATCH v2 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' Date: Fri, 17 Jul 2020 14:54:15 +0100 Message-Id: <20200717135424.2442271-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spifc.c:80: warning: Function parameter or member 'dev' not described in 'meson_spifc' Cc: Kevin Hilman Cc: Beniamino Galvani Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones --- drivers/spi/spi-meson-spifc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 Acked-by: Neil Armstrong diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c index c7b0399802913..8eca6f24cb799 100644 --- a/drivers/spi/spi-meson-spifc.c +++ b/drivers/spi/spi-meson-spifc.c @@ -70,7 +70,7 @@ * @master: the SPI master * @regmap: regmap for device registers * @clk: input clock of the built-in baud rate generator - * @device: the device structure + * @dev: the device structure */ struct meson_spifc { struct spi_master *master; From patchwork Fri Jul 17 13:54:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235709 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724929ilg; Fri, 17 Jul 2020 06:55:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/vmz0+R9893aY0Vk8O1/CgO4mYlBekBthgPEcfvqC91o1Tzj/sjCMQsqksW3pQ3jyDLMc X-Received: by 2002:a17:906:f98e:: with SMTP id li14mr8481826ejb.174.1594994126178; Fri, 17 Jul 2020 06:55:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994126; cv=none; d=google.com; s=arc-20160816; b=fVHug7FpegUPgkC/v94nIi38Kp/n2e6J/i9OlhjyzLsyoTObqZtVCfAKkLNd6QjgAj XXWjhf0YDRoSz8e/kSu1oVWykYjC49aSe1e9iCFcj/8RcuGsCt49Re7yQF47iOjqaaao uJrOeUh3xDSYyciemHqrg7yd54xX+pFptKjbaHxH2lxGUw4fXeJVkvYsVlJsWogwYVr3 3P7te+uX3VYu2RZxz6mc2CJfTAEc0GKi1AWNzqSBdJzTMvcLhkD5e5NiHrHHcJsbw0TH x3rG4Uc9OmW9Uisblrr91t03nm843FWKSZsoFLiNfAC8Zl8clQ+5RVrMXbT0r03QThwY VXaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Neuk7hlxyMHOEJZl+c3Ce+fuWuJ+zLYxzzvecm8U2ZQ=; b=zUZaJsJUmcMkGrx1sISr8dz1BWrlTCVUBmMeWIh2u/Uqww0nR+my7sRzSudJ9LLuHs WgjDgpZF/fEBNsAfPHEnTAgJ0spjc3/V849JLeKj81t6j6+6hCS9Q66KrRSazIhZ5Rsz 7H5WR4u4LZP3We9ezBj3fjREwxornOFsoqUAVH77rA5DLY/1k/Zp3ClUhQBFsrEnSsib 71II5t8eWzLjA6Bm34PbXWZPNjiQhpME+x/iIymfPN7IDuhc1gm04Drd9kIli+k/k1cs jEHMEd/MPbx0NtWhBfKxcIm1E/+ExGwzuSaaKs/xzE4GHqqOF2zCdpN5V1IjtivkzLny McHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JqcHwGwY; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq5si5227174ejb.110.2020.07.17.06.55.26; Fri, 17 Jul 2020 06:55:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JqcHwGwY; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726968AbgGQNzQ (ORCPT + 2 others); Fri, 17 Jul 2020 09:55:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbgGQNye (ORCPT ); Fri, 17 Jul 2020 09:54:34 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 566CEC0619DA for ; Fri, 17 Jul 2020 06:54:34 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z2so11258230wrp.2 for ; Fri, 17 Jul 2020 06:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Neuk7hlxyMHOEJZl+c3Ce+fuWuJ+zLYxzzvecm8U2ZQ=; b=JqcHwGwYT8ZTvOUrpYD9UCG8OknPKe8KLct5xkbhm9XKF4P4uYR3ON03DVJiunjCn9 QalPNLZvjQnz3T1ZZ9giCZ7GjjqGSi2w13uo8hMx3L+J4wM+SCKHoJ7knI9Kd9M/nlGt o2wI1kB21f9JI/xRneRKdJMNoMlJAyRmqfVA58DfnQrFib3EINkomufdHtBctOOj2LIW QTMr9rlzAWo6+J4efQMbIqi8bDow/ngNWRzB8LMci5NiRtYIKlNTofQTrypuLrgTkW7c HVDsTyXjFUajMUuSHCJRL7I3fU2YEwA78dG7meEnNEPs3ruKpDUG/HVmR6gs+ydyy2Hu f9mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Neuk7hlxyMHOEJZl+c3Ce+fuWuJ+zLYxzzvecm8U2ZQ=; b=Dge+51hToMoKRl2YoIUUnutyeYoL9Evf8U7F9P5yoiow+banZIRmOcqMf9NzuOD0x4 OYGKQpOmotiVzqBuei01RZPqRQjQjou0Oq3KtCy/+hyjx60HyRgvcVYJEvMwWrUvk+EP yfgckXZp7QqNCXDAe+xuUvrL/4DUAMl+/h3SA85sYbM/rq8mnq+5U3wCX41ABU04dnP6 meIwyanWU766ozUqGJJt9TrzVW0U+xap/JBWoDchjFYG1acZimhQ1o5G1XdRg8XOkrDx oYEWxr99lUboYsecUZAE+jqSiOsBzsNhcyN0BK3Hik09nUyyhm8B6CctL6Je/9ECrY+l 1d3Q== X-Gm-Message-State: AOAM533uTgXBdmlvPcO5PgIVHMXEcHe6xAX2kGfgGNM85KgVabQ1mVcN TATTYxBK494C14KJ/hwPlo+7WGkXluENfg== X-Received: by 2002:adf:ebd0:: with SMTP id v16mr10685903wrn.241.1594994073095; Fri, 17 Jul 2020 06:54:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:32 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Kevin Hilman , Neil Armstrong , linux-amlogic@lists.infradead.org Subject: [PATCH v2 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() Date: Fri, 17 Jul 2020 14:54:16 +0100 Message-Id: <20200717135424.2442271-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Looks like it hasn't ever been checked. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spicc.c: In function ‘meson_spicc_reset_fifo’: drivers/spi/spi-meson-spicc.c:365:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] 365 | u32 data; | ^~~~ Cc: Kevin Hilman Cc: Neil Armstrong Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones --- drivers/spi/spi-meson-spicc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.25.1 Acked-by: Neil Armstrong diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index 77f7d0e0e46ad..ecba6b4a5d85d 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -362,8 +362,6 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc, static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) { - u32 data; - if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, SPICC_ENH_MAIN_CLK_AO, @@ -373,7 +371,7 @@ static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) spicc->base + SPICC_TESTREG); while (meson_spicc_rxready(spicc)) - data = readl_relaxed(spicc->base + SPICC_RXDATA); + readl_relaxed(spicc->base + SPICC_RXDATA); if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, 0, From patchwork Fri Jul 17 13:54:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235702 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724696ilg; Fri, 17 Jul 2020 06:55:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAQjL4nnhU14cm0ke8Hus97gZvq346sve4j4fsm0E60Tfc2f6fjrfTxWUvSQLlYASB6Ya+ X-Received: by 2002:aa7:c991:: with SMTP id c17mr9383457edt.278.1594994107044; Fri, 17 Jul 2020 06:55:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994107; cv=none; d=google.com; s=arc-20160816; b=Y0fxusonEG0gOdf45NmKPDsWU856ZF3cYkQ/OemI+/tsDGJgzsqxFi58jjCRHbV01g YRTgULlgADVcKHEFlf88I8y/k5Ug9A20H6dtUVgta3a6CXtnxyuNbnK843OWsy0KCD00 as5fwEo683SKBAJWWWwtgUyk6RFg7AT9Mgp6tG3+Oi8zhLKVjDP80VvR1IOQYkk/GpQx nq5ZwWtf+7qUsXRdmOTVBM51A5njcEt4DCRBUoeY6wD6X9hfwFESr2WXTZc7U0HdssL+ LEYiA7Da7GrbQlPNf4pTt5syB5vdHS28dr5QS7CO5vrSOlfSnKMYEA/ruGsKzVUmMCu4 ERug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BdU11UOQFuXyCSynzxRXM0IT1vARtgrxd2bUOuqypjo=; b=KsgVF7RKZSppc6wYDsmCYbjkl6/KULMFGSz2Owkk/aGxFEpyvABKiDHDxQA1RgF9XI n0SiM0SehGPtbxMi34uQvrjGdvFT8BPkuIfDbmBzXv68tu7ff/fsNiHaayQva1l8zh3h r65F57e8Ow+Maa9RdNbqPit9gaa+zrmu/8pJndHLBM8KZtpEfA3bRLHc6he8riQ2C4Hv 47flsmoxzU7MHlD/Io3YNG+dxG1hgENkFNpLNlIOcsXtj2AEH+kRC0907mbt98MBCw8X nD0s9Obn97+kwXl73wTUlIKI7qLlTi53oMKQUd+z3WfAntUNaeI0Oec79IWfVPnr8X/W BrDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z6e2Az59; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq5si5227174ejb.110.2020.07.17.06.55.06; Fri, 17 Jul 2020 06:55:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z6e2Az59; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727033AbgGQNzE (ORCPT + 2 others); Fri, 17 Jul 2020 09:55:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727001AbgGQNyg (ORCPT ); Fri, 17 Jul 2020 09:54:36 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E25EC0619D5 for ; Fri, 17 Jul 2020 06:54:36 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id c80so14957471wme.0 for ; Fri, 17 Jul 2020 06:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BdU11UOQFuXyCSynzxRXM0IT1vARtgrxd2bUOuqypjo=; b=Z6e2Az599CouQ+hjKJ3fh171GrmBXuuQYoyxs21YgHQXcnooWtd0d4qYE1hp7Fwp5Z SM8M9boXYBJvn8lwPVCVxW6+FNHJUOfLDJ52Mrw0pvO9wEGLC8olytK/rYr01bgfpIRX NfOd0UXXmOtLeEZgF7joBx8fm4hIDMZDinwqPn3IXqLfsoAW+pE3JeoJdYkxDJ+rSeGm zl3LNaO8Iip6w5A2lPOWUgmwjQqpCN61R357z3ZYuT4myLa+74zeRFOI1eyXwWOm8FDM ISnduGtoskDm+LkUDeOMHuTItePm8NNoAdICqcjQFMk/XhvtEoz3VYA6B7hUX6aUJ1V1 XjxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BdU11UOQFuXyCSynzxRXM0IT1vARtgrxd2bUOuqypjo=; b=btn4GGQrgf0dnDnFn/bFEB4GzOsN64GvSP5CMVtrCXKZK13blA3T2DpIL+z6zgNJDA G1FaCbjMr5YSCbXpixFa29BIX5Y/YHSMAW2QVIEXUyu+/Lki7/fv9nY/qMhUApYVtqBZ VHBbzx1d1EFIPUBH6mXHe0x7P8DEiTkSXGIF3VPIBZCCHjPGK/qqKp75WkqxqGvFH7Kt ps/osIT7/ZcixyHWX4Us3yKZ7q0Teo6yhf9D+4SEtafLZ8uNGGIMy2mU40yN6+iePO9W KVOsdeDVdG1q4YSE0c6SVcA0jcZ1DcQLnZZv/WusvTZdrb8LjOFkbWDQtiRTrWZsbA8b y/hA== X-Gm-Message-State: AOAM532ghgitowdLl5ebeSEPNnkcxUT+AnhbYOaHSHGbOIk0LZektgxN 92QM94o6me6M1wkH/xbKf1c69w== X-Received: by 2002:a7b:cd83:: with SMTP id y3mr9305717wmj.105.1594994075163; Fri, 17 Jul 2020 06:54:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:34 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Sachin Verma , Linus Walleij Subject: [PATCH v2 08/14] spi: spi-pl022: Provide missing struct attribute/function param docs Date: Fri, 17 Jul 2020 14:54:18 +0100 Message-Id: <20200717135424.2442271-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Also demote non-worthy kerneldoc headers to standard comment blocks. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pl022.c:304: warning: cannot understand function prototype: 'enum ssp_writing ' drivers/spi/spi-pl022.c:330: warning: Function parameter or member 'loopback' not described in 'vendor_data' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'rx_lev_trig' not described in 'pl022' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'tx_lev_trig' not described in 'pl022' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'dma_running' not described in 'pl022' drivers/spi/spi-pl022.c:670: warning: Function parameter or member 'pl022' not described in 'readwriter' drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'irq' not described in 'pl022_interrupt_handler' drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'dev_id' not described in 'pl022_interrupt_handler' drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'pl022' not described in 'set_up_next_transfer' drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'transfer' not described in 'set_up_next_transfer' Cc: Sachin Verma Signed-off-by: Lee Jones Acked-by: Linus Walleij --- drivers/spi/spi-pl022.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 66028ebbc336d..d1776fea287e5 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -298,7 +298,7 @@ enum ssp_reading { READING_U32 }; -/** +/* * The type of writing going on on this chip */ enum ssp_writing { @@ -317,6 +317,7 @@ enum ssp_writing { * @extended_cr: 32 bit wide control register 0 with extra * features and extra features in CR1 as found in the ST variants * @pl023: supports a subset of the ST extensions called "PL023" + * @loopback: supports loopback mode * @internal_cs_ctrl: supports chip select control register */ struct vendor_data { @@ -353,11 +354,14 @@ struct vendor_data { * @read: the type of read currently going on * @write: the type of write currently going on * @exp_fifo_level: expected FIFO level + * @rx_lev_trig: receive FIFO watermark level which triggers IRQ + * @tx_lev_trig: transmit FIFO watermark level which triggers IRQ * @dma_rx_channel: optional channel for RX DMA * @dma_tx_channel: optional channel for TX DMA * @sgt_rx: scattertable for the RX transfer * @sgt_tx: scattertable for the TX transfer * @dummypage: a dummy page used for driving data on the bus with DMA + * @dma_running: indicates whether DMA is in operation * @cur_cs: current chip select (gpio) * @chipselects: list of chipselects (gpios) */ @@ -662,7 +666,7 @@ static void load_ssp_default_config(struct pl022 *pl022) writew(CLEAR_ALL_INTERRUPTS, SSP_ICR(pl022->virtbase)); } -/** +/* * This will write to TX and read from RX according to the parameters * set in pl022. */ @@ -1237,6 +1241,8 @@ static inline void pl022_dma_remove(struct pl022 *pl022) /** * pl022_interrupt_handler - Interrupt handler for SSP controller + * @irq: IRQ number + * @dev_id: Local device data * * This function handles interrupts generated for an interrupt based transfer. * If a receive overrun (ROR) interrupt is there then we disable SSP, flag the @@ -1334,7 +1340,7 @@ static irqreturn_t pl022_interrupt_handler(int irq, void *dev_id) return IRQ_HANDLED; } -/** +/* * This sets up the pointers to memory for the next message to * send out on the SPI bus. */ From patchwork Fri Jul 17 13:54:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235703 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724704ilg; Fri, 17 Jul 2020 06:55:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmujXfSLGlQtRBveBhDdCfXzUDjF+fL4UrY6HIpixgogpQtlZNxqLB12ST45o1qaDdg92l X-Received: by 2002:a17:906:40d3:: with SMTP id a19mr9000706ejk.474.1594994108302; Fri, 17 Jul 2020 06:55:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994108; cv=none; d=google.com; s=arc-20160816; b=Y36qjry8VbBNHf3RFwpPNmeRc01u4GEdrlQaUeslWPh0wE8ncXpnsbtv88nfaSoVe0 whWZE+ntG/qxOWWiiTAUbSuQbaFm0E6eJ2RO5JLOaM1gPg2JL7Bz7V7MAJqCOyCNv2HL ztvYj8pHpiPZFFCJ1dKGYHpxmg+fnqI+SLWzAy1QCUzxp7xwFAExTkw3rKlfM5DlOAAY e2nSd81Qi3wyQAD6dBo9vWOCt1miNoOZHqXBdTlk1X4Da1A2cRpIgfLF02XuzxJKDvsI 8Zc3RwVDPN/EFmB8qisJsCykzXqMuzvMoCo5GPvzpowzzM0IORHQuHh/RAkV4Lx/pQrH Kdwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/mBj9pAMuVLonO6aKhrgrEYwyEsNFutXpDwnyRxo/to=; b=Nly4rifxFvv0VsyZvGL8ju55fOb2d0za0ePx18QixJz3WDdSymzfAmHXm2nMJPIGy4 b99Oy8tty5jhkwrARL22pMmQXL+sfbhiBVH7b7iTudK9NEK86pV8PnypkwzKMwsmAdBA 8HpdZ2CpQpK1r8JThEybr9EoaL2Vd9LXlsWulX6EAAn7/vBjh8LyMlWcaYkTuy4j4yzS NUZ3YXF2DxF1wYhLfAl7xFkUGfshfdHKWwXk50crDQyTmompgmT+5Mc+rN/9AbiYJ3+H D5FFqjxDQSDwRVtTpWbG/KAcJoPepQaZ5tZ6NJQQm1cFCU2FLVgD4uc1EXW/Xhj88wXn w6lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cCC6wwWl; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq5si5227174ejb.110.2020.07.17.06.55.08; Fri, 17 Jul 2020 06:55:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cCC6wwWl; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727837AbgGQNzD (ORCPT + 2 others); Fri, 17 Jul 2020 09:55:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbgGQNyh (ORCPT ); Fri, 17 Jul 2020 09:54:37 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89287C0619D4 for ; Fri, 17 Jul 2020 06:54:37 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id w3so17159209wmi.4 for ; Fri, 17 Jul 2020 06:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/mBj9pAMuVLonO6aKhrgrEYwyEsNFutXpDwnyRxo/to=; b=cCC6wwWlQpTMveu1qLqD9irne79EY5ETXeh1rAvAAmH+LbiFyUjRk1ScIyrfmwefTv mFH+Dn3v/+xPUHoIWVWnpdkrm8IZAwwrC0nGV6nJHAUPKTjea9YuyLEZQwc1IJAswX6+ tCXEHvtE1nHhDMPzh2+JAiQX+k+oxlOF0rSb1BHirgI+fTnJa1Wag/CmnsEhB2k4FQei IuVXnlndn2vb2xncG+l0JMF/aakBraFwN6jUo0NHQUI1LLX0qof6/3e3YtpgKX0gUI4o sBKrEHsK4I3F+qIti6r6RGX+i+V2MWy7R7rwXBmQH2TfDvHmoPTS3FPp8isAlmk2K3fI VMLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/mBj9pAMuVLonO6aKhrgrEYwyEsNFutXpDwnyRxo/to=; b=lX8o1XkVlwk6aBvoBt16BWr7WtA5y6PtAzdDY5MdAWVF299GJ+eyr/L9Il9AJNPSf4 ay5Vv667aOWLx5Q1HBUn0iAZNoq+2AVhr1nsgigOQGTACUWmAh9Pko5rw2cucbpv5fSi 6XFZ1tpvzHvRgi1Q+eHxqRQrs1wY9V8rjRlOMoDrRtIAzfKko/77uZTW+++MCNCQIxp1 54m7sWrC/xckB9xrZfgtAvesARiUiha3mU1ZaenN87FefZS98ne6PdDuDe6KTKP1/gC1 hbWl3V9dhvIW/QJEm3wz9dw1lmNyv6EI5YOuUCL+TBvyRwglwfJaDNNZfKQY5ZUXxgsx qFCA== X-Gm-Message-State: AOAM532zMW9hl/trLdBY0Izfxhk6FVZZFNJldDG3s0uGpB4x1KSwphkG Ovxh9lhPM4fX9canszITVmxwabuucxgwew== X-Received: by 2002:a1c:2d0c:: with SMTP id t12mr9259723wmt.43.1594994076272; Fri, 17 Jul 2020 06:54:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:35 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Sureshkumar Relli , Michal Simek Subject: [PATCH v2 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters Date: Fri, 17 Jul 2020 14:54:19 +0100 Message-Id: <20200717135424.2442271-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi' drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op' drivers/spi/spi-zynq-qspi.c:334: warning: Excess function parameter 'qspi' description in 'zynq_qspi_config_op' Cc: Sureshkumar Relli Signed-off-by: Lee Jones Reviewed-by: Michal Simek --- drivers/spi/spi-zynq-qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index bbf3d90561f54..5d8a5ee62fa23 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -119,6 +119,7 @@ /** * struct zynq_qspi - Defines qspi driver instance + * @dev: Pointer to the this device's information * @regs: Virtual address of the QSPI controller registers * @refclk: Pointer to the peripheral clock * @pclk: Pointer to the APB clock @@ -316,7 +317,7 @@ static void zynq_qspi_chipselect(struct spi_device *spi, bool assert) /** * zynq_qspi_config_op - Configure QSPI controller for specified transfer * @xqspi: Pointer to the zynq_qspi structure - * @qspi: Pointer to the spi_device structure + * @spi: Pointer to the spi_device structure * * Sets the operational mode of QSPI controller for the next QSPI transfer and * sets the requested clock frequency. From patchwork Fri Jul 17 13:54:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235701 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724661ilg; Fri, 17 Jul 2020 06:55:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziLzQGuvVOPlNs8WGNAZMXNwPe0pPOUadr8zRE79174ve5AU0mOV8DLCvMFVSVA2tRHBJQ X-Received: by 2002:a17:906:456:: with SMTP id e22mr8541088eja.178.1594994104702; Fri, 17 Jul 2020 06:55:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994104; cv=none; d=google.com; s=arc-20160816; b=PyW1KfarhhAzIrhNjNnWpqw3HsNYoAToqsu3BMUxLCdp0OtqOm+w2d2ndAN/JmjUKM 2KQW1STmKEs7IMLydkkbGfdgVQFu+GARLuW6rvyM7Y75b6jGq7dmfb57PDVfFrfLiALo bcnABpmcgiWh0ESpOe+P+4O0UazAvrvKWwdbRafeICDR1aLyo/ZBk5aIuLe4h887SHN1 44mb3xYk63ve7kA4nF7ojJ/t+k/GlSoLx7OoUc2EYjc2UeTAKGD2sY+JcVwhLO53+nGZ w1lGo4G1EKIwaJdNDbieTg18qlV4JDigVNmwXzeUftQm2gCPiaN6vZPg5/U7E4/3juFP Q51Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ptPnW5Wq5Xlmw660UEVJ/FMLrebEARvPD+hr3BMDl5Y=; b=NZt4QjDWjIXslDYhC8a9gIEB1gyn1tAufn8atJ6pU16OKJkhpy4e4IZ6y5XFm4Lp2+ oVsdavFiVXgBtZ/dco2LB6U8QGljwtkXYwdK+PPxoCZfCKpaXbrSdTq+f8vlxkaYOz3D ue5umJmAe3DxJP5MSOZeoVbaxLoCVMbCh4rEoIiuvuIZAcAmo2nQoubK8XyuN1vXalq0 WOKZrf/6m5YhiNfEW+7f5npVoctc8DNgjRvMMIbnN+WDjRjQKkz/9u4j/rxqINSu6vqX VOtWLKc2duEuKFMhbZqe5n4/AhRqRdCF2VTCTnzo8yWke498qD2WZakBq13fIS4ukSgE 2u1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vGeuCgIu; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq5si5227174ejb.110.2020.07.17.06.55.04; Fri, 17 Jul 2020 06:55:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vGeuCgIu; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbgGQNzC (ORCPT + 2 others); Fri, 17 Jul 2020 09:55:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727045AbgGQNyi (ORCPT ); Fri, 17 Jul 2020 09:54:38 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88326C0619D5 for ; Fri, 17 Jul 2020 06:54:38 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id q15so14960135wmj.2 for ; Fri, 17 Jul 2020 06:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ptPnW5Wq5Xlmw660UEVJ/FMLrebEARvPD+hr3BMDl5Y=; b=vGeuCgIuXoltl82e88QMAD4qKZTTplcAZ8PaNDib7nkd+uoYiTXZeVJpFP9WyGWZ6I PfM3Ca8M089A3y7Gbs8ILX0PuKbmPBeDvzF6ZG9V3ukEAc/yw0+f71JUSMyM5Ffokyx7 IdXYIamPS9sSWW3ciq7IBJGGjzRIMC8rDnqUysc+Ej2OPnL/1OMIB5dxfe/+A6fARcQK auUqYqUQhiAleVyWBH7QyFrx3GSYVVrxi6lr2CkcDRTPu0ZBZ+RQRF8oG/t+LG7RvNwm iVL5K/MEY+S9e2wv2tSgOE+UWEyObkfBCvxhkCv/36sDGFg6YatUyXNMRuzC8OaDQxDT 93+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ptPnW5Wq5Xlmw660UEVJ/FMLrebEARvPD+hr3BMDl5Y=; b=cOI9NGBvewnEFNsHPed1kf2Fr6YndxaJKwIBVDrvjESO5UILMN4LZi+N6mAYkSEYCm ImOMRcLr7gvGL+LzHFTmPaxUorJGUo9bNKXZ20qMrwK61E/mhVQHYo0I7MmCHvwo0KvK oUqBLMkUbLd9Wn5m6MOyHTluRMneJq95vOyzUgJ3528sCIYug44zC/d3D7vlb44lGKtm ZzLnvXREezzPSVyHRKHbrojn8+paygBbS69t3qGbJHR912pHA51p+nLcCQSkmNVH9lgd yoNp7mJGWL2cjMX51Oz4reMqdM9Z+DjiLYV/B2CWfpPCjKZOAwmmS3Lg1jdbrTfxBl87 nEyQ== X-Gm-Message-State: AOAM533YBNHAoeF1pwN6BqoC5uEEHr/ulNQ7P0E+k7khK61EL599WiHh 9otbriFaZlP0AeQ+FiBQcJcIiQ== X-Received: by 2002:a05:600c:2949:: with SMTP id n9mr8765745wmd.69.1594994077227; Fri, 17 Jul 2020 06:54:37 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:36 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Michal Simek Subject: [PATCH v2 10/14] spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc Date: Fri, 17 Jul 2020 14:54:20 +0100 Message-Id: <20200717135424.2442271-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavecs' not described in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavebus' not described in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashcs' description in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashbus' description in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:902: warning: Function parameter or member 'dev' not described in 'zynqmp_qspi_suspend' drivers/spi/spi-zynqmp-gqspi.c:902: warning: Excess function parameter '_dev' description in 'zynqmp_qspi_suspend' Signed-off-by: Lee Jones Reviewed-by: Michal Simek --- drivers/spi/spi-zynqmp-gqspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index 811c97a7c8589..e17a201252557 100644 --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -197,8 +197,8 @@ static inline void zynqmp_gqspi_write(struct zynqmp_qspi *xqspi, u32 offset, /** * zynqmp_gqspi_selectslave: For selection of slave device * @instanceptr: Pointer to the zynqmp_qspi structure - * @flashcs: For chip select - * @flashbus: To check which bus is selected- upper or lower + * @slavecs: For chip select + * @slavebus: To check which bus is selected- upper or lower */ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr, u8 slavecs, u8 slavebus) @@ -892,7 +892,7 @@ static int zynqmp_qspi_start_transfer(struct spi_master *master, /** * zynqmp_qspi_suspend: Suspend method for the QSPI driver - * @_dev: Address of the platform_device structure + * @dev: Address of the platform_device structure * * This function stops the QSPI driver queue and disables the QSPI controller * From patchwork Fri Jul 17 13:54:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235700 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724622ilg; Fri, 17 Jul 2020 06:55:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3DZCm6vQPtvXmTXDFJ9cFHCwdiiNXZWsJfPuc16IW5f36epya+iygqcL8c/6lV8fvJC4+ X-Received: by 2002:aa7:c657:: with SMTP id z23mr9442691edr.265.1594994100624; Fri, 17 Jul 2020 06:55:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994100; cv=none; d=google.com; s=arc-20160816; b=lqbZ07CNkb4CCPyZvnEJ7Dd//gCa6pP1qc9yv4pnxWRzO/cKgJxRGkQtDZbO4LU6+b CgDTLNku5C77PXrpfMvIO2NivKTdVaRH5qHN38bfhadGIRwa9Ww74Q5c+9JwhjDAeU08 V6ktuJSqEzCm/f1R3hxdhsjX4hW22XazdlPj7r5x4aHZsaztXYr4UIllepKtxxbVV6l2 Ro2oDBzL4dC80PxtelGQ9fOQLQpmwf6OJ+F0qvqItI6vizQlkzFsbrWyYdmLTAkdGVFp bJnRazipdXKIIEhtWzzYePDqIE41UHVyY37HVMXHfHV7iQ8S8Ii2MREcgxoher+Y4MZt SJNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=H0hqYMND+uGAp1rMEcNu0m6mV960EisaT807v2jtpHtHuyp9TfayjtHOFljqWWNUpt A4lUJ+nwxwYbeSruL0VGUmyRgmYELP/l6sq4U1uyzZWT8qZBuWqS13E6kBLXRGL4DXqD LmjLpPHcSvEBno0vMy98FxgukYTXnASFKAYgE36caOzTs6uwZoBJDVIt+K0S9evU4hxZ 212Ehg1EZ3ZH5Tpmpzt9qkTkKE97sFUc+yixE3a2Ov5sHPwJR+ZNLrKOsjU9FBTn9TV8 fyfHFRW4QcwgMcT5XXc61MZOHPVjnlAvt40e7mcm1ywV8m8WedFURxHXRWMSZvhFSs9F kOTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CLcRog2e; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r11si5336427edw.359.2020.07.17.06.55.00; Fri, 17 Jul 2020 06:55:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CLcRog2e; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727091AbgGQNy6 (ORCPT + 2 others); Fri, 17 Jul 2020 09:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727050AbgGQNyj (ORCPT ); Fri, 17 Jul 2020 09:54:39 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D220C0619D6 for ; Fri, 17 Jul 2020 06:54:39 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 22so14951184wmg.1 for ; Fri, 17 Jul 2020 06:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=CLcRog2efhriOmziPd49uvqHp4X3kgn1MMhEVojt9mJGnBLfyFuKfUqJx5yUzpj2Zj 5Ym61ZRmqQ3DPrfbITu3j1YnCKySperMNZP3cU9/bdO1TgPDWdDmjQ7d0qmWsdesIvOB bpIYUeLDljadMWctNzF83RAoClWIdr6ZSV9f6nz8BgpWTi2y0Wbqedj2QUGb4eXYyhXl YxdqabjHzf9qfpd/LXuXtREuBS0/PiNBbOp/snlxaqVb4l4MNvOyJybjndDRwjdnl8LP v+6owkZu7AR/Jbyz9Uap9KGe77zwO5b6d8Qz+tNE0W5rLJK5uCHXMlkkdJN/ItaZQ7br qxOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=jCIycAN0kT6unT4FaKg7cP0EIUvzCY7GUeVGj3Zp6SdA5gca1mh9Xix+kVY5HLhdgv 5Tc0mw1do7Uit46lbmUYBMzr2gqKHy1f4H+T8eNRrisr/1ecnqfRkmfvPVEh5K1fvIWZ RKWj35akMtBTCkYnzl+I2PaeSF18zZkUosoA9f+Uahftww+vaE/SRBg+CWaseJSMHC75 +M9EZ653R0eweQN9121Wpj7ChEPw52ijr2XwcC5eWwXMzhVwNV8967dkx3ys9/R2Y+rD lYnXRYVO5mNV13mxtfMbceHJtfdI8cAaBN24Bum/sInityeLGosqpvAMKaaH6KFdfvuz UjzQ== X-Gm-Message-State: AOAM530zd4M7CsvEnZ3I7X+yhkUS6szP906cZ48wqW8XHs61+A3MyIQz /GOj2RcOOKwm0ZronMGcTlf/DA== X-Received: by 2002:a1c:7e90:: with SMTP id z138mr9010367wmc.7.1594994078207; Fri, 17 Jul 2020 06:54:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:37 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones Subject: [PATCH v2 11/14] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data' Date: Fri, 17 Jul 2020 14:54:21 +0100 Message-Id: <20200717135424.2442271-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'io_base_addr' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_tx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_rx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'use_dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'save_total_len' not described in 'pch_spi_data' Signed-off-by: Lee Jones --- drivers/spi/spi-topcliff-pch.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index d7ea6af74743e..baadd380cb297 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -122,6 +122,7 @@ struct pch_spi_dma_ctrl { /** * struct pch_spi_data - Holds the SPI channel specific details * @io_remap_addr: The remapped PCI base address + * @io_base_addr: Base address * @master: Pointer to the SPI master structure * @work: Reference to work queue handler * @wait: Wait queue for waking up upon receiving an @@ -138,8 +139,8 @@ struct pch_spi_dma_ctrl { * transfer * @rx_index: Receive data count; for bookkeeping during * transfer - * @tx_buff: Buffer for data to be transmitted - * @rx_index: Buffer for Received data + * @pkt_tx_buff: Buffer for data to be transmitted + * @pkt_rx_buff: Buffer for received data * @n_curnt_chip: The chip number that this SPI driver currently * operates on * @current_chip: Reference to the current chip that this SPI @@ -151,7 +152,10 @@ struct pch_spi_dma_ctrl { * @board_dat: Reference to the SPI device data structure * @plat_dev: platform_device structure * @ch: SPI channel number + * @dma: Local DMA information + * @use_dma: True if DMA is to be used * @irq_reg_sts: Status of IRQ registration + * @save_total_len: Save length while data is being transferred */ struct pch_spi_data { void __iomem *io_remap_addr; From patchwork Fri Jul 17 13:54:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235699 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724620ilg; Fri, 17 Jul 2020 06:55:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZvObdfad1P5Ze+Bw6CBmQ/N+ymfYeLqNwOdy1fICFBJqoVTJmEdPAx4C+FqhsDRtFVjjV X-Received: by 2002:a17:907:11db:: with SMTP id va27mr9111803ejb.175.1594994100208; Fri, 17 Jul 2020 06:55:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994100; cv=none; d=google.com; s=arc-20160816; b=BVlVVNJrYPd4y7mSyDPrMUqyY0SGGs6FAYbLsQSjXfMDQ8M/iibr6q0Y8nuOeTD2DI CJ01uVfwzpOXrHFKWYXoYelVSByODQyzACRhPdvrtcz5Xx96WIxpjYCYZp1q8MrkO1yf J2gF5/R6+G5URkzsySs9wbgVX6/Puoj588VU6PiKU4Kw4nJZKEiK18UyE+MXHbQjtpYg YC+kmk1Us/bggq/65ocXxeRenjZeRNwfMyptpz44NxZK0cAEk0Pv2QJ6TBama4sRTWMy /6g1pwXJHX+ACwEGe2usGHa/+5dzkOh5hwy+vL27PtjuslaBl6Sf7tbFIABiVweMtj+n X9yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CPH+QD7EGY89rpfM+jPOD+8I8Jq38VLlFewJk4yzuOM=; b=r7TtV7+plIapOEkzu1SLvhDPbJI0qUwK/E61j3ZLWOKJmDTooVDScCXmiORKr9eIqZ fvY13EvFInkH7zu8Qzg5tFHlcg2W8DPnPcQXxBYUGeUkXuc8JkgJ2ff4AE20+bN2voNz e8ol2If/F2UQnZfsM6NuKz8HIP5rBFPxlmhF40Wx1Ata3aHURnX8snCWBALo6bv7GRdK olO7eS9xdJGGVJbLoPDabI7kwQP49Szolj2YapA2OnoIzU99Q1f5BvgG4hyDf9+lWLew 2UGWvrmgUXb4Gi+AWtJYYmMAS6Zl0TEaNJ/ZxNmhoS9lIQpnmjXcJY3ua5xp5J2MwpEb zZVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VjzgIcU3; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r11si5336427edw.359.2020.07.17.06.55.00; Fri, 17 Jul 2020 06:55:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VjzgIcU3; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgGQNy6 (ORCPT + 2 others); Fri, 17 Jul 2020 09:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbgGQNyk (ORCPT ); Fri, 17 Jul 2020 09:54:40 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A122FC0619D2 for ; Fri, 17 Jul 2020 06:54:40 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 17so17180587wmo.1 for ; Fri, 17 Jul 2020 06:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CPH+QD7EGY89rpfM+jPOD+8I8Jq38VLlFewJk4yzuOM=; b=VjzgIcU3+ooip1M3AXK8TOgT0tdwcKF6NfoM8oDGAwDytuhYS3FzrGb+gD0Sjj04RP 6tyujb+FQaCiDYHM2ixzWByHiOOkfBd0lBsy9VaxV+PtktCvhVOceqQZ+cKcGruuUrA0 O7Gv5SFLmuApMRfZ4hdAu4HGPK1lB5nEBEfUyYFoDANRIzWirPpShVehPf4xCLYivPps iB2xoC8Y6/AfyoniZHOquXz01a98gHtBPW5io+sA1mafGTG8zdNDuQHU+/7aGle0kbSz m/3XeCqXw41/d+ARjP+Ax1G3nDZ5ChIQ52kQUK5FqdILlK3EDB/vZfoYqY0F57+cPyl0 1E9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CPH+QD7EGY89rpfM+jPOD+8I8Jq38VLlFewJk4yzuOM=; b=SMCZrRTu7axVwEQU0/qBOpO55ubkevYFq75YZbiQ+eQUyP5pmNODjePHtNzGQn51be JE4mjJicf1sTvbSw0IwWltzf4YaZ/fO7rYY4QfeutkmyoiryObxzt30Di1c+WY+ql6M+ wgH0xGJxNc11F9ul/e6S63LJjJVPRSCtk7Ph5TH3BXbooWV14XaFOrAjWmaLktzupe5n pXotBbiNsZjxUQIk52tJUjIORIkUeBEMPUhNIZoT00cWMrbuc5B5N28qKPqV66PZfGpQ YZI9GWB/YWvU/NZrYJL0t5beEustT2DTr92+2oFPSnemhOIjEYeaXocvprY60MG8QjjQ IERA== X-Gm-Message-State: AOAM53020M617DZVG8q9xgLvAYfbFSeohidlt/z4mXB0Cahs8AWjmF5a kqXb6xnH7sAlnxAijmsFqNmqLA== X-Received: by 2002:a1c:48d7:: with SMTP id v206mr9115687wma.145.1594994079322; Fri, 17 Jul 2020 06:54:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:38 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Radu Pirea , Nicolas Ferre , Ludovic Desroches , Alexandre Belloni Subject: [PATCH v2 12/14] spi: spi-at91-usart: Remove unused OF table 'struct of_device_id' Date: Fri, 17 Jul 2020 14:54:22 +0100 Message-Id: <20200717135424.2442271-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org The only way this driver can be probed by MFD via its parent device. No other reference to 'microchip,at91sam9g45-usart-spi' exists in the kernel. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Radu Pirea Cc: Nicolas Ferre Cc: Ludovic Desroches Suggested-by: Alexandre Belloni Signed-off-by: Lee Jones --- drivers/spi/spi-at91-usart.c | 7 ------- 1 file changed, 7 deletions(-) -- 2.25.1 Acked-by: Alexandre Belloni diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c index 88033422a42ae..8c8352625d232 100644 --- a/drivers/spi/spi-at91-usart.c +++ b/drivers/spi/spi-at91-usart.c @@ -681,13 +681,6 @@ static const struct dev_pm_ops at91_usart_spi_pm_ops = { at91_usart_spi_runtime_resume, NULL) }; -static const struct of_device_id at91_usart_spi_dt_ids[] = { - { .compatible = "microchip,at91sam9g45-usart-spi"}, - { /* sentinel */} -}; - -MODULE_DEVICE_TABLE(of, at91_usart_spi_dt_ids); - static struct platform_driver at91_usart_spi_driver = { .driver = { .name = "at91_usart_spi", From patchwork Fri Jul 17 13:54:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235698 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724555ilg; Fri, 17 Jul 2020 06:54:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEL7O09fEJnJ8W+StIGprSgj/91IZpuIEA8JYIFuiG3GOSngH8zdp1YCjSKKCK+owjVhFc X-Received: by 2002:a50:cf09:: with SMTP id c9mr9641790edk.90.1594994094319; Fri, 17 Jul 2020 06:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994094; cv=none; d=google.com; s=arc-20160816; b=hEU7buvuYYM7aSG3bzIfXqZEzAm7RNfAA2a3U+Mlsy+PP3Ghw7p5vpKdCj9pPn8tzZ d1eyVOnkm8JoZXGYrCuBbfwoZ4umLdNoVpjbG3TwdEkUdDNcXQa7gHphgEaJ3c1uP3AX 8Num2mb//rBDdqRqOw9cpHbJb9jlBJZzaCKl2HmQx8U03tQfQgVbclH4dVnTH2UefmmC LPUvVUKIv6b6889ViKOw4jawrzx3eMmqKFDOdgQQTqY7G1qoD18cvZAnjW1Qq/uekC1m OUOSGz8/CaPkUcO6b4hxOx32q8uYSElhSUOjoaautpRUW2kYNy/zssE2fEnN2TC0G58J 1+XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=wFd/vgln9b6qSpWIYxWOhJHoUmyeZQpP4jc3caSbG9FLLHUeyg8AUibYzMND48YDpB eLw19fAoR3ThWM5m8/0QU9gyXkSgLPKu4Rw1aNIE02xTisB0WyPtQev1sX6x5FvlOXl+ Th7cP5WQkUV1nAtdnWbzpmoCTWUI9+HgdakER81aKc510oxl6sM4QMS/TaCZAZLx0ZoD +GhC/63R7sGCgzm0OI4iGg1leNFeZb1jLscwXt92T1/Tx3Fri7fx3a1zoTWP1LqqkfN2 dM5igYurKuBXe4klE1d+WaKixjZJ/EG8x7g6qwdZD6pLjkGhmyE2z30sEmf2D2Vo4AyS Lt1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BJWYGXYq; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r11si5336427edw.359.2020.07.17.06.54.54; Fri, 17 Jul 2020 06:54:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BJWYGXYq; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbgGQNyw (ORCPT + 2 others); Fri, 17 Jul 2020 09:54:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727090AbgGQNyl (ORCPT ); Fri, 17 Jul 2020 09:54:41 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19D18C0619D4 for ; Fri, 17 Jul 2020 06:54:42 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f2so11205565wrp.7 for ; Fri, 17 Jul 2020 06:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=BJWYGXYq1pgsO4ivqCiR82eR35O7gSNMT6QzlxPG0J5WFo7f9l9ct2/Tj5hbius4wJ Z3Nj9oYaqBKMg1Xoi6M4UZkmmfrLIkOblh0TJcSGnmWoWrAo6+546QwFRUIZFYt0uk9F P4n6sI1WeB+yEJLGruWOY5oFh5vAAwBE0sSKpokIUpMVYM0U5mlq0hoKOTFrP6pj1ogt qBVxuMuEOaLVOwxwyszj1rDIl05cV1teNU20ANvSq5UID796wEmfuWiVh9kq+r3ORgD1 CKk+4gQ6lc1SCsduPRjx9fMiZ8f6nvrTSL7uHPXLrhtjK2mTSQcMBXQMTJfGqOP5i/M3 qjLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=B2F0kofOwNPuPZegVOA3XfoBVvdKA4GSGI5UgkbniZgJ6juHDIG/iVDENFSFvQuP38 cweAqnv8mJf/MTgkmtH/Cg9tqAZSRGUXh/+zmP843gvFq6/5uE2cAAgLzrLJdmolS6wX uX2Z+9p9nwZUFUanx1Nd11AJ4bx4GQCeaP4rCTwCvinIb72e22lLSzqtS3qfmNglOkAZ BO4wGfNkfqz8sUDmblnL1EWEU5cK8tBBS2Xg11i2yY5/truZ3eDePiDAgt/tJlWUI7lD aV0UeQM7B7GYGulvsVtdvPQVQnxiVhNJceDrrChY3cXbcnByMdQ6JzyK/UkpznzPGixC ItbQ== X-Gm-Message-State: AOAM530mlgwOOEnpCT2KCImwIiCkqFEivgBgWVgELJYjGUMtvZ9ktRcP q7zVe5NFkxuQ5Re/eUmjgn7I5Q== X-Received: by 2002:adf:f104:: with SMTP id r4mr10951860wro.90.1594994080427; Fri, 17 Jul 2020 06:54:40 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:39 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Daniel Mack , Haojian Zhuang , Robert Jarzmik Subject: [PATCH v2 13/14] spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Fri, 17 Jul 2020 14:54:23 +0100 Message-Id: <20200717135424.2442271-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'pxa2xx_spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pxa2xx.c:1435:36: warning: ‘pxa2xx_spi_acpi_match’ defined but not used [-Wunused-const-variable=] 1435 | static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Lee Jones --- drivers/spi/spi-pxa2xx.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 0040362b71622..814268405ab0b 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1432,6 +1432,7 @@ static void cleanup(struct spi_device *spi) kfree(chip); } +#ifdef CONFIG_ACPI static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { "INT33C0", LPSS_LPT_SSP }, { "INT33C1", LPSS_LPT_SSP }, @@ -1442,6 +1443,7 @@ static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { }, }; MODULE_DEVICE_TABLE(acpi, pxa2xx_spi_acpi_match); +#endif /* * PCI IDs of compound devices that integrate both host controller and private From patchwork Fri Jul 17 13:54:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235697 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1724475ilg; Fri, 17 Jul 2020 06:54:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx86+iGdyCl3wQdkx4XQwEhCO8cGq+FjIINTDB0QE213qCHk/k58GUSepNTfBBV5IrRgro1 X-Received: by 2002:a17:906:1f53:: with SMTP id d19mr8492862ejk.327.1594994086800; Fri, 17 Jul 2020 06:54:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994086; cv=none; d=google.com; s=arc-20160816; b=Oj7vx7RnJrZ+Wr61p+BH1hVvKrmZCbsaMSc2VedU9e2P3qWxpbwaUPNk8pukjnGfUq BOu8ASasqUlzmgEKLqI1KCjMWazGVF390I4QCqt4Tm3BETqerKPsQtCvgPe958im+ckg hXm547mxsda1Fks/frIzY1SgWUGQIClvkqFse0gH1B3Vj2H9WbwAMnyh0Bqc31MYWu8U ZwCv2AuaVUb3I4MroAL3OUnYuP6RofTsIV+su0LkEMN4QMxclhGTuYjIfIvmVUkpRN41 RAHUDtyTmbgppPqRQWo2oAno3U1L6/LpqVbcfqGoxLIFr4dN6y/t3Wi93Z25o3OK1dhf tjCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=St/xAyCtrmRBWfYYcSn7juPr5Poh/NZ3n2rNrUrY394=; b=Y4TdVzyv/QFVSKRwQEy3nlEY0WlyM8ROr00VAHajPxsP8VggSMLEPZYMIfmo8cFXee 7xGwoEkKOR/XN2e9jMiTzi1SXK22uquIgkr4dGEznXhq9hSf8cy0TTitnf/VXVJJjC9r vGpL1T+qQxUurMhw7Rs2FF7NZGB84oWpluIJskg+1fx+hOaZ5XbMXkcpKkbnHCb9nmLY ao87MStfqWv8KZ3OTWxx8+LCWf9eniOJaYNmRnxjZ4Y9URYvBiDEfmsAWdVd7oQs+1KI D/bN/FTCy/L9wWdXyj05KKWQ3wUeLaygUwlzqFDGW8huVkyWm/nHCTohcZsInSgelifb ob3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bpNzeGQ2; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r11si5336427edw.359.2020.07.17.06.54.46; Fri, 17 Jul 2020 06:54:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bpNzeGQ2; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbgGQNyo (ORCPT + 2 others); Fri, 17 Jul 2020 09:54:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbgGQNyn (ORCPT ); Fri, 17 Jul 2020 09:54:43 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4FD0C0619D7 for ; Fri, 17 Jul 2020 06:54:42 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id c80so14957971wme.0 for ; Fri, 17 Jul 2020 06:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=St/xAyCtrmRBWfYYcSn7juPr5Poh/NZ3n2rNrUrY394=; b=bpNzeGQ2MR4hr80NvQhU98nD3GgSa4EDbYmGyWnchS5R3CJAZ9DaK36qm+qmXP2F+E V8YBOYQySCSk1JLCHed2FvU7RP1NEE94M+Kde0STUOJGfkONWj4s0Uc+QjarvN2q4NtN AsmqgLlDKAu8qLK16LPIIt5kXHR1qcZnoUFm4pHV/kl5ScEHKkKwzKmyOBCfwPguiP/z GSwuDGCDy1Ku3Ybl9ASlfk+YTrI0hfqVKnazspGNqYP19fvdKf5StJnn1HUViiHCURQ2 0VEZEE2oky80AyF2bpL0dAxjuoS1yacbs+7svgQv8gFOU0JezgrR8a7YMHfLdNtQBFns rT6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=St/xAyCtrmRBWfYYcSn7juPr5Poh/NZ3n2rNrUrY394=; b=ZeaNTvmCp7Vlu2DAeeHVwt8iuTY2y0JoHcO9ho+HECWO9heRVl2Kx7OozYHzjB0v/h FWTZlJ/uaMlVVxOvd50k1KiP23eBrMMULTQBYir6AWXCYiP3yj8pQiy+/1k6UkSivd80 xdrRgpcNqhbytqBWMMrz1rhMetWYhkF5j2fAY99ERGFUBeMym2L9eIm0RHDbcPfFnsni QmqxhvY7hlhYn+bmSlI/UKeozlZnZ1VaoTAbANEhWmuyIM9wf+FEc8ZvtObHDeqR/2k4 UyikHxod8vdlhgRLcbGwgHXh2d+nB2qxx5JJA5ApnFGArmeomPGGHiQ36e4lfPYo4hIv BuaQ== X-Gm-Message-State: AOAM530QTJW3hhau00lNy/IE6Kvp21yBVwkK3B6a8j29a7UseklIVSnR zr+5jTukq11HVZI0WqvXYQ8YxA== X-Received: by 2002:a1c:31c6:: with SMTP id x189mr8995770wmx.182.1594994081433; Fri, 17 Jul 2020 06:54:41 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:40 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Sanjay R Mehta Subject: [PATCH v2 14/14] spi: spi-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Fri, 17 Jul 2020 14:54:24 +0100 Message-Id: <20200717135424.2442271-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-amd.c:297:36: warning: ‘spi_acpi_match’ defined but not used [-Wunused-const-variable=] 297 | static const struct acpi_device_id spi_acpi_match[] = { | ^~~~~~~~~~~~~~ Cc: Sanjay R Mehta Signed-off-by: Lee Jones --- drivers/spi/spi-amd.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 diff --git a/drivers/spi/spi-amd.c b/drivers/spi/spi-amd.c index d0aacd4de1b9e..7f629544060db 100644 --- a/drivers/spi/spi-amd.c +++ b/drivers/spi/spi-amd.c @@ -294,11 +294,13 @@ static int amd_spi_probe(struct platform_device *pdev) return err; } +#ifdef CONFIG_ACPI static const struct acpi_device_id spi_acpi_match[] = { { "AMDI0061", 0 }, {}, }; MODULE_DEVICE_TABLE(acpi, spi_acpi_match); +#endif static struct platform_driver amd_spi_driver = { .driver = {