From patchwork Thu Jul 16 06:16:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 235627 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp514031ilg; Wed, 15 Jul 2020 23:16:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8jUZjjgX4N7Q/W2qbDvDnGA2ItdTBKTa+fJfE9KqFbBPoG/inDrZnorIxkz3RCzjefj+S X-Received: by 2002:a50:d8c2:: with SMTP id y2mr2992810edj.114.1594880178020; Wed, 15 Jul 2020 23:16:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594880178; cv=none; d=google.com; s=arc-20160816; b=QnnzVMCuazgK5wC4QMX9rAjVvodpV2dc7hcrntzpRfone7uatr7YxdCi2zzJXGPqdW BZ3WKnxd8u7VRpPhjquOo9dGybsiLzH5hdLxxumIBFHCs9OZ/0T3zehO8R7hLHz/E5gY 3oREYI0Vhobmta1aGtnWfkgt8P4nbuP4oi8ZqXE5ZCVjBx4blJVJaooWpypeKRq51roo frzoaqbAMkVIszzWli6ZQuP5JdaegQnrKjm0N/5G4Rr53EtG5ohFGZTAZVaj0YYU2R+s hFej07gldJi6Pi92XPI32HqbJmuF/mH7WETI2Iom6zhP79b0rknrglWdBD5Ev+tH2efm joEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:from:to:subject :content-transfer-encoding:mime-version:date:message-id :dkim-signature; bh=kF7R5DUC1URNMPbAYPkDub6YZWoBbHJrUi/9LeiLYeY=; b=KgrsCN0MkPD07rpfNWu+89C6VxWvRilXqrhy7yQrDe4RSpybS4ML/INTPGBXXZnAgF ZH76hfrQz1+lCToxOrRN5jUjXYCAJ7bJatZ3mFtpt72HqXIBKHw7KpQvK0WKirfxNZeb 9kRhgP+gwixetqlEKWZvyQEXhc2EYJ+jr0i7uj/Rgn10FF/c0XbXEEpXLdYk4G1HhoX9 NN5ky5bj+fMVMmOsn1wwQF9PkJtg3N+1pIzUBXzEqZwtUm7hmC8l7k/jnqySMgp2/FWV BVv0937PxZpexGbR1qc5oDrwJM9uZ7mFbBxINA5JIvkgaFy/IeAZmYFTe+PK5dfynWDC th6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=1ShX9mEw; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mj23si2464234ejb.746.2020.07.15.23.16.17; Wed, 15 Jul 2020 23:16:18 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=1ShX9mEw; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728098AbgGPGQO (ORCPT + 6 others); Thu, 16 Jul 2020 02:16:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727943AbgGPGQO (ORCPT ); Thu, 16 Jul 2020 02:16:14 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE23FC08C5C0 for ; Wed, 15 Jul 2020 23:16:13 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id m9so3202735pfh.0 for ; Wed, 15 Jul 2020 23:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=kF7R5DUC1URNMPbAYPkDub6YZWoBbHJrUi/9LeiLYeY=; b=1ShX9mEwNKC3QnGClMktjWkQoAorJK8LcHm8k2oZ2FIpYaNHeq6+U29CZFWoYFbIVj RlR4zvbcjbX9H5mbar9DzS7zFWdIryezMkFQTeCHfkDVyNIbO3dhgtbyG3GJLAj8UJ4T 9K49gei1FHE/6r7+0oFVPeaE6zVFf/bck8Odk4zNqR/gCrI7Glu4ZB8jh2x6JF2MHN4w lbfp1yfxFV4dLVZaEXC3UzXnHei1GahBS8k5Oyc+UVSZk0nB2E0IQGEHijJFbKzR0fJP opPTJVvjOC/SOSS5L7aluueiffide0vpYCB3hoYuATsu4I/+njnMtx/gBmkOOBuoTDFn iM9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=kF7R5DUC1URNMPbAYPkDub6YZWoBbHJrUi/9LeiLYeY=; b=fXTVH0mDv1tACOYftxQZq+3/WOltn+JS6rGAWbv9teqfl/EvVso/spxEPtYRXDUfAl QGTC7lHEyAEbN0DYUAvlCkEPPVr2pTvF8mHXB58UzajIcwfJ4FRYmS5ngtgm4qf0kT8v nd5TZRZ0C/A6vp8UBlV2Au6JOMOw5FcKiZY49w5L4Q3DUHCvJU0GdxOnNb+T6rYCQoqa /Syt1IlULuO4k1oYgZ1bVlf0QWxPDlDshWtnxbqcYPYord3GAqV37f4zsDErDeN7A8OT WPEv4CuyTaSE6UNrdBEIVFvyfESud5LNOeh66ETIU9tKAmiWXAw03fEzAuHWyq95a8sV meeQ== X-Gm-Message-State: AOAM531KkZdeYS1MsgzhBjX6Rt+VSyKwWTd7nXiKbidLYQpJR7pYBVja BBtoHHzBb/S3daIDS6vWpTFNug== X-Received: by 2002:a63:5a01:: with SMTP id o1mr2862474pgb.337.1594880173303; Wed, 15 Jul 2020 23:16:13 -0700 (PDT) Received: from kernelci-production.internal.cloudapp.net ([52.250.1.28]) by smtp.gmail.com with ESMTPSA id e10sm3891656pjw.22.2020.07.15.23.16.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 23:16:12 -0700 (PDT) Message-ID: <5f0ff0ac.1c69fb81.d1a0b.b284@mx.google.com> Date: Wed, 15 Jul 2020 23:16:12 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Kernel: v5.8-rc5-44-g994e99a96c9b X-Kernelci-Report-Type: bisect X-Kernelci-Tree: mainline X-Kernelci-Branch: master X-Kernelci-Lab-Name: lab-cip Subject: mainline/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15 To: Sudeep Holla , gtucker@collabora.com, kernelci-results@groups.io, Andre Przywara From: "kernelci.org bot" Cc: Lorenzo Pieralisi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Liviu Dudau , Rob Herring Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * * * If you do send a fix, please include this trailer: * * Reported-by: "kernelci.org bot" * * * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * mainline/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15 Summary: Start: 994e99a96c9b Merge tag 'platform-drivers-x86-v5.8-2' of git://git.infradead.org/linux-platform-drivers-x86 into master Plain log: https://storage.kernelci.org/mainline/master/v5.8-rc5-44-g994e99a96c9b/arm/vexpress_defconfig/gcc-8/lab-cip/baseline-vexpress-v2p-ca15-tc1.txt HTML log: https://storage.kernelci.org/mainline/master/v5.8-rc5-44-g994e99a96c9b/arm/vexpress_defconfig/gcc-8/lab-cip/baseline-vexpress-v2p-ca15-tc1.html Result: 38ac46002d1d arm: dts: vexpress: Move mcc node back into motherboard node Checks: revert: PASS verify: PASS Parameters: Tree: mainline URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git Branch: master Target: qemu_arm-vexpress-a15 CPU arch: arm Lab: lab-cip Compiler: gcc-8 Config: vexpress_defconfig Test case: baseline.dmesg.crit Breaking commit found: ------------------------------------------------------------------------------- commit 38ac46002d1df5707566a73486452851341028d2 Author: Andre Przywara Date: Wed Jun 3 17:22:37 2020 +0100 arm: dts: vexpress: Move mcc node back into motherboard node Commit d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices out of bus node") moved the "mcc" DT node into the root node, because it does not have any children using "reg" properties, so does violate some dtc checks about "simple-bus" nodes. However this broke the vexpress config-bus code, which walks up the device tree to find the first node with an "arm,vexpress,site" property. This gave the wrong result (matching the root node instead of the motherboard node), so broke the clocks and some other devices for VExpress boards. Move the whole node back into its original position. This re-introduces the dtc warning, but is conceptually the right thing to do. The dtc warning seems to be overzealous here, there are discussions on fixing or relaxing this check instead. Link: https://lore.kernel.org/r/20200603162237.16319-1-andre.przywara@arm.com Fixes: d9258898ad49 ("arm64: dts: vexpress: Move fixed devices out of bus node") Reported-and-tested-by: Guenter Roeck Signed-off-by: Andre Przywara Signed-off-by: Sudeep Holla ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [719fdd32921fb7e3208db8832d32ae1c2d68900f] afs: Fix storage of cell names git bisect good 719fdd32921fb7e3208db8832d32ae1c2d68900f # bad: [994e99a96c9b502b3f6ee411457007cd52051cf5] Merge tag 'platform-drivers-x86-v5.8-2' of git://git.infradead.org/linux-platform-drivers-x86 into master git bisect bad 994e99a96c9b502b3f6ee411457007cd52051cf5 # bad: [dcde237b9b0eb1d19306e6f48c0a4e058907619f] Merge tag 'perf-tools-fixes-2020-07-07' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux git bisect bad dcde237b9b0eb1d19306e6f48c0a4e058907619f # bad: [442ad2254ac56b39870c0cfed96d500921fea5d5] perf record: Fix duplicated sideband events with Intel PT system wide tracing git bisect bad 442ad2254ac56b39870c0cfed96d500921fea5d5 # bad: [f7db192b2d71ea42627a32349d59a5f99f2aafcc] Merge tag 'arm-omap-fixes-5.8-1' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc git bisect bad f7db192b2d71ea42627a32349d59a5f99f2aafcc # good: [ae71d4bf0074a81cc04255c96e3de0a49b1d95fa] Merge tag 'perf-urgent-2020-06-28' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip git bisect good ae71d4bf0074a81cc04255c96e3de0a49b1d95fa # good: [d528945d7762be94beca4c111bb95dcc9a9f39c0] Merge tag 'omap-for-v5.8/fixes-rc1-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into arm/omap-fixes git bisect good d528945d7762be94beca4c111bb95dcc9a9f39c0 # bad: [2596ce4b4ded685b67fed407aed2bfe6ebcc39cb] Merge tag 'arm-soc/for-5.8/drivers-fixes' of https://github.com/Broadcom/stblinux into arm/fixes git bisect bad 2596ce4b4ded685b67fed407aed2bfe6ebcc39cb # bad: [0f77ce26ebcf6ea384421d2dd47b924b83649692] Revert "ARM: sti: Implement dummy L2 cache's write_sec" git bisect bad 0f77ce26ebcf6ea384421d2dd47b924b83649692 # bad: [d68ec1644dd546851d651787a638aead32a60a6f] Merge tag 'juno-fix-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into arm/fixes git bisect bad d68ec1644dd546851d651787a638aead32a60a6f # bad: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node git bisect bad 38ac46002d1df5707566a73486452851341028d2 # first bad commit: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node ------------------------------------------------------------------------------- diff --git a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi index e6308fb76183..a88ee5294d35 100644 --- a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi +++ b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi @@ -100,79 +100,6 @@ }; }; - mcc { - compatible = "arm,vexpress,config-bus"; - arm,vexpress,config-bridge = <&v2m_sysreg>; - - oscclk0 { - /* MCC static memory clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 0>; - freq-range = <25000000 60000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk0"; - }; - - v2m_oscclk1: oscclk1 { - /* CLCD clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 1>; - freq-range = <23750000 65000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk1"; - }; - - v2m_oscclk2: oscclk2 { - /* IO FPGA peripheral clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 2>; - freq-range = <24000000 24000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk2"; - }; - - volt-vio { - /* Logic level voltage */ - compatible = "arm,vexpress-volt"; - arm,vexpress-sysreg,func = <2 0>; - regulator-name = "VIO"; - regulator-always-on; - label = "VIO"; - }; - - temp-mcc { - /* MCC internal operating temperature */ - compatible = "arm,vexpress-temp"; - arm,vexpress-sysreg,func = <4 0>; - label = "MCC"; - }; - - reset { - compatible = "arm,vexpress-reset"; - arm,vexpress-sysreg,func = <5 0>; - }; - - muxfpga { - compatible = "arm,vexpress-muxfpga"; - arm,vexpress-sysreg,func = <7 0>; - }; - - shutdown { - compatible = "arm,vexpress-shutdown"; - arm,vexpress-sysreg,func = <8 0>; - }; - - reboot { - compatible = "arm,vexpress-reboot"; - arm,vexpress-sysreg,func = <9 0>; - }; - - dvimode { - compatible = "arm,vexpress-dvimode"; - arm,vexpress-sysreg,func = <11 0>; - }; - }; - bus@8000000 { motherboard-bus { model = "V2M-P1"; @@ -435,6 +362,79 @@ }; }; }; + + mcc { + compatible = "arm,vexpress,config-bus"; + arm,vexpress,config-bridge = <&v2m_sysreg>; + + oscclk0 { + /* MCC static memory clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 0>; + freq-range = <25000000 60000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk0"; + }; + + v2m_oscclk1: oscclk1 { + /* CLCD clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 1>; + freq-range = <23750000 65000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk1"; + }; + + v2m_oscclk2: oscclk2 { + /* IO FPGA peripheral clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 2>; + freq-range = <24000000 24000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk2"; + }; + + volt-vio { + /* Logic level voltage */ + compatible = "arm,vexpress-volt"; + arm,vexpress-sysreg,func = <2 0>; + regulator-name = "VIO"; + regulator-always-on; + label = "VIO"; + }; + + temp-mcc { + /* MCC internal operating temperature */ + compatible = "arm,vexpress-temp"; + arm,vexpress-sysreg,func = <4 0>; + label = "MCC"; + }; + + reset { + compatible = "arm,vexpress-reset"; + arm,vexpress-sysreg,func = <5 0>; + }; + + muxfpga { + compatible = "arm,vexpress-muxfpga"; + arm,vexpress-sysreg,func = <7 0>; + }; + + shutdown { + compatible = "arm,vexpress-shutdown"; + arm,vexpress-sysreg,func = <8 0>; + }; + + reboot { + compatible = "arm,vexpress-reboot"; + arm,vexpress-sysreg,func = <9 0>; + }; + + dvimode { + compatible = "arm,vexpress-dvimode"; + arm,vexpress-sysreg,func = <11 0>; + }; + }; }; }; };