From patchwork Wed Jul 15 09:35:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 235582 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp454802ilg; Wed, 15 Jul 2020 02:35:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0PLYCHNBvj8SPXx18DXFHzV+6xByprDbYhzdUUpmw891W+KdF3vBnyjXUILQkistLsgsm X-Received: by 2002:a17:906:a081:: with SMTP id q1mr8025496ejy.499.1594805731888; Wed, 15 Jul 2020 02:35:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594805731; cv=none; d=google.com; s=arc-20160816; b=fmXhhBvgoSEkuezXfr0YMlff8F6kUPAAReqkj6ZOEJ9EQMF5n2xiV2OGBjqLwDBgg5 UxKIWDTqomnhFnd2IoBQLK+wm8eHJMUoyfLa+61gfdZA9O0y4e3Y5IC9ryeuZU4ayeuZ 9hRGHujj9mkWK9sE29cS3AOJQqG3oYtnOO8Z2gmhdMlZH0qtv2HjRajnyBJmDcLRuDE5 sJVxZzm2vcq+rZw+vQdmN4eWOB0U5NnreV9rZv/VJpnA2ARdWgD3cw5gQtr5bwGKgc5A z3w+e6G03O2/3wocnDJFYfAuMJkQahyhz1D8hYlvUhcdvblbro9cSzcdcE+tmTSpLhy/ mDlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:from:to:subject :content-transfer-encoding:mime-version:date:message-id :dkim-signature; bh=AVB5MsrwbaPIfDw4I26TDX5GzM7tcYJsoKaN5Tiam2w=; b=Ydwk+vCkT7IEnxTvUQmICLCh4ANZImll+s0sREDJQCj/5rNtt9gAWEuxrmWbAccHzw RgpkgTz76VBE4Wp1ptx1I0GHiEV712WhjshwCmk/diYTx9f0nXLnTl5YvuK5cwWHDhMy zi3duB+oKsBYrP/jGB0+BO6EqAhfAhzo83GZnt9iWFF/W8kACKSaV9G8TnkaV0lRnMsD KI5WuaaEPJjKZT21S+VkDrWpSeP6/xEqB2PaVGaRK38c9jbYHEGQldNml/3Yp5UHjJ+8 9YGAIrardtz3sdZn+UUWLPvXCpMdbTclKNydnQ9HNh5nSRvtkhRJ3l/quiZr3K47D6ZB 8lOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=AcR7xx7O; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca10si925807edb.224.2020.07.15.02.35.31; Wed, 15 Jul 2020 02:35:31 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=AcR7xx7O; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730519AbgGOJfb (ORCPT + 6 others); Wed, 15 Jul 2020 05:35:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729047AbgGOJfa (ORCPT ); Wed, 15 Jul 2020 05:35:30 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45DF9C061755 for ; Wed, 15 Jul 2020 02:35:30 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id a14so1851304pfi.2 for ; Wed, 15 Jul 2020 02:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=AVB5MsrwbaPIfDw4I26TDX5GzM7tcYJsoKaN5Tiam2w=; b=AcR7xx7OWiLQnAZjaYAKsReUTmyX0vA2ivseCBNhJy30sctAip8r1VNILKYch8Z/WI cadcezapw4RyUmZ6DfnFYQEmFS7pvSiUKFTYmF0NHlnKOAOw02kw5eLDZpnJVRQwI5S0 g2sO3hnfV4+PF2Irs7U0lfTiod8hzrSn8o8wKe8e1jh6/ipEHm0XI4+Iqfj4PJnfkd2/ BcSH113B9l07cQdFB0XGB4dRPvWVsowu3A75sKeeJt+5P31FSqpoIeGFf2Y2+BYkZp+1 WT1pHZAmgR1P3wc4sLtaZ9SmUJAme2KzuKYbukg3nrmscN7M4ps9PeLY7T4ARL18/gQC Zubg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=AVB5MsrwbaPIfDw4I26TDX5GzM7tcYJsoKaN5Tiam2w=; b=CEnAD73ktzIR+BFDMAwqpYiWJ6gftmpa6XEyGk5/fyDABuuKAQYEGTL04MFhLq1/j3 4sxv2Uran6DEHI44lWgbDMoQbzP/u6IZwyJ9PkbGff4G5MIraj3fInbR5+ORE2qAar+G k6a0fkbr0ZVntz7KKJfeWjrHiKO5kizLiIROC9RMtCfL1a+fvjQ66bptJPbpe7bfRaEL iMh9DvKG/PYj7+U0mFaCNYyD38/jItYyG+EzX+AXS+0mfbhG//voKpkpgtj/BEmc9rTJ mFSsoAkLL1w/P4A8dH+rdWIf2hcef4q+p42DLEBaWg0jK1vKsV88Y3FlvH7C8mAS1HGU 3XVQ== X-Gm-Message-State: AOAM531nEdn+O7byyUeakSL6Wbj9B51/QNrvm8lzEW29lmH+jlzMrblK lt9Py5fOXrt0l60gvdkOZsGxJA== X-Received: by 2002:aa7:8edc:: with SMTP id b28mr8145624pfr.230.1594805729750; Wed, 15 Jul 2020 02:35:29 -0700 (PDT) Received: from kernelci-production.internal.cloudapp.net ([52.250.1.28]) by smtp.gmail.com with ESMTPSA id c187sm1491979pfc.146.2020.07.15.02.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 02:35:28 -0700 (PDT) Message-ID: <5f0ecde0.1c69fb81.17318.4549@mx.google.com> Date: Wed, 15 Jul 2020 02:35:28 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Kernel: v5.8-rc5-16-ge9919e11e219 X-Kernelci-Report-Type: bisect X-Kernelci-Tree: mainline X-Kernelci-Branch: master X-Kernelci-Lab-Name: lab-collabora Subject: mainline/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15 To: Andre Przywara , Sudeep Holla , kernelci-results@groups.io, gtucker@collabora.com From: "kernelci.org bot" Cc: Liviu Dudau , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Lorenzo Pieralisi Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * * * If you do send a fix, please include this trailer: * * Reported-by: "kernelci.org bot" * * * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * mainline/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15 Summary: Start: e9919e11e219 Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input Plain log: https://storage.kernelci.org/mainline/master/v5.8-rc5-16-ge9919e11e219/arm/vexpress_defconfig/gcc-8/lab-collabora/baseline-vexpress-v2p-ca15-tc1.txt HTML log: https://storage.kernelci.org/mainline/master/v5.8-rc5-16-ge9919e11e219/arm/vexpress_defconfig/gcc-8/lab-collabora/baseline-vexpress-v2p-ca15-tc1.html Result: 38ac46002d1d arm: dts: vexpress: Move mcc node back into motherboard node Checks: revert: PASS verify: PASS Parameters: Tree: mainline URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git Branch: master Target: qemu_arm-vexpress-a15 CPU arch: arm Lab: lab-collabora Compiler: gcc-8 Config: vexpress_defconfig Test case: baseline.dmesg.crit Breaking commit found: ------------------------------------------------------------------------------- commit 38ac46002d1df5707566a73486452851341028d2 Author: Andre Przywara Date: Wed Jun 3 17:22:37 2020 +0100 arm: dts: vexpress: Move mcc node back into motherboard node Commit d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices out of bus node") moved the "mcc" DT node into the root node, because it does not have any children using "reg" properties, so does violate some dtc checks about "simple-bus" nodes. However this broke the vexpress config-bus code, which walks up the device tree to find the first node with an "arm,vexpress,site" property. This gave the wrong result (matching the root node instead of the motherboard node), so broke the clocks and some other devices for VExpress boards. Move the whole node back into its original position. This re-introduces the dtc warning, but is conceptually the right thing to do. The dtc warning seems to be overzealous here, there are discussions on fixing or relaxing this check instead. Link: https://lore.kernel.org/r/20200603162237.16319-1-andre.przywara@arm.com Fixes: d9258898ad49 ("arm64: dts: vexpress: Move fixed devices out of bus node") Reported-and-tested-by: Guenter Roeck Signed-off-by: Andre Przywara Signed-off-by: Sudeep Holla ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [719fdd32921fb7e3208db8832d32ae1c2d68900f] afs: Fix storage of cell names git bisect good 719fdd32921fb7e3208db8832d32ae1c2d68900f # bad: [e9919e11e219eaa5e8041b7b1a196839143e9125] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input git bisect bad e9919e11e219eaa5e8041b7b1a196839143e9125 # bad: [6d12075ddeedc38d25c5b74e929e686158da728c] Merge tag 'mtd/fixes-for-5.8-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux git bisect bad 6d12075ddeedc38d25c5b74e929e686158da728c # bad: [684c8ccc40d7e5408d597a43712bad3827d3fb94] Merge tag 'devicetree-fixes-for-5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux git bisect bad 684c8ccc40d7e5408d597a43712bad3827d3fb94 # bad: [e44b59cd758acdd413512d4597a1fabdadfe3abf] Merge tag 'arm-fixes-5.8-1' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc git bisect bad e44b59cd758acdd413512d4597a1fabdadfe3abf # good: [91a9a90d040e8b9ff63d48ea71468e0f4db764ff] Merge tag 'sched_urgent_for_5.8_rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip git bisect good 91a9a90d040e8b9ff63d48ea71468e0f4db764ff # bad: [42d3f7e8da1bc55e3109f612c519c945f6587194] Merge tag 'imx-fixes-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux into arm/fixes git bisect bad 42d3f7e8da1bc55e3109f612c519c945f6587194 # bad: [6d89c73ca5813768a2cc66f7420ac0cbddf4f37d] Merge tag 'arm-soc/for-5.8/soc-fixes' of https://github.com/Broadcom/stblinux into arm/fixes git bisect bad 6d89c73ca5813768a2cc66f7420ac0cbddf4f37d # bad: [0f77ce26ebcf6ea384421d2dd47b924b83649692] Revert "ARM: sti: Implement dummy L2 cache's write_sec" git bisect bad 0f77ce26ebcf6ea384421d2dd47b924b83649692 # bad: [d68ec1644dd546851d651787a638aead32a60a6f] Merge tag 'juno-fix-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into arm/fixes git bisect bad d68ec1644dd546851d651787a638aead32a60a6f # bad: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node git bisect bad 38ac46002d1df5707566a73486452851341028d2 # first bad commit: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node ------------------------------------------------------------------------------- diff --git a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi index e6308fb76183..a88ee5294d35 100644 --- a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi +++ b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi @@ -100,79 +100,6 @@ }; }; - mcc { - compatible = "arm,vexpress,config-bus"; - arm,vexpress,config-bridge = <&v2m_sysreg>; - - oscclk0 { - /* MCC static memory clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 0>; - freq-range = <25000000 60000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk0"; - }; - - v2m_oscclk1: oscclk1 { - /* CLCD clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 1>; - freq-range = <23750000 65000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk1"; - }; - - v2m_oscclk2: oscclk2 { - /* IO FPGA peripheral clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 2>; - freq-range = <24000000 24000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk2"; - }; - - volt-vio { - /* Logic level voltage */ - compatible = "arm,vexpress-volt"; - arm,vexpress-sysreg,func = <2 0>; - regulator-name = "VIO"; - regulator-always-on; - label = "VIO"; - }; - - temp-mcc { - /* MCC internal operating temperature */ - compatible = "arm,vexpress-temp"; - arm,vexpress-sysreg,func = <4 0>; - label = "MCC"; - }; - - reset { - compatible = "arm,vexpress-reset"; - arm,vexpress-sysreg,func = <5 0>; - }; - - muxfpga { - compatible = "arm,vexpress-muxfpga"; - arm,vexpress-sysreg,func = <7 0>; - }; - - shutdown { - compatible = "arm,vexpress-shutdown"; - arm,vexpress-sysreg,func = <8 0>; - }; - - reboot { - compatible = "arm,vexpress-reboot"; - arm,vexpress-sysreg,func = <9 0>; - }; - - dvimode { - compatible = "arm,vexpress-dvimode"; - arm,vexpress-sysreg,func = <11 0>; - }; - }; - bus@8000000 { motherboard-bus { model = "V2M-P1"; @@ -435,6 +362,79 @@ }; }; }; + + mcc { + compatible = "arm,vexpress,config-bus"; + arm,vexpress,config-bridge = <&v2m_sysreg>; + + oscclk0 { + /* MCC static memory clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 0>; + freq-range = <25000000 60000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk0"; + }; + + v2m_oscclk1: oscclk1 { + /* CLCD clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 1>; + freq-range = <23750000 65000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk1"; + }; + + v2m_oscclk2: oscclk2 { + /* IO FPGA peripheral clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 2>; + freq-range = <24000000 24000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk2"; + }; + + volt-vio { + /* Logic level voltage */ + compatible = "arm,vexpress-volt"; + arm,vexpress-sysreg,func = <2 0>; + regulator-name = "VIO"; + regulator-always-on; + label = "VIO"; + }; + + temp-mcc { + /* MCC internal operating temperature */ + compatible = "arm,vexpress-temp"; + arm,vexpress-sysreg,func = <4 0>; + label = "MCC"; + }; + + reset { + compatible = "arm,vexpress-reset"; + arm,vexpress-sysreg,func = <5 0>; + }; + + muxfpga { + compatible = "arm,vexpress-muxfpga"; + arm,vexpress-sysreg,func = <7 0>; + }; + + shutdown { + compatible = "arm,vexpress-shutdown"; + arm,vexpress-sysreg,func = <8 0>; + }; + + reboot { + compatible = "arm,vexpress-reboot"; + arm,vexpress-sysreg,func = <9 0>; + }; + + dvimode { + compatible = "arm,vexpress-dvimode"; + arm,vexpress-sysreg,func = <11 0>; + }; + }; }; }; };