From patchwork Tue Jul 14 11:15:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235525 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3640832ilg; Tue, 14 Jul 2020 04:20:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPPcBixu2Aitg6GCBBtTgud6h7eb1gFj1+dRkxI7cxgGDkY7YN6uy7ow/aAqe4tyI0wvuA X-Received: by 2002:a50:c355:: with SMTP id q21mr3939841edb.121.1594725621045; Tue, 14 Jul 2020 04:20:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594725621; cv=none; d=google.com; s=arc-20160816; b=v3DIjKMcMFgbO0Z5rL63gNXM0bZZ0YP0yPb+JRgRFkyRVTWPE1HmjgdqeBDu5QMy7D JRHmdd7Fkut+fLzZSegUa2An6kdi0uDsBh775q0TCQ0ppBq5Dol3NBcSgo18mMP6kvzo No6kgBisZLpbe5vDl2AVd/kW1afqYDYnpMYmjYP23AzYsvs/Y0X6V8Wb1LenRcii6D9P 8Xq64qQmGgeD4aXUsmwV96jBpKCQc9yy9IL0EBXMBPelEnFheRzyVgUDSkOYNpz1Lrus vtD8uufZJdWJOY4S10pKTRiPhBehZ3fCqB7jCQQSX4ygQ9efw1O7BBmsRrY91B/qVO4c r4UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=z/zoKcrmx2IW2qZYN8v07zqfWyovJdKlsFhRtVJoj8Y=; b=BiWcgtxNalpH7MynUDboN618dMyTUd3WFl++x4bLPFwsrrYXdRyyk0UP9zKzRJzRQa B4dZu9pBw4qC8lkRDnK+LfZpk8XOO0kejLr1fi0v0k593BzWAqzeszc/pS0lHFANIXtY G47NEjO8ZJMgQoQCCaYxeXkV5CzCgNhtzkl6yYloM+q7gePCU597Z8iGcLhG4+hq6zxg fCOO30nPGbLovH5Cbl3UgGqS4pKJrW8m1zk/ziVGHibtUM2uFpGBr67AXTEcq6EsnnDC BsIOanYPDxM2pfppPelu/igIK7UE8wgUVglZJr1fbwe8FBPyyeEbPZ0pZ+3NUwflobhW r+oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=b1sAb44W; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x14si9610633ejb.713.2020.07.14.04.20.18; Tue, 14 Jul 2020 04:20:21 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=b1sAb44W; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727965AbgGNLUR (ORCPT + 9 others); Tue, 14 Jul 2020 07:20:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727891AbgGNLSm (ORCPT ); Tue, 14 Jul 2020 07:18:42 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9BAAC08E85B for ; Tue, 14 Jul 2020 04:16:05 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id j4so20884081wrp.10 for ; Tue, 14 Jul 2020 04:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z/zoKcrmx2IW2qZYN8v07zqfWyovJdKlsFhRtVJoj8Y=; b=b1sAb44WGmZFCdVAFpOnOB6gjm1ZuIfnH5qfH6jEl7r1V5Ot0bj2a/haai/zLlbGwZ jyft/gXpKRKwhcAmBF6N1E3tVUv3FpyxaQDJbEMA+kzxFOdi5i/iC+SuVdGwUK3S7lkC JCMyVtDbRUfFVhAZkbBSmtUupdpqKKxXkUPJTaoOYPu5dPFvyg6Blg9WrDMzB/cseVM+ rhmyyRlfWyztEMer+eWo6n3Do/AXv5WhKdZaS+4tgq6H2R8pELz1fQ3yZJcDDG53AKI8 o6mlh08h6jJhiGMzg1aEP83hrtSL2JwTrrM/lGjoC5Bpn1y65cxU+TAsW9GNOLI5/kNh tUSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z/zoKcrmx2IW2qZYN8v07zqfWyovJdKlsFhRtVJoj8Y=; b=m5Hz0Ln/5ZVpPqyKi3pfkGgB26HVtDZ/Bcc0HWz6//0lS3157fifsdrbvZYpr/kgUB MKCEAqNlXrBCrll/tCDPIQYhppxXAP+lUQ1D6/n5cpUSvpuFog15/EDGuD2soj1ST9Gx lYv8pVjUretMnR22FUzgG77yg1ObMisQbdOy/x7q5TiJ/OiUkjYYWU6hYb4wBBNYRsyE PFGTq269ickgcO++9GoYrxsodlbXpW4U6rM4giwuqF8kBg6z8DOV6Z3ovrwQ/werKdD+ A23hlgSpxPUwc2NT935K3eEvTNyBVof88KeIXAnbOf8Mi/BLnF7VQ0gkxwmQDkdCrmUa Wc7Q== X-Gm-Message-State: AOAM530ZiuCMnFw5fowgRzgen+Eqxsd523IpROhDDqHKNH7yGt3Nkx5K fzMqsulRnp5Av6HrAHABtH5C7A== X-Received: by 2002:a5d:698e:: with SMTP id g14mr4923996wru.301.1594725364528; Tue, 14 Jul 2020 04:16:04 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:03 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Guennadi Liakhovetski , netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 13/17] dma: nbpfaxi: Provide some missing attribute docs and split out slave info Date: Tue, 14 Jul 2020 12:15:42 +0100 Message-Id: <20200714111546.1755231-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/nbpfaxi.c:157: warning: Function parameter or member 'chan' not described in 'nbpf_desc' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'tasklet' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_src_addr' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_src_width' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_src_burst' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_dst_addr' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_dst_width' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_dst_burst' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'running' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'paused' not described in 'nbpf_channel' Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Martin KaFai Lau Cc: Song Liu Cc: Yonghong Song Cc: Andrii Nakryiko Cc: John Fastabend Cc: KP Singh Cc: Guennadi Liakhovetski Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones --- drivers/dma/nbpfaxi.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c index 594409a6e9752..74df621402e10 100644 --- a/drivers/dma/nbpfaxi.c +++ b/drivers/dma/nbpfaxi.c @@ -144,6 +144,7 @@ struct nbpf_link_desc { * @async_tx: dmaengine object * @user_wait: waiting for a user ack * @length: total transfer length + * @chan: associated DMAC channel * @sg: list of hardware descriptors, represented by struct nbpf_link_desc * @node: member in channel descriptor lists */ @@ -174,13 +175,17 @@ struct nbpf_desc_page { /** * struct nbpf_channel - one DMAC channel * @dma_chan: standard dmaengine channel object + * @tasklet: channel specific tasklet used for callbacks * @base: register address base * @nbpf: DMAC * @name: IRQ name * @irq: IRQ number - * @slave_addr: address for slave DMA - * @slave_width:slave data size in bytes - * @slave_burst:maximum slave burst size in bytes + * @slave_src_addr: source address for slave DMA + * @slave_src_width: source slave data size in bytes + * @slave_src_burst: maximum source slave burst size in bytes + * @slave_dst_addr: destination address for slave DMA + * @slave_dst_width: destination slave data size in bytes + * @slave_dst_burst: maximum destination slave burst size in bytes * @terminal: DMA terminal, assigned to this channel * @dmarq_cfg: DMA request line configuration - high / low, edge / level for NBPF_CHAN_CFG * @flags: configuration flags from DT @@ -191,6 +196,8 @@ struct nbpf_desc_page { * @active: list of descriptors, scheduled for processing * @done: list of completed descriptors, waiting post-processing * @desc_page: list of additionally allocated descriptor pages - if any + * @running: linked descriptor of running transaction + * @paused: are translations on this channel paused? */ struct nbpf_channel { struct dma_chan dma_chan;