From patchwork Mon Jul 6 23:10:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 234894 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp392263ilg; Mon, 6 Jul 2020 16:10:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCvnX0Fm983+n+dNBeWqUWQL3jX077lh67YdwB/PRFVZMRWM/r6621m+tAaT7UiSpvdZm+ X-Received: by 2002:aa7:d848:: with SMTP id f8mr49323479eds.329.1594077027221; Mon, 06 Jul 2020 16:10:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594077027; cv=none; d=google.com; s=arc-20160816; b=NpbodMWXEdgW5woRTEm9BHqyAlVECN+zeZbrNDrsOXvnuBtikCN2J1OWudOzPGOE/t gPFcjUOCkTGrVbXusvACANrGrI4Dmk8d7AElN8ypzhgqKYjF46tXHiWPWg5d3eb3Zt03 dtKx+fxRLXlgcEwsni1S0FeGIAV4K4UG1+MNDn8VlCK15o+5mbAeOBmhKDbtIupVFOB1 utSCVjf+/hEIfZQr5yz/l2VJjJBbw11Pbho7+SD2T9/bhveqyF9ntxlHMk/FyBvMTOvQ c8E/6tBF6pu9Mk/b/gsJ3N7lEoaJcb+3F1K6hwt7P2rp1OaEeM7UpjIAeSSyMNlXUyVg yqXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ankP85bIZrb6kR5tlukQkQix+FYTJlMioaJsg3D4qUg=; b=FPCi2atNgRsMF9XTImBPXvKPKKfg7ld/RZF4CKfbbh9CQ6B5Ny8LTOuhJg0wQvSHOG fZ4SFEth6X0GEhiTtoqI7wR9GWkdLArsw0udQGqT6M7FX3q2hX82Vm78Qz+7QYbAZahd 559TDofxfeSNV5gb5Xx6ImEU3kN7rFtSP41wQovF/bPQ2eTUJZfVJCFVTsxwVU3C3kwo WGlRNYsb4zzrGxdz278mlzDj+YwcQQ6EbyjaKxtEc1KYK4r/4XOFDB8qnZV6+ZEsTZzt oKenasdPym+Eeu9XKDRndeePxrp1ua6BOX4pNgUPR47ljqpmoVroEFqqzyC/UeJmLe3x j1KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZfgxS87Y; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w6si13885702edx.62.2020.07.06.16.10.27; Mon, 06 Jul 2020 16:10:27 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZfgxS87Y; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbgGFXKR (ORCPT + 9 others); Mon, 6 Jul 2020 19:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726918AbgGFXKQ (ORCPT ); Mon, 6 Jul 2020 19:10:16 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 378BFC061794 for ; Mon, 6 Jul 2020 16:10:15 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id k6so34381274ili.6 for ; Mon, 06 Jul 2020 16:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ankP85bIZrb6kR5tlukQkQix+FYTJlMioaJsg3D4qUg=; b=ZfgxS87Yj5mTWgguF2sLLEwgcR2OMZg2YrsgKJZzPAUklYJUviai2HniNxuzv5BXSQ z1hKHdjcAvXhgFlt8qm0jdY2rjoWnRw0e7GYq/SFL5jh2yw++uLiA3tsHsZMhIQegrU2 HqA19kP9oE5Ytq5e35trGzc84KNWaW34MrUzyLgIqQQ3an+ImttrBcp2t49sf3EPr4VV uWgRh41z9HSHYIoCNwaV8sn2SuT8ao5ylLvJJ8R5teg9tA4Gb+px0X+UY7oUNso/+v/J 8JvJHLuq+OrYCNc5LeoJNuHgqqlBZBGyjCUeMuw7xgIQmu8r6xUkQpjHO7pJvyNoWvsk UIdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ankP85bIZrb6kR5tlukQkQix+FYTJlMioaJsg3D4qUg=; b=gWVoTynLUpSsq7miWWKQ/b1AmxF82J/IrIple6/PSqTp9B+aJVJSTsVEjS/InINX2a E5EeggMxzolPG5n+gWS4E0EZ1UfEJMH+KF3KxKT+YlG7SbmpzREOmU8eNKZxXwiUbC4Y NyUC3ItwzIMpTMohLRW1TuXV4TKjc3SITL32hsoBIvXcuzQk9pD4fZGeSzjTlUBrJQe2 USv3LaMC663P5ZKPZfITmqAYJSfr1yG7Y1zqGtaoHLcCvo0dFFrZrPXRCZ3JtOoxjcWP WUc5BlpOU/5jlYaX/39KTH0VGOTbW4dM0tREyOomqNysTeuu2k4ragbqp0nS1ESiYCZB AO6g== X-Gm-Message-State: AOAM530jBWuX7+CbSwglPrkmFwzE9kbjPAMXFQ3llqbS6OflubgmwsBt dc7bqumJfGMlx4g63cSYaHXEcbGhHtzDxQ== X-Received: by 2002:a05:6e02:682:: with SMTP id o2mr30589234ils.188.1594077014526; Mon, 06 Jul 2020 16:10:14 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id w16sm11523029iom.27.2020.07.06.16.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 16:10:14 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 1/3] net: ipa: fix QMI structure definition bugs Date: Mon, 6 Jul 2020 18:10:08 -0500 Message-Id: <20200706231010.1233505-2-elder@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706231010.1233505-1-elder@linaro.org> References: <20200706231010.1233505-1-elder@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Building with "W=1" did exactly what it was supposed to do, namely point out some suspicious-looking code to be verified not to contain bugs. Some QMI message structures defined in "ipa_qmi_msg.c" contained some bad field names (duplicating the "elem_size" field instead of defining the "offset" field), almost certainly due to copy/paste errors that weren't obvious in a scan of the code. Fix these bugs. Fixes: 530f9216a953 ("soc: qcom: ipa: AP/modem communications") Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_qmi_msg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/net/ipa/ipa_qmi_msg.c b/drivers/net/ipa/ipa_qmi_msg.c index 03a1d0e55964..73413371e3d3 100644 --- a/drivers/net/ipa/ipa_qmi_msg.c +++ b/drivers/net/ipa/ipa_qmi_msg.c @@ -119,7 +119,7 @@ struct qmi_elem_info ipa_driver_init_complete_rsp_ei[] = { sizeof_field(struct ipa_driver_init_complete_rsp, rsp), .tlv_type = 0x02, - .elem_size = offsetof(struct ipa_driver_init_complete_rsp, + .offset = offsetof(struct ipa_driver_init_complete_rsp, rsp), .ei_array = qmi_response_type_v01_ei, }, @@ -137,7 +137,7 @@ struct qmi_elem_info ipa_init_complete_ind_ei[] = { sizeof_field(struct ipa_init_complete_ind, status), .tlv_type = 0x02, - .elem_size = offsetof(struct ipa_init_complete_ind, + .offset = offsetof(struct ipa_init_complete_ind, status), .ei_array = qmi_response_type_v01_ei, }, @@ -218,7 +218,7 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = { sizeof_field(struct ipa_init_modem_driver_req, platform_type_valid), .tlv_type = 0x10, - .elem_size = offsetof(struct ipa_init_modem_driver_req, + .offset = offsetof(struct ipa_init_modem_driver_req, platform_type_valid), }, { From patchwork Mon Jul 6 23:10:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 234893 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp392186ilg; Mon, 6 Jul 2020 16:10:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzHqtzQXnSD7jqDEceYAA8HqrKJSCKwPFkovEMnsDxoatHRKgCqzTvMH8psE4dyVsNfXc8 X-Received: by 2002:a17:906:f1d5:: with SMTP id gx21mr44296181ejb.121.1594077020586; Mon, 06 Jul 2020 16:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594077020; cv=none; d=google.com; s=arc-20160816; b=FImieapNFmCnslKzIiPZU+TjmC9uAqbQFz6rBon5YMwCkr0iZKLE9FsPcSaa6PuiS1 IYk4dFfj/cE8K8AUoKREAjjYU5ohH+VYn+lZdM1H43Sc5XzhtM5KQ7Km1lRuUxdoMhc/ ETwkaVhckr9kDQHQ16PxzykjUwO2Q1J7Btopgx6MqT1FDwPkTVmasOpxoxwzBiJsso4x reWzN6OnnuhqxBdQqGWgcv2kSYY5U3rhUeJZog9ACKKU/ee5AS/q9//CYNP0ywPjVFlT JuUxM8jTMlyD/ZA0PZSJC3EcCWct1z+I474dELNrT7hxwt/LbeQaHQBMK3SY1ZCG+63D A2ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=se6npIx/isoI+wc+DuA8rTR4AlHBZ2FFSB7wVA4cQcE=; b=GcpcFNaKOFniwVFM0zTjzGasBgGUYAwQvbL2Tzp2OsENcQvXCQf/LFgBIPmArSzC6J 7j5XN+nBkryzOQtcwFkeN2++sODTQMBRYJhjUgZeRBF5h45eNPxCkPjjStXe6419VVGN WsIpBdEKZiip82qfqMbxj2Ovpd6Z3Iz4JM2jfNCDXtfTWlqS6gOrLD9UCi6fAOYAbDAm cUEYUA4tGdc2uXGeaYkkZKqrjEqVVw5Hn+dhXgnXlFROC+xTbSvQFdlBqGovSrN+zCT2 vvo5671VI3atm5wSYOcvnrJsANKSReOtdSkk4FwBsy3YYgRsxPnivpLf4hHGzMfb8tEX Phog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UBuCvzeW; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b3si14643160edn.338.2020.07.06.16.10.20; Mon, 06 Jul 2020 16:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UBuCvzeW; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbgGFXKT (ORCPT + 9 others); Mon, 6 Jul 2020 19:10:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726946AbgGFXKQ (ORCPT ); Mon, 6 Jul 2020 19:10:16 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D3CBC08C5E0 for ; Mon, 6 Jul 2020 16:10:16 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id o3so17014688ilo.12 for ; Mon, 06 Jul 2020 16:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=se6npIx/isoI+wc+DuA8rTR4AlHBZ2FFSB7wVA4cQcE=; b=UBuCvzeWAF5+IDTI7RF1zsFrtgZM/fbjlSisrBTBcKRILehXI+LrHwlgiz4LyYb8pW Sf/SlBzf13tuYo7bFT8anxfKfI/fAOybik1Dpi4uQs30mVQm3eDvraBaivCejyOojATg 7MBl8KArREbaxVhzRuGvbOrFSZbJDp52D+yMjWCJs6den5Ah9H5jt8p3V8SI+cR/BbUI KPcdF0KK8/mCWakrO/4pq96mlk8xkwxg2KOrENdz/Iy0u2LZsvmmByOfJqkGw5u15Iu+ xZwvgB/on5WygSTkF7Y5XPoEaRfZpv4rEz0j99mcxVW6qB9dZI9aZgneyFJYc36FMcnO jLzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=se6npIx/isoI+wc+DuA8rTR4AlHBZ2FFSB7wVA4cQcE=; b=laAdBlB6tbmGks6f+b9whkOBiqfdTzPP1QxMVCsDy0YLA7smhO8dpAdZykbcMBKBhe 6+M9W4AwM4d5rM7wJY+ZwRUYekOH7XmWckOn4qqmOH6UgkDaDGoOu8I3VjwJ/knrS/bd PqYw2+EUOkpXjKCYO7lZWKTH2FQYkbedRT3FBFrhwL1aKTp/aAcOGLMIeA5vXVv+nhvb A43qTrb6bOsHmYQMIj8v5XOkGk7vFzjRwOZD77P8odDQzokhEtXYobQSIPHy/FWKz6Nb uYyUuy/Nm1lqllX3srcDwqiYfvXnsLAhM3n7CAvay9fUjUHSf7GUhVWwNshSZnah6Id2 xHxw== X-Gm-Message-State: AOAM531tfRPXPo5yuA8EE89Cr0iLJ2gUs2FpzIQRjX6/Po4i1ggGL/+X 1whyJkRYs8DrI/tC4DLot/Bkrg== X-Received: by 2002:a92:dd02:: with SMTP id n2mr32990236ilm.257.1594077015622; Mon, 06 Jul 2020 16:10:15 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id w16sm11523029iom.27.2020.07.06.16.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 16:10:15 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 2/3] net: ipa: declare struct types in "ipa_gsi.h" Date: Mon, 6 Jul 2020 18:10:09 -0500 Message-Id: <20200706231010.1233505-3-elder@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706231010.1233505-1-elder@linaro.org> References: <20200706231010.1233505-1-elder@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Pointers to two struct types are used in "ipa_gsi.h", without those struct types being forward-declared. Add these declarations. Fixes: c3f398b141a8 ("soc: qcom: ipa: IPA interface to GSI") Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_gsi.h | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 diff --git a/drivers/net/ipa/ipa_gsi.h b/drivers/net/ipa/ipa_gsi.h index 3cf18600c68e..0a40f3dc55fc 100644 --- a/drivers/net/ipa/ipa_gsi.h +++ b/drivers/net/ipa/ipa_gsi.h @@ -8,7 +8,9 @@ #include +struct gsi; struct gsi_trans; +struct ipa_gsi_endpoint_data; /** * ipa_gsi_trans_complete() - GSI transaction completion callback From patchwork Mon Jul 6 23:10:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 234895 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp392312ilg; Mon, 6 Jul 2020 16:10:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyK+QMSt2Q/BSn7ZEbcAODp2fhr4OwiCuwPPYMwYr1vA6vLsUrfmSnyJgiCoVLCgvDX1Np8 X-Received: by 2002:a17:906:4bc1:: with SMTP id x1mr35811261ejv.377.1594077032324; Mon, 06 Jul 2020 16:10:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594077032; cv=none; d=google.com; s=arc-20160816; b=yzpGZJITjmw8FXeAJjYTdSUBo7bKN2Mu3L1KWDN1imXiOhjpKjsRDv1J/0D2UFih/7 8rh5cc9cj7+s1TGjMFC8yEMogJPk4lL5huq1+WogUYAal4VAZq0AJ8bC8uSk92Ih6Wck 9qjrYwX6IVg3YcIrJep7h31cx3LqglgdXFVOtE1ms7MQ1Es8dWty6QVi4gRdJ+Qh6UTn 8Au5CYWW1CFq3vULbpjAFIkbglAm8VV3NES9gLU7JC362fUehGn2D2ez3QAlB8ZCSoT7 DkED8piLr7o9bLzrmfS53IcsN7r/wLt+zRxnOuLc+sYHGxhFB6OyhFBHZCvXVFUGcZOs 9+9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PZvIX6vLMbdnQ9xi6X13Q9UES2Dc+IRz4gOtA11omag=; b=WLd1vWSDhefuDuisVJNoaSzKx1vhXbX7VHUQNZUNDKkWfppq6iHvOc4t+4EsPH3v2v tZ2/LE7KW6IjHtGcBFTINZnO7FVvzptOuxJMQcoHpDQgONjXcOpbxY1YuRd6LTq76cXP 4Nd+0riqt3sTEiP/daIyOZl32SbmaQpD+FcXtNEeuhQaYLDR+EgT5lkv/jU77uhqukYf MzbdK9ujd4pMv/Bywu0tNDiuwCjoj3PAWkIJCQ5wLTXSSQeKB+634di1+p/D+d+Yraqs jtnIj3/466PPoXiturPHGAlTQo2YaHcwTTx62t6wJsATy/8dBmgtkpKjphkqa2oHV9Ks q2Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cjf8h2QD; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w6si13885702edx.62.2020.07.06.16.10.32; Mon, 06 Jul 2020 16:10:32 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cjf8h2QD; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727928AbgGFXKb (ORCPT + 9 others); Mon, 6 Jul 2020 19:10:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbgGFXKR (ORCPT ); Mon, 6 Jul 2020 19:10:17 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DCEFC061755 for ; Mon, 6 Jul 2020 16:10:17 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id a12so41215281ion.13 for ; Mon, 06 Jul 2020 16:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PZvIX6vLMbdnQ9xi6X13Q9UES2Dc+IRz4gOtA11omag=; b=Cjf8h2QDNDmu6NNDaeQqVXA0UYoFCg5Rnh/FqMDFA/mJbYX8C91CKnmrMizibrHZ+r cVrXBaQJIdLTRfiaR9ojksO3cW8C1k5Fx6yK+92XEPYmJtqfPGi2IY/HLhqG4/2rWpN7 40Rken9P0iVRYtrZi0N5lDn3FJk2S7rLqjx2oWQY0hkFGmbIx7RuWKiOsxBeXQ+0QZgT /0KpV5/2QBE5urHl98sv4+Bet4VJIqzgbiQ42BvSkkxdxrXUYJPQdKp/h8fmp8f1Aa9K GNzGOr8lNiNfJYjI+XuiiBCxBtumK585s1LvxeozZXFPop1HXNhG/man06ppLnxvjZMn s5ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PZvIX6vLMbdnQ9xi6X13Q9UES2Dc+IRz4gOtA11omag=; b=bcFOWYRNjNkrJBjpiJp6d/hcJSoI/6Yu5VXqQnuemYr+obb0lxVpTkkFPg8iq/gMyo SA/+VOTOO3BGhtGwtfmKrxLJfWKzaflLudzmLBhF+CQSCdpnNc/bChgY7duE1T9Z5XSD IbzkgkNG2bajAF2b3eu9Q2U7B/Gp7DDh1cHEfcmN+3dqSVElTBFPRsJN5TRK9zRlVHXN BwlmIm02Xl8OeMAkTw/rMaTqD8m+g8UMQScK6KV8m8+lGXW8nHLxYagGVhAcyQMl02JV ESWGi/mi3xrAjK6sbdNFObntFx20H2/7uY4vxWkDRw28pReaGMg62XDKXfUmlC+25hHZ vhNg== X-Gm-Message-State: AOAM532vt+c+6xNQzwcyg6SEOpRRVPFdemUFQgIEf2OUutqEV9vm0ymn PTcUKZK5Evo+nFlkGrGHYve2FA== X-Received: by 2002:a5e:da06:: with SMTP id x6mr27921238ioj.196.1594077016696; Mon, 06 Jul 2020 16:10:16 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id w16sm11523029iom.27.2020.07.06.16.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 16:10:16 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 3/3] net: ipa: include declarations in "ipa_gsi.c" Date: Mon, 6 Jul 2020 18:10:10 -0500 Message-Id: <20200706231010.1233505-4-elder@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706231010.1233505-1-elder@linaro.org> References: <20200706231010.1233505-1-elder@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Include "ipa_gsi.h" in "ipa_gsi.c", so the public functions are defined before they are used in "ipa_gsi.c". This addresses some warnings that are reported with a "W=1" build. Fixes: c3f398b141a8 ("soc: qcom: ipa: IPA interface to GSI") Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_gsi.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/net/ipa/ipa_gsi.c b/drivers/net/ipa/ipa_gsi.c index dc4a5c2196ae..d323adb03383 100644 --- a/drivers/net/ipa/ipa_gsi.c +++ b/drivers/net/ipa/ipa_gsi.c @@ -6,6 +6,7 @@ #include +#include "ipa_gsi.h" #include "gsi_trans.h" #include "ipa.h" #include "ipa_endpoint.h"