From patchwork Wed Mar 11 01:09:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jules Irenge X-Patchwork-Id: 222726 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE4BC18E5B for ; Wed, 11 Mar 2020 01:10:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7059821927 for ; Wed, 11 Mar 2020 01:10:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dixj4Z0Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727944AbgCKBKB (ORCPT ); Tue, 10 Mar 2020 21:10:01 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:39060 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727941AbgCKBJc (ORCPT ); Tue, 10 Mar 2020 21:09:32 -0400 Received: by mail-wm1-f68.google.com with SMTP id f7so286887wml.4; Tue, 10 Mar 2020 18:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FfWEwRjnWrI+e8fHcACmfkZeIDdYu59pur6KndMjjNY=; b=Dixj4Z0YJlggYSUyUQ/N9K0iThizcZjLO5mZ0kvDXMOeW/zwZcQauhE3tLJNSllkoK 80A5vpgifCRcyJxHA6rElCdLyN5yP8L1/cYjeSkp8sApvioSr0RhOv22ecMIAb1NYTpa REPR/NkIA4C2Ccfqoobtar0T44RnX5Xfx4leimnUWNMcxwQ24x3USvnVXQdsW5d7VE6I GdlFxWjKVcOw3pqvzBMvpM2DkECy6oAJXKac34Iy4ZZfaQPb5x5ODzYR05dvvDC3NmW1 zQhhha3u1jR56yzq1wg8w+UHevJhetmbsCgSRL5kFfrfyk0JowhjrHX+xOv0cyyM9xRB hq5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FfWEwRjnWrI+e8fHcACmfkZeIDdYu59pur6KndMjjNY=; b=j7j6gMvHNXXQGf1qCflY3CQUovuau3mthP5ms4O5ft9epTWa8iNXGI5W0dkxSZLhLn qtbtQIwklyupXH/swdL+ZtKltA2G0y3GYvpQTnVosTNckmBkWbzJ2m+PonOVhmA2NNfQ EbMQImWuBNUY7778M1bRWhjtuu8AI1SvFCCmMWPCfp8TRYLhTanKRLHHLrcuhzWiNEr1 f+jPlB9X28oFQGaMC0ugFpeByiwtiUSj06T7+vZwuQJdBT/PMxIV/nXGkN0SEdPFlfrT vUI0mf8gyuKfvasmQ7dvO4hN6LgKP3f/2NBDCS4S3jzMK4lOqc7io3mbRDkjvwcik1Sz 5PTg== X-Gm-Message-State: ANhLgQ2cuRdtblifYEqLQ1K0wVq75sUFI69rshxlQ9pSYnum6gFafzlR CPbrGmBPpNI2tOZrPVmy8w== X-Google-Smtp-Source: ADFU+vsrGhrH0kjCQVr6n7dem2snr5Jgxu93uqYQ1n3Q1xOAaD7eT0k5slu7U6q1CB/jTfcY653ZHA== X-Received: by 2002:a1c:a345:: with SMTP id m66mr381869wme.114.1583888968391; Tue, 10 Mar 2020 18:09:28 -0700 (PDT) Received: from ninjahost.lan (host-2-102-15-144.as13285.net. [2.102.15.144]) by smtp.googlemail.com with ESMTPSA id i6sm36658097wra.42.2020.03.10.18.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 18:09:28 -0700 (PDT) From: Jules Irenge To: boqun.feng@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Jakub Kicinski Subject: [PATCH 3/8] tcp: Add missing annotation for tcp_child_process() Date: Wed, 11 Mar 2020 01:09:03 +0000 Message-Id: <20200311010908.42366-4-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311010908.42366-1-jbi.octave@gmail.com> References: <0/8> <20200311010908.42366-1-jbi.octave@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sparse reports warning at tcp_child_process() warning: context imbalance in tcp_child_process() - unexpected unlock The root cause is the missing annotation at tcp_child_process() Add the missing __releases(&((child)->sk_lock.slock)) annotation Signed-off-by: Jules Irenge --- net/ipv4/tcp_minisocks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c index ad3b56d9fa71..0e8a5b6e477c 100644 --- a/net/ipv4/tcp_minisocks.c +++ b/net/ipv4/tcp_minisocks.c @@ -817,6 +817,7 @@ EXPORT_SYMBOL(tcp_check_req); int tcp_child_process(struct sock *parent, struct sock *child, struct sk_buff *skb) + __releases(&((child)->sk_lock.slock)) { int ret = 0; int state = child->sk_state; From patchwork Wed Mar 11 01:09:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jules Irenge X-Patchwork-Id: 222728 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B27D1C18E5A for ; Wed, 11 Mar 2020 01:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 795F924680 for ; Wed, 11 Mar 2020 01:09:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qvULlz99" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727977AbgCKBJg (ORCPT ); Tue, 10 Mar 2020 21:09:36 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51036 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727958AbgCKBJf (ORCPT ); Tue, 10 Mar 2020 21:09:35 -0400 Received: by mail-wm1-f67.google.com with SMTP id a5so298749wmb.0; Tue, 10 Mar 2020 18:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vVRR4OgupYaiYbHKhmSicBHQ95FN9+SKT9CQzo7pJnM=; b=qvULlz99rWRiLqex5Lnn1QU1NhB/rQU7Wu8/SvYwZHZSifBTXvmU8WAGQIj8+/k9mT aOVd9vPoRvUPnFcecDzQZJE/MygViKIMPSuwXoeS/2yWxorCxdJ46MTFNPSZTs1uI7QI w9FvmdwQHbfNUuGOToq0xasCIJPmi6NZSf3ctusJjmrxW+GR938JEwGd5F0JFzDPivOO szaaDIuuKlTSOVORMmp5nEd/i6JMrX/UdDYo/lAEO7Nyl/St7iCJdbRVgsBFcaQhCd/r 4SpKYdnrvHW9Qb3RxC9tj92GCqz2Q8MuSJ6BWtEmTsTRSfNyT9COuXCLgLD+Fawc7mun n6wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vVRR4OgupYaiYbHKhmSicBHQ95FN9+SKT9CQzo7pJnM=; b=UMmhJvxprM8hWggW5kjm/b3a+mfr9iQ0Nq0O41qahfl/oRAzROigefpOQosq1FWMsG FiMjwgKIWRV0BvcDBmcRNADVhAEF97eo4ATzx+XAdz+GzHRptRfh2hzwiP+dn/mp1555 C/PqIduFrpmSrhNONQ/vCjeyMi/PY7tQqb5RQ2TJ9I458bdLpaTMYGLYIvWGg9TzBcwY haD269S+Lw8Zjr2ktgbuT2XfrGft35NlMa0s+Gtpy6jmObdur3vVAjeRqksc4WLpTe6r 8DK9kuKORxc1V1ByxASNdZuoth/drsa62PDK99mHC04evH1zL7s5KcwInGLn5ZrIMqGp B64w== X-Gm-Message-State: ANhLgQ3sbGhpFtwMXoG+sihjrdXkODJ0TDEOojpc5ZZmUAfqGZmcsCyN zY4/PjbuuJWBycxVlpYCi+6IAIt0sLsZ X-Google-Smtp-Source: ADFU+vtXpCSp5JFuiBAC9PWH1R2+yQ8jDwpK5A9aOUQnqqdqMGMCmmBBcK5PstShOSvBnZVXdm1TtQ== X-Received: by 2002:a7b:c4cc:: with SMTP id g12mr379000wmk.104.1583888971399; Tue, 10 Mar 2020 18:09:31 -0700 (PDT) Received: from ninjahost.lan (host-2-102-15-144.as13285.net. [2.102.15.144]) by smtp.googlemail.com with ESMTPSA id i6sm36658097wra.42.2020.03.10.18.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 18:09:31 -0700 (PDT) From: Jules Irenge To: boqun.feng@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org (open list:NETFILTER), coreteam@netfilter.org (open list:NETFILTER) Subject: [PATCH 5/8] netfilter: conntrack: Add missing annotations for nf_conntrack_all_lock() and nf_conntrack_all_unlock() Date: Wed, 11 Mar 2020 01:09:05 +0000 Message-Id: <20200311010908.42366-6-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311010908.42366-1-jbi.octave@gmail.com> References: <0/8> <20200311010908.42366-1-jbi.octave@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sparse reports warnings at nf_conntrack_all_lock() and nf_conntrack_all_unlock() warning: context imbalance in nf_conntrack_all_lock() - wrong count at exit warning: context imbalance in nf_conntrack_all_unlock() - unexpected unlock Add the missing __acquires(&nf_conntrack_locks_all_lock) Add missing __releases(&nf_conntrack_locks_all_lock) Signed-off-by: Jules Irenge --- net/netfilter/nf_conntrack_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index d1305423640f..a0bc122d5df1 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter/nf_conntrack_core.c @@ -143,6 +143,7 @@ static bool nf_conntrack_double_lock(struct net *net, unsigned int h1, } static void nf_conntrack_all_lock(void) + __acquires(&nf_conntrack_locks_all_lock) { int i; @@ -162,6 +163,7 @@ static void nf_conntrack_all_lock(void) } static void nf_conntrack_all_unlock(void) + __releases(&nf_conntrack_locks_all_lock) { /* All prior stores must be complete before we clear * 'nf_conntrack_locks_all'. Otherwise nf_conntrack_lock() From patchwork Wed Mar 11 01:09:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jules Irenge X-Patchwork-Id: 222727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB492C10DCE for ; Wed, 11 Mar 2020 01:09:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D9F621D56 for ; Wed, 11 Mar 2020 01:09:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r93FSAoX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728010AbgCKBJp (ORCPT ); Tue, 10 Mar 2020 21:09:45 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38268 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727923AbgCKBJn (ORCPT ); Tue, 10 Mar 2020 21:09:43 -0400 Received: by mail-wm1-f67.google.com with SMTP id n2so291068wmc.3; Tue, 10 Mar 2020 18:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rM3cbsU55xJlyKmK7QwcQylOwbs8Tma9Iu3Kufv/e4E=; b=r93FSAoX3d3rZQcJ/3HADdXXtRixoWxZEGpdEuNh0YacpT4Ty8mUDyVxEXd8TyYAtj LKVik9H7txixvdX862XIkrjHwM1wrTzq1MWIMARCGXuI1sfYt6D3TbZn9bJcziwFzylW QkQ/5WyQTgdqlBkehnSHgYQAWLjnZaHvq/Psc+ZSjzU/FjJxMzNASkz3Wy9d3p8rzVTK 9OzIcb5VGOsWocOu9tiURVX+ew1NIko8nZChiBDq1v01xXMRPTbl7pkv/o+kflW3Fk9L v2kaH0GAh1KA7FtRSKVkqo68xL0Ij7MsGl8w+LDDZSd9znw+IrbTXc/5P6le7RihJVqV zA2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rM3cbsU55xJlyKmK7QwcQylOwbs8Tma9Iu3Kufv/e4E=; b=AsHQXcQ4MeKA0EaPBa0H3arRCkvTHVCxxorkMn+io5P7iHyPErAbQW2VUDXvoYm4bf z+aMPY5O2EZxwj750hTB2Bnl0nMjxUnyXvJyykDk2pIdIv5PzD0JRZsJK+1N6ZIJ2aom Xl+q+wzWU1fyMFjULT2b1tBhOMU9ji9skmYhxBti2moeRYD6dpc+ez2VR/WqIeX0YgKC B+UUoVpg6sd2j9OG0f1cAt7g24XlDnwFlKp2U9IyiP1BtR04yQbVYLXzYlUI9GHsWJP5 QtyS6k9UYR2erwcZMtK1QH0QgAnaZnu1ORDgAZkE1YC3YywBfVUD3hydgaQwT0ve9Umv jAfg== X-Gm-Message-State: ANhLgQ3bdzTq7SWTuZvvL+yV3KKdkIz0nzt0UzCIdtrdfH00MBNaVqgK 6ubKVHu1+ZV6b13lTaGbUQ== X-Google-Smtp-Source: ADFU+vtjoWA4bkISywodXaBjpthXQzuAc5Q6v2tqYQpfmLp+cZN2g+BrSyNtymI7EZ5aVbUmOg6z2Q== X-Received: by 2002:a05:600c:294a:: with SMTP id n10mr433928wmd.11.1583888979445; Tue, 10 Mar 2020 18:09:39 -0700 (PDT) Received: from ninjahost.lan (host-2-102-15-144.as13285.net. [2.102.15.144]) by smtp.googlemail.com with ESMTPSA id i6sm36658097wra.42.2020.03.10.18.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 18:09:39 -0700 (PDT) From: Jules Irenge To: boqun.feng@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Clemens Ladisch , Takashi Sakamoto , Jaroslav Kysela , Takashi Iwai , Alexios Zavras , Greg Kroah-Hartman , Allison Randal , Thomas Gleixner , alsa-devel@alsa-project.org (moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6 PACKET...) Subject: [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue() Date: Wed, 11 Mar 2020 01:09:07 +0000 Message-Id: <20200311010908.42366-8-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311010908.42366-1-jbi.octave@gmail.com> References: <0/8> <20200311010908.42366-1-jbi.octave@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sparse reports a warning at tscm_hwdep_read_queue() warning: context imbalance in tscm_hwdep_read_queue() - unexpected unlock The root cause is the missing annotation at tscm_hwdep_read_queue() Add the missing __releases(&tscm->lock) annotation Signed-off-by: Jules Irenge --- sound/firewire/tascam/tascam-hwdep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c index c29a97f6f638..9801e33e7f2a 100644 --- a/sound/firewire/tascam/tascam-hwdep.c +++ b/sound/firewire/tascam/tascam-hwdep.c @@ -36,6 +36,7 @@ static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf, static long tscm_hwdep_read_queue(struct snd_tscm *tscm, char __user *buf, long remained, loff_t *offset) + __releases(&tscm->lock) { char __user *pos = buf; unsigned int type = SNDRV_FIREWIRE_EVENT_TASCAM_CONTROL;