From patchwork Wed Mar 25 18:11:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Fuzzey X-Patchwork-Id: 221850 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A1EC2D0E6 for ; Wed, 25 Mar 2020 18:12:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BB472076F for ; Wed, 25 Mar 2020 18:12:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=flowbird.group header.i=@flowbird.group header.b="BJCpQeb6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727996AbgCYSMF (ORCPT ); Wed, 25 Mar 2020 14:12:05 -0400 Received: from mail-wr1-f99.google.com ([209.85.221.99]:40097 "EHLO mail-wr1-f99.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727682AbgCYSMC (ORCPT ); Wed, 25 Mar 2020 14:12:02 -0400 Received: by mail-wr1-f99.google.com with SMTP id u10so4388532wro.7 for ; Wed, 25 Mar 2020 11:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=G61Qe3eJT571EH7x7IhXUIxwlPNKKyhXnXe4ITy6VDY=; b=BJCpQeb64ilhKkblw6FOV5x7rvqyn9D/mptuh8QHSv4LCHx1h22tsz8VRicfOKIuy7 35s2PDgmhbScymVqGByxQVrsHLJq/j6RIv3ZN9aU4o0WZb7B6SFqEnxXJps5QZDa976P 813Xnt5LQ4xFA7gvgY4LSfSUV6/LS+lHY+tOwPFPM2xZp0NhZXgbyz+l3iI0cfUDGn1Q fZwzLwf2H3HWMhqX9GaeOm9oUOvEcbXom84OCu1QYjvKjkEEjdXMfLIZE0Rcnget399+ imRnWfc8rguyBYzRG8WqYpl66nH71FdYg0QK2vD6lUzCa+uLIujmj9ArAoelFtMcH4jE N4KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=G61Qe3eJT571EH7x7IhXUIxwlPNKKyhXnXe4ITy6VDY=; b=f2/qtQU5BY3Szly2+dRJFRjQmVQN4PZqeNs655fXfoxDIwiRdrcKv6tN1WZTgjgoRV F27CmqQm6sHEY6oK0jG5wD63AC91V2fRAm91GD902S9Pwdi/nuSmttjBfprKPtYm6unm aNgHAnYfxcUaSAaSWF1CjXfuWDHr040RLVhdnF7DNRuCjbZ9WtTyddgTSJd0p+pIDK00 LWT2Gg6uWzYxpIdptl0BpXZ+JUEaY30zbG3lb464Ulc4QFZH5sP/kfDcJsx/YX/SEJvZ ZMSMS4SAOjksA66DOMocbdgKIErasGTKXg/gc8SkzrKZxu0kMyt+bjBv3n7DctveE7ef f81w== X-Gm-Message-State: ANhLgQ1Zv+UrLL+HJrU5CiX39eg1knd33/UoA8KbC5GI54W2yAlCFHjT UpzlqIuxFAycJpjRmE6G2qgg+taoC6QFJTlBbwaA13ry3LS4 X-Google-Smtp-Source: ADFU+vub5D0jlsGOnm4YpokUYEZUOEHB6GT1kQnRwz9Q/yK67pONTdN9dt97HprIfogh2eG4adM5QF2KReUu X-Received: by 2002:a05:6000:114f:: with SMTP id d15mr4897008wrx.143.1585159919696; Wed, 25 Mar 2020 11:11:59 -0700 (PDT) Received: from mail.besancon.parkeon.com ([185.149.63.251]) by smtp-relay.gmail.com with ESMTPS id e16sm328483wrs.81.2020.03.25.11.11.59 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 25 Mar 2020 11:11:59 -0700 (PDT) X-Relaying-Domain: flowbird.group Received: from [172.16.13.190] (port=39524 helo=PC12445-BES.dynamic.besancon.parkeon.com) by mail.besancon.parkeon.com with esmtp (Exim 4.71) (envelope-from ) id 1jHAVT-0003Oy-7a; Wed, 25 Mar 2020 19:11:59 +0100 From: Martin Fuzzey To: Fugang Duan , Rob Herring , Shawn Guo , "David S. Miller" Cc: netdev@vger.kernel.org, Fabio Estevam , linux-kernel@vger.kernel.org, Sascha Hauer , NXP Linux Team , devicetree@vger.kernel.org, Andrew Lunn Subject: [PATCH v2 2/4] ARM: dts: imx6: Use gpc for FEC interrupt controller to fix wake on LAN. Date: Wed, 25 Mar 2020 19:11:57 +0100 Message-Id: <1585159919-11491-3-git-send-email-martin.fuzzey@flowbird.group> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1585159919-11491-1-git-send-email-martin.fuzzey@flowbird.group> References: <1585159919-11491-1-git-send-email-martin.fuzzey@flowbird.group> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In order to wake from suspend by ethernet magic packets the GPC must be used as intc does not have wakeup functionality. But the FEC DT node currently uses interrupt-extended, specificying intc, thus breaking WoL. This problem is probably fallout from the stacked domain conversion as intc used to chain to GPC. So replace "interrupts-extended" by "interrupts" to use the default parent which is GPC. Fixes: b923ff6af0d5 ("ARM: imx6: convert GPC to stacked domains") Signed-off-by: Martin Fuzzey --- arch/arm/boot/dts/imx6qdl.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index e6b4b85..bc488df 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -1039,9 +1039,8 @@ compatible = "fsl,imx6q-fec"; reg = <0x02188000 0x4000>; interrupt-names = "int0", "pps"; - interrupts-extended = - <&intc 0 118 IRQ_TYPE_LEVEL_HIGH>, - <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0 118 IRQ_TYPE_LEVEL_HIGH>, + <0 119 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET_REF>; From patchwork Wed Mar 25 18:11:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Fuzzey X-Patchwork-Id: 221849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ADDEC2D0E5 for ; Wed, 25 Mar 2020 18:12:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15B882076F for ; Wed, 25 Mar 2020 18:12:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=flowbird.group header.i=@flowbird.group header.b="rrNk6Kcx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbgCYSME (ORCPT ); Wed, 25 Mar 2020 14:12:04 -0400 Received: from mail-ed1-f100.google.com ([209.85.208.100]:45287 "EHLO mail-ed1-f100.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727705AbgCYSMD (ORCPT ); Wed, 25 Mar 2020 14:12:03 -0400 Received: by mail-ed1-f100.google.com with SMTP id u59so3687073edc.12 for ; Wed, 25 Mar 2020 11:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KKpKhLhaC9HGAwcc/wCEo8PVI3BgJbUGYTvCaeR49Ok=; b=rrNk6KcxURyxMqPmDLj2w7bRmiDPMbUI0d/kn5MoPrEUo33YzVn3zrxcuD85NeIErE +uGfzC7ut3SYcHQaLhmVWeUTDF73/vZGMa7Ku0Mz/KEWdWqxjWZHRLrkQP0RfXWMGD0m g8VbKMTkYncsJmDzeZV4BiiiM5zYJmPUIi2Cs4pHzaY5pWLRtjTfZVHxHP9YFhI9gv2h /soDGEdt35MheO4BaZk6KhmtRX4IfSR4z5IKnqcXCOr/49iFIdKQh5jwWJD6BMQDXElL to2vidpfeVH7HdXqu2o5MY3gopz3yUWfxHW8arc0tljoE4wT5MR3wxtPfBk3kpMziCWj MZ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KKpKhLhaC9HGAwcc/wCEo8PVI3BgJbUGYTvCaeR49Ok=; b=HUJQ+mgtQV+5dvDsYbYGAy3Ib3jZHmrgFtMUWmDejx+Y64aeYm/D6i1h+KJqZQ4dCo Wt6yVG8SEJ0G6lDxIa47cmiRT7BMKYHDRgIg4WLjRLUGrkdww+EuylaremSiGBBQS7F1 IK6YKJWjXDPuVtouV8w3V4fee/zqkuL7HFGDTcHWUaL480NYPIK7w3aZfxNdCukMCE6l FiO0dUmPygUpX9R88SU281ssbRePA6NZeyRLV+rolVzngrdax27neNYKYWW3GtErbUZ3 Rmwx7aMXe1Oh7FFaO78N2dQM9sPnJSF3FWYfoyArF+m52/YnnYRVv821Sy+ogkq1GHsN f8ZA== X-Gm-Message-State: ANhLgQ3OB8LPGMTGl9CGj+q/jutfVHUyjeV+ohkFLZTUhBB6z4PcIrcJ fHPEo4iN0b6c4GbuWj2JrPxIjNL61QRDm3SUvbzYeFwMht98 X-Google-Smtp-Source: ADFU+vuep+cArUuYfyT4aIlU+oz4LwkVg1M9a67K8D0RfGmqdTIIjC4kRTkukTB5EAVMq2zHqSjAPESSkERj X-Received: by 2002:a17:906:1cc9:: with SMTP id i9mr2034588ejh.0.1585159920479; Wed, 25 Mar 2020 11:12:00 -0700 (PDT) Received: from mail.besancon.parkeon.com ([185.149.63.251]) by smtp-relay.gmail.com with ESMTPS id x25sm182281edl.7.2020.03.25.11.12.00 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 25 Mar 2020 11:12:00 -0700 (PDT) X-Relaying-Domain: flowbird.group Received: from [172.16.13.190] (port=39524 helo=PC12445-BES.dynamic.besancon.parkeon.com) by mail.besancon.parkeon.com with esmtp (Exim 4.71) (envelope-from ) id 1jHAVT-0003Oy-U9; Wed, 25 Mar 2020 19:12:00 +0100 From: Martin Fuzzey To: Fugang Duan , Rob Herring , Shawn Guo , "David S. Miller" Cc: netdev@vger.kernel.org, Fabio Estevam , linux-kernel@vger.kernel.org, Sascha Hauer , NXP Linux Team , devicetree@vger.kernel.org, Andrew Lunn Subject: [PATCH v2 3/4] dt-bindings: fec: document the new gpr property. Date: Wed, 25 Mar 2020 19:11:58 +0100 Message-Id: <1585159919-11491-4-git-send-email-martin.fuzzey@flowbird.group> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1585159919-11491-1-git-send-email-martin.fuzzey@flowbird.group> References: <1585159919-11491-1-git-send-email-martin.fuzzey@flowbird.group> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This property allows the gpr register bit to be defined for wake on lan support. Signed-off-by: Martin Fuzzey --- Documentation/devicetree/bindings/net/fsl-fec.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt index 5b88fae0..ff8b0f2 100644 --- a/Documentation/devicetree/bindings/net/fsl-fec.txt +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt @@ -22,6 +22,8 @@ Optional properties: - fsl,err006687-workaround-present: If present indicates that the system has the hardware workaround for ERR006687 applied and does not need a software workaround. +- gpr: phandle of SoC general purpose register mode. Required for wake on LAN + on some SoCs -interrupt-names: names of the interrupts listed in interrupts property in the same order. The defaults if not specified are __Number of interrupts__ __Default__