From patchwork Tue Sep 19 16:00:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 113032 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp5083376qgf; Tue, 19 Sep 2017 09:00:33 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDjOfPD/qRzhne+aE1M6hhESfCJldAlddn0508/Yx+NOgMuhZ3LQxu3jA9+CHcnZFeHGGll X-Received: by 10.107.186.86 with SMTP id k83mr2416255iof.173.1505836833744; Tue, 19 Sep 2017 09:00:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505836833; cv=none; d=google.com; s=arc-20160816; b=fKuPclRncVwFbZ5LFb0jwscYx//2HCLcXKqV/PmnFmHHbyvvMouTQJ1zkZssbVwEtE 9jDE4m+CeKZ7jovYOYMOnjwjTjYBppWQFMPTyd7Y/UdlNIw67U+RzAF09iRVJl7uITXT dTmmwz4BwS0IuQCaZ6fUOpHF+inPt+kGxVKU6Z2nnlDTsBozD4/DwJNL8CsZpAMU0UFB 5IwuFFnOK3ydo/T5O37MWUAZRn6FLP28OElsxAFdQfitslZRG6e/I/0FmGQhPzqD4QWJ xqF6OIWYlItPPwPDNqndCk3HtlGdxahPrrKLjc1cSGY6aJbjfVPj+ITwhAqqMkeYIvTW sNmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=0gIHswW8Eq31En2ICESZe13MwAVneLG2aRSAuPHsXws=; b=x1zjuYvcSoKoX+OVBp9MJWaSz+20/orypGdlJ3PdsdcEmXVWTrs6XxJWl0pgxt5KPO iyFKjOIZFfHnOY68XkhyU4lcmxggljzVPSvk6+qc1/BsVNqE9vIchCLI4Oz3CqSSvu0a FfHZY1OzOGRujQFEKGbnGhQMeUYGzBQLhBgIKsuyglmGrAIiIDkKVpTIzr7NaauJU9w7 Y9vFQLIiD4yNkN9vsElG2QMnevzNTsI69FHJ9D8jjs97ntr6jc51WpIgLvTTHrcHtuPT +inI7XaO9LAGceP9eWDg00HBo/x0XS6VmsA6/tDjLago6hAj2gb3r9OKhlK+fs9iAKbb fogw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id l7si8277642ioe.326.2017.09.19.09.00.32; Tue, 19 Sep 2017 09:00:33 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 766F762C7E; Tue, 19 Sep 2017 16:00:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id ED5BD60C0A; Tue, 19 Sep 2017 16:00:26 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id A38C561E1A; Tue, 19 Sep 2017 16:00:24 +0000 (UTC) Received: from forward100p.mail.yandex.net (forward100p.mail.yandex.net [77.88.28.100]) by lists.linaro.org (Postfix) with ESMTPS id 824D360C0A for ; Tue, 19 Sep 2017 16:00:21 +0000 (UTC) Received: from mxback5o.mail.yandex.net (mxback5o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1f]) by forward100p.mail.yandex.net (Yandex) with ESMTP id 2A1895105428 for ; Tue, 19 Sep 2017 19:00:20 +0300 (MSK) Received: from smtp1j.mail.yandex.net (smtp1j.mail.yandex.net [2a02:6b8:0:801::ab]) by mxback5o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id IQCYx9dUkC-0KkKnBcI; Tue, 19 Sep 2017 19:00:20 +0300 Received: by smtp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id YFwFLCsRJt-0JbuG0wv; Tue, 19 Sep 2017 19:00:19 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 19 Sep 2017 19:00:16 +0300 Message-Id: <1505836816-15468-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1505836816-15468-1-git-send-email-odpbot@yandex.ru> References: <1505836816-15468-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 182 Subject: [lng-odp] [PATCH API-NEXT v1 1/1] linux-generic: fix GCC7 build error in sched_cb_pktin_poll_one X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Ola Liljedahl Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=3246 by adding missing curly braces around if-clause. For builds which don't flag this as an error, the resulting build would be functional but with degraded performance. Signed-off-by: Ola Liljedahl Reviewed-by: Honnappa Nagarahalli Change-Id: Ia94d6f3a0528f57e0dbca528cea40cb1812f6a8d --- /** Email created from pull request 182 (WonderfulVoid:api-next) ** https://github.com/Linaro/odp/pull/182 ** Patch: https://github.com/Linaro/odp/pull/182.patch ** Base sha: e344e4364f771f32b86d822d0c447770588fe65d ** Merge commit sha: 4da50ba5dcced1e50a032d61d21617b7e5095a6e **/ platform/linux-generic/odp_packet_io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_packet_io.c b/platform/linux-generic/odp_packet_io.c index bf792a340..64ec1f670 100644 --- a/platform/linux-generic/odp_packet_io.c +++ b/platform/linux-generic/odp_packet_io.c @@ -702,12 +702,13 @@ int sched_cb_pktin_poll_one(int pktio_index, if (odp_unlikely(pkt_hdr->p.input_flags.dst_queue)) { queue = pkt_hdr->dst_queue; buf_hdr = packet_to_buf_hdr(pkt); - if (queue_fn->enq_multi(queue, &buf_hdr, 1) < 0) + if (queue_fn->enq_multi(queue, &buf_hdr, 1) < 0) { /* Queue full? */ odp_packet_free(pkt); __atomic_fetch_add(&entry->s.stats.in_discards, 1, __ATOMIC_RELAXED); + } } else { evt_tbl[num_rx++] = odp_packet_to_event(pkt); }