From patchwork Tue Sep 19 13:45:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 112986 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp4937694qgf; Tue, 19 Sep 2017 06:47:11 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCTfOBmWQYFT6c9fmaQ3SpaanessVjavH/L1acZMpiup+ZvvCrxPUWGbN6zlNtgoIMAPWlY X-Received: by 10.28.103.195 with SMTP id b186mr1243389wmc.86.1505828831850; Tue, 19 Sep 2017 06:47:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505828831; cv=none; d=google.com; s=arc-20160816; b=FG2CxNjdPpeail2wce7jHngjWWwuONPgdDIh9oCCuIymZjgm6LF4zVjLXZbIz+fiVp 8nWqDu4fAIpJo/9qSRTuR5rC2pJQ8iSrSDoNRrynnVdCLE7Ky4FF8LIun6u4KJxf9Btt SvOQigyy4cS7NOrvz3lXT8z4IBhcE3u4PePUXVrKD98GvL+3L1R5CuJn2WM46Q27MLLk K7Xl4Ok+KUHctiui7UJhO0pDCFelUOHl0S9XnR5ojGg+71mJ7Ox9Uqeux6XkNGvzyhsm ZjFPMcOY2DkDVzOL1oAXcJlMGDRRnz2fiNHClhj1qImjzCbHG7jV7GC5Ei/r2b1FJnYv alcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=Zt6DdMdinCgTsEVObHhM40j/tqQEBse0xyjvFls3iHs=; b=KvzaJ7zF3A6qj5Qy3wZBU3JjiBP2cVZCMru7BoWlbRDXiSDXJm++5bvaxjAplu/Dmu DyUSJjph+vDWQgfRsvmcq0B5JRtxH2iJMOi0lVqBhKNxOdFGGW8Ila98/IFuF7Qf1mbD S7//VgTgSR72eehV3AdbgtTAm0On/D8gZC5J+a+p5AmQNbNhlHbtuZRIYuAqy8cpkPe1 7CqcfOAwmYheyIl6F/+JEyEYQRN9LyVZ1q5Ddv3trTaV/oEmUsgPZUEo2Dlmq+7jL6kZ BaWJnCDG5FLyxIlBsNWcujmbJml0fdIvohOxawrg0I4S5K2MKv8mndQLDtwFrlSUVIAw yvwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=jHvJpq+E; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id p105si7617405wrb.514.2017.09.19.06.47.10; Tue, 19 Sep 2017 06:47:11 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=jHvJpq+E; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 283C52673B2; Tue, 19 Sep 2017 15:46:03 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id CAB03267374; Tue, 19 Sep 2017 15:46:01 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_NEUTRAL autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id A9EDB26739D for ; Tue, 19 Sep 2017 15:45:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=TJQCVDzd8cI48uccD5i+I1kL2TsrWf+rod//ZU92xpI=; b=jHvJpq+ExFt/ 45moyQDHAFpIbNK2qy1/yLfH9ky+qhzuz2fnpZF90o68Z04M8TVcseqnlc7KrfJ4SmMa0mkKJZMQA M4ydrMOzYH1xGeF1b/B0iQf5tCPi4KDRcBhqVTOJA4zX+WDTtf08vShMU8l7ippHEfSsV8RU8DjQe RVpOk=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1duIqV-0001NB-5S; Tue, 19 Sep 2017 13:45:51 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1duIqU-00087E-OU; Tue, 19 Sep 2017 14:45:50 +0100 From: Mark Brown To: Pierre-Louis Bossart In-Reply-To: <20170908051309.19028-2-pierre-louis.bossart@linux.intel.com> Message-Id: Date: Tue, 19 Sep 2017 14:45:50 +0100 Cc: alsa-devel@alsa-project.org, tiwai@suse.de, liam.r.girdwood@linux.intel.com, vinod.koul@intel.com, broonie@kernel.org, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com Subject: [alsa-devel] Applied "ASoC: max98090: reduce verbosity on PLL unlock" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: max98090: reduce verbosity on PLL unlock has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From d10a7d3e2af98e639e74c64185f910915a560f07 Mon Sep 17 00:00:00 2001 From: Pierre-Louis Bossart Date: Fri, 8 Sep 2017 00:13:03 -0500 Subject: [PATCH] ASoC: max98090: reduce verbosity on PLL unlock 'commit b8a3ee820f7b ("ASoC: max98090: Add recovery for PLL lock failure")' enabled a workaround PLL unlocked issues, but generates annoying dev_info "PLL unlocked" messages at a 10ms rate, usually on startup. Move to dev_info_ratelimited. This issue doesn't seem to impact audio functionality. This trace is commented out in the GalliumOS patches, it's better to keep it to check on potential quality issues Tested on Lenovo 100s (Baytrail Chromebook) Signed-off-by: Pierre-Louis Bossart Acked-By: Vinod Koul Signed-off-by: Mark Brown --- sound/soc/codecs/max98090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 13bcfb1ef9b4..f5075d1f79e6 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -2115,7 +2115,7 @@ static void max98090_pll_work(struct work_struct *work) if (!snd_soc_codec_is_active(codec)) return; - dev_info(codec->dev, "PLL unlocked\n"); + dev_info_ratelimited(codec->dev, "PLL unlocked\n"); /* Toggle shutdown OFF then ON */ snd_soc_update_bits(codec, M98090_REG_DEVICE_SHUTDOWN,