From patchwork Thu Apr 30 12:41:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudarsana Reddy Kalluru X-Patchwork-Id: 220223 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C74AC8300A for ; Thu, 30 Apr 2020 12:41:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F55E2072A for ; Thu, 30 Apr 2020 12:41:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=marvell.com header.i=@marvell.com header.b="fn2/aw6X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbgD3Mlu (ORCPT ); Thu, 30 Apr 2020 08:41:50 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:16940 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726677AbgD3Mlt (ORCPT ); Thu, 30 Apr 2020 08:41:49 -0400 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03UCfHDe007452; Thu, 30 Apr 2020 05:41:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0818; bh=P9RqNQ3ZW1xcDzu1No5qu1M4+LnuFtCTMBpM3v2W5+Y=; b=fn2/aw6XCaJmxijQHjtip6MRqz4sFlSl16MY4PjxVwozhgbQAMs/rh9elxLt8cts50m+ YdgE9nUyBbN1vfzlFWIBo75JZY5lnfnZnSX7pG+yX6zk5PifuWyg97zcnkjOXFirjPY2 PlQdtyUOXZr5kmcBapIbiEYpkouUh/qNn9X5uWXSAH04lg1W9bsNy4Td7Ne0EqFHfn6B nJ4yEA8tJKK2XG14uCYaSqcsv4Jbkjd9dJwLyaJnhwPXNyAuYgyvnr7RwIPBErkbzdm7 A/wzaAVYQgSK688zsvfC/QRZ9MV/Xqegq2GdflsZ/45lx1rNzZkbZ68rlrE6llIum+co Ww== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 30mmqmx0af-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 30 Apr 2020 05:41:45 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Apr 2020 05:41:43 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Apr 2020 05:41:43 -0700 Received: from dut1171.mv.qlogic.com (unknown [10.112.88.18]) by maili.marvell.com (Postfix) with ESMTP id 64BBD3F703F; Thu, 30 Apr 2020 05:41:43 -0700 (PDT) Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id 03UCfhnc003031; Thu, 30 Apr 2020 05:41:43 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id 03UCfgKg003022; Thu, 30 Apr 2020 05:41:42 -0700 From: Sudarsana Reddy Kalluru To: CC: , , , Subject: [PATCH net-next 1/1] qedr: Avoid DB recover entry deletion when device is not active. Date: Thu, 30 Apr 2020 05:41:10 -0700 Message-ID: <20200430124110.2964-1-skalluru@marvell.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-30_08:2020-04-30,2020-04-30 signatures=0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The doorbell (DB) recovery entries gets deleted by the QED driver when QEDR device transition to non-active or dead state (e.g., during the AER recovery phase). The patch adds driver changes to skip deleting DB recovery entries from QEDR when the device is in non-active state. Fixes: 731815e720ae ("qede: Add support for handling the pcie errors.") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Igor Russkikh --- drivers/infiniband/hw/qedr/verbs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index a5bd3ad..7e10f3b 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -672,6 +672,12 @@ static void qedr_db_recovery_del(struct qedr_dev *dev, void __iomem *db_addr, void *db_data) { + if (QEDR_DEAD(dev)) { + DP_VERBOSE(dev, QEDR_MSG_FAIL, + "avoiding db rec since device is dead\n"); + return 0; + } + if (!db_data) { DP_DEBUG(dev, QEDR_MSG_INIT, "avoiding db rec since old lib\n"); return;