From patchwork Thu Jun 25 20:13:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 217109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27199C433DF for ; Thu, 25 Jun 2020 20:13:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1CFF20767 for ; Thu, 25 Jun 2020 20:13:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="Swty/C63" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404922AbgFYUN5 (ORCPT ); Thu, 25 Jun 2020 16:13:57 -0400 Received: from mail-am6eur05on2051.outbound.protection.outlook.com ([40.107.22.51]:6061 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2404386AbgFYUN5 (ORCPT ); Thu, 25 Jun 2020 16:13:57 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PDyRBo18RWzPN198F6M2p+/c9zyeewqeVbyGYbDcPe3WcrZZkI/txCfPXJa+aVz5KKAmQfVxR5iu99JWHjLsrAlYADkQfBN41AkiM/emfK9qTbk0htAs2SdjzagyVMmh7GdOr/34b5RSexpq1WeHvQC1Jjyc2DFi4RJRU1nPL5lFUYPGJv3jSPN8Gr7mfWXI6neUfwT1VkWx8kuE0xzGb7tHFyh2ZXix7Etg6Z4WtSyXI6TPUMo5QHvH29gspTJD99uaumLCpX/FoK3lBYW3CljLH+GpS1tvDKIOK9g0WFMYkxQBf9eygC6JanL3dmOkrBDixrVZDmgZjNopX5dfHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=571NT07tMexOGWUDw9lkMSfLxuBGVsPtYDngHakIEl0=; b=KAljc9VZwNEMs2DsanzkaCP4YOlhoNZXugWxXi5+H1wuXNXeaSpIw35qaoNp0uDTl05nMtOppIP5jAJI9XJU2HbrJeD1Vz1kDl5Uoe6S5LiFQ/eJQZkJdSi74gofO871k04SoK+zZJ/SaMGFqlXtEylty7VyYiLwFMqwLjyZHnFmpDJ5sI8qe3wdyz5TAJ2OKEd+4w1Izx+R1KGSkBDja6ekQuEZSJMASHOqg18dOhTU6u/yfdQLrqTGPZq7pjUSs+tLg5VN3IrQ7OKzWW5KOtj4dXSVGMVUbUCPEyHcm1v1wvky6C3xGP8vqKP5qcHfJ87/b1hy3h2CQ3S+qLRgEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=571NT07tMexOGWUDw9lkMSfLxuBGVsPtYDngHakIEl0=; b=Swty/C63KPrhetGGOdige0ylfLnH8Amtnyf3Q6/xrx6UjG2qkazKl+lGQuaGwiGd89nuYgAv7xnUEVbL2M3bRn2L1A2YSfugj2m8UBT1ab1vzjsx3ZBGxzi5/ZRkwrz4WY29wGqhA0LIz7C79bZ8gYGinPXGVugZpui3Xc22eOY= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) by VI1PR0501MB2448.eurprd05.prod.outlook.com (2603:10a6:800:68::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Thu, 25 Jun 2020 20:13:51 +0000 Received: from VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c]) by VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c%2]) with mapi id 15.20.3131.020; Thu, 25 Jun 2020 20:13:51 +0000 From: Saeed Mahameed To: "David S. Miller" , kuba@kernel.org Cc: netdev@vger.kernel.org, Hu Haowen , Saeed Mahameed Subject: [net-next V4 2/8] net/mlx5: FWTrace: Add missing space Date: Thu, 25 Jun 2020 13:13:23 -0700 Message-Id: <20200625201329.45679-3-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200625201329.45679-1-saeedm@mellanox.com> References: <20200625201329.45679-1-saeedm@mellanox.com> X-ClientProxiedBy: BYAPR06CA0005.namprd06.prod.outlook.com (2603:10b6:a03:d4::18) To VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR06CA0005.namprd06.prod.outlook.com (2603:10b6:a03:d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Thu, 25 Jun 2020 20:13:49 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d135e368-9cca-48cc-13d8-08d8194446dc X-MS-TrafficTypeDiagnostic: VI1PR0501MB2448: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-Forefront-PRVS: 0445A82F82 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rhQnvyIyQmFs7jPnyiKOOoTBdoZYlM5s/cUTyWD1bfvg9dpT0S706YCVVr4aCFYb6ZoO1Py5wTVG9UBulY5Mr0Xi/POxYTkuXnwbz6Hq4G6zn8Aa683uOsNpPXzPoDCjd/qBpOxDuJhyHRAR3umG3RMWOfWrYoq7jDONgcknSLFQliUyYhTW9ebH/qFXPbuyoLvWwTBG3DgF6jWFnRob6XD+tcWXa758pW3FVF7s2ctTrbduOVeVAXVFdcAI+yKyx8ETzDr6K4Q5JBrM+I/pH+Qk/qUjtFwqgruceSdEbhMhuGZCcRw7uVq9MBVZTrnnCV8cbA36LRWsTs3ASy5B6HHyY9SFnDsqLXjc73s9dd8vzOda0wJ5CCa+MaLVCAXD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5102.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(8676002)(4326008)(2616005)(6666004)(1076003)(316002)(956004)(66476007)(6506007)(186003)(8936002)(66556008)(16526019)(52116002)(66946007)(26005)(2906002)(54906003)(6512007)(478600001)(86362001)(6486002)(5660300002)(36756003)(83380400001)(107886003)(54420400002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: oVZTxmeg48g7j0TzyiF95AELnUl+uBAnwk9FgxgxoTr8s8sDKJeiaxwb13tq1Ww8gtDs3eFMS+TsqbDeMHj3tlPmGssLPj4R77DGDZvlwMrAWaZoqAf7O1clSAq0NNInP9DMy3z2AzFw8ctgHF40KMNspkqGRgytYqglYoqL+ELH7aOoPvgmCbudpUadcnochJOVfYcHXEJmqqsjmOxJFLLdV0CqXantkXnZEJFdfNOR/TqmfgRZrxZyoSvHyOSUvyZIisu658PRXoWcnIFWdYMRwOytcyd4sb03tqA9ZI2CgtRi/rh4NLvRi1daLNO/LA/A6Cpy+GVjroBNsoMEd+pcQvTOyi/yz80CDIrtuhZPHgg96E1whSuwNRcrkZneyvrULuzYW4GPvweR5aiTQWmr+Cep5vwUji9XpUL5O7Hi2oPqhIba7KOYE5kE8wxZaeeqBTlcKHMWxWkx/OxuBwUSnUydD6ROW0NuoaysiQw= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d135e368-9cca-48cc-13d8-08d8194446dc X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2020 20:13:51.7539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DPN/bXU1Hzl45woipfghtbNNr9MEv/Ac2dWAy4BltRvVV53VWWM1uEHVxCsvW0FXh3YCaSwsgkMrubZklcLbpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2448 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Hu Haowen Missing space at the end of a comment line, add it. Signed-off-by: Hu Haowen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c index a7551274be58a..ad3594c4afcb5 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c @@ -676,7 +676,7 @@ static void mlx5_fw_tracer_handle_traces(struct work_struct *work) block_count = tracer->buff.size / TRACER_BLOCK_SIZE_BYTE; start_offset = tracer->buff.consumer_index * TRACER_BLOCK_SIZE_BYTE; - /* Copy the block to local buffer to avoid HW override while being processed*/ + /* Copy the block to local buffer to avoid HW override while being processed */ memcpy(tmp_trace_block, tracer->buff.log_buf + start_offset, TRACER_BLOCK_SIZE_BYTE); From patchwork Thu Jun 25 20:13:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 217108 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B13C433DF for ; Thu, 25 Jun 2020 20:14:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92DBE20767 for ; Thu, 25 Jun 2020 20:14:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="IDWqr4xO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405136AbgFYUOE (ORCPT ); Thu, 25 Jun 2020 16:14:04 -0400 Received: from mail-am6eur05on2051.outbound.protection.outlook.com ([40.107.22.51]:6061 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2404386AbgFYUOC (ORCPT ); Thu, 25 Jun 2020 16:14:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Htz0iTMHp28/q01TFB4F0W46syQas6OVyK6Zd1qIP3/tjptXsf61ciaq07gRzFpy7rI/meQSIFlD5XCqLOwPmcbL9Mf2D6kZSmWodqTFEGzvRoCa0vMs5Rr5PT/pwVLHA5Bmor/xiP+b2NI92d5dZqfcsYcNNKKnNmyVqbLszXdBr5V8+kOdagAEKYJ1nZSgJkR5Fd8mc6jHP6rssIzvaopey4pvLrmJn4Bo7F7ya60RcIn6mBc8yMV26YUv1aCh+fY8cl9T1Ed06isCBY6P1gKdUblJdEFqB4yN291ueDVHvlhy7vYEDYt/yEfJDcxEJXDQJ54DcZtc5Xg1nQdnIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MvlrTmQHnXAEK9ooKha8cL1GrEdP0cdhD8iDygZfaQ0=; b=hHlpkW+oJoxzwem0v+GY0EDZjzgtbXi1+mE2twIb/ZzWi3FdEDEd2ieke1sdmT5d3LTabLTA2vymx53xeb5XJRcr0NkPUIp6S6gQUpZYE4p+cTqwnM4o4ovplgzM1F5eW782Vj/eKXcfjpM/cADxEmvnIahGhLkcmlQgd5ni37aHmbjMh8uOLIBbtUVhiVRgyXz4EHJCzy7sBevEsMWR8Ca4LNDkueA4SBs7L7NQwEH4vTfYMJyfOumZP69I+Nw5sBe7/bGwjH+WKy0jnN7Jq8p1u1wlG5r+hk8LpmWZCr3xHATa3i0Iw0DaybJFg3IXiZ0wbbSo23EFuq69q7fvPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MvlrTmQHnXAEK9ooKha8cL1GrEdP0cdhD8iDygZfaQ0=; b=IDWqr4xOZyqQpQQaISSgVU8N1s1NgjQbe81kmd8H5ZMAQdP5EA2tzO0nnB+qZoAsuNEtQ2IlM0BDPZ1MYNxCtEa7Y2vflH/Y290Ogl/zUx0SM1gTETAvmIORVXrSqa5MLtY4ci0Xsi9Pe2KRrQ0YLtgGF1jAeDpBH2b5g2WdFog= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) by VI1PR0501MB2448.eurprd05.prod.outlook.com (2603:10a6:800:68::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Thu, 25 Jun 2020 20:13:56 +0000 Received: from VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c]) by VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c%2]) with mapi id 15.20.3131.020; Thu, 25 Jun 2020 20:13:56 +0000 From: Saeed Mahameed To: "David S. Miller" , kuba@kernel.org Cc: netdev@vger.kernel.org, Maxim Mikityanskiy , Saeed Mahameed Subject: [net-next V4 4/8] net/mlx5e: Remove unused mlx5e_xsk_first_unused_channel Date: Thu, 25 Jun 2020 13:13:25 -0700 Message-Id: <20200625201329.45679-5-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200625201329.45679-1-saeedm@mellanox.com> References: <20200625201329.45679-1-saeedm@mellanox.com> X-ClientProxiedBy: BYAPR06CA0005.namprd06.prod.outlook.com (2603:10b6:a03:d4::18) To VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR06CA0005.namprd06.prod.outlook.com (2603:10b6:a03:d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Thu, 25 Jun 2020 20:13:54 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c441248f-4fea-45bf-acb2-08d8194449ee X-MS-TrafficTypeDiagnostic: VI1PR0501MB2448: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:162; X-Forefront-PRVS: 0445A82F82 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zvJRk66FooqM9kQInzij5Qz7t0lidan2g35DPTDm5KgkB0WBUkpMmAm9Nmt8H9TW1w324h1w9M0LzclSYkUeYO5+tSSt1G4Ffj4MQjU32trWpi+k1ygOZpP8QfnMsZde0bubVN2911KYvd/U5/ktRZetXMA//ikbpFgUhuoUcg/1xkvJ+F24/pEogEPdJCGMth1khNKQHUvO1d76SuW5vW8dcdcEs5aHjKaMcA/T4oAZGO8RiP4Ig+FecLm2bI9wL0LGX00gqWJRcL8Gs+Rz0ykzbDS2iGxssQklpG/8ZgpBHUni/Cw2j/aHZK9QLdr2L8GOhwLMXhpDfBjsTu30g2OI0l3T5NjPkEX/L/OwxPIg8w77q1QzqDrER/s6uogT X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5102.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(8676002)(4326008)(2616005)(6666004)(1076003)(316002)(956004)(66476007)(6506007)(186003)(8936002)(66556008)(16526019)(52116002)(66946007)(26005)(2906002)(54906003)(6512007)(478600001)(86362001)(6486002)(5660300002)(36756003)(83380400001)(107886003)(54420400002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: y575hMQ45PYILltqVDS7OVjw8XmdpvrNJBbZBxxp+F1HzTJ09TKC6pCpC/JT+YxWDX3AQH6+AJcoww6WkHPVcQbnO/7BPkXyMhoxhfy2UD9yElRm0zQL+k8jSVJBlK75K2qPrBX1iRhLpAtI5ipJE15GvddtrIKObq0WKHKoAd7sqSP/ojtQ10q5rHNh/VA5HRDS3l/BeFemzU67tnU84POtlRChExe4caVmg/aQa1mkF5nrcmvnirRvZiXIAamIJtwOXx/IlKtXGzSvZSqpa/kC3VnEYp/UGaDHEhydywEf3Z5wevxLGBxAVPK8SAdlIfzDDNs4m5WlpiN2dxkAgcdwO2Hagb9lczkUWtkPHrFjWtMVbsrra7OynSriCkFL5yYy5mO3AoZ+vgY31hhwlt7dtlbu8p6UTqpSf9V0a+MVyKirwPxsTfeU0fuvWtr3WkBhjMLhomyP0nEgs9K3u9FwyZQb03ujh6zO78bkmQc= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c441248f-4fea-45bf-acb2-08d8194449ee X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2020 20:13:56.6141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QdYFnO9L14qXY7otaBOU6do1m+A67MYIx8aMVWlNneCBKR6lY6AfE5WnVvj+8OAGjbagdUJYQpeCWj4zI1vy/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2448 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maxim Mikityanskiy mlx5e_xsk_first_unused_channel is a leftover from old versions of the first XSK commit, and it was never used. Remove it. Fixes: db05815b36cb ("net/mlx5e: Add XSK zero-copy support") Signed-off-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/xsk/umem.c | 13 ------------- .../net/ethernet/mellanox/mlx5/core/en/xsk/umem.h | 2 -- 2 files changed, 15 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.c index 7b17fcd0a56d7..331ca2b0f8a4a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.c @@ -215,16 +215,3 @@ int mlx5e_xsk_setup_umem(struct net_device *dev, struct xdp_umem *umem, u16 qid) return umem ? mlx5e_xsk_enable_umem(priv, umem, ix) : mlx5e_xsk_disable_umem(priv, ix); } - -u16 mlx5e_xsk_first_unused_channel(struct mlx5e_params *params, struct mlx5e_xsk *xsk) -{ - u16 res = xsk->refcnt ? params->num_channels : 0; - - while (res) { - if (mlx5e_xsk_get_umem(params, xsk, res - 1)) - break; - --res; - } - - return res; -} diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.h b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.h index 25b4cbe58b540..bada949735867 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.h @@ -26,6 +26,4 @@ int mlx5e_xsk_setup_umem(struct net_device *dev, struct xdp_umem *umem, u16 qid) int mlx5e_xsk_resize_reuseq(struct xdp_umem *umem, u32 nentries); -u16 mlx5e_xsk_first_unused_channel(struct mlx5e_params *params, struct mlx5e_xsk *xsk); - #endif /* __MLX5_EN_XSK_UMEM_H__ */ From patchwork Thu Jun 25 20:13:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 217107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D53C433DF for ; Thu, 25 Jun 2020 20:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99F1220767 for ; Thu, 25 Jun 2020 20:14:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="tTuJIrzy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406879AbgFYUOM (ORCPT ); Thu, 25 Jun 2020 16:14:12 -0400 Received: from mail-am6eur05on2071.outbound.protection.outlook.com ([40.107.22.71]:6196 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2405218AbgFYUOK (ORCPT ); Thu, 25 Jun 2020 16:14:10 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FnUJIWrs/mvkeTuaMaBG2AwbuduLd7J71PnEXSjn4ldtZY9ToVoSAofv5nyn5tRPnUVTdR+Js36lvjQu2Zrg4eQjFRO0GukjY9qRGx6Boq9LRKdxJ00T9C7URfzLEMf1yzjbd+zHXewQXwPQZIplSs3NUjzIDopfn54fCpUXIEt6PhZLCzVPSyQUikzYetN5HiVJisxqgsVV9cQsOTJT7+SpCpPxmePc2dp6eP80HUVjq40/gjfSvEcjs0eEhAxxmH2Dv/KW3Hly4pchD0amq5uTzMPyyxP5itKpMSX7NjUMJG+IvOuMrjozSfvSf4lwb8zFLB2/GNlMt9p1HeERnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z1ulmEsLk87aPuwLqOA4+/0tBo0bloH/+X64+wQ9dqk=; b=dBSOhbt3srq0mtmUNxKXcTw5VNVlNozsV65Vh0lTQ7j9gw068gJBszyZ7V6mrNC5LPKJDTZKgneRpzw7HXkBgfB3zlz6GoxPP7/jkbRdohYCxpWEP0N+tHZ0bPaUTF1SunBGNH7eJgzMFgHQr0+I79RvWT+Q2PBzHUn+W9hsG29hlwOUFjmkTzwLQMpYSsaQlUWhGcz4PdKe96GgIPyOtqUzyuECQ0QAmsqQCbrAaBIHT9SqVh+l9EE2T3OSN4vFHa5oEPoREGGN86uQgwg2BsEY6KTO1feWp6LO9iYBDli+AiBqVi4QRzQjBA9R4n7yfu05P87mzj+Sb24mxp80Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z1ulmEsLk87aPuwLqOA4+/0tBo0bloH/+X64+wQ9dqk=; b=tTuJIrzy9wLlTXdlfbB0ncans+GcZvNCnnGGyuAqivzjVSRapV1TmXl2/mEe1GeYxX2xBGUFcfEppwZa5DF22/LN2/hbHhJsCXkUSPH4Q+TDvA0k1dQqgPPM/e9tizlo0IXNRjAQlcvTdl2g9Inx8P1coJQZyuRZDjo5r/QLPq4= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) by VI1PR0501MB2448.eurprd05.prod.outlook.com (2603:10a6:800:68::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Thu, 25 Jun 2020 20:14:01 +0000 Received: from VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c]) by VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c%2]) with mapi id 15.20.3131.020; Thu, 25 Jun 2020 20:14:01 +0000 From: Saeed Mahameed To: "David S. Miller" , kuba@kernel.org Cc: netdev@vger.kernel.org, Vlad Buslov , Roi Dayan , Maor Dickman , Saeed Mahameed Subject: [net-next V4 6/8] net/mlx5e: Move TC-specific function definitions into MLX5_CLS_ACT Date: Thu, 25 Jun 2020 13:13:27 -0700 Message-Id: <20200625201329.45679-7-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200625201329.45679-1-saeedm@mellanox.com> References: <20200625201329.45679-1-saeedm@mellanox.com> X-ClientProxiedBy: BYAPR06CA0005.namprd06.prod.outlook.com (2603:10b6:a03:d4::18) To VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR06CA0005.namprd06.prod.outlook.com (2603:10b6:a03:d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Thu, 25 Jun 2020 20:13:59 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2eafda3c-30f8-49b0-9810-08d819444cc2 X-MS-TrafficTypeDiagnostic: VI1PR0501MB2448: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:257; X-Forefront-PRVS: 0445A82F82 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rlboZRtBr1FdKa9OttmDYOsCXmx4KF5OPdkRCYJ+pGa44Sbkbacl+z92/KMfhIxQtN5rSbeD4uO/ICjehzeKquTdF/bG8EVQFiX/eVz85Zkfvh0CcbhoGoXS/6pJACMOWIIY2rOJE2RsAlDCMdKZwNBnIplX81+pha7r7MGaTMSY5WgC9ExwGdQ5aVwwIPw438IBygbjccRh/fjaA52Uc/Cu2hb0oMhU8Fka1XDqQSdZuTX66oVCLreuAFx3wE7B/Bu7TDc2/V9FVMDhcYiVkSBZsvekzz2RIrPl6NYrfxmmXSvtDrO3v4CRvv7QPt1qdPL5S/gqYbW/5l6RI0f+EyLteW4uB27l1bCQwf2N8cBhqJOJwKP8bwSVPVeznamz X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5102.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(8676002)(4326008)(2616005)(6666004)(1076003)(316002)(956004)(66476007)(6506007)(186003)(8936002)(66556008)(16526019)(52116002)(66946007)(26005)(2906002)(54906003)(6512007)(478600001)(86362001)(6486002)(5660300002)(36756003)(83380400001)(107886003)(54420400002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: zWWR+pPwxaNdf/cxaVQp9UA92FJznxnLPK53tfMI0z/PAXD8xYLr+xQZMFuj+34Wi8LfPjZe7A+cdul4gzOeEpxQ8SyiSCC0JuoxCCU9GZ5uagD//wQZX7RmwGm+FR1n7gGDyNROapELLYbUQ3nXTI8nQOBTPTpMeG3BBCadPJaaM3qi3JIxuo+HwrzOO+VnkQfsrz44wRYvfr+TjM4ksXMbq6Aa+1FNa3M1Wo1wQ+Kt6IW/soS/Iy9NxOEHtKJx6orLO2MXHvpvcWwtjGo5tvJwA+VUJuhFZm8a0O69VkWSaxnoTpE5Jrcz29IEQixstefezGhwUsDQdgX4tQ80Hi6FK1oEILu1JnvPRmKvMR/wJ/fDv9IrlO4rcAemTeKdrK9uQgcSNoJ34ggT6hiJGS49oDZK3baCw5m7xRv986c1l5R02JhFhF6JrlVRf8iTw14TflNqMm19Pl5vGSOLoKqgzmAjUSuXiUQY0HQhIM0= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2eafda3c-30f8-49b0-9810-08d819444cc2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2020 20:14:01.3344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EoEHE2eRhsEU3vm58M2sqQP0huKi22gJQl/EyO9HAD2A9mbsXLU2s/tzthh2XZjm0bN5NDcb899C10KdV3xqTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2448 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov en_tc.h header file declares several TC-specific functions in CONFIG_MLX5_ESWITCH block even though those functions are only compiled when CONFIG_MLX5_CLS_ACT is set, which is a recent change. Move them to proper block. Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Reviewed-by: Maor Dickman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h index 5c330b0cae213..1561eaa89ffd2 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h @@ -40,6 +40,14 @@ #ifdef CONFIG_MLX5_ESWITCH +int mlx5e_tc_num_filters(struct mlx5e_priv *priv, unsigned long flags); + +struct mlx5e_tc_update_priv { + struct net_device *tun_dev; +}; + +#if IS_ENABLED(CONFIG_MLX5_CLS_ACT) + struct tunnel_match_key { struct flow_dissector_key_control enc_control; struct flow_dissector_key_keyid enc_key_id; @@ -114,8 +122,6 @@ void mlx5e_put_encap_flow_list(struct mlx5e_priv *priv, struct list_head *flow_l struct mlx5e_neigh_hash_entry; void mlx5e_tc_update_neigh_used_value(struct mlx5e_neigh_hash_entry *nhe); -int mlx5e_tc_num_filters(struct mlx5e_priv *priv, unsigned long flags); - void mlx5e_tc_reoffload_flows_work(struct work_struct *work); enum mlx5e_tc_attr_to_reg { @@ -142,10 +148,6 @@ extern struct mlx5e_tc_attr_to_reg_mapping mlx5e_tc_attr_to_reg_mappings[]; bool mlx5e_is_valid_eswitch_fwd_dev(struct mlx5e_priv *priv, struct net_device *out_dev); -struct mlx5e_tc_update_priv { - struct net_device *tun_dev; -}; - struct mlx5e_tc_mod_hdr_acts { int num_actions; int max_actions; @@ -174,8 +176,6 @@ void mlx5e_tc_set_ethertype(struct mlx5_core_dev *mdev, struct flow_match_basic *match, bool outer, void *headers_c, void *headers_v); -#if IS_ENABLED(CONFIG_MLX5_CLS_ACT) - int mlx5e_tc_nic_init(struct mlx5e_priv *priv); void mlx5e_tc_nic_cleanup(struct mlx5e_priv *priv); From patchwork Thu Jun 25 20:13:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 217106 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FBB7C433E0 for ; Thu, 25 Jun 2020 20:14:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66A4A20767 for ; Thu, 25 Jun 2020 20:14:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="EsNWSJHS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407067AbgFYUO3 (ORCPT ); Thu, 25 Jun 2020 16:14:29 -0400 Received: from mail-am6eur05on2071.outbound.protection.outlook.com ([40.107.22.71]:6196 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2406983AbgFYUO2 (ORCPT ); Thu, 25 Jun 2020 16:14:28 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RGykFIFQMRJbXUdvCTDE26//mPIviii9AB4XluPeosSvusYzVuVpH+rafePDyEIB0nYR32H/5x19ay00CkYaBTT39Q3jV+/z7GmoAUOKq0zz3AghYtkC3wbZQZAT2mfdJRp67yOOmjZCaNnAceqNVWdMYlRt9FIXQrEEIxiCS5xXsPX4UYV5qbyqCI69FqPLJTbBQ+Lx8VOVIs9i3O8RA0ELTo9Xwdhz0Ths0kwx2JPKpEmpSEBn/gDBo/eEI8gK2BPtuVLzg8HQ6waMgKXCNCqZmModSEmaZnYCBSnds/f9ftSP+LITjTjIGDp0a85SmSB57XSJVaAz49MSK4uPiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xO3DnVWv1QEqusc+nGUHwMvFvdcoYJPgoujYQZhZ7O8=; b=RUgZtgvopEQ5I7YfIeowSWk/ufKG3HwyK0wy1n0a7bgG2hMh7tXF8uPMwuImmOn3/fNY0iUPJgbVRQZ6A7R1QWqFAuNSZLE9Lkpow92Jqx936eRFQKjj5iZppIV8pNmDqc76ms2onkmnNwnelKYSTdBtRTeKYhnFhMSiL9UKhsdYb/8Iy+XGm/tDJzpBsVSi6r2By/JuLu30ctuAUGLN47nDuwuzSufuardTWhSbO+R9v8fMBwU5vrazaJP7kpmeqO5HuayWz1IkbcekKMslyR0MMUh/7R1E/XLcttzrDByeiMtYAROy+dgx0pE4Le22Do2YZNDmQLV6zocBNzXMHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xO3DnVWv1QEqusc+nGUHwMvFvdcoYJPgoujYQZhZ7O8=; b=EsNWSJHSp9f5CA6dAZC2kG16sPsmETcPcOAoPHX2QEtJQG2CElbgR5HnhnIJOpymBUA98U1VVfi+LyIhsH7KWeCBTkBo7o1CLfFpoUO9x29pW0G+ScpfKNvPQfi1pi+jNVznH7OILFCCNSC2YpfqPUQ5Y7hq1CcTfZD5ko2UCmM= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) by VI1PR0501MB2448.eurprd05.prod.outlook.com (2603:10a6:800:68::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Thu, 25 Jun 2020 20:14:05 +0000 Received: from VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c]) by VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c%2]) with mapi id 15.20.3131.020; Thu, 25 Jun 2020 20:14:05 +0000 From: Saeed Mahameed To: "David S. Miller" , kuba@kernel.org Cc: netdev@vger.kernel.org, Saeed Mahameed Subject: [net-next V4 8/8] net/mlx5e: vxlan: Return bool instead of opaque ptr in port_lookup() Date: Thu, 25 Jun 2020 13:13:29 -0700 Message-Id: <20200625201329.45679-9-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200625201329.45679-1-saeedm@mellanox.com> References: <20200625201329.45679-1-saeedm@mellanox.com> X-ClientProxiedBy: BYAPR06CA0005.namprd06.prod.outlook.com (2603:10b6:a03:d4::18) To VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR06CA0005.namprd06.prod.outlook.com (2603:10b6:a03:d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Thu, 25 Jun 2020 20:14:04 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a8b1b7f9-88b9-40ed-22c3-08d819444f6a X-MS-TrafficTypeDiagnostic: VI1PR0501MB2448: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 0445A82F82 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QmvM5W30FG5iQX9ZHPaLPDX4AvJ5jipKOcZNVqkv/47jZGBBpu2j3qQN4bB6cTnX/UBVA05JxhJl4jKEkd0jd6H0wkfkhZUYOGcvjshlM3EYGQ+3lEBTKI2BzpfnofSTI8A+8Vow6uQd1llaXjIFh8NIhlHjgpy6Xzr23PMTilqMZDjisk5Hdghi3M8gxVoIvMsMJ0gtTVQP881f6OQFG8SGYNOzzOzFqRGF8NGr0/mHMwUvXfU1z3WRcmKbQR3ARkSyCistC+mup1nBRgiBDuQZyaF6WWDt/dv/9BHRwBZtf3UxMnDkaKjXbEfbo4btxyfvDnQAWvVosm9qG4bkKpT8hZBraudf2xZs1nSniAX/5+lLS+Yrmoi3305fBV0EWEC3h5YdBJpHOHk12SX/nf8iI2Bhdm02QG2xTVCTC2Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5102.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(8676002)(43170500006)(4326008)(2616005)(6666004)(1076003)(316002)(956004)(66476007)(6506007)(186003)(8936002)(66556008)(16526019)(52116002)(66946007)(26005)(2906002)(6512007)(478600001)(86362001)(6486002)(5660300002)(36756003)(83380400001)(107886003)(54420400002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: uK2lhr4Gd1AqakyF/4vnebL6kgsn9tK3eJr7QfXmF3GmU5vhq5D0ircja4OnMhu1Ryr17M00XxS6Bwj8VOFENYb3yWrtjGt8szX2Gcx9q2yk19g8NLoAzUYtukweVgdMrlQsz6rBI1vI0/iT8SbYEmDPBhojfIu7jH6O1yj/aFBHtg4YxzCwMH5zPO4wWkoFVyKR29ziS6lHgKWDke8v2VarIBEgtW6tpyBrF+P9O/Y8wtEYUy27FYqJoPhyy7abD7765LnXQTY8FyynBrwIjS3tIWhr6UmKejwAT26cOGlQWLxDRxiR9AZqmC9zndLKibrZ/gH/FLwcRpjZdx8FkbUjY2qQCdgm+ijxLGvIQR3sKXtpDZ1aBL8qz91z2wRd4DqydJf6bbNAmALNNqLou0Mf8JwoJ16Eqw1rqyOpc7r1RApwGEZhCTMUdvKCMRYJ8cDtwBqqxAMpA+Sew/wZdaJdWY49tBbxzbuofA+1ibU= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8b1b7f9-88b9-40ed-22c3-08d819444f6a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2020 20:14:05.6669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZqEVIBX8yL311UoFG0hJLzz1w8Tb5yy2pYk1n7KE7UVmGExQCySWOs39e8jsj6Yy/ybY1qzCRNt/NnezeGmY8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2448 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org struct mlx5_vxlan_port is not exposed to the outside callers, it is redundant to return a pointer to it from mlx5_vxlan_port_lookup(), to be only used as a boolean, so just return a boolean. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c | 9 +++++---- drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h | 5 ++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c index 85cbc42955859..be34330d89cc4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c @@ -77,9 +77,10 @@ static int mlx5_vxlan_core_del_port_cmd(struct mlx5_core_dev *mdev, u16 port) return mlx5_cmd_exec_in(mdev, delete_vxlan_udp_dport, in); } -struct mlx5_vxlan_port *mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) +bool mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) { - struct mlx5_vxlan_port *retptr = NULL, *vxlanp; + struct mlx5_vxlan_port *vxlanp; + bool found = false; if (!mlx5_vxlan_allowed(vxlan)) return NULL; @@ -87,12 +88,12 @@ struct mlx5_vxlan_port *mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 por rcu_read_lock(); hash_for_each_possible_rcu(vxlan->htable, vxlanp, hlist, port) if (vxlanp->udp_port == port) { - retptr = vxlanp; + found = true; break; } rcu_read_unlock(); - return retptr; + return found; } static struct mlx5_vxlan_port *vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h index 8fb0eb08fa6d2..6d599f4a8acdf 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h @@ -50,15 +50,14 @@ struct mlx5_vxlan *mlx5_vxlan_create(struct mlx5_core_dev *mdev); void mlx5_vxlan_destroy(struct mlx5_vxlan *vxlan); int mlx5_vxlan_add_port(struct mlx5_vxlan *vxlan, u16 port); int mlx5_vxlan_del_port(struct mlx5_vxlan *vxlan, u16 port); -struct mlx5_vxlan_port *mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port); +bool mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port); #else static inline struct mlx5_vxlan* mlx5_vxlan_create(struct mlx5_core_dev *mdev) { return ERR_PTR(-EOPNOTSUPP); } static inline void mlx5_vxlan_destroy(struct mlx5_vxlan *vxlan) { return; } static inline int mlx5_vxlan_add_port(struct mlx5_vxlan *vxlan, u16 port) { return -EOPNOTSUPP; } static inline int mlx5_vxlan_del_port(struct mlx5_vxlan *vxlan, u16 port) { return -EOPNOTSUPP; } -static inline struct mx5_vxlan_port* -mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) { return NULL; } +static inline bool mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) { return false; } #endif #endif /* __MLX5_VXLAN_H__ */