From patchwork Thu Sep 7 15:32:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 111952 Delivered-To: patch@linaro.org Received: by 10.140.94.239 with SMTP id g102csp256526qge; Thu, 7 Sep 2017 08:34:01 -0700 (PDT) X-Received: by 10.98.252.216 with SMTP id e207mr3121788pfh.306.1504798441365; Thu, 07 Sep 2017 08:34:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504798441; cv=none; d=google.com; s=arc-20160816; b=AjWhq28d9uqb0dU4cWTgnKzkLql41Sv6gi/B1qX/3O3Bx8UEpuDnsJM4ZO3/OgTC9q TPx5V478LkKBINEpnrqpoFBTcsu/uBjGJ2u0ZuCtIl1U1TfnsDODWXzClFcaqffJLcEo oSk79EbRfbwDSS4MXzq8vtC2ElkkvXU3hmqxtLGpexBVFfFCrxQOkKaDAOj2MVqur4In X6pV9CoN/cg1qdRdla/yaaA7qkGzJnzfr+NJPPLTmky1U+fOzJJyE7j+OmsZO7b8KoS2 HzwcXKcXxauT6azDGuhkgrY9LsxiEnTFODNISzm3W0lJyXyrizmT6ZYMpiTy/Y2QsF9v kMrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=nIpZN0D2DDMSur5geICiy/XUzLai3G31hEAMKjtR4lI=; b=uOov6/906uFJ0Lvj3q+hcCmDmDooWD7ZqjOahCi6uR98/Q0sS4k5X+9l6dsbh02jGP WHw/vhUusxZIOF2VxikYxZ6q/leI8CbqavDrYukfDAwpnNXWSStXOZ3JBRcU38MZTZN+ gmst22UC+3hmp+5LWFz3a3ITKRCGA0YePa4JRb0CNkcd0l738BD5jRqCfwpT6N19hzYr jAC3KE2Rw2prU+8o4zjP5xtfkBaSxQGcJQSMcWhmlwiEOqqiz0cOB05HrrfNvVY8tBUU PtYZ2aFejcG88Ir7d+G856VxadrzZXURmFyQh2iDJRu9tPZbOfve/gsuU8r6lYltNc3A aoSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BFFsKTy8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 22si1923476pfn.426.2017.09.07.08.34.01; Thu, 07 Sep 2017 08:34:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BFFsKTy8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755466AbdIGPd6 (ORCPT + 26 others); Thu, 7 Sep 2017 11:33:58 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:35642 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754932AbdIGPd4 (ORCPT ); Thu, 7 Sep 2017 11:33:56 -0400 Received: by mail-lf0-f49.google.com with SMTP id d17so36612lfe.2 for ; Thu, 07 Sep 2017 08:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=nIpZN0D2DDMSur5geICiy/XUzLai3G31hEAMKjtR4lI=; b=BFFsKTy88vIIVVA8xXNvqVuXvO5YzXr1UT4svoCwdL8VxyhUAZKcnDgRM0A5JpPw+r 9ZYtWOrAKrgLYoHJ7E4CXFFij5hVJjQssb35YrKLTtgfNYmLfYD9xg0BH8KkhEWlRWRy Pdhhxg/JKF1z8Ay/yhLDn4MhTRvopqA4ONAbs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nIpZN0D2DDMSur5geICiy/XUzLai3G31hEAMKjtR4lI=; b=pjZ5oP8hyV9TheBllcmcGJ49yYVxNvRHsu0ayWKutE4vjTeeli7z5leDguMxfYs/Qv Yv7tpceil1aJB09IupEUP2DAr0NYWOCmJccDRmIbw5Sao0cgcCLUTLC0uvuFZcHgWeav KmDgy9G1i4NZSU/0u1m+MUF1+l5b3TUrdUZOeYaCbc9jVDGC7AiqrrWv4nX+9KPh/kTi F9UkUbMLZJK5wYQqKDgLRymmR2f11Ye+N5Dlc9C/J4Z+v9L34e3F0Arc0QtCG7bEBj20 jvBb97GCZ61QoF39w0iJeYE18Q4D6mAuEElAgMrbW9U8orgENyOPjkTkiGPgrixZ8ZV7 FKRA== X-Gm-Message-State: AHPjjUjb7fi6J3sSaWkqKRdUJ+EWVheqXXehGB3MwVtyYNC3NzopCQxv 5ynUaNHGeSzJCkMX X-Google-Smtp-Source: AOwi7QDxWlByQog+FX4hEUiguIwCZ1PzXUysP1R/PY88yKAeaE397yt737Cf4mvMNFWXtln60IFcdA== X-Received: by 10.25.221.93 with SMTP id u90mr1210912lfg.19.1504798435370; Thu, 07 Sep 2017 08:33:55 -0700 (PDT) Received: from khorivan.synapse.com ([2001:67c:2e5c:2011::77bd]) by smtp.gmail.com with ESMTPSA id a198sm441560lfb.40.2017.09.07.08.33.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Sep 2017 08:33:54 -0700 (PDT) From: Ivan Khoronzhuk To: w-kwok2@ti.com, m-karicheri2@ti.com, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, grygorii.strashko@ti.com, Ivan Khoronzhuk Subject: [PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del Date: Thu, 7 Sep 2017 18:32:30 +0300 Message-Id: <1504798350-790-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't remove rx_napi specifically just before free_netdev(), it's supposed to be done in it and is confusing w/o tx_napi deletion. Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/netcp_core.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.4 diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c index eb96a69..437d362 100644 --- a/drivers/net/ethernet/ti/netcp_core.c +++ b/drivers/net/ethernet/ti/netcp_core.c @@ -2145,7 +2145,6 @@ static void netcp_delete_interface(struct netcp_device *netcp_device, of_node_put(netcp->node_interface); unregister_netdev(ndev); - netif_napi_del(&netcp->rx_napi); free_netdev(ndev); }