From patchwork Tue Feb 7 04:10:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 93504 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp2023725qgi; Mon, 6 Feb 2017 20:10:14 -0800 (PST) X-Received: by 10.84.210.232 with SMTP id a95mr22815988pli.31.1486440613985; Mon, 06 Feb 2017 20:10:13 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 86si2774836pfl.85.2017.02.06.20.10.13; Mon, 06 Feb 2017 20:10:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbdBGEKM (ORCPT + 25 others); Mon, 6 Feb 2017 23:10:12 -0500 Received: from mail-pg0-f43.google.com ([74.125.83.43]:33802 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752696AbdBGEKK (ORCPT ); Mon, 6 Feb 2017 23:10:10 -0500 Received: by mail-pg0-f43.google.com with SMTP id 14so34616072pgg.1 for ; Mon, 06 Feb 2017 20:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qKXEjR8QkRisjKkI6wc7VXROZvkOYHLINPlpeYrW3sg=; b=Mz9KKAdEDfnvP51QuIfm4vujb4HJqiCsF/fSB3vbvochzBvtZZ1Hntq1DvFj5umjUA O+pwJZCXvwungpT2Od2RZvFe/BJKvHHl5z9JPrOywOqyk5lmFfX3T2wV33jtWtC9obzM uYHuiSEHd3arQeQIOa2CqKrd6O/yj1oKReWUs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qKXEjR8QkRisjKkI6wc7VXROZvkOYHLINPlpeYrW3sg=; b=lyfckkVGJ2gsR42E/oJ+xQTkWxg4zBU4Gl78CkIUdXNdPvbNN5LZ/f0QJ2HWjZRaq2 MjEZFiJ7u7Y/xoq7GgowOfh8r86Ow6ImmKh5dtjdxKYFeCykxjmXBX+h9jiIR2BM04Lo 6qBg6EsPrhKBRxCSIwVJMbSgvrroX4M7TrclMwAHb/lVh59jogj4WE+grVniGBtDLMPl 2HywBq4g36jAv/JdH1wwAbYuT6hfpic5+cuvdrw1CNjBRVBIgygIohOtOI7bZ/a+svPK 5QGejBwHiYgnLUywtOYz81T3lfK2N9Z8uJ76LTD15MDpjZCWSyuKhIBFV1i7I6PWNF9d ZTfw== X-Gm-Message-State: AIkVDXJUzfemgtTVzB/clXw/tphUY7XaGl6hEAcZcsojRNci6jixM/wWbZA4fe20/6mYjetz X-Received: by 10.99.104.133 with SMTP id d127mr17834585pgc.52.1486440610011; Mon, 06 Feb 2017 20:10:10 -0800 (PST) Received: from localhost ([122.172.165.189]) by smtp.gmail.com with ESMTPSA id p14sm6164445pfl.75.2017.02.06.20.10.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 20:10:09 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , rui.zhang@intel.com, edubezval@gmail.com Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , dan.carpenter@oracle.com, Viresh Kumar Subject: [PATCH V2 1/5] thermal: devfreq: Simplify expression Date: Tue, 7 Feb 2017 09:40:01 +0530 Message-Id: <79611a51240c83504c35a8739fe8e1837e903671.1486440448.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.7.1.410.g6faf27b In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to check for IS_ERR() as we are looking for a very particular error value here. Drop the first check. Reported-by: Dan Carpenter Signed-off-by: Viresh Kumar --- drivers/thermal/devfreq_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.1.410.g6faf27b diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c index ba7a5cd994dc..cf71550b9d00 100644 --- a/drivers/thermal/devfreq_cooling.c +++ b/drivers/thermal/devfreq_cooling.c @@ -222,7 +222,7 @@ get_static_power(struct devfreq_cooling_device *dfc, unsigned long freq) return 0; opp = dev_pm_opp_find_freq_exact(dev, freq, true); - if (IS_ERR(opp) && (PTR_ERR(opp) == -ERANGE)) + if (PTR_ERR(opp) == -ERANGE) opp = dev_pm_opp_find_freq_exact(dev, freq, false); voltage = dev_pm_opp_get_voltage(opp) / 1000; /* mV */