From patchwork Tue Sep 5 17:25:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Todd Kjos X-Patchwork-Id: 111706 Delivered-To: patch@linaro.org Received: by 10.140.94.166 with SMTP id g35csp3126115qge; Tue, 5 Sep 2017 10:26:03 -0700 (PDT) X-Received: by 10.98.158.78 with SMTP id s75mr4421821pfd.156.1504632362988; Tue, 05 Sep 2017 10:26:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504632362; cv=none; d=google.com; s=arc-20160816; b=ip/YvgJRt803mOucVqBQzkPYXIgMKgaprcLYnsrzcSMJGvqebfKVWtB3JLrOZE3bu8 Onu55Cx/8Z2FbGpEnCMjNWbeCSlCcT1IAUyB1RMfpe5hEM8DKFoe3VcZjPVVKG+2AARb NqyiRp0QBHE2WiYRJ3aEwFq95TjQNZ7Rjsi6mKfPiGzlfawJXKa6xeNS02Suv2EDRrQO 07MKzm7fHv790Ym3Bq8QtlSUx5MZ/w2R0oKi/oKtgDc7DUtJHMEkSDsURBk6vdTnJLKS 5k/HJ+oQEwhQu12AEv/FRvyRt5/E0p+lQ2JfPkH21VID4fV64kvN9rzoY4Tsb787XkSo R9pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=OOQJcCAonsNXjsVEnYxOju61lHbSOhds2gRGCF+9mM4=; b=vRZq8fFra3SCklPqW/ChPptrfz7uMPKm1iIE1AnSHoXPsEBYfdvpxtmE2S64IaemL2 7fhn74wdB3q6BrBzvdMSfiOulGS/J26BLHEdwaLjf1yPP3zFv26PfQ38xx8uyCmZRjaT 6x6A7g/6dKZpClfrSAccTDNQsN82S+HUmgiebyZYDAGnvGwEscG9bFM5Wz0/EmCcZVku cnsox/61TR7UfA7repfPtFtfB5TOFTYUDawvjOxrE1pRv/vZBaduHPUYQlc6Wzo2Dst/ vJpTHttbn6FugsZTsRgZSIBsUMWzouB5LwRKqovOU0ultcEFGpaLFixBmAIXYKwzbrxS MOvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=Uq98fsMn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=android.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s13si593231pgr.309.2017.09.05.10.26.02; Tue, 05 Sep 2017 10:26:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=Uq98fsMn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=android.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbdIERZ6 (ORCPT + 26 others); Tue, 5 Sep 2017 13:25:58 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34591 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbdIERZx (ORCPT ); Tue, 5 Sep 2017 13:25:53 -0400 Received: by mail-pf0-f178.google.com with SMTP id m1so8864399pfk.1 for ; Tue, 05 Sep 2017 10:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=OOQJcCAonsNXjsVEnYxOju61lHbSOhds2gRGCF+9mM4=; b=Uq98fsMnmlWWogH4f2nyzElDgsb9FF5/wPZRY7kh2VV/uUAacPjs/LXfsCMrkSMHBb nyPs9WHjVRFTAZ/vZP+5luNQ5ieTTZ+sOYyeUtSgfEs76l5aLQ4pq+JYUhYxIHV+rDS7 XH0fLbllOyi2ieaMc6quHJRtCodbZxLCNk3/BnQ/vCTz0NxZ3C6r59bdi/4DhouO/juz 6fcPgHLP0MdlK8LM1M4b/X78KQRMlju1wchgTevp2CUbFUGFhMhF0McfTYRe99G6lKsr gre6SMH+b8sJWoJY/MLldvLIfdPMSvoVWnSrFBBSfDttX/rMw04RlGRKnjlUzZcbpFtr isyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OOQJcCAonsNXjsVEnYxOju61lHbSOhds2gRGCF+9mM4=; b=Ooyvj6X+BiQsFMvg2m8fo58UYUa/k0esO0LFC/OOkCtc8Dg7z22HKWMt2t34chk/ZS TNK/j9WaY+wIwdBukBTuufByEplrgBtjNZWYi290i4DAqoHHxwacBxT593MautbfSxLz RPu3fOm2GL0nAReXUF4i1af/6GLMLvSQsHc5EWRI9FDyxX2qSO8LKk0JecwmlH/Re5E4 Ny0NKB0+EkDIOTldjyo6PlcWg8PkvpesqvWuljd/LWy31KI+Sm6u3BjmCxpAe2TI2Wgf s8gzdC0RMpy7T53qfwAuJuTpWKvdTOiY2+/5HAZz5EpxTzwAtCLtas8NtxWoS7CbQsC/ XToQ== X-Gm-Message-State: AHPjjUiDNCAbxT7SZR8vkxHrmrBwG3dPQwWx/wwrysXhZk+An2otFHrK WtzPjsKHn5vLZIEm X-Google-Smtp-Source: ADKCNb5SpyOgtomaxZw9uRcKZqq7pMNHJ4AVEzftn8I1OScxI6WD0b2tbIFzRsWFgAEL53J+JBjhow== X-Received: by 10.101.92.204 with SMTP id b12mr4736053pgt.54.1504632353323; Tue, 05 Sep 2017 10:25:53 -0700 (PDT) Received: from ava-linux.mtv.corp.google.com ([172.22.121.103]) by smtp.googlemail.com with ESMTPSA id h82sm1883670pfd.148.2017.09.05.10.25.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Sep 2017 10:25:52 -0700 (PDT) From: Todd Kjos X-Google-Original-From: Todd Kjos To: gregkh@linuxfoundation.org, arve@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, maco@google.com, tkjos@google.com, xuyiping@hisilicon.com, gengyanping@hisilicon.com, shiwanglai@hisilicon.com Cc: Xu YiPing Subject: [PATCH] binder: fix an ret value override Date: Tue, 5 Sep 2017 10:25:38 -0700 Message-Id: <20170905172538.36758-1-tkjos@google.com> X-Mailer: git-send-email 2.14.1.581.gf28d330327-goog Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xu YiPing commit 372e3147df70 ("binder: guarantee txn complete / errors delivered in-order") incorrectly defined a local ret value. This ret value will be invalid when out of the if block Signed-off-by: Xu YiPing Signed-off-by: Todd Kjos --- drivers/android/binder.c | 1 - 1 file changed, 1 deletion(-) -- 2.14.1.581.gf28d330327-goog diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 96cc28afa383..7ef9e7f05e17 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -2326,7 +2326,6 @@ static int binder_translate_handle(struct flat_binder_object *fp, (u64)node->ptr); binder_node_unlock(node); } else { - int ret; struct binder_ref_data dest_rdata; binder_node_unlock(node);