From patchwork Tue Sep 5 08:31:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 111639 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp5179150ybm; Tue, 5 Sep 2017 01:32:13 -0700 (PDT) X-Google-Smtp-Source: ADKCNb4jjq9WWtGJJR5zcVeQ5bKC+SjuEW8VtajEUII/k20cMnWOTaE6cr/zk2R16Oc+UT7KDr9K X-Received: by 10.98.33.134 with SMTP id o6mr2961497pfj.103.1504600333634; Tue, 05 Sep 2017 01:32:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504600333; cv=none; d=google.com; s=arc-20160816; b=MSB/AVB60wGL/hsjWanfJhYz8TCbe0wicynNeffdHubL8/OKa0CkdCiQ1r7urgEKOC Hq/cr6VkJaz0d96aIrGYj3k9YxpVLYaJDUwaCbGM9DQ1Zsq+Z2H9CqEo9v77RedV9hfW 6K4zdZ9MaqOlCL5FcddPU4LcwYmPkgZipIx7TMwqMjdarGjTGOi3M7HmqeckVIQ884Cg dO80uyTzt23gBX6yl+syEj2WA77b4qfb0kf2cFNYwhCCFnkVdP46dwph514U9gYvKAXI kmFWkJV4TZNo3JRrOp9AdWRjns9c/nmsacebLBYgfDhXah6b9ajy8RdNEWsi/B5KBlhF jTQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=GBDP2/TUXaTnX8jSXyWwWu3X7XhthYmSMyBvcuhNcdk=; b=ch0i4SDb0PF2IaOUnjGWB9+QgYrTQME+x3n4RirRIkNlpMG1wnDY7n11fRdAE3t9g9 PATTD1cImwlAyYqkGWmyiL6v3dGr9MkQpGfmhJe3FIne9ek8nNyezjjoqhI7z4gfat7a RHcBmxQy+YekexzKZ5hwP8gY/DTub9jgaqxet9/cfiV/9ixCg0Au2BB+05MZWHZijkmQ Mk6FevMjlHpgldiuFXvPoFfdV+2FsE+qmMQfjKag9H/ncI30uSkyHsWpt9XpM4KF3HqH Ymn+YQ6oqZsOrnasc4t98A/Qc89f9HN2dzDEcAgF5N7g5XIiUxUEwDFQbG3VtiBMogtq snTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k5si154889pln.309.2017.09.05.01.32.13; Tue, 05 Sep 2017 01:32:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800AbdIEIcK (ORCPT + 26 others); Tue, 5 Sep 2017 04:32:10 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:54147 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbdIEIcH (ORCPT ); Tue, 5 Sep 2017 04:32:07 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0M09s4-1dUKZG13me-00uFFA; Tue, 05 Sep 2017 10:31:50 +0200 From: Arnd Bergmann To: arm@kernel.org, "David S. Miller" Cc: Dave Jiang , netdev@vger.kernel.org, Arnd Bergmann , "Karicheri, Muralidharan" , linux-kernel@vger.kernel.org Subject: [PATCH] soc: ti/knav_dma: include dmaengine header Date: Tue, 5 Sep 2017 10:31:35 +0200 Message-Id: <20170905083146.1289546-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:o0v+92kIxBQ/8VQPgoMYxg2whroulUGcyNMT/WSyMxcdD5jwgpH T1mjXKEWj/LmeuDu0Hyv90Vgz8Ev59j7Usp/7nCRplq+HlL2lIGD07k0PBTCkMWKUyY7+k9 aJ/iX4RAFyykIth9bbXgz5BNJfRsSqHDTjd6ZD+5UYBiYH9JmdBk6cZDVf9HvoH4Icygwxm 9OOZLHtrjDIEvGo8E/4RA== X-UI-Out-Filterresults: notjunk:1; V01:K0:I3RwZ0Fw1A0=:/NpW+yVftUs9ga2MXPb6lh JZ88uQovAkG0ZXmVY9N9XHBUGYHVYfxAZzXaWh06ojw7/p4wXdbyF32DzrWSqvABKbym2siBL 16JORiERMsJdPAQwVdmijGllkIeBuN6n/LN7q15ULF3NAVGpjro6BccYBGQyg5ra+5Cv2Aa9D OO8OzcPu2XTiPva2yUEPb2llXe18iu2yN/omqA6p28XjRpezweY/WWGJd0zuAY9JcA6D/JOcr yhPgWbfc53diYyBTXXtlnsXOBBFcPI5IfvjfahgjGblISj0+vAqdQNomZvQMxHa3i3uzh7gNO Mnm2pF5PufWckNwKs4pWN23I4JJgFiNXOCdJOWBbVmpNJdwLS9N89IGHpvQbCi3+FE2oksj8m MGQjr8AM4AgZagpvdCCHSbXp4PD0w7CvbBS+cltexWln5tjVcps8dkphCP/cN2hpGBfApP450 e3cTl2w//zrHE7LZVJWzVoX7kz3t8pyT5no/UXP7FC/4zinUh9iJ5EvR0NalKSe/VDJN/UaIk w/JHvE3wDvp7JALqRIosVKeqQ+VQGLyG5TBkRdSKhroDmMgBMijyGVV202dJoFXkhKaOgl1gP ugVypD7hx4UuL9XaWjuVWYPdo1hVs4HfG5i7SAfR737tJavLdBHlDrW5r0OqPY+UZNcG2ciMT pqWFLbH0kWMLfy+yh35a+4t9NynByPbo3AFq8Hb+fbIAGFQQ9f+mpXlV18ZuCKCUJmCaebZ+R vaR3J60hgxPiieKf3lozfEJAASS4G8HOxsNAKA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A header file cleanup apparently caused a build regression with one driver using the knav infrastructure: In file included from drivers/net/ethernet/ti/netcp_core.c:30:0: include/linux/soc/ti/knav_dma.h:129:30: error: field 'direction' has incomplete type enum dma_transfer_direction direction; ^~~~~~~~~ drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_txpipe_open': drivers/net/ethernet/ti/netcp_core.c:1349:21: error: 'DMA_MEM_TO_DEV' undeclared (first use in this function); did you mean 'DMA_MEMORY_MAP'? config.direction = DMA_MEM_TO_DEV; ^~~~~~~~~~~~~~ DMA_MEMORY_MAP drivers/net/ethernet/ti/netcp_core.c:1349:21: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_setup_navigator_resources': drivers/net/ethernet/ti/netcp_core.c:1659:22: error: 'DMA_DEV_TO_MEM' undeclared (first use in this function); did you mean 'DMA_DESC_HOST'? config.direction = DMA_DEV_TO_MEM; As the header is no longer included implicitly through netdevice.h, we should include it in the header that references the enum. Fixes: 0dd5759dbb1c ("net: remove dmaengine.h inclusion from netdevice.h") Signed-off-by: Arnd Bergmann --- If the cleanup patch hasn't been submitted for mainline yet, please add this fixup to the net-next tree, otherwise I'll merge it through arm-soc. --- include/linux/soc/ti/knav_dma.h | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0 diff --git a/include/linux/soc/ti/knav_dma.h b/include/linux/soc/ti/knav_dma.h index 2b7882666ef6..66693bc4c6ad 100644 --- a/include/linux/soc/ti/knav_dma.h +++ b/include/linux/soc/ti/knav_dma.h @@ -17,6 +17,8 @@ #ifndef __SOC_TI_KEYSTONE_NAVIGATOR_DMA_H__ #define __SOC_TI_KEYSTONE_NAVIGATOR_DMA_H__ +#include + /* * PKTDMA descriptor manipulation macros for host packet descriptor */