From patchwork Mon Sep 4 11:41:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 111550 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp4118998ybm; Mon, 4 Sep 2017 04:42:14 -0700 (PDT) X-Google-Smtp-Source: ADKCNb47X4odVyWargJV/hwZAD/buy/CosNTNzF8E+CSNDjHYyZ8maSABVzHzrs8E4D8qEVcIbWS X-Received: by 10.84.232.8 with SMTP id h8mr383283plk.62.1504525334763; Mon, 04 Sep 2017 04:42:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504525334; cv=none; d=google.com; s=arc-20160816; b=nT1I0ynlPP9BsspXyFEpGhw42qTD5oY2Y68r6ZqhBpOqvZIeNZQ19dJdpy8HFNYnbe DR92+//MLJgGqL1Mn2XDI9ko9WHFqFVKkkXaWIfNUwvkFGSg9qIVJysS2CEVVOI5nn6c I9knvAFV9Kbv/gC1K83afkav410qovWcPgsSPm7fHj+cgjUTfLuMxGNwUgAPLH/nmyi/ TOuhNq7qjRUT1uokMy9cw9WHiS4fbEZFaiQ97N7eZVVhdfCJQgiG7xB+P8PEGfLTmNnE veymUaflmCvfviUvCmROPE75qnY7GJ7oLbUbY7r+B+Whm8wDC2F3xypt1Iqs+oHSclQ1 kVDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=Hx+29OpXNkh6D22D1xat15Z/b3UwhMRMiX32Hb46hHA=; b=YOvYIXLzIB+AGD/LTssIMhe+IKh/ZdbMeBxodiENXcyWTndQJz/4xDscDFhQNKJo7V eMRCkcqiIcQhGn10LQbvtaht+ha7qWPjH1haa9tz5JKOHb/FNibDAi8GUv1amUXA9gIH Ufdx+pdaU9clqiV8ZhXRPGq6jITvM6T4RipcGViskjgtqSj6audtDGUjeLNIRGisJ4w1 sCBYcKSkDsd6kRE81RkiutDUG9jMw/sMaVYsqnJRKKOymhsEoBP8h59liADriYrWFvRm xZ+HxTk0/QFqMBAgKVjKJC6FdhHw7rKFZc9HZmB31BqCB/KoPCQaEpbf73PQWdEZbtBT 8wRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ZMrx0fOU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 71si3009112pfx.299.2017.09.04.04.42.14; Mon, 04 Sep 2017 04:42:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ZMrx0fOU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbdIDLlq (ORCPT + 26 others); Mon, 4 Sep 2017 07:41:46 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:42938 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753380AbdIDLlo (ORCPT ); Mon, 4 Sep 2017 07:41:44 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id v84BfT4r006520; Mon, 4 Sep 2017 20:41:30 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com v84BfT4r006520 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1504525290; bh=Hx+29OpXNkh6D22D1xat15Z/b3UwhMRMiX32Hb46hHA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZMrx0fOUTBOZpRPyKHo1S1b8jXTMO6OLEjLvea5GF2ruXlQum/AB1ibESV+t9yTqY yeiNY2xYbTflZWtD5WIBzOdtg9huFXt1/ODnVmqnpE4y0BF+Bmk1U5kBoWWUS+vINw luSo5ymWXUyWZoa/jA7kSRXLFljld1xmCIfvao/GR6eqN6O2MXKVvMscjnqwB2pq4b 9Hb1O9k3jVBeswNYkHELb21xJTpV2ayZ6UCCCboVmoY2pkX3Mr9RZsdtLm7TLOwp+C k36xNJ/2lpDSvbE2Z82rJOxQmg0FDtEVET7gUQnJSxtmaaW7HnM1D2kPomG+Cl1j7o mC8q0/QddGiJQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 1/3] nvmem: add missing of_node_put() in of_nvmem_cell_get() Date: Mon, 4 Sep 2017 20:41:14 +0900 Message-Id: <1504525276-11507-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504525276-11507-1-git-send-email-yamada.masahiro@socionext.com> References: <1504525276-11507-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_get_next_parent() increments the refcount of the returned node. It should be put when done. Signed-off-by: Masahiro Yamada --- drivers/nvmem/core.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 4c49285..ebd673c 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -789,6 +789,7 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np, return ERR_PTR(-EINVAL); nvmem = __nvmem_device_get(nvmem_np, NULL, NULL); + of_node_put(nvmem_np); if (IS_ERR(nvmem)) return ERR_CAST(nvmem); From patchwork Mon Sep 4 11:41:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 111548 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp4118685ybm; Mon, 4 Sep 2017 04:41:54 -0700 (PDT) X-Google-Smtp-Source: ADKCNb5S9DfX4+SY4mcsSdlF15aSOdJM0Qp/K58CJXsSMdAAuXdOXLZishI6FCh2al37MWsy1Mn2 X-Received: by 10.99.95.145 with SMTP id t139mr132957pgb.153.1504525313926; Mon, 04 Sep 2017 04:41:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504525313; cv=none; d=google.com; s=arc-20160816; b=o/+9ZHvl0B0SRMk+jvGNzcvKzmLMexlBW2oCFnqjt/Iv3iP8SxGLbdxVKwQnb56wS5 hn+vTXY2vranid6rJRrmAfIWR4i5zA1gdcLA/Hx+mGSIteQHfjNnQF7FnUcmDFqHpSzC J4KyY+xRLviQQg+jszRVEo4EnqXwOjI9k/xjFSpBGJV+WwAI70mM/16qL/73qYosEMna JkGwjSWuvrJWTnfyYxGA4uMQSR4lEAE+5pnWx8D0zWJ945xVE1ZAu7kD+bw1b2nNzJaK IKNqZMFrtlP6ljteCPtY3vUxHf4aFZ9NNJp+NQzO8ZXkSXXYI3ZRVli9ZOAUA3RHMFg5 Ilqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=Iv9SXD4xj4CVKg7h6NkyDeoKJgah4pYGuHAr1Ux8LOA=; b=zY8mSIfdNHsRHpZ2JV2HW3KZbBm0TetTB61dVSzMAi/IKUKT//fuI9dNaPs5Kq5FnJ R4rQCNdbqqjGdBT4DzUP6rlWEQnVpf/C+yDqZArkjPr0KdW47qDhtKVwGiS49VcEklwX P5ss9P7icyJQyoEhrjgPwwe8IMaECDH/L6GS2qVrEazf0bRusNYt2wGsIwFsnUDQNqe8 ddCppsoHSA3o/md3WL5L0q3+11hv1vYuLxP9SqsBtRBfb2nngjvMgT3ZAJOfOqVPCRZG A8Af78pde4SLd+Nk3lq/uDBucmz16ONjIWnS/uHfOD7nkvRLwyP0Vo6Kcl4oDNAHBIyz dg4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=tjbZMKqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si5328683plm.262.2017.09.04.04.41.53; Mon, 04 Sep 2017 04:41:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=tjbZMKqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753607AbdIDLlt (ORCPT + 26 others); Mon, 4 Sep 2017 07:41:49 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:42936 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753485AbdIDLlp (ORCPT ); Mon, 4 Sep 2017 07:41:45 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id v84BfT4s006520; Mon, 4 Sep 2017 20:41:31 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com v84BfT4s006520 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1504525291; bh=Iv9SXD4xj4CVKg7h6NkyDeoKJgah4pYGuHAr1Ux8LOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tjbZMKqS8dWJGGzX8comhx/d4WkVC/hL4h2pD6eu0mZeJVuc2d6NTTcR++nm7tQ4B whi07HljRZJ3jndqih43WeKMayZfJaG32hu2enTP6FyXMzpmmxMaJ8QJWR4JjexAaF qcKiFP4HNzbBsnkD6sAWb33C+uuRueDkNLaRt+W2OWHyimvwC8YQBCqKhgf4bXaaR+ iX4/rcE2PJ1ZXFd01ODnxEcFhogcWf1l29U3eEG2LARmQMU4yywMDDFh1XLKGAmmmO En72sYSzEHSHTNdlrZypBMlQAT5TCKizPVmyxqGCAZo9iRIK8dDAT/4oPLpr2/Ci6j LclgOSNJ9AUUA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] nvmem: remove inline in drivers/nvmem/core.c Date: Mon, 4 Sep 2017 20:41:15 +0900 Message-Id: <1504525276-11507-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504525276-11507-1-git-send-email-yamada.masahiro@socionext.com> References: <1504525276-11507-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These two functions are defined in .c file, but called just once (at least for now). So, the compiler will fold them into their callers even without the "inline" markers. However, this kind of optimization should not be done by hand. It is compiler's judge after all. Signed-off-by: Masahiro Yamada --- drivers/nvmem/core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index ebd673c..8d915da 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -946,8 +946,7 @@ void nvmem_cell_put(struct nvmem_cell *cell) } EXPORT_SYMBOL_GPL(nvmem_cell_put); -static inline void nvmem_shift_read_buffer_in_place(struct nvmem_cell *cell, - void *buf) +static void nvmem_shift_read_buffer_in_place(struct nvmem_cell *cell, void *buf) { u8 *p, *b; int i, bit_offset = cell->bit_offset; @@ -1028,8 +1027,8 @@ void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len) } EXPORT_SYMBOL_GPL(nvmem_cell_read); -static inline void *nvmem_cell_prepare_write_buffer(struct nvmem_cell *cell, - u8 *_buf, int len) +static void *nvmem_cell_prepare_write_buffer(struct nvmem_cell *cell, + u8 *_buf, int len) { struct nvmem_device *nvmem = cell->nvmem; int i, rc, nbits, bit_offset = cell->bit_offset; From patchwork Mon Sep 4 11:41:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 111551 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp4119022ybm; Mon, 4 Sep 2017 04:42:16 -0700 (PDT) X-Google-Smtp-Source: ADKCNb7vKb8hrDtGEeituNDDDezfvSRXk3K/UyBRYg43JwpZhoE81Dq8buK+jFFFNdPhZ6S95zxz X-Received: by 10.84.129.34 with SMTP id 31mr369977plb.282.1504525336399; Mon, 04 Sep 2017 04:42:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504525336; cv=none; d=google.com; s=arc-20160816; b=0jxFWzarBeSqKB5n6uSC+lXxTn/E78AIyA3xJWPO+F6GAgmJs728E7CRkRYLE9bM7a MBJ++TAeoXMennSdt20zuM9vLdJm5qM1tGqUyh1BmmRqTV3cWIr4GbVpYS0stc6Nv9rO PRYOwaodMqq1V3y+ccGaN0OU63YzkD8U1qxFHlghM+1JDrt8JZhrLBFC/ulBfBn/vTfk H7/WTGs8571xjUqVXeOJRXo/zdKOzgL46rIMIZnCKoHFJv0KbGcd0g5rB9V2K8pbn+WR 0XIZyNTaBGWbIfauOojs2tNeOq4JEjnw+h5XT0pFZpdAwcBBrVibU1JJbIZ81wKVjDlJ A4xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=wk7+WyeLvqQqBu6Ezb0F1c59/7YALb9PWQI/JPytQuU=; b=EEZEs3tYw4tgSjdV3RsfdsuM2n9e1J8C6fNx9YhxftbYKu93PkcqmuhiFjocbk/VDR 297fMv3FGLiDj3zQqKwNIbIkcJJxa1DWbPXgAgHbGOaTHp0KLyOvuJKFfgDBDx5I4/Mz 4pQSICj44z1+2AF1OHQI/u41igc1Jptzxssw5pkOQv986udvzVk9GTrda7G9n8ipVLKB F01NFVbFL+gdtZjCyn8xBqp7Nx9E4TamLjyNN5RhAJrBlZ7R+cHoIfTE8MRnn0fPAM/7 qchou5FKfT0ZJT4ICnP0rbaOElTmVeai9El9kLdqpMTGHOiTs5D7k+nHBDujl9e3SiNt SNZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=nN6Wj0bh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 67si4856837pfy.65.2017.09.04.04.42.16; Mon, 04 Sep 2017 04:42:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=nN6Wj0bh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753661AbdIDLmN (ORCPT + 26 others); Mon, 4 Sep 2017 07:42:13 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:43691 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753638AbdIDLmL (ORCPT ); Mon, 4 Sep 2017 07:42:11 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id v84BfT4t006520; Mon, 4 Sep 2017 20:41:31 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com v84BfT4t006520 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1504525291; bh=wk7+WyeLvqQqBu6Ezb0F1c59/7YALb9PWQI/JPytQuU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nN6Wj0bheWr+IwtdUOZDmGRlSNkt3Yg30Sj2coRQiv9nQa6lBQbFiz0SLrQQknaAr K7j6qy4CH0cdDIDxxanLqIXxMK2sH2FcpeTvr+N6HrsI3vxEZb7ZV65U5PgkhdfOFm J6Nb1wzjyODBI/HpD2XkMCKp92NK0qUYP27GLVuY+YulwY0q6qBVH85aEqlwVj7idd DsBIj4YES540SbIBc/DyzGpp8VY1MN1iWLtkOB0TXKyhlPCRZCAI18Axo814avmIUg 1pcOp/8dP2WVdb0fDJc+m3NB2uo9QTYIq7QJ/G8eqF0gjN2amhnBidsm4n+6YY8ycq MlypeCT2jsvlw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] nvmem: remove unneeded IS_ENABLED(CONFIG_NVMEM) conditional Date: Mon, 4 Sep 2017 20:41:16 +0900 Message-Id: <1504525276-11507-4-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504525276-11507-1-git-send-email-yamada.masahiro@socionext.com> References: <1504525276-11507-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As you see in drivers/nvmem/Makefile, this C file is compiled only when CONFIG_NVMEM is y or m. So, IS_ENABLED(CONFIG_NVMEM) is always evaluated to 1 in this file. Signed-off-by: Masahiro Yamada --- drivers/nvmem/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 8d915da..ebdc817 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -615,7 +615,7 @@ static struct nvmem_device *nvmem_find(const char *name) return to_nvmem_device(d); } -#if IS_ENABLED(CONFIG_NVMEM) && IS_ENABLED(CONFIG_OF) +#if IS_ENABLED(CONFIG_OF) /** * of_nvmem_device_get() - Get nvmem device from a given id * @@ -753,7 +753,7 @@ static struct nvmem_cell *nvmem_cell_get_from_list(const char *cell_id) return cell; } -#if IS_ENABLED(CONFIG_NVMEM) && IS_ENABLED(CONFIG_OF) +#if IS_ENABLED(CONFIG_OF) /** * of_nvmem_cell_get() - Get a nvmem cell from given device node and cell id *