From patchwork Thu Aug 31 12:00:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 111378 Delivered-To: patch@linaro.org Received: by 10.140.95.112 with SMTP id h103csp2441826qge; Thu, 31 Aug 2017 05:05:34 -0700 (PDT) X-Google-Smtp-Source: ADKCNb7/Jmi75bK1N8u9fMxgfiMC/wdG8E+6cwk8z6NUWFJOfEQuNyBtXQmspBV0974oNGNwJGTJ X-Received: by 10.200.51.119 with SMTP id u52mr6331110qta.69.1504181134154; Thu, 31 Aug 2017 05:05:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504181134; cv=none; d=google.com; s=arc-20160816; b=hkqSAcs8dZKjORg+hGhGt1eZrNxmIjI0N60tKZvyDVG7ZtRjNtXZHTNv2eEExvDNbb nHUkBd27yrFGu3nLUjdexOKfSHcqdXBdPnQAgfLjVJDTEFbN5EMz0s1E5ses+9biNQxb WgNuJG6N0deyw8VA46Pv7omGW210i0Ga9ZWRah+vRj8s0v8aNZAu4S/Cy/F2wyc2qwsX HKPTjgYAJW4Y1peQujEn+BxJlSnNzmzIrt4flRwmLQhdnosthJJtpQfAYssFjaftQZDl 290wCCUicn/F6JbjJObftUG8DXiV4pmWNFrjUUruA5ZYjRVDSVJPUEEPKIkkmKc8oq4J 2o/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=uZUTUhkQXsHEpCdQ2KeexlP1eh1SO8f+6ZzAbEiqhFA=; b=g9kyzjWTqrCkT8FPotoRuCNiYRJZoLXrcXfQlewmcKTbQxmjkshhIKdDUa1tsZz43E UjaUvmCkvzOXm2b7mN5DwUprRWxyNQBPAotai5DFiFoX4Vq7G5VYJHL7hGa5y0RJ+DXc BraaDuNDLG4ICf9pJb+70OzrNOavsc6HAWoBTkZA0lw2g0KW4gV4ZVI+dBvXUQSTT97t rKt8YoYdeVwhaJ5bKbejvJFxjTGdKfcLQKzxUBXYYbiTP1IFtg5OpvQZkSBun8plILJs 9vz2kMqcrM8I9+LJcd2LaEmVObbrvI/RyBWe6+90NnQUPxbmUGG6buTlewdZz2Tgnf6S JMdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id e61si6745422qtd.208.2017.08.31.05.05.33; Thu, 31 Aug 2017 05:05:34 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 7208F62EF4; Thu, 31 Aug 2017 12:05:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 4B731636A2; Thu, 31 Aug 2017 12:02:23 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id D141F60DF2; Thu, 31 Aug 2017 12:01:53 +0000 (UTC) Received: from forward3p.cmail.yandex.net (forward3p.cmail.yandex.net [77.88.31.18]) by lists.linaro.org (Postfix) with ESMTPS id 1C2B560C79 for ; Thu, 31 Aug 2017 12:00:37 +0000 (UTC) Received: from smtp4j.mail.yandex.net (smtp4j.mail.yandex.net [IPv6:2a02:6b8:0:1619::15:6]) by forward3p.cmail.yandex.net (Yandex) with ESMTP id 2331420C09 for ; Thu, 31 Aug 2017 15:00:35 +0300 (MSK) Received: from smtp4j.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp4j.mail.yandex.net (Yandex) with ESMTP id F2BFD32410A7 for ; Thu, 31 Aug 2017 15:00:20 +0300 (MSK) Received: by smtp4j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id Qefy0z1H5O-0J0CvE8n; Thu, 31 Aug 2017 15:00:19 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 31 Aug 2017 15:00:05 +0300 Message-Id: <1504180805-13531-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1504180805-13531-1-git-send-email-odpbot@yandex.ru> References: <1504180805-13531-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 157 Subject: [lng-odp] [PATCH v1 1/1] odp-generator: Use clock related functions less when printing X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Ilias Apalodimas Using odp_time_local() on each iteration consumes too much cpu for no reason Netmap pktio reported ~550kpps prior to this and ~1.2Mpps after the patch, when odp_generator was used as a receiver. Signed-off-by: Ilias Apalodimas --- /** Email created from pull request 157 (apalos:gen_cpu_fix) ** https://github.com/Linaro/odp/pull/157 ** Patch: https://github.com/Linaro/odp/pull/157.patch ** Base sha: 7508c5ac906bb7cb1d339b4c5e924f3a18e504ca ** Merge commit sha: f499aa73554e49e50ec2c34f01e07aa2b2a7a96b **/ example/generator/odp_generator.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index f3ec43be..fad83db5 100644 --- a/example/generator/odp_generator.c +++ b/example/generator/odp_generator.c @@ -765,11 +765,12 @@ static int gen_recv_thread(void *arg) */ static void print_global_stats(int num_workers) { - odp_time_t cur, wait, next; + odp_time_t cur, wait, next, left; uint64_t pkts_snd = 0, pkts_snd_prev = 0; uint64_t pps_snd = 0, maximum_pps_snd = 0; uint64_t pkts_rcv = 0, pkts_rcv_prev = 0; uint64_t pps_rcv = 0, maximum_pps_rcv = 0; + uint64_t stall = 0; int verbose_interval = 20; odp_thrmask_t thrd_mask; @@ -786,8 +787,14 @@ static void print_global_stats(int num_workers) } cur = odp_time_local(); - if (odp_time_cmp(next, cur) > 0) + if (odp_time_cmp(next, cur) > 0) { + left = odp_time_diff(next, cur); + stall = odp_time_to_ns(left); + stall = (stall / 1000000000) + 1; + stall &= 0xFFFFFFFF; + sleep((unsigned int) stall); continue; + } next = odp_time_sum(cur, wait); switch (args->appl.mode) {