From patchwork Tue May 19 07:50:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Albrieux X-Patchwork-Id: 200379 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F45C433E1 for ; Tue, 19 May 2020 07:51:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1115320809 for ; Tue, 19 May 2020 07:51:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="afDBTXdV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726943AbgESHv6 (ORCPT ); Tue, 19 May 2020 03:51:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbgESHv5 (ORCPT ); Tue, 19 May 2020 03:51:57 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 534C6C061A0C; Tue, 19 May 2020 00:51:56 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id u188so2307952wmu.1; Tue, 19 May 2020 00:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=g2sU/s3ZSgjmLzLMit0zw8xym5bMpksqrVvGb7EuMnM=; b=afDBTXdVkIaS0Jh4uTRhUhaav27upBE5ZgSJ8qVeFA5EmHbOelxEJW1raIen3J9Jja 6A8Db77ULrxBx6nRzJKpYZgOHHEsZdiOAlNY5nMejusIX9Pz7heZhdMxNHsnOTf7c2mp iEUKPFj5E4U1JWGdKNFacRqlewyyAh3uncTsJc6zM4TKvmTuJPsjJ6bxUmK4cwE18q42 9fUTyBp/jFv3LLwRk9ftSbuKRUK/XtWX+DNVVXjjmyW5kqUh/SnhBJmwX4h4J023z0/v NiM1ltErl2etOCambA5cVaRAb8b3L5ivoECwXMYimPgJEg1M0wQzk8HkVRPHVsxgbf00 TQ5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g2sU/s3ZSgjmLzLMit0zw8xym5bMpksqrVvGb7EuMnM=; b=MR/nqjgVNy2SiFvOWFABUMp61iXdjketGZFAiNqoCaz2n5fAkazFRoWOWgD4lmXXXO u6eEAv53VZKLw275NoHkBSfxFehvf/iACWRWzxjA12NH2xmiJNO3SkT3I2BZDUdrexQc 2h61me8bZYgrTs0SlCjmkvdgQ7a0LjXjAgzY9VZdKuJLuPagoCIeXc3LEHnjuXPy7+5O PNtDqoACXScR3cBe0ZTPzR/RuSXspbpqzpBFH3RN0gY20CDHWGVg2U1o92goQ3uICjOb friQVScXos70RuJKGOtCvdpTT5NKigbS69aWiPb2QozU26xyWz6CR6A6YeCbHjFixC6A Eabw== X-Gm-Message-State: AOAM532FP5azNVSaWJdsOnTciwz0OCAqvUAqD3JvimKDsbB+J1ZG3t3Z JHNTu3uUdOmQ4gjEfoXeHTbc5hL0ecs= X-Google-Smtp-Source: ABdhPJwTzc1wazYnIQwgBVGvzyYXxFBP+pNKLJ/5+5Z3ROPzayYdlv33R1Lm5OW9qfTy7EgFqyOuog== X-Received: by 2002:a1c:2e46:: with SMTP id u67mr3789884wmu.156.1589874714499; Tue, 19 May 2020 00:51:54 -0700 (PDT) Received: from ict14-OptiPlex-980.kataweb.it ([178.23.248.46]) by smtp.googlemail.com with ESMTPSA id w18sm20019697wro.33.2020.05.19.00.51.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 00:51:53 -0700 (PDT) From: Jonathan Albrieux To: linux-kernel@vger.kernel.org Cc: Jonathan Albrieux , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Hartmut Knaack , Lars-Peter Clausen , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), Peter Meerwald-Stadler , Jonathan Cameron , Rob Herring Subject: [PATCH v2 1/4] dt-bindings: iio: imu: bmi160: convert txt format to yaml Date: Tue, 19 May 2020 09:50:57 +0200 Message-Id: <20200519075111.6356-2-jonathan.albrieux@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200519075111.6356-1-jonathan.albrieux@gmail.com> References: <20200519075111.6356-1-jonathan.albrieux@gmail.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Converts documentation from txt format to yaml Signed-off-by: Jonathan Albrieux --- .../devicetree/bindings/iio/imu/bmi160.txt | 37 -------- .../devicetree/bindings/iio/imu/bmi160.yaml | 84 +++++++++++++++++++ 2 files changed, 84 insertions(+), 37 deletions(-) delete mode 100644 Documentation/devicetree/bindings/iio/imu/bmi160.txt create mode 100644 Documentation/devicetree/bindings/iio/imu/bmi160.yaml diff --git a/Documentation/devicetree/bindings/iio/imu/bmi160.txt b/Documentation/devicetree/bindings/iio/imu/bmi160.txt deleted file mode 100644 index 900c169de00f..000000000000 --- a/Documentation/devicetree/bindings/iio/imu/bmi160.txt +++ /dev/null @@ -1,37 +0,0 @@ -Bosch BMI160 - Inertial Measurement Unit with Accelerometer, Gyroscope -and externally connectable Magnetometer - -https://www.bosch-sensortec.com/bst/products/all_products/bmi160 - -Required properties: - - compatible : should be "bosch,bmi160" - - reg : the I2C address or SPI chip select number of the sensor - - spi-max-frequency : set maximum clock frequency (only for SPI) - -Optional properties: - - interrupts : interrupt mapping for IRQ - - interrupt-names : set to "INT1" if INT1 pin should be used as interrupt - input, set to "INT2" if INT2 pin should be used instead - - drive-open-drain : set if the specified interrupt pin should be configured as - open drain. If not set, defaults to push-pull. - -Examples: - -bmi160@68 { - compatible = "bosch,bmi160"; - reg = <0x68>; - - interrupt-parent = <&gpio4>; - interrupts = <12 IRQ_TYPE_EDGE_RISING>; - interrupt-names = "INT1"; -}; - -bmi160@0 { - compatible = "bosch,bmi160"; - reg = <0>; - spi-max-frequency = <10000000>; - - interrupt-parent = <&gpio2>; - interrupts = <12 IRQ_TYPE_LEVEL_LOW>; - interrupt-names = "INT2"; -}; diff --git a/Documentation/devicetree/bindings/iio/imu/bmi160.yaml b/Documentation/devicetree/bindings/iio/imu/bmi160.yaml new file mode 100644 index 000000000000..6b464ce5ed0b --- /dev/null +++ b/Documentation/devicetree/bindings/iio/imu/bmi160.yaml @@ -0,0 +1,84 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/imu/bmi160.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bosch BMI160 + +maintainers: + - can't find a mantainer, author is Daniel Baluta + +description: | + Inertial Measurement Unit with Accelerometer, Gyroscope and externally + connectable Magnetometer + https://www.bosch-sensortec.com/bst/products/all_products/bmi160 + +properties: + compatible: + const: bosch,bmi160 + + reg: + maxItems: 1 + description: the I2C address or SPI chip select number of the sensor + + spi-max-frequency: + maxItems: 1 + description: set maximum clock frequency (required only for SPI) + + interrupts: + maxItems: 1 + description: interrupt mapping for IRQ + + interrupt-names: + minItems: 1 + maxItems: 1 + items: + enum: + - INT1 + - INT2 + description: | + set to "INT1" if INT1 pin should be used as interrupt input, set + to "INT2" if INT2 pin should be used instead + + drive-open-drain: + description: | + set if the specified interrupt pin should be configured as + open drain. If not set, defaults to push-pull. + +required: + - compatible + - reg + +examples: + - | + // Example for I2C + i2c@78b7000 { + reg = <0x78b6000 0x600>; + #address-cells = <1>; + #size-cells = <0>; + + bmi160@68 { + compatible = "bosch,bmi160"; + reg = <0x68>; + interrupt-parent = <&gpio4>; + interrupts = <12 1>; + interrupt-names = "INT1"; + }; + - | + // Example for SPI + spi@78b7000 { + reg = <0x78b7000 0x600>, + <0x7884000 0x23000>; + #address-cells = <1>; + #size-cells = <0>; + + bmi160@0 { + compatible = "bosch,bmi160"; + reg = <0>; + spi-max-frequency = <10000000>; + interrupt-parent = <&gpio2>; + interrupts = <12 1>; + interrupt-names = "INT2"; + }; + }; From patchwork Tue May 19 07:50:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Albrieux X-Patchwork-Id: 200378 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D2C8C433DF for ; Tue, 19 May 2020 07:52:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBE2A207E8 for ; Tue, 19 May 2020 07:52:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VFppNQKO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728570AbgESHwE (ORCPT ); Tue, 19 May 2020 03:52:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbgESHwD (ORCPT ); Tue, 19 May 2020 03:52:03 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ACCFC061A0C; Tue, 19 May 2020 00:52:03 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id 50so14663949wrc.11; Tue, 19 May 2020 00:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+9q/lrH8Rz1lWaiznxolgZJjw54jdIA13oGlCCkqVWE=; b=VFppNQKOwslJ52Bhq5aKyGSXmyfKM+y2ofM/uTjfNjFGd9ihqxIKnPgbhGXVPF6/hZ GhtvBF3u3B2SfohsCfVczsf+2vu1p+xwr3VHtEm4PRoP4/B6f4jH26u2V7nujIfF30EN DMjXrIHUTpSO3eRw099p5Bz35WAzW048regqgbVMt4t3IYCk1GGLnjFrmHjr+1wh85xM nexPtzQ3AQThkprrL7lJ+fN4YiYup+IdCDaU4YESO7BmKAcciJT367yVWvbQ3oG7x2Xs H6pR4ULWy9Q6ctuX5W65BKRCQb/2APLvqGTNYF5Q3S1CPWM5QZF+o00ATmALRK00LPRY MPiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+9q/lrH8Rz1lWaiznxolgZJjw54jdIA13oGlCCkqVWE=; b=IPjic6i5EdzMJ1jlOIRuOid7hMygLaHcZkDm55NdJeB6dE7R6POmKE/sfFBPCFjmPz yMEOpedHoKApO1z2T2dm/acp79JYbyRY/7XI82SBaIHQJLIbgQukNGwOuEZ8BjjAgHT3 L9S0UqDdK88gFadcdH2/isSxP6ZHxCSvFLiHaAOJgJGdZ+3tuh16fr6iP0RgEvPwxHH0 kXuPV37R5Gcv0xOhMWCnwRknZlkK97Zr2ba55hAQoQ/CLxWn8SmW/wjDCVzkmJUEvzG5 2AXqdOWg7c4jqILTX/SdniWpFWzeDnQtOf9hjpAcAozLa1QYakgHeOBzsGc6GxWtqVYn OJtg== X-Gm-Message-State: AOAM531liISiLThYrcFiswkycW8X1dleqswCI3dm+mLUSYkU3iNTQE88 Gj9vDjOZn3d7TT7sIIKf8LnPR8VcLhQ= X-Google-Smtp-Source: ABdhPJxIz2vOS+zMIvTdjRmEANZlTkljXpVaVGC6bSoPaePYn8jUR2aXIUq24cRHqc3d0fbDP9vtIA== X-Received: by 2002:adf:e985:: with SMTP id h5mr25204106wrm.239.1589874721123; Tue, 19 May 2020 00:52:01 -0700 (PDT) Received: from ict14-OptiPlex-980.kataweb.it ([178.23.248.46]) by smtp.googlemail.com with ESMTPSA id w18sm20019697wro.33.2020.05.19.00.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 00:52:00 -0700 (PDT) From: Jonathan Albrieux To: linux-kernel@vger.kernel.org Cc: Jonathan Albrieux , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Hartmut Knaack , Lars-Peter Clausen , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), Peter Meerwald-Stadler , Jonathan Cameron Subject: [PATCH v2 3/4] iio: imu: bmi160: added regulator support Date: Tue, 19 May 2020 09:50:59 +0200 Message-Id: <20200519075111.6356-4-jonathan.albrieux@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200519075111.6356-1-jonathan.albrieux@gmail.com> References: <20200519075111.6356-1-jonathan.albrieux@gmail.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org v2: fixed missing description Add vdd-supply and vddio-supply support. Without this support vdd and vddio should be set to always-on in device tree Signed-off-by: Jonathan Albrieux --- drivers/iio/imu/bmi160/bmi160.h | 2 ++ drivers/iio/imu/bmi160/bmi160_core.c | 27 ++++++++++++++++++++++++++- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/iio/imu/bmi160/bmi160.h b/drivers/iio/imu/bmi160/bmi160.h index 621f5309d735..923c3b274fde 100644 --- a/drivers/iio/imu/bmi160/bmi160.h +++ b/drivers/iio/imu/bmi160/bmi160.h @@ -3,10 +3,12 @@ #define BMI160_H_ #include +#include struct bmi160_data { struct regmap *regmap; struct iio_trigger *trig; + struct regulator_bulk_data supplies[2]; }; extern const struct regmap_config bmi160_regmap_config; diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c index 6af65d6f1d28..9bbe0d8e6720 100644 --- a/drivers/iio/imu/bmi160/bmi160_core.c +++ b/drivers/iio/imu/bmi160/bmi160_core.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -709,6 +710,12 @@ static int bmi160_chip_init(struct bmi160_data *data, bool use_spi) unsigned int val; struct device *dev = regmap_get_device(data->regmap); + ret = regulator_bulk_enable(ARRAY_SIZE(data->supplies), data->supplies); + if (ret) { + dev_err(dev, "Failed to enable regulators: %d\n", ret); + return ret; + } + ret = regmap_write(data->regmap, BMI160_REG_CMD, BMI160_CMD_SOFTRESET); if (ret) return ret; @@ -793,9 +800,17 @@ int bmi160_probe_trigger(struct iio_dev *indio_dev, int irq, u32 irq_type) static void bmi160_chip_uninit(void *data) { struct bmi160_data *bmi_data = data; + struct device *dev = regmap_get_device(bmi_data->regmap); + int ret; bmi160_set_mode(bmi_data, BMI160_GYRO, false); bmi160_set_mode(bmi_data, BMI160_ACCEL, false); + + ret = regulator_bulk_disable(ARRAY_SIZE(bmi_data->supplies), + bmi_data->supplies); + if (ret) { + dev_err(dev, "Failed to disable regulators: %d\n", ret); + } } int bmi160_core_probe(struct device *dev, struct regmap *regmap, @@ -815,6 +830,16 @@ int bmi160_core_probe(struct device *dev, struct regmap *regmap, dev_set_drvdata(dev, indio_dev); data->regmap = regmap; + data->supplies[0].supply = "vdd"; + data->supplies[1].supply = "vddio"; + ret = devm_regulator_bulk_get(dev, + ARRAY_SIZE(data->supplies), + data->supplies); + if (ret) { + dev_err(dev, "Failed to get regulators: %d\n", ret); + return ret; + } + ret = bmi160_chip_init(data, use_spi); if (ret) return ret; @@ -853,6 +878,6 @@ int bmi160_core_probe(struct device *dev, struct regmap *regmap, } EXPORT_SYMBOL_GPL(bmi160_core_probe); -MODULE_AUTHOR("Daniel Baluta "); MODULE_DESCRIPTION("Bosch BMI160 driver"); MODULE_LICENSE("GPL v2");