From patchwork Wed Feb 1 03:35:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Palmer, Thomas" X-Patchwork-Id: 93002 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp2235805qgi; Tue, 31 Jan 2017 19:35:06 -0800 (PST) X-Received: by 10.84.141.1 with SMTP id 1mr1129642plu.33.1485920106329; Tue, 31 Jan 2017 19:35:06 -0800 (PST) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id c7si13099632pgn.352.2017.01.31.19.35.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Jan 2017 19:35:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id B457D82057; Tue, 31 Jan 2017 19:35:05 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AB26282055 for ; Tue, 31 Jan 2017 19:35:03 -0800 (PST) Received: from arm-build-server.us.rdlabs.hpecorp.net (arm-build-server.us.rdlabs.hpecorp.net [16.84.24.54]) by g4t3425.houston.hpe.com (Postfix) with ESMTP id CB6264B; Wed, 1 Feb 2017 03:35:02 +0000 (UTC) From: Thomas Palmer To: edk2-devel@lists.01.org Date: Tue, 31 Jan 2017 21:35:00 -0600 Message-Id: <1485920100-33234-1-git-send-email-thomas.palmer@hpe.com> X-Mailer: git-send-email 2.7.4 Subject: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ruiyu.ni@intel.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" On GCC built UEFIs, the "cp" command fails with "The source and destination are the same". The root cause is that StrniCmp failed to detect a case- insensitive string difference due to the InternalCharToUpper function being improperly declared. Fix is to add missing EFIAPI token to match the original implementation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer --- .../Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ruiyu Ni Reviewed-by: Jaben Carsey diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c index 7948e53cfc46..4dbff4de26f8 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c @@ -21,6 +21,7 @@ * functions are non-interactive only + (C) Copyright 2017 Hewlett Packard Enterprise Development LP
Copyright (c) 2014 Hewlett-Packard Development Company, L.P. Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.
This program and the accompanying materials @@ -268,6 +269,7 @@ VerifyIntermediateDirectories ( @return Char as an upper case character. **/ CHAR16 +EFIAPI InternalCharToUpper ( IN CONST CHAR16 Char );