From patchwork Fri Jun 26 19:11:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 191914 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp759864ilg; Fri, 26 Jun 2020 12:11:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/BobTs1RL7jPMT52HvEt9hTga4o1u4hlN7QTG+RmaeAGQEwhwjcg92wI9BMYPAA1S/vqn X-Received: by 2002:a17:906:82d2:: with SMTP id a18mr3783779ejy.522.1593198667750; Fri, 26 Jun 2020 12:11:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593198667; cv=none; d=google.com; s=arc-20160816; b=FPWUndyImflStjiExOe0/TM/lk16fRaMstnC53hi3gVSo59zYbtPDcV5nYfYdAYm4S KcSdEC0OlO7nOwjUt+jIRiPl44WQboH8frC+WkkhibZ9yQGI9a/rcsAd4/FBMIs7TLQL d8jrFU8irtepJ0p8xuFAJ/HsTHvapshX3ZZpp9Ju0jrxMNTse3WlbmhfTZnsW1a5uw3G l3GKuIWXkayBu4fwNF8LPtbHfqSpoKT7TzG/OMzbL/irbTm29KkXBy/BhyHHrysI4dhs EJTbQ3+5MpOHOsDTu1LHhAvGLHZRDwfJ4sZuJ/JZoh5nyJVxZb/OiqbUK+88wGGgoDNI Nr8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:from:to:subject :content-transfer-encoding:mime-version:date:message-id :dkim-signature; bh=6UjzTo6kKJLkeVtxkIJDMzomu4dcIQKvoQRVUhtv+x8=; b=PqSWW747/caT+82eEveAqhFVLxNy4YFRhAEqdlQ94qCjPfSbdfyn1KRQE1gGJM5svm fco9oi8AnxirDSWbSC8Bnp3vGd11jxNdU7PFYMiTBx1yiEDXE8g/MsjsEpV+jftzy5PO XitliN7ZonIPYrmPXueEZlKKbubw0TDYIE78ysjq85C6sfYPoLqwlSgRF/KxJfQPBFhy oso2dMXVzLjAnFrSim+KzskzWz+8fzotr8VryoRh2YqMVccby9yMQda8Pk5xQNXG8hhG BS5UUwX9vbavlRr67kyXqBP98YGbuJOdARmW9waieKaD5v49nuOO7piVz3Jy4VWVwhBu wiCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=ftibM33U; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b17si17702086eds.13.2020.06.26.12.11.07; Fri, 26 Jun 2020 12:11:07 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=ftibM33U; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725816AbgFZTLH (ORCPT + 6 others); Fri, 26 Jun 2020 15:11:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725792AbgFZTLG (ORCPT ); Fri, 26 Jun 2020 15:11:06 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 497F4C03E979 for ; Fri, 26 Jun 2020 12:11:06 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id ev7so4563412pjb.2 for ; Fri, 26 Jun 2020 12:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=6UjzTo6kKJLkeVtxkIJDMzomu4dcIQKvoQRVUhtv+x8=; b=ftibM33UckAR0AQRwJCEc0N3RtukE/tcWr7W8C2v18E/QHcM3tbLBTqQSqVZ8e9PDa pTlaH8bhqVGpp6ZD6Jvn1VUJkukqNVhjUsapEOvwCwqSK1DmMbmJxbesGeEwRpZ2aVYB I2895JfEdF7L9L35GDRY0lcMuGP0VpzOfcL2KP0vpTPykQJ85Kf4OKA21q3paEMMuE76 nxL2LZWsDUFNO0d+9JH+3+uKeNGUI46di8fvVAIwpS2pX4z/WmJxf4GEjmYYTWDNLonR /XkfhepSXp1asia6CiiT5hbwvvywp9szOSpbyH2TJ2v9UX9cO9yQEYno+0BemwVFrOeB zJzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=6UjzTo6kKJLkeVtxkIJDMzomu4dcIQKvoQRVUhtv+x8=; b=LPXHhNEWJvkAFrCaIahMgxIPBnPUWrJdpJlgzZctAmSxhPurEzniwWFL0v7xs46qyG M3qMU0fGBtNJf4U29KMtoBjML8DNDqdAKT2Y9S5s2DdXgZa6YTA7UwfkokVDhuTBkvl9 V78XhQb2UKhoyoAH15fvgmFWeMowvrXAI4aFo7pWxRmF165OuKH9VjPpdYL1oKhriNMD 2NqHKTuDxWxc5IOn+NU+5fmVPVrwIq+L0qLFhg59KREJ1Ui9Gaay5FFOdIwOuaciOcPb SKFadsPEO+CjhSF+xRPCRaQHvXgtNY918nTx2QiHDrrvKkro9OyYp7/Heit+XSZerU2k S8Cg== X-Gm-Message-State: AOAM5328ZtLAYsGJohCIYo1TOkxCgto88QEgJMIEqZpCsE2I0WwZtOtx LNySTVO9pWBScJlVmpj4sFOQ7b1Z9Fs= X-Received: by 2002:a17:90b:2350:: with SMTP id ms16mr5162309pjb.127.1593198665787; Fri, 26 Jun 2020 12:11:05 -0700 (PDT) Received: from kernelci-production.internal.cloudapp.net ([52.250.1.28]) by smtp.gmail.com with ESMTPSA id z5sm978327pfn.117.2020.06.26.12.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 12:11:05 -0700 (PDT) Message-ID: <5ef64849.1c69fb81.2d891.248a@mx.google.com> Date: Fri, 26 Jun 2020 12:11:05 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Kernel: next-20200626 X-Kernelci-Report-Type: bisect X-Kernelci-Tree: next X-Kernelci-Branch: master X-Kernelci-Lab-Name: lab-collabora Subject: next/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15 To: Sudeep Holla , gtucker@collabora.com, kernelci-results@groups.io, Andre Przywara From: "kernelci.org bot" Cc: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, Liviu Dudau Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * * * If you do send a fix, please include this trailer: * * Reported-by: "kernelci.org bot" * * * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15 Summary: Start: 36e3135df4d4 Add linux-next specific files for 20200626 Plain log: https://storage.kernelci.org/next/master/next-20200626/arm/vexpress_defconfig/gcc-8/lab-collabora/baseline-vexpress-v2p-ca15-tc1.txt HTML log: https://storage.kernelci.org/next/master/next-20200626/arm/vexpress_defconfig/gcc-8/lab-collabora/baseline-vexpress-v2p-ca15-tc1.html Result: 38ac46002d1d arm: dts: vexpress: Move mcc node back into motherboard node Checks: revert: PASS verify: PASS Parameters: Tree: next URL: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Branch: master Target: qemu_arm-vexpress-a15 CPU arch: arm Lab: lab-collabora Compiler: gcc-8 Config: vexpress_defconfig Test case: baseline.dmesg.crit Breaking commit found: ------------------------------------------------------------------------------- commit 38ac46002d1df5707566a73486452851341028d2 Author: Andre Przywara Date: Wed Jun 3 17:22:37 2020 +0100 arm: dts: vexpress: Move mcc node back into motherboard node Commit d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices out of bus node") moved the "mcc" DT node into the root node, because it does not have any children using "reg" properties, so does violate some dtc checks about "simple-bus" nodes. However this broke the vexpress config-bus code, which walks up the device tree to find the first node with an "arm,vexpress,site" property. This gave the wrong result (matching the root node instead of the motherboard node), so broke the clocks and some other devices for VExpress boards. Move the whole node back into its original position. This re-introduces the dtc warning, but is conceptually the right thing to do. The dtc warning seems to be overzealous here, there are discussions on fixing or relaxing this check instead. Link: https://lore.kernel.org/r/20200603162237.16319-1-andre.przywara@arm.com Fixes: d9258898ad49 ("arm64: dts: vexpress: Move fixed devices out of bus node") Reported-and-tested-by: Guenter Roeck Signed-off-by: Andre Przywara Signed-off-by: Sudeep Holla ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [52366a107bf0600cf366f5ff3ea1f147b285e41f] Merge tag 'fsnotify_for_v5.8-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs git bisect good 52366a107bf0600cf366f5ff3ea1f147b285e41f # bad: [36e3135df4d426612fc77db26a312c2531108603] Add linux-next specific files for 20200626 git bisect bad 36e3135df4d426612fc77db26a312c2531108603 # bad: [11fdea666694c5c8c8a52cb75b2f0e70a2c2c201] Merge remote-tracking branch 'drm/drm-next' git bisect bad 11fdea666694c5c8c8a52cb75b2f0e70a2c2c201 # bad: [39ac1a242d0940dabd9192d99113c2b082ba45bc] Merge remote-tracking branch 'printk/for-next' git bisect bad 39ac1a242d0940dabd9192d99113c2b082ba45bc # good: [4a750150d9fe543e2163998501b3ad947d6dff74] Merge remote-tracking branch 'at91/at91-next' git bisect good 4a750150d9fe543e2163998501b3ad947d6dff74 # bad: [d7645ac1101c5160a05e2dced672a8d63c2a7ec0] Merge remote-tracking branch 'scmi/for-linux-next' git bisect bad d7645ac1101c5160a05e2dced672a8d63c2a7ec0 # good: [2408a915a05c109169ab689dc91ce31315406513] Merge branches 'arm64-defconfig-for-5.9', 'arm64-for-5.9', 'drivers-for-5.9' and 'dts-for-5.9' into for-next git bisect good 2408a915a05c109169ab689dc91ce31315406513 # good: [1679681fb8b2d169ac9d98660d7390620990bf77] Merge remote-tracking branch 'raspberrypi/for-next' git bisect good 1679681fb8b2d169ac9d98660d7390620990bf77 # good: [137233bdcd265762a251dfa24e82ebc5468e0ec2] Merge remote-tracking branch 'reset/reset/next' git bisect good 137233bdcd265762a251dfa24e82ebc5468e0ec2 # good: [99bcf38dd05b76b41f8564b53d9be6b44613fa92] Merge branch 'v5.9-clk/next' into for-next git bisect good 99bcf38dd05b76b41f8564b53d9be6b44613fa92 # good: [dc45e438fac0b5df3c31bb83f3d809cd0f67dcfe] Merge branch 'next/dt' into for-next git bisect good dc45e438fac0b5df3c31bb83f3d809cd0f67dcfe # good: [d6fe116541b73a56110310c39a270c99766cd909] Merge branch 'next/soc' into for-next git bisect good d6fe116541b73a56110310c39a270c99766cd909 # bad: [24077bf8f9e69a3a6a2c714634e6c813566a152f] Merge tag 'juno-fix-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into for-linux-next git bisect bad 24077bf8f9e69a3a6a2c714634e6c813566a152f # bad: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node git bisect bad 38ac46002d1df5707566a73486452851341028d2 # first bad commit: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node ------------------------------------------------------------------------------- diff --git a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi index e6308fb76183..a88ee5294d35 100644 --- a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi +++ b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi @@ -100,79 +100,6 @@ }; }; - mcc { - compatible = "arm,vexpress,config-bus"; - arm,vexpress,config-bridge = <&v2m_sysreg>; - - oscclk0 { - /* MCC static memory clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 0>; - freq-range = <25000000 60000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk0"; - }; - - v2m_oscclk1: oscclk1 { - /* CLCD clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 1>; - freq-range = <23750000 65000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk1"; - }; - - v2m_oscclk2: oscclk2 { - /* IO FPGA peripheral clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 2>; - freq-range = <24000000 24000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk2"; - }; - - volt-vio { - /* Logic level voltage */ - compatible = "arm,vexpress-volt"; - arm,vexpress-sysreg,func = <2 0>; - regulator-name = "VIO"; - regulator-always-on; - label = "VIO"; - }; - - temp-mcc { - /* MCC internal operating temperature */ - compatible = "arm,vexpress-temp"; - arm,vexpress-sysreg,func = <4 0>; - label = "MCC"; - }; - - reset { - compatible = "arm,vexpress-reset"; - arm,vexpress-sysreg,func = <5 0>; - }; - - muxfpga { - compatible = "arm,vexpress-muxfpga"; - arm,vexpress-sysreg,func = <7 0>; - }; - - shutdown { - compatible = "arm,vexpress-shutdown"; - arm,vexpress-sysreg,func = <8 0>; - }; - - reboot { - compatible = "arm,vexpress-reboot"; - arm,vexpress-sysreg,func = <9 0>; - }; - - dvimode { - compatible = "arm,vexpress-dvimode"; - arm,vexpress-sysreg,func = <11 0>; - }; - }; - bus@8000000 { motherboard-bus { model = "V2M-P1"; @@ -435,6 +362,79 @@ }; }; }; + + mcc { + compatible = "arm,vexpress,config-bus"; + arm,vexpress,config-bridge = <&v2m_sysreg>; + + oscclk0 { + /* MCC static memory clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 0>; + freq-range = <25000000 60000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk0"; + }; + + v2m_oscclk1: oscclk1 { + /* CLCD clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 1>; + freq-range = <23750000 65000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk1"; + }; + + v2m_oscclk2: oscclk2 { + /* IO FPGA peripheral clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 2>; + freq-range = <24000000 24000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk2"; + }; + + volt-vio { + /* Logic level voltage */ + compatible = "arm,vexpress-volt"; + arm,vexpress-sysreg,func = <2 0>; + regulator-name = "VIO"; + regulator-always-on; + label = "VIO"; + }; + + temp-mcc { + /* MCC internal operating temperature */ + compatible = "arm,vexpress-temp"; + arm,vexpress-sysreg,func = <4 0>; + label = "MCC"; + }; + + reset { + compatible = "arm,vexpress-reset"; + arm,vexpress-sysreg,func = <5 0>; + }; + + muxfpga { + compatible = "arm,vexpress-muxfpga"; + arm,vexpress-sysreg,func = <7 0>; + }; + + shutdown { + compatible = "arm,vexpress-shutdown"; + arm,vexpress-sysreg,func = <8 0>; + }; + + reboot { + compatible = "arm,vexpress-reboot"; + arm,vexpress-sysreg,func = <9 0>; + }; + + dvimode { + compatible = "arm,vexpress-dvimode"; + arm,vexpress-sysreg,func = <11 0>; + }; + }; }; }; };