From patchwork Fri Jun 26 06:57:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191810 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp214605ilg; Thu, 25 Jun 2020 23:58:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsWb6Jr0hDniwlLBPXAGWeO2CCOZlKpdNnQPxyt6aRyROT/jpBrJ2f72PPto+exxnxEMHV X-Received: by 2002:a17:906:d784:: with SMTP id pj4mr1244074ejb.405.1593154702814; Thu, 25 Jun 2020 23:58:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593154702; cv=none; d=google.com; s=arc-20160816; b=ndvP3nmFEqVhXzB8Zf+OeCdp9JJNFfY+qPqAe0zsgcii00iAwqmF28wsWAaiRxrrbZ pBUH8UU11jtcQcFRyNVCBu0O1Nu1Nt/eWvZ7ORAfYToBJF6ZmbITqLd/B52TLFQIRhlQ DbySPQ+6XsFEK7VpO+ZsU1LpQxbAwnGfYbIsPumsUvMebtQbx8JaVURrOoITASpYRAMU 9hb8HT9uSycGhf499uqEaI5pdg9ix8GKsbF4cMmRDlU+anbHgVyFWP5ZzowMUJVdjqMW Fhu3U6ASim2IwXLuDTbdfvaHx3d7Ff1W2r9Gstao2b3PUj4kf3stpVrM+VnTsPAU3u8P NVrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EQdtlCq0FayiIxw9Rs+gOrZ/5VZqnIsgjAQgaobsp4s=; b=z62d49PgnXrZhwFqM4UYyS6N2Bc/NFTH0/1PJwNfJAho6A4FT02SIUmTVFN2vn3mQr qsFBwhq15v+dJJceamN6TXOIf5iY+oSIrVY1b7OPTy8WMb0L86MvfPgJAAu9D3qsmoOo SCWekxPBd3M9zZJAoNkNX8tSrKKWl7kJ5VOKspTgqsQkdWo40fxXmGaciKBwc8CG4Zih EfDeVHgWAjSyI/sC9DtYTeWGqigSAbosmejqCykBuONgHFrRqLO6Yes+xZswPuIRR/Kb zXdu2WI9nxGzWqUoGwVZuc+G0W2H6zZBESuLMP7nnXWCTp1UXhJWqk4jvydXSDi4cdiR q2Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cU3REmEx; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cx9si8288473ejb.25.2020.06.25.23.58.22; Thu, 25 Jun 2020 23:58:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cU3REmEx; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728692AbgFZG6T (ORCPT + 16 others); Fri, 26 Jun 2020 02:58:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728586AbgFZG5q (ORCPT ); Fri, 26 Jun 2020 02:57:46 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4DDCC08C5DB for ; Thu, 25 Jun 2020 23:57:45 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id k6so8377349wrn.3 for ; Thu, 25 Jun 2020 23:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EQdtlCq0FayiIxw9Rs+gOrZ/5VZqnIsgjAQgaobsp4s=; b=cU3REmExdXZnTF1HXY2PtQ30RmVx7lx6+g3J32TSut/xk7G7p7XuOcEJLmRCbZ1oAr yxV9KPJUZZxSbh1LCZe2jrxDJ+MPWPlh0BioUJLmX/EUALUyyccsVlG1MH1dkpOLRMbg F1qIyO8QOKmF/5DVafM5L6c29Kmb/zbFn7/mZAHvQwjiHO04zXvrQrvjofjw6jUuyN1n mP/+VZDB0onc+Z+oo783ZaFEVi8BQHwkpLhTxi8/2m/2B8ctw2r2H/OwnpQMJBAjCEAO SGmQdBYITEgfwziCb87ej+7xh0NjA/L6OCgXbTy+b95YSxVc84h4L5vpK1eAZH5R/Qp9 gajw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EQdtlCq0FayiIxw9Rs+gOrZ/5VZqnIsgjAQgaobsp4s=; b=q3lhmlxmnzunrps99ecOqwYuyZAcVbrfarA1reJGz25QBeA4jAK2nkLALQFB6if8Hu cRo0CbpqgExTL6J/IWdV6VBm+uocGH+kQMpvLTRrHpseKBU8sW6AgQ40HOBZ/sIYR+mS 3UB2cmJCtm3XS5cnPXf1AdvDE9CbtkBRVc8G0djjpV3iz9hKCd71e/NgMBv9SiWKgcrs ubLknbaC7bB8J05f2W8RLXc2T7qmar1bnDthzv/QWhlC+rpFT8+q1cFQ4BCBcJoZR1j6 SZkVzf3EMbygop+KlJ9iNZUT25yzhlCDuxFkFW6t5qJkTvJpaVx2nGv4yn3ZIdnyEJTs Bvow== X-Gm-Message-State: AOAM530SLAO2/9t3niWOXcL4mSoV+WUF+w1zpU6GSKHwFVeZh876VuRn qRO+808QOVGH4rA1ig/p59nPTg== X-Received: by 2002:adf:fa81:: with SMTP id h1mr2187942wrr.288.1593154664379; Thu, 25 Jun 2020 23:57:44 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:43 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Subject: [PATCH 2/9] regulator: qcom-rpmh-regulator: Repair dodgy kerneldoc header formatting Date: Fri, 26 Jun 2020 07:57:31 +0100 Message-Id: <20200626065738.93412-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org W=1 kernel builds report a lack of descriptions for various enum properties and function arguments. In reality they are documented, but the formatting was not as expected '@.*:'. Instead, some weird arg identifiers were used or none at all. This change fixes the following warnings: drivers/regulator/qcom-rpmh-regulator.c:33: warning: Enum value 'VRM' not described in enum 'rpmh_regulator_type' drivers/regulator/qcom-rpmh-regulator.c:33: warning: Enum value 'XOB' not described in enum 'rpmh_regulator_type' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'vreg' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'dev' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'node' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'pmic_id' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'pmic_rpmh_data' not described in 'rpmh_regulator_init_vreg' Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/regulator/qcom-rpmh-regulator.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.25.1 Reviewed-by: Bjorn Andersson diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c index 79bdc129cb504..08dcc614efa7f 100644 --- a/drivers/regulator/qcom-rpmh-regulator.c +++ b/drivers/regulator/qcom-rpmh-regulator.c @@ -22,9 +22,9 @@ /** * enum rpmh_regulator_type - supported RPMh accelerator types - * %VRM: RPMh VRM accelerator which supports voting on enable, voltage, + * @VRM: RPMh VRM accelerator which supports voting on enable, voltage, * and mode of LDO, SMPS, and BOB type PMIC regulators. - * %XOB: RPMh XOB accelerator which supports voting on the enable state + * @XOB: RPMh XOB accelerator which supports voting on the enable state * of PMIC regulators. */ enum rpmh_regulator_type { @@ -399,13 +399,13 @@ static const struct regulator_ops rpmh_regulator_xob_ops = { /** * rpmh_regulator_init_vreg() - initialize all attributes of an rpmh-regulator - * vreg: Pointer to the individual rpmh-regulator resource - * dev: Pointer to the top level rpmh-regulator PMIC device - * node: Pointer to the individual rpmh-regulator resource + * @vreg: Pointer to the individual rpmh-regulator resource + * @dev: Pointer to the top level rpmh-regulator PMIC device + * @node: Pointer to the individual rpmh-regulator resource * device node - * pmic_id: String used to identify the top level rpmh-regulator + * @pmic_id: String used to identify the top level rpmh-regulator * PMIC device on the board - * pmic_rpmh_data: Pointer to a null-terminated array of rpmh-regulator + * @pmic_rpmh_data: Pointer to a null-terminated array of rpmh-regulator * resources defined for the top level PMIC device * * Return: 0 on success, errno on failure From patchwork Fri Jun 26 06:57:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191807 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp214402ilg; Thu, 25 Jun 2020 23:58:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTWv2gll+9Keh9SdXLzur5UVa6QuIYNvwxDmc+7Q4/CqeQc4d2xsuGso53amaujgirepe5 X-Received: by 2002:a17:906:8381:: with SMTP id p1mr1302449ejx.280.1593154681828; Thu, 25 Jun 2020 23:58:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593154681; cv=none; d=google.com; s=arc-20160816; b=kyfXmH6PBF2XUEQcF0lksXiEGdh4fCbcB57RVzzPX+wX53pmeemgz/Gj6VTvIhRz69 6iI1I8d0B+lVN17f9zPYJTo5CnL4s3cUY4uBkJ/OKER6RYcbfc52HQSOpCF+vHHhyYpK gones1HgjhXG5CtcI3D7SwwpkmkcIhSa3YJ7xuzSrOezPsnnOmMnOc7E3qJZmSS60XWR aK3ehEK7c0hcutmyMYFJ/6B1OcEklnpoMBunV/jy1dQPyipTpUX7Cv3Scnm/Je+AnqNs zZUeCy25jSWU8JikdWk+DXzdXUpEFMPB4Zk3Urhgbo6YR5IDuYdbqv3dEF1GesTuP+Y+ tauQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LPP/UO1S0fFlAO//S91M0USmj0hNvysUxqLwY/EHMpU=; b=O4Q3f4snFZbeFd4nrFBOQRxBcwMylB0wNpc0EyoIsePwrQNmldU75fUvpruEpCLHQa 5oPsh639r2+mzLqhE1Kmdqv0uLSMwukbITbwzr+IWsSFjC3XXZHAhdttd58v5UP7MBCB KKknAVcZ0e0zEvQr4fgKo658I55oaW2ppbnalE/D7+1IEWrKjZcysRbtyXvXAcyx6dhE +2Y+Xu03uAKHXLAcwhWo6dzv6YYEfzTPjIY70sIUVglnXNyn24HgmS8vb9ot4LA7nmwP Ytc+DyvnKSDyGTfmyJk3hI3yhCG2igCjxWXIEfcj7NJAm+NPGiP1Vjdfzmv7KDoJpVSk 3nsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o4qPuOSq; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ds3si20226406ejc.545.2020.06.25.23.58.01; Thu, 25 Jun 2020 23:58:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o4qPuOSq; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728610AbgFZG6A (ORCPT + 16 others); Fri, 26 Jun 2020 02:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728634AbgFZG5y (ORCPT ); Fri, 26 Jun 2020 02:57:54 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE893C08C5DE for ; Thu, 25 Jun 2020 23:57:53 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id g75so7769963wme.5 for ; Thu, 25 Jun 2020 23:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LPP/UO1S0fFlAO//S91M0USmj0hNvysUxqLwY/EHMpU=; b=o4qPuOSqulK9KuVSnsgC92nheOHo5sPkiZnIT04OlBWs0kqtIAb1N4z9yQia5M2icA guTWlRhrkyCoWzC3edxywWhCMB3kYYXx9d8LTrmQCGfjb/QaOR6ps5jq6FstBy2QKQJb plyMLcEJmAyltVcNPygxskIaJ7VzzxZD4OsFPUEhxq4+1VRKnED8SBVFGi4HWn9pUxx+ tLSKSQgUHmlCfWhnt7UMwcLy7gfDfBLZbhv5ML1APO4aygCLEAPPS0iKzMTl7AMxCCSl d7BR7Lw8RUp82W2CZ80jxbfRBZ1g1YuuLsfxPW4NCtWVmtct5JlmAwZ+yoIeeDj7kiuO Werg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LPP/UO1S0fFlAO//S91M0USmj0hNvysUxqLwY/EHMpU=; b=uPW3+6ZELUiyJrtyHNhYCESY3rcRNNMfMqRKB9lGn8cLAKdEsRG93xCOHhYAw7RjcC Nmb4eAK/FFYXgYfjvjyoK1bqvEIyN/kbwGL4/qiGLsblYwg5XkpUeCEvc1AtGQxRIdMz VkqEZ8sWwcBNbemD8oKLT/ktFWZsROa3U+n1kC0U5zryDR7q9Xu3HWBQnP/yTZtBZI1i yHALoi6vNAOrz7NLu+igZp3SN3QxDPG4Q5lj2wT3RMY/aE42m8fcz7CSqZnaCkCZtxl6 Thaz9U5O4gqRKZ5tWrBhSlE7ZN2YsjVPKxKt5Im2Qhfi+/u/PTkD+ZV2hKAEqCPq2Wzl rEgQ== X-Gm-Message-State: AOAM5300CwhciuLabUmI1XxbZ8TbkWX1NZFoAqY6VVKD64HsEAGzo2+5 0XcfH+fjQJvDAjJnluaghbCEoA== X-Received: by 2002:a1c:1bc4:: with SMTP id b187mr1906640wmb.105.1593154672520; Thu, 25 Jun 2020 23:57:52 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm15355269wmi.35.2020.06.25.23.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 23:57:51 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Subject: [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct regulator_desc pmi8994_boost' Date: Fri, 26 Jun 2020 07:57:38 +0100 Message-Id: <20200626065738.93412-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org> References: <20200626065738.93412-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This was an upstreaming error. Remove it as it's not to be used. Fixes the following W=1 kernel build warning: drivers/regulator/qcom_smd-regulator.c:477:36: warning: ‘pmi8994_boost’ defined but not used [-Wunused-const-variable=] Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/regulator/qcom_smd-regulator.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.25.1 Reviewed-by: Bjorn Andersson diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c index 53a64d856926f..4c0a469d8a115 100644 --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -474,15 +474,6 @@ static const struct regulator_desc pmi8994_bby = { .ops = &rpm_bob_ops, }; -static const struct regulator_desc pmi8994_boost = { - .linear_ranges = (struct linear_range[]) { - REGULATOR_LINEAR_RANGE(4000000, 0, 30, 50000), - }, - .n_linear_ranges = 1, - .n_voltages = 31, - .ops = &rpm_smps_ldo_ops, -}; - static const struct regulator_desc pm8998_ftsmps = { .linear_ranges = (struct linear_range[]) { REGULATOR_LINEAR_RANGE(320000, 0, 258, 4000),