From patchwork Wed Jun 24 15:06:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191694 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp677606ile; Wed, 24 Jun 2020 08:08:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGipjhLQ8OoOVaOarfIPoid7GHlIdUR58+tXwe4KdV7DGTPsvRqy0Nka44CBSBTRxiuxoW X-Received: by 2002:a17:906:3192:: with SMTP id 18mr8498224ejy.208.1593011284735; Wed, 24 Jun 2020 08:08:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011284; cv=none; d=google.com; s=arc-20160816; b=rdi8oqwHMiHXyVA9t1FjI/qIhMdcavaJPttcX/5db9GR+SSu/ssjULLgRtkE7HB0lf NNdshTKtQ3FAhNHNrnyFbpD5RT8sO0FkpX3qsT/f6r+ynN/ehBAtJQTP7YN6Z2QG78Jy T8nqZ0TUT2tvj/Dx8xWv6dlwRoFLKNHALfEzpqV4kO4Rn0Iptqdi2opCR/pcoCjxsPM2 nFoCxltrKzBnB+zxKM903ywVbgDDHqZaT8/vJ9ZMq/1uHUyTTt8iqC4VmHJfXx+q6sRY bMYXSPlTRLTcJk5S1kcMuUuiYmmVmqt5p1k250O2ptEUt2kS+k4vGphlVsnWa+ckneN7 I2Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=g3Z/1Sd7KiUmvxa4jor9PLam8Q3K0QVIvvAftZ1YelI=; b=p6gN8eQaqFnVxUpFG147JfDiBPbAti52tgAiWGK2H947MLtv1S78sib6NDUNjKPnWE ktb/MCXeT6AGb27IeXs2OYuj/3XUCPHQDZ10rgQXbptSU3Dgma1Z2+etqvcFwACw3Ui5 Te1tfuX2mXytkioZo+Dz8oNp8G79R9adYLp2cztLz/T2fZ4RTsGu6Ys9bgl/hS1GXLBk ldwNPrXqhhSX78YQoUxh6nqKKT0ScqONl6nVr3cbl8oiOZPhebKHzm9cm+ZDQlT7UVkB IkCShfFw8v/6esBYbmI9CagECrp9nDI3N4jR4hGCii5Wrp7xH822uDImnA6gommyKOiT 8dTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dbjw8KGX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s14si1843822ejx.43.2020.06.24.08.08.04; Wed, 24 Jun 2020 08:08:04 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dbjw8KGX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404140AbgFXPID (ORCPT + 15 others); Wed, 24 Jun 2020 11:08:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403831AbgFXPHO (ORCPT ); Wed, 24 Jun 2020 11:07:14 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405D3C061796 for ; Wed, 24 Jun 2020 08:07:14 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id j18so2650319wmi.3 for ; Wed, 24 Jun 2020 08:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g3Z/1Sd7KiUmvxa4jor9PLam8Q3K0QVIvvAftZ1YelI=; b=Dbjw8KGXNnJR4/Cv9UY5wql6tvwgAVUE3t+Ql2V7uqKucZ/2lLic1lPgg7arybg/Zv BPvQSpSjk+WFFTm6Ryjn5CCh5S44hDzHQealupKltEpkDgvluJwY4Vyyh1+bDYHsLFvR XxeB3/USF+YNB0BiW+2J7WhBAPKe9YtuzvMBzMUN5NaIjjygKhjsdMOwmU1NEwTHTPVk 0Jo2DMHgKs557saxVmYCP4vImoVwz7KcSk9WdMgBLHj74Kyjb9GIOtjBuAtNQ9VIRtoD V8K7Mx1uw2+Lt9rme1GVEtyg99f/y8opZ4jln0sKsUb/oiikPgu5OzLfhFqUCfbTBiNF 3qIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g3Z/1Sd7KiUmvxa4jor9PLam8Q3K0QVIvvAftZ1YelI=; b=UsWxhxdC8eAGne2sNSKJilsJgAAfHa0wX3fR8inIBNQGRGhZNs7+F4D4/PwIwvypTz DDtBRqntkiV6EopvGgXP9MkVgATkjCGdqf/iBFcJ6zggUqQUPccjJSnCmUtw5d7GB9wr rbczHmsR0y7Cpi0q9J7cvPJmqONycGL+p1+Gb3Tn9rtIepe8+uxcYpaqNKELRl4mqGSy xybFDMWOXv0ld7J5+Le/5fMnlS6KjlZzbdXMiPx7x1UEYX5rGNAxz+8DTaAfFFlmKU6a 5y0147rnRPwHJpEqQW2vMfsvqMR+p1bZALCzVn+m4D0YrmQAqTJH7qccOOBvYClDiFH4 +5pA== X-Gm-Message-State: AOAM531Z3qjJyvmxz52vTiWAOvn23i8cwe5Eib1+Q5fkSM8NQy/cTfa7 Sl0lPPDyWm4aSHfynkF5P5nVpw== X-Received: by 2002:a1c:4e1a:: with SMTP id g26mr29750762wmh.148.1593011232892; Wed, 24 Jun 2020 08:07:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:12 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tony Lindgren , Kai Svahn , Syed Khasim , linux-omap@vger.kernel.org Subject: [PATCH 01/10] mfd: twl4030-irq: Fix incorrect type in assignment warning Date: Wed, 24 Jun 2020 16:06:55 +0100 Message-Id: <20200624150704.2729736-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Silences Sparse warning: drivers/mfd/twl4030-irq.c:485:26: warning: incorrect type in assignment (different base types) drivers/mfd/twl4030-irq.c:485:26: expected unsigned int [usertype] word drivers/mfd/twl4030-irq.c:485:26: got restricted __le32 [usertype] Cc: Cc: Tony Lindgren Cc: Kai Svahn Cc: Syed Khasim Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mfd/twl4030-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index 910a304b397ce..d05bc74daba32 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c @@ -477,7 +477,7 @@ static void twl4030_sih_bus_sync_unlock(struct irq_data *data) if (agent->imr_change_pending) { union { - u32 word; + __le32 word; u8 bytes[4]; } imr; From patchwork Wed Jun 24 15:06:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191693 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp677567ile; Wed, 24 Jun 2020 08:08:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmgq4/L/xo7sWstRWBQS42t5JW90UM0/qm1dQYlWdkFqPvFxbiC7vtrobYVEf+0EJUkULe X-Received: by 2002:a17:906:fc20:: with SMTP id ov32mr23893097ejb.531.1593011282498; Wed, 24 Jun 2020 08:08:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011282; cv=none; d=google.com; s=arc-20160816; b=g5hpJ0ECB+6Bqq46rWGXYeqABJ+t9JuKFOwcW/ctKIrXSoypdWmZUZyFjeHwRhI4Iq XMVnyZGXV3NA0qe5yANNoe07/vV18j1+/l1ZDXPFbcAVMD/WnuFHQsChjfy4M5hQD2vv Haa4B6dMMFaZEQbkeUTRwGW8p4zh3NKhE9cFA3yx8wnEnGlWqivEqUCF/mO4kx8624C6 55kVC6thxQjIQoF4nJk4BD12T8MbFxOlpHkwMr7HcZMsS8qWmsPxgmhFDSukpSszgRE7 7BTrCz8xDkcXWSDfbF39CbTMWXqoHcwUnFWLERaZgu2lj4wbw6Apjkw2SFFehsra9eHj PSWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=s6bqmwyzyHG2RdGTyEeF3lokJJurQOvKiY/PaolAzM0=; b=GDVG2gpw3L0WE+aYkwOYKNjFjRDf1TzfN5raRTlfd+AoDShhZn32PLoxvrJkR8pWbP vJdhTCziRqVgMr14+UtpGnMDycrO7JfCOmQL63Kg8o0TvgpBnhj5nufPWoNucapqKllx uB5WFurjCe4slVuplFz++8pVmg6QKdemYkmcW0KcDKKmhHcfmCQD5Mh3HXtSJEbgBo5j LlP7mSR1yHjLc8cSUyhbnzHoLTgye9AFYVsuHNU3i10Uy/pVl49bXYT+i9az3C3P9s53 Hk2bKhCo03GKUea6z+x3FSAX6xqvotUrnI+evVS6oQ36jO2B9OWRy/jV0CbrR8oEkYBT q+xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="UDb/Vse+"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s14si1843822ejx.43.2020.06.24.08.08.02; Wed, 24 Jun 2020 08:08:02 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="UDb/Vse+"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404427AbgFXPH4 (ORCPT + 15 others); Wed, 24 Jun 2020 11:07:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404135AbgFXPHQ (ORCPT ); Wed, 24 Jun 2020 11:07:16 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F7C8C061797 for ; Wed, 24 Jun 2020 08:07:16 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id l2so1381508wmf.0 for ; Wed, 24 Jun 2020 08:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s6bqmwyzyHG2RdGTyEeF3lokJJurQOvKiY/PaolAzM0=; b=UDb/Vse+j4PLUklMPE1jOG89dEqQuO2i7OzePR1xZB+Siiw5RD0TNhZ61xg09kUs89 /j6gfY5MnzUfpvNACK/AyPui2vyY89OSGCOHsoIVLaqSqPW9LpLNZAFOlC1J8E0fmIdp an9XJ9DImy6JVYbEUnIPVyxSCmwdNyhEkapxPgOahBtkigo0F522HmM5oAB7yoM0WR1U D32plII+0qv9D9duq0tohxdfVCI6gjoYS/9hQYTQQmTvnHOBVyeSxKVGEiIKxXoGzl5B Ax/pJQOymt1mxWUlguQssE0BX/ehCYDcRuTAyJiWxEyRVtjn0QJTfb+Hq32A+W97Jhov Ch/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s6bqmwyzyHG2RdGTyEeF3lokJJurQOvKiY/PaolAzM0=; b=VA8Lj143XQAJDUoSu2gJMr2tWWrecKsKBC+Iq9aDVOoh/DPijLmFBc4QPme+IL9DtW B8bNZROSD6YqELkQce2lfNCnplwl1f1vIBXhK9K23YbSDcOjCGKFHcfGGeo6aSq5UwUt uUIIF0jwlr0G8mzCkc/zcgTA2gcExWtEs58pZrr/dOeYPVG2zHFCRZxPr10IedMVg7jY D/ZWS90jx7uZatYjCq15DowMW58YxBozmjB5vE+bRAThzWjdznUdiQPyQhPRLzm00YG6 0CWln0zY30ZIqc0qmC+UCXU2xUQVIc8eA7R5tk1uaooXuSMUsGBJE8ixbwruBGImk1bQ MGBw== X-Gm-Message-State: AOAM533Ldjan5I/rhQgjr0WuHsx5mKDQhRn9tWCbDJSqN8t1YOahexgJ nPJPsY+Y/DnXsHRA3m3q2QCfRA== X-Received: by 2002:a1c:3881:: with SMTP id f123mr29878381wma.178.1593011235038; Wed, 24 Jun 2020 08:07:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:14 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mike Rapoport , Eric Miao Subject: [PATCH 03/10] mfd: tps6586x: Fix cast to restricted __le32 warning Date: Wed, 24 Jun 2020 16:06:57 +0100 Message-Id: <20200624150704.2729736-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Silences Sparse warning(s): drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 Cc: Cc: Mike Rapoport Cc: Eric Miao Signed-off-by: Lee Jones --- drivers/mfd/tps6586x.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c index c8aadd39324e3..c36597797ddd8 100644 --- a/drivers/mfd/tps6586x.c +++ b/drivers/mfd/tps6586x.c @@ -309,18 +309,19 @@ static const struct irq_domain_ops tps6586x_domain_ops = { static irqreturn_t tps6586x_irq(int irq, void *data) { struct tps6586x *tps6586x = data; - u32 acks; + uint32_t acks; + __le32 val; int ret = 0; ret = tps6586x_reads(tps6586x->dev, TPS6586X_INT_ACK1, - sizeof(acks), (uint8_t *)&acks); + sizeof(acks), (uint8_t *)&val); if (ret < 0) { dev_err(tps6586x->dev, "failed to read interrupt status\n"); return IRQ_NONE; } - acks = le32_to_cpu(acks); + acks = le32_to_cpu(val); while (acks) { int i = __ffs(acks); From patchwork Wed Jun 24 15:06:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191691 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp677340ile; Wed, 24 Jun 2020 08:07:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKSuAH/obQ5TyiOYn0ngTex7epPuPiWR5mEl1gnwfKjB2EW77ApjvmTK0//kHWIboeIcZg X-Received: by 2002:a17:906:2c18:: with SMTP id e24mr12319677ejh.335.1593011268628; Wed, 24 Jun 2020 08:07:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011268; cv=none; d=google.com; s=arc-20160816; b=OEMaYjXbVrEyWKT3VxRkupjTFBXZPK4P+BbJdOzQPLva5vxkHF4ofqmTmWam7zkm6P cKyjLmS0d8cf04nhpN90pKiUBU/SdLiSCdEvrXZsDdP54xdPo3LEQXwU+mVYSN9RSOMJ 0X+2BP4C+Ihrbiu9+FXnBaqH9bmm103YcsBEHJAkRux370DLEqVinBiBU+lI2f2R6SBI kYeZJP/5QYftEMveGFne+45k6XNeSp6HBLA8vXBmvWHqE1GCt6MSPoEV4IuX3Jv+YHJq 9Nldvtd/Jka9GM+lp4A3E7S9vN0j3LyH7IM1P00w+hgaai1VrE+QpomnHc8EH4KoEREn PTgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mWlJbsdlqYw5jcyMhAAPjydUuATe963bkCaEYyUu7rs=; b=QuyRD3G7M+Yti+Q458A0FlO5nW/YYZxv1U4nsHZjh8g392pHV5PA3RDaGm96QynHNH SOVJG1t2jeiQvrOgiR/o8vs1dTPyjVKDAwvU5xJiINZIo75LOYraj458d7i5SEvpjvyA hqGiBOZmEBtxcO9S++DlN/GZEyKrQB4O1CkiUSa/YJoYDzMf8DSVBgHUS2sCOmPZgCz/ G6xeaPe8R52WZZ7ZQpOjBRTR1W8khVYRDAKCp74J4ik2bfEHW2+Nfr+bAB9O4Ogrgz3e 6iUusHLLtgdAeJ3l2CWgTAzi1LIVsQkkkcAmwWeAxdX+RIsyjupeyUC9VZxejqxoikA3 fqYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fDNdhuKb; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si12817081ejd.191.2020.06.24.08.07.48; Wed, 24 Jun 2020 08:07:48 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fDNdhuKb; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404379AbgFXPHq (ORCPT + 15 others); Wed, 24 Jun 2020 11:07:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404169AbgFXPHS (ORCPT ); Wed, 24 Jun 2020 11:07:18 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F90FC061795 for ; Wed, 24 Jun 2020 08:07:17 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id b6so2613053wrs.11 for ; Wed, 24 Jun 2020 08:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mWlJbsdlqYw5jcyMhAAPjydUuATe963bkCaEYyUu7rs=; b=fDNdhuKb0j3VVPDO8tDSy54CPULXaYK08sbKQIDy3ep1JOR9nBbVcUbCnIFZr5CSGA 3eEaUEy+1pLOj1z8WJl90MkZZFGGT9kDKYYvy3RI+KX1vuVVu04bxyv83MTjlwzOuWzF 3ZZ83AAafizu+5VZcyLjnzxd75QECfrxUTAwAfV1BnF1c01lu0M5M14g6I5rQJls58v5 STkDxI2Abl7qHAmtVyhd1iATdTFvFTyzTTPld5HJVriQgOMSNPGl/F7gMLR4eKX7QO6Q kTZFbd3qnehapxU5N/pyDV/KutSTw85dKRtaeRBtU3HYGlLQ7Pg8Gg33Pb89SizVNWQa lxnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mWlJbsdlqYw5jcyMhAAPjydUuATe963bkCaEYyUu7rs=; b=TWpxHwHUb80zZBhbf6PiUcBwbcajFt/u1XrcB1Raxo5rVjXTIqyUOMyPAqXoqceiP+ nrBSCpoVKTNC8sjSDPVJzTTjW94m4X3k0ovQQzTB7ph3Xxy4kx/Eb/L1U0J17GNt2WDg 4NYZudZLmEjBR/WnI9oX/yYYuUCgiIqqnYvOkOIh2b7Cnx+w4iDbaT40jFPpWpKP3Iv2 MAxRpRvMtGIYdRqtK6LNiEoTu9UXdxEGuNIE+1QzRGV+7Km3n5em09ORl5Vd6svMEE/1 xfoYPG59UtErEqh211trejfk+yd8FZ3LFUVJOi0z3RqkDBmRl2yCJJPjkvoDMNGwH+In uPKA== X-Gm-Message-State: AOAM532odfTAYuJuoskmuqKsA8+gU1OjO/YRVQEGdVGiCFeUO0Yd2/lh ncDDtqEhPEKHhAgZU389QZQlEA== X-Received: by 2002:adf:e4cc:: with SMTP id v12mr3692714wrm.92.1593011236167; Wed, 24 Jun 2020 08:07:16 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:15 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Thor Thayer Subject: [PATCH 04/10] mfd: altera-sysmgr: Fix physical address storing hacks Date: Wed, 24 Jun 2020 16:06:58 +0100 Message-Id: <20200624150704.2729736-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Sparse reports: drivers/mfd/altera-sysmgr.c:150:30: warning: incorrect type in assignment (different address spaces) drivers/mfd/altera-sysmgr.c:150:30: expected unsigned int [usertype] *base drivers/mfd/altera-sysmgr.c:150:30: got void [noderef] * drivers/mfd/altera-sysmgr.c:156:26: warning: incorrect type in argument 3 (different address spaces) drivers/mfd/altera-sysmgr.c:156:26: expected void [noderef] *regs drivers/mfd/altera-sysmgr.c:156:26: got unsigned int [usertype] *base It appears as though the driver data property 'resource_size_t *base' was being used to store 2 different types of addresses (physical and IO-mapped) under a single declared type. Fortunately, no value is recalled from the driver data entry, so it can be easily omitted. Instead we can use the value obtained directly from the platform resource to pass through Regmap into the call-backs to be used for the SMCC call and use a local dedicated __iomem variable for IO-remapping. Cc: Cc: Thor Thayer Signed-off-by: Lee Jones --- drivers/mfd/altera-sysmgr.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) -- 2.25.1 diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c index d2a13a547a3ca..83f0765f819b0 100644 --- a/drivers/mfd/altera-sysmgr.c +++ b/drivers/mfd/altera-sysmgr.c @@ -22,11 +22,9 @@ /** * struct altr_sysmgr - Altera SOCFPGA System Manager * @regmap: the regmap used for System Manager accesses. - * @base : the base address for the System Manager */ struct altr_sysmgr { struct regmap *regmap; - resource_size_t *base; }; static struct platform_driver altr_sysmgr_driver; @@ -127,6 +125,7 @@ static int sysmgr_probe(struct platform_device *pdev) struct regmap_config sysmgr_config = altr_sysmgr_regmap_cfg; struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; + void __iomem *base; sysmgr = devm_kzalloc(dev, sizeof(*sysmgr), GFP_KERNEL); if (!sysmgr) @@ -139,22 +138,19 @@ static int sysmgr_probe(struct platform_device *pdev) sysmgr_config.max_register = resource_size(res) - sysmgr_config.reg_stride; if (of_device_is_compatible(np, "altr,sys-mgr-s10")) { - /* Need physical address for SMCC call */ - sysmgr->base = (resource_size_t *)res->start; sysmgr_config.reg_read = s10_protected_reg_read; sysmgr_config.reg_write = s10_protected_reg_write; - regmap = devm_regmap_init(dev, NULL, sysmgr->base, + /* Need physical address for SMCC call */ + regmap = devm_regmap_init(dev, NULL, (void *)res->start, &sysmgr_config); } else { - sysmgr->base = devm_ioremap(dev, res->start, - resource_size(res)); - if (!sysmgr->base) + base = devm_ioremap(dev, res->start, resource_size(res)); + if (!base) return -ENOMEM; sysmgr_config.max_register = res->end - res->start - 3; - regmap = devm_regmap_init_mmio(dev, sysmgr->base, - &sysmgr_config); + regmap = devm_regmap_init_mmio(dev, base, &sysmgr_config); } if (IS_ERR(regmap)) { From patchwork Wed Jun 24 15:06:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191692 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp677478ile; Wed, 24 Jun 2020 08:07:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlh7RCPi/3L7Z6rY4GjU4m4VBKE62hfJ77/JiBfDo2ECZA8VCmqjr2OK10nJIJ9spnd0FX X-Received: by 2002:a17:906:1d5b:: with SMTP id o27mr25106737ejh.344.1593011276347; Wed, 24 Jun 2020 08:07:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011276; cv=none; d=google.com; s=arc-20160816; b=htmOmVGyz1zsl3szw2uIZ6j7nSPiiAT68Az9YTSxjrv0YFM7JlTRPqqh1d+tqo3FhP 2dv0qgtq+lBep3k6xD3I1I/kQtxdS1H0hr9j58/P2umdGAL0xLezLrJGv7xc1lCur8/V HYzKA6wtC+tds89PT/mFy/UBf12x0tTbY1WT/rFHXPW0rX/kE4NPskXM0BmlmCspkAFt Q79bcKvvidsse1lMcBettyMMt8xLYYV1t5b2ZfH2TlfKGtaz09QUYSSZA9B1U3/D+zUz zK38YEEoT++UD2v1nPTVtWv+PgvoxlkYfIHp3XpTPSipiQCRIsOKdZFYnnEKCuQj/SX/ D59A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=C0YMw50ghAnk+HJlng7jm1/7u29zz1+p4P4aWF+LxTM=; b=MJ8ORf3nCx8VWuE33Yv+QntRlxLeMXbyQQJNtUuvCFuXzSu2/mr4M67VOGFMrAfh4H PM9tQrqYKF05pcaeTLVNRnr6c2B9zCAszyP1TZ3muf/B7L1Sg4rQIOG2qi5E29d2nHP2 JKWlEhJ0DuJJQIB9iedfOuObsremSg0vEuLa0W7TieisskX2WIMX8qsYPoFP8IgNEsi0 rzDfz+LbPmFlC3NrC5azpmio1l2F7TmSa8mE9Xl6CrOxFYYcuN2ZN02Hv5sQvnL1BF8E Uc9C2JHn9wg+PN2HLnn8WifpRJW461CRRqKIY56TL/j7bnKbM+fiogA2QFwtkOnxrGIH +IVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kDV2gBaw; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mh8si3774491ejb.245.2020.06.24.08.07.56; Wed, 24 Jun 2020 08:07:56 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kDV2gBaw; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404243AbgFXPHq (ORCPT + 15 others); Wed, 24 Jun 2020 11:07:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404187AbgFXPHT (ORCPT ); Wed, 24 Jun 2020 11:07:19 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65D52C061573 for ; Wed, 24 Jun 2020 08:07:19 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z13so2640718wrw.5 for ; Wed, 24 Jun 2020 08:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C0YMw50ghAnk+HJlng7jm1/7u29zz1+p4P4aWF+LxTM=; b=kDV2gBawSXjgK3E9pSWH7A3EwP21b+YwX9fkeeuRcMt8E5kiFMZWVW0uYtCNOKcJuj IlqNWloTM+FAEb+U0biu0LntpBbm0JAACtz0XyTEmV/gKbjUFfaJRomKsF4zGlZT6I6p LWpzY3Sh6pcWRuViXK7g/WZpDc1qvOlw/ZeK6Ed8mKvL+wr7SabH/mKNbAPxWZApEJFa gnE8MA+E6U/pAaKDfv5CX9jACfdEpHTXEEfxN3ZvrkXac3mtnPw7zaScjyiQv+xl5GaK nJtMTi3C+ufi2umQbtp/YQ4YV/LWR8gsuIQXPdgTB0GBXH/9BabuZmOM7P9L0JNXcm1i 8fDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C0YMw50ghAnk+HJlng7jm1/7u29zz1+p4P4aWF+LxTM=; b=C9OqMAfYD0pDrvxmwlnkeZhlXQxrK5K2f7ODkOVjVHb+1+tcHpKls1l2ucNKcW4RCn CuYKTdp4RmgKqlKSm/DBJJDr72poSBSZ6O69iYih3O7hN2IGy2ICMdoKc3PoJ6XobOP6 soQ/WXW0HstfXVyYHYpil+/XAbXH+cEWwK2lAJQmTWNjAz8ZO713ojCdl62LrzdZlqw8 jAkdOnCtpoUybkbocZoUBrtozriMYU1PTV/Lj2UGJUI8nUfG8Gop89aB/SZ+AVv1bekR UWdGM8iseOhytXlyyaTYQdq6G86yn3nLKioTFyOm4reG9QRWEvLL9ueHZCL9b9iSFDR4 ELeQ== X-Gm-Message-State: AOAM533oV/DlKqhZb+kOVI3Q+2IU4akGxXRmQwOXAoYaHixrA2OFxNZU qO0YMRel/EDeqw/gxCOItZmJsA== X-Received: by 2002:a5d:4611:: with SMTP id t17mr30149480wrq.243.1593011238093; Wed, 24 Jun 2020 08:07:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:17 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang Subject: [PATCH 05/10] mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger_type' was not declared warning Date: Wed, 24 Jun 2020 16:06:59 +0100 Message-Id: <20200624150704.2729736-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Sparse reports: drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol 'sprd_pmic_detect_charger_type' was not declared. Should it be static? ... due to a missing header file. Cc: Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Lee Jones --- drivers/mfd/sprd-sc27xx-spi.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 Reviewed-by: Baolin Wang diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index 33336cde47243..c305e941e435c 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include From patchwork Wed Jun 24 15:07:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191688 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp677316ile; Wed, 24 Jun 2020 08:07:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyW/leNrrcC+wfHgSYnip4OCEq17/dp0RgmBICsYWU3/j9hMZIb5QWZfu9jVcawukhc9gT X-Received: by 2002:a05:6402:642:: with SMTP id u2mr27059951edx.230.1593011267479; Wed, 24 Jun 2020 08:07:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011267; cv=none; d=google.com; s=arc-20160816; b=o+fiQ6iuQhdArQj2DXSLlCxsHTstQzeSIQETwjlV1IRLmD18PC3ldF3vsmqPxGahy0 +nLhKtPvYS+ljrgzdXYCEh2upKd4i240BWHiLtjzeZjhD+cFqhoKebblEiVgMMMP8JEv Lmz7yZqmLXHaU+/ozjK2UmW6bZr/QT8PHWgfN35P4pxVV5AOsivTrpNC3LAJO87Dbmm1 PE+g6dadnIzIsszgFReGMB7iheok/XRbEg/gjHldsqEBWKRl2bdoUTnOhX9F4IqCCDhp ywQnr7xIrL3xBKYb4hC+rc7aTaGviebMWOhDBCblch9AC58UunrCPQSQZPRgkM1C9wFg 9Qqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ka6N3pIS5SMpHS3Dkd8MuBcyOJ38IwtNTJ67x9HE/gM=; b=dRtVYk13c4HKHT6I6peiG5PkJ+s3rqy5hvZi+pF/DirEeyiVAeCC/OwQydQPEjTEQL 69VhHCI51lAr///tTDvysDhpELnmSKISViO9PgY/TtYx4aD3UqUGFoG6cHqco678Wr9f PPkg5wI/ctiCyEjHoj91hOwwfEskHbOUF4ls+3WBV/RFlfvNsDV6F/6B7YEXBruZbFdV 4eUzcvnur9BfFMkhEdM78vQ7+MRDAbh4kX/BWIj0E31FspHquWVpo8J4bcxADrAJ+PZH cpnVvAzSOVbRFHKqivFaUVMmcqtA3C7OMfqagR7f2VEb/2Hwlt1wDayFyTnxy0W8znt4 pahA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ff5473UI; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si12817081ejd.191.2020.06.24.08.07.47; Wed, 24 Jun 2020 08:07:47 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ff5473UI; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404408AbgFXPHm (ORCPT + 15 others); Wed, 24 Jun 2020 11:07:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404199AbgFXPHU (ORCPT ); Wed, 24 Jun 2020 11:07:20 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87F6AC061796 for ; Wed, 24 Jun 2020 08:07:20 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id j4so156720wrp.10 for ; Wed, 24 Jun 2020 08:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ka6N3pIS5SMpHS3Dkd8MuBcyOJ38IwtNTJ67x9HE/gM=; b=Ff5473UIxYPsdW4pi6CB5QPFSge/HWs1GPIn1OasdcMvQPjvlEK+g8lSeufiA1UwKm H6KDcmB3IgwAsPz//203sr/5lItNIy2VU8gLEnAju1bDpqSAA+snoMXXBbUKVTtwRhw+ iYvztLUTfNwIJqWObVgXcpCcC997bPMIODvu8fKaIJsBfDZOWCccn9tKIqHndpm41ykY Mq5NnAMV9jctWKT/2bpdtVs0PMXEScf5SNuIIaSmmhtv+vlqdMu/JvyKU4itIlO1CcGf tVbYtwzeO0StF89eiamELfZGSFWzF039y0cQjpkDunjzUqt5nyJcW9aNz0PxKD3gXnrL vAgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ka6N3pIS5SMpHS3Dkd8MuBcyOJ38IwtNTJ67x9HE/gM=; b=drfEJlYizXB7Z5ahGuBRlzaEefSPprf47B47suvBQc5ipI1mWqpXJ2XB9H20AiXdEl ShGsOM28r9Y81RmKhHFvEX5Y6rxFIhwkXu2fncpl+2fIc85Q8Tnjv9HaVccq+6Nxivx8 G06eA7KWHDXGOmW6Vb17AmZKgKa7Ol62VMHGzbJ89D7sxv1vj+56NWiXJvm5hSHgRa7A IIaBLGdJCFTCAEAxf2XESfXny3KmRq2/bIsFQrltpJ41lBFmeon5m74wylJco4wwsP4W 7eIAlTIgOKFPkDpCmFIUWWRFCuUbNcpPJ4/NsXvf2J1c1vgoyk64x5Sa6Xzqa1RILoEr 4bQA== X-Gm-Message-State: AOAM5339YHf9rdFhbNpn7PzvZ+bOeuIM3BV/DRZN4MPgYICPgRxR58cy Fel05A36YXsxMjae73QbvxAJ+l4+2qQ= X-Received: by 2002:a5d:6749:: with SMTP id l9mr31134388wrw.63.1593011239284; Wed, 24 Jun 2020 08:07:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:18 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus Walleij Subject: [PATCH 06/10] mfd: ab3100-core: Fix incompatible types in comparison expression warning Date: Wed, 24 Jun 2020 16:07:00 +0100 Message-Id: <20200624150704.2729736-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Smatch reports: drivers/mfd/ab3100-core.c:501:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab3100-core.c:501:20: unsigned int * drivers/mfd/ab3100-core.c:501:20: unsigned long * drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab8500-debugfs.c:1804:20: unsigned int * drivers/mfd/ab8500-debugfs.c:1804:20: unsigned long * Since the second min() argument can be less than 0 a signed variable is required for assignment. However, the non-sized type size_t is passed in from the userspace handlers. In order to firstly compare, then assign the smallest value, we firstly need to cast them both to the same as the receiving size_t typed variable. Cc: Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/ab3100-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 Reviewed-by: Linus Walleij diff --git a/drivers/mfd/ab3100-core.c b/drivers/mfd/ab3100-core.c index 57723f116bb58..ee71ae04b5e63 100644 --- a/drivers/mfd/ab3100-core.c +++ b/drivers/mfd/ab3100-core.c @@ -498,7 +498,7 @@ static ssize_t ab3100_get_set_reg(struct file *file, int i = 0; /* Get userspace string and assure termination */ - buf_size = min(count, (sizeof(buf)-1)); + buf_size = min((ssize_t)count, (ssize_t)(sizeof(buf)-1)); if (copy_from_user(buf, user_buf, buf_size)) return -EFAULT; buf[buf_size] = 0; From patchwork Wed Jun 24 15:07:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191685 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp676993ile; Wed, 24 Jun 2020 08:07:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYcxlUjMAB6bk2AiB1r8uA5g2TVGu0pDXq5OkVG1RPvPr/VMzL0+wZeZlk7ut/O17gaTpi X-Received: by 2002:aa7:dace:: with SMTP id x14mr27589960eds.343.1593011246233; Wed, 24 Jun 2020 08:07:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011246; cv=none; d=google.com; s=arc-20160816; b=JFlZjRKlWcjaODJjchhtUJtrmpm0O4wGOmCJo6eDKdjEzY6nw/yDv7WJo0KWCZNfKd M+iR2vq9iDXfzH0kGtoYlRXtmar4ILzQ0qZBgBxJiGrim9jUzGIL08Iqm0FsS7d6b+6k H8GIDctqysh0FT33/CGmP8mOFHjUvCn/T76wjZUr5s13IhUAQttlTuUBA8iufBzojR4Z In7AlU7G5vY5egIfKNWSDGA4v7RP87HBWP+MXXQmmS+1sQUqpuGxrxevlVA/95nvrumC ebLDKrEDTXHvW4D+NNPRxwsnkIcDiGmE8e5+f8MdEnGxs7zs3bbWQlk+/nHaIGjDRxmW j02Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZDwUiot6YU8OgX3Hsb4EAg8793UTa9837ZvsB3Ajb68=; b=F2AMLzKU+/J/GzqGq90TLRpj8jmg6fZkutpIbCiOEwKSgPTyCy/sCZo4B7kSLTTJde yeSAyZfulfxRPhsN2aZ3dPWVA0fXD434hHFJbcwk9EQf3kfc+O6kk6gJ+YhBmbEfnIYQ VYpyobgDiQMpO7es1qFIfieb7ijwXcwFCeENs4N+EgD5THJ0AVMk+nIuzyKKpn1+n8dm /wbQb6L2h4PT+9wiMT6Qq/nxn05msJIC3imSXuyeoaFkr82V7oSwWmFfHrsMcDTEwqFh KnoxGJWvEClxzF0wpjiiPic7aVETwsGHdtjXAsF3Vl3t4iPOk5Rrh79JmwabazV2fwN0 y21g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DPUhRWgB; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jp14si1292510ejb.93.2020.06.24.08.07.25; Wed, 24 Jun 2020 08:07:26 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DPUhRWgB; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404259AbgFXPHY (ORCPT + 15 others); Wed, 24 Jun 2020 11:07:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404216AbgFXPHW (ORCPT ); Wed, 24 Jun 2020 11:07:22 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBDBDC061573 for ; Wed, 24 Jun 2020 08:07:21 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id k6so2656141wrn.3 for ; Wed, 24 Jun 2020 08:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZDwUiot6YU8OgX3Hsb4EAg8793UTa9837ZvsB3Ajb68=; b=DPUhRWgBdf4z6Kq3oWU8vrFS/EIgLp6T1Rjiov9INnODXro+UNi8yI8adJRwBb0utU 7Pm3vem2rv8I4QJIpGeXDr5oIFYw7N0HnH07oS/h/x/xgKsH1rkfR+v4BHlP/y+79eyw p6ClIinjeu01EHHr/ntpl6Pu1CqJm9076Dt52/rKxDXw28C8Wg23+Uys/DJw4//G0Lg2 kJJo4eSujafjVkZdQcjpwrnR+NUQRGh5WdZkKoFRB0OTACrZ5/h0jEZisLqxQCBOZ9YB 084H5InBZNTRYzrTu+pYo+r5TQXYYBL7tywwHul7NsS26H2HBonPPvirVNEOc7UAiv21 3n2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZDwUiot6YU8OgX3Hsb4EAg8793UTa9837ZvsB3Ajb68=; b=r5al+Kg9Tcc0mV1Dr1kCIVgWAWT21PEXLw+EMq15Rq7ZebvMlDHZhU/zNiqZcKiV5l CfytCL42l3H7+F5EI8kRaaF3uNRT+985cLgc8bQUOLC//fJIO+E4Qsfbd3ZG1C90kZjf NePrL7E44qQILFL5Zm5Txm//y9mhaYmXU5NuCAZsJRt8MB5DybxUDUk7QAmwaeN+a/kU d+ZVzrxfhx57qun0jgFPCiXmzV7p3O7NLpZ/C/NR/6FMvsk8WkgwalfNY9iIzYlEOEui sdBG79ZNHYHRWA8b3HdQDOIvwhQd6t9sYOAtp+DP4kTXP8A7Lq/E1RSe7Yihrc4/ipDi 7nCA== X-Gm-Message-State: AOAM533Y0BFCNFtRDWXCWhr1ARBnzcDpLbsypseyDIkTLx2qTQZV9hsN z3Wfztdd31P+D/FuASXvLE+axw== X-Received: by 2002:adf:a514:: with SMTP id i20mr31153581wrb.112.1593011240649; Wed, 24 Jun 2020 08:07:20 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:19 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus Walleij Subject: [PATCH 07/10] mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue Date: Wed, 24 Jun 2020 16:07:01 +0100 Message-Id: <20200624150704.2729736-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Smatch reports: drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab8500-debugfs.c:1804:20: unsigned int * drivers/mfd/ab8500-debugfs.c:1804:20: unsigned long * This is due to mixed types being compared in a min() comparison. Fix this by treating values as signed and casting them to the same type as the receiving variable. Cc: Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/ab8500-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 Reviewed-by: Linus Walleij diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index 1a9a3414d4fa8..6d1bf7c3ca3b1 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -1801,7 +1801,7 @@ static ssize_t ab8500_hwreg_write(struct file *file, int buf_size, ret; /* Get userspace string and assure termination */ - buf_size = min(count, (sizeof(buf)-1)); + buf_size = min((int)count, (int)(sizeof(buf)-1)); if (copy_from_user(buf, user_buf, buf_size)) return -EFAULT; buf[buf_size] = 0; From patchwork Wed Jun 24 15:07:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191689 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp677322ile; Wed, 24 Jun 2020 08:07:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAnMk/ShXVZZ3ukStTfeoabrCpSjzVNizNUc/v4d9o4+X5jsjQ3rIoGRjKXp7aLjoqLg2I X-Received: by 2002:a17:906:3952:: with SMTP id g18mr26881835eje.68.1593011267865; Wed, 24 Jun 2020 08:07:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011267; cv=none; d=google.com; s=arc-20160816; b=d0l2GVl8WY8WeU4m92TqNOKv2DLZr9CP7TikWmY9hJBwMQlS2Y4AlikPe2pylV4mdI TP/01fTOUeZadujN0Gm8wI0QbJGwZ5RU6yiudeffei0n8otHlg33EM5wMniAGJRaOm18 SE2IDXIW27jAT0yhuqj5LDzTy+Dn9tkE+um7d+8zdqB+8zH2oebLpEmUzEYeaRlHqdtS KGFaSQlvh8pGfWfZEy3bMIuDiaKbl5n5EOMqiTI4soDB9/Ob00iE1RdcMQUKE2+JewbB Vh+pa8MBhXz7GPi9WEQ3eP25RMR/diQgCum7su+8wKrCy83IAarauQbto+2QHhZMW8Mb 29Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HqgBI5p9cdp/gbRtc5/Vf5SqfkaArMfvY8eaitdy6zc=; b=GilKEEoJ0GaThnMO6iNdsQAkBBQAmKFioeJFMOHMLzVTB3bYo5xlLeP87q4PglCew6 gznbvflz+1DGNByTJ5+y8c0oIjbktGGH4p5YxOoCajtMl7OBdBVSL7BQ0c1jfFXayuDg gqEO+TcdajTHYkxCfZIClx4+2cwDj3BK4DeoxHzs4Qf6wFWZrB7d+Sy461W48bL1Ya3l u9Y42Pp/+hm05dt9Qn2YOHCdGaOFpm16dO+R+OUz7H0x8JBwhmbPvnO3twSSO7LgVMXU /MvDVZUFeXdn380F+pdV385whPCpZRPHAUJ3zKV4jIAYXs1nx/1nRZUWqnb5AhMv/t8C fK6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lFmz9hEr; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si12817081ejd.191.2020.06.24.08.07.47; Wed, 24 Jun 2020 08:07:47 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lFmz9hEr; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404402AbgFXPHm (ORCPT + 15 others); Wed, 24 Jun 2020 11:07:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404238AbgFXPHX (ORCPT ); Wed, 24 Jun 2020 11:07:23 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4980C061797 for ; Wed, 24 Jun 2020 08:07:22 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id r12so2594762wrj.13 for ; Wed, 24 Jun 2020 08:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HqgBI5p9cdp/gbRtc5/Vf5SqfkaArMfvY8eaitdy6zc=; b=lFmz9hEr/UQJ+lwMW8roCnq3g4o/1IdbpIbo0yOY9Gr1j8oubjm/YxUQtoUtEG4z0u iDnDFflx74sHdoX4yqDg6oV4pfxet8NvFU2/FHLuALUQr3an4yKs9S+Fs79eIDpc3dcb JtXFXWW12p27qVi6qpB5nk9/t1ogYLmnsm7xyLKp4i3FT22qLqFqH+ICOvXShxjlQnys fqySQyjcMI+FVhbec+8k44RhRNFhvVdmz31l5lW8qOFH+vEQucZDKToab5H7wXcx15lc lpA6UmZdV5LtxK5uhrMDob/Slw1ZsJUiIbWJiEEXLvXoJKmphPdN8AP4XYBMgBlADmQW sBBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HqgBI5p9cdp/gbRtc5/Vf5SqfkaArMfvY8eaitdy6zc=; b=D7Et4Fa6v4PUqBU78i2T7SINz+WufBhWWlLZ/1Va0OjMnekEb2inM/judIQyiQoV2c 5xZpCcUcjprURQEem3+46nHLTp1Q0va3Z9ZtL9Pt+QJ9VW1EHDE0mTQgQtTAxXs0nLUy TZ4Su4hNbDjK5fjb6AL2Bia/n+JMKWltu/1PlYS2VQk/0Bt3MNwPjfStzWSSr3mtOrQV QIkbbpk8n+9bhugoH2FAT4CVXesM6zo7vPk1pT4qrrRoemksvPPuK2GiwQgtHK1kp18N 8c3JaGEq31T+Ka2ZVikLg3jpNWeedOkrqEq0UleyPixiyIU+BnS/5cnlj7SxEThv0QAx 8Hrw== X-Gm-Message-State: AOAM532KaiH8xGoD+j7EYsTaz8+HL9i560MveLky2WS3fJE2/al8BArt UT7zxvn9ApOWnReHYkbRKmjsDw== X-Received: by 2002:a05:6000:10c4:: with SMTP id b4mr18542660wrx.50.1593011241512; Wed, 24 Jun 2020 08:07:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:21 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 08/10] mfd: tc3589x: Remove invalid use of kerneldoc syntax Date: Wed, 24 Jun 2020 16:07:02 +0100 Message-Id: <20200624150704.2729736-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Kerneldoc is for documenting function arguments and return values. Prevents warnings like: drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35890' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35892' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35893' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35894' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35895' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35896' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_UNKNOWN' not described in enum 'tc3589x_version' Cc: Signed-off-by: Lee Jones --- drivers/mfd/tc3589x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c index 67c9995bb1aa6..7882a37ffc352 100644 --- a/drivers/mfd/tc3589x.c +++ b/drivers/mfd/tc3589x.c @@ -18,7 +18,7 @@ #include #include -/** +/* * enum tc3589x_version - indicates the TC3589x version */ enum tc3589x_version { From patchwork Wed Jun 24 15:07:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191687 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp677233ile; Wed, 24 Jun 2020 08:07:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKZ7y/NcMqpzXCChK0EtKk0NASK/Pek18G8wTc49KlPUmn1oSh24DWbQDfqZgBA/nN1ueV X-Received: by 2002:a50:f387:: with SMTP id g7mr27935048edm.185.1593011263035; Wed, 24 Jun 2020 08:07:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011263; cv=none; d=google.com; s=arc-20160816; b=iY4MysbnULTsJ4itgWdcd0YmyLTFUhAAMQXfKHky2k7PoU2yPdzxSMqKK88Yt4b1Tp 8AAGZqcCRvnZkgqgsSfjtQ+f6CIebjGCUYAIM2Rsmm5lKvOYiSEuPT8otdZOUS3coc7D WwCrVhtP3KHHn0JiVPECtVyW0uZSIOO8uVQVR7jZ8iB6B5XBi8XdVTBfEbU7AvN4GDQi xahR+/dxWgNcfg0i59mmn7husp89TdsyYechq+LnNLtN6SJJmdB2B09EjhIkg2Eteyzf 0B0N8hbthx6CslpLTUjQX1CKy2A3wwOXcA/tP61OCsFHYgnYAS+W9XtREaltw6l+24Or mXaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iBe/FTv7QFeWNcu1NrkE8EgReU1liqjk61nWnJ+d1XE=; b=ntqHt1N0Dq5dI1yOQCRu1t4+PCLABmkttNHoY4UZehyhHneU9v0CEZwjCzUvpVpR3g IgC1xCKFSXz2uSE3b0N6/3gm77OQKGi8t+t7ekndrm8qL6/tGcDaRsajgCjGCTl/rx7c afuDxFKtMhxLWCwatmlsm0m9BTgB1g5KNRLUoc4lfFX3g5nr/7LwZBsjlnay4vVCn8j7 XU9V06OHtz7LBH84KF8Pv6MXXmvMoKk2AFGJqcd5GmMHB69UkoWhLtCjhMsIojxgHYHO 9l3nzzOrZ6vFsmBDPARgVxCYr+1wyw7IqUXfZpH1V+y3Qm4cV8wA0o6jA2BScvyXHUCv l1lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B+Hgbe6A; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c10si15595147edj.163.2020.06.24.08.07.42; Wed, 24 Jun 2020 08:07:43 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B+Hgbe6A; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404390AbgFXPHl (ORCPT + 15 others); Wed, 24 Jun 2020 11:07:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404262AbgFXPHY (ORCPT ); Wed, 24 Jun 2020 11:07:24 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0F1DC061796 for ; Wed, 24 Jun 2020 08:07:23 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id h15so2631311wrq.8 for ; Wed, 24 Jun 2020 08:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iBe/FTv7QFeWNcu1NrkE8EgReU1liqjk61nWnJ+d1XE=; b=B+Hgbe6AnZtssQEQLO8+i8LkJ9djlesDYCv5WY7N1bZuonlujQTgxUVX+EIDPO9kgQ 5AKudORu/oeiJMDAlTmAdQnVSJtqifT2wniOLK3q1GFfQk93QfIsuzrKKUAJz+R1dzcR suKJvwEPmlDTzNaH7TNLdu1QwMrKr6R6f0HGqXMtOHIuPYgZ/bfkULjSw9PNFIctmDEE P9MNElqmSRzhWWNxy9kXXWmZrxts/dMGERsWqgdpr7/2Q/j5WLhhJJ9Qjt92oI8GBpVN 1o+nBw/CBOEzI7oFe9mzJ7P343F/2Dh04W8EOjuETfcBeVenRb9twG5OwYOW87+Zz/XU XelA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iBe/FTv7QFeWNcu1NrkE8EgReU1liqjk61nWnJ+d1XE=; b=hrNqyWMoXUTn8lAG7KmWb1CFkYPIOAT73hr8/Mt1PjWGmk8X4NZszAxaxFOC09u3iA frsdnRetCvMM2LsylrA4RKT98PX8beVrRMaBZHi36eUq+o1tKe4SDH7BDavQX1VXeLFI 9de1kuyZTaBptq2jBmoPsTzLipDHvo3hkDeSPZoW5sawz5wnGbeyAgHFb+hELJZXxM9F vdqxYRtoH1BUiEgq6o7ALtU3mWd9wXPF+SPRXa4+3nW4GH2ia/sCzDEqiINPD1UQ6e5+ Dd6bOxQXAPpQJfT7Fu7Pubzxnb8HUvcktWLZN/EN5X2jta5GdMcEh10VlWtbcigrHNI+ iIsg== X-Gm-Message-State: AOAM530ls/1NssSq1qqR/5aInGq0hJYegAZZcN2VGe4iroEjDsK3B8H5 Y7/GhRFdXkJsjVxue6/WgFMe6A== X-Received: by 2002:adf:ef89:: with SMTP id d9mr17946513wro.124.1593011242694; Wed, 24 Jun 2020 08:07:22 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:22 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mark Brown , patches@opensource.cirrus.com Subject: [PATCH 09/10] mfd: wm8400-core: Supply description for wm8400_reset_codec_reg_cache's arg Date: Wed, 24 Jun 2020 16:07:03 +0100 Message-Id: <20200624150704.2729736-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/mfd/wm8400-core.c:113: warning: Function parameter or member 'wm8400' not described in 'wm8400_reset_codec_reg_cache' Cc: Cc: Mark Brown Cc: patches@opensource.cirrus.com Signed-off-by: Lee Jones --- drivers/mfd/wm8400-core.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 Acked-by: Charles Keepax diff --git a/drivers/mfd/wm8400-core.c b/drivers/mfd/wm8400-core.c index 3055d6f47afcc..0fe32a05421be 100644 --- a/drivers/mfd/wm8400-core.c +++ b/drivers/mfd/wm8400-core.c @@ -108,6 +108,8 @@ static const struct regmap_config wm8400_regmap_config = { /** * wm8400_reset_codec_reg_cache - Reset cached codec registers to * their default values. + * + * @wm8400: pointer to local driver data structure */ void wm8400_reset_codec_reg_cache(struct wm8400 *wm8400) { From patchwork Wed Jun 24 15:07:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191686 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp677009ile; Wed, 24 Jun 2020 08:07:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyC7rQGgtSzOqVQCVykucybNPBw3ZJSuKLFbmhcXMWGHsHiqH+4+s47vLCda68r/dQrUVcx X-Received: by 2002:a50:cdc6:: with SMTP id h6mr26766987edj.111.1593011247240; Wed, 24 Jun 2020 08:07:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011247; cv=none; d=google.com; s=arc-20160816; b=jIrUwVG2rd1BFNSwBMeRApdu2dy7iMyqFRNZHyJ+irq6HrB4xhBdTC2KudLMRxJoyX /ZGjWLzGLjpRboxVGyZhRJz1UfBtVXlaiQpxjQLa0XroUd/IEULsLY5DggQ29lFIbXLg o1bKd8AtE1w8/PUBFb7FYTE045h/9O68LKQRcXtGupgKenXQvVPl2Y5DORdZRMRnA5S5 Lvk1kJZUqtKAt8R2cnAJYmzuj6aHBclHRx/Zw1QmJkwLSbcCzLECmtw7QRGwAiI4mcAr 7SyUeEzkVTSdaswj5bFF3INMddSlpn6G7Dg/1SrPXqAuGjPXOwhmggTSDgasDTXSIxDP X3yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kSPgE+bGgsMdGhCfRjJWoo3vTL9/vYYp2AF2KnCRX7A=; b=Dfy5K6Nfh34O0dZhBhWEPMLDrhRxVYkds4v0crOS1L0AYOmCPJg0Hj4iAjXtSPWDRx buTSTUx251B4FmqfDmCyOsNDBHQdKQZBFMuDu/Rkm+JFviDSIC4LwFw5RkT3aegdHJNL tWKFWePL7tPKPPeeha+fvInPyUdr/ujIIjBct7OxPTGS6ycMX2KZu4T5p1nlgV5p+5UE Pyh2Nmb8wS4d/+/vM0BADSJrXJQvghtdIAv+aOIaig3JPgs6+fPdMOYEnY+FDYVihzbA JPu5Qpo9Bbih4Vri14ZmEyAdCW1uCnR1c5khq0/jS/r+E1FFTJa/T71RRorUYbkn6Evy heqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BtZw33dN; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jp14si1292510ejb.93.2020.06.24.08.07.26; Wed, 24 Jun 2020 08:07:27 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BtZw33dN; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404284AbgFXPH0 (ORCPT + 15 others); Wed, 24 Jun 2020 11:07:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404271AbgFXPHZ (ORCPT ); Wed, 24 Jun 2020 11:07:25 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E465FC061573 for ; Wed, 24 Jun 2020 08:07:24 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id h5so2634904wrc.7 for ; Wed, 24 Jun 2020 08:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kSPgE+bGgsMdGhCfRjJWoo3vTL9/vYYp2AF2KnCRX7A=; b=BtZw33dNk6XR2atGnsBkwFUuIxaaSCIFGdnyixfM0UlnYDV3zzT6lb6+aa5UD58UCe tElHor7dZl5GsAKmFmBg3dY+AfhyaoGNRDv2IttT/kiYEg0K6OEVNIX2BjsVMyL6D1Vh pl74LjR7qUunaQwqNmFvpQ8M5npMEODYp/0U4aA7dzfTv0oXX9GuIPNlYKwdGJulKZNC xK911HEq5deWXhRuEJqGaat8+7llFxgHSGLbdqhi18VSQhB6s0rrfYtB0yK78ppQSKlp 1mdd1eqdW9hbgOZwIWTNEFDWEsKFNNT8+oTEHAvTj92jtOvOonh5b99Z7mXBqFc9znrQ 7Bow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kSPgE+bGgsMdGhCfRjJWoo3vTL9/vYYp2AF2KnCRX7A=; b=i0MgcHNSRyPydv/z60a0/j/6hFBAakL5kR/5uHvUvRcGoRg+kJEvvjH/0iUgz9MqWZ BtdMHw3PMMQlLRQNgUB9Aya53PDSxQxdw5kJdhDhNjhW9y3xM9Q5YgJ+oZkM7JdyJIQY QVoPeyD5fYHq3q2bt0H1a8wU4deXRtI3eyfWSNIv7BD1QFrF2OrglWZKp+Tur7pl5B9H Xm11SjZUkOk/MGSdSPWFN0niVkMd2obvX7t7lOzVFNEhGdyw9LyEVWoIcnpkRp/c08K/ c41XWDXuHXY/SWylAAgFBQd98HrQrDENbYYZDXoQ5aT5fyx4F4FB1DmeZ20WDB7bFkGa V+oA== X-Gm-Message-State: AOAM531GFELmFZXn8DEI9iYC3CfNguAyFNgV4yvnClPGzBZ5xnDZ2JmE 4VQghZsU8Dp3Gpf9+qDKjqcI7A== X-Received: by 2002:adf:ff90:: with SMTP id j16mr17817455wrr.364.1593011243632; Wed, 24 Jun 2020 08:07:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:23 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mark Brown , patches@opensource.cirrus.com Subject: [PATCH 10/10] mfd: wm831x-core: Supply description wm831x_reg_{un}lock args Date: Wed, 24 Jun 2020 16:07:04 +0100 Message-Id: <20200624150704.2729736-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/mfd/wm831x-core.c:119: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_lock' drivers/mfd/wm831x-core.c:145: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_unlock' Cc: Cc: Mark Brown Cc: patches@opensource.cirrus.com Signed-off-by: Lee Jones --- drivers/mfd/wm831x-core.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.25.1 Acked-by: Charles Keepax diff --git a/drivers/mfd/wm831x-core.c b/drivers/mfd/wm831x-core.c index 02f879b23d9f6..b0344e5353e4f 100644 --- a/drivers/mfd/wm831x-core.c +++ b/drivers/mfd/wm831x-core.c @@ -114,6 +114,8 @@ static int wm831x_reg_locked(struct wm831x *wm831x, unsigned short reg) * The WM831x has a user key preventing writes to particularly * critical registers. This function locks those registers, * allowing writes to them. + * + * @wm831x: pointer to local driver data structure */ void wm831x_reg_lock(struct wm831x *wm831x) { @@ -140,6 +142,8 @@ EXPORT_SYMBOL_GPL(wm831x_reg_lock); * The WM831x has a user key preventing writes to particularly * critical registers. This function locks those registers, * preventing spurious writes. + * + * @wm831x: pointer to local driver data structure */ int wm831x_reg_unlock(struct wm831x *wm831x) {