From patchwork Tue Jun 23 14:23:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 191488 Delivered-To: patch@linaro.org Received: by 2002:a54:3249:0:0:0:0:0 with SMTP id g9csp1090680ecs; Tue, 23 Jun 2020 07:23:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRUen68Lk4Up5gEpwxAMbxQAhF4szlRnRNUVdq/q3s0u7ohsiSaO8yBwKHRAefr7pE3iqy X-Received: by 2002:aa7:c80d:: with SMTP id a13mr12460118edt.327.1592922198362; Tue, 23 Jun 2020 07:23:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592922198; cv=none; d=google.com; s=arc-20160816; b=J1Bwx7uq12aq9zBhcA7wLOYabszaDposAnm2dOhuwfuqb9/qdN0MzX+iT7dRQBudNK 7IeHdI8eFKCEO7aeL6nBg/hlzt/vgcMwI6GEoPLQcSdziu4o4PWMrAJ2vCQ5HJTk+dce 8DdpQTVu7LvKjhvVYw9ZyZCsnaZvIE0S5mNKowaer4NpY69Rl8cX4y2YnYlrH7j6hWyz dwERgksrR4iaZfrEEAHE+ihHVdLWHQf3vhpEdm+UnLd4jngbtsavlfS8oX6OdDhuQgBy B6b1CP4gwv/LoDPcgA78My0igIGKyL6xqENuzDcso2HsaoirSe2ZAxX7j0g2jBaVbBbq eA0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:from:to:subject :content-transfer-encoding:mime-version:date:message-id :dkim-signature; bh=qFlOj3wSSSINOzv90EaLpuVFFjebeMk4KVdQXi9/yNc=; b=WSGogEL4Oe222pUa/CCNUNuJozzksQ+wFdvHRlIA/hTd6XRN7VuSf5+W707R2YuTe+ g5k17ZqiICJq2vnTaME4FSYfszWtdGSWg92bQVor83PTjQ/FWxI1Ibc0d6ymtPKNW8ik Q2JtlKwtpYwiJRuH1WEoUrsBhYCVLiO9FsNEuzjKgp2iDmKGR+qWSKi9ifIbhaoEJdZ4 WdD99wnw9YUSWxoThx/p/oGgqoCVkjinzu/qlUUzMG+PofD/mfiAtUgKiNufTHswqXrC 3JkHLqBle0lDbY3vGZ8n8dvTrVTiq+fsYPAh2hm0B1sskBKfkUmeyEg2NKozCJc23OJz 99wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=APdLuZED; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o1si11233547edr.267.2020.06.23.07.23.18; Tue, 23 Jun 2020 07:23:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=APdLuZED; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732761AbgFWOXR (ORCPT + 3 others); Tue, 23 Jun 2020 10:23:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732759AbgFWOXQ (ORCPT ); Tue, 23 Jun 2020 10:23:16 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0ECEC061573 for ; Tue, 23 Jun 2020 07:23:16 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id d12so3205322ply.1 for ; Tue, 23 Jun 2020 07:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=qFlOj3wSSSINOzv90EaLpuVFFjebeMk4KVdQXi9/yNc=; b=APdLuZEDWd1OMGhDoMAaRMtSUxrpGGMQdnAaFCMsfp7ovPdt/FNXP3tG9r+eJj0kke CshHHxHrhRewRr0kn6wukWaOwPFKu1dh1mThMyIWPARfIf6kKEgseYCaOZpURqNL2VVh /j7L+IsrUaXRmIDOUrgJu+FLxfAyLxlXPmzGbN2t/zRFzanEpYP0ztX3sgM0yLaxK8qz KIwI2T01wURJcmv0UJFT8G4T/+PkYbHaOFTGNBXiS+9w4g6xEKwhgySmhuS1Lsi6YbHb ntNb/UrAQOTOhMpkEy6S6Q3I41963Ytvvp2DuTsi/4GHHl9quM6VGZAnoZX0tp4/+9kO vpqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=qFlOj3wSSSINOzv90EaLpuVFFjebeMk4KVdQXi9/yNc=; b=ZyYXaIndwUlWM3J6PIMzk6nZ3YWZGm24hJmu5CjTSG+NwsKfKcSuE0ID0mstLB+QM6 ZllvkSssZxaU9W+j/pt4BbqKSRTlhxXY2mngpaUdVVZmBMgILTcuwgv2Xc3clA78Sx1b 8lrN75trYkIlM48HehZuQGgw75QsIOL1HZfh9StsJIIJh//RCQbSuw/AI3Na4H16aPB5 NzesGVwFzOgDZQrgGk2pl8RCk7Uo5FOdSyo1QhJe1+8XZcabVkfiHgB45t+QUQfeBX8j uKP6kPveexlz/7WY3jK5rsc35iNQnAycEy2Rcof9MWMne1eAFsCIx+LeH811z1RL78Qa UXwg== X-Gm-Message-State: AOAM532+VGvRF3k95GoEJw2YTL3CQwFMF05v4yfJhTlP9p8xoXF1WRZC SSb2a2Mmhw62C7jhL6it13YIaoS8z/8= X-Received: by 2002:a17:90b:796:: with SMTP id l22mr21618759pjz.45.1592922196445; Tue, 23 Jun 2020 07:23:16 -0700 (PDT) Received: from kernelci-production.internal.cloudapp.net ([52.250.1.28]) by smtp.gmail.com with ESMTPSA id y7sm2814095pjm.54.2020.06.23.07.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 07:23:15 -0700 (PDT) Message-ID: <5ef21053.1c69fb81.b80ec.8649@mx.google.com> Date: Tue, 23 Jun 2020 07:23:15 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Report-Type: bisect X-Kernelci-Branch: for-next X-Kernelci-Lab-Name: lab-baylibre X-Kernelci-Tree: krzysztof X-Kernelci-Kernel: v5.8-rc1-14-gd6fe116541b7 Subject: krzysztof/for-next bisection: baseline.dmesg.crit on bcm2837-rpi-3-b To: "kernelci.org bot" , gtucker@collabora.com, Krzysztof Kozlowski , Guillaume Tucker From: "kernelci.org bot" Cc: Russell King , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kukjin Kim Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * * * If you do send a fix, please include this trailer: * * Reported-by: "kernelci.org bot" * * * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * krzysztof/for-next bisection: baseline.dmesg.crit on bcm2837-rpi-3-b Summary: Start: d6fe116541b7 Merge branch 'next/soc' into for-next Plain log: https://storage.kernelci.org/krzysztof/for-next/v5.8-rc1-14-gd6fe116541b7/arm64/defconfig+CONFIG_RANDOMIZE_BASE=y/gcc-8/lab-baylibre/baseline-bcm2837-rpi-3-b.txt HTML log: https://storage.kernelci.org/krzysztof/for-next/v5.8-rc1-14-gd6fe116541b7/arm64/defconfig+CONFIG_RANDOMIZE_BASE=y/gcc-8/lab-baylibre/baseline-bcm2837-rpi-3-b.html Result: 5b17a04addc2 ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val Checks: revert: PASS verify: PASS Parameters: Tree: krzysztof URL: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git Branch: for-next Target: bcm2837-rpi-3-b CPU arch: arm64 Lab: lab-baylibre Compiler: gcc-8 Config: defconfig+CONFIG_RANDOMIZE_BASE=y Test case: baseline.dmesg.crit Breaking commit found: ------------------------------------------------------------------------------- commit 5b17a04addc29201dc142c8d2c077eb7745d2e35 Author: Guillaume Tucker Date: Fri Jun 12 14:58:37 2020 +0100 ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val This "alert" error message can be seen on exynos4412-odroidx2: L2C: platform modifies aux control register: 0x02070000 -> 0x3e470001 L2C: platform provided aux values permit register corruption. Followed by this plain error message: L2C-310: enabling full line of zeros but not enabled in Cortex-A9 To fix it, don't set the L310_AUX_CTRL_FULL_LINE_ZERO flag (bit 0) in the default value of l2c_aux_val. It may instead be enabled when applicable by the logic in l2c310_enable() if the attribute "arm,full-line-zero-disable" was set in the device tree. The initial commit that introduced this default value was in v2.6.38 commit 1cf0eb799759 ("ARM: S5PV310: Add L2 cache init function in cpu.c"). However, the code to set the L310_AUX_CTRL_FULL_LINE_ZERO flag and manage that feature was added much later and the default value was not updated then. So this seems to have been a subtle oversight especially since enabling it only in the cache and not in the A9 core doesn't actually prevent the platform from running. According to the TRM, the opposite would be a real issue, if the feature was enabled in the A9 core but not in the cache controller. Reported-by: "kernelci.org bot" Signed-off-by: Guillaume Tucker Signed-off-by: Krzysztof Kozlowski ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [b0953d8b7cdb39493e67cff4b20b0ebe3a2bba92] Merge branch 'next/drivers' into for-next git bisect good b0953d8b7cdb39493e67cff4b20b0ebe3a2bba92 # bad: [d6fe116541b73a56110310c39a270c99766cd909] Merge branch 'next/soc' into for-next git bisect bad d6fe116541b73a56110310c39a270c99766cd909 # bad: [5b17a04addc29201dc142c8d2c077eb7745d2e35] ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val git bisect bad 5b17a04addc29201dc142c8d2c077eb7745d2e35 # first bad commit: [5b17a04addc29201dc142c8d2c077eb7745d2e35] ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val ------------------------------------------------------------------------------- diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 7a8d1555db40..36c37444485a 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -193,7 +193,7 @@ static void __init exynos_dt_fixup(void) } DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)") - .l2c_aux_val = 0x3c400001, + .l2c_aux_val = 0x3c400000, .l2c_aux_mask = 0xc20fffff, .smp = smp_ops(exynos_smp_ops), .map_io = exynos_init_io,