From patchwork Tue Jul 11 23:11:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 107426 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp83316qge; Tue, 11 Jul 2017 16:13:48 -0700 (PDT) X-Received: by 10.98.33.132 with SMTP id o4mr52401292pfj.11.1499814828683; Tue, 11 Jul 2017 16:13:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499814828; cv=none; d=google.com; s=arc-20160816; b=YV9YFy1Taz5kAJdIOyMtbGr9KztooaI/lBNcGQwfizXWb7nNJKEh3tDeg3MgWEAoqs aQacx0FzTHnAdVDCgItuLBwn6OO4F6f/6KSZxKYnk9JXHshPssTXy5rf0UWrSbnRYLUT 1o+t1RopasJsWh3mEtUZqQFyKODTmPLxYc/gYDtHw5W0RX2kqeyYGOm57uOMOmPl5Ibg zLI3SWZOMK9wHHkyr344CYj12WfAKEvV8MX5OkpI1Kt3XByEjT//Q4uGVL0ptK2Jbbg9 VvlrzsN51OrUCW9Rwuy4C75Nrc9CeNh+8QmjgAEFcE1Vxkj1uhDsQmXM6fwsu9GEsiRM yXBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=J4nIkETyJSVq+A4Zc1mjWbPuy5BnbZmTntHP6zr7Edw=; b=xH35gpOoFqWJpQfZ1Sujly9SqEMfGSIwiSRrhBWaX5S4yuc4Baq3JSEqUBwwudVJRq NcGSinXthFEUp8Vvz3ghD5eNZkhdjEMAD5gFP5l8YI9WP2yF7N7Mowkw9v2wGvy6/hvK 3ia4yVXbzFv76YRE6WIEtseS+vpExRLXkVZloJrqkMA77Udc8tLl8G2BRzFjPTa2p6xQ NGswAjC962J+fX6modPWvSnqCQeqWne0fR7YGaB8Vnk6NdyUqO/aOolLvLR8b1DLKzOy eZDQWPlgsvjgfj6Id9KDGmovzh7FpF+zS++jcxaJhYFfWixiYZe5Ll0B8+aN58vLQuiO HJmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.b=qDhQL75V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i136si481873pfe.141.2017.07.11.16.13.48; Tue, 11 Jul 2017 16:13:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.b=qDhQL75V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756083AbdGKXNj (ORCPT + 25 others); Tue, 11 Jul 2017 19:13:39 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:32983 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755625AbdGKXNf (ORCPT ); Tue, 11 Jul 2017 19:13:35 -0400 Received: from grover.sesame (FL1-122-131-185-176.osk.mesh.ad.jp [122.131.185.176]) (authenticated) by conuserg-08.nifty.com with ESMTP id v6BNCCkU029106; Wed, 12 Jul 2017 08:12:13 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com v6BNCCkU029106 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1499814734; bh=J4nIkETyJSVq+A4Zc1mjWbPuy5BnbZmTntHP6zr7Edw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qDhQL75VVrxaa3q2Vr3xpMVw7l4Z/9GbNXXfTKte7C+hP6NBA+uCvG4yQk3jpUgvh aZ9xssAPR7BgP+e0Nw8Vo7RQjyYVjSghHqg6SPRqZXxArgOFB35UFbX3ntv8Oy+yBu 6fa9hPGBV3OxiCFC2l7r8xNCdDFAtJZ+G74Sz16P85W0sDYwwnQ4K7Ze7hNTAJqRcI ohcFC8WvSO0wl9KjSVUZ7z8b2RN3efeRW8RTMT0GkDn3TxVAInkCY9RRBZSiOO5CsF S7zmEqgkOn0Bi3vlXIm7qOy7i+TbWXB3e9lnN54LsmWk/lv9CEJA8Owwgwm9XAVhrD TRBuUFqpMCPxg== X-Nifty-SrcIP: [122.131.185.176] From: Masahiro Yamada To: linux-gpio@vger.kernel.org Cc: Masahiro Yamada , Arnd Bergmann , Alexandre Torgue , Linus Walleij , linux-kernel@vger.kernel.org, Maxime Coquelin , linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] pinctrl: stm32: select IRQ_DOMAIN_HIERARCHY instead of depends on Date: Wed, 12 Jul 2017 08:11:49 +0900 Message-Id: <1499814710-16686-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499814710-16686-1-git-send-email-yamada.masahiro@socionext.com> References: <1499814710-16686-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drivers that need IRQ_DOMAIN_HIERARCHY should "select" it, but drivers/pinctrl/stm32/Kconfig is the only exception that uses "depends on" syntax. This prevents GPIO drivers from select'ing IRQ_DOMAIN_HIERARCHY. For example, if I add "select IRQ_DOMAIN_HIERARCHY" to GPIO_XGENE_SB, I get the following recursive dependency error. drivers/gpio/Kconfig:13:error: recursive dependency detected! For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by PINCTRL_STM32 For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/pinctrl/stm32/Kconfig:3: symbol PINCTRL_STM32 is selected by PINCTRL_STM32F429 For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/pinctrl/stm32/Kconfig:11: symbol PINCTRL_STM32F429 depends on IRQ_DOMAIN_HIERARCHY For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" kernel/irq/Kconfig:67: symbol IRQ_DOMAIN_HIERARCHY is selected by GPIO_XGENE_SB For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/gpio/Kconfig:502: symbol GPIO_XGENE_SB depends on GPIOLIB Signed-off-by: Masahiro Yamada --- drivers/pinctrl/stm32/Kconfig | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.7.4 Tested-by: Alexandre TORGUE diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig index 3b8026fca057..7e1fe39a56a5 100644 --- a/drivers/pinctrl/stm32/Kconfig +++ b/drivers/pinctrl/stm32/Kconfig @@ -6,29 +6,30 @@ config PINCTRL_STM32 select PINMUX select GENERIC_PINCONF select GPIOLIB + select IRQ_DOMAIN_HIERARCHY select MFD_SYSCON config PINCTRL_STM32F429 bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429 - depends on OF && IRQ_DOMAIN_HIERARCHY + depends on OF default MACH_STM32F429 select PINCTRL_STM32 config PINCTRL_STM32F469 bool "STMicroelectronics STM32F469 pin control" if COMPILE_TEST && !MACH_STM32F469 - depends on OF && IRQ_DOMAIN_HIERARCHY + depends on OF default MACH_STM32F469 select PINCTRL_STM32 config PINCTRL_STM32F746 bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746 - depends on OF && IRQ_DOMAIN_HIERARCHY + depends on OF default MACH_STM32F746 select PINCTRL_STM32 config PINCTRL_STM32H743 bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743 - depends on OF && IRQ_DOMAIN_HIERARCHY + depends on OF default MACH_STM32H743 select PINCTRL_STM32 endif