From patchwork Tue May 20 19:43:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891585 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C52A27815B for ; Tue, 20 May 2025 19:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770253; cv=none; b=UNjMAGVwBJuFAFdAHVhO9cV5rCZj9JfTyC8B5shItRld0oWMldG5c4glie0/sfLU8+nWa3DPFjPJCIGB62aFasj9VUwQo/vjJpxw379Lnj3A+qKstZnd5SYfCZzbThqAlrPR7FkZRZ56T9HOmZUuz+nJLtogLMuJYFIGsLKCj9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770253; c=relaxed/simple; bh=lXkzN3vTUtCsuMNaU7AQ+PKOsH9wKasVCRD3PK1/E2Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P20DyJp244Rg+z2pWHmNaf6DQgL83m10N0yhRnSKvH60nyCBZMY14OhRYrzVGsS62uF4p6wiVCf881ZrQUEk4Pbm3EC1lSixVw5Xzn4H7sxAVvTNjF7POlY5rLktfoGRadEvib0A/7f4IL7ZknBXD5UwabgLMwjUwWgbnQTAcZc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k8gDBVty; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k8gDBVty" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-601f278369bso4784260a12.1 for ; Tue, 20 May 2025 12:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770250; x=1748375050; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RynZ2VZgsWEHv1jM7imrJocPwmlfDRE09WSP5dxmvgA=; b=k8gDBVtyB6/fMW+Uc1zfZdk1IqfIUBbtj/hrwHPcAR3baa1bSyDyTJEmYHe15X68gr FaYJmvfLda+AEqeDiDh4H0S+zW9ISY9QNXFWjH0RTygWOl4h0ChL7B5wISnJBZ3ZxAwR 74H/sRw9RFT5ErlUkMVqdp5zii5cRZ7LRYZ1iixDnx6XupsSFARPo5YjlDQECvViSWo1 oXcJLnEYCIe+iL9KiwjluCIc4LiP/owpg8wnJmsmPDPINUOumkstm25uVOjAHi6g8RRl I/5pMdMIEuOjy4rdsmSW2vDHY4/Czgau+x6e1Ix44UdR6ZorfJL2ytJGufKVIHK61ERo S7zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770250; x=1748375050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RynZ2VZgsWEHv1jM7imrJocPwmlfDRE09WSP5dxmvgA=; b=KrODe6hQIapV4J8IDqScH5/6/TD3jlJWd11LUMYsPMy7TI6/boxRmCslWcjM031KaD AX+aRjRq5zpjRzMkbDlHuOezeRmpkYVdRm5zf3tp9Wo0mHHcyuqP8bUzxKPpkVvgBbGK LZtcgK0soiuAPIb4jQXVWe/hGNwjD3XvFfbViFQXqLSSRmpTD6O4McKLgbUUdIZvjNTQ qwfrV3GCg2ROgcddQRgMuQxsUORsJx9wUXg8YYDL4F2GVN1Fkj21ytcziak1SO0+qPyS Aaau65EDV2H9DDI+d1s3L9GdsSeraJIHMFtw0ekKOlAwmcNjH5T5U3OxHMvkDsHxSGR6 i6eg== X-Gm-Message-State: AOJu0Yw4iWRyw7tXEB8EBiSOrZx8glxnevA4dbiTloMmdPwLpMIa1FXB f5gMg5Z2emW1/AEKQlfsabB5/PeloNmzmj1hXnUD4QnxsW1lWrNg46TzYglH6B3eFyY= X-Gm-Gg: ASbGncs/1Ii9Qe5wEiihCi68YK9h1y2uUYVDBMX4Ti4fEmuQYr13kHiLxDL+rCyD72u 4/ZwaQ6ZWVdOdQ/KXemtxvUOghBTm0ghLfI1PvdwECV1nu2nXfm2ZSAu+eCwOwCzoNLuK+vgFv4 WZjQLujY+SGb9L9rKPf/nCnlWQkGufSS5Ge3wZkjUNHcSZoPyzySLBaRMPlau7JnJQuTyGBb0uf xLST1EmwucTxfRzSBE7xqD9Yx6H+AFIWkVGvNRKSS13KEqtt6gCuwdN9EvTYUEtL4Ur4s9sJCnk w2SJtiglFOBpWVan8W5YBqOldO60fMmJZHVpjsDy7V9OfKHw12C+WQaWPYmsHZmZ4PjzVvdNsfz DzvjwEg== X-Google-Smtp-Source: AGHT+IFXBkjMXPqq2YMsGnleGuZgnvR22tXLvwdieF2jQVX6poShdbRUmJuVWwp8pn4PP/PjxJ5Tog== X-Received: by 2002:a05:6402:3546:b0:601:a35e:6dd1 with SMTP id 4fb4d7f45d1cf-601a35e7008mr11375498a12.21.1747770249609; Tue, 20 May 2025 12:44:09 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:09 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 01/10] i2c: tiny-usb: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:43:51 +0200 Message-ID: <20250520194400.341079-2-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-tiny-usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-tiny-usb.c b/drivers/i2c/busses/i2c-tiny-usb.c index 0f2ed181b266..68d1441f5f3d 100644 --- a/drivers/i2c/busses/i2c-tiny-usb.c +++ b/drivers/i2c/busses/i2c-tiny-usb.c @@ -253,9 +253,8 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface, dev->usb_dev->bus->busnum, dev->usb_dev->devnum); if (usb_write(&dev->adapter, CMD_SET_DELAY, delay, 0, NULL, 0) != 0) { - dev_err(&dev->adapter.dev, - "failure setting delay to %dus\n", delay); - retval = -EIO; + retval = dev_err_probe(&dev->adapter.dev, -EIO, + "failure setting delay to %dus\n", delay); goto error; } From patchwork Tue May 20 19:43:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891393 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678C6211710 for ; Tue, 20 May 2025 19:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770254; cv=none; b=VUq6aNiuNtYTZLJ/ER1H5O1nlzM/cjrLrY1gDcckb7desRPKY9mDaFolEyDPXLOITKHQyel/+ETpnRbBLl2ybfTNIBgSmU40kRffKsdXEeyrJvKFNirF3e9iigTss8XEmn2MjOObz9bLNHJ0lKXCJWHC3bfldgZU2+UdCLfc8OQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770254; c=relaxed/simple; bh=o4eCxaogxkKg4ggYHDPKzyLXdrXjwwevF8B5eyjdTTQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B9HJz0VQTlxO6ZJVUhuk2xb8AMTcHHVNGYaRVKKjnVaWUd7GM29YfUuPfMnbyT55gVWUBxQpfQx4cqED5L59TD71SHHFIrhwuNI4Ga5OgfiE/hMzPbiG8McqEHEAnFjT609d+1nSOSePObFS2ZAa0pz917PaijXpsyxEAWbDTkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OdZmwRgk; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OdZmwRgk" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-601d10de7e1so4395551a12.1 for ; Tue, 20 May 2025 12:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770251; x=1748375051; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hNwTypVEhW+I6Ule3/kZmD3HwJ7mxNMD521XFrY6l9k=; b=OdZmwRgkCdZnkp9Q3gzFmp68jbalhQRgFDkvWWveXkTbSYbaYr5GY7ywWJsmtQ9Ug2 KSvRkKi+p6/Z1uJbmqjt3iw6+pIfyG6Ws2gf2B9zrVYV1VWlVt8A+jysuUPZzkEfZ/9K C2eBbDeX3vTMz70W/Hm/qnOdqcWcKQIDW4GjtD7CNmEO4MDCa74EIKMYR6oqe6ajXmDB wvirAqMeljLn+jduJUPWNUDHwhJxyj1GBM5GTIDG0UJ5YIdVVXW2hJDXamvF9xyAyaYh uMwwjWeEKBRrn3/0AEJEUUbhzk9jjdZ6k2l7r1H7lPmRHBxY5AJCMindet8XT/MUNqdx W/cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770251; x=1748375051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hNwTypVEhW+I6Ule3/kZmD3HwJ7mxNMD521XFrY6l9k=; b=gwWB3gI1CX+KzI/fv4pYydXZuOJ54GBIPWBe+GFN+/MFRqCZrQ9h8zLklcwL+t/fR1 IfkSmpq9JYoyy7nSzf1nCim15uIEh1bEdsM/DkEZH7JN5NUshFkXaR6A6rRq2J1rVXGg tNNVu5WmnrY6jVNr7f1PSeMm2UhHAgJJXpuiOHE4DTAXp9Oyad2LBaBt1uXIPSTwLjsp vf6I2coqv9jSW81/haSVUQUXdT+2aVK1gHnTJcvF2OxjuGE1jxblBuWiiCptV3Pn9RXh U6JEAxD1P3Lcp4lIumFNi/w0DoGC3BLqwZ1lqB38LdxB5N9Hv82tMYS7upUohVJsksln 0voQ== X-Gm-Message-State: AOJu0YzedFi12iBzdSPnzdrhLEkXLu/2kZdGO5JWvjjIH79M4HYeHe01 P0u1cIKSTUYCpQ3xZit9PKMJxCNHuktxuVFnogsn9UpUzSnKlPEVR5yDkK/h87Dar8I= X-Gm-Gg: ASbGnctBzkkDWgq5YCAf0jPAHGAHuSQFJ7Ts2wKFCefrrSsqxige9dLvs68Fqwdb2Dj WPodV64G68boJLIqK1Qgq4ChOAShIcKlIZImJmeAGfWfJoqcpVr7TswYAjMnES41kqoWyVZIsCv dj5ldB7kDo6N5OVbbdGcFXN8QbIujF82m9FaJ22/sttimjKylQhOeA/cvlv448f6my4LfJi/UoN ZGa0djdKIPjPH5Vd1x+LN0lTH0hp/jA8Jca6bLCMlBtt7cokI8mUsU1JbQ3/1frCyr+YUKtUGpC Yjigsuq3ZrtE3xYKjU4fhdbIuEAskiNjUfbPm6NPvE8gyMN7giB9sOMq2OuJ9Nayzz/27n+Lwxa tLr1gmvueyrtR1s1n X-Google-Smtp-Source: AGHT+IHjYDJsEXVrjuaC4isX3IrjBgui3obsdFkBsJO4aaBhsAtAQJAl6CskSvsEbBd8LX8Ohm6DzA== X-Received: by 2002:a05:6402:90b:b0:5ff:addb:653e with SMTP id 4fb4d7f45d1cf-6011411aa27mr13795344a12.23.1747770250491; Tue, 20 May 2025 12:44:10 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:10 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 02/10] i2c: tegra: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:43:52 +0200 Message-ID: <20250520194400.341079-3-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-tegra.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 049b4d154c23..0cfa45da9b94 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -471,8 +471,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev) dma_buf = dma_alloc_coherent(i2c_dev->dma_dev, i2c_dev->dma_buf_size, &dma_phys, GFP_KERNEL | __GFP_NOWARN); if (!dma_buf) { - dev_err(i2c_dev->dev, "failed to allocate DMA buffer\n"); - err = -ENOMEM; + err = dev_err_probe(i2c_dev->dev, -ENOMEM, + "failed to allocate DMA buffer\n"); goto err_out; } @@ -484,8 +484,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev) err_out: tegra_i2c_release_dma(i2c_dev); if (err != -EPROBE_DEFER) { - dev_err(i2c_dev->dev, "cannot use DMA: %d\n", err); - dev_err(i2c_dev->dev, "falling back to PIO\n"); + dev_err_probe(i2c_dev->dev, err, + "cannot use DMA, falling back to PIO\n"); return 0; } @@ -1710,7 +1710,7 @@ static int tegra_i2c_init_clocks(struct tegra_i2c_dev *i2c_dev) err = clk_enable(i2c_dev->div_clk); if (err) { - dev_err(i2c_dev->dev, "failed to enable div-clk: %d\n", err); + dev_err_probe(i2c_dev->dev, err, "failed to enable div-clk\n"); goto unprepare_clocks; } @@ -1736,7 +1736,7 @@ static int tegra_i2c_init_hardware(struct tegra_i2c_dev *i2c_dev) ret = pm_runtime_get_sync(i2c_dev->dev); if (ret < 0) - dev_err(i2c_dev->dev, "runtime resume failed: %d\n", ret); + dev_err_probe(i2c_dev->dev, ret, "runtime resume failed\n"); else ret = tegra_i2c_init(i2c_dev); From patchwork Tue May 20 19:43:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891584 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 814E525A645 for ; Tue, 20 May 2025 19:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770255; cv=none; b=YFSOBWva4eYfKF+rfbIl96c1+pu46IPMbBRBkqEbxOycIB8ZeIijAK9GzKf91ka1hHUbJ1mNmqnCli0N9pY1xmwIkW2Hwph4Qm1Xhd5az0fNuSz9NGsrWn5tgVL0rpB4j61//LxrmRfPQVMqkOVul4+Ko0UFeK84ZXIrMjO/u5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770255; c=relaxed/simple; bh=nGYnKGhw73dJHiwm1W1eb6FQjjywGbLAgxARipb5Iw4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wnk0vGjeZzhLbHZySZSZIKed5obyPuJmvMSfcGQ20FDUDGLOdNjNcVoYzgXCFhzytHXwY+1UX75qY7U4/xbH081I2Ze12CYiE/YmolhVi6TgZVcI/lBnjIaFoqD2nC1npdFljcOaeI0QAJny0GuII32ycV6uOO3v9crB3jg37fw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CHNnV4sG; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CHNnV4sG" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-601ad859ec0so6266542a12.0 for ; Tue, 20 May 2025 12:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770252; x=1748375052; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ov9ZG4e7DE6olqmoqUw7eHlut/Cel5+9g7jkUvcF8w8=; b=CHNnV4sGu6wQYeaQuUYiTSzlJt1XAYp44XAyLs2BDooVH89Zx4TE2ovnmmJqHH2nRs zAU/kQm9qy7R1govpUpthqhkEWdSexhqXUprzg7m3pTbsjxXoa68YKT1OBMQXVvflh5l /nRMCF5i6G/W57m5y28f/Leh7i8whQxPRD0xbsIJyPpJiRRihM5u74aU4PhjyTb4JbKI CdtpkEkWMKC6kr0SV9AI+3KI+TGL/aI6uCHHPIAWD6gTGX6Q+mNqxO9BliHIREMmNTYc SzgBWkDrRRT8yz12vFpu2dYaXSjWCwJmQ6asl6VQxZSQ77NnRVrVBz0wavhR85KlxflU KUzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770252; x=1748375052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ov9ZG4e7DE6olqmoqUw7eHlut/Cel5+9g7jkUvcF8w8=; b=QlaThCn3KDrVWXnJOMDaUItDrZqG3ptACC/Qr2eT9BzVH/EPwcYyL2m3iGLMckc0sS 5SJGiLaaRGhSTRTYcqnAILQYRVe0kR3uxAqjz1qmO/iVFrWbjHJpBCmeEWmKciOz7Xy2 kJ8tEfUX9Zy9k5c+9U9NYBPS/T8dI6ZiudbvMEcpg/mVqaKVlepRyvbORuyhsq0TdZXC /wuDvjb7q1OSejsqjoRbrtRp3FYwgpFFNHTCMZOgpTFEf+qr8bYmY+Pu8I/P8Hz7HBB7 WvjjdIl8rLvyPumzdmw7BIlzlgfWUfQK+sGHYKIDsue9UPkAZ/ItNLwI4SFrepyiCZcF IhKg== X-Gm-Message-State: AOJu0Yz2ZrMqEzKnj8NcwztcNpUXM4kp+OLmOWLmTAVXACn0sm8jHUDs 5XNne4CxR1UHnW8UWXEhpTXblC015ebeft7iG4LsZ/trlcbglWmVPwGloiWHo4h+zzU= X-Gm-Gg: ASbGncuPdJKqD1UqnVOG5/sREqvwnpFjqThMZ7hZG/hBraUTmxEdUVD2yCBcyucj1Ay 9IVtRbUx8+s3DX7JgkXp8Kj2Hd1leNIGqPhmDqwQAbh1hDw4SB7K9KbGmyPvmfTm/DpQAyC2Di1 zuRu4eTdM8+E7Q2HJn1Lj63m4iPDesoCzcfFS6zEP+Zfn+hFkYskLVR2dc0qOZTvfP9LqmDoi2Y L+rIRuLwolx1qtjDJT3b3tMEV/UhRAzB+7K7XebNWZUNl4d2H1Qbe8lLf01f5KAKpN5QvxDfSaT 5+V1zyrvlr8X5uKyl+44NOhpLPzfIy6qXqmEvRzUb85MNuLyLQx3+Fy/07AS0hEUXWRQYwdyXtP QFdI0dQ== X-Google-Smtp-Source: AGHT+IFHamLUlaZH1stWXeZDPt+Zw/8x4O1P9FYC2tlodQCiVww7NBfQCkxto8I3cnYb2GuQLfHPCg== X-Received: by 2002:a05:6402:90a:b0:5fb:1cbb:9390 with SMTP id 4fb4d7f45d1cf-60090185bbamr14917065a12.33.1747770251683; Tue, 20 May 2025 12:44:11 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:11 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 03/10] i2c: sun6i-p2wi: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:43:53 +0200 Message-ID: <20250520194400.341079-4-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-sun6i-p2wi.c | 55 +++++++++++------------------ 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c index fb5280b8cf7f..dffbe776a195 100644 --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c @@ -194,22 +194,16 @@ static int p2wi_probe(struct platform_device *pdev) int ret; of_property_read_u32(np, "clock-frequency", &clk_freq); - if (clk_freq > P2WI_MAX_FREQ) { - dev_err(dev, - "required clock-frequency (%u Hz) is too high (max = 6MHz)", - clk_freq); - return -EINVAL; - } + if (clk_freq > P2WI_MAX_FREQ) + return dev_err_probe(dev, -EINVAL, + "required clock-frequency (%u Hz) is too high (max = 6MHz)", + clk_freq); - if (clk_freq == 0) { - dev_err(dev, "clock-frequency is set to 0 in DT\n"); - return -EINVAL; - } + if (clk_freq == 0) + return dev_err_probe(dev, -EINVAL, "clock-frequency is set to 0 in DT\n"); - if (of_get_child_count(np) > 1) { - dev_err(dev, "P2WI only supports one target device\n"); - return -EINVAL; - } + if (of_get_child_count(np) > 1) + return dev_err_probe(dev, -EINVAL, "P2WI only supports one target device\n"); p2wi = devm_kzalloc(dev, sizeof(struct p2wi), GFP_KERNEL); if (!p2wi) @@ -226,11 +220,9 @@ static int p2wi_probe(struct platform_device *pdev) childnp = of_get_next_available_child(np, NULL); if (childnp) { ret = of_property_read_u32(childnp, "reg", &target_addr); - if (ret) { - dev_err(dev, "invalid target address on node %pOF\n", - childnp); - return -EINVAL; - } + if (ret) + return dev_err_probe(dev, -EINVAL, + "invalid target address on node %pOF\n", childnp); p2wi->target_addr = target_addr; } @@ -245,26 +237,20 @@ static int p2wi_probe(struct platform_device *pdev) return irq; p2wi->clk = devm_clk_get_enabled(dev, NULL); - if (IS_ERR(p2wi->clk)) { - ret = PTR_ERR(p2wi->clk); - dev_err(dev, "failed to enable clk: %d\n", ret); - return ret; - } + if (IS_ERR(p2wi->clk)) + return dev_err_probe(dev, PTR_ERR(p2wi->clk), + "failed to enable clk\n"); parent_clk_freq = clk_get_rate(p2wi->clk); p2wi->rstc = devm_reset_control_get_exclusive(dev, NULL); - if (IS_ERR(p2wi->rstc)) { - dev_err(dev, "failed to retrieve reset controller: %pe\n", - p2wi->rstc); - return PTR_ERR(p2wi->rstc); - } + if (IS_ERR(p2wi->rstc)) + return dev_err_probe(dev, PTR_ERR(p2wi->rstc), + "failed to retrieve reset controller\n"); ret = reset_control_deassert(p2wi->rstc); - if (ret) { - dev_err(dev, "failed to deassert reset line: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to deassert reset line\n"); init_completion(&p2wi->complete); p2wi->adapter.dev.parent = dev; @@ -276,8 +262,7 @@ static int p2wi_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq, p2wi_interrupt, 0, pdev->name, p2wi); if (ret) { - dev_err(dev, "can't register interrupt handler irq%d: %d\n", - irq, ret); + dev_err_probe(dev, ret, "can't register interrupt handler irq%d\n", irq); goto err_reset_assert; } From patchwork Tue May 20 19:43:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891392 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76EA3211710 for ; Tue, 20 May 2025 19:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770256; cv=none; b=iS36VlUGm8C5BshG0OjG9iOdAOLHyzIkBbBSYJsYGk76NX6q4WHoVYDlZjK7WG0PgpJkNPz2OYwnHIFWaSRsdSI9xOPEg0HtbdSIuh/4OkEdBgvZWaCJxZjmwvxOMaRxtvpm7JkTqwDMH2HbuUCeOmxjuPDnOF3oP/XA4/CJJ4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770256; c=relaxed/simple; bh=wR9auhATL6wnlfrWjsXykx9UKqMr86UB+LIXzCuL/BY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ITeLAxzIg4Xx3/Q48gxL5DbVW9LR8R3ZU5wGEeCkcg3K7v5a5H43HZiBdWFjAZn3m+5F8zKktH49aIlFTO3W9qi+RfkYrkSdMsi9cM4Yhh/zmXRBhibLoSZ+TEiM1wxSQowuWx15gmuOQz17r2FAVRk7pjhfb799+zf/MAdq9+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QU04eAnz; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QU04eAnz" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-6015f8d4b7dso1283240a12.1 for ; Tue, 20 May 2025 12:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770253; x=1748375053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8RCCW4FNzoeNvxVglIw2r9Xf1QUNgZrscpO4kdi/4Lo=; b=QU04eAnzktVsr7ZKjee7Se4fcR6OxnD2jUVghg57Gfw15RtcM2XRCCtfQvpiCWmXzB UVqHxou5aTHzDhJ0yKP45m1RUvgHkBDyKb3sPIEHgNRNK//8JmGKv2ZSzVWxw+8PuRr4 CgXuXfQKGoQfKruoSHYUeikPPW7ulvUM+1mdgomdR6wh3C6ltc8gRfJdiEhPPJXR7ysu CkK9vwYJGekQpOgmalUEoTjbxZyONvfzjyYxmE2P8H9v6jk2lyQ9X0MbSk5cxnqStL/y haQCIn/2nUezCsNjwjkJ/b74C2R+nCCxJG1V1QIZPIzPMFSZ+WlrzvWAX5sgm2izezHo ScLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770253; x=1748375053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8RCCW4FNzoeNvxVglIw2r9Xf1QUNgZrscpO4kdi/4Lo=; b=m7enuDQ6GzEVSxDEehG+qkT5CziJr1mCc35LG2GtQ1lZQVCCax+l3n+S5NJW4DRJ4C P54+yNFEShpSZ5z6hJrAvpHgs1PKo/HjzFdlxwuPPzWVy/QQMVhc0ztmG1DMU0v5+cae YQ5+Zbr/t4k0gLeoz2995gqo5RrPVEZPljtOp2Zz189LvUA7q7fimJ5dhuDqbnOuOahQ q8GoAWe1KymRpc+exUZFq/73AQyzENI7FnX3Lmj0FYezzrHF2Zuoyj/nMbXiaqA3sNSx 7AkEWQPHUDYaqu6lTzWPKcxIftygGhZiO3F5ipbY9TfSUVbfSfVxqD9/4CNnJI0hA9K8 gfCA== X-Gm-Message-State: AOJu0YzwDQK4/5mmvM3AqOer0+VtYDA54F4W5KBJCV4ipKdeMuQ6+KJQ B+eG2aIlY9yAm4mv/FE8H9xBVj59YfJC4JjsOlHzGMOOKOst2htjweCWvi80Rbx9mYU= X-Gm-Gg: ASbGncv+7NAnDvfUrB34i/09A33uumYjIYt/H2jW9+DZkqtjDQnQog/k3deZa4zfzC6 74IIYydy8Kp3E67f6VzbK3TLMp62JmEnYO+uI9DjUWAburv8pEHG9FFAzYsYqBl/lWXUUE0Hroz BG+FhPMZnD/g6t7I29O0QGQhE89laFD5FQt5DkSCpAbXoJW7j/aGplc+VR7u3n4bNyjqPOXFcjH WadWBG7KUFyakqIbWzTkRQ1y8+7mkPnquUwidXfcFDqC32NFeiJAJed3Kk3YZl5wEZf7be6ux4q 1iGMoOmnS/jT3Y6sVTnTdnqOtDj8ObX5ZyPb2hDxWikIWwSlF7KIgy+2aNX5hljt1UVW/iFFRpp IaSMtqw== X-Google-Smtp-Source: AGHT+IFTrjA+H/FCGX1AEec8OkYZb304WlZRq+zsYBOIw8r/blP5vxAXT8Cbudjjmr7xmlyeJjhSXQ== X-Received: by 2002:aa7:da1a:0:b0:601:89d4:969f with SMTP id 4fb4d7f45d1cf-60189d49957mr10859561a12.32.1747770252671; Tue, 20 May 2025 12:44:12 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:12 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 04/10] i2c: stm32f7: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:43:54 +0200 Message-ID: <20250520194400.341079-5-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-stm32f7.c | 78 ++++++++++++-------------------- 1 file changed, 30 insertions(+), 48 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index 973a3a8c6d4a..1a9d727b0ce6 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -480,28 +480,22 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, int ret = 0; specs = stm32f7_get_specs(setup->speed_freq); - if (specs == ERR_PTR(-EINVAL)) { - dev_err(i2c_dev->dev, "speed out of bound {%d}\n", - setup->speed_freq); - return -EINVAL; - } + if (specs == ERR_PTR(-EINVAL)) + return dev_err_probe(i2c_dev->dev, -EINVAL, "speed out of bound {%d}\n", + setup->speed_freq); if ((setup->rise_time > specs->rise_max) || - (setup->fall_time > specs->fall_max)) { - dev_err(i2c_dev->dev, - "timings out of bound Rise{%d>%d}/Fall{%d>%d}\n", - setup->rise_time, specs->rise_max, - setup->fall_time, specs->fall_max); - return -EINVAL; - } + (setup->fall_time > specs->fall_max)) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "timings out of bound Rise{%d>%d}/Fall{%d>%d}\n", + setup->rise_time, specs->rise_max, + setup->fall_time, specs->fall_max); i2c_dev->dnf = DIV_ROUND_CLOSEST(i2c_dev->dnf_dt, i2cclk); - if (i2c_dev->dnf > STM32F7_I2C_DNF_MAX) { - dev_err(i2c_dev->dev, - "DNF out of bound %d/%d\n", - i2c_dev->dnf * i2cclk, STM32F7_I2C_DNF_MAX * i2cclk); - return -EINVAL; - } + if (i2c_dev->dnf > STM32F7_I2C_DNF_MAX) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "DNF out of bound %d/%d\n", i2c_dev->dnf * i2cclk, + STM32F7_I2C_DNF_MAX * i2cclk); /* Analog and Digital Filters */ af_delay_min = @@ -566,8 +560,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, } if (list_empty(&solutions)) { - dev_err(i2c_dev->dev, "no Prescaler solution\n"); - ret = -EPERM; + ret = dev_err_probe(i2c_dev->dev, -EPERM, "no Prescaler solution\n"); goto exit; } @@ -623,8 +616,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, } if (!s) { - dev_err(i2c_dev->dev, "no solution at all\n"); - ret = -EPERM; + ret = dev_err_probe(i2c_dev->dev, -EPERM, "no solution at all\n"); goto exit; } @@ -673,11 +665,9 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, i2c_parse_fw_timings(i2c_dev->dev, t, false); - if (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) { - dev_err(i2c_dev->dev, "Invalid bus speed (%i>%i)\n", - t->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ); - return -EINVAL; - } + if (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) + return dev_err_probe(i2c_dev->dev, -EINVAL, "Invalid bus speed (%i>%i)\n", + t->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ); setup->speed_freq = t->bus_freq_hz; i2c_dev->setup.rise_time = t->scl_rise_ns; @@ -685,10 +675,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, i2c_dev->dnf_dt = t->digital_filter_width_ns; setup->clock_src = clk_get_rate(i2c_dev->clk); - if (!setup->clock_src) { - dev_err(i2c_dev->dev, "clock rate is 0\n"); - return -EINVAL; - } + if (!setup->clock_src) + return dev_err_probe(i2c_dev->dev, -EINVAL, "clock rate is 0\n"); if (!of_property_read_bool(i2c_dev->dev->of_node, "i2c-digital-filter")) i2c_dev->dnf_dt = STM32F7_I2C_DNF_DEFAULT; @@ -697,8 +685,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, ret = stm32f7_i2c_compute_timing(i2c_dev, setup, &i2c_dev->timing); if (ret) { - dev_err(i2c_dev->dev, - "failed to compute I2C timings.\n"); + dev_err_probe(i2c_dev->dev, ret, + "failed to compute I2C timings.\n"); if (setup->speed_freq <= I2C_MAX_STANDARD_MODE_FREQ) break; setup->speed_freq = @@ -709,10 +697,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, } } while (ret); - if (ret) { - dev_err(i2c_dev->dev, "Impossible to compute I2C timings.\n"); - return ret; - } + if (ret) + return dev_err_probe(i2c_dev->dev, ret, "Impossible to compute I2C timings.\n"); i2c_dev->analog_filter = of_property_read_bool(i2c_dev->dev->of_node, "i2c-analog-filter"); @@ -2174,10 +2160,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) return -ENOMEM; setup = of_device_get_match_data(&pdev->dev); - if (!setup) { - dev_err(&pdev->dev, "Can't get device data\n"); - return -ENODEV; - } + if (!setup) + return dev_err_probe(&pdev->dev, -ENODEV, "Can't get device data\n"); i2c_dev->setup = *setup; i2c_dev->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); @@ -2278,7 +2262,7 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) ret = dev_pm_set_wake_irq(i2c_dev->dev, irq_event); if (ret) { - dev_err(i2c_dev->dev, "Failed to set wake up irq\n"); + dev_err_probe(i2c_dev->dev, ret, "Failed to set wake up irq\n"); goto clr_wakeup_capable; } } @@ -2304,9 +2288,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) if (i2c_dev->smbus_mode) { ret = stm32f7_i2c_enable_smbus_host(i2c_dev); if (ret) { - dev_err(i2c_dev->dev, - "failed to enable SMBus Host-Notify protocol (%d)\n", - ret); + dev_err_probe(i2c_dev->dev, ret, + "failed to enable SMBus Host-Notify protocol\n"); goto i2c_adapter_remove; } } @@ -2314,9 +2297,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) if (of_property_read_bool(pdev->dev.of_node, "smbus-alert")) { ret = stm32f7_i2c_enable_smbus_alert(i2c_dev); if (ret) { - dev_err(i2c_dev->dev, - "failed to enable SMBus alert protocol (%d)\n", - ret); + dev_err_probe(i2c_dev->dev, ret, + "failed to enable SMBus alert protocol\n"); goto i2c_disable_smbus_host; } } From patchwork Tue May 20 19:43:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891583 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ECAE2820BE for ; Tue, 20 May 2025 19:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770257; cv=none; b=YHhYZWCE7S/k3d9G33e3DCWVrm39MF3bxMMYNJf3unothKx2nstM2t6x+8TbHTod72RVucRcBhJ5wkYvCZpR1pZYj8n5FUvosNTpzfws2I3xpcU0K/rXF1Z+NCYD+jLAGzNqAK9YWmbrblRN7q4GvMCcYIopThf6OFVKEkbKkyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770257; c=relaxed/simple; bh=YqjOWrzlHnNKu5uHpA1rE4wWliA7EPUf+cDA2KE8X3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PpG6IkwqMfCdo8dEkrtx2gzr8ZlSpVhSBMdZS5dh4Mb6oGBU9RFAHMzghscVVZaCAPVUMdygat6uZKkZHzUxaZEXBx45ZA0swfXVgXYBRYicegfB8x+JAQC5sZZFKIQriM6GtavYnO33KzwcZRn0RKzExbWD0Uo31IEYbr4FfrU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hmUDIx89; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hmUDIx89" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-acbb85ce788so1193158466b.3 for ; Tue, 20 May 2025 12:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770254; x=1748375054; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9uDr8J6lTyQptmES90WjIqWyVhKsxxX+fGaD8I9r3OA=; b=hmUDIx894ObbgnykcKcvJUJeACaOi2OxNEVe6w1TpgG2yZCHghtcX/fP3s69hNuSrX ZBSrbRF+I18DBq3Slw8DwkkCPyoefEf2XH/lGfnNc8pBDeqztEhIdHNTz7tl3jvv4z6H IJAdpFhBRzuHXDiYbIhUzBRCEpyFSSRGxd54tNQI8pydOyNlwgvgADlhziOqnHFfpsZK 589cS/hLGTVuZtUW1VfKLJr4XVVc/HUELWZlQyajkienbWeG5aToGQggA2WRLWt2VPfw sCGjxqUBzg9vQ1LaeGsADS42UsX67T6D/C/6IscD3vABxvtukCFPJCW3fRQQCH8baYX8 +9Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770254; x=1748375054; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9uDr8J6lTyQptmES90WjIqWyVhKsxxX+fGaD8I9r3OA=; b=k7i9xyD+7W7nQSmwPJ5z44wvLk4rse3QENuNhV1XntBFT5bKG2EPS8VgOGP7Vm59bU ixkBrqZ8kFNcr4d6BLPTYD9XEA30MaomYOI6FOpoyhUbFZ1bIw7UjyVTbQXUjDcTLneX hUIIX6n9R5Vp8B4zJlOudXgm8M15I4ZtgqWgFeroa8qShdRyDv4Wmj6gMd0MMk5EFtZu 2hEyphIbP+LWiILE70jIxSyMmRa14qNNhAmGxONRQJtxoK3I5Bi2m2dsyxFai1qg/L4V OMmxNPYo8jfmZ/yLlBdSm6KEe/LREhya3hT6XWGVoe9+OPNzGQ5ynhwP8ELY7NqcWJn/ EV5g== X-Gm-Message-State: AOJu0YwXz+UkIezpEJ6gDsYtKl6VVQkOB/kzNz3bwNV86gOHgNeKEHVI U7UH2Qw3gNhSW5ea2ygmxDqWkYkHDreLMbaLrT+GwcH6oHhCBxoHQRrtHFmweQOqJLE= X-Gm-Gg: ASbGnctzoxIH1Xp+3/eNnGJNqmO+XquClKR4U8z5/i3X6XSWd4wQrwZ3CPuNZ0I3Mq+ olhFaB9lg4zK0Os6SvQj7RyVJus5LfDka4WPHz3bzfvURycO+YoszNNIoMYbJlCsS00UMkZJT5J SNO8bLrlIg2wOhUQuf1pT21fG2nNZfEzoSJ2Pqm65MWb8OgWJ7Oh2aauD3cYzTKYnvoUti9l5fX /5EawR9bT2fDYI68KiVP0s00dSVKKXrvb1YcGWRj7N+NvrmQM3+G/AjjQAoa/b2t9kExoLCpd6Y UgoZTl4veD05n+fYzdofhA0iK1zHmnbJ472VcZgcdJ5eXvbwuQsljoGM+r+9+ZyTa89eoXCOJ/y BD675DA== X-Google-Smtp-Source: AGHT+IHi/x1DeJ5Bvev3uQKxrlCpxcgHtSVGvBCkHn+b8S08rkyZ0kDW8PsaTB7/EzQ2bURI1UeWwQ== X-Received: by 2002:a17:907:1b0f:b0:ad5:5293:f236 with SMTP id a640c23a62f3a-ad55293f282mr1288606266b.3.1747770253678; Tue, 20 May 2025 12:44:13 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:13 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 05/10] i2c: stm32f4: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:43:55 +0200 Message-ID: <20250520194400.341079-6-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-stm32f4.c | 53 +++++++++++++------------------- 1 file changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c index b3d56d0aa9d0..44e8b04962bb 100644 --- a/drivers/i2c/busses/i2c-stm32f4.c +++ b/drivers/i2c/busses/i2c-stm32f4.c @@ -163,11 +163,9 @@ static int stm32f4_i2c_set_periph_clk_freq(struct stm32f4_i2c_dev *i2c_dev) * to hardware limitation */ if (freq < STM32F4_I2C_MIN_STANDARD_FREQ || - freq > STM32F4_I2C_MAX_FREQ) { - dev_err(i2c_dev->dev, - "bad parent clk freq for standard mode\n"); - return -EINVAL; - } + freq > STM32F4_I2C_MAX_FREQ) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "bad parent clk freq for standard mode\n"); } else { /* * To be as close as possible to 400 kHz, the parent clk @@ -175,11 +173,9 @@ static int stm32f4_i2c_set_periph_clk_freq(struct stm32f4_i2c_dev *i2c_dev) * maximum value of 46 MHz due to hardware limitation */ if (freq < STM32F4_I2C_MIN_FAST_FREQ || - freq > STM32F4_I2C_MAX_FREQ) { - dev_err(i2c_dev->dev, - "bad parent clk freq for fast mode\n"); - return -EINVAL; - } + freq > STM32F4_I2C_MAX_FREQ) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "bad parent clk freq for fast mode\n"); } cr2 |= STM32F4_I2C_CR2_FREQ(freq); @@ -772,22 +768,19 @@ static int stm32f4_i2c_probe(struct platform_device *pdev) return PTR_ERR(i2c_dev->base); irq_event = irq_of_parse_and_map(np, 0); - if (!irq_event) { - dev_err(&pdev->dev, "IRQ event missing or invalid\n"); - return -EINVAL; - } + if (!irq_event) + return dev_err_probe(&pdev->dev, -EINVAL, + "IRQ event missing or invalid\n"); irq_error = irq_of_parse_and_map(np, 1); - if (!irq_error) { - dev_err(&pdev->dev, "IRQ error missing or invalid\n"); - return -EINVAL; - } + if (!irq_error) + return dev_err_probe(&pdev->dev, -EINVAL, + "IRQ error missing or invalid\n"); i2c_dev->clk = devm_clk_get_enabled(&pdev->dev, NULL); - if (IS_ERR(i2c_dev->clk)) { - dev_err(&pdev->dev, "Failed to enable clock\n"); - return PTR_ERR(i2c_dev->clk); - } + if (IS_ERR(i2c_dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk), + "Failed to enable clock\n"); rst = devm_reset_control_get_exclusive(&pdev->dev, NULL); if (IS_ERR(rst)) @@ -807,19 +800,15 @@ static int stm32f4_i2c_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq_event, stm32f4_i2c_isr_event, 0, pdev->name, i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq event %i\n", - irq_event); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to request irq event %i\n", irq_event); ret = devm_request_irq(&pdev->dev, irq_error, stm32f4_i2c_isr_error, 0, pdev->name, i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq error %i\n", - irq_error); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to request irq error %i\n", irq_error); ret = stm32f4_i2c_hw_config(i2c_dev); if (ret) From patchwork Tue May 20 19:43:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891582 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C7727FD79 for ; Tue, 20 May 2025 19:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770261; cv=none; b=XuTgxFY1wwnrwhai2PtT1iSUtimiJdQQFiTkl+fahP5Bg+Cjd089PlFAbQ37+CQFSx4wbvDkWIAiESIGBlIodUqrBZBTw9dn1O0JWRM9j3PKJekoYGupJe0zPKcmkHJkHp45E21dpZIDP1t4pT9DSKR0FdNR1PmmmuYgipIj+n0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770261; c=relaxed/simple; bh=ynmAYPvAH/LrmJpo4MDryQML6zzuiHc67Q5YNVT/TUk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Je6kdgYKGN03WvKI1swlncf+9egk3yiszwz43tVhNcefH2yNpRG3jeQaDkCLrenQB/3dHKWqUJNZK0w4NzqwlY6lxSdG6HTDhlGzOsJE0cXHFKoVR262CTDdYZz0jRnoIpp4WJhap5Kzeb/l0djei4vrfeyrVwS77GGumFiD2Ks= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NR8JDEpp; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NR8JDEpp" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-60119cd50b6so7372004a12.0 for ; Tue, 20 May 2025 12:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770255; x=1748375055; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qMzYJhCcEP323syMKgIcqE5uCw3H1V/W8yGCAUNpQsY=; b=NR8JDEpp34gdAKQqwHQ9QNamdlKyxETX1jIy4pVhFYsEquJdQNKwI4Yqf3F6NSQi9x w3CH3Pevgkx4l0O4HaD5coSh47CVqg6HueuuVuI5Iy7vUCSCc9SHVzKc/QOPnXgxooCa ir/3bji0Zkbm3R2xh6+Qa8vta81ilZXOfACGt69p9MsDy+kXJ03Md1y/+cAIu0EtMPvg f7NfxELDMD7j59WSfmHMUbiw9yApZ9V9lXu48mPSQLtaRJD4JBJowftT7aIbFbx4FSQU 8gh2kE/cll08V/d+kTNrMs2+ES+J5zzygRbIiVVBxifPU70K47nRyhP8XEVeYP/+Ls08 XNmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770255; x=1748375055; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qMzYJhCcEP323syMKgIcqE5uCw3H1V/W8yGCAUNpQsY=; b=DoQvCBpVrxhstLRMrNuESD9UKjLd/8ae5/jEB9hQI1kMswo5t+/cc7UuT7OROMZ3xN eLH42LXf0tQPV6H4fF4M0ezsroWgtJ17+L8AxnEmpKBkXScZfJGvUXm79/2YwiHwVoQc NMlnfEH/RWwrvfMHZFTjF+Ax7uNMHa1RJguI2SNZ6SUYYwp4tIwusT0Y8e2N5vB+qdA3 XGYXujAPu4963/9dqr7FHS+9Me/ArqDhZUGvC6CZ3bDKGB20FXB/iAkp1r+WTuGbk7uh IkN27OpsrL2aFvYzSdGcX/A89myTF1qHGA7/ChVGMdHC4lJwKQWrSTfgqtxj4HiOi61Z zVnA== X-Gm-Message-State: AOJu0YwDs2jy/++j4NEkc4EgRQiimeja3Qaf5wKsYc1JVLQqHlKRXtoH x7zEFaXZt38jr2iOwPlLmQQpIINGx03WK7pYwrxRcwMYmkf6qt+3IZLktQ7mjeX1Zhw= X-Gm-Gg: ASbGnctkE7lS54RvhhSA0hdSnPKJJXtfzvY8WQWBGjdgARh2cnUjmm/Ew7ENkBVtDi7 ti9oKk6NR2PTKbRp3u301w+0TqCRfYosWFIYfOJAqEBjBKMI1RlP3V2dFVqAUpVCofeRGNiEGof h9VcRMUMlVicqvRFr4zXQnIswd8cZ0C7LMjpR15MyIDA2eYmbJgE0hKFVYKwxuaxF7dGcbmE1th t47zjzmILUm1lwIl1KIKf6xVW08Zlif3juZWFNsUV55YFu519J2hAobrvOuGuLvlb83EZ+p9j6F zvu5zN0xG+JuxOOmZYQUQZUYjoAby6XMaJ6uAmfJzdG5/sc8Geg644uTfFjqIw7nzcw/sQGc6Fw suHCAJA== X-Google-Smtp-Source: AGHT+IEOZKLkNNOKqbGOrrrwFvzZGZVVSB/SHPQM+mtOGIzuM939ggKcukOo9Kx6T5AQzkd/ey1pjA== X-Received: by 2002:a05:6402:2789:b0:602:29e0:5e2f with SMTP id 4fb4d7f45d1cf-60229e061e6mr1125654a12.10.1747770254571; Tue, 20 May 2025 12:44:14 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:14 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 06/10] i2c: stm32: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:43:56 +0200 Message-ID: <20250520194400.341079-7-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c index 157c64e27d0b..3ca84fef230c 100644 --- a/drivers/i2c/busses/i2c-stm32.c +++ b/drivers/i2c/busses/i2c-stm32.c @@ -39,7 +39,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev, dma_sconfig.direction = DMA_MEM_TO_DEV; ret = dmaengine_slave_config(dma->chan_tx, &dma_sconfig); if (ret < 0) { - dev_err(dev, "can't configure tx channel\n"); + dev_err_probe(dev, ret, "can't configure tx channel\n"); goto fail_tx; } @@ -61,7 +61,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev, dma_sconfig.direction = DMA_DEV_TO_MEM; ret = dmaengine_slave_config(dma->chan_rx, &dma_sconfig); if (ret < 0) { - dev_err(dev, "can't configure rx channel\n"); + dev_err_probe(dev, ret, "can't configure rx channel\n"); goto fail_rx; } From patchwork Tue May 20 19:43:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891391 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84E3C27FD4D for ; Tue, 20 May 2025 19:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770260; cv=none; b=gIs2xhdZv0O0XJAnLFDjR+7GqF3uJ1CQ8l+5NXkNPavWD9bvH5+mNBquiBMklf8CEswjpNB3B5yFAaSu+CgjYfNK4Agir9lGG4e2PVH+b4SyBeIcePqG6Ajq8IVPBMZk9oSimWxekLyUNTRcnTh0aYvipoo3iW7woqL1eFtGCCY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770260; c=relaxed/simple; bh=6bDSviPTEwFEXcWZySCcxrDK6S0DSpavH2mDF2+eyoU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qvCwBegt3XwSLwPtawcThDKuj0yj/zr8e2SoD4mZ4taVQmy1rTCbI74WnlCSj3FzV6pt1odHk9DvjzumEMq7Y5zBf1wZMuXEb1TnarZZ+dD8uv4UswDDJdBj3rvYpvepRbnG0vh5HA8uZw16cbZzfRZzL1t83VXQRJdwfS2bJ9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X3s21wLN; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X3s21wLN" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-601afe51106so4467124a12.1 for ; Tue, 20 May 2025 12:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770256; x=1748375056; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SMPXPAMRhAmykmGRJk3xsS3rWd1ulHzSKuY5YnUZI1w=; b=X3s21wLNVhJD4G+lBBU2yvkiTqV2kLMG84XPatCwX3lEK1hRQv7hgMMGav5z0f1mAK bYijSinxEgjxNCYRQOwCGiJAKC2sOkLODxpjAaFJTvDHr9dYy84Ykr0mm38+DsYRgTOy /f/zEMHJd+0Ns7+4R1uky1mfGdA849v0nyVevPQiPaosppiPbZOE6QwXzBTBiLnZWIs7 hNgiNYD2UrzQjQ645GSpp0rZQlz9szbg5mGO38WsgQpJNKtgEeMW+NosIs7X2Goo69F+ VFgumrb6/bjFlxGtftwPg4CstK69cL4INE2JoloLg4Cn4iLw7j9+Ff/uyFQNmIj+XB7u Oj1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770256; x=1748375056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SMPXPAMRhAmykmGRJk3xsS3rWd1ulHzSKuY5YnUZI1w=; b=wh4M06rS0DOPk0/t0zYk3H50RpGJTr2uwGndyEPbdBYxEuR3NSAEW8Rqsyx6tGgy29 cEJLy3huNAhkel1NMuz0tQmx9vsgfKOBUAH1xDioe6hQFFg5wpoB5N6IsahOtjj1/qTL IOOrKJQ0Yp4AeFeUEzXkDRE59NhVgourJYOO1mO86Cu1ylRLI/ccpdyrpdwc+XdjFb3L 1/7X6mM7cws0fh9p6V3XGzmEuMrG9L6bpvdeDkz+jMXC2QSnosbOcjz/oL6x/UhI3FKV XTCOA4hpjfmo2LhGNiFn62NMCT4PZv9Jiv4t4NOVIrAPLA/kM8EJG49xu08zVxyXhVqB 1NvQ== X-Gm-Message-State: AOJu0YxL8LNhMV5h0S2B4jCMeOlW4MoMkt7l7vP8mLQHzZWt/EgY+v+U EPIAryAalsXRN/+5aHkW2zP9vja5vK2SSF82on5Y/eMeLVVZXcn9NEqVgB+vjGh4 X-Gm-Gg: ASbGnctrBdWzeWtqHR+waRcGbEND2zkZXzAw4fiPn7EH+G5yWwi/XvXY8mFxO5hTnga 3NM89PsU600nDzaGsKjLvQPzvFOh2bGEc65M4AQqX5mIUmtUMrRBI5i5XdTGPnrXAP+GTKpzG5I 85tWMjNk/shupRW3JVR9iXHJXDaCcr31uqbFC4aUUOPw0eOSeVHh5Te6fXQ+p5ih6FBfGAS39Vu InXvXT4gqelVohk0QBPweQdIrfb/S3c12J9DVMwoVFR7z+RhaKg5dyptDoMoRo6vNLpMmBaMq6o zK4wxc6v44qbxPkee5kFpMMt0lGSiVic6cJbJgctuC8JIQPhe+NwvC3ytnmkkie2bPY0MH+tk7y WtQfu6g== X-Google-Smtp-Source: AGHT+IHdPxGKF+PxNRa6DzDEHfHbcwS+uR0+RgIRbHjr8zT1d6wtx5CK9f9G7111zdVcI62zdynIlA== X-Received: by 2002:a05:6402:26d0:b0:601:f4e2:320c with SMTP id 4fb4d7f45d1cf-601f4e23302mr5878120a12.23.1747770255675; Tue, 20 May 2025 12:44:15 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:15 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 07/10] i2c: st: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:43:57 +0200 Message-ID: <20250520194400.341079-8-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-st.c | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c index 750fff3d2389..96e4c68428b1 100644 --- a/drivers/i2c/busses/i2c-st.c +++ b/drivers/i2c/busses/i2c-st.c @@ -781,17 +781,15 @@ static int st_i2c_of_get_deglitch(struct device_node *np, ret = of_property_read_u32(np, "st,i2c-min-scl-pulse-width-us", &i2c_dev->scl_min_width_us); - if ((ret == -ENODATA) || (ret == -EOVERFLOW)) { - dev_err(i2c_dev->dev, "st,i2c-min-scl-pulse-width-us invalid\n"); - return ret; - } + if ((ret == -ENODATA) || (ret == -EOVERFLOW)) + return dev_err_probe(i2c_dev->dev, ret, + "st,i2c-min-scl-pulse-width-us invalid\n"); ret = of_property_read_u32(np, "st,i2c-min-sda-pulse-width-us", &i2c_dev->sda_min_width_us); - if ((ret == -ENODATA) || (ret == -EOVERFLOW)) { - dev_err(i2c_dev->dev, "st,i2c-min-sda-pulse-width-us invalid\n"); - return ret; - } + if ((ret == -ENODATA) || (ret == -EOVERFLOW)) + return dev_err_probe(i2c_dev->dev, ret, + "st,i2c-min-sda-pulse-width-us invalid\n"); return 0; } @@ -814,16 +812,13 @@ static int st_i2c_probe(struct platform_device *pdev) return PTR_ERR(i2c_dev->base); i2c_dev->irq = irq_of_parse_and_map(np, 0); - if (!i2c_dev->irq) { - dev_err(&pdev->dev, "IRQ missing or invalid\n"); - return -EINVAL; - } + if (!i2c_dev->irq) + return dev_err_probe(&pdev->dev, -EINVAL, "IRQ missing or invalid\n"); i2c_dev->clk = of_clk_get_by_name(np, "ssc"); - if (IS_ERR(i2c_dev->clk)) { - dev_err(&pdev->dev, "Unable to request clock\n"); - return PTR_ERR(i2c_dev->clk); - } + if (IS_ERR(i2c_dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk), + "Unable to request clock\n"); i2c_dev->mode = I2C_MODE_STANDARD; ret = of_property_read_u32(np, "clock-frequency", &clk_rate); @@ -835,10 +830,9 @@ static int st_i2c_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, i2c_dev->irq, NULL, st_i2c_isr_thread, IRQF_ONESHOT, pdev->name, i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq %i\n", i2c_dev->irq); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to request irq %i\n", i2c_dev->irq); pinctrl_pm_select_default_state(i2c_dev->dev); /* In case idle state available, select it */ From patchwork Tue May 20 19:43:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891390 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96CA3280315 for ; Tue, 20 May 2025 19:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770261; cv=none; b=pUQEcP/oUra/4l814E005ZrQusJ/aSaHNkSk/C0Ynh4Am+bD2cxxoOw6wvO9bmhqphoq9ENtbufkvPYiuzWIJRLJ1NkFrAhXahbP0fC0pVF2JJgON/3KpYo+MNAuqi2sTrD3o1e8BEM2Tx1ejg4ZAxDPhAL4Mw5qUUqtNMTE4Lk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770261; c=relaxed/simple; bh=F795GdY6ayBv0DwLnMom/uSHZRkwwVkciJQIcg/xdwg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h8F03MoR5TLhVtQab4MV0/HC5JbQJBkG7nx7IyXOXw+rPL5Q6mXNeytTM+G04mV1im/y7snnxS5dWwyZT38Y5cH630FKoqBO/QsW0M0BpjxdVZht/kHQYsafzsxAxvheeFksK3UJExUM7a7kE3HjhsXape314FElXt6PE2O8GMY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ms5jg6Uh; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ms5jg6Uh" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-601aa44af77so5967365a12.3 for ; Tue, 20 May 2025 12:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770257; x=1748375057; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DCs1F6io3un3HDzqL7E1QMr2p+GN43rrNRa2GPduaWE=; b=ms5jg6UhaxFH23UZH7+wnwi4gYg/AJUtPD+PMOgGIdAySPRuC/jZ3NmT4zGBc1Ct+M uVH6sQyrNxhGT+B0xN6XrMQtvzIlGxuUTNgpsTxlGUWw5NY5pvT430SXCJSwNwiGDP4f 7h42084TGVFn5mTgnMk5KW6pI/Ua/WlvkY0uuPe6LhuEaA833Ak4mfrC1GCyl1+LoVpj mXDGlbufzie1LLG0iwBHoMVazI6ozAkhsuT+64H0aSl3PTDa7czH3yEEAF7FgJfbQuCl YzxPj7u4s3RwWSdT5kMUGS8XjzBPRLdKkHllcW18mfPQ1Ag2ZSLL9gpddJK20C9sh1UJ N0XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770257; x=1748375057; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DCs1F6io3un3HDzqL7E1QMr2p+GN43rrNRa2GPduaWE=; b=MmOe4q1ZEQKerMsWefAgj/wJbbkqVGypfAc1FoCCwbex1Dz1oFRlZQHA95HWDmTW4G bJuxWzot+laifNiPJS67Us/NYwfg9Ujn8hlL13KynfSXDUQrWAIDnJ2tfXVkeMdsUmYD sh3yRxPv2HRmFXs6E+NQoVcv+YUUGZZ2dwpxSKz9odDPieCCghSD8rGpPSsSSczxT5E9 sLGLeOWqd3fgBpN/U3k4huW0Kzo+TwnaDMgdQpaJaGQ4cFgBVL52ck/XXaEdFaVX6k0t /S1LiAoDVACRm4hBML3DZkMljSKHE2oRXJo7hrEl4YWbW1tZDSaWeGuchURC0bER1zTH ZWiA== X-Gm-Message-State: AOJu0Yx3eltvMEPpKxZ8nYe+v7i9vOD7OmZdYyG6OMjJiit5WPRG2gnF m/XFvWB3ZsQJawzl2WQJ6/511VBGjqtdJNOs9ui/SprXB70kcN2xf2g1asTPBmOz X-Gm-Gg: ASbGncsLlE97ZtRydSepZVSZaHmKKmV/kDGjwGv2GZtAmceI9w1wxzYFZbNXU0rmaav hW9jlRROWv8S1v3SZH+tHQ4Qq4/Jxnfx0dv9HjSi+Ho/FqPwsWUj+KkGnHuokHrH3kdFJUzru2L 4FXxWxclDFb0DznjpmJO50obmct+U2u86FeoogIJAoDe/TtgTDufwMlJUwuWOBuyHb+2dRk9qT6 eytDvt44E4DhGaSCvYWvVpHu8oc3WykxIUgnJ4fzKrA+tGJD6DxTY7EnDuiEBnPrWIiJkxtcUOk q1mn+POwJWb+z7diWoLDldAporR8sCPEDXlFMS3o9Wvz57ahzwgxniUhJCBKIdHvLoIit8T0FHx 8C6ywTg== X-Google-Smtp-Source: AGHT+IGPX5BxiP38YfWj7Ou9pfAOejBr7vEZS69PUxzmSPGAgro2F9kVcV7FG2/Nsr9oykEMvZOj5Q== X-Received: by 2002:a05:6402:40c3:b0:601:fcc7:4520 with SMTP id 4fb4d7f45d1cf-601fcc748ddmr5660684a12.4.1747770256689; Tue, 20 May 2025 12:44:16 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:16 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 08/10] i2c: sprd: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:43:58 +0200 Message-ID: <20250520194400.341079-9-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-sprd.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c index 56b2e5c5fb49..9dfcb4955610 100644 --- a/drivers/i2c/busses/i2c-sprd.c +++ b/drivers/i2c/busses/i2c-sprd.c @@ -470,11 +470,10 @@ static int sprd_i2c_clk_init(struct sprd_i2c *i2c_dev) i2c_dev->adap.nr, i2c_dev->src_clk); i2c_dev->clk = devm_clk_get(i2c_dev->dev, "enable"); - if (IS_ERR(i2c_dev->clk)) { - dev_err(i2c_dev->dev, "i2c%d can't get the enable clock\n", - i2c_dev->adap.nr); - return PTR_ERR(i2c_dev->clk); - } + if (IS_ERR(i2c_dev->clk)) + return dev_err_probe(i2c_dev->dev, PTR_ERR(i2c_dev->clk), + "i2c%d can't get the enable clock\n", + i2c_dev->adap.nr); return 0; } @@ -549,13 +548,13 @@ static int sprd_i2c_probe(struct platform_device *pdev) IRQF_NO_SUSPEND | IRQF_ONESHOT, pdev->name, i2c_dev); if (ret) { - dev_err(&pdev->dev, "failed to request irq %d\n", i2c_dev->irq); + dev_err_probe(&pdev->dev, ret, "failed to request irq %d\n", i2c_dev->irq); goto err_rpm_put; } ret = i2c_add_numbered_adapter(&i2c_dev->adap); if (ret) { - dev_err(&pdev->dev, "add adapter failed\n"); + dev_err_probe(&pdev->dev, ret, "add adapter failed\n"); goto err_rpm_put; } From patchwork Tue May 20 19:43:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891581 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99A30280CFB for ; Tue, 20 May 2025 19:44:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770261; cv=none; b=Imjfs5yqYYLcMKG31V0t43g6elr5VyMOysz1o1NiRVg/d/sf6ewEzv6EAW69gW7PLAAT+5hXl7V1gs8YlRxnmPfedLe/LeoumoOIttbtRaxIUbTDeygyM0nOMhgd7yCn6Nrw2ksrHpfNsxYzdaC10ALcPjPWo/aBnrVvMNPrQeE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770261; c=relaxed/simple; bh=LCzJRNCDscXMDZdG4MBkfgsmjK6cIi+bcvdVqIpEXQM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KyW3g1QbW5/sCl1r85S/Cq5647Wdd2u+Lp1ZbjxRUrulErfoiEBdbfyZ6fSXVWMnUxYFQsg9LhgB76Cvi/V3XZ2vc/ZtQCJfZioHatqEcIhpM8Y3hkvbfltCAabs/YnHEnB31YF59+dBm6CvEG2ajePGCcAIb/uKpuQcyjmJOc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ILgsFy5q; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ILgsFy5q" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-ad545e74f60so659155166b.2 for ; Tue, 20 May 2025 12:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770258; x=1748375058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=svzZdYZrxSuRStx76VDt/bV5dnOlxDgL19Gcp9uOERE=; b=ILgsFy5q2eFfV6yNDX2/Gui/6BlzzkGI23rRnu1CVSGUYOIg7OKm7329gVlvCa8psr HB8gUaJtb8+lKFiTCKSavFBYxW5YC4QyQIufcNqrMdpqGQwQvnEM2nqGLDnaQnNLI/eg /Jd6aqvxmUtPjeOXK8TvLoSS0WESL9hPb1BIPep3MbJuu2Pqo2bN6FnDWzZdb/rtI6bt LYIqhqhwyUZDnXCdLFJ6txv+6+d61UcQrGRXlholP+IiNSfobdBLHlJp1TkHOoHOaz25 hFp8EUbb1LP+pEXihaTtdW1khAhFzLpvby8X8QtcrmZZInOiAHyF1umkEp7kRibRked3 X4dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770258; x=1748375058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=svzZdYZrxSuRStx76VDt/bV5dnOlxDgL19Gcp9uOERE=; b=Tgw4aiUpScdSle/xlp754GfY3eSRWtZ1KgS1EXib9TtGfACuHpxK40vdxHmSeDTYaN y8uayt10MLvoRoH5wyuAD72HcKJFiuFdyyuT4V/UpUzAqZSj8ZAjM9K/YkSWs/xAFJOm sjBTz7Ma7a+VR4grpblwRdKEuc5jn4J+9AQSpQUIShPUen5//Zh3Xj1vZmL31qQ2G8e7 uSFsmb+zCKLKsee2mHkyl8Ul5LdD6kHvGdcdsVpbqUz6LqdI6yp58YpQHKZJ1fE1VZ3N A0rWj/yEQrag4wIFN1t3xewhqg0hnNYVs9yKGz6ukqFXQlEn15kTmNLpKWQHtto39X0+ jTOg== X-Gm-Message-State: AOJu0YxYaKOPeBZ6LZurV8Qm7rcQ3tD3A7VrHBnD1FSsn60Us9vQ10Pp fiiETw7tOfwPqxutORayC/SCntqfKVZ4HxsfVI3Iiy9besGJQMoxcp5+hkaNpmOZ X-Gm-Gg: ASbGnct1DTIuCE7IEGmr983dab8N43UVmaYsgON3RNMaLPLHz4/5e/UQg7LKsz1UDgg F6QQWFNKLKz4QxDJGqLjIlVfk0Om/j9O+8LfZq/2gEePaH0+LKKsfPJg+Xa3p9N5NLGuKmetum3 QgGmT8888W9Y5tTim4Kmg/RFWlkJkdMlTeg1y9Xf6xlQsNFr0nvODaiAKOgEZzqGOXTvytOpTuZ y6G06WwtiX/SaTTcAALCQtuLqs1Xbb+J+4HmFh1gqq0jRaJVgRzTvtLvsEvJo5LrrpHnAdrnffG jrLLsBQ+3KB4ZHImrdTQuM+/lc3nSYv0GSn8SnhtTyV2LL2kVLuOypDqaweD5dEiFm0EUR238na 6GHY69g== X-Google-Smtp-Source: AGHT+IEvl23CjxFJrN0ar62w/0hD9Iattrhj3p0NYYTDSwCVAfoC1ovKunl442NR5N1g8VFgiZk6FQ== X-Received: by 2002:a17:907:1b20:b0:ace:c505:3349 with SMTP id a640c23a62f3a-ad52d42c0f0mr1775612766b.12.1747770257773; Tue, 20 May 2025 12:44:17 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:17 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 09/10] i2c: sis96x: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:43:59 +0200 Message-ID: <20250520194400.341079-10-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-sis96x.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/drivers/i2c/busses/i2c-sis96x.c b/drivers/i2c/busses/i2c-sis96x.c index 77529dda6fcd..eee41dc9d706 100644 --- a/drivers/i2c/busses/i2c-sis96x.c +++ b/drivers/i2c/busses/i2c-sis96x.c @@ -245,23 +245,19 @@ static int sis96x_probe(struct pci_dev *dev, u16 ww = 0; int retval; - if (sis96x_smbus_base) { - dev_err(&dev->dev, "Only one device supported.\n"); - return -EBUSY; - } + if (sis96x_smbus_base) + return dev_err_probe(&dev->dev, -EBUSY, "Only one device supported.\n"); pci_read_config_word(dev, PCI_CLASS_DEVICE, &ww); - if (PCI_CLASS_SERIAL_SMBUS != ww) { - dev_err(&dev->dev, "Unsupported device class 0x%04x!\n", ww); - return -ENODEV; - } + if (ww != PCI_CLASS_SERIAL_SMBUS) + return dev_err_probe(&dev->dev, -ENODEV, + "Unsupported device class 0x%04x!\n", ww); sis96x_smbus_base = pci_resource_start(dev, SIS96x_BAR); - if (!sis96x_smbus_base) { - dev_err(&dev->dev, "SiS96x SMBus base address " - "not initialized!\n"); - return -EINVAL; - } + if (!sis96x_smbus_base) + return dev_err_probe(&dev->dev, -EINVAL, + "SiS96x SMBus base address not initialized!\n"); + dev_info(&dev->dev, "SiS96x SMBus base address: 0x%04x\n", sis96x_smbus_base); @@ -272,9 +268,9 @@ static int sis96x_probe(struct pci_dev *dev, /* Everything is happy, let's grab the memory and set things up. */ if (!request_region(sis96x_smbus_base, SMB_IOSIZE, sis96x_driver.name)) { - dev_err(&dev->dev, "SMBus registers 0x%04x-0x%04x " - "already in use!\n", sis96x_smbus_base, - sis96x_smbus_base + SMB_IOSIZE - 1); + dev_err_probe(&dev->dev, -EINVAL, + "SMBus registers 0x%04x-0x%04x already in use!\n", + sis96x_smbus_base, sis96x_smbus_base + SMB_IOSIZE - 1); sis96x_smbus_base = 0; return -EINVAL; @@ -287,7 +283,7 @@ static int sis96x_probe(struct pci_dev *dev, "SiS96x SMBus adapter at 0x%04x", sis96x_smbus_base); if ((retval = i2c_add_adapter(&sis96x_adapter))) { - dev_err(&dev->dev, "Couldn't register adapter!\n"); + dev_err_probe(&dev->dev, retval, "Couldn't register adapter!\n"); release_region(sis96x_smbus_base, SMB_IOSIZE); sis96x_smbus_base = 0; } From patchwork Tue May 20 19:44:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 891389 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A719127FD4D for ; Tue, 20 May 2025 19:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770262; cv=none; b=J05IA3sVuwwt3YR7fq7Oy5kOY5tAH6Hi3NoXvMVP7G3uxDkkElTnDU31Dqz8x/vjMpspPkqAe1iWX6V57ztqusFWpfFmGfMNSGlYFhPoLrqomMwYrw0BJOqh03t68gKTNSO/AmhWyzrInn0LWKaBWGB4xWxuN1SEsozxF14FNug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747770262; c=relaxed/simple; bh=Grgt3ocdyh4uBFLmgAgJDVm/IgLTZaWHdaA1SrgKRhs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hS3anZEVyBdPT/COgpGhm+L0hHL8eFQ7D3oBA3RdE6Zuihm30Yv0l1U5vfLOYtFdXFG9dzXkdSin04OWGiPYfBt/w/5QzAW8mbmGTpJeyhCH6si89TL2p/RQ/CCTfLga62V7WwKC8KaJjH4BsDWeKqpVx3MwD84Io0SCZu/lLmg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BeNdN0Lk; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BeNdN0Lk" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ad1f6aa2f84so1167276166b.0 for ; Tue, 20 May 2025 12:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747770259; x=1748375059; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rFo9gcT/1a0eu/X6R2IYP4VmtBGqYLekUCk7wmzPX5c=; b=BeNdN0LksjZc8aN+d1ToJAlZpQzRfrYm7unWt2sNuDfQfPMLvrqaz9zdPBN/6nXeEC inRpkjdsBKZK+lK0sFMTw81KjEbRmI1x2Di/keDV5/Y04h39SGABs/7MRvSy2qqbktSy 636VQ9Cv2WYvGJd7CTkNGToA8qkcdIPmBk4UwqMxHopO4s58prX8GDkX01sRnvCgpOpO G1uhTk1hPQNOvgElmRrG9xfWSqf1uzXn1ftHBey4qfF/8fEpIEfVgb66xLGpNth6W0oA LJepVcxmLFTlxdM7U6ZN1Q4GDFUbdCaQCfsZaK+4Wh66selSkwSGUV9qf90KyLgymFcV OGnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747770259; x=1748375059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rFo9gcT/1a0eu/X6R2IYP4VmtBGqYLekUCk7wmzPX5c=; b=G3pXwgKgC1ZRumlMj80UX+g35n2PJfg7T5dsRnvbpE9zInsi+x+3FqCjqIff6peg/1 lbw/YwjAolAVr699XVDPnTRGIxnNPSNe5rSadrXEqDk0U9E5z0DHkeimZ+8uMyGKIPP/ xQbKl4FvL8H4djPecy7+r/C2sgOvIaFqlzjjWrxLzoP8shEcrR0zslfolFnzkDOlyJLf lWG+BfUeQ6wYMrGPODJlKffyVzfyNaYb6BefluqVwC6q/cICfUH4CeY0lE6Lc7U06IbN zv/KuuCm2t8KHjiI1wyxWm8bcp1d2wCQ+S8b21XH47PhthSGJJl8p3lVYVvgtgPAHHhW 5KXw== X-Gm-Message-State: AOJu0YxZ5ddlKCmvWVqG0RQDoUGhgST8O36ma6ZOFS3kxa7FikjH1VtO kFekR6nS/dHKpDr9pZsDaXh0ffotbXUlkUwE6h97flMzXJoMR+atnpLiRaADduQS X-Gm-Gg: ASbGncvzWSFBCNm7l5oC1EJu+3KBj6kR5Xyqf8lCx50u4rLf4k98v20JuLJeXt3+vOH +nMudAOtTdlUuCHvkQLpbeAHTcVF8TwfJ/3HHpq8zRsGdLszPxDZfAKox816tX+XdVxE3xYTbCc chBpQEA1BIW9URNMo5mPrzpI8o722PSKLvh518SbXPa36P7clT3CI91yU7v2Vio4wC1agXBYyFH 9z2Ho5M8OuFKMh3X1BLToPd4izcdaWtz4VW69OYaXbxyED5pUJuk1U6vcay+B1+565ZYzPtFW0L dPRRG8uxoYHNg4qYSKTfJRVeCqdQpqxpu5rRM2OSkY/wzhoFgDmksy9ofCE4CDh1NDu2NxalAGV +11PD5MW8PvPCPBnmmXmm7YMIB2U= X-Google-Smtp-Source: AGHT+IGM3AJt0lQukp+k6tAm8ksTBPXNtr8y+Pciyj0Im4/5zhQDbcxvypurNXm3+X4Ur4tItmg0rw== X-Received: by 2002:a17:907:60d2:b0:ad5:54ec:6b3c with SMTP id a640c23a62f3a-ad554ec711bmr1181982266b.27.1747770258870; Tue, 20 May 2025 12:44:18 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-11.cgn.sunrise.net. [194.230.145.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac33a98sm7736122a12.49.2025.05.20.12.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 12:44:18 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 10/10] i2c: sis630: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 20 May 2025 21:44:00 +0200 Message-ID: <20250520194400.341079-11-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com> References: <20250520194400.341079-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-sis630.c | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c index a19c3d251804..3d0638c2bc51 100644 --- a/drivers/i2c/busses/i2c-sis630.c +++ b/drivers/i2c/busses/i2c-sis630.c @@ -431,24 +431,23 @@ static int sis630_setup(struct pci_dev *sis630_dev) in acpi io space and read acpi base addr */ if (pci_read_config_byte(sis630_dev, SIS630_BIOS_CTL_REG, &b)) { - dev_err(&sis630_dev->dev, "Error: Can't read bios ctl reg\n"); - retval = -ENODEV; + retval = dev_err_probe(&sis630_dev->dev, -ENODEV, + "Error: Can't read bios ctl reg\n"); goto exit; } /* if ACPI already enabled , do nothing */ if (!(b & 0x80) && pci_write_config_byte(sis630_dev, SIS630_BIOS_CTL_REG, b | 0x80)) { - dev_err(&sis630_dev->dev, "Error: Can't enable ACPI\n"); - retval = -ENODEV; + retval = dev_err_probe(&sis630_dev->dev, -ENODEV, + "Error: Can't enable ACPI\n"); goto exit; } /* Determine the ACPI base address */ if (pci_read_config_word(sis630_dev, SIS630_ACPI_BASE_REG, &acpi_base)) { - dev_err(&sis630_dev->dev, - "Error: Can't determine ACPI base address\n"); - retval = -ENODEV; + retval = dev_err_probe(&sis630_dev->dev, -ENODEV, + "Error: Can't determine ACPI base address\n"); goto exit; } @@ -469,11 +468,10 @@ static int sis630_setup(struct pci_dev *sis630_dev) /* Everything is happy, let's grab the memory and set things up. */ if (!request_region(smbus_base + SMB_STS, SIS630_SMB_IOREGION, sis630_driver.name)) { - dev_err(&sis630_dev->dev, - "I/O Region 0x%04x-0x%04x for SMBus already in use.\n", - smbus_base + SMB_STS, - smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1); - retval = -EBUSY; + retval = dev_err_probe(&sis630_dev->dev, -EBUSY, + "I/O Region 0x%04x-0x%04x for SMBus already in use.\n", + smbus_base + SMB_STS, + smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1); goto exit; } @@ -511,12 +509,9 @@ static int sis630_probe(struct pci_dev *dev, const struct pci_device_id *id) { int ret; - if (sis630_setup(dev)) { - dev_err(&dev->dev, - "SIS630 compatible bus not detected, " - "module not inserted.\n"); - return -ENODEV; - } + if (sis630_setup(dev)) + return dev_err_probe(&dev->dev, -ENODEV, + "Compatible bus not detected, module not inserted.\n"); /* set up the sysfs linkage to our parent device */ sis630_adapter.dev.parent = &dev->dev;