From patchwork Thu May 15 07:53:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890902 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 792DF2798F4 for ; Thu, 15 May 2025 08:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296192; cv=none; b=qJRwND32y+I3zyhgHAU6ab10gvU4XvsMb3AOp3Amus2daVdlTLoc3eTRV0/EXEXvThWLOciD3lMr7862Rb04UuZkecAReaTjRaFCRLRZu5iJgGBR9k0rR9T/10UVfsMx8X087bCEsOrgQTNlgYTS7vy2MBGmEkkMBViNJibgDyE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296192; c=relaxed/simple; bh=of5W8eKVyNDMR3PDIDx3jc0OsUPgpBWDqyoq5bv6hd8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=ITNfcdr09xYYWkjm/zA3xXqvYSIbRUwYlfHaDB6yNArL8JZefwNjMFm6FvO94zgZ+GHP1OBxFPl0jKBMrCb8vdDgoboji02Tdacnuqe26pDX626OI6J41sJ/24cT+cP0PK0mssXyYQr5S9bbqv9xYnGRZxsRwAgAkH5qQe3MN2c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=pJ8cUNUk; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="pJ8cUNUk" Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250515080307epoutp0170073cd23f81bbcf5cb603282c4bde88~-pJ-xA1sY0912409124epoutp01c for ; Thu, 15 May 2025 08:03:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250515080307epoutp0170073cd23f81bbcf5cb603282c4bde88~-pJ-xA1sY0912409124epoutp01c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747296187; bh=Tkp0DQwXc1mOn4qy+xZBw8LmMOr1qvZhRe+FhWG/Q84=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pJ8cUNUkyQw+ylK+3ntdvOjXnn/bCBbSFaeNHcLeFapeV0B81MujwqvS/n/lR65jz FFl5/UQJZ4n40i/huhuGRT148O4g0hXBqUL//i7fz39GF/TYCuxlfC3Xk6c7sOfTZ0 c12ha3a7RjNNmGwxy/otGLNhNe5Vt5lfIopUGJOU= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPS id 20250515080306epcas2p481b6f11776427b56173731bd63fa4591~-pJ-a9u7B2562425624epcas2p4b; Thu, 15 May 2025 08:03:06 +0000 (GMT) Received: from epcas2p4.samsung.com (unknown [182.195.36.102]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4ZyjPk2H2sz6B9mP; Thu, 15 May 2025 08:03:06 +0000 (GMT) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPA id 20250515080305epcas2p4fa47dbfe9c4ece7c40eb04ea4c37c386~-pJ_OI3yE2143021430epcas2p40; Thu, 15 May 2025 08:03:05 +0000 (GMT) Received: from epsmgmc1p1new.samsung.com (unknown [182.195.42.40]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20250515080305epsmtrp2f76e6349f9cba96800c1fd2046b971a8~-pJ_NWHhQ0238402384epsmtrp2k; Thu, 15 May 2025 08:03:05 +0000 (GMT) X-AuditID: b6c32a28-edfbf24000001e8a-61-68259fb92c1e Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgmc1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 06.C6.07818.9BF95286; Thu, 15 May 2025 17:03:05 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250515080305epsmtip2160d2a09d0e53fdf3e15513c5ad463f6~-pJ9_fQdi1287712877epsmtip2V; Thu, 15 May 2025 08:03:05 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin Subject: [PATCH v3 1/5] watchdog: s3c2410_wdt: Replace hardcoded values with macro definitions Date: Thu, 15 May 2025 16:53:46 +0900 Message-Id: <20250515075350.3368635-2-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250515075350.3368635-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsWy7bCSvO7O+aoZBmc/KVo8mLeNzeL8+Q3s FpseX2O1uLxrDpvFjPP7mCxurNvHbvFk4RkmixmLT7JZPH75j9mB02PTqk42j5Vr1rB6bF5S 77HzewO7R9+WVYwenzfJBbBFcdmkpOZklqUW6dslcGXMejKTreAAe8XqlaeZGhgXsXUxcnJI CJhIXLxwnx3EFhLYzSjxfrt0FyMHUFxK4t0zS4gSYYn7LUdYuxi5gEo+MEpcWf2eESTBJqAj Mf3fbRYQW0QgTuJY+2ZmkCJmgZ2MEi3TfzODJISBEuvf7AYrYhFQlWh49h9sGa+ArcTum2vZ ITbIS8y89B3M5hSwk5h4cRcjxEG2Eof3PGGDqBeUODnzCdgcZqD65q2zmScwCsxCkpqFJLWA kWkVo2RqQXFuem6yYYFhXmq5XnFibnFpXrpecn7uJkZwwGtp7GB8961J/xAjEwfjIUYJDmYl Ed7rWcoZQrwpiZVVqUX58UWlOanFhxilOViUxHlXGkakCwmkJ5akZqemFqQWwWSZODilGpis iqe/zHr6tnOLrIuAHK/Gtc6/fHqyHUd1X6dddj5sFSH3pU/7j7flt/V2fvb/TGoCQzqvXOGT ex2+hv3xnd1tuewcRjN+9P7Ojuyx+Zez2uz0Ql6dlKvhohkvf88RWqTW2rtvn4HDfYWY5VES cclfJz7NmJO84PQ2z52Gq9a5bLC6YqxXtEPh5C+FdZOP3YpP33H+r/7bBZPsdq6///t1nZz3 n8CXEsknwy/b7Lz/i+XQJL77gnOmHuC/euvaXf4doccua0r4MN5ue+pYkTvX8HbGzxvz0jdP rY173qK6giHCVUrmYEOhwcLID6cvfnKrebCTkyNcfWLizRO6GQ5zn/aa1rrPqZ1UL3Ox6Plv JZbijERDLeai4kQAYiq1XOcCAAA= X-CMS-MailID: 20250515080305epcas2p4fa47dbfe9c4ece7c40eb04ea4c37c386 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250515080305epcas2p4fa47dbfe9c4ece7c40eb04ea4c37c386 References: <20250515075350.3368635-1-sw617.shin@samsung.com> Modify the code to utilize macro-defined values instead of hardcoded values. The value 0x100 in the s3c2410wdt_set_heartbeat function represents S3C2410_WTCON_PRESCALE_MAX + 1, but it is hardcoded, making its meaning difficult to understand and reducing code readability. Signed-off-by: Sangwook Shin --- drivers/watchdog/s3c2410_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index bdd81d8074b2..228f86d83663 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -555,7 +555,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, if (count >= 0x10000) { divisor = DIV_ROUND_UP(count, 0xffff); - if (divisor > 0x100) { + if (divisor > S3C2410_WTCON_PRESCALE_MAX + 1) { dev_err(wdt->dev, "timeout %d too big\n", timeout); return -EINVAL; } From patchwork Thu May 15 07:53:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890586 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C755284686 for ; Thu, 15 May 2025 08:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296193; cv=none; b=bTPzVJhldZJPr17xAxPYz+pOVgWp4M97Pntn/F3+rBYaBYbd6x4eEvmP8nxPh5GwYO9iBpZbvfgk0mem+4RMg6wx0kCh2sWvhW28lpjC+YAP26MOHpq3cDN3N8tgrVOH6xOQB+etVbCzIn7Z3afiLrLVJ0dlZf0pGaveQK6JJ/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296193; c=relaxed/simple; bh=1lEyv2C31kOucrORJbfvZ1JMD4KJHOoFDzImrxOR6ck=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=YhaR3Hp+XYrdcBvhupWtxm8U20zWjRd6vSIx7lL26lMUW09QpAZh2rT7TDf6/CEpyOp7kez2/IzfRYi6b3fLPeq2ZjGqJwTDcF/PoY5KJbkahKHVTp+lfT5tGblKDIWtxBjyaFam7cdYY8BFzM3DfGLfvmg83lwIpe7HDx+qp6M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=gakzh3y5; arc=none smtp.client-ip=203.254.224.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="gakzh3y5" Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20250515080309epoutp03468942a60d02dff8608a96d878a66765~-pKCMes6o0348103481epoutp03g for ; Thu, 15 May 2025 08:03:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20250515080309epoutp03468942a60d02dff8608a96d878a66765~-pKCMes6o0348103481epoutp03g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747296189; bh=kI99l7mtGn0iNk2KRSiHV06bFYTxVJP1UnDWIzaZPlk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gakzh3y5xGISBmh2amH1f6Pto/3sNmtZooOvr4RUsW0xcrp2Xf7gVPvxsu6yALsH8 0tOXaEGA3faxQDPMR0nzwW47xySRz3iMs/dEYtIMvI8QV0iZs4RyiQu+Ck07BytF7h J/Nkg0+SWQoeXHZPdtx94nynsBDli4nOLD+HNuks= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPS id 20250515080307epcas2p3fb15f30d7cfc984881505e4768f9aeba~-pKAWgJmN2780027800epcas2p3O; Thu, 15 May 2025 08:03:07 +0000 (GMT) Received: from epcas2p2.samsung.com (unknown [182.195.36.68]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4ZyjPl45wkz3hhTB; Thu, 15 May 2025 08:03:07 +0000 (GMT) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p2.samsung.com (KnoxPortal) with ESMTPA id 20250515080307epcas2p2898fb938ccf5c9a43d3f58098982dbdd~-pJ-h66rY1485714857epcas2p2O; Thu, 15 May 2025 08:03:07 +0000 (GMT) Received: from epsmgmcp1.samsung.com (unknown [182.195.42.82]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250515080307epsmtrp1049858c66d76c4b541895c4a7062b8f2~-pJ-hIC8h2250622506epsmtrp1-; Thu, 15 May 2025 08:03:07 +0000 (GMT) X-AuditID: b6c32a52-40bff70000004c16-fc-68259fba9856 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgmcp1.samsung.com (Symantec Messaging Gateway) with SMTP id 3C.77.19478.ABF95286; Thu, 15 May 2025 17:03:06 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250515080306epsmtip20d5991e9a7419b91a6608246d0dfef9d~-pJ-T4uaV1291312913epsmtip2v; Thu, 15 May 2025 08:03:06 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin Subject: [PATCH v3 2/5] watchdog: s3c2410_wdt: Fix max_timeout being calculated larger Date: Thu, 15 May 2025 16:53:47 +0900 Message-Id: <20250515075350.3368635-3-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250515075350.3368635-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsWy7bCSvO6u+aoZBt27rCwezNvGZnH+/AZ2 i02Pr7FaXN41h81ixvl9TBY31u1jt3iy8AyTxYzFJ9ksHr/8x+zA6bFpVSebx8o1a1g9Ni+p 99j5vYHdo2/LKkaPz5vkAtiiuGxSUnMyy1KL9O0SuDK27O9jL/jJWbH30l+2BsbNHF2MnBwS AiYS/fvfs3cxcnEICWxnlDg+4wtLFyMHUEJK4t0zS4gaYYn7LUdYIWo+MEqsONDICpJgE9CR mP7vNguILSIQJ3GsfTMzSBGzwE5GiZbpv5lBEsICYRK3Lq8As1kEVCWW7ZsM1sArYCux88FF dogN8hIzL30HszkF7CQmXtzFCGILAdUc3vOEDaJeUOLkzCdgvcxA9c1bZzNPYBSYhSQ1C0lq ASPTKkbR1ILi3PTc5AJDveLE3OLSvHS95PzcTYzgUNcK2sG4bP1fvUOMTByMhxglOJiVRHiv ZylnCPGmJFZWpRblxxeV5qQWH2KU5mBREudVzulMERJITyxJzU5NLUgtgskycXBKNTDNK62y DjtnEva3/WXNsnsbit6uSXE5I+zxKMJnfvWNsJLe/Q/C8uuEpbakbptbyL28yPq1zmn9qMgX AjcFrnzXaJdfeerdzqMM5Y9TX4bycSezqfQs8VeM4THyCdv9KdDrWcwvj8jZS1XibB/OzPdg yPx+asW6XQvE5P+sv1+zrbNA5+mZogYRQYHwd5f2LJ5fGi8Vodcy2fb+cplt6yo2ZbEu++ls ekaogKVdwn5vvG5LOueG6b2bCh49Xzf3TnfGqm3istfiQowO7NZjnhq/vkROMEC+6S7PDIUz m5Y+3Z0Ta9Z7xe3U5YcPPGRvOH4xiujxPez/qy74pnhLWH5H46Ka3bXR71d/P1Vs1K7EUpyR aKjFXFScCABlPnLY5AIAAA== X-CMS-MailID: 20250515080307epcas2p2898fb938ccf5c9a43d3f58098982dbdd X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250515080307epcas2p2898fb938ccf5c9a43d3f58098982dbdd References: <20250515075350.3368635-1-sw617.shin@samsung.com> Fix the issue of max_timeout being calculated larger than actual value. The calculation result of freq / (S3C2410_WTCON_PRESCALE_MAX + 1) / S3C2410_WTCON_MAXDIV is smaller than the actual value because the remainder is discarded during the calculation process. This leads to a larger calculated value for max_timeout compared to the actual settable value. A ceiling operation is applied in the calculation process to resolve this. Signed-off-by: Sangwook Shin --- drivers/watchdog/s3c2410_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 228f86d83663..c6166d927155 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -379,8 +379,8 @@ static inline unsigned int s3c2410wdt_max_timeout(struct s3c2410_wdt *wdt) { const unsigned long freq = s3c2410wdt_get_freq(wdt); - return S3C2410_WTCNT_MAXCNT / (freq / (S3C2410_WTCON_PRESCALE_MAX + 1) - / S3C2410_WTCON_MAXDIV); + return S3C2410_WTCNT_MAXCNT / DIV_ROUND_UP(freq, + (S3C2410_WTCON_PRESCALE_MAX + 1) * S3C2410_WTCON_MAXDIV); } static int s3c2410wdt_disable_wdt_reset(struct s3c2410_wdt *wdt, bool mask) From patchwork Thu May 15 07:53:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890901 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7940A283FD6 for ; Thu, 15 May 2025 08:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296193; cv=none; b=Fxswn6kVteLLSmsl9seFSQxGys6cFT27ScWXH89mmANT+nGdhHlx/ipFRpaX6zLesgUuVf+Pyg1VpsJF+fpsXxQlM8/D+wa6w95KUBvMvgpsC9KBxTZZAzZItYdcEfcwpsdTSgDYteY56CIQ0RxzSaqwsJdhqC3WwoRhxopeQwc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296193; c=relaxed/simple; bh=k/EN1xunh0Y89PyU6CdcCeFSTvK/TGqlV9c+DhCqBeU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=hWkmGoz9aAW7EZHjK/P3eHpeVwRVF7Idpz66OxP0gSRIrjGn4PCCAsKq39nAG0pK7agEZDwaaA9V6+AVSzohpGK/jRX4QBDu78Mw+ZJ7KkLpfJsETnVnqmou7dURgPytDJD25cypY5FUz6ZTpKLbGIWlRGAuGNlezIpJ6s9jPeQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=d6TDFNKk; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="d6TDFNKk" Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250515080309epoutp0176a1c558146e47f8f0435bc7f0ca8acd~-pKB-WmSy0978009780epoutp01V for ; Thu, 15 May 2025 08:03:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250515080309epoutp0176a1c558146e47f8f0435bc7f0ca8acd~-pKB-WmSy0978009780epoutp01V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747296189; bh=glGyEXi0QZpDgdf+QBJO5sMYl1AOPW1Yz+35AUaf0fQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d6TDFNKkUgpr2sAhv5OUZU7v6kcn61D0DMOal1wEyQlS5Kjn3JpSA0qVW8cPMEWwk XdFkLtebmE6ROuLalqadvpq+5+9yJs3N97BduRVDt0szFm71KAkZHGL2VUgyfS2575 VoFx7MXD5/PLvv1WcaC4a3Ee/N/4BTiY0erQ8KgI= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPS id 20250515080309epcas2p330e7b7168e831d899750bc2174a7c844~-pKBjVzxT0239902399epcas2p3s; Thu, 15 May 2025 08:03:09 +0000 (GMT) Received: from epcas2p2.samsung.com (unknown [182.195.36.68]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4ZyjPm68NVz3hhTN; Thu, 15 May 2025 08:03:08 +0000 (GMT) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p2.samsung.com (KnoxPortal) with ESMTPA id 20250515080308epcas2p23dcfda26ccbb9376d400af0017b55247~-pKAuG6Hd1485714857epcas2p2T; Thu, 15 May 2025 08:03:08 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250515080308epsmtrp1083deebc5acfa82e7517bde59f074a57~-pKAoSJ3O2250622506epsmtrp1B; Thu, 15 May 2025 08:03:08 +0000 (GMT) X-AuditID: b6c32a2a-d63ff70000002265-81-68259fbcd430 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 8E.86.08805.CBF95286; Thu, 15 May 2025 17:03:08 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250515080308epsmtip2135cebdbb929a513a5543301eec0c26c~-pKAcXscJ1287212872epsmtip2n; Thu, 15 May 2025 08:03:08 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin Subject: [PATCH v3 3/5] watchdog: s3c2410_wdt: Increase max timeout value of watchdog Date: Thu, 15 May 2025 16:53:48 +0900 Message-Id: <20250515075350.3368635-4-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250515075350.3368635-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsWy7bCSvO6e+aoZBj+nclg8mLeNzeL8+Q3s FpseX2O1uLxrDpvFjPP7mCxurNvHbvFk4RkmixmLT7JZPH75j9mB02PTqk42j5Vr1rB6bF5S 77HzewO7R9+WVYwenzfJBbBFcdmkpOZklqUW6dslcGUcmb6AtWClSsWLnu9MDYyL5boYOTkk BEwkLi9Zx9TFyMUhJLCbUWLij/vMXYwcQAkpiXfPLCFqhCXutxxhhaj5wChx9vUeFpAEm4CO xPR/t8FsEYE4iWPtm5lBipgFdjJKtEz/zQySEBYIlWh48RCsiEVAVeLWyu+sIDavgK3E5nXH WSE2yEvMvPSdHcTmFLCTmHhxFyOILQRUc3jPEzaIekGJkzOfgM1hBqpv3jqbeQKjwCwkqVlI UgsYmVYxSqYWFOem5xYbFhjlpZbrFSfmFpfmpesl5+duYgSHvJbWDsY9qz7oHWJk4mA8xCjB wawkwns9SzlDiDclsbIqtSg/vqg0J7X4EKM0B4uSOO+3170pQgLpiSWp2ampBalFMFkmDk6p BqaVip3lLM8M2JayVry5rCazj9+347WyjOaURat0vLbyTefUqlU2f193Je3eY8eQb+66BTM7 tnQJpimtEDSp7isOVEjkqbEKOCejkdS3g9mIuTEpOPh/eJiZgtQWrbq9ZfJOC3qqDzSw5b9O 2JZ71NQ0ctaf7y9WrYsNL5crDCkIztNvvWt801RQ5vq5Ir+Z9Qd5lNRqmz3X8xy5+3B7fN7v xRpt/1aenXRH/cXf7pkq026fUvX9n7Kc7/73X14b3shJ/3ZiP6bwKHb6rwnS7XPfhM3JqGKY +8Ow4Jr/yfJZ7mZbmg1DfLsExYWz2EwmJCno/0le1mZ6vLy0MvWxypyPT4J1Z7zk2XVqgqel EktxRqKhFnNRcSIAUUvpr+gCAAA= X-CMS-MailID: 20250515080308epcas2p23dcfda26ccbb9376d400af0017b55247 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250515080308epcas2p23dcfda26ccbb9376d400af0017b55247 References: <20250515075350.3368635-1-sw617.shin@samsung.com> Increase max_timeout value from 55s to 3664647s (1017h 57min 27s) with 38400000 frequency system if the system has 32-bit WTCNT register. cat /sys/devices/platform/10060000.watchdog_cl0/watchdog/watchdog0/max_timeout 3664647 [ 0.302473] s3c2410-wdt 10060000.watchdog_cl0: Heartbeat: count=1099394100000, timeout=3664647, freq=300000 [ 0.302479] s3c2410-wdt 10060000.watchdog_cl0: Heartbeat: timeout=3664647, divisor=256, count=1099394100000 (fff8feac) [ 0.302510] s3c2410-wdt 10060000.watchdog_cl0: starting watchdog timer [ 0.302722] s3c2410-wdt 10060000.watchdog_cl0: watchdog active, reset enabled, irq disabled If system has 32-bit WTCNT, add QUIRK_HAS_32BIT_MAXCNT to its quirk flags, then it will operation with 32-bit counter. If not, with 16-bit counter like previous. Signed-off-by: Sangwook Shin --- drivers/watchdog/s3c2410_wdt.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index c6166d927155..1c7299deec5d 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -34,6 +34,7 @@ #define S3C2410_WTCLRINT 0x0c #define S3C2410_WTCNT_MAXCNT 0xffff +#define S3C2410_WTCNT_MAXCNT_32 0xffffffff #define S3C2410_WTCON_RSTEN BIT(0) #define S3C2410_WTCON_INTEN BIT(2) @@ -119,6 +120,10 @@ * %QUIRK_HAS_DBGACK_BIT: WTCON register has DBGACK_MASK bit. Setting the * DBGACK_MASK bit disables the watchdog outputs when the SoC is in debug mode. * Debug mode is determined by the DBGACK CPU signal. + * + * %QUIRK_HAS_32BIT_MAXCNT: WTDAT and WTCNT are 32-bit registers. With these + * 32-bit registers, larger values to be set, which means that larger timeouts + * value can be set. */ #define QUIRK_HAS_WTCLRINT_REG BIT(0) #define QUIRK_HAS_PMU_MASK_RESET BIT(1) @@ -126,6 +131,7 @@ #define QUIRK_HAS_PMU_AUTO_DISABLE BIT(3) #define QUIRK_HAS_PMU_CNT_EN BIT(4) #define QUIRK_HAS_DBGACK_BIT BIT(5) +#define QUIRK_HAS_32BIT_MAXCNT BIT(6) /* These quirks require that we have a PMU register map */ #define QUIRKS_HAVE_PMUREG \ @@ -194,6 +200,7 @@ struct s3c2410_wdt { struct notifier_block freq_transition; const struct s3c2410_wdt_variant *drv_data; struct regmap *pmureg; + unsigned int max_cnt; }; static const struct s3c2410_wdt_variant drv_data_s3c2410 = { @@ -379,7 +386,7 @@ static inline unsigned int s3c2410wdt_max_timeout(struct s3c2410_wdt *wdt) { const unsigned long freq = s3c2410wdt_get_freq(wdt); - return S3C2410_WTCNT_MAXCNT / DIV_ROUND_UP(freq, + return wdt->max_cnt / DIV_ROUND_UP(freq, (S3C2410_WTCON_PRESCALE_MAX + 1) * S3C2410_WTCON_MAXDIV); } @@ -534,7 +541,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, { struct s3c2410_wdt *wdt = watchdog_get_drvdata(wdd); unsigned long freq = s3c2410wdt_get_freq(wdt); - unsigned int count; + unsigned long count; unsigned int divisor = 1; unsigned long wtcon; @@ -544,7 +551,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, freq = DIV_ROUND_UP(freq, 128); count = timeout * freq; - dev_dbg(wdt->dev, "Heartbeat: count=%d, timeout=%d, freq=%lu\n", + dev_dbg(wdt->dev, "Heartbeat: count=%lu, timeout=%d, freq=%lu\n", count, timeout, freq); /* if the count is bigger than the watchdog register, @@ -552,8 +559,8 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, actually make this value */ - if (count >= 0x10000) { - divisor = DIV_ROUND_UP(count, 0xffff); + if (count > wdt->max_cnt) { + divisor = DIV_ROUND_UP(count, wdt->max_cnt); if (divisor > S3C2410_WTCON_PRESCALE_MAX + 1) { dev_err(wdt->dev, "timeout %d too big\n", timeout); @@ -561,7 +568,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, } } - dev_dbg(wdt->dev, "Heartbeat: timeout=%d, divisor=%d, count=%d (%08x)\n", + dev_dbg(wdt->dev, "Heartbeat: timeout=%d, divisor=%d, count=%lu (%08lx)\n", timeout, divisor, count, DIV_ROUND_UP(count, divisor)); count = DIV_ROUND_UP(count, divisor); @@ -764,6 +771,10 @@ static int s3c2410wdt_probe(struct platform_device *pdev) if (IS_ERR(wdt->src_clk)) return dev_err_probe(dev, PTR_ERR(wdt->src_clk), "failed to get source clock\n"); + wdt->max_cnt = S3C2410_WTCNT_MAXCNT; + if ((wdt->drv_data->quirks & QUIRK_HAS_32BIT_MAXCNT)) + wdt->max_cnt = S3C2410_WTCNT_MAXCNT_32; + wdt->wdt_device.min_timeout = 1; wdt->wdt_device.max_timeout = s3c2410wdt_max_timeout(wdt); From patchwork Thu May 15 07:53:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890585 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F0092868B5 for ; Thu, 15 May 2025 08:03:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296195; cv=none; b=FJrhx5WPFxRsxwfeROO8pED4eNCjYTyjogeKa5ljt/G2/lt1tSRMPwCmsOuVqcLjdf8JyN9iKEjNm85o+T2MtANi5g+q1ZYQ3lXnJFNAYwX2v4qDGY18rZwNfBmwrTRHshBoB2o5wZVJUBSZsLvFzawYxiowcxY2Aq/ddUCYA9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296195; c=relaxed/simple; bh=JgzSBwGJSPNR5u2mFY4Uyiofeb5W9+zY06IMUVvh9VA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=fcUdEflmZsTdbWVWEBodKdYQRyOFPcEtJz6r4FKoKsd+JW5MBE18CsS7Un+fYL0TsKXoA+SmER7B5AO3/kNSBUKSUPHFsNcOZb72543/brPQqdRDV77Qqx81G+JEnbAKonAJgLwOq8US5OV2jfQuM0I+9IHOH0loJzVg1FT439U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=ktdKdi3I; arc=none smtp.client-ip=203.254.224.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="ktdKdi3I" Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20250515080311epoutp039c8e8b06f0beb70d71af88b5bd30816e~-pKDUAd6_0669206692epoutp03S for ; Thu, 15 May 2025 08:03:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20250515080311epoutp039c8e8b06f0beb70d71af88b5bd30816e~-pKDUAd6_0669206692epoutp03S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747296191; bh=l1sBe+or20ljTm54YnvzZcJO7su90SPJqDKMD7hCrSM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ktdKdi3IFF8vT/w9c4KJnN3SVzLRBJUY7l5uvmhq12xOlGPl37MP/l6Ik3CRhe2tg h+j8RdfL4vP4AGyoOLSICwD0ZUSRSrjXAliQvDbrWwxCwWDyVoy3dezVcyi6f61CYz 4rKc5BlPVaWj5lzOB/p0gi4vxeDgcYgNfBy29Qh4= Received: from epsnrtp04.localdomain (unknown [182.195.42.156]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPS id 20250515080310epcas2p35f99437ebc36178361227b8bcf938ae0~-pKC4mdky2780027800epcas2p3W; Thu, 15 May 2025 08:03:10 +0000 (GMT) Received: from epcas2p1.samsung.com (unknown [182.195.36.101]) by epsnrtp04.localdomain (Postfix) with ESMTP id 4ZyjPp1HwNz6B9mK; Thu, 15 May 2025 08:03:10 +0000 (GMT) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPA id 20250515080309epcas2p47d07f73de08c7c14b2a60a8d15423954~-pKByYSlY2279222792epcas2p4u; Thu, 15 May 2025 08:03:09 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20250515080309epsmtrp2082993217c24a68f158fb7dae594dd53~-pKBwKT-I0272802728epsmtrp23; Thu, 15 May 2025 08:03:09 +0000 (GMT) X-AuditID: b6c32a29-566fe7000000223e-c6-68259fbdfec8 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id CB.1E.08766.DBF95286; Thu, 15 May 2025 17:03:09 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250515080309epsmtip2b17d44959dfb46140b6393a8d4c5c14e~-pKBfaH241291312913epsmtip2z; Thu, 15 May 2025 08:03:09 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin Subject: [PATCH v3 4/5] watchdog: s3c2410_wdt: exynosautov920: Enable QUIRK_HAS_32BIT_MAXCNT Date: Thu, 15 May 2025 16:53:49 +0900 Message-Id: <20250515075350.3368635-5-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250515075350.3368635-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsWy7bCSvO7e+aoZBi1zhSwezNvGZnH+/AZ2 i02Pr7FaXN41h81ixvl9TBY31u1jt3iy8AyTxYzFJ9ksHr/8x+zA6bFpVSebx8o1a1g9Ni+p 99j5vYHdo2/LKkaPz5vkAtiiuGxSUnMyy1KL9O0SuDIm9W9mKjjEWdE79xJ7A2MLRxcjJ4eE gInEw6PfWLsYuTiEBHYzSsz9uom5i5EDKCEl8e6ZJUSNsMT9liNQNR8YJfbNPsQEkmAT0JGY /u82C4gtIhAncax9MzNIEbPATkaJlum/wQYJC8RI9DalgtSwCKhKLPk1jxHE5hWwldi1axcb xAJ5iZmXvrOD2JwCdhITL+4CqxECqjm85wkbRL2gxMmZT8B2MQPVN2+dzTyBUWAWktQsJKkF jEyrGCVTC4pz03OLDQsM81LL9YoTc4tL89L1kvNzNzGCA15Lcwfj9lUf9A4xMnEwHmKU4GBW EuG9nqWcIcSbklhZlVqUH19UmpNafIhRmoNFSZxX/EVvipBAemJJanZqakFqEUyWiYNTqoGp c/WlP6XuiVH7zshls7QuT9pSlSVaXjhl9teO0z9/vp9lfDpZQ4ddVt3INZ3pVWLEIaFXf1Rk ZuTlGF7ecK0gzOvylc+dlYt+mvY3L1D/zcgdnsf/2mRF9zxe/ZdbHkc47Tl0R/hFVUPDnU/b faWa0youN86eKcbe8va10NarSizC6f7zDujqb7Rfwqe6NDV7YdYcv79cv14t3NP981GGRPLN qNdhpvd5G04v2hNZ0RzMvSrjmcnWvZvN7Squibg6tBzUurl3w8TjzkJWAbx3IzkK/hwKfDLd /du99x6ZEpINGWWZrDJqrH7fDvzK1rAtaV3/NXMSyxQbb6fPPIFRB7PvJJs1TLz65xcrn7US S3FGoqEWc1FxIgCXHLHP5wIAAA== X-CMS-MailID: 20250515080309epcas2p47d07f73de08c7c14b2a60a8d15423954 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250515080309epcas2p47d07f73de08c7c14b2a60a8d15423954 References: <20250515075350.3368635-1-sw617.shin@samsung.com> Enable QUIRK_HAS_32BIT_MAXCNT to ExynosAutov920 SoC which has 32-bit WTCNT. Signed-off-by: Sangwook Shin --- drivers/watchdog/s3c2410_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 1c7299deec5d..3c12a3ae50f8 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -326,7 +326,7 @@ static const struct s3c2410_wdt_variant drv_data_exynosautov920_cl0 = { .cnt_en_bit = 8, .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET | QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN | - QUIRK_HAS_DBGACK_BIT, + QUIRK_HAS_DBGACK_BIT | QUIRK_HAS_32BIT_MAXCNT, }; static const struct s3c2410_wdt_variant drv_data_exynosautov920_cl1 = { @@ -339,7 +339,7 @@ static const struct s3c2410_wdt_variant drv_data_exynosautov920_cl1 = { .cnt_en_bit = 8, .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET | QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN | - QUIRK_HAS_DBGACK_BIT, + QUIRK_HAS_DBGACK_BIT | QUIRK_HAS_32BIT_MAXCNT, }; static const struct of_device_id s3c2410_wdt_match[] = { From patchwork Thu May 15 07:53:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890900 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3FBC2882A5 for ; Thu, 15 May 2025 08:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296195; cv=none; b=SNvP+/HW/tI/L6tHvGBmX+VIK2MVH/5WNkT7T3VeJ2r2Zp+ZGnC45qg9Z5zFbs2TrDFkb6amR+rfZUtU3K2AhS9Py1umgqfOEWDzMuqbz/jo3qb7G4qaMxcP6LPzM+22ZYzr4F/kPcONcZr7OP2Qr92ug2ao8kNz/IkeaqJ8oe0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747296195; c=relaxed/simple; bh=EyGor6XVIMq7J+WDI1N7ciU1xsKQCdfgZtKjtEldfQg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=gY5GYZikdx4rKPhUR9pHSy/6redcTEsTan7zcWcL29qgEqd8TNGyeMV4Nq44AY7rpiAXBVOJrIU7kx3Sm1Muox8iNkTHhYzQWfxqgAVCavuki5keKQpSAVoi/utZ12l9wMxbU2MeS+fNsn/OBsIL4Xc3Bu2E5f+u9/80ZkzFLrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=pmYFseS5; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="pmYFseS5" Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250515080311epoutp0198ce60ac95036e6afac2e82688c88c0f~-pKD_SlKv0978009780epoutp01Z for ; Thu, 15 May 2025 08:03:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250515080311epoutp0198ce60ac95036e6afac2e82688c88c0f~-pKD_SlKv0978009780epoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747296191; bh=6E+pV7n6F1eiQsjNgSMeovGhdczmhV6c5wMuEuVtyBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pmYFseS5N4H5pnvdK01BIqDgEPdkLbvewVptfUh5Fm17MgtQKW60Djm8m2yMvEQH3 mHwLJ1AzgqUoIGf7KbfJBEDb1hg3LGGwujszqKPyHBZRsPb0FFl4BYIpuqn76ISwkl 0UDXurBYrUF+AgSjqWCBnhjX0NVlyQNoDmAg/i/k= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPS id 20250515080311epcas2p37c9372ba816747ad9656a31ce32f9b3f~-pKDlpvx90512805128epcas2p3N; Thu, 15 May 2025 08:03:11 +0000 (GMT) Received: from epcas2p3.samsung.com (unknown [182.195.36.102]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4ZyjPq0RPgz6B9mS; Thu, 15 May 2025 08:03:11 +0000 (GMT) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPA id 20250515080310epcas2p3e045327d03d031d38614464e881957d1~-pKCtzKMG0512805128epcas2p3J; Thu, 15 May 2025 08:03:10 +0000 (GMT) Received: from epsmgmcp1.samsung.com (unknown [182.195.42.82]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20250515080310epsmtrp251f35ed8e6bc7e92010376c57bc1c705~-pKCsNObh0272802728epsmtrp29; Thu, 15 May 2025 08:03:10 +0000 (GMT) X-AuditID: b6c32a52-40bff70000004c16-08-68259fbe1191 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgmcp1.samsung.com (Symantec Messaging Gateway) with SMTP id FD.77.19478.EBF95286; Thu, 15 May 2025 17:03:10 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250515080310epsmtip2d6c9b47d2e65d4be8635ae76e0ab739b~-pKCeOpfZ1291412914epsmtip23; Thu, 15 May 2025 08:03:10 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin Subject: [PATCH v3 5/5] watchdog: s3c2410_wdt: exynosautov9: Enable supported features Date: Thu, 15 May 2025 16:53:50 +0900 Message-Id: <20250515075350.3368635-6-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250515075350.3368635-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsWy7bCSvO6++aoZBscvCVk8mLeNzeL8+Q3s FpseX2O1uLxrDpvFjPP7mCxurNvHbvFk4RkmixmLT7JZPH75j9mB02PTqk42j5Vr1rB6bF5S 77HzewO7R9+WVYwenzfJBbBFcdmkpOZklqUW6dslcGVMfTObpeA9V8Xe263MDYwLOLsYOTkk BEwkmt9sZ+xi5OIQEtjOKLFp8R32LkYOoISUxLtnlhA1whL3W46wQtR8YJT41PWfESTBJqAj Mf3fbRYQW0QgTuJY+2ZmkCJmgZ2MEi3TfzODJIQFwiRevP/LBGKzCKhK/Nl0gBlkAa+ArcSy WXUQC+QlZl76zg5icwrYSUy8uAtsvhBQyeE9T9hAbF4BQYmTM5+A7WIGqm/eOpt5AqPALCSp WUhSCxiZVjGKphYU56bnJhcY6hUn5haX5qXrJefnbmIEB7pW0A7GZev/6h1iZOJgPMQowcGs JMJ7PUs5Q4g3JbGyKrUoP76oNCe1+BCjNAeLkjivck5nipBAemJJanZqakFqEUyWiYNTqoFp cX9q4vrq1qslwjMnr5nH0f+S92yvjdIK8yb2AwdEn6zOvcffNKWi7mi18LsnLcdCY16nB93m q+TeqrrQPYNtpeUkG2bhjaxBLq8vaH9ZUn8j2u3dLPa1f1mEQ/RsFyjMmTzrz+Krtz5s8Fq+ Sv2nbeWeekO1Ei13TYPO2gOCmtfeGG5nsPv/MdiAU9JelkVk4k2e0xnNV2eHJvbeSeR8ev38 lnMfQn7t/s7ZZvWYlzOzytSaN3PN/HX77H9xhsiovp+tv9f6eJOZVWYA06z4Z2t4p2esvFav t9Kw8KDW7UUuxreWqRzoFnnc48RyueNzweYLf8t4p6lsfBE06Yip8Ob911oi5pw5fzzvGPde JZbijERDLeai4kQAlpDYcuMCAAA= X-CMS-MailID: 20250515080310epcas2p3e045327d03d031d38614464e881957d1 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250515080310epcas2p3e045327d03d031d38614464e881957d1 References: <20250515075350.3368635-1-sw617.shin@samsung.com> Enable supported features for ExynosAutov9 SoC. - QUIRK_HAS_DBGACK_BIT - QUIRK_HAS_32BIT_MAXCNT Signed-off-by: Sangwook Shin --- drivers/watchdog/s3c2410_wdt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 3c12a3ae50f8..bbc1d9916f67 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -275,7 +275,8 @@ static const struct s3c2410_wdt_variant drv_data_exynosautov9_cl0 = { .cnt_en_reg = EXYNOS850_CLUSTER0_NONCPU_OUT, .cnt_en_bit = 7, .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET | - QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN, + QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN | + QUIRK_HAS_DBGACK_BIT | QUIRK_HAS_32BIT_MAXCNT, }; static const struct s3c2410_wdt_variant drv_data_exynosautov9_cl1 = { @@ -287,7 +288,8 @@ static const struct s3c2410_wdt_variant drv_data_exynosautov9_cl1 = { .cnt_en_reg = EXYNOSAUTOV9_CLUSTER1_NONCPU_OUT, .cnt_en_bit = 7, .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET | - QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN, + QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN | + QUIRK_HAS_DBGACK_BIT | QUIRK_HAS_32BIT_MAXCNT, }; static const struct s3c2410_wdt_variant drv_data_gs101_cl0 = {