From patchwork Wed May 14 09:42:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890588 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CB4925DAE1 for ; Wed, 14 May 2025 09:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216428; cv=none; b=laQXbaQ26z7GYGqrm8NhhNtOkZ3Qj4um+kbCWQV248seP3ELf99VL2q3EdGA/c0ABiHK77nVLq5DHWmLkAcgwx+uh1krEY15/JFiat9hXYvdb1LmFFTSukTxXX9hoa1hIRMrbQ12Enw3a19S0liPU5z/g2c+gLqcnux+SPmVfM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216428; c=relaxed/simple; bh=IyXTrHkH71Jaj6qRL7zMPPW/Tqq1aNW/n4YHk6qZxmc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=LGy1D1DKSXGdBYFz2lqa7BvmyW09hvNWL2z3bQ5THXksTHJLv22mdJpeQpGgaxcnAPOAlwTRR1VRe1fjpsWpBukJQSgcEUe6L4nbjRJAZImNQXts10EtZyF6XIHY6yBt0V3z8zyljYLT+3XdtH0/0Rz3QZpU/5MnVJ2uduvCjvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=VX06KiTs; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="VX06KiTs" Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250514095337epoutp0139ef54b2c2ff8e21a3392d81bfe0f53a~-XBMMnSjc1870918709epoutp01N for ; Wed, 14 May 2025 09:53:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250514095337epoutp0139ef54b2c2ff8e21a3392d81bfe0f53a~-XBMMnSjc1870918709epoutp01N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747216417; bh=JVyto71w61vrp7yw23DVq8t5lbwhvGzxNZd2g0nOgRU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VX06KiTs8bC5wpUDjqhVIG7sLoo03yCicEfpzWr5lqnDW2wUhBZa26DHDT0b4aASo 3rrXLyjCjqyQfzK9uMFvIuAl/wrza0heSAJswBlVy4IIIUl8ZguMAM59LLQIA9iJ0a O+eIXtn747YPbylQ+/Q+uDa2YqciFGUK4u6WfhWE= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPS id 20250514095336epcas2p4f5bbf7c6386516c792c82a0073c306e9~-XBLuGcfg0187001870epcas2p4Q; Wed, 14 May 2025 09:53:36 +0000 (GMT) Received: from epcas2p4.samsung.com (unknown [182.195.36.97]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4Zy7vh1ZMsz3hhT7; Wed, 14 May 2025 09:53:36 +0000 (GMT) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPA id 20250514095335epcas2p139710b146aaf4709a0a7aafcabe2f7c7~-XBKib47P3022730227epcas2p1I; Wed, 14 May 2025 09:53:35 +0000 (GMT) Received: from epsmgmcp1.samsung.com (unknown [182.195.42.82]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250514095335epsmtrp14926ba4f054b27b3fb411a1af425d0b4~-XBKetToL1996119961epsmtrp1P; Wed, 14 May 2025 09:53:35 +0000 (GMT) X-AuditID: b6c32a52-41dfa70000004c16-ce-6824681f3306 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgmcp1.samsung.com (Symantec Messaging Gateway) with SMTP id 68.55.19478.F1864286; Wed, 14 May 2025 18:53:35 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250514095335epsmtip18ba7a072d9f13ba0d6fb49eff0a3815c~-XBKNbQAH0078100781epsmtip1z; Wed, 14 May 2025 09:53:35 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin , Kyunghwan Seo Subject: [PATCH v2 1/5] watchdog: s3c2410_wdt: Replace hardcoded values with macro definitions Date: Wed, 14 May 2025 18:42:16 +0900 Message-Id: <20250514094220.1561378-2-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250514094220.1561378-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsWy7bCSnK58hkqGwd9LIhYP5m1js5jffonR 4vz5DewWmx5fY7W4vGsOm8WM8/uYLG6s28du8WThGSaLGYtPslk8fvmP2YHLY9OqTjaPlWvW sHpsXlLvsfN7A7tH35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZXQsbmEt+MZecfrmDsYGxsts XYycHBICJhJPLn9nB7GFBLYzSnw55dXFyAEUl5J498wSokRY4n7LEdYuRi6gkg+MEkdO/wDr ZRPQkZj+7zYLiC0iECdxrH0zM0gRs8AjRokr83qYQBLCQInpd44wg9gsAqoSW44tAmvmFbCV uLl6HgvEBnmJmZcgjuAUsJOY29LKBnKEEFBN03YPiHJBiZMzn4CVMwOVN2+dzTyBUWAWktQs JKkFjEyrGEVTC4pz03OTCwz1ihNzi0vz0vWS83M3MYIDXitoB+Oy9X/1DjEycTAeYpTgYFYS 4b2epZwhxJuSWFmVWpQfX1Sak1p8iFGag0VJnFc5pzNFSCA9sSQ1OzW1ILUIJsvEwSnVwCR0 33/vFJ7HE/wVzpqW8t0zKIv24056ru+1MHfvJ48HmxP4C67t6D/8SDzleUbVFcaWUIv3t89t nJYXc9K22ND+2tLrEw9UvPWK/75lzaTbx7qX/MxavlC2olXN72jTyu7d1/YmeAq/PXYg6+7Z +OfnXZaoTW/nbZzNIqBkqr/6glXubVnzwtlBy0WYffbN9alaMyMv6o+k4FqBaWnvgs+48/Wb ZCw0ODgrV+P0doUjm66smalhnhn7uTBE6g57S0L8qxctAuqL/KPmHGNcaLHLVMi/ZWpaiOeF r8XG5juiJjcf47Svupay1HxOY/oN1d5jv+4++5z9TaX05IKezNSrOwPU5u2cbMc0eWlh/Dcl luKMREMt5qLiRAC9p4jL5wIAAA== X-CMS-MailID: 20250514095335epcas2p139710b146aaf4709a0a7aafcabe2f7c7 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250514095335epcas2p139710b146aaf4709a0a7aafcabe2f7c7 References: <20250514094220.1561378-1-sw617.shin@samsung.com> Modify the code to utilize macro-defined values instead of hardcoded values. The value 0x100 in the s3c2410wdt_set_heartbeat function represents S3C2410_WTCON_PRESCALE_MAX + 1, but it is hardcoded, making its meaning difficult to understand and reducing code readability. Signed-off-by: Sangwook Shin Signed-off-by: Kyunghwan Seo --- drivers/watchdog/s3c2410_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index bdd81d8074b2..228f86d83663 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -555,7 +555,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, if (count >= 0x10000) { divisor = DIV_ROUND_UP(count, 0xffff); - if (divisor > 0x100) { + if (divisor > S3C2410_WTCON_PRESCALE_MAX + 1) { dev_err(wdt->dev, "timeout %d too big\n", timeout); return -EINVAL; } From patchwork Wed May 14 09:42:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890590 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED1D25DAF4 for ; Wed, 14 May 2025 09:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216425; cv=none; b=k/x301WhiFfwYfznOpo98AW79bfqUJlcmbgQiGQjztpXS5K5shE95EakYjAbfDdNECl49ckIu8kvWkKlFczAl7V99yByFtgFQB1coqY453OklWkqqVGZSjkh/uh7xCl1OgyfVr1AkX//10GZO3ahdIpDgBFoe1Np8KZaVAYmoeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216425; c=relaxed/simple; bh=atyitCEKPo/sR39ot1ypGJArFGKNO7YqMSWVEsH4orc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=WrkZly6gNDOA5GCivthS1hjVCoLbTKBwmfoVM1mza1Fs6XNraED7Qu5WyXLVFdqcX4YX3I7gVef0epTtD8aKXIxZ9Bj/J7Kuw3stW8j8+nH5rw0Wt0Dy7O0+lhJp0lpGAUNNiyds2kGJJH7DRD4eGmTFyKnfwuxSY6p3dM/aE44= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=qLKYGqoN; arc=none smtp.client-ip=203.254.224.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="qLKYGqoN" Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20250514095340epoutp021edbb730db5e5e979124f136a6ac3590~-XBPP2nUm2558825588epoutp02x for ; Wed, 14 May 2025 09:53:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20250514095340epoutp021edbb730db5e5e979124f136a6ac3590~-XBPP2nUm2558825588epoutp02x DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747216420; bh=9Qg8cccbFqUOc2UTuMr4PQBF5rx3CZxXMxNVXLkP9iM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qLKYGqoNZWCpEPswjKSiL/jwZdfg6hKG8BNcTBVvm1RhAxDecxaNguhe/3/u7MbJe nKWqNduRqYJm6mzpWQ9Bb1sGjKkSbuSC9lZwTwSz6A3+VEVTOmxtNFsdsxOvjGekIn JZiYHE5P4jODE8PT4xIyT9c2ejiFARr/4kvve7yM= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPS id 20250514095340epcas2p35d5b5b07e4af0e655a1fcef524752925~-XBOxpJeW1373113731epcas2p3D; Wed, 14 May 2025 09:53:40 +0000 (GMT) Received: from epcas2p2.samsung.com (unknown [182.195.36.88]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4Zy7vl51Whz3hhTC; Wed, 14 May 2025 09:53:39 +0000 (GMT) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPA id 20250514095339epcas2p1c0c174b1d2d5aba23899363d2fd5928a~-XBNzkFCu0288702887epcas2p1y; Wed, 14 May 2025 09:53:39 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250514095339epsmtrp1e4c02d91f25a0d152e7254ebea3b5f81~-XBNyzjhC1996219962epsmtrp1P; Wed, 14 May 2025 09:53:39 +0000 (GMT) X-AuditID: b6c32a29-566fe7000000223e-45-68246822f3b2 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id A8.AB.08766.22864286; Wed, 14 May 2025 18:53:38 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250514095338epsmtip18d6f3b10cccf8ea5db315f0b6ce9c3ef~-XBNnLVxT3233232332epsmtip1W; Wed, 14 May 2025 09:53:38 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin , Kyunghwan Seo Subject: [PATCH v2 2/5] watchdog: s3c2410_wdt: Fix max_timeout being calculated larger Date: Wed, 14 May 2025 18:42:17 +0900 Message-Id: <20250514094220.1561378-3-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250514094220.1561378-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsWy7bCSnK5ShkqGwYyTVhYP5m1js5jffonR 4vz5DewWmx5fY7W4vGsOm8WM8/uYLG6s28du8WThGSaLGYtPslk8fvmP2YHLY9OqTjaPlWvW sHpsXlLvsfN7A7tH35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZexf2MlYsJ6rYulNpQbGJxxd jJwcEgImEo+Pr2DpYuTiEBLYzShxcft51i5GDqCElMS7Z5YQNcIS91uOsELUfGCUOHmwiRkk wSagIzH9320WEFtEIE7iWPtmZpAiZoFHjBJX5vUwgSSEBcIkDq45DmazCKhKLDx2gw3E5hWw ldjz7jYTxAZ5iZmXvrOD2JwCdhJzW1rZQI4QAqpp2u4BUS4ocXLmE7BdzEDlzVtnM09gFJiF JDULSWoBI9MqRsnUguLc9NxiwwLDvNRyveLE3OLSvHS95PzcTYzgwNfS3MG4fdUHvUOMTByM hxglOJiVRHivZylnCPGmJFZWpRblxxeV5qQWH2KU5mBREucVf9GbIiSQnliSmp2aWpBaBJNl 4uCUamCaZjvnoFH7hqWzal+JNj74vneDusH/tf21N38UJBxjTv0sc/yCY9/UDpnN5rN8WpeV JlWwqxkI8x37t9aRL85E8nH+rsTq2clMutc+GGuqPXav/bVi2Zp9lhsufjZvb353RvLcpyV1 E572iU7xfc7THPRKtTTjzo/7Qj2rz6z/uqaYb/oEiYVpvCc+7nX6LfPchbckxUOQ72J3ySyO nydyw1s3K/uotlQ9MJrF3KIzXyD7X2r7hzcpvYsZwoWYTCO+3CnIuLel6YvItiTVV7eXlt/x qt6j+0K+OP77KRaGp/EyXxg2vhXU5v4x/9fVkxG5d6p/71NX9WW1bv6wpHlawaaMcoGqlDWq ClqLMh8rsRRnJBpqMRcVJwIALDGlEOsCAAA= X-CMS-MailID: 20250514095339epcas2p1c0c174b1d2d5aba23899363d2fd5928a X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250514095339epcas2p1c0c174b1d2d5aba23899363d2fd5928a References: <20250514094220.1561378-1-sw617.shin@samsung.com> Fix the issue of max_timeout being calculated larger than actual value. The calculation result of freq / (S3C2410_WTCON_PRESCALE_MAX + 1) / S3C2410_WTCON_MAXDIV is smaller than the actual value because the remainder is discarded during the calculation process. This leads to a larger calculated value for max_timeout compared to the actual settable value. A ceiling operation is applied in the calculation process to resolve this. Signed-off-by: Sangwook Shin Signed-off-by: Kyunghwan Seo --- drivers/watchdog/s3c2410_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 228f86d83663..c6166d927155 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -379,8 +379,8 @@ static inline unsigned int s3c2410wdt_max_timeout(struct s3c2410_wdt *wdt) { const unsigned long freq = s3c2410wdt_get_freq(wdt); - return S3C2410_WTCNT_MAXCNT / (freq / (S3C2410_WTCON_PRESCALE_MAX + 1) - / S3C2410_WTCON_MAXDIV); + return S3C2410_WTCNT_MAXCNT / DIV_ROUND_UP(freq, + (S3C2410_WTCON_PRESCALE_MAX + 1) * S3C2410_WTCON_MAXDIV); } static int s3c2410wdt_disable_wdt_reset(struct s3c2410_wdt *wdt, bool mask) From patchwork Wed May 14 09:42:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890120 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6394625DAFB for ; Wed, 14 May 2025 09:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216425; cv=none; b=F3nUATdGA48d8PFlaOXye5XZhh09ftPMy6yZXgp4ixokjdw3bT6CAceUis+5ZBAy+1gknl2J0yghfmiDdHZf9YL2ejDZ7woiC5fFYk25H5cRs9BKroYB3r5bVtnIYR5dZoa82KmUkxcexGCKUEjkmFO1mCdt+qflScGmB9XEQYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216425; c=relaxed/simple; bh=vR0UQoO2XxwJQek/TZEpTck1zQ7UkY4WavIhIGGCiHc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=ZnD32z9cOlyx5glN4gYkqE7ihurltWAyzJJoe6G3e8MGtz+B/vNNGoqsXxUVFMOTE+4SGGzA2jwkriWxPhKbPUgLtRIeRV7YZIHKkgk7nhHwnOjI2SvEJFMciBk7AtST+fSath2zdz+sEx0O/Sau7b3cWW56rSPFrKfieVLPerI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=cPgcvyY/; arc=none smtp.client-ip=203.254.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="cPgcvyY/" Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20250514095341epoutp0436e6cf0988f575a1ec95b0f1d0162be2~-XBQONOKJ0311503115epoutp04b for ; Wed, 14 May 2025 09:53:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20250514095341epoutp0436e6cf0988f575a1ec95b0f1d0162be2~-XBQONOKJ0311503115epoutp04b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747216421; bh=M3b1Psw+JucOaMEaVCgfFq85fzdpxooWfq61IOT0Tpk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cPgcvyY/UF3i4/R78cS6a6Nc4BjrYoyUzGDMr+hJ2BKmIPQ+JkAlmlYWYw0f8FbEh McoPcvXjd4wFGl9RLgakNjj4XXtnBPEDK+TV3UOHt1RBwvR9UsvfuVi4nRybsM/Jyt S1uHlyZ9K5HNWQ712ilJ2bbtDaA4ZwSuLQfPG7MI= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPS id 20250514095341epcas2p4a56583edd09d7c993c68efd8667ab8d3~-XBPxewzu0188301883epcas2p4R; Wed, 14 May 2025 09:53:41 +0000 (GMT) Received: from epcas2p2.samsung.com (unknown [182.195.36.88]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4Zy7vm5x42z3hhTG; Wed, 14 May 2025 09:53:40 +0000 (GMT) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p2.samsung.com (KnoxPortal) with ESMTPA id 20250514095340epcas2p2c58454d8e0e27f46d5a71475f22e614e~-XBO7Nqho0657806578epcas2p2d; Wed, 14 May 2025 09:53:40 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250514095340epsmtrp19c55ac68ac736c446cac4b9212cf74d2~-XBO6ce_J1996219962epsmtrp1Q; Wed, 14 May 2025 09:53:40 +0000 (GMT) X-AuditID: b6c32a29-566fe7000000223e-47-68246824665f Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 59.AB.08766.42864286; Wed, 14 May 2025 18:53:40 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250514095339epsmtip17dca7478570878620e0152c719068ba8~-XBOreiFl3233232332epsmtip1X; Wed, 14 May 2025 09:53:39 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin , Kyunghwan Seo Subject: [PATCH v2 3/5] watchdog: s3c2410_wdt: Increase max timeout value of watchdog Date: Wed, 14 May 2025 18:42:18 +0900 Message-Id: <20250514094220.1561378-4-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250514094220.1561378-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsWy7bCSnK5KhkqGwcnVbBYP5m1js5jffonR 4vz5DewWmx5fY7W4vGsOm8WM8/uYLG6s28du8WThGSaLGYtPslk8fvmP2YHLY9OqTjaPlWvW sHpsXlLvsfN7A7tH35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZXxqv8xYcF+l4vjkRsYGxity XYycHBICJhKPdy9g62Lk4hAS2M0o8f3eWfYuRg6ghJTEu2eWEDXCEvdbjrBC1HxglPi4aj4r SIJNQEdi+r/bLCC2iECcxLH2zcwgRcwCjxglrszrYQJJCAuESnx+c54dxGYRUJX4MXMtWJxX wFZi/pxudogN8hIzL30HszkF7CTmtrSygRwhBFTTtN0DolxQ4uTMJ2C7mIHKm7fOZp7AKDAL SWoWktQCRqZVjJKpBcW56bnFhgWGeanlesWJucWleel6yfm5mxjBoa+luYNx+6oPeocYmTgY DzFKcDArifBez1LOEOJNSaysSi3Kjy8qzUktPsQozcGiJM4r/qI3RUggPbEkNTs1tSC1CCbL xMEp1cC0U2rHsWSjNU1LH6kG336/Y2mI9DV2FwXFBucFO1x/aP1+ue343HVhEy0EhEo+JliE brT4tLNrgZKccU7Rnor6aPMiMV2p2PbLM1V+GUq4qLy8Fa3PN9fwW9bSqYsc9h88tu4xk3La 59rgOwefXTttH8RxZH9M+s5pAev+/lFLZWq259xwarmsX2TAtXlNcrkvEjTCWibXhx9dZPLf J0Zz2te+S/nrDtg22r17scO/a8PcNUUnu5u9e5TPZ+3/0eLUynu5TDBo5YSXv5xZRN76fS/8 78nxpORLwrZH12bp3Mt74/rhe4uUj7rJo6l9cZ6+rsFHNT6bb4jlsXV4vbckt/vGEdbtnFds y/qeCxopsRRnJBpqMRcVJwIADso1IewCAAA= X-CMS-MailID: 20250514095340epcas2p2c58454d8e0e27f46d5a71475f22e614e X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250514095340epcas2p2c58454d8e0e27f46d5a71475f22e614e References: <20250514094220.1561378-1-sw617.shin@samsung.com> Increase max_timeout value from 55s to 3664647s (1017h 57min 27s) with 38400000 frequency system if the system has 32-bit WTCNT register. cat /sys/devices/platform/10060000.watchdog_cl0/watchdog/watchdog0/max_timeout 3664647 [ 0.302473] s3c2410-wdt 10060000.watchdog_cl0: Heartbeat: count=1099394100000, timeout=3664647, freq=300000 [ 0.302479] s3c2410-wdt 10060000.watchdog_cl0: Heartbeat: timeout=3664647, divisor=256, count=1099394100000 (fff8feac) [ 0.302510] s3c2410-wdt 10060000.watchdog_cl0: starting watchdog timer [ 0.302722] s3c2410-wdt 10060000.watchdog_cl0: watchdog active, reset enabled, irq disabled If system has 32-bit WTCNT, add QUIRK_HAS_32BIT_MAXCNT to its quirk flags, then it will operation with 32-bit counter. If not, with 16-bit counter like previous. Signed-off-by: Sangwook Shin Signed-off-by: Kyunghwan Seo --- drivers/watchdog/s3c2410_wdt.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index c6166d927155..1c7299deec5d 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -34,6 +34,7 @@ #define S3C2410_WTCLRINT 0x0c #define S3C2410_WTCNT_MAXCNT 0xffff +#define S3C2410_WTCNT_MAXCNT_32 0xffffffff #define S3C2410_WTCON_RSTEN BIT(0) #define S3C2410_WTCON_INTEN BIT(2) @@ -119,6 +120,10 @@ * %QUIRK_HAS_DBGACK_BIT: WTCON register has DBGACK_MASK bit. Setting the * DBGACK_MASK bit disables the watchdog outputs when the SoC is in debug mode. * Debug mode is determined by the DBGACK CPU signal. + * + * %QUIRK_HAS_32BIT_MAXCNT: WTDAT and WTCNT are 32-bit registers. With these + * 32-bit registers, larger values to be set, which means that larger timeouts + * value can be set. */ #define QUIRK_HAS_WTCLRINT_REG BIT(0) #define QUIRK_HAS_PMU_MASK_RESET BIT(1) @@ -126,6 +131,7 @@ #define QUIRK_HAS_PMU_AUTO_DISABLE BIT(3) #define QUIRK_HAS_PMU_CNT_EN BIT(4) #define QUIRK_HAS_DBGACK_BIT BIT(5) +#define QUIRK_HAS_32BIT_MAXCNT BIT(6) /* These quirks require that we have a PMU register map */ #define QUIRKS_HAVE_PMUREG \ @@ -194,6 +200,7 @@ struct s3c2410_wdt { struct notifier_block freq_transition; const struct s3c2410_wdt_variant *drv_data; struct regmap *pmureg; + unsigned int max_cnt; }; static const struct s3c2410_wdt_variant drv_data_s3c2410 = { @@ -379,7 +386,7 @@ static inline unsigned int s3c2410wdt_max_timeout(struct s3c2410_wdt *wdt) { const unsigned long freq = s3c2410wdt_get_freq(wdt); - return S3C2410_WTCNT_MAXCNT / DIV_ROUND_UP(freq, + return wdt->max_cnt / DIV_ROUND_UP(freq, (S3C2410_WTCON_PRESCALE_MAX + 1) * S3C2410_WTCON_MAXDIV); } @@ -534,7 +541,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, { struct s3c2410_wdt *wdt = watchdog_get_drvdata(wdd); unsigned long freq = s3c2410wdt_get_freq(wdt); - unsigned int count; + unsigned long count; unsigned int divisor = 1; unsigned long wtcon; @@ -544,7 +551,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, freq = DIV_ROUND_UP(freq, 128); count = timeout * freq; - dev_dbg(wdt->dev, "Heartbeat: count=%d, timeout=%d, freq=%lu\n", + dev_dbg(wdt->dev, "Heartbeat: count=%lu, timeout=%d, freq=%lu\n", count, timeout, freq); /* if the count is bigger than the watchdog register, @@ -552,8 +559,8 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, actually make this value */ - if (count >= 0x10000) { - divisor = DIV_ROUND_UP(count, 0xffff); + if (count > wdt->max_cnt) { + divisor = DIV_ROUND_UP(count, wdt->max_cnt); if (divisor > S3C2410_WTCON_PRESCALE_MAX + 1) { dev_err(wdt->dev, "timeout %d too big\n", timeout); @@ -561,7 +568,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, } } - dev_dbg(wdt->dev, "Heartbeat: timeout=%d, divisor=%d, count=%d (%08x)\n", + dev_dbg(wdt->dev, "Heartbeat: timeout=%d, divisor=%d, count=%lu (%08lx)\n", timeout, divisor, count, DIV_ROUND_UP(count, divisor)); count = DIV_ROUND_UP(count, divisor); @@ -764,6 +771,10 @@ static int s3c2410wdt_probe(struct platform_device *pdev) if (IS_ERR(wdt->src_clk)) return dev_err_probe(dev, PTR_ERR(wdt->src_clk), "failed to get source clock\n"); + wdt->max_cnt = S3C2410_WTCNT_MAXCNT; + if ((wdt->drv_data->quirks & QUIRK_HAS_32BIT_MAXCNT)) + wdt->max_cnt = S3C2410_WTCNT_MAXCNT_32; + wdt->wdt_device.min_timeout = 1; wdt->wdt_device.max_timeout = s3c2410wdt_max_timeout(wdt); From patchwork Wed May 14 09:42:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890589 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89B0D25D550 for ; Wed, 14 May 2025 09:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216426; cv=none; b=Lv0a0NlHnPyVdNjCV1izc98sCS0HnjDqT3+LPNFT43nQQLiFYhEcyvOgaf13I7yPWl3sZHJTdJsziTVzz5UZWRx9VLf9Gjk3Otedm1JPwVuLMtk/4oX14ufXWa7j/O3IvbH4XDPDYssBmpuN3Qs4G9L+VEHrlz9tZNhWdAkYBug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216426; c=relaxed/simple; bh=Ursjan50Qcf7QoJQKjSZMoQdbTh05KFYWyeXrspZMNg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=ibKhJq869wsaIbGcUtYurpmrdyGGjjXrFBGxqRd1d1jZpdmLilGqQUqvCKrD6QonxDutFx84zp/j9j5KdBsDWURy2YMJJTJ6TBcnly3LHDGJzMjCcPK7YdG00MAuHH1H0QrzPMW2bR2g8BoiptJPcYcenND+iC5GF4TuLk1WBnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=j+UPB3sa; arc=none smtp.client-ip=203.254.224.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="j+UPB3sa" Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20250514095342epoutp02d0399eaf307a2453be42f905e4a4d53a~-XBRUjO0m2676226762epoutp02X for ; Wed, 14 May 2025 09:53:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20250514095342epoutp02d0399eaf307a2453be42f905e4a4d53a~-XBRUjO0m2676226762epoutp02X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747216422; bh=F9nR+4yjOvh1XbA9AsmONTB28VO11laEZY8Ec+hddHA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j+UPB3saAahHjPu1LaWVZL6z3lnKcijMlonRVnlK7J5sW73Kf/jWNtTK0cyxsXBKP KTxuqjusrBNz17XrqQ2FxoJutCX987ppQXGRl2AJloQfXlTL0PqlSTe2TZLFAC2OWF EgoJB4C4N7yXCavavzKfPyoBufKxDuC6PYIi5Vn8= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPS id 20250514095342epcas2p4e93a4c35b70d89577b32214afeef708d~-XBQ0Y1Mo0421404214epcas2p4E; Wed, 14 May 2025 09:53:42 +0000 (GMT) Received: from epcas2p4.samsung.com (unknown [182.195.36.88]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4Zy7vn67Dkz3hhT9; Wed, 14 May 2025 09:53:41 +0000 (GMT) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPA id 20250514095341epcas2p4f4bb6da7fa61f19610e63ee605eea94c~-XBPyMg9h0421404214epcas2p4D; Wed, 14 May 2025 09:53:41 +0000 (GMT) Received: from epsmgmc1p1new.samsung.com (unknown [182.195.42.40]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250514095341epsmtrp16ccda6f6dbd6411a230b3289924ab0b0~-XBPxhGW-1996219962epsmtrp1R; Wed, 14 May 2025 09:53:41 +0000 (GMT) X-AuditID: b6c32a28-460ee70000001e8a-15-68246824de58 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgmc1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id B8.C4.07818.42864286; Wed, 14 May 2025 18:53:41 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250514095340epsmtip1ab4469196d723c53a1b1d9ac55153c78~-XBPh6vsY3233232332epsmtip1Y; Wed, 14 May 2025 09:53:40 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin , Kyunghwan Seo Subject: [PATCH v2 4/5] watchdog: s3c2410_wdt: exynosautov920: Enable QUIRK_HAS_32BIT_MAXCNT Date: Wed, 14 May 2025 18:42:19 +0900 Message-Id: <20250514094220.1561378-5-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250514094220.1561378-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsWy7bCSnK5qhkqGwerFzBYP5m1js5jffonR 4vz5DewWmx5fY7W4vGsOm8WM8/uYLG6s28du8WThGSaLGYtPslk8fvmP2YHLY9OqTjaPlWvW sHpsXlLvsfN7A7tH35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZTQuOste8IOzYurTa6wNjFs5 uhg5OSQETCTuX1vC1MXIxSEksJtR4k/zU5YuRg6ghJTEu2eWEDXCEvdbjrCC2EICHxglLs6p B7HZBHQkpv+7zQJiiwjESRxr38wMModZ4BGjxJV5PUwgCWGBGInGCZfAbBYBVYmfn56wgdi8 ArYSV6Z9ZYJYIC8x89J3dhCbU8BOYm5LKxvIDUJANU3bPSDKBSVOznwCtosZqLx562zmCYwC s5CkZiFJLWBkWsUomVpQnJuem2xYYJiXWq5XnJhbXJqXrpecn7uJERz4Who7GN99a9I/xMjE wXiIUYKDWUmE93qWcoYQb0piZVVqUX58UWlOavEhRmkOFiVx3pWGEelCAumJJanZqakFqUUw WSYOTqkGJudvG2cdMmZmdWpwPOP7mXWP7gNNgz+3p+kVzvnMu/8Z58PO+AJ7P4MEU6abGeZ6 n87Ku+3s2KEurzhRUDJE1amslPul/4XyMONZqvLuLmIsaZuOtD01Z4kP+XPO55tmUdzbyV9e 7996SuawlKrys1OT7dnW806zvK7iJiL8iG+P40mNBd9XFQnLq02+sia3SHTu67KX5UIh0uvm rFCqs6jpFvBf/EAvhSW5cP7EoIyLtkk3uR88OaD2elmspssX51xpZp95RVHVMrd7391278qy rNv5X8BWM8Pu5Jvtib/2uzyIlGteVyf8SsTXKrbIQav/lWBOS8v5+CnPVMQqPgsc6dro3WX+ 4NiiziAlluKMREMt5qLiRADbeOu/6wIAAA== X-CMS-MailID: 20250514095341epcas2p4f4bb6da7fa61f19610e63ee605eea94c X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250514095341epcas2p4f4bb6da7fa61f19610e63ee605eea94c References: <20250514094220.1561378-1-sw617.shin@samsung.com> Enable QUIRK_HAS_32BIT_MAXCNT to ExynosAutov920 SoC which has 32-bit WTCNT. Signed-off-by: Sangwook Shin Signed-off-by: Kyunghwan Seo --- drivers/watchdog/s3c2410_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 1c7299deec5d..3c12a3ae50f8 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -326,7 +326,7 @@ static const struct s3c2410_wdt_variant drv_data_exynosautov920_cl0 = { .cnt_en_bit = 8, .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET | QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN | - QUIRK_HAS_DBGACK_BIT, + QUIRK_HAS_DBGACK_BIT | QUIRK_HAS_32BIT_MAXCNT, }; static const struct s3c2410_wdt_variant drv_data_exynosautov920_cl1 = { @@ -339,7 +339,7 @@ static const struct s3c2410_wdt_variant drv_data_exynosautov920_cl1 = { .cnt_en_bit = 8, .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET | QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN | - QUIRK_HAS_DBGACK_BIT, + QUIRK_HAS_DBGACK_BIT | QUIRK_HAS_32BIT_MAXCNT, }; static const struct of_device_id s3c2410_wdt_match[] = { From patchwork Wed May 14 09:42:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sangwook Shin X-Patchwork-Id: 890119 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7846525E456 for ; Wed, 14 May 2025 09:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216427; cv=none; b=p0ANwgESOl/ir8m3proNIYUUb35SrhUuR4xzb/5zWFgkzb+1z2VMgAeo21m7f0XU12JwZPt2umKm30sYKnFWe9cdvEXPgfCnz5+KK+hW26N+vb5fTC5qiVKvXmrFg25Td27LF1frHfWDIF3nXMQsIwfKwVYrOJrCwNuRPfxkkBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747216427; c=relaxed/simple; bh=622+LtoyH7U4bpu0gZpm1wzigDBNma3B5KPFSwSgLl8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=BvNinDOQKmSAcccL1KQPUWfuMbtuqSe8SRvRvFAPIEr9gC+H/sgVxtsCdqY4iAWFw6ehuL95XtFRZmlQVo7dTilzWDjIeYOpNgcModXsFzH0uVLeWj0jBoT+tZU2L+A2cRTHh1DJBiLQy+vubQaYqVI4HUEjVipmdZNmxg8WZTM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=VCzszoMP; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="VCzszoMP" Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250514095343epoutp01fddc30f867f4cf37fd1c769e162fa7c4~-XBR92IQx1877618776epoutp01N for ; Wed, 14 May 2025 09:53:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250514095343epoutp01fddc30f867f4cf37fd1c769e162fa7c4~-XBR92IQx1877618776epoutp01N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1747216423; bh=euDg0lpNrnAL1l5Mdnq3mtKgKzdVtdPZ2zegxJqxchA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VCzszoMPD7nw+jtgtfo2yfzdf/o4bMLtODt74fiW+R3xb4WJ06a0eCqguMG3Yn7SH szze6IKugVyKyuyOuQzR59luLsAEpd0Sv8D99ePX/GC46n0/wJjKCWniNFo9n0K9IU BlBPudwPjGSHHgXhte574g6PB2FsE6YePr7cWUY8= Received: from epsnrtp04.localdomain (unknown [182.195.42.156]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPS id 20250514095343epcas2p134dadafb319aee512fab07dc76564974~-XBRh5m0j0288702887epcas2p1D; Wed, 14 May 2025 09:53:43 +0000 (GMT) Received: from epcas2p3.samsung.com (unknown [182.195.36.101]) by epsnrtp04.localdomain (Postfix) with ESMTP id 4Zy7vp4ZT4z6B9m7; Wed, 14 May 2025 09:53:42 +0000 (GMT) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPA id 20250514095342epcas2p366f8abb441850d4b503926425082f2e7~-XBQj9krg1373113731epcas2p3H; Wed, 14 May 2025 09:53:42 +0000 (GMT) Received: from epsmgmcp1.samsung.com (unknown [182.195.42.82]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250514095341epsmtrp1a88bf0b1c84a630ccc397dcf28e64214~-XBQiV3do1996219962epsmtrp1S; Wed, 14 May 2025 09:53:41 +0000 (GMT) X-AuditID: b6c32a52-41dfa70000004c16-da-68246825082b Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgmcp1.samsung.com (Symantec Messaging Gateway) with SMTP id B9.55.19478.52864286; Wed, 14 May 2025 18:53:41 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.9.126]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250514095341epsmtip16e419ee7529645ed800122dee606b8f0~-XBQYfbc43083530835epsmtip1Q; Wed, 14 May 2025 09:53:41 +0000 (GMT) From: Sangwook Shin To: krzk@kernel.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sangwook Shin , Kyunghwan Seo Subject: [PATCH v2 5/5] watchdog: s3c2410_wdt: exynosautov9: Enable supported features Date: Wed, 14 May 2025 18:42:20 +0900 Message-Id: <20250514094220.1561378-6-sw617.shin@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250514094220.1561378-1-sw617.shin@samsung.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsWy7bCSnK5qhkqGwcUvFhYP5m1js5jffonR 4vz5DewWmx5fY7W4vGsOm8WM8/uYLG6s28du8WThGSaLGYtPslk8fvmP2YHLY9OqTjaPlWvW sHpsXlLvsfN7A7tH35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZcxcsp+5YCl3xeVVdg2MFzm7 GDk5JARMJNrP/2fvYuTiEBLYzijx42AzaxcjB1BCSuLdM0uIGmGJ+y1HWCFqPjBKTNzwnwUk wSagIzH9320wW0QgTuJY+2ZmkCJmgUeMElfm9TCBJIQFwiR6v+5gA7FZBFQlWs6sAovzCthK 9Ow4xQixQV5i5qXv7CA2p4CdxNyWVjaQI4SAapq2e0CUC0qcnPkEbBczUHnz1tnMExgFZiFJ zUKSWsDItIpRNLWgODc9N7nAUK84Mbe4NC9dLzk/dxMjOOC1gnYwLlv/V+8QIxMH4yFGCQ5m JRHe61nKGUK8KYmVValF+fFFpTmpxYcYpTlYlMR5lXM6U4QE0hNLUrNTUwtSi2CyTBycUg1M OQ9ebZu/7MeX7QvCo77LvNzxwb2c/VP3m6cZEterUx4GLJqw6GHT4r8XLmZ/63q3qpG9wPR/ 4mfhJV6hV5acCzi7PGrP79KnK/jOGbzc8eRWh9O6BKt8if+hzmU32RUu3n79dVJCiwjHp9gE MeYmKWvGFwzulq7nCz/w7UhX+1z/R8NV78WRdT9WZRZFXLfSf3Gv4seO2qstd9/Ihc29HtQV r/zisnq/lEFsrKd+/bw40fyo1uUP5k39fpDlo8NzmeArSYZ9Ei68mk1l1pVtmQwbXv1VFH5w 6eQp+y+bV39y0TTrM7i6+kH/uy0x88xkglslDrgwb+zitZvqtcG6Ztmd+ud7TdbrmBo48E1s UmIpzkg01GIuKk4EAO3sg/fnAgAA X-CMS-MailID: 20250514095342epcas2p366f8abb441850d4b503926425082f2e7 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,N X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250514095342epcas2p366f8abb441850d4b503926425082f2e7 References: <20250514094220.1561378-1-sw617.shin@samsung.com> Enable supported features for ExynosAutov9 SoC. - QUIRK_HAS_DBGACK_BIT - QUIRK_HAS_32BIT_MAXCNT Signed-off-by: Sangwook Shin Signed-off-by: Kyunghwan Seo --- drivers/watchdog/s3c2410_wdt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 3c12a3ae50f8..bbc1d9916f67 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -275,7 +275,8 @@ static const struct s3c2410_wdt_variant drv_data_exynosautov9_cl0 = { .cnt_en_reg = EXYNOS850_CLUSTER0_NONCPU_OUT, .cnt_en_bit = 7, .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET | - QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN, + QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN | + QUIRK_HAS_DBGACK_BIT | QUIRK_HAS_32BIT_MAXCNT, }; static const struct s3c2410_wdt_variant drv_data_exynosautov9_cl1 = { @@ -287,7 +288,8 @@ static const struct s3c2410_wdt_variant drv_data_exynosautov9_cl1 = { .cnt_en_reg = EXYNOSAUTOV9_CLUSTER1_NONCPU_OUT, .cnt_en_bit = 7, .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET | - QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN, + QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN | + QUIRK_HAS_DBGACK_BIT | QUIRK_HAS_32BIT_MAXCNT, }; static const struct s3c2410_wdt_variant drv_data_gs101_cl0 = {