From patchwork Wed May 14 19:18:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 890397 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 782BD1FECD4; Wed, 14 May 2025 19:18:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250330; cv=none; b=P6pGToPpwKyGwjhVC9MWVpO/Q4NKnEuV0u8itgr8XCMAkFknGmlGol3K9lNlEWqUyb4NSkMFq6qPCJ4pD9s3qGp0d5PtudWiRBg2fvScomKxNfIQ2UrB+f8Z2yhr/NfAW6yUa8nTFZWNkxo4Dqx/MttLL6PQqUhpqie4uQqQzbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250330; c=relaxed/simple; bh=HWrCWD/D1GcLemVwToyXg/euxJc5Hy8JhNtLCS2OIDg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P2pe8CYQeaYMhml0+KvSUx7k8pTyIhLgLEl/PvvBUo5J/+7WXRpa6c+JBu5wAOeehhJcsmiKlPBjyx8lSzSKzH8nmCNWIBKGXqX1pKP9lYq8B2v71ldcFOAv1JEcB5FwJQ6KU4BUt+vaKca1+Mz71nYjqGvOIx7Iimk3B++Or80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IdBhjPDq; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IdBhjPDq" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so1719965e9.1; Wed, 14 May 2025 12:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250327; x=1747855127; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e+3rMB7TgpOuv4MciTDXaw4O2zORwfW5g8/Gm6AF5Sc=; b=IdBhjPDqzl486pMGV/GvFZSYRVYqNWqwVkC39AL6z+Sq4Yg9I+BacEi3WojNLB4JD1 lNatPYdLgwJ0dSxW9aXiiUsqQCDU7Icp6s/R9P/0DAKwpr6VLa+LKZOa1s0vJO9bZoNs fYRH1eXY7t2TQtAtr1lm9Ph1ECpqc8hFf3y4gOQ0+RDnClVJzcQnvXYMVE301eGawffg c6qokxuTG5fgHHeeSPozFixjagM+6MyG2HQp9ywRCzs6H8t4uIWy35135kXkwupZYQwF 2Yp+qwD+Wi/83UlPJtj+LoCGqk5invNUDEHkSETM7GTNaS92Gsmz2l3kwesWmjMx+BaA KgsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250327; x=1747855127; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e+3rMB7TgpOuv4MciTDXaw4O2zORwfW5g8/Gm6AF5Sc=; b=a5SaAoa83+H5QZqbCVQr2kr5HLjGJt7rafrcoVWSOXElZ9dld/nATe5GvSSwe/iO0U IS/8nuF6szZg1ComqkdK73mMC8PMlUUDd95+AvAH9yxpCij431TvXr7VTj9gCG4QpIBS qAmeRNm0guBoRK7Y5a/n3NojshQVl7+cluKiFlyrx2DHW1tFj/4osx1TeGi6Pp1aQqva +MVz8GRtPMR2zZEfZTE9kw0RUlx1h4jqWtLXglFgzzTr1XGTD/+L4oqr5g10xSAr1sJ9 Q7PGBcebFK9HPFn6LCyJQy7eN/WclaqiWwn/LVhrds8PgF4GgTxN3m2J1GaEDr1Pm2R+ NHaA== X-Forwarded-Encrypted: i=1; AJvYcCUY19UcXw+nRAh4sd2d7xQX2viNojHAJI7/2A9rzUpOs9XxNOE8R1+6329qVP27fCit598UKPmWbox9mSO9@vger.kernel.org, AJvYcCUjDGHEP0mPXXxNafYwzV2WltizN7piVXOA8nSEwRBq1erz1afLR9x8EW4aY5LqqTe7b8efMC2U@vger.kernel.org, AJvYcCXPB81ehopvTlKmtABWcN2RzaQ2/DUm2tDvDnQYmpKVgd4AaNxbOn8AvXffAkZNPtCM8JqOMk1Uq9iA@vger.kernel.org X-Gm-Message-State: AOJu0Yy9M4w9abHzK3CxTLtBowQkPfrjBnS80pq5sg906VjstDtul8G3 2bMhUIo5c7n+URPHJM1OP8ypg6NmPEPuV3D+vK3oua2iqVtZRPi+ X-Gm-Gg: ASbGncuoS5ErKPhfuCm6RF9mMr9uHfXJBElsS7UebR8UGkgQAJKnB4M1DKSJlabFVyX iG0hnwea+N3lbzRxaplfu7g+iyZt95hlvpyGL/QG4nTqdtWOle5u1h4+wSQpwjuWOITHmLa6d07 ilj9HvXJ6e7YWE3haufAlcD6VPw5WZGjsNXzaXBpocc8tkbfCE0pGFLvxi74+PWHaGUGSX4l62/ 0QGiyt+LcX24WHibzEu+nvcCiAvCfSdyajy1LCQZ1k0RwxBn0VdP5EhP8uuZAw0g0PY7NfCPVIF 6qIj80BnaWrZHOhT/uyKdWiaPhZTAcXPv2spD1MxGiJNFkUo03WxeDkRtvB5gzos5O3bFCniGk2 IEyu2TtjW9itR+xs= X-Google-Smtp-Source: AGHT+IF3E6LnoIX6JTtY3lxfeZ+NzzfzZnch+kPaMH0wTlfbXodC8lOmf+uaRXXzGO1KAKLVlDBUUA== X-Received: by 2002:a05:600c:1f96:b0:43c:f78d:82eb with SMTP id 5b1f17b1804b1-442f2107a53mr42040395e9.15.1747250326663; Wed, 14 May 2025 12:18:46 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:45 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:32 +0200 Subject: [PATCH v2 1/7] pinctrl: armada-37xx: use correct OUTPUT_VAL register for GPIOs > 31 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-1-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org X-Mailer: b4 0.14.2 The controller has two consecutive OUTPUT_VAL registers and both holds output value for 32 GPIOs. Due to a missing adjustment, the current code always uses the first register while setting the output value whereas it should use the second one for GPIOs > 31. Add the missing armada_37xx_update_reg() call to adjust the register according to the 'offset' parameter of the function to fix the issue. Cc: stable@vger.kernel.org Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior") Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 335744ac831057576473dd62c5533168b243a656..43034d29292687e875136aafa530b62479dc55ec 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -417,6 +417,7 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); + unsigned int val_offset = offset; unsigned int reg = OUTPUT_EN; unsigned int mask, val, ret; @@ -429,6 +430,8 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip, return ret; reg = OUTPUT_VAL; + armada_37xx_update_reg(®, &val_offset); + val = value ? mask : 0; regmap_update_bits(info->regmap, reg, mask, val); From patchwork Wed May 14 19:18:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889998 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8038D28DF3B; Wed, 14 May 2025 19:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250332; cv=none; b=SEYRa4Du0atzSG44f7HZA+irCUbi7Dbx9x1/OfjJDvPV0zJvneWiE4Af2YmatZ5Em58yMZOc2Q0hUKDhYdmrzypIchuFx06k3TAFsEVBGYo35Qkp2witTKVcnsHzM32wKN8DmjaQkrceLMkqSBNJIvAnktLIJZQICOm65QeM4bA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250332; c=relaxed/simple; bh=rkHy0kQeLRmpuGO74kKtvOziIW+BrhpOftFy3YFd1qw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=B4TXdaaa2mh898IAsMTJwl8cb8IaR+Dq9KBPEv6lcjyvwAAeqeBoUMnTXZylJ5rgkS3dHH9cuRgwUUryLh6+gWzHqVaijqgJmcQ0YXzmGhdGEMr1jvePNSxiOzVux7JxLjzN4NZe70CPy8mwnHpC/rPbqj9y1Vbkg5PZV3/LTgA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZEGGEnrG; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZEGGEnrG" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43edb40f357so1442975e9.0; Wed, 14 May 2025 12:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250329; x=1747855129; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w1VHW2HJExWmBNfaPof6yV4PNzfV43beUESvCPBIVuk=; b=ZEGGEnrGc5SixD8L8+9/Bf9GN8S9YHQh4JyUPC8uW2fnhtoV2wQrbq+5b7wOMnVvvU ETN8rgRUcfdJIk2nxVDa/+VOCLK1wkJrYHrf9oZCPUvcM2Nwdx0EpDjym4lEnCeJZKXP alRwuhKUTLiy5u+Wi2OWE8D82D0cBPsirSdJqFtPaln6ni5l5Bcul1yknI+GKNKEKtBv sdF/ONiqeF662LlIXZc89djUv6YHmprnvQRS3LTLnAN43X9JUpIQGDJf1SN0PwT6CZuP UquFk4J0PXdZTG4C0PkVuXtTYFj5kLQdbIljchnp31MDaWXdvFrzRx1kCjC+vcmS+SgT bC8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250329; x=1747855129; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w1VHW2HJExWmBNfaPof6yV4PNzfV43beUESvCPBIVuk=; b=mgO0gPKDNdQSw2vP3lMdc11uYSUXsInGvSx6ghCKQyVvO6iNPTQWm29h0efrt0gZg0 2DIq4G5CWHH1axtQVekYG5818vMNrmnKaUAxTeOSdSMWuN/vsSkFgFuMlMbORqBDLoiz I0GthopwvnI7dT8GzJRKLI/+vj6O7KvVgz/t9r/sG5pscOkFFK+lyg3ycA+aFdvG+WTs m4jZybktTrlOMigW/39xehwA6lQpelmDhisWoC4XZSUJAI9fBgKoCFIpq5YLXzE7uhud c0hJNJF2WsSCHOUu+nXmEufJnfICo0gnj7YYh6UD7Jyy3HIb0ddJgqhgcdMEcdPssQkm AWtQ== X-Forwarded-Encrypted: i=1; AJvYcCUS+qGnWYXRhIFgUOluumMrFrQfw+IzBrxI6xR0U2VcalViBVM7iLgYeaFYfkK9HIMxLm1GXYUvoNCm@vger.kernel.org, AJvYcCW8Obf+ZqiWPrLH7Yi/S23Lv4pX9wWWwVg0dgqz0OpruOQop5HZZjCyVVJoUYAHY/VyWzLgwCJ/@vger.kernel.org, AJvYcCXtX67TM3G7EqX88ThAzAZs9eKIjy6i7iWFfH/FOlzp93x8lp94+4Uwv+f/YYkicLlVXrhvM9v0/i7rpauu@vger.kernel.org X-Gm-Message-State: AOJu0Yzq3+ZEp0wQ2xMF1UV8NR3D1rbAXOpgfVK+nS6O12LmoV8jHt4M Xa9PsXSETeZe2e9v2VlWb9GTrqYRMmY8MA6jLaypYxQfslbVxCCm X-Gm-Gg: ASbGncuEemFgR5TLWBWrdrYcu9FNqOn+6TjP+/OWnHZ7h3cbwDaAjpnclWDc5BKEV4y Q6/yuEWoCf7XOnCsZSVCMZ7rguaYBDHFzuif73HWdJ0R6IROCnIepMGGa8OAfpzkIvxmgeHlqBh N/779UaqZjdCCFF+FJWDh9/k4bin8jwK8mWXAFXuqKaWmAM9I+dXNgxPhvrfH9osXfYFnb2AVld 0VWIrDniW4N4ViFaQ00839yQZZXn4qZbRq9m9Tu1HeyFNSKgPcnp6E8A5CFpTaIXsg+JI27DqqP vjmEEPFGnInVyA4JBJ69yCEhupPzLeIuIPBfS2EcM0RgbBxMPEXDIEh40nLQhXhcDy3p4HxtGQj r59yV X-Google-Smtp-Source: AGHT+IFVv7oza45Q2QfziPl/5KRvPAxx5elH3SF3XZpjCrkHu0ZxgVl+w6k+ib6M2XHCdlmCCVtmpQ== X-Received: by 2002:a05:600c:4686:b0:43d:94:2d1e with SMTP id 5b1f17b1804b1-442f20e9013mr43795755e9.13.1747250328632; Wed, 14 May 2025 12:18:48 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:47 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:33 +0200 Subject: [PATCH v2 2/7] pinctrl: armada-37xx: set GPIO output value before setting direction Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-2-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org X-Mailer: b4 0.14.2 Changing the direction before updating the output value in the OUTPUT_VAL register may result in a glitch on the output line if the previous value in the OUTPUT_VAL register is different from the one we want to set. In order to avoid that, update the output value before changing the direction. Cc: stable@vger.kernel.org Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior") Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - swap with patch 3 from v1 - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 43034d29292687e875136aafa530b62479dc55ec..79f9c08e5039c31acb170d4f38b516b1454fd9ea 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -417,23 +417,22 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); - unsigned int val_offset = offset; - unsigned int reg = OUTPUT_EN; + unsigned int en_offset = offset; + unsigned int reg = OUTPUT_VAL; unsigned int mask, val, ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); + val = value ? mask : 0; - ret = regmap_update_bits(info->regmap, reg, mask, mask); - + ret = regmap_update_bits(info->regmap, reg, mask, val); if (ret) return ret; - reg = OUTPUT_VAL; - armada_37xx_update_reg(®, &val_offset); + reg = OUTPUT_EN; + armada_37xx_update_reg(®, &en_offset); - val = value ? mask : 0; - regmap_update_bits(info->regmap, reg, mask, val); + regmap_update_bits(info->regmap, reg, mask, mask); return 0; } From patchwork Wed May 14 19:18:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 890396 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D43A228F505; Wed, 14 May 2025 19:18:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250333; cv=none; b=gBYgDHRxcWHtlML54v4Mbum1KKskc1NBQHJr7ytQZozNny1g3Vcx3AyTord3PyLYVm3SsvRrSfZMs4EeyKZpcQ4HPACimaayvkl0qkjv1M0r/3mAtd+7zC8iu08q19upKm/fC5jVIPWPv9xT1howbc6lfamFvWhfMWULkhyvSOg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250333; c=relaxed/simple; bh=ykZXcE8hJxsykp8VNTUTsaJ1m9LqQ7SpsYliElzTU9U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ye16sfAynU7kCiEMw515QVz8X/hqROah6Vd0R757z2owredAx6rP4Bmktgj6cPrKGGGbxl2eHnyVpqxmbmdvaUlagaFZPplVWAirw07Rf0wbKYqgIkA+fGHC+H/1sR6/gZIh8+5Rdu5LUcPatQQcCbm1V+B28ayaAZMpMrF22sA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cDkM3A3h; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cDkM3A3h" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cf848528aso1305895e9.2; Wed, 14 May 2025 12:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250330; x=1747855130; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TPNeg7LLw+wPjDBNhjdS5KhhZROy/LV2IQ+NsavxOkc=; b=cDkM3A3hXXH+UD2M/TKu6bavMDTFIrDj7R9efTFypHsOJnBARjOMWiSYvqB9zUllBR ZppQ7Cez8JfTPVWnOGgASwByDfNwc+e8FXSx1V8hpPk9PGt57fg82dQ9gJtYH1VrAUZN 8byS53TKkcafZM60kw9QDxEruA4rimImNA1ZOcCIrc9LRgu0xaB6XYgCcW8k7kKiciGp XxvMij1wZJx2M/Qzxfk/hvuvomIcz/c2qhJomZER79J3nLkHiPCFGqpu8bvnlh5Un5E5 Wp7WKdN9vMCMj2Cfbi7FI4XW3fEEIZ8TlxXn+Auughby6FPxU/m4j5qYl5ZQdFy6UyfW gp7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250330; x=1747855130; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TPNeg7LLw+wPjDBNhjdS5KhhZROy/LV2IQ+NsavxOkc=; b=HMZQXOchAqvs4/9FuEiwr7pjsUSkM2ROPN0cvZm/qx7Qbf+v9EHZX9twM9upGDKt26 zIaWwASMUjGZn3zfiIm3vhzWhTAiQO/PjrCRC7tgmU7X7yjio5WSPKRirG/PZJ0LDblb 58xBVxgIlJaYdpoEzoHP+UAUClaYKIVgj/sacdTQZlvDpPF0ua+lAbiPXsXMDFclI6iR ESROy3v5g0Z/AWgY/zj6V/rmXC1qYD03cafm4+hAP78Ji7aAYwDfZ5VsnFnJnANF2vFT 1vr4ncytKBZv9pD9E+f+68St1nIdxb2qDPfd5Egst01mSGJD4exMD3iUOPZa/0l2lLiF /D2A== X-Forwarded-Encrypted: i=1; AJvYcCUShkCAD15cc9dsgeFr9dxiowzDBQtPHd1tiHstCUwVY+BFzGOp9KkA+3EhVbiYEn3MPrv5blFL8pLw@vger.kernel.org, AJvYcCXQnjHnX7wA7YxlyqieO5ZbZC68yyhL/VTStwVskoiLS+9GAS5rg4zbWiaegmZWJ1AGpsYs7DIDykRmb4xF@vger.kernel.org X-Gm-Message-State: AOJu0YyukQU5LD8UyjFSJVacgrYtVOOFOvn2us9V1s3Yj39hFYCQQc/q PrIIO0IOXVGhZQZjpfdgG1dvTBmvZ9mHA4GkXvGUAfrmAogN2KlO X-Gm-Gg: ASbGncvWroIj0WXGGJLs566XZhRZoisqym8ncYHMfs5He7izBaLsS3QqQbECRqkhj0t 8ej/UzOtQLGnBvmnJSiA/+kjCL7msA6La096CkgYhXoIbdCi51o/YWOEiNwei7pqr3nIv9Xdo4K /2AfCEwfrsLz9+vthHKSXaz5mPSRNRLorAoDoKe4h3QPl3beUuOoRVmUayB314E99T8yJV2UeA/ +hC4GeabtXYlfPN+uWpENRCvwknkcvs+KgnLrlEm7tN081barOX6CB1/PAzJkJ86ncyh6NX5MXA LYQkHjZ9HjwOX77mWYKubrYz1mh5xk0pI70f/O/ktXwpFNIYfJIG0/sZUCDCgNTZzNuUzWrgem5 3V0TB X-Google-Smtp-Source: AGHT+IH0E2mXP8h4czOWxmxTLcdTr5dOwlDwwjHlT7wewaTCIuF6I9tuk+ZWHV0gFhyASv2QPYJl2Q== X-Received: by 2002:a05:600c:b88:b0:43c:f332:7038 with SMTP id 5b1f17b1804b1-442f2168c5amr42844645e9.21.1747250329820; Wed, 14 May 2025 12:18:49 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:49 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:34 +0200 Subject: [PATCH v2 3/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_direction_output() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-3-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 The regmap_update_bits() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - swap with patch 2 from v1 - remove 'stable' and 'Fixes' tags - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 79f9c08e5039c31acb170d4f38b516b1454fd9ea..8d93d36af63ab9496376219454214c05db30971f 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -432,9 +432,7 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip, reg = OUTPUT_EN; armada_37xx_update_reg(®, &en_offset); - regmap_update_bits(info->regmap, reg, mask, mask); - - return 0; + return regmap_update_bits(info->regmap, reg, mask, mask); } static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset) From patchwork Wed May 14 19:18:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889997 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D50E9292915; Wed, 14 May 2025 19:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250335; cv=none; b=pbTiXg/XJ7gkPVSSGFzBhJXJhH64PxgKaPvHxNDFgRhWxYX+SBsQGI8N6kdCkq6cVFsynOOSYGKMBVJPJkOZ9g/cCAvmDIRaAxvdCgMz3OiJ/yaIqjB/HIm/EGSCcYIJyDe1UU369S/pi/E60V+MnaxP6VfDgcQucrbJ+lAB2K4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250335; c=relaxed/simple; bh=jlyE/5zTgoPhjJoVNnSQJM7bQxmZU/bpkCu7beL60fk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lOk7ilbVFMJ4LsvVj7E5RP/hg0pezxaCAisAWLBK0/mvE86Wrb2HjvZ1XOGiKTqHzveopjBeKQL7gZBjbnh5na1yNGdNlhfVSQBUT6MjqYrx96AXnV+umxNFk1kLMcM8q7Fqlelr8D8mrLq+VWgWTUdhvfjmgcqN73yABnLXtVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZhJUA7DH; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZhJUA7DH" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3a0b6773f8dso89622f8f.1; Wed, 14 May 2025 12:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250331; x=1747855131; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/w5xa3ncgd49kFJyT9bhO/chzYmHK3SV50+YzkQ82VU=; b=ZhJUA7DHy9IbAa2fUT7tv10t0tlWZRWELtrOOkWOlFm+knyc3QgzZn28SGuzNUFR4J YZnIDNyzTcvwgPBLtCkmQykk6dtNsPyqUVrGDsx59+o100H6Cy6brOLLCdHVDl3VeFBb aN03M5mv4JrquPqedplLRguTSmvwV0a27oNKmEAtzc8MMlAMKI8uqy64uhav+jaOUqy7 OtTdZL0/lEv1OgsE1wfFpY2LmLwbGGGbSokH+X1HoK1sQjonlJUihAwgjLyhBN2Mhtbr iaV+l1rPhvBFy4OLy/QviPYUKSCUgwYCmB9bNETpLTo9uCwHtUxTgB4ohH1AAgHxOZoq BhfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250331; x=1747855131; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/w5xa3ncgd49kFJyT9bhO/chzYmHK3SV50+YzkQ82VU=; b=cj3VgfIuyDJByMG1NGiNpZIpxxv8t5SnYcvHzFuIXOByJhgHKxsXRxILzdBqoLQk5v OfJoQuRiRQW9kRQaoF1oI5JBfzesGLvID2ouGJcFpdIlxLDKmuJhF0CRSVxcamkKAPpJ AkgiS3SK7nMMTOn9qsmMqSSpF4+VpsNegGGqYibx+1hixXdfDSn7F8LzL9ddATiS7pnJ gT+zYJ0qxFq4OmBHX+StApb2wo4AdlSh2lE3D17NGRqlUWng7AkfRY4JVPnY7kPYKBfW Xk6QF8EsHkWa9heROWE3EDPWZoy2z7lRiKoKo9Vo40PX0zpYOTqaO/olzDlS41N2A51h GNPg== X-Forwarded-Encrypted: i=1; AJvYcCVE06PwXKiW1FYFxYjM+HNXTR/c11Xb1HwGf9FD1v6mjM4Sqk7MK48fuSrxjjxpXAOxP94S61yLNSL/@vger.kernel.org, AJvYcCVQnu8QZoxw/s2F4ER69J0somjyq8FL7BH1nCliTSxdcTBCOwaB0qvrPjuh0FLS65L9FelE6XpWIqMHRl0U@vger.kernel.org X-Gm-Message-State: AOJu0YzN9J6u3SRVTlM4Au9qcVKpM4MIx7vw7Ujoo0Sw1DyULcp7yjEr ugtEkZ7LThtlmkPAvSJQKFe0S6T3sV9rRnhCxAwlFRPOo//p7WIp X-Gm-Gg: ASbGncupGAsiD54XE8DnhdZiduetkMU/y2/LWlIJ38jnTnei0s7HGPQbbTgtF15J/hs vRt/Se5RBF2D+KAMMWnLcIS3nZiURzPCH/3rOgla6bnZcr29iuw826DiewvOlsL3vJLzFi2O3lG 4/HNMHXJ3Sz+Vdv915vRGKh2MhBUtm5v44jO07DiEJo9pNlBWnAew6eiqfUb0GaPMXjwhGWlwi/ dgcepPrYaDOhWQc+DBJIsb4hmTlL94qIubrQ1C1qUwDMYOGQjiwwlAPAFlk/fZ1wOA6THNrVii6 2QJSQ6/BrxmFGicwimo5ykGERmTEg4+bfAsh5HVAjRfur5sUIWmMBUs+KExfpPLp/AcSfnxqoxl bU0ix X-Google-Smtp-Source: AGHT+IEgJuTYC7ocCZO4XzaB8x9Uw4o8jNbva79UgC8DZ96g+uMc/4dsrtA/ArSqnVslHqk6qc2TAg== X-Received: by 2002:a05:6000:4382:b0:39e:f9e8:d07d with SMTP id ffacd0b85a97d-3a3496a497emr4133973f8f.20.1747250331033; Wed, 14 May 2025 12:18:51 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:50 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:35 +0200 Subject: [PATCH v2 4/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-4-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 The regmap_read() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - remove 'stable' and 'Fixes' tags - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 8d93d36af63ab9496376219454214c05db30971f..2e88a0399d1a205064b58890db6477e2202bf311 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -440,11 +440,14 @@ static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset) struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); unsigned int reg = INPUT_VAL; unsigned int val, mask; + int ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); - regmap_read(info->regmap, reg, &val); + ret = regmap_read(info->regmap, reg, &val); + if (ret) + return ret; return (val & mask) != 0; } From patchwork Wed May 14 19:18:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 890395 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D064293728; Wed, 14 May 2025 19:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250337; cv=none; b=h0wo8IlcgQjONIsmtzY8H4i2NUQtx5H1oSSQloJax8uFVkMKPPgzNnhdY1mEbuHZgte0zgS/r2InezVmC00pi0fESpb74U4zX4vHI5QIfja8lS9ces2Q+gi23yuiYr86jROlgN5qdl5CXPFxFPQUQOoNQcJXQwTrHkLE62dL//Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250337; c=relaxed/simple; bh=h0tNaL6qncESrFjbYyWC3nmtw8NiJhI90khkkfSvdXE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d23SKD1zzbQ+luwDl/0F9w9X/LDdOyrUsSdMwccaPneyrXwAhCy9WX72cotYxL36ho3b1Qb/G9PMFfH06QUSdjzxc7obTYN0T8ZoEp8AYtRRICqiaSNGm29R6z/zq4oZ5Zavynz9+/2/mwdn+RstIame+TQ0H+7QFUrWc8K8BEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZZ5bBUjs; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZZ5bBUjs" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43edecbfb46so1479175e9.0; Wed, 14 May 2025 12:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250333; x=1747855133; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RZSG2e6Oo70EYCNnyg2ytHClvaVnzvr6s5xKl7gP7ks=; b=ZZ5bBUjslrEuULci9HVu3kgpw+TvS4t+H2wYecB/bLLZt+iH6T4XVvDqzPv5bJQuIi UcVpeFPz7ret8dZAdNIk4cSPIm1yEa7dT08/IYpre8ylnQ6uLaPNkwLirXiHH9PvPf03 1ki05fyJ8vCxYBledfFTAVAT9iBjVd3Pfn/76FwE7XezoDZZO4T7bzSo928Yegej8hzv 5sPQWgrGcj2BCqqajBcmxNyUt1W79NXEwgA6vUaYPf6lCaog/Bg59hBuzSybqpZjmYfb inG2eSsE/JHcWXB3Kjxo9o/I8Sk66rT+VznLaSEYOwLJC5q3vDHxnZBCAdAXuNbCeNRd lY6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250333; x=1747855133; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RZSG2e6Oo70EYCNnyg2ytHClvaVnzvr6s5xKl7gP7ks=; b=NkOajNx9N1u8ewiL90H6hVbrUuf3NmGFO76inxsLzBlpgvDDPemBtSQRBzLtkzgkCX NdbPHC/CWtvnpUae0nK6pNzYOp3ojvXGvfYUhUG1Osr9CBHNoGv3NVm+MadV10Nf67T/ I9/eWDTRWLH1NNTpS0iOVJYiZDLd9ecNbBNYSQDiF31VSZqLfBmwiR6WnTph1lzfWpAL p9wIWbMMmxaOxo0qd3e/lbfAfBiaN8XRbGsWfDJQAmzJasQjf1Bl+up+D4LYpveKyLxL XFvKqoH1pQo6ovt/8EaJ4IdR0lhF64YjMw1EChk1B3sjWWLXvT84d8Q5JUFfxsxLciqS embA== X-Forwarded-Encrypted: i=1; AJvYcCUW7q/6cPhaltesMRlvKAJiqnNoOj5n0JddGB/WtsSYsiXax1ja44zneEQBeOsbug8Lub8tpOGKhYBPH7Kk@vger.kernel.org, AJvYcCX283N4SNpJajsW/RNTqyqc/5mIHUG423NaYjIs4wni2enZUPQ0f5S6bioQ0q2vW9Ry07qI7XwWhvpM@vger.kernel.org X-Gm-Message-State: AOJu0Yz2sdt9s6aojO7K4iQpeC9mD+rc7WmBEACeHKEsEof+oK7CLnuJ Mh7XHg21Dbfd2HygiDZw1xG5kM/D8O+ryXsPTuFN4T6FxNr//AWu X-Gm-Gg: ASbGnct+QkWoNR7lhFDtdp3wm0YPDVTU0zRLdYhw7QsZ92yK4W2eynR+zImK2jYoel1 WKsjZLKZt8pbMdccP9PhhsoMchg5Vra2vkeQny3d1QoNyE0WpkHbWCyqHFyx1vwYAkkQieR6/7o Ybv7M10FZBPHNNyI+YepegW88GUYYEqLQoqkOI2FN7aSGvXCqh02hKrGF1mYUWVzFRxNkeuceRN wSoE/z0hUL3kdOO9RDxwNfTFhm1FHx/ApwyOAXyGwPry+6/Lw/OaVwXUp1E4dQ8msdmXSxp7/pV Eiz/YEJ+6/JnezAvHdcBGVpesvfeHY3VOQzb3zTfcIgrYByxmA/akjlS01JM9s0VfC+lV21BdcL otVyP X-Google-Smtp-Source: AGHT+IE/FzeiZP6erIxPU2QEOlCFHyMatTZe9U11qci64whMI6XJiG749EI5iSektYWhvPKKGSJZ6g== X-Received: by 2002:a05:600c:c059:20b0:441:b3eb:570a with SMTP id 5b1f17b1804b1-442f285d105mr24526685e9.2.1747250332437; Wed, 14 May 2025 12:18:52 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:52 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:36 +0200 Subject: [PATCH v2 5/7] pinctrl: armada-37xx: propagate error from armada_37xx_pmx_gpio_set_direction() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-5-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 The armada_37xx_gpio_direction_{in,out}put() functions can fail, so propagate their error values back to the stack instead of silently ignoring those. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - remove 'stable' and 'Fixes' tags - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 2e88a0399d1a205064b58890db6477e2202bf311..aed0069b085ced5867993e95e0244df7ccda556d 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -472,16 +472,17 @@ static int armada_37xx_pmx_gpio_set_direction(struct pinctrl_dev *pctldev, { struct armada_37xx_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); struct gpio_chip *chip = range->gc; + int ret; dev_dbg(info->dev, "gpio_direction for pin %u as %s-%d to %s\n", offset, range->name, offset, input ? "input" : "output"); if (input) - armada_37xx_gpio_direction_input(chip, offset); + ret = armada_37xx_gpio_direction_input(chip, offset); else - armada_37xx_gpio_direction_output(chip, offset, 0); + ret = armada_37xx_gpio_direction_output(chip, offset, 0); - return 0; + return ret; } static int armada_37xx_gpio_request_enable(struct pinctrl_dev *pctldev, From patchwork Wed May 14 19:18:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889996 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BFC7293746; Wed, 14 May 2025 19:18:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250338; cv=none; b=SS1IHO63XyrAUUrMNotiLaw7MR1uCuzRRJWwrlfZnp8L/oQtNUQrKQ6wShlODMI2akLYDXM07wKaVPKk/LQU9CRYRC+MO2jSWVZrfVg1tYWIrZunaBcd5OK081tqZ/Zl5KFis501aMIe5CA6ZDLviGwCeTPP9hhfXxv0UBhWZp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250338; c=relaxed/simple; bh=c162Anph3qlAPGzo2CLpqBLKtsxPBThotJe6YKAgJZg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P3d+pRwU93OruB1ldHCq8MF6RX3v+/TCDAfh5oFxK/dNiAH6UMq/SkNkjdLc6nq1qy2bqUvlcHoHJpKTLqiUH2XO0jLSantNnLu6qkmIbvE4FTVJiOe0GA64qvJzyn2gjBE+FTEdY0RaK7YzEvkZ0iJ4rAWyLMx2DASp6NaGFN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FISLwmRe; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FISLwmRe" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a1d8c09674so87031f8f.1; Wed, 14 May 2025 12:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250334; x=1747855134; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3JH55QdZJtAaACW1NAFT3cE1dsxbphEYIr1BTgO2aG4=; b=FISLwmRecUnKV7+bPJlE9iWF+npXyPH6Xpi6/FYrHX+y+jgTAt2MtVnlRX0VkkYGI2 +TuN2tMlVZQuViUWbMse4vwkVNuWTLD9jE3G6Np9H+MHgjXtfZ4QzGHrMF2g/tfaBucg PezWptj19pAcAjl6/YYl5Ex5ylTC2mJB7RcgNCCL3lcmLr5/ddEntkUeSqqhscZstSby 65pn/MmtY+r4QYwkKPbSklis8lRnVU9XMaObUdx21KQOC+tf+7D7Upypdpjh0uoTH6ZZ 8qFLoavwwBgMu8z8BoI1JFOmEJgCJlX+HM/f2j8/J/3GAwLWvqbztZUb60VQxuyLicvL SIcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250334; x=1747855134; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3JH55QdZJtAaACW1NAFT3cE1dsxbphEYIr1BTgO2aG4=; b=su0jFvWjDcBuQp/LtcSo3PlhSOkCAJfVN8GtC7se7uKly4Zwh1TAChrx/Faxtz/pZ6 sVqheRSbJ9R7F1/jk1JoJ4yNAItVQt8V14/akP7eNpXwNAqB6QXL6guFJ1qXucZ6bsGy sW5vVYuc4ihHlhAm4szVGJBegnUz/SgYeyGaTNl5jqsEdNI8lF9yNLhuyAwvpRQWY7WE 5LoNhCZR0/0rIDsQ5TGxbgscrzQr/SQJ9ig5wgeaYKznK0ZT3hoBLXxHfLN+tBmgIHR1 LzqHjppNbKwwBSAt0NLy4md4+L0vfbJ+DxwAFi9+OmV8v2s3TaEjm9Z+PgtkNZZp0LVx KIIQ== X-Forwarded-Encrypted: i=1; AJvYcCX5YFmGk4lS05v3wtpCFUBEaFQtKJtoYfKJFakoM06x5KupSKHso8sw1o/G2D6moTCZfqXzgiHC7LhAuTnh@vger.kernel.org, AJvYcCXmISiBpWWBZov5WSLYAnbvDN+AymOWU4QgxAvU2WXlcXavVjqz6DyWNyh6r3fqYFEDZjvwdWCHRKwh@vger.kernel.org X-Gm-Message-State: AOJu0Yx+4Oid425MuiI6zxx/Ksiw6lczgXX96oJVT0x60KUE6MqOpTda owRpq4gAqZFveJz+i/ZVhkiqW5blc8qwowtmSGXt11hJpN+SDyCR X-Gm-Gg: ASbGncu3A3zrBQl0mSAG1lBgoE/gke7/onZfbxj7unPWIGYuQyi1b58Nli1PL+HWQ6h 61dg5PhRO2A+eTDDeo5QT36hXoSYvoyD4vInwlddvmlxRnt2Hsun3CLaUqFJ6Gy0d/wx6/9mjDJ HTHbD3t65fTcqdpAdPRUE71pW4NufufLGvQOA+gaE44DJ1xua48nuD6voSEHM+uKOSqo4t5K7bt bSj1+2qcZ5RI47uiaBwUw4z3ST0h2Pgq6Jvir+lG1EQREyfG/z26Fx+yEUlbBf26MnC9YKA4z53 S6ajmqCxk13x+DVF0S/I3cKbaN2ClolX5QL6+XSpfbYQZlJhrDHz5T0dI9HnqWXnmGiLKSbYzge TaM5m X-Google-Smtp-Source: AGHT+IHzNZaFCgyXoBk/vI3JWqPShaXSNalLho71Vx1hM7ORoJVxx3uDSV4erFJ5/o6LPZDyD2SVTA== X-Received: by 2002:a05:6000:40dd:b0:39d:724f:a8f1 with SMTP id ffacd0b85a97d-3a34969487emr4027229f8f.10.1747250333647; Wed, 14 May 2025 12:18:53 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:53 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:37 +0200 Subject: [PATCH v2 6/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get_direction() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-6-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 The regmap_read() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - remove 'stable' and 'Fixes' tags - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index aed0069b085ced5867993e95e0244df7ccda556d..18c6c5026b26c294ee65e3deea02d2e852e10622 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -402,10 +402,13 @@ static int armada_37xx_gpio_get_direction(struct gpio_chip *chip, struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); unsigned int reg = OUTPUT_EN; unsigned int val, mask; + int ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); - regmap_read(info->regmap, reg, &val); + ret = regmap_read(info->regmap, reg, &val); + if (ret) + return ret; if (val & mask) return GPIO_LINE_DIRECTION_OUT; From patchwork Wed May 14 19:18:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 890394 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97A65293758; Wed, 14 May 2025 19:18:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250338; cv=none; b=QGZ7oeuLtRg5s7iGBDsRB5ecA36+0pUNLO1SSwav05bF3Boq3fsD8tLdMlKG0VifY+MVfPtggPxhyAMazk3PQkZFoJ25g4eEElSZqe5CByb0I7Qlhwha4FwsITqwdklsjLyS0sdiZCHe5KL3rITwurS6az5XtjVrTzjKvudPtwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250338; c=relaxed/simple; bh=+7qqRID3OgpSWICC3duVHK6vZd1Tbn89NENi8PpPnjg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Xojcv6VrQU/9p1JHdOgx3Xi6h4Qq4kahchI1HM7uFjaKEEvjFIJlfmsIo/Ujln7uniqJ4luafth5sZYjDe6DnvDjHkZGBFJ9pVoHnSm/ckLnHj5rHVk8dhR5wcP3E38FM4UKUu5cyMOBdXWUbaZz3rjrzB+dpbHK/71xzghCdnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jcNVZ12y; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jcNVZ12y" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-442f5b3c710so1347315e9.1; Wed, 14 May 2025 12:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250335; x=1747855135; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vaL6y6eAH+cyG0BHc8g4kaknwTTJ0ODkBusGr+TVtqA=; b=jcNVZ12ybH7Yph7nLNKSVApKMxSH5TIOa6fljweuvMM2UZJFWcYYL5eM40NYT3Vw21 2IjH6rpYdINe5p+AC+vtDvHy1nfFrT2XxWjg1OimgxRaTugXTKKwHmVjcrzHOHSU09xA rps6QVHNd7O7kZrauVhGY7FBijHgZC969Ku/DZBeaxoQuuRWlRK4TZTS+2RieoYHNN8y aflyKry/gemxbo3vzUEYuVtxOHiXd30qo1jh/2wE8CKogDqAqptGq8JDtBVnlNwaaSfc 4fd+acG9xqi5Nuycf3DpqB8hQp0THGKj7e1L9+VOirs9XUp8VbP54l4tKUKMRDeGU0YV v+Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250335; x=1747855135; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vaL6y6eAH+cyG0BHc8g4kaknwTTJ0ODkBusGr+TVtqA=; b=jZTiyRYHAJPN1zCxKD0JD3TYaUudgStUL1/hXqZOohxEWLvwtAUZ4yeeaAAOH6JacH hzR0JFnV5mMXAoMxbTwmi1mtONMeXdfO5cDJ7D9jahouQyWpB7K4NWSTZDkvjrM4mVVC 73QAwK3AkAXKbIbDA1OB1pZpS9ZOOCcZq2FovDlhd3wmsTwfMUfGOsWW9kmbEP4GeSbr R3j4crI1E1aXvymtEgFFY2pXL0eya2iZPZ6bjtaurwQt64TKze4XvGfUrpxxuIdwjVWW 8Psu2Nbz+pj4UFwLe/kWklHLkjEZvei//xwZAJ24Ulp9EkSg6t3pLmX3y3znX3iC9MgT /I6Q== X-Forwarded-Encrypted: i=1; AJvYcCVuCK8XgJ9dqjkidazRM5olsU8HBASStanOAxY7/2YKCDYGGhtzknVHseEDVc86iR/kOrQnGQYfmnp7@vger.kernel.org, AJvYcCW6QtDDOWwCd0EeAHnTO4c0uzXrVxrvh2jlzLXDnCAW5zXYW6bZhduqFk0zum/PkPwtxE1MEefyk9U857RL@vger.kernel.org X-Gm-Message-State: AOJu0Yzk1N00PVC8bGWtrHg5TXCdwWMj5Jwq7wK5nj4YCPJE4sCjQUfY d9LioRLvRQRXvtn6fxPLY/DYE3syQvVjx8BPT3h9aKA/JsbYxCAa X-Gm-Gg: ASbGncuhd/dfeGxlhf0/+B9IIofV+cfF93VXfCR7dnKWOCl+bMTH41KYMKcJnje71ek /CSdlffZdOD+DaGHy3EJHbUwZ+3DuNebwKyssyacbDmH4n5IY4w9/iCpJNb2MxaNKRYS1vPZvn8 0bH/sn1h0tHY4p8jiHZNuZCsqmtH87C1aJmgWL3NhxjTOg8PIhNDYgVoNzQFTJOQlrknMBx0hPG Qb181e2ryK3O5n953Y38aVFPVVGI4sh/dGaDhBOWzGtzrHlnDpXpEMwfwg1tDByyPEEewaSWFFh qoaxfQcWbQKpr8vLy1FbDiximhOp/sWsMfqy0o7qerI7TPpbsCZh0qQxLLVj0NSKsCPMiyo6JY2 2Kl/P/ADBRT5cdro= X-Google-Smtp-Source: AGHT+IEO8Ku9a6HIDYbQtu7HYkIlwiUHOkaMZWGq1KsWHgfBv9ZWFnMh6u04RTRwJ+/8YE1l6aQXSA== X-Received: by 2002:a05:600c:1e2a:b0:442:e109:3027 with SMTP id 5b1f17b1804b1-442f2168cefmr45995485e9.24.1747250334905; Wed, 14 May 2025 12:18:54 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:54 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:38 +0200 Subject: [PATCH v2 7/7] pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-7-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 The regmap_update_bits() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - remove 'stable' and 'Fixes' tags - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 18c6c5026b26c294ee65e3deea02d2e852e10622..f35bf0cd98c97419ba0ab0291a23d4774a595d39 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -358,9 +358,7 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev *pctldev, val = grp->val[func]; - regmap_update_bits(info->regmap, reg, mask, val); - - return 0; + return regmap_update_bits(info->regmap, reg, mask, val); } static int armada_37xx_pmx_set(struct pinctrl_dev *pctldev,