From patchwork Tue May 6 07:29:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 887932 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011004.outbound.protection.outlook.com [40.107.130.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8C8E23314B; Tue, 6 May 2025 07:31:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516675; cv=fail; b=BVQ1HfMnW4sUW++tdVPwHYL85AWfCkxxrtKeWP3N8rGDExjh+cTHjYqCzlGogRwApruWRBrW7bfrGk4y2Kn3riaGFBT5Y46s/kn0AODYfmGWGWsveCrjbkh9XYWsoiMzSHTdWKxSYaGLwHycNc36tLMlyPxH6jxJYK3HrTvvvrw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516675; c=relaxed/simple; bh=d9XsZOm5HN31TB3o+Cc3rtYz1J+CsGeVUq+zrNjEVpA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=NOs0CH9102dji7KUEOL9GHp1bt+8lArfpZF3RXH22G/yqoA+S8pw6Mms2u/SkJ5Q6oJ1QD/ShZ2M/yihJCmBhdbRcWGR922AbhB1RgdvbOFNVsTbv3gVtZXvFpkw335xbVYa5naYZcE2Ib/DkA4KUXRaH6xcMZU7MIfU1laHp7w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=bVDuF+NW; arc=fail smtp.client-ip=40.107.130.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="bVDuF+NW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DZfpO0oRET95dni19w26p1gaKaBOVYYxL9PSKEK63PjfffRRJ/JEY9jCg0M08RjVRDf6SH3CKWrexxAoUpJMzuiBlxn6cIBlksf5XX+JZPSd8Mo8ltXulVq8eSD9C3UIWPI/j15v2vTa32SOFv+YpvpNTTHYIWdvDn8V/LZWkUAUotb2wgyjq0/1/4s9tdZ2xca6MxaaJJDKvf1EjLGRF7/t7wL0IzJQB5Vche4ij7efjzqibkoOKvSBsUuW74tQoEr7nuBpI5EzeXXkAZDpBZW1p14jDHwZ2oSKYaNuCla12a8G1yZwTFmJM8I3Ac+HA84HeGuv0es/KxHe+HU3Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tCcNcUQb6VDoFfspJ29cZ90knzyy35SVsuFGx5dhAjg=; b=NpFPKGQpspPYqD2PDE73d55ZotjbYUfuDI1ORY8OwBZabZkL4mKrOXrRBJdPDqCuvBFDF2aFiTMeJtMLLaz4ZOaKezTARabVTSrGAOg8CwWptMuYLcQq6s55E+JWZjydyOHLcRYWcy7HOUtzT+k88YfiyjA4JflIleTVekgSv/Re72a83DSWwc4eNJyyYH2TxHQU81H45Qp5PJVlnWl7DvvxC37vKnwfzbkYUlLb5R5tZY7Sq989CNmJlq/8C28V+9J50tlpBxKAyju5hulIspKFEK8OAju3lJm4Wc5C2zH+aKIVpZsVY7yfZgk0nqEYcHrNvlURMS2g2H6/ySPbzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tCcNcUQb6VDoFfspJ29cZ90knzyy35SVsuFGx5dhAjg=; b=bVDuF+NW4tPcJYaZKhvFHTgB/RxmqkGrOyQ+owjUGH9sfwoN1wO34FRDRmFoIPwmD9TAJv8nGUPsj+NPtLa1Fqd158Pm9QLSozj0+dHQizQTpc8jXcBWW5H7TZkKU1CXtI3fAD+sc0ofYMKaRsb+INDqdJPN1c18h9j1bWR5nnec3xqzvZlfcUfuBQZ4uJkykcnLsF8LhwX2GCCUg8xTfGPmPwjJ20kJS9iE2aZlZ03Ht8TzD2Ysz1zYZRdD4rD4/cPXt3BObSNvfFjGJmOLYxe7sWfVeb3o8R9YlA5sthTEkpk79v92VSOSSdNlAWBHzDTLBk8orCfdMTzscc7b3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7196.eurprd04.prod.outlook.com (2603:10a6:10:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.32; Tue, 6 May 2025 07:31:09 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8699.026; Tue, 6 May 2025 07:31:09 +0000 From: "Peng Fan (OSS)" Date: Tue, 06 May 2025 15:29:32 +0800 Subject: [PATCH v3 2/9] ASoC: codec: cs42l56: Drop cs42l56.h Message-Id: <20250506-csl42x-v3-2-e9496db544c4@nxp.com> References: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> In-Reply-To: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Charles Keepax Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746516585; l=4414; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=eQ7UdEZ4xHJklXPmR4di3YvcmBTWJXIeJvZOIGA8q0U=; b=cukX6B4dylPXdPLfg6q2rW19aJzWL08TFsI8T3UuSD2nhqYPPNwmRa3llNdrQemmPVg0YBsQ4 nKbjmkIDqzkC0kl/oi+mAfprDTx9kZHevcMSweLJP756nSvnKZPPqEA X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR01CA0176.apcprd01.prod.exchangelabs.com (2603:1096:4:28::32) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: 952f785b-63df-4feb-ef67-08dd8c6ff880 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|52116014|7416014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?b6ieUD3nZiLracSFvo+DWIeYQd/f3jV?= =?utf-8?q?YbhoCjmCMVD/qsJoekd0QVMRqEQ9QQ9ooMkDQLmBB49QZ9sdYI3cTA5Ass3Z/6vxS?= =?utf-8?q?sEu8wK0EkPTEUzaXhFEkDdoi+NvaBhCvljMpKwYACctsjxKPse+57e+HEga4DVj02?= =?utf-8?q?3JJDXWAXVdtDWXfMr3PNL2h+LUKGxJ21LwBPL3g2uXiQOEVeuZfwgdratyd0UQRd2?= =?utf-8?q?bYu9DfUpd+q3aGJTrf8VYMEL0r94d+jMgv/5lJFlOfiUVEKeDqd0Kqyns/QTMDGh4?= =?utf-8?q?T90fIjVDu4njtBY7Ikv8G6M1kmxfYpyeL7xDEGiKSRxIMoKIhpy0vRZPJmy44Zi6S?= =?utf-8?q?fGFBZJqcs92iwvUV+4WBra+wVwigGiz5w3VZu9DoGm3yIol0QVNPQSES0CyICCRxP?= =?utf-8?q?g+q++EZJrlCMovyEFb0pGZYMIhHqzMf72pISblbLy8fSxWfCo2XOVHViWE2U2baMU?= =?utf-8?q?AYvZuHng9lynYIDdpDKCytPlR8sLQCJYkikRk/lAODEmJp/88zSIb8pLQkjNwQNLg?= =?utf-8?q?Kf4m4LJ6FntUSUZDSfeqfaui6sYMGkcRpOrTxnYWM9IHHshWdR7xGxGXIjzzzM/CG?= =?utf-8?q?s3wKpzvZFUiDggximrJYTmL+KdRHriQwk5WvLzEGTmEBmWSJkqhVErvL+PCydDfBA?= =?utf-8?q?/3JOi3qHzU+tpsYlUXi4entxAtPI5vsDmSkYnQuWHm7zsoVpzNOLaCPjMEnFyNpFh?= =?utf-8?q?hlEWLkjiLtFWh35xyTkf95CvW2AQs4jjde2+xkhdKH3wkK6bXpYHkz9C9jLC/0u6/?= =?utf-8?q?0u70igCVVRjFAGwq1NwquU9S/OrV1qhYYjhUp1r8Ozhn+kSJZpgGTFkjCtewHqY2u?= =?utf-8?q?a/Ai3H0DaMKy9/z1HnhjJ+H6Bg919txCaDQ7GX7ugFyQqTAfgcvguMpyiSo+pBezf?= =?utf-8?q?VFKWvalFwot+zPdist7HfnLMtSiUuEwO97Qg+9BS4Jp7MAHWRcgDDWLpbfpygwK+U?= =?utf-8?q?mCrGeE6DRbseylqQm28hpRZQaohR+Jqt+lwft2NOdU6cRWQUoaUeYVE3SkSsiq90c?= =?utf-8?q?A7ek/I3PQT364tqrXC6e2IeeRiTwUibfhT3YHKwWRL8/YJ5hxeXa6hBjtlE2+YKn9?= =?utf-8?q?CDT2t/K2pxVPw9H6WqZoPmhpOjL4k1mHr8kHlfqMQbu/CQmyFjIhNcdFehc6g0YEx?= =?utf-8?q?2FWphC8N6FKAeNJTcZe/wf9A/Sdj+FWii5VaaaSOGQFR1iqVyqtJ8y/lUQ4lSET8s?= =?utf-8?q?54rvM1U+jXMZjNh1hL2GoJABKD1hZ1sR8g5wTjv2Hb7U5Y7T5HxnYxHohIZRJEWfI?= =?utf-8?q?FKQ4yVltmXazqPpyvCk/WLrBsnwBrMzZ81E3XMzu1QStMMgtBDCCiKEP/UM3eFUM1?= =?utf-8?q?fImQlmymt34+NGGkfyGm7yjXIJvab4rXaKDNk5HteOJ+gtq/nix9p/Fea0Dklvab4?= =?utf-8?q?DYT6EGGCwu2Wq0L0iZNS2tjkwXUVqZdsg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?B1jE/Y+cfFgT6D5ZtQCXyocVSatW?= =?utf-8?q?wTVn3D22S1XFYJCqT7ZUVMFlsIr2ivVZDDUr5ONBCnqv4jt6UnLD8kkQio+5oNI/l?= =?utf-8?q?tyeQeJDhNec18KOEe3gf0xA91zJjFLQ5UWQ0JEeE/qPXg/2073xWXs3isCkSbN4rt?= =?utf-8?q?0jAkvBUdk5SJzViJKQY5iDp/dJQNvnPFAS2tH4JMKoEbyTjGwKPYKHtLi2/d+n46f?= =?utf-8?q?XvEUbRYMYvG0+fxvpXtFveaFbCUsoBA0gmhhWcMh9I60IJ1CW8oaxA2wa1ZUSVVjT?= =?utf-8?q?MxDcFL+rx/aNlljxi/wuaOPczkDX9WHCqXJiTAzuKVGlhKSDw56c7doZx+0FxzVJh?= =?utf-8?q?uY5s9/+OI91WfwDulGZlz+9HfEbcIYsufnCELQMRA1OXIKOjArtfMlTtHJ55BTB9H?= =?utf-8?q?PkgKDcLcA+yYFXWBsp+KfjZ6eKpkwh2191cj627/UMYFSw+w15xndKzXFKZJVir5p?= =?utf-8?q?lUWhVruI6XHvZevr0IDoY8zjyQUGtXGVGKRWU3o3nEJlyr13bVy1yhW0paHWi+03p?= =?utf-8?q?y/3dR38Oz3/ZStEUQRTbWuR8jv5XbQwAKbbXRZ4Rspyq/ng734Id5bqJ62UDrxXqP?= =?utf-8?q?Svj+YfNxXT2DK/dM/kULVz2b6bZ8DTjpnm9/6xg2OtsDUhCDo2SAcQGluYxkPrDsR?= =?utf-8?q?2Y/bLJXjAdO5lMaU4/QnPTjggychzkymZ9xw/FN0VXJsHku0Rlg8dy23WZKepXaRh?= =?utf-8?q?edHRmuaejqEOkkTb8ot4AdaCRHBtrpLobdWUxGBq+h+Yq1M/GHvmXH3kDteC1JX8x?= =?utf-8?q?/7Wo1JOokJWSTLn0nw4YdekQb/Q76uFCXaGKtU7NXVbq5HDV15kViNpA5jVAe7UX8?= =?utf-8?q?FhgrKnRp9UhSA6EI9d8HsQcy/5qY/4Wjqad0j756Mj6RTa8m/O/e1vWI4/UO2Xm4r?= =?utf-8?q?77dJcPF9DaBnv1j4mms/vbQTftnkrQBbxX38AxzOLAb2xN8kr/0Xql8WE80vr5WKv?= =?utf-8?q?Kkzi+BbNCuINnGRaNK/X579mqK0+l0SVPhM+Q5ESMfJ/1nwo4wYbrHtnDNdFkE8T+?= =?utf-8?q?8lF6l9qd3ow5WJQ1chojxjY48Fkoz2RyjarkQmdPgQZmlT42tV7FxnQ4r30/fTAiG?= =?utf-8?q?QNTTHSS65uZQRh9RoIntBctzck8Ma2Z3Th9idwpmS7P46DlRJK8SS1nAmt5GPZT7B?= =?utf-8?q?h3P6GcU/mDjTlvT+yWxQc1qeEOO9Jby1/3utxNvMXgiLIfDyAA0ghGhGKm8Exi7NX?= =?utf-8?q?Dv+4KJWfB9mZjjAifzkh09MkiCIwLv+EGB/NqOWQP4IepWT3snCfZWS+x7T2Igx0Y?= =?utf-8?q?2Mn4aFzsC0cwLFbOTUSftFaoh78E8QWMxpGXHbTnOo/QEYHdleFPlXn2NZ+hmvznA?= =?utf-8?q?VyDo/KwjmARS0ny7mOhfaZ0PsxZHJPCTYTFwL0tTKAfkTcZoenVv27n2H6dbcBwyi?= =?utf-8?q?bwU5FEBMmKdp+FTcFccYJirxBAs0i6vCIVM9Y8CgJhQi+OV1jgpKY7JmmfcWnhcu6?= =?utf-8?q?uFym2EbSqhEPFGZrj/nZfJqQjMn1WdPRpsDLQHzsrgmSeDV2dhepIKE4xgMC1syA7?= =?utf-8?q?UimQZywEE52A?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 952f785b-63df-4feb-ef67-08dd8c6ff880 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2025 07:31:09.6669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QIsOLeGxueiZADrOXGnBJBDgHiEhloVDZGRKZhGYmlkGQZlUwtYPJPf/NbIILYtkT0HlJwRBLIcfH5G33QYcDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7196 From: Peng Fan There is no in-tree user of "include/sound/cs42l56.h", so move 'struct cs42l56_platform_data' to cs42l56.c and remove the header file. And platform data is mostly for platforms that create devices non using device tree. CS42L56 is a discontinued product, there is less possibility that new users will use legacy method to create devices. So drop cs42l56.h to prepare using GPIOD API. Signed-off-by: Peng Fan --- include/sound/cs42l56.h | 45 ------------------------------------------ sound/soc/codecs/cs42l56.c | 49 ++++++++++++++++++++++++++++++++++------------ 2 files changed, 37 insertions(+), 57 deletions(-) diff --git a/include/sound/cs42l56.h b/include/sound/cs42l56.h deleted file mode 100644 index 62e9f7a3b414f6d1bcb651b22f7f8bd1f29b0eb3..0000000000000000000000000000000000000000 --- a/include/sound/cs42l56.h +++ /dev/null @@ -1,45 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* - * linux/sound/cs42l56.h -- Platform data for CS42L56 - * - * Copyright (c) 2014 Cirrus Logic Inc. - */ - -#ifndef __CS42L56_H -#define __CS42L56_H - -struct cs42l56_platform_data { - - /* GPIO for Reset */ - unsigned int gpio_nreset; - - /* MICBIAS Level. Check datasheet Pg48 */ - unsigned int micbias_lvl; - - /* Analog Input 1A Reference 0=Single 1=Pseudo-Differential */ - unsigned int ain1a_ref_cfg; - - /* Analog Input 2A Reference 0=Single 1=Pseudo-Differential */ - unsigned int ain2a_ref_cfg; - - /* Analog Input 1B Reference 0=Single 1=Pseudo-Differential */ - unsigned int ain1b_ref_cfg; - - /* Analog Input 2B Reference 0=Single 1=Pseudo-Differential */ - unsigned int ain2b_ref_cfg; - - /* Charge Pump Freq. Check datasheet Pg62 */ - unsigned int chgfreq; - - /* HighPass Filter Right Channel Corner Frequency */ - unsigned int hpfb_freq; - - /* HighPass Filter Left Channel Corner Frequency */ - unsigned int hpfa_freq; - - /* Adaptive Power Control for LO/HP */ - unsigned int adaptive_pwr; - -}; - -#endif /* __CS42L56_H */ diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index 0201206518cd9ea8ecfb823a96fb59cae37c36f4..9c58d4f08692871c5baf2702c73367287735cf24 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include @@ -33,6 +32,39 @@ #include "cs42l56.h" #define CS42L56_NUM_SUPPLIES 3 + +struct cs42l56_platform_data { + /* GPIO for Reset */ + unsigned int gpio_nreset; + + /* MICBIAS Level. Check datasheet Pg48 */ + unsigned int micbias_lvl; + + /* Analog Input 1A Reference 0=Single 1=Pseudo-Differential */ + unsigned int ain1a_ref_cfg; + + /* Analog Input 2A Reference 0=Single 1=Pseudo-Differential */ + unsigned int ain2a_ref_cfg; + + /* Analog Input 1B Reference 0=Single 1=Pseudo-Differential */ + unsigned int ain1b_ref_cfg; + + /* Analog Input 2B Reference 0=Single 1=Pseudo-Differential */ + unsigned int ain2b_ref_cfg; + + /* Charge Pump Freq. Check datasheet Pg62 */ + unsigned int chgfreq; + + /* HighPass Filter Right Channel Corner Frequency */ + unsigned int hpfb_freq; + + /* HighPass Filter Left Channel Corner Frequency */ + unsigned int hpfa_freq; + + /* Adaptive Power Control for LO/HP */ + unsigned int adaptive_pwr; +}; + static const char *const cs42l56_supply_names[CS42L56_NUM_SUPPLIES] = { "VA", "VCP", @@ -1169,8 +1201,6 @@ static int cs42l56_handle_of_data(struct i2c_client *i2c_client, static int cs42l56_i2c_probe(struct i2c_client *i2c_client) { struct cs42l56_private *cs42l56; - struct cs42l56_platform_data *pdata = - dev_get_platdata(&i2c_client->dev); int ret, i; unsigned int devid; unsigned int alpha_rev, metal_rev; @@ -1188,15 +1218,10 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client) return ret; } - if (pdata) { - cs42l56->pdata = *pdata; - } else { - if (i2c_client->dev.of_node) { - ret = cs42l56_handle_of_data(i2c_client, - &cs42l56->pdata); - if (ret != 0) - return ret; - } + if (i2c_client->dev.of_node) { + ret = cs42l56_handle_of_data(i2c_client, &cs42l56->pdata); + if (ret != 0) + return ret; } if (cs42l56->pdata.gpio_nreset) { From patchwork Tue May 6 07:29:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 887931 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013047.outbound.protection.outlook.com [40.107.159.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F73223496F; Tue, 6 May 2025 07:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516683; cv=fail; b=uMXJKo9xlmr/reTpny34VAdMN4yeXZvSEttJ6P+Kbh4ANk1rkpGv7sly4B9t6+rBsAQQ6ss1fd9vbV2hLe8VkpSY0YYL30DMlgJlaW6jRuqHyMbxNmtSuqn+sWrl6W9cX6WluPsQeKVEtiQjCLYDx19g+niRmFB4Z3/kXdCTX9U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516683; c=relaxed/simple; bh=S7pWC06CgHTERGLLyR9oZMEHCgLuC8Od3W6nbjYt6IA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=g9xtkAt+eXCSs3bhJl5vVOUoRobcpZ3udqc2LhZLjUUrF+VCHJbwGm9ehdSYk3Wyt2Aif6dDOj3kgtBjrH+7nAC7j9JIiz+ZNOUOb089wyLM4FeOGw6mFtcd+s5HqWoncg9wbjzgGoefqdj8sd/wlIuFrcaAwQe6Pg5cBomQhtg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=ZWHeOdGr; arc=fail smtp.client-ip=40.107.159.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ZWHeOdGr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dfw809eOXN9KKmYGx8j7xORUv+jV+hhCoT7XiUm6fgcwdwabTxMqma9xHdayaO4sk8VIP4z6flS/2G3MmP21FqfrFgTD4gZeoHMTk8Bb4UQDih6EfXWEV9ip+eiWoG5FTcwuTPT4PXbgLUqWsNh/o0gCH1SqIoy7D4Zkw85y+eK4M3UPwdlqwP9y/3B7lfZbTvjWkJE950gKFjUPQGSQPHTkOo0EoV5D2k1ScqBDoMQlVKZOei+MB+LlbUCDDGy6znFepv8HTnbeaJQWYyb6zQvdqBav3GTKX96qIFH0o1qKyDdVHqP4eEv5W1cVyTeCkzBV6lvxghU4BNPCbbnUZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IyWJKZNAr7h8m8h5VonmErKx9wkO/meruzrMYnS5gA8=; b=BHSyVNkgw9GI3KVC74OpR1Zc42WUNH6OKl3+SgKsMwiUUOyy4iB7POPi1p84gEyAlxmMw4qFpVvq1FwT8dEPZY0Uai4kBTUJEI40BtK/BrYeNBpqY19KV5T7ZjB0S/tTe0yGLIK+VrGoXjjhYvDerIEulMmpguRNI58TgSqySKXGkf9HIpPKo4rW8861Hfs56fjbwJmtOa3oWfiBZORbOhOC/mq/Iq616C7AlOqM96rHE5Ji//amCHl86OvgHIUNyh4n7537KBSMa786fhFlDSF/wD7vv/kMFtxqV4fb4G49q1jgqG045V2H2kC29k0eLr7hjUM6O6uOZSLMwDzW3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IyWJKZNAr7h8m8h5VonmErKx9wkO/meruzrMYnS5gA8=; b=ZWHeOdGr9uDo+xMYtXZ+EIJGBeRWJiqgeRmnTsbFS8yiuK8KTgw23dv4bu1tn8/OZGzqiGQcCgslMgqgYZduLN/G9jYe3Cqs3+lZToEMjDuqtfuphC69AB3t5SQnW4qUpXPXcyw8H2DrGDWeD3MjScoR+umYUowCRXGCH92dkYjqrjD38cAT7Nm3iFSneSXtgLHvUs7v2heLjNZz4tKAwrES22Ek2U6jONsak57bPvSo84+BOChz/LHz3JQdYjBwF/Q1m2UmdoI46dZa5JbDEU1mzzQLTEoEAbc0lzIX9lN+NGDkIVdok9rff2KcAxk3Us4TGn+QAPeG8nLLRgyddw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7196.eurprd04.prod.outlook.com (2603:10a6:10:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.32; Tue, 6 May 2025 07:31:18 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8699.026; Tue, 6 May 2025 07:31:18 +0000 From: "Peng Fan (OSS)" Date: Tue, 06 May 2025 15:29:34 +0800 Subject: [PATCH v3 4/9] ASoC: codec: cs42l73: Sort headers alphabetically Message-Id: <20250506-csl42x-v3-4-e9496db544c4@nxp.com> References: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> In-Reply-To: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Charles Keepax Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746516585; l=1356; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Rnxf1FYlHnF3970LmgJ+r7F5b809BLKPSEb+eSwkAdo=; b=G+hgAQH7VD1IislyNvk1SALWkxMpwdZ2LrQ7cKwFnmuPJMDNLATqCGQW5FTcvC0l44OVQj+ys spVOZgRUsXaAgwIFtXmkdClwZSBn8lCBUnItajGuq7HNcpS1RB489p3 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR01CA0176.apcprd01.prod.exchangelabs.com (2603:1096:4:28::32) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: b23b35e6-b1ba-4b9d-b574-08dd8c6ffd7d X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|52116014|7416014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?vir5yXiv/IGPIxGdXofioXC3u/1btMU?= =?utf-8?q?eIBC5qeNKjGNfNoENIk0v5Kb5fsnfmmQvOsm1GEELD0n3PjMj7MNGtCLACUy5h3+w?= =?utf-8?q?0lZ0cfBoR6jXZzJMTPiGn2ZkGU9j8Dz8anpGRIvRg1mKDOoBqtkJ1TUwZR1ZDDdCT?= =?utf-8?q?CMxBxzHM15akXKfyhgzVNXqvdKg8i3CxpiCkwA5M+oHPqciK+UAw88CwVhnpsXVYR?= =?utf-8?q?OxqvxIxiYx1QQUF3Xtch4awi8bbfSAkd+wK6WiXaZpsRwqtIO1JUL6I/gO71MG5D/?= =?utf-8?q?m9T6LTRecLb1621VTmODEnRUuljimmCLkC0TFC5PPDd1BjWoU2r3csr/hgcSzNKsU?= =?utf-8?q?DmxhfkMN0UzBlTG2bvsyMhHHY/8Hfo8+nS4VcZtlJMDXQO/CfoFA0zID2uGDc3EDI?= =?utf-8?q?4+NaRXNRYahII1TaSbMbrh9YyYuDW8JxPbslaMXlrXQ20Xs0ibLkxlbWeyvP6zOuR?= =?utf-8?q?NRpYjcuRNg90UFWx6s5ABDFHEocLQGcApdwOD1xRIITWo67uWV2y4iNfsmIXlgFkI?= =?utf-8?q?BCdQUYJR0dSdOVA/rJBi2NL9pi9Bhz+QNIPb0yo34Mst/oe3oEm+GZWKc6xkG4S6f?= =?utf-8?q?7iUjONgkXdljQ9igjy7BDDUtrV6+XPMi7DYVo9pwMrSyz12lrl4T4qDf1Ue7rM61d?= =?utf-8?q?8kAylgZMkdvlKfCwt+0H+RkprnfsMeceYmFHbO1Yj4GrJ/yh+PhimBrLvuDFjVo8Z?= =?utf-8?q?V/wlVxef/GbSwICI2cvZbutebav0GW4xpYezVLVQ2Rlu51I7uAkHnuSfbtiSzedrs?= =?utf-8?q?up0Tt7VvCbAxVAdpqn7zApGylmMvNNTsapPKGRhCYFkXNtoeVS8d8BGofjGvvsEkg?= =?utf-8?q?z6mnIcR9mi0qRS1JFI0FWHYWVqiQ76Udy21413S+eCDyo2UoIv/a9C/JgG0bUuadN?= =?utf-8?q?ZxMAPw6EsiUz9lnIZZs1uvNmn2k9RyZCgQyRjz5mNLtHVzFbbDJhn3o+yJJ9aZDHh?= =?utf-8?q?8dNJlV+N3PGWQFdtHFA3FlyssmyLmdupwsxnP7+/SemR8au//igHkc973as7QfmTS?= =?utf-8?q?cUBPoBdbMPIXA+bDPahMYSKYkaSmXwtRwhS1tdMGdme1OShEFe+nZbWTkpQoH5ug/?= =?utf-8?q?BcPuGOXAiS0jPO9nk3qAC/UF/L33vA3uDxT5sGz1U1NpK6tjIMxn5CmBfc3/5BUlH?= =?utf-8?q?/L24U2laReiPtCStJ2wXdMU9xWh+VwDM71JE3lJBX1GALTnW3VmLiAEuYa/p9bRh3?= =?utf-8?q?qJ14CGnZSk6mIjCi5ivXZgJ0RitLxzkLNyXWO9oWlfWB+9r68tbPU+2KITdqdBZ7S?= =?utf-8?q?cTMJ5tgZFdLDDtrqDABiCihpn2eW7viliNdm50k7Fxhs3z1Tpp2lkc77IhrUx7E7J?= =?utf-8?q?CfWDpcIwufjyW35OraRQeY6GGQBVq2GDNqrfh1K2EziVT1eXNJTEks2C0eZ7crWYh?= =?utf-8?q?MaqKVjp0JSjt/nrEcJKjDBNkpMRJZfs9A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4JRpjdtdmdMyLlJ31xLKvtn0qKLS?= =?utf-8?q?40quF3kTeyvVPYPWJi1NNvb6qC9cUuwH1/Fz1Y2MzMu6d554I8qOLVO4OMvduamqy?= =?utf-8?q?ZOVHZA5qLh93XAptJdqqy/5m5v4DWLfhdYVxIRuo5AFGh/en8u6+NXbE/meHd02Ue?= =?utf-8?q?PIDu53ScFKiWrYspXxWAoeeo8xgV0Unm+85GdUJaHPXYjD6eVVfA64zYmBE/3Uri6?= =?utf-8?q?6Tq6qrUgyRuBrkAo2iiULBje1iZy8BGbqmLnMPCsKr0+h7oZPkThd8CiMUYkCpDH5?= =?utf-8?q?+D5/02+xm8jiRzEnw1clgVh65xqw8irc7QI2Rr9xuC/Kx74+Cti5CeWA/9m/ceFOB?= =?utf-8?q?p2R8JUkal3x0pWYxcaG98sC461lbVKwCHlKt+niVwupzOSBIgAmGWsVTsc6dPTVRa?= =?utf-8?q?/1TRg1R/adfnCLL2wibQ4sTCIZ9kRQdOje9tL+kabEvYmiPWc46XgWvkz9ixmCEDK?= =?utf-8?q?L2xi1z93i/mJ1ZU5ymT+b/eg/R4eFI7y3s1AxKiL36gfvPjqnrqdQGM4nyUfU98+k?= =?utf-8?q?WFPyZDQ3PakC5+SiDvUruRZICNhaLclKwlzTeHc+ejYZXqc6UcnKLN+hfGACzpO4R?= =?utf-8?q?ZUrKHNjL27XRsPFvjt8b0X0t7EbJdzEei0k1Yt2qfvBLEZyHYYcf3ades8fUrL9Dd?= =?utf-8?q?7Fcev8zsX6lOlxJ+KW4puiOC6OFyMmwzOlXkoHt2WQ3AcOngTku/MWAd1e0XswsTf?= =?utf-8?q?R4BKV+kx3KbNCwFQ3XqVWT6x0ih6b2xGF3FMGuSMMdc3ZddNIEb3WqGQmDTHCZAVU?= =?utf-8?q?sbzLBdbi7gOwCkj009vwHa3cJOlsDSdRovbF0znA6372zUh6TO0yWk+4qIVJJDrrm?= =?utf-8?q?llV2pJmiwXv1gjaFB+J6re8BJfRlGMQTWs2d4phwky41eyMp+KnUVNQUjaB51HlB9?= =?utf-8?q?aW3uW6zyhsHCNKFXQru1Kf/Ngn40WsXgMSvJ4bnsDn1gdMJscHRXpkMY4ilW0JvCf?= =?utf-8?q?MMq5FQXHKYyHvyA4nE070yVHD2xabMSL92eo82LqZDtE6kLKnnlfqXfoEMIMATutu?= =?utf-8?q?Xr5MH+dNqGETTsMvM51JLHIkQh5RIZapx2EjECIzKeMTDa3mXEICwQ5VZqa8CnZYr?= =?utf-8?q?QOf3863a+iuhciHPwC5jbrPHxbQgn2YczjgWlutF0t1QadiZedQ07FOS8tITOdwO1?= =?utf-8?q?CXflM2/G0RFAmTO5YPBHW2wCis7GQpLV7+aA/CFiNbGP5/RLRX/HorV3xplHPnkRr?= =?utf-8?q?3bRWMCiupasHAsOJXtwLsEbpqlK89mvvQhSKzygWUNM9W8Pkvj7khpWRWGGb9Vdi0?= =?utf-8?q?bXh7ikYKciFjicSztcGoiSvBpdKgul6LvRvo3pjmNGzOtq0y5TmWSI7RR5y+Zg4cC?= =?utf-8?q?r0LHO1Z9egszuxP0+veSJDRPRj60PrxGXf0ppOZNwo5c6PexnJhPqCT+7xHs+TlfN?= =?utf-8?q?7KgtXrCAf0GoxcB6+W7BZiarRzH3Wdqdtv46L+cDeIJgRNtS1ZY/JxqkJULBj6iIN?= =?utf-8?q?DvCxZvD59+MRxCrMOEqDBDxj3FGXuG15XEoyKKDhcBt2iEDRSE/9ftDEgcBsWazlV?= =?utf-8?q?V3Xr7U2Mx3+v?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b23b35e6-b1ba-4b9d-b574-08dd8c6ffd7d X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2025 07:31:17.9783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bh5PgZGk56Cg7GZErUV5jILTbysdBpMCY1uv303xN0FHuJZu0kwS08Vjqx1ZHaHpvEFCoeh4zjCXPj7wCc3Jkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7196 From: Peng Fan Sort headers alphabetically to easily insert new ones and drop unused ones. Signed-off-by: Peng Fan --- sound/soc/codecs/cs42l73.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c index ddf36001100eef29f74f4d99420511f620f1948d..556270befa941a69e17b47a15677e1c4f912b14f 100644 --- a/sound/soc/codecs/cs42l73.c +++ b/sound/soc/codecs/cs42l73.c @@ -8,26 +8,26 @@ * Brian Austin, Cirrus Logic Inc, */ +#include +#include +#include +#include #include #include -#include -#include -#include #include #include -#include #include #include #include +#include +#include #include #include #include #include -#include #include -#include -#include "cs42l73.h" #include "cirrus_legacy.h" +#include "cs42l73.h" struct sp_config { u8 spc, mmcc, spfs; From patchwork Tue May 6 07:29:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 887930 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011059.outbound.protection.outlook.com [52.101.65.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D9D23C390; Tue, 6 May 2025 07:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516690; cv=fail; b=RAV+s91bpF+FswcPo4k9AI6oCup1vUXbOkrv1sn/YpiyFJncE3lAjDk1SsZjx+3igj3KXjXRJ8MZKuUoFGVwbcperOZimW/FpJF+iXhERO1iZrYNuKYKkzjI/sS6xEH77xB37UUc9b9TckT0DarNYCL0IlQVNb+XYrr5W1hU1aI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516690; c=relaxed/simple; bh=loGsb8BxVV8cN59KlSXd4XjQDzgQcKtScg539R8bxEM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=LuHWV2Lh2uW85/SV+YuzXw/jFUKUgOtXI0Hsu3zfwbY5u5jfqVoZz2pJ9mPDTqJa1kXem1pybN5A/06X5o+tuJnfml/6kK3XEe30g/DM7BhQbvi1ZFqnvGSMkpN95liYFUHaEtnMOap5eYopn/VZv0y/3BwXPK4adS+re5IxrcY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Kd/jIUZt; arc=fail smtp.client-ip=52.101.65.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Kd/jIUZt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X1N2FPBuYeHamzwWu+qqu4ZP0Nr5DrJ2qVeN9S0Q6BTBkFTSRXnH9o0WUlLQPtenND6ZG5fLb9Wbg3hLi4GjEir2DtITHxOLSu9DaH6wy06TCh9iI7mgBV8gYmgcWHDblvvivpm0qi3axSeUzx0WSoa2/4JjREUlcPw+NOM/s6jIBlffglrJyfo0TYz4vTWi/R1M3CdP4xN1NvPf7cX+ZrofLxIyoz2Z2KnaMcdeYNMl90qJm3ecEhvWof66krz4+DQZ5Yw/N8jiimeCcIeMpYhDNCN2dAApKQywNa7A2t+H1peZ9byxFiXf/p8DxdHLlZTc4h3X2dj56mOgG07Ozw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I6VsyhUjYzbIhuCFZYke3WjMogqPQM7yhWcLNVJYzbQ=; b=jFFpzGwwBeRAjFNguB8V200ssQSUleodR5BPjozrvAOMIRcyyZcBYrXsiUgeQRhbARck52C+0Gifk0drL46zErqlFoLRtm2seeq8FNNnXT/Aq2XiyFqrx94/6xiGyxFP5gzs7ZNOUQBCGbMfiVZr2h7+k0AI8LtUv033t57Ig41wCI3VKG29+uBVh9Mdmm2kwGMer1W43vU6XFd7fM/a8MXHiREKEG3VyEf3/6zDJQf4kpczCswwGyZk0KzUldyjj4bMDnxSLLZhpQ/2e8TXND9e3CXLlQsZkkip+4+7DiakctDCmrgZ1nhjc68r9XeEChyIrerpKAFOavyY47jZiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I6VsyhUjYzbIhuCFZYke3WjMogqPQM7yhWcLNVJYzbQ=; b=Kd/jIUZt0ghKR+1AAL3lFXGpgzRwsFSi9J4OONQnH4bJGpVvwOpLknbBaR3q+b0ngE3BNIqgvLMELDYqb70H/oyPp8twHMIcFAh8tpYUrvuBX4133y0jdiqxCB+7EZMYJfLTOvTeg8LLQKR6I4Z4QUaCZreJufozuO/uvVIBmSDoRsV9XYWvZQpWxa22o1QmnPKR0SAzsAyCWOQDt86lDPuZvPb1JZZSQc5QBfXmHibpDPMQjP769+Ksm7t3jqyNnm3tAnPLM6k0UzEAiTtt+Tq7pARDumfiAaeX462QK0n/9j/r05chXJpiZnzhAEY4dEM9RJxIAssBU+XPpFuaFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7196.eurprd04.prod.outlook.com (2603:10a6:10:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.32; Tue, 6 May 2025 07:31:26 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8699.026; Tue, 6 May 2025 07:31:26 +0000 From: "Peng Fan (OSS)" Date: Tue, 06 May 2025 15:29:36 +0800 Subject: [PATCH v3 6/9] ASoC: codec: cs42l73: Convert to GPIO descriptors Message-Id: <20250506-csl42x-v3-6-e9496db544c4@nxp.com> References: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> In-Reply-To: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Charles Keepax Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746516585; l=3281; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=EJwDsMlb68b2TeHr3o9byLSOgFkhPb3M5yScw8I2Ms4=; b=B5PwnJETGNUr6rUlwhjL86Oddm8Jhy8HPlS/c+LOQE+AZx6AzSxU2ywKUt7NOEKQQKY3KdoyD AA8a9+dzkT4CuOtpB/uSkYZTmum8Q433qtCWGOjM0NNg183vhBLnUSn X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR01CA0176.apcprd01.prod.exchangelabs.com (2603:1096:4:28::32) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: 61fac5d0-f142-4cea-177a-08dd8c700254 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|52116014|7416014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?6R0PUAZxNO59szhKyFwbWK3PT8fPSVB?= =?utf-8?q?jECwKLkw3a3KcS8aPGf0TZlR4nhhBXgBYND+ucHDQ/i0YYiCkvhdJX8VW/v92UbvW?= =?utf-8?q?nnv5lByOyyb9JmPWwUH+dMkfuwUKiJQTFUPm8kuDQDwziSQ/Jg/cWuIzW8bkZoTgm?= =?utf-8?q?lY+szZer79InOEllVDgyfjpED2AGwkleZaGqZJ0n842EdwupJbRifgCDyX8I/PAuK?= =?utf-8?q?bPafN2kJzKZseOoBh/QTtTLO6qmv0/Ox1IppK7MIK9dsDDh2kmvQeh72z06HvTKJ9?= =?utf-8?q?TABUcGETDRUvoCQHEQT+rlr2BXT6QI2i0Aqv5hfmEjTgBjeozNLL8GUNAngclpsKN?= =?utf-8?q?u2SndGLboJniB6BIwxRAH44ZVQPJPI2sNS81M36AiqWnreexywobaOHOrnVRwrgo8?= =?utf-8?q?iDdkVSAuwsoVlRVLhKyb+NxkL4AprU6lSDBVJivTXOQ+f/1iFMeY2BJPIov6eRuMA?= =?utf-8?q?D0r4wZslvIhlM8A/mUNnFrnbAloLolQOwVKNEz7dbyuVYg/OBhe7525IshPdPB+3W?= =?utf-8?q?H0kkJDuI6Ec0IRaweYrxTKYvIk2Da9zwojeGSAlO7itTwHtssumomXxyWgrq4Fo7h?= =?utf-8?q?o8pAMZGQpqAk7+HHcEzr8MDloMEn82hwTJ4F44nOWZT3sCXQ0Pg7qAph6wf3o6be4?= =?utf-8?q?McxIrdO7VKf+bPx/A5vqNIKWbGu7n7YL72lLK8jiHZbJOlmEb/bcNmoB7YM9Qh6C5?= =?utf-8?q?86ZezKvlrx0GNWyOIWv68QlNKkMPvG0ZeFYti4jqcytqN8XVC/5cUbHsXqO6XshbJ?= =?utf-8?q?I1tizG2sLt425sPwnZhXA6o2W8VGl7eje2BugGJxptqZVtSxnl+Pu0adodSXF1Vyl?= =?utf-8?q?P37H+XB5E5JNztKgU/B+BMyz62sAc8vQqLzBPIV+ZEOvvXloODQBDvB4wHq7QHxED?= =?utf-8?q?fRF0XCh/iV9DTYvvlpTujE4M6oQUS9+hCljDL8NXLtF1wHISL/b/ZwNHQYoulEbed?= =?utf-8?q?Cfn8CGcxwZ0+XMDVkBV2dg4QoagZdDkyY9DWI8gabJs3DaqgwRmBask1ztb9QL/NT?= =?utf-8?q?wIVVhKLFOzN4Jl2f1tQpMnf4KgjUou4vUd7T/riSvyzESjuhJ6TJi2be/TXQXVB5p?= =?utf-8?q?WEiTtmoCxf+wZsIPG2dmBOCnEz9iwy0RzmNCkr8cNv6oYL14swx3vyuHIRV9cnVkr?= =?utf-8?q?y1ZoEwZXE3U2W+33/AOaygwozYeXNffMt+9Swiqjcu1CVOONQCemf54JnAPfQZGUK?= =?utf-8?q?nv1uAI5IOgd/vsfu9nZqmyi8pEyTgiZ/wjkiznp9AUp3jYgwyHDZBkVRjrxIkZawg?= =?utf-8?q?vIHwBFPwLAmhdxsDm0QuQGdfNM21cfGpvgyGzyFnYMM60uENC6BfbpqcdtWgHqKL7?= =?utf-8?q?EqMnZ/o35x82kVDbxQ2KgEnmvVBBASJEeCZbmiI9pyVPD9RYUjMDoW8l6fC7IP8Lr?= =?utf-8?q?GB04ckBdDeQhPIJUNTgeE+7etgOZsNlLQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?LAaTUy69aHQuqRNJm+UfRKxnCkPL?= =?utf-8?q?nHJCmjDpR4zH1vPOICrtTwKWKNqJSI4E4U14MPd+rWJYADYVMNlYEmjSuLP+PlnSz?= =?utf-8?q?jVUMyGD9fo1gt422izmplPOrxWY5W7oLeoFgQtuEkn9b6ymdwCPQbYW+I3UYaKdhU?= =?utf-8?q?+h4ijVOspVdb4gbEojhi7B06cVpHAkp7KNdb2KOYR6LG7z+mVV3z7W/4A7WFlPDAI?= =?utf-8?q?uuD51kIeHbbdJQVeZw6FDiDXIu0jfbF5KDMfsfqnp4U4Xz1kXpDnWt64Ae0SJcI0v?= =?utf-8?q?F0h0eSE48dqmwgKi4ejEJ5suorzAaOG6zzXKmrUyC4UQzqmCJY75vU+yAJSbGgJwM?= =?utf-8?q?Dap8i4L/7m/vPfItbN4t9bzsI9boAR+bHcMnKhEoDty6pXeSmf7AcSf7txcQv1x8Q?= =?utf-8?q?VefDqHA28GyIqPGyQHq0Wua3k63UW3i69i31UeP50Fprgt/bAkm7ykNOAzLoy6we1?= =?utf-8?q?zHpOQ5V9WXtOhtScO9Cs+KD7qqhNec12xWZM6yyxRaBIrDrM3NXxZqtIr4Beij1SO?= =?utf-8?q?asS3EZ4Z9x/XI2GTEbD/PpsYi2rEbmNdl8ThefXWbfwZM52UhhLOrTO1OMCuK89le?= =?utf-8?q?bBuPTDvFNZiGuOg2XQgldtEUq2ECeOw2HMKY18ehjLZ17ICiS/3dlQ/du+iTGygE2?= =?utf-8?q?+qC8pUWT7rgrssLSBaNV8vXlLTwdFcy5SR7NF6ygJ766Pgl0o38zNXm6pcEKkMY+I?= =?utf-8?q?1gj0npFCnspS24ogMkx5snI7vI9NpJnjnpGroC8FISd0s1KZmbGm9uTHbd8nTvrVc?= =?utf-8?q?ziwgO9BcOc85cIuKUWpRSFiNTTcL3PVgGOhfkgRjm4FwGCK0il2x12m+Q2+4z8bs0?= =?utf-8?q?CCBFHIY+0O18mETJ7gRJxNtrTrzHEIAGxv0z2JmGiF7Fr3qAOs9vUzfI/xoKlFLOw?= =?utf-8?q?EMh5/wfrtY7x1vYIgJgG31OApyc2d7j7xpBTtB5qHlsUiwxB4dC+go2HrSTZHtksx?= =?utf-8?q?hgbEl/WNYVRmcCQ3ouo6rNzyCvTc0jkPigrh2+R+TE3yNE3WNtMih00Wkz0pOhom/?= =?utf-8?q?6D8BXxDYDnbsgoLpoZwvIsuG3GgZ90xznMGu4xaQO5PYrDIY8VLX/VA0CSSTgBOcn?= =?utf-8?q?BFwTQ06p4jCVvyozu2KbjmSSlkJSNy3wualuI07mbdEmRnLlVUZkRMZT1iZ3HIE0W?= =?utf-8?q?XYNQWiOVK6h2ZgnwjmWAL7d06ULSYYt77Fa4STTI8NYY1g+NLJU8IWfKFZf6BuEd9?= =?utf-8?q?wsREJaWzZI4t5z0utnz2L+BDJtOsPg+YqQXOt+dmCOHiy6aAoLhAMDP2KGsr+o4Qb?= =?utf-8?q?26WSENLVLt9+oJhP9OBi1xqqa823XJGZde+hhIixkO89aTB/rYmkNHqjJLFSXB9fl?= =?utf-8?q?Rtitk5SJmW9p3j5Fi9ettwH+pNEeyBv6RSK7NqAYArX1Z9bmQCXTx6pVIzpvi6G11?= =?utf-8?q?wZJn3cEX8tz+CYgh5FEccdTKSMdlHDJt1Clq9Xd+HrZpqV0uJFTIk02BB61eyb/gt?= =?utf-8?q?chn2t0qi8QqYRQBaDgxlezM4tHwOgOjYsOlCfDoO8YM3N5r1oKDk5Ho4n/8VmOKd0?= =?utf-8?q?4CL8HJphenlE?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61fac5d0-f142-4cea-177a-08dd8c700254 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2025 07:31:26.1390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SMVZ1sGK6vayxarxDPSlyyEg2nrIrfeXfrCsWBRuR/Pz75fDkNv7gCj/CJkd+K7Kcf6rf+sDexmoCl5h0QvB/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7196 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use devm_gpiod_get_optional to get GPIO descriptor with default polarity GPIOD_OUT_LOW, set consumer name. - Use gpiod_set_value_cansleep to configure output value. Checking the current driver using legacy GPIO API, the reset value is first output HIGH, then LOW, then HIGH. Checking the datasheet, Hold RESET LOW (active) until all the power supply rails have risen to greater than or equal to the minimum recommended operating voltages. Since the driver has been here for quite long time and no complain on the reset flow, still follow original flow when using GPIOD descriptors. Per datasheet, the DTS polarity should be GPIOD_ACTIVE_LOW. The binding example use value 0(GPIOD_ACTIVE_HIGH) which seems wrong. There is no in-tree DTS has the device, so all should be fine. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- sound/soc/codecs/cs42l73.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c index c09c23487d2e73340b8947ed0e1ffadb24414e7c..535a867f9f2a6d32986190c4302dfeb1e9f06913 100644 --- a/sound/soc/codecs/cs42l73.c +++ b/sound/soc/codecs/cs42l73.c @@ -9,12 +9,12 @@ */ #include +#include #include #include #include #include #include -#include #include #include #include @@ -30,7 +30,7 @@ struct cs42l73_platform_data { /* RST GPIO */ - unsigned int reset_gpio; + struct gpio_desc *reset_gpio; unsigned int chgfreq; int jack_detection; unsigned int mclk_freq; @@ -1307,23 +1307,19 @@ static int cs42l73_i2c_probe(struct i2c_client *i2c_client) if (of_property_read_u32(i2c_client->dev.of_node, "chgfreq", &val32) >= 0) pdata->chgfreq = val32; } - pdata->reset_gpio = of_get_named_gpio(i2c_client->dev.of_node, "reset-gpio", 0); + pdata->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, "reset", GPIOD_OUT_LOW); + + if (IS_ERR(pdata->reset_gpio)) + return PTR_ERR(pdata->reset_gpio); + + gpiod_set_consumer_name(pdata->reset_gpio, "CS42L73 /RST"); cs42l73->pdata = *pdata; i2c_set_clientdata(i2c_client, cs42l73); if (cs42l73->pdata.reset_gpio) { - ret = devm_gpio_request_one(&i2c_client->dev, - cs42l73->pdata.reset_gpio, - GPIOF_OUT_INIT_HIGH, - "CS42L73 /RST"); - if (ret < 0) { - dev_err(&i2c_client->dev, "Failed to request /RST %d: %d\n", - cs42l73->pdata.reset_gpio, ret); - return ret; - } - gpio_set_value_cansleep(cs42l73->pdata.reset_gpio, 0); - gpio_set_value_cansleep(cs42l73->pdata.reset_gpio, 1); + gpiod_set_value_cansleep(cs42l73->pdata.reset_gpio, 1); + gpiod_set_value_cansleep(cs42l73->pdata.reset_gpio, 0); } /* initialize codec */ @@ -1360,7 +1356,7 @@ static int cs42l73_i2c_probe(struct i2c_client *i2c_client) return 0; err_reset: - gpio_set_value_cansleep(cs42l73->pdata.reset_gpio, 0); + gpiod_set_value_cansleep(cs42l73->pdata.reset_gpio, 1); return ret; } From patchwork Tue May 6 07:29:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 887929 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2056.outbound.protection.outlook.com [40.107.241.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95DA523D288; Tue, 6 May 2025 07:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516700; cv=fail; b=gCXXQwl9OW6DJGoT/N6YASUNEBmi22FNjl8DPQngILeDCunf1NUl9bTTYD6snnwLK6VzJKzyxJx+KLRLVCGTZXYn4g080ZMqvXhpUZWmKIqftxCSdDyd2a2y7h00isl/CpC55efUa2MwSThI7jePdAf531tYa4E1A/DNjupfhm8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516700; c=relaxed/simple; bh=hRlT3/ewzgRHoWAAW4auCAg3K5hopTijr31RLhkkEZQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=IzYmNi3nDj9SeeecrFnXuTVOQo3l1RFyh/XRUcHZE0E2NPX+ooE863RTZ4WJFVKrBueno5KdpKc1NCauuclIdUrkZ/xm3lkVeo2h96rDUuRWIUJb8GlzE1RnsUTg0e+s8wD87VDuXje1G0GbGhOnWHerhfEed1W4uqu+VeaRL/4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=MKiOV6Fs; arc=fail smtp.client-ip=40.107.241.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="MKiOV6Fs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YtIAMSghBUi+yYC5c1BPltiBShOQcag9F40Pis9xgut9Sow7eGOWBKLFRYKohnzdNHNTC/8jMpH/tk6yvKlPpYSeA+Tno8WI7SwhMyXuS3IILk+FaN9HobMAA4FeLPDNFKXQAs2hNCHMQuk3BdPrAJsOVJlgAn9oGI7GAdg64RkIyUfJcCE6OZ3LFsaVpN8kK7J832ZxWNeY+SbfoxrIHv55iOL6DuNttvwswR4klo1P/WfJM/666USxDqz+scWh4oO6ozNZj4EkD2ps3KJXZvQQp8H4uMRAciEloZzR+SSyzu4EyqaLWZr0MRSWfpAOajKFFK3USJHny7yjf+C0Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NzIn22C/bCqKKCp92PT/0N8Qjb6tiddD259dSvsaWRI=; b=QKjB6UO7C6/LHQ6P84T+xcojwmVH1z/GOf3LHJT3EpH3foNZyihk1cW8mfzYhyxnqwAxEXNLhFkRHqXL7ttaNmx/QPgry+beIxCN0bkfvr/VWR1L0O7T5WPXAhaUdOkgJZyrvg+VQg6dciowQygXU3Zsmhbx47RhyqpCUIbHib8mlJL7dBSQURilAYPNJLzXTi2RVXqJ4/J/k2ncHUoD3i9LnWEzTVEHdAa7cBqjf5nfy97MXwYI4o7XTLlBEZBeKKRd/iwF0Y8SeXoNpc7X+ocyWl4n7OROhAKFcWlWeLp50S2KskFw9Xzv8jCWyUw8J/OiX+uMnR/DapcQ5YsnHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NzIn22C/bCqKKCp92PT/0N8Qjb6tiddD259dSvsaWRI=; b=MKiOV6Fsp22wra8VXiDxbyo+hMTNTym4q5vU1xdu8LEJLX5PKRE32OK/RtJo2sElTSj0Y9Jp10ETbStzEn06O8R1EqFz2GOF4zZjrwcBb90UDs85mYGkggiEiGwg3g8YTBeUDidTwCJTnovRm6pj9xKijfJhmTpsxmi2sQwnvkFVC+asSRC6sHgm6i9B5jh3gFLskPiZAclsBL4BxcSAa68vkuv+pNlKfeAmBH1QzieVuwdvlS4TYt58MqybWYVEMvssHlSk4j/NGCc5wQY6cxsGG9Ql9nCCRWwZKJjBq5PQaaRegii/aSJSTfRvZ2Orc0P9upqcDFb9ILLAoHTMoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB6881.eurprd04.prod.outlook.com (2603:10a6:208:18b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.26; Tue, 6 May 2025 07:31:34 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8699.026; Tue, 6 May 2025 07:31:34 +0000 From: "Peng Fan (OSS)" Date: Tue, 06 May 2025 15:29:38 +0800 Subject: [PATCH v3 8/9] ASoC: codec: cs42l52: Drop cs42l52.h Message-Id: <20250506-csl42x-v3-8-e9496db544c4@nxp.com> References: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> In-Reply-To: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Charles Keepax Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746516585; l=4795; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=+Vvp6+/DXS9mmi5+1a0ljPE8nIjFVG5lF9th4X+L+ew=; b=bpVRN+6qqhc+y4Ln3HuGADcsqcMd30Dmq1KF62uOiUGFgAnXQTIXb5j7Pigf/F0uQLV3PXp9f 0ymeQiOymS6AIyRDI4YPR8EN5nGCuDxS+dRwGetw1hzWkl4DhlMOZRU X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR01CA0176.apcprd01.prod.exchangelabs.com (2603:1096:4:28::32) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB6881:EE_ X-MS-Office365-Filtering-Correlation-Id: e358fecd-7c34-4754-47e1-08dd8c700731 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?HEw0VghCUBruonQUxhGfiux9FRPjmNF?= =?utf-8?q?6EyMbVQ7Fvz+9s/YxhsP5326oKByNES+IKCFC578ISByi3KLck0e+Q9FMJxiVSx5u?= =?utf-8?q?YdZIx+YcmA9WVYCIxgo5ALpDvqTvHUoDfRSBJ8+rMc/0/NftjMTyx6Z4uCEUcxlji?= =?utf-8?q?QBy6rUVxmE1os2lnOIelQJuRYOygIDf3TZmoWWJwqCbhH//H1CRHKqQr8ssBB9y20?= =?utf-8?q?y+QHFjdHNIEpXtt39+suMQjFxwlkH2pAa/ZRcg8hmP9VTuUDLvn9W+GMLi08W5f6+?= =?utf-8?q?9054IYgDhuKwCjGvfjUVciZy2yBZFhw88ysHkmGxWL0xQzGFABTzRkP6Kcr8GirBV?= =?utf-8?q?4d7cssWQ4LRJ2z+bLB1qMpTtKX5IH4+L2d5dbnTTfbycynjHfEmz0hADIR2I3BIse?= =?utf-8?q?mjy2C3hHBKEPdFPF7WTeUTAcnii0Q7tCRUbfZOH0ZGTN5sRJHlqzrbYOEw1LsrmSh?= =?utf-8?q?t6Im2GEkWo3G3j8Z9g0HnO+6GAnggZpthpVzIIRm3UG283/lZ7KmJ/Y8NmKTy3ePt?= =?utf-8?q?J2HaFqouY8wzY0/RcjfYNRHWMKWIn3nxXG3mP/PDJqX0yRnifpqVG/IoGa0Ib6sTw?= =?utf-8?q?6MDWhQH/GvIUzzKQQ0BOar81tZKPJ3WCHhnXmf0DTwDBZeNDHC//OOr0/P4Q/q/zM?= =?utf-8?q?vT8HhzkLHAlkifTxlw+suc/7JZLLSRPO9XLjgsoHeepSR0CCVpjuLn5YjtHYxIgmH?= =?utf-8?q?WLPbssGNOVozB7qbBCsPjida3T8B7040JvWCxfDEHjr1bnL4NeHs0naUZMvs4Foo7?= =?utf-8?q?u2OWO1hVMw/Kq/d80enr6HvD9rTWuFjtgAPu08ES5AqGp4vTfyi6qGybMABos2mBx?= =?utf-8?q?gje91SZ8B03q9LQcDBQX+YzS4zbUTRfiXfE4loaWYMItOyCQ56LQUPYJS24TKG+Vf?= =?utf-8?q?g5DHU8PUkVo9T9P1HKwGiZpvcCebjv69F7UTu9L4aEFuexm+XB5CnNs0GW0K7iWZu?= =?utf-8?q?MSh1K+6PLgL1QDRi5ZpCAFfrFiX+aQdfb4uuNmIDVVmbySBeZymRtiiIrM+b1x9ln?= =?utf-8?q?1wiVG+KPO9aPXRpOOrQDwXx7ElBYYraputLRUVMTu4McG06O+KCPI/yVYdHLeAfWk?= =?utf-8?q?QBL94pbPax3NTrojqu7iJf83+IEZST5Py73BKR+nkP8eM2h/Y9JwSxqXJTBs5RDOC?= =?utf-8?q?2gLnynmHYheHl+UuDWov396ge/m60AZU/ZWT10J2z9hfFWE7UkSA3uOuTzYXwSIbq?= =?utf-8?q?wYCxB7HFvGIKnNfshRbpx3tMUvqxzsGbF2wRIObTRq2zSFz9P5mDraGLjZgnFEh2I?= =?utf-8?q?0W5lBKf3SziZ798ol7K0ulyJpftDnreNG0yh5MlH+MST7tvOnA79EntXfvLL1w5t6?= =?utf-8?q?EZ3BNXel1bV8Vxbg5cO0OsWuImqPOYWXfoZPl89agob1QFT64GBExwk5+v63PazSx?= =?utf-8?q?DQ6wlfDLK9dC5FADCCKnVIGsCAsLyu4TQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?LcRIxG6c4LBRo6u1aGNF6Tblkvfd?= =?utf-8?q?o8VVzGL0tF7LHHnQ6cpO6bz2yzIISo24racQU7jJ7K7eByu4yQjTMO93fP3Um2U4n?= =?utf-8?q?kUwm59EgP8rhpQfVl9ppEy9A9qAya9Gbw701WNk+dO378sRx0wI9+IbSm41jXuANw?= =?utf-8?q?7DRqqWN32wx+4jxo42YLHpJVaKdRwEYWyQ1ETv5pOXbmfo7cqXsvkjmWff9WgFrO6?= =?utf-8?q?1ZKNrq3QUKlWIEdYA322KcAhh6tWaCL8Bd6rySSRTwhbQuPwM6LwFfzd4JzeaVJiI?= =?utf-8?q?htcpjWoHMR3GSraBDnO9bE/mKTBKYYjkpmBU60h4gsRZhUwEqQyIqhmxVwf1Y6vAE?= =?utf-8?q?ePmc7zyE2julOTILqavH1WBR6dQEkLNdHfyxpMQbQfrg83VhDwEfXwwVcgY7F14UW?= =?utf-8?q?9xAJN5Idv1xKdvGxJH0sjTiaHNgcVPEUEaMI2aio97bqy2nxYPO9c3JSUuzCeQAp0?= =?utf-8?q?qzZiJbyX4iTSN/HU/ZE2Px7Tnn1ctHXD8sqsmNhtTFvD3WCrxU5wk8JX5zy0bxBZO?= =?utf-8?q?oL2YcpMRINtFR9yGKTgYTC8ePghuU0RZRrx9YTJOODXXxIrdtuTHhKPRSomZosYOg?= =?utf-8?q?2x//pNbf3cj1O/pH1WuegqjaBN3TKaC6MdTyKZoiK4+3YvDrFJK5j897S+FTH7EVs?= =?utf-8?q?ahPhs2Ck39n4FQe1R0cC9jDIiIUVAGeMFVvFJaYvAZnj70Axe5Koj/VQfzfVPhYNU?= =?utf-8?q?v6NEmw8SDXxG1odmRkqd1U9aylzA49miamyifWj2Top22bsCPgiVYr99OKrzGGWLf?= =?utf-8?q?mG2N4gixB8RGO/QKnkvlVE/zMLydkZr5yxSrXznaa74VJOVsfb2OK7bzayynfEFyu?= =?utf-8?q?VIJCiOhCbyFMGQ8dzHG2hrHmxv7dZJadcY5x3gKnX3oUXr6y0X4io6oQKagy+EffL?= =?utf-8?q?76cKS3HKDhIrdQZ//A2J4w0nplVdRwmZAWLVoRaMkFjzVm5Si03M7B31moNy69ZXu?= =?utf-8?q?RVbAVfss8OsytRwSBrPyMU8yyLlPTlJ7DzM1MjuCSoAhH2Y47Zc5shpATnEQC6azT?= =?utf-8?q?rHBdWUuUH6RsOTSsTU7/8kOylCJQrZBPu+h2HbXvURykMz3rAn33SDD5tFj1+jNYt?= =?utf-8?q?n4l11y2CvjK6Oz/MVufbZ4ZKLTa88OD52NVv9/BcWuHBoTMhfaE3S2hRFBg6H8Qit?= =?utf-8?q?ui4NgkfTsocTFdtaldtZ8u6VxH4I+ihV96Cx3d2xdW7f9x3DhntXXeGD6HdRUrAKg?= =?utf-8?q?Xa6zUNT0+ncq4vRw7WQUHsgvI6jCVf6nWNQsZXDRAHspwrgrnASWgrIxs+g9axMDK?= =?utf-8?q?AHgI9cFOrz1Y6FyUcsm2opt4o/qN48PCjTTtnKpO6TND+uxcyoFjmyGxy90WvETou?= =?utf-8?q?IVHAlK3PXD/w4UamRpJafoJN+HJzTYopAEqiM2dxwBepppH0Xg1JwYbzFM/7/5fVO?= =?utf-8?q?S1X54alsm+Z5tF/y9X6428bRznuu2UD8SFsiDLHiCq8THDNKdQcsmWQudgdSPqTwG?= =?utf-8?q?/B2y3wGfuQkUybMrzrEXH9jvqf3X47sv76ZTtDoqSx6o0lQR2odSVA2p3Ldv0Qy3l?= =?utf-8?q?7hwwMYrG/XbM?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e358fecd-7c34-4754-47e1-08dd8c700731 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2025 07:31:34.2660 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b8+NZpcxQUBQedjzM7g179W9uZQ4awbVXzVvvHuos96xrCmgixHXPH8ENPjpCQAFzhHm5yrYtPHRI0NSNMukTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6881 From: Peng Fan There is no in-tree user of "include/sound/cs42l52.h", so move 'struct cs42l52_platform_data ' to cs42l52.c and remove the header file. And platform data is mostly for legacy platforms that create devices non using device tree. So drop cs42l52.h to prepare using GPIOD API. Signed-off-by: Peng Fan --- include/sound/cs42l52.h | 29 ----------------- sound/soc/codecs/cs42l52.c | 78 +++++++++++++++++++++++++++------------------- 2 files changed, 46 insertions(+), 61 deletions(-) diff --git a/include/sound/cs42l52.h b/include/sound/cs42l52.h deleted file mode 100644 index c20649666abe5dcbbf628f6c2d1692d3e7190eeb..0000000000000000000000000000000000000000 --- a/include/sound/cs42l52.h +++ /dev/null @@ -1,29 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* - * linux/sound/cs42l52.h -- Platform data for CS42L52 - * - * Copyright (c) 2012 Cirrus Logic Inc. - */ - -#ifndef __CS42L52_H -#define __CS42L52_H - -struct cs42l52_platform_data { - - /* MICBIAS Level. Check datasheet Pg48 */ - unsigned int micbias_lvl; - - /* MICA mode selection Differential or Single-ended */ - bool mica_diff_cfg; - - /* MICB mode selection Differential or Single-ended */ - bool micb_diff_cfg; - - /* Charge Pump Freq. Check datasheet Pg73 */ - unsigned int chgfreq; - - /* Reset GPIO */ - unsigned int reset_gpio; -}; - -#endif /* __CS42L52_H */ diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c index ba2ccc818ba6cc1b5fbcfb38e07e9bc8f68c4a6e..aa8c001cce099e3c1dfc979678fe8000caed097f 100644 --- a/sound/soc/codecs/cs42l52.c +++ b/sound/soc/codecs/cs42l52.c @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include @@ -36,6 +35,24 @@ struct sp_config { u32 srate; }; +struct cs42l52_platform_data { + + /* MICBIAS Level. Check datasheet Pg48 */ + unsigned int micbias_lvl; + + /* MICA mode selection Differential or Single-ended */ + bool mica_diff_cfg; + + /* MICB mode selection Differential or Single-ended */ + bool micb_diff_cfg; + + /* Charge Pump Freq. Check datasheet Pg73 */ + unsigned int chgfreq; + + /* Reset GPIO */ + unsigned int reset_gpio; +}; + struct cs42l52_private { struct regmap *regmap; struct snd_soc_component *component; @@ -1090,7 +1107,7 @@ static const struct regmap_config cs42l52_regmap = { static int cs42l52_i2c_probe(struct i2c_client *i2c_client) { struct cs42l52_private *cs42l52; - struct cs42l52_platform_data *pdata = dev_get_platdata(&i2c_client->dev); + struct cs42l52_platform_data *pdata; int ret; unsigned int devid; unsigned int reg; @@ -1107,38 +1124,35 @@ static int cs42l52_i2c_probe(struct i2c_client *i2c_client) dev_err(&i2c_client->dev, "regmap_init() failed: %d\n", ret); return ret; } - if (pdata) { - cs42l52->pdata = *pdata; - } else { - pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata), - GFP_KERNEL); - if (!pdata) - return -ENOMEM; - - if (i2c_client->dev.of_node) { - if (of_property_read_bool(i2c_client->dev.of_node, - "cirrus,mica-differential-cfg")) - pdata->mica_diff_cfg = true; - - if (of_property_read_bool(i2c_client->dev.of_node, - "cirrus,micb-differential-cfg")) - pdata->micb_diff_cfg = true; - - if (of_property_read_u32(i2c_client->dev.of_node, - "cirrus,micbias-lvl", &val32) >= 0) - pdata->micbias_lvl = val32; - - if (of_property_read_u32(i2c_client->dev.of_node, - "cirrus,chgfreq-divisor", &val32) >= 0) - pdata->chgfreq = val32; - - pdata->reset_gpio = - of_get_named_gpio(i2c_client->dev.of_node, - "cirrus,reset-gpio", 0); - } - cs42l52->pdata = *pdata; + + pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata), GFP_KERNEL); + if (!pdata) + return -ENOMEM; + + if (i2c_client->dev.of_node) { + if (of_property_read_bool(i2c_client->dev.of_node, + "cirrus,mica-differential-cfg")) + pdata->mica_diff_cfg = true; + + if (of_property_read_bool(i2c_client->dev.of_node, + "cirrus,micb-differential-cfg")) + pdata->micb_diff_cfg = true; + + if (of_property_read_u32(i2c_client->dev.of_node, + "cirrus,micbias-lvl", &val32) >= 0) + pdata->micbias_lvl = val32; + + if (of_property_read_u32(i2c_client->dev.of_node, + "cirrus,chgfreq-divisor", &val32) >= 0) + pdata->chgfreq = val32; + + pdata->reset_gpio = + of_get_named_gpio(i2c_client->dev.of_node, + "cirrus,reset-gpio", 0); } + cs42l52->pdata = *pdata; + if (cs42l52->pdata.reset_gpio) { ret = devm_gpio_request_one(&i2c_client->dev, cs42l52->pdata.reset_gpio,