From patchwork Thu May 1 14:33:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 886485 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 783321F1509 for ; Thu, 1 May 2025 14:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110019; cv=none; b=vCsTjT4VGDjNtC8b7NzxpWQbbI+uhgBIMN70ZMdy1WT5PmSnny/zouxuiIlFWOpcWlp9vo/HWM3yZhhEFvK9IeG2YDkm5agniHIbiF8/FaPGKd+N3F02K2yusd6VcV4PkaWoGQpAaRPlFW94ODthJDzNIAOAi8Gttbe/Yvi228w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110019; c=relaxed/simple; bh=i/9JegHkYn3hf7UKBycAb6L/6+ZSLW212aokZlZbpAM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b7TMnyP4Rhq/unGe1FBLYEr/gteXcRHYniTAhdajnbck+5GFBf4gJgvf5w3naQEXKexExTWrI7wSwzTCs2WpnvOlpy354craQqShO4Lf67onNJzNUOz7UBXzmVl1xk4eDY6hlOB//oraiG2Elm9IQZENbqyKMYTJta+SIhjQDdw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GfHIWhqp; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GfHIWhqp" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43cf7c2c351so1079795e9.0 for ; Thu, 01 May 2025 07:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746110016; x=1746714816; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=235YzEa2hhjg3MerjPvZinFHZ44M460Ui9/2wMQKQn4=; b=GfHIWhqpjBEmMJD7lm1OeWcrdg4JgAW4dWWbC5EwFEWS1NHkY9LQ9qU1QUCP+7v8Ig +/gQfFZhYGVsimYJZRyPGgil3ldlikSwXB68kklphGtXDj7BA0sO9ihG6v8mO3kCOD9B UFRQ3qd1A/83UICDRTAVHvZdWiynD9gVzgCym8lOdybBGwnaVppv5AV/GLh4JIpupbQX QeoQxL2w5OCLOt1VLMAwbZzX+ERF0zIjq4+wjuS9h8zHtwz+bMDhXmALYJ5fI1G0cNM+ 2UXR8zvM3pq41RWZarEuTW/bYObdRejBEXM8Ri44yow7aOMo8uBJvSkUEwKn5nj7WWVI xtgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746110016; x=1746714816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=235YzEa2hhjg3MerjPvZinFHZ44M460Ui9/2wMQKQn4=; b=p+9JPDMHDge/g20dbbVuuiRDH/JyEB86eTnW44WhY4SfuKuMKi8Xcmn9kDY5WTRMei xFP2miQ8+C61gzNEfwZmYXcelEPX5cyd6r/ghpSfp+XsJDOAEJWrpDfgoW+9Ku3g6gnL G89GDLiSGiPcY0B/tyWyDQpZTVRtR9a0+3X2/lgUdjfBpgO27+JOBjeD0Rthl3v2WnY/ KMg4WLLV2DfBv8JbiuAC9++n0DSOUxPfau8ewsYG2FbFdE8EykytK+d1gO0ID0vYBji4 8zfxnccUT5GVTO3xOwX2tcFM3s/0QR6g4hk2oG6LrNLX1qRqVdkiAbnPfYe6UeADdCpT 9stw== X-Forwarded-Encrypted: i=1; AJvYcCX2JPnGdzVQR4U+lwTKSMkm+MhyN5i3YbVpQR0ty9MOFHEGVnKTrPUPrMmNEKjYKyvONu5hc9lvAw6U4TCL@vger.kernel.org X-Gm-Message-State: AOJu0YwHcyZLwDki0AjYxwKBAXzkXAqouUAOc6+AgdUN8E4ITOO+YF+Z O4ZskLYHYsycNTsSYOloNt3DXgZrJ/9kKsdq8r/gkP9VJeAiAl+YFhnRZLnDWLI= X-Gm-Gg: ASbGnctlvf6mba2nFFLZ0t671WiE77UJNpBxtWJm49gCadB0ruR2RIdXnvaP8QCxEAo 2lNg1SwyrCrM8bMm+FLDvQxVDbKSBEglCABiNwrAyzOiP+bSWUAIyiOup6/L+p2tBObk0Yd4nXq h7cyDnF4l6FEOJ3oeZBpjYKYkYYlSYg2GqAD8BEkNh84sAXSjMJXumKx483H6H/EMrNz9aoG8bL MZnBz1WoqrhDeEkZtBt0PUzkrp/2FKFcygWJpMwj22raBdUVB2BLUBUyU0c2v+gb9fw1OsiIyd7 D68Z6x+i7yGKdM1TNjGZU56wg5w415vBr9HUjs8I6yjcfC2Q8Y1QaRBRG/g= X-Google-Smtp-Source: AGHT+IHM+H9W6H03/DSmUY0qzExdl+2h9JqhPuoEYvmYnQ1kcBLAjkYWDq/sTkuyzxoH0CkcdQ5N1w== X-Received: by 2002:a05:6000:18a2:b0:3a0:831c:ce4e with SMTP id ffacd0b85a97d-3a094178ed7mr696817f8f.12.1746110015720; Thu, 01 May 2025 07:33:35 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a8ef66sm957636f8f.88.2025.05.01.07.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 07:33:35 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 16:33:22 +0200 Subject: [PATCH v2 2/4] extcon: axp288: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250501-device-wakeup-leak-extcon-v2-2-7af77802cbea@linaro.org> References: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> In-Reply-To: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=819; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=i/9JegHkYn3hf7UKBycAb6L/6+ZSLW212aokZlZbpAM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4Y4qnk/g4XV7me9WouKqm9DXqHuXluUpQfFh 44yOz8PFqaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOGOAAKCRDBN2bmhouD 1zSDD/4/C2bZx81xYPkD+nD8q8jsTtnM7Tz9rzBhA+VDWRdn9Nz1CTuSZ62C1J5w2Nhn7BFtuJY MWEUiigYZrgv/L7einC9teL35A4C4XbTGSeELk6gHyyJRC9t2U8RHQBaC3BS82BqcnwMm3nRzM/ hmUBj02FP14tUrpVAb0qfvmiVaml+SyH/zUxjyfC01psQ8JmDhm0hE4uTqH27Snj83Clrv+l0Fc ihC65YP7MzlIaV5d/wlo3L6DmxkH5uzVhXmX1tlLmArZ2Vdx8+Jgiemw8u8s13Zqz10UrQQzaa7 Osv4n2qPkxDiAHNKAb4Jw9iiqlxbw+eRYLjE/PMFXC4FO9iecc1z5GEKF8QN8ahBWfuK3z2gv5X 7zNEW8QhqzlT3dy6NRoB2L9rYVHzDM77MZ9md5FV5KGINOIFLPJynOAtzWzZR+Z4MeDigxWi3LG OGGcux4v0+fu4rCzttuNcw39dzsEsvLuBGq8AcmNhScv46ji6D9KTdwOFF3+gsYOQWDuRlyogEV a7/fCqr+/r2IyOYS5rLCcIXxTun/TZnvo67GMjnFxuGpf7PSOEOgCEvHyGKOOgUJMdC2bKaPwE2 qRF0mmfZXeaAtCesIeE+nhHFolQe9IlF0r1dOxO2EFG/7KVMhrvbiJ+fHWiJa8An9iLmUUQF7Zt goZGEmzDfYZrZaw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-axp288.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c index d3bcbe839c095f126f0313a074681f1c900762c2..19856dddade62c5592701f8fd5842857ec24813a 100644 --- a/drivers/extcon/extcon-axp288.c +++ b/drivers/extcon/extcon-axp288.c @@ -470,7 +470,7 @@ static int axp288_extcon_probe(struct platform_device *pdev) if (ret < 0) return ret; - device_init_wakeup(dev, true); + devm_device_init_wakeup(dev); platform_set_drvdata(pdev, info); return 0; From patchwork Thu May 1 14:33:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 886484 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A21F0201033 for ; Thu, 1 May 2025 14:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110021; cv=none; b=YyqZgD+KJsugf+OH6afULuDYdrXMTGYjtT3WOxujMf1bH5wDPvY3H4yZ00DPtNhP+TuMRWCAAMhH3TsPJSz0KgSyYBaC0XeSf3yZxgd+jq8c69qTsgDsCO2YOs3w1eeOQYAZQ1++eov4fRPzQmuIalC+M355wb6PgAY5Z9yCuQQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110021; c=relaxed/simple; bh=2aoVFkAjElaHENHtg8TjDWPYjXCiMNrGnaFnDbM6YaE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sg29px5VnshT0SPAshvrC0hAKHEARIdtA2iOT5cc7jeEML0d6pvS14OY136vS24G59Lvgj9w/pPg7QL+B2IA13jdHHbhtheZc6dwyWu5InPSNXtKwPLIp9dIsSoJQAWXxU74ju/+9u0NUXHsAeaYIB1kNWjsQph9In7OgZrWzaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wuJk7iO0; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wuJk7iO0" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43f106a3591so1316855e9.3 for ; Thu, 01 May 2025 07:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746110018; x=1746714818; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9+H5gIa6d4pyLO8MdBlU6oFyFMziUKLEhRLhfdswqn4=; b=wuJk7iO09rELbz3quIVEMJeq3Qhaw2EJlviOetFTUAOJEIb9aeEB2l15m9Gs/f8MyJ Y6TSflkBHr6Yt39WwyrTxcWjRUl3cmDspOZI1V/HV61sSI0+KZd3Jyi5loW1k7KI86zr 8UjO9hIJG27iCNI9j70hVeFySmYx4N6E2RNxVWa5vSuMBbjcHU+uxg+ck1abD2xf52t1 VrCHmabXLbE6LS7NUqP1y5xnuTmu5GRKbyg+zw7yKSq0aqd7L+krjKoeoWqY7SDP3v4n gFvd6Vx+HCv0PEoaRM8PMKYQ+ukPK2QV1OZ3awDAfx4p+Q9DvWiLPYlscxD3ski65kA9 zkZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746110018; x=1746714818; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9+H5gIa6d4pyLO8MdBlU6oFyFMziUKLEhRLhfdswqn4=; b=k8z3Asd/1Lj6cfsxmYzQsY+9m6IqiBvqZONtBpL9yPKMkKeKceinCsu4mGYfdXxxaI gGeJAim1NJd++mmqWjyJXN3fP1Fd8UUpmfMalUJ5oqcuYcxezPpFYM/JTHTsUct7eFap 3d8A8lAPSZd4Ben9PDuEdxbUzIvWkVqw4MVclwhOlXZHuveC1vVawh5cIDQnD8PgnJ5d dXlMLARrQn3hiTUXuABpVhVGww8/ZOm1XuPMi2txZxHjuxllSARpEmqFT5HIXyxr+t5l R45OoK6hh9IyBtW9GgRtiNMbNonYuKuyfTbuoVOUOAMwbOgFCqLs1C/m3qZNO4aILpY7 v1RQ== X-Forwarded-Encrypted: i=1; AJvYcCXfPPG6pwNeBN82VD+Hp/bYrqRHrqiJ0VxalNgy/K+c3upWVJYFK14twBmuqvcdlixp9GnJmbjh3KjVKHSX@vger.kernel.org X-Gm-Message-State: AOJu0Yw+osgrO6yX18aN1rjWNFVv61qV73pA2Du2dKjNUx4CKdnvhxfP M0xibeCm7a5jfAONWuMCE2Cl78QBv2Tq6our7eUbJbngqqPVp/3aMJuPXSlslk8= X-Gm-Gg: ASbGncurh1ZYT2KOr/ClxxBH1bmzyDaE0innmlSxirsH1xnZRwsqJXRgkX5aqU/SPqb mSDXUfI99q7Z2kEPhWyky4rPJtG9t/P++CwKc2/YXiQND7vx0Dc2znKRu4DoUeUnxssBOg2J1g0 9LShG6bwj7mEWCb2Cbbvc7n7F/oqYT92StH3OE8SPIU4RkwKN0M+4tNpMN7dPk4JeLvoEttYfMB u9YbL3hcENSsZ6k2FYIiMp2BXX7UEjI/ElO63Q2ETgP2gkB2hNOooLKKJHRwfOonlA+V7gkZRvk oQDTERab0rEcj+mXsUvTypXLTWN80BBvWKayNbP5yB2vNUU3MJa3iEKpU5w= X-Google-Smtp-Source: AGHT+IEZATzbg/rgmI6bhSczj0axA9hwqI+q39PcQPM8+MaFD8mRfMUqEaGtuwQ93o0OYfWDkXaF/Q== X-Received: by 2002:a5d:6b0f:0:b0:3a0:9570:7233 with SMTP id ffacd0b85a97d-3a095707240mr350578f8f.11.1746110018004; Thu, 01 May 2025 07:33:38 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a8ef66sm957636f8f.88.2025.05.01.07.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 07:33:37 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 16:33:24 +0200 Subject: [PATCH v2 4/4] extcon: qcom-spmi-misc: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250501-device-wakeup-leak-extcon-v2-4-7af77802cbea@linaro.org> References: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> In-Reply-To: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=911; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=2aoVFkAjElaHENHtg8TjDWPYjXCiMNrGnaFnDbM6YaE=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4Y6EdqQvi7iSbCPndmZkC+pXDb36V2KHvHE+ 0sRg5QFcouJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOGOgAKCRDBN2bmhouD 1yjAD/0XskD2vQXiEUBv5CQhPcKLav8KeOqqIn/LsWowRspN8Udl/FO1N5AtS632Irr4FM3A06N 0HvKqEi8uZ46yvCmr3lny3gjfH3dmUN+TuLsZulBilCBI4lyX3KMzfrvVntKcdM+HJa/HCMJzhz NOGmtILGMD4yfnH+CgFXf4zN8d1de8GgP5+YRUKUBJrjx50J30JoBMad4nGZwGA/XHW9D3DLIth RgMPveHYoVRRa9smq7xPQC8DuHKqF2hR9TaKvXm7THj4C3NSZtHKUDhSmD6url2RE5Z5j0dS5cm l+Z3kJ6WixTkR0x4qUsa+BGeuPlTMOpTvOBWc7bGsFRTv9V1aXgCL7cHO2MKWBI+vyjCDB3lD0q p3hI1YQflx0ExfD+HDxq3eBC/6zB5hRTg6X7fHZCyPNkN6PbH/Ty1yFmzkSH1bsjq8qWmeaYttq L4KXcbaOBC5DdhsBovHRsrOLvQeXV8aUgJLvKn1VlLXjX5m+yiVN1XzXAUXgs1TMcCXkKddnKHe GMIWRmbkyM7l9kFgz3bCk+1EiUboAYqPkl2o1uQsVlRo0Kt901qUoFOmH6/ZJR5vIwxwotVHpYm MyIwXMwK8bgcSQp9umrZf73h2QYaubFTAbhfaqLYAF9Serlp4NRrAJNChtPDST6pHfQgj4uuoBE FLcoTRp8853hTHA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-qcom-spmi-misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-qcom-spmi-misc.c b/drivers/extcon/extcon-qcom-spmi-misc.c index 53de581a393a35bb48f637ea73e910b4c8340ace..afaba5685c3dcdbdc750c1835ec4c696bcc64fc4 100644 --- a/drivers/extcon/extcon-qcom-spmi-misc.c +++ b/drivers/extcon/extcon-qcom-spmi-misc.c @@ -155,7 +155,7 @@ static int qcom_usb_extcon_probe(struct platform_device *pdev) } platform_set_drvdata(pdev, info); - device_init_wakeup(dev, 1); + devm_device_init_wakeup(dev); /* Perform initial detection */ qcom_usb_extcon_detect_cable(&info->wq_detcable.work);