From patchwork Wed Apr 30 12:32:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 888006 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A40A238173; Wed, 30 Apr 2025 12:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746016415; cv=none; b=czD4IrYmdEwIrwudarll+6ReWGS/MZISvHD8lXgaOjX//A28MMRFYP1xWKEvediuBDCq2j7+juARON15wiBqnHYb6BZW9OK/iJ1pKDjBgEImJDartKrxdQgqlmUQns7WDGT6aduIc0FILqs0mM9zDxRrDmfykd+3H0S8+uL8tLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746016415; c=relaxed/simple; bh=rsd0oMU+vi8Z/ml6XTpNx91MJVE9xBPx9VtmVuORW8Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zov8Z1wZGfIEkJ5G7pUI1ZFBxDKqXNk3HDTJPLrtSCtwzI02b7heMcD+nvsB90P1SVqSZwySxMUoSdqa/Dx2msfUexL0yDNgp1wr/1RJCF5qtbfyaAl4EmQUq0hMr7TE2znPAUm98gTPpVIatyS56JVT8l2Q5wyFU1eE/kL0TkE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H4tvZ6ZK; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H4tvZ6ZK" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7396f13b750so7939373b3a.1; Wed, 30 Apr 2025 05:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746016413; x=1746621213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lf55HjdhhKhvLLEeAhmoJNEvXS6+XdwBwTK225CdBtY=; b=H4tvZ6ZKwUtmDCWK+eyiVyIxS4FpQfush7PJ25/ZtBsFtfzOjgIm0mytgtqpKhJCKx 58xN+coyCtJ/fHuhSxQNbZQgXPDo0zbbiCjRO/fWSA18AA1yX4mQC2Z12/2DokNahnLN 1VuopbRQs/J372XwPu+DoBSczB39mo5LeScWFPFvJj8Ya66vu4EbXofgxsAQPLuc3EJh X8AEKfhmzeYIvo4O5ndHOwjyCcfYBNy0ARcVSfTETBjHgbumlc3Qm7ASrvVaC3Kmd5dv xNXGdS0YjGnkD4RMfDBseO/nvqtClhRJIDJhYc24if4dHvjF7vghAQrWMUHm2yISQxmt bi2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746016413; x=1746621213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lf55HjdhhKhvLLEeAhmoJNEvXS6+XdwBwTK225CdBtY=; b=IesaIv47wWapEbbM6xS7Kvy6vo2l19TaR31KMCkBuczF3EHBeTnM8LBGMNDTm08ogf WO6Z3IVKnTHnt/DBY3HAKGsCBwGiM1BvwUxIrt9riGyoM59FybzeVCfu1vDqazoRMHiI IzMHXFoxN9vN/c4zode7Kl4FAWb7Z1d99fnFEM3iTgVaXmmYHHpM7lPkYFj2qYqT0qsw 5n/wbCC9McA0PJTQRkWWksLiwr0AFpE955g+S/i5gTIz9GlvQy7zViqM4/k1PbxIAIjn UPfZiZ8eeHC2CArBDYH3YORseNw5PoGDSsXzMHFnfPk8o8TZtWU/AtfQ4hbhEKdqvloB F5zw== X-Forwarded-Encrypted: i=1; AJvYcCUnhGFqeCDUfBnEOJME1AneFFZsfjHU++JlMhwD1PNbC60CLqM+dgTX+XToxyHv7IVk/8nAwinAQ0vMqFU=@vger.kernel.org, AJvYcCVeFnX77UjycTkTRRfhMKgM6AQ3M2VnZud85Hu8/ifunL2MK49mSmp2J6YZkwOXZYBzpK9vl1uGs+tOprFMP92CvS8=@vger.kernel.org, AJvYcCXNyuja8HVJo6aK0Z8zraOE+XRbSKDFU1p5BTUxKPUHYkvmBIZc9GJobDN+z9kVpD8e/YHXN9kXN5w=@vger.kernel.org X-Gm-Message-State: AOJu0YwTrKdvHc0h8DQBZ0DfMAvo59u7lKorDMGCmfJbKzbcPaJOy3So WFpmfEjiaL5UprwrQeZt03vKY4dVqv3TFYySdDPRV1CaB9ugTXtc X-Gm-Gg: ASbGncsqiHshlYzObK3jac4eZEiXnyrUUpO8jrL86ps2gea2rd0OQlQcw/PvH6xqwN+ wcatICVpXN9u4aLOxdLC+o5mnfdwCk8hA20walSMkjl9r06+9cy6PfgjS2JOKo1PY8u+YUvAhkY fGklu5D0ZvhbFw6LJWDIFaNEE8HHpqNZ8YMGh5AKm66rkvgY3D47OaHkPxG/y116+HW6R8xi0rc KdPgZzLBeiHX6rMsq0zr5mQHt519tpnpwKdjzENyv0co+LsHrKTvmJ8yqTFg5n2hz7Dcn8C9L9L gmz009O/aX90uN7EX+N44Kk70WXwu+Ygao6qsRIvM5G0EyG0hHqsdA== X-Google-Smtp-Source: AGHT+IEXIBRnItsxJgHarmeNLTYGAGyI0xDlMc36p/yim3EbyhEaIx8/EJ3h3jrPHK0gWcrJ56Volg== X-Received: by 2002:a05:6a00:2405:b0:73e:b65:bc47 with SMTP id d2e1a72fcca58-74038a8762amr4013535b3a.17.1746016412720; Wed, 30 Apr 2025 05:33:32 -0700 (PDT) Received: from localhost.localdomain ([110.44.101.8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74039a62e23sm1522627b3a.147.2025.04.30.05.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 05:33:32 -0700 (PDT) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Cc: Anand Moon Subject: [PATCH v6 1/4] thermal/drivers/exynos: Refactor clk_sec initialization inside SOC-specific case Date: Wed, 30 Apr 2025 18:02:57 +0530 Message-ID: <20250430123306.15072-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250430123306.15072-1-linux.amoon@gmail.com> References: <20250430123306.15072-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor the initialization of the clk_sec clock to be inside the SOC_ARCH_EXYNOS5420_TRIMINFO case. It ensures that the clk_sec clock is only initialized for the specified SOC and not for other SOCs, thereby simplifying the code. The clk_sec clock is used by the TMU for GPU on the Exynos 542x platform. Removed redundant IS_ERR() checks for the clk_sec clock since error handling is already managed internally by clk_unprepare() functions. Reviewed-by: Lukasz Luba Signed-off-by: Anand Moon --- v6: Add Rb Lukasz and try to address Daniel review coments. v5: None v4: Fix the aligment of code clk for clk_prepare in proper if/else block. update the commit for clk_sec used. checked to goto clean up all the clks are proper. drop IS_ERR() check for clk_sec. v3: improve the commit message. --- drivers/thermal/samsung/exynos_tmu.c | 36 +++++++++++++--------------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 47a99b3c5395..04517d52afbd 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1040,26 +1040,26 @@ static int exynos_tmu_probe(struct platform_device *pdev) if (IS_ERR(data->clk)) return dev_err_probe(dev, PTR_ERR(data->clk), "Failed to get clock\n"); - data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); - if (IS_ERR(data->clk_sec)) { - if (data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) - return dev_err_probe(dev, PTR_ERR(data->clk_sec), - "Failed to get triminfo clock\n"); - } else { - ret = clk_prepare(data->clk_sec); - if (ret) { - dev_err(dev, "Failed to get clock\n"); - return ret; - } - } - ret = clk_prepare(data->clk); if (ret) { dev_err(dev, "Failed to get clock\n"); - goto err_clk_sec; + return ret; } switch (data->soc) { + case SOC_ARCH_EXYNOS5420_TRIMINFO: + data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); + if (IS_ERR(data->clk_sec)) { + ret = dev_err_probe(dev, PTR_ERR(data->clk_sec), + "Failed to get clk_sec clock\n"); + goto err_clk; + } + ret = clk_prepare(data->clk_sec); + if (ret) { + dev_err(dev, "Failed to prepare clk_sec clock\n"); + goto err_clk_sec; + } + break; case SOC_ARCH_EXYNOS5433: case SOC_ARCH_EXYNOS7: data->sclk = devm_clk_get(dev, "tmu_sclk"); @@ -1112,11 +1112,10 @@ static int exynos_tmu_probe(struct platform_device *pdev) err_sclk: clk_disable_unprepare(data->sclk); +err_clk_sec: + clk_unprepare(data->clk_sec); err_clk: clk_unprepare(data->clk); -err_clk_sec: - if (!IS_ERR(data->clk_sec)) - clk_unprepare(data->clk_sec); return ret; } @@ -1128,8 +1127,7 @@ static void exynos_tmu_remove(struct platform_device *pdev) clk_disable_unprepare(data->sclk); clk_unprepare(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_unprepare(data->clk_sec); + clk_unprepare(data->clk_sec); } #ifdef CONFIG_PM_SLEEP From patchwork Wed Apr 30 12:32:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 886269 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9148525A331; Wed, 30 Apr 2025 12:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746016422; cv=none; b=rbH6i0qSrad/14dB+UudIVA8H71V0TDppCtREVp0tdBafAvrLFSZBHmMoA1VhLB09H1QtCfL8Ydj2RNgolTP+KGAe/2PqB/6eKvux0tyC45B4rAtXcDlEbZXuuF55YdmbLhmsD0rFh9fAuNhibD5HY2yzl97X/EgQrCv2Jtmfok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746016422; c=relaxed/simple; bh=AMHriJWtg25hnFA/So3L/EOWUqqACE2Z4o1uB6xjZeA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S8mVpcOiQ30vyTmEjRwA57t5PVVyLf24qgxbizQ6hHehkE8SVBge4eLRgZes9Dy0XYbDsvlIenpVpykHJaPC6JJsOxGzo+68IRdGeH0U8CPRaTEd+7C8K17/AVuZPLEMIahQ8H+4Xm2gmOmRtLRazIGufbP5Q36sRLGnDpGZ91k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ex5VHu3J; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ex5VHu3J" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-736c3e7b390so7291927b3a.2; Wed, 30 Apr 2025 05:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746016420; x=1746621220; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nvhhvpDOxzlX5SAkLZgkSUnI6uZuO15oKBiHsWrIAXo=; b=Ex5VHu3Js3meZ6q6qVE6afZ3leFHXcitpzQ/u5Gozb3Nn9RT2bcAa360peSh0myCP4 USNXxNXu4avrsr37XxVqHSiHTd15fo58ya2sfVEU3w68IEXg5yXnZnNShEAmkDFuerVO e/l2cb0ye6qm0dlT7hKcRjwieQPEvgg27WIwr+YX4d5UHICqekWLRAAhFK16MRyPC+19 2j9rI7EuKiDnm9RPJWXnv063g0G8/s348ttIT7NaVEOJGTDVF7wfXQGW8ANA8MaO7aFz 3TdEAwi1Bf6a5PYVeXlh8Bii7GiBT8jx4XpPoIO2z1dDjaYM9a6hxffCX5LsEc0oXKrf CrZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746016420; x=1746621220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nvhhvpDOxzlX5SAkLZgkSUnI6uZuO15oKBiHsWrIAXo=; b=hy54TzmRUOFYb6Upao9ZjwO7FYGsU0xZIDBXHQvXF/wMwmM/7f/seYMwDXKxacCnmo nvdUm5sf/Gerz7TKJQ5X7GIvu83kL4RCWWcOp2eHRyP2JL63652hlE3vmmPQ+rN12q0U csgQ4Asop4R+wC8pMkwLjYS3EahWsQQgYWU41fOR/Vla7tsW7O7ZHcAcVMzT1y0m/S3X GKpxtyJ9IcyowgtuWgfcHFxvn5D3Z2V3Qwj/ElJmERbQNjE4n4vcwg1j439FlOBZijpw xExl4AZGlJUojzKsYTvnZPdOPob/xtYHNLcDGcoyN5D9UsH5D9t7GjiyBXx74Ha5dEPi pCSg== X-Forwarded-Encrypted: i=1; AJvYcCUmvSJQlKbYj7uGbYkkQjYLIt82KSMXoRLC31x1GwuxwNJS/5mQ0kjDolFR0ox8nnEyIJ18tSMpnIA=@vger.kernel.org, AJvYcCVM8Wpnf85heD/WbM7Hl01MKbICaD+geG51FzNkflVyfVHwtrIn8C4xHxnhl8f3syw3mHPkoEWliUQ/DkI=@vger.kernel.org, AJvYcCW8tUtdX0igdfcSnJNwYXXCll6ZR6TVU3bqpz4byUZFjUn8yZ/mWgBSsrRQG/eEBhSDBjwvMbV7BAaFajXObvwilpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwZBXhzuzzgsObBnsT/9qoAyjPvg+3rtW5WA8FmwtCneYx4HX6T YQ0l/W3u5yKPsT6+xD9es7sk4J95z0PRJVrhzTN+lmgWGag0ffl1 X-Gm-Gg: ASbGnctHRDZA1/9Xf/1aSvXq6DS9xfMV78Vwvnnb3t7ICPJu8E+u9bFdSKbacpwJX4e P0Whr2Tg9YgTco11WDQToc0AAjN+eIMfYVG8cFgs/Gns88Gb0vx2ZK2OojrMV9iHxZHAQuw3MtB f5f8LTK9t/ZCKMqWrLweK6Qs2gqQQz36/p+inaHvwnQL6xGqcu++ceZa2NtwFDFjccOSThpWfKI dAodXT6B5cRomKM/2zKmnsZuB28i7uRGE/j2P5ODvjnzEHM4UbaE279ND5D4X2y+ujvhzsNb1bc HqO2sEo/E1OxS/SkwCqfCxLVPE1RlH5hVhfP9Vt0d273UFanMJhcvg== X-Google-Smtp-Source: AGHT+IE32P919fQ5R/hcnyijMUiuE0NQgTE1aYia66YLx8XCG3ZA9kGC6cfX4skbXBq1rJ+lGp2Cug== X-Received: by 2002:a05:6a00:1496:b0:730:75b1:7219 with SMTP id d2e1a72fcca58-740389cb685mr3926486b3a.12.1746016419699; Wed, 30 Apr 2025 05:33:39 -0700 (PDT) Received: from localhost.localdomain ([110.44.101.8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74039a62e23sm1522627b3a.147.2025.04.30.05.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 05:33:38 -0700 (PDT) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Cc: Anand Moon Subject: [PATCH v6 2/4] thermal/drivers/exynos: Use devm_clk_get_enabled() helpers Date: Wed, 30 Apr 2025 18:02:58 +0530 Message-ID: <20250430123306.15072-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250430123306.15072-1-linux.amoon@gmail.com> References: <20250430123306.15072-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use devm_clk_get_enabled() helper instead of calling devm_clk_get() and then clk_prepare_enable(). It simplifies the error handling and makes the code more compact. Suggested-by: Daniel Lezcano Signed-off-by: Anand Moon --- v6: New patch as per Daniel request. --- drivers/thermal/samsung/exynos_tmu.c | 77 ++++++++-------------------- 1 file changed, 20 insertions(+), 57 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 04517d52afbd..aa0726b33c84 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1036,65 +1036,41 @@ static int exynos_tmu_probe(struct platform_device *pdev) if (ret) return ret; - data->clk = devm_clk_get(dev, "tmu_apbif"); + data->clk = devm_clk_get_enabled(dev, "tmu_apbif"); if (IS_ERR(data->clk)) - return dev_err_probe(dev, PTR_ERR(data->clk), "Failed to get clock\n"); - - ret = clk_prepare(data->clk); - if (ret) { - dev_err(dev, "Failed to get clock\n"); - return ret; - } - - switch (data->soc) { - case SOC_ARCH_EXYNOS5420_TRIMINFO: - data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); - if (IS_ERR(data->clk_sec)) { - ret = dev_err_probe(dev, PTR_ERR(data->clk_sec), - "Failed to get clk_sec clock\n"); - goto err_clk; - } - ret = clk_prepare(data->clk_sec); - if (ret) { - dev_err(dev, "Failed to prepare clk_sec clock\n"); - goto err_clk_sec; - } - break; - case SOC_ARCH_EXYNOS5433: - case SOC_ARCH_EXYNOS7: - data->sclk = devm_clk_get(dev, "tmu_sclk"); - if (IS_ERR(data->sclk)) { - ret = dev_err_probe(dev, PTR_ERR(data->sclk), "Failed to get sclk\n"); - goto err_clk; - } else { - ret = clk_prepare_enable(data->sclk); - if (ret) { - dev_err(dev, "Failed to enable sclk\n"); - goto err_clk; - } - } - break; - default: - break; + return dev_err_probe(dev, PTR_ERR(data->clk), + "Failed to get clock\n"); + + if (data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) { + data->clk_sec = devm_clk_get_enabled(dev, "tmu_triminfo_apbif"); + if (IS_ERR(data->clk_sec)) + return dev_err_probe(dev, PTR_ERR(data->clk_sec), + "Failed to get clk_sec clock\n"); + } else if (data->soc == SOC_ARCH_EXYNOS5433 || + data->soc == SOC_ARCH_EXYNOS7) { + data->sclk = devm_clk_get_enabled(dev, "tmu_sclk"); + if (IS_ERR(data->sclk)) + return dev_err_probe(dev, PTR_ERR(data->sclk), + "Failed to get sclk\n"); } ret = exynos_tmu_initialize(pdev); if (ret) { dev_err(dev, "Failed to initialize TMU\n"); - goto err_sclk; + return ret; } data->tzd = devm_thermal_of_zone_register(dev, 0, data, &exynos_sensor_ops); if (IS_ERR(data->tzd)) { - ret = dev_err_probe(dev, PTR_ERR(data->tzd), "Failed to register sensor\n"); - goto err_sclk; + return dev_err_probe(dev, PTR_ERR(data->tzd), + "Failed to register sensor\n"); } ret = exynos_thermal_zone_configure(pdev); if (ret) { dev_err(dev, "Failed to configure the thermal zone\n"); - goto err_sclk; + return ret; } ret = devm_request_threaded_irq(dev, data->irq, NULL, @@ -1104,30 +1080,17 @@ static int exynos_tmu_probe(struct platform_device *pdev) dev_name(dev), data); if (ret) { dev_err(dev, "Failed to request irq: %d\n", data->irq); - goto err_sclk; + return ret; } exynos_tmu_control(pdev, true); - return 0; -err_sclk: - clk_disable_unprepare(data->sclk); -err_clk_sec: - clk_unprepare(data->clk_sec); -err_clk: - clk_unprepare(data->clk); return ret; } static void exynos_tmu_remove(struct platform_device *pdev) { - struct exynos_tmu_data *data = platform_get_drvdata(pdev); - exynos_tmu_control(pdev, false); - - clk_disable_unprepare(data->sclk); - clk_unprepare(data->clk); - clk_unprepare(data->clk_sec); } #ifdef CONFIG_PM_SLEEP From patchwork Wed Apr 30 12:32:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 888005 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0550D25B68D; Wed, 30 Apr 2025 12:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746016428; cv=none; b=hsbhDAKptCsxb6FmE1ougJD08fWzmjpCsMhwZsGPmUg90S1DZrGP6DBhnL9X0xLeYaerE9d5LMQ8XJeX2urkfikuf0ERX/+FJQzRjmXLnVZXhZSJ/VaAScQeQNYbHV7a/wwyJCfdxHmxyAyQkPkcHjIeO3ObcZLBgh1hMSx4l/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746016428; c=relaxed/simple; bh=NaQIDks9q3n5AJ3fdvvvN06Dc2CyVDzyDsG6sNYlTnc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jD2cOz2VYmjnC2EEHcpVsIWycXTiKDeUCx5uSIYYYAqFwA2rLF7YXZmNvnnK7OaApzmBvdmsJb5UPwFJGnFFEx0DBV4+qvMmoh9Lrjo+bSjBp8tMhzSF1HE6k1MfOAN0cIHPolTs6MWumpxlpmmBX2vLrYB9kEosMpSVMUJAQVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H5r9b7Lu; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H5r9b7Lu" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-736aa9d0f2aso8931874b3a.0; Wed, 30 Apr 2025 05:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746016426; x=1746621226; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t3SNFYqaM9t1VFZcOe3OuDknXKerjgLDw3YgF3gLBg0=; b=H5r9b7Lu94UtIDctKaRmWILKuvdyrb62VIQdkVw+qHZBAfPHdApqu10f1PIxhuXkfb Q/bha2NJ1Xe3Epi25HSIqI7ZIoNDA5XRNN94Y6+iwCdsQRRnqOCq6i5sZfg2XvGofX/K GBJ2RgPfjdVPBwY1R+uSvzSyoOD/KD33BSSQJ4RwVi++OUkx0WK3Pd5HrI+qJ0NrHpsT WhRIqHYTqeUVOyLg38Si28xXDY6J2O5WrupgMfrKbSoHHz3MGCNsRKQqfKmwRcX3l7P9 I5FRzse5F0mTaHUSaJa7Ca19mrX1Fpth7Eim3O402DVJ3+PDWsQlrh3lS6S2FTqGLOAK 7FQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746016426; x=1746621226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t3SNFYqaM9t1VFZcOe3OuDknXKerjgLDw3YgF3gLBg0=; b=mvQImYw6b52dgRYP6jcxla4pVuT6ektUszNBYMpiACB2NXcDRGRm0NhbNc+I7Dv5iM Eij/PqZn1Wm14I/Sz0SETrXbrLS/XNqO4zQF/5j9RSSkXO1Jg5KaGl0memqz+oYNx1tv b2rMe0slA7644gpuPfkFDxp5l9cEFcY7eS9cUrbyuWCzdamLv+dyR6F20V+A2dXhGk0n LXjxNireBD2bXpk+H++skVYQAOOgHGcoxaIdIHgQx85hI+Vw62DppCILylAZqIG690cD KeZ9hHSnjPQvDaBwZGhZVPBlwurnOwf9uRq/M8bpass+qgTeb0xeCcj/yO+9DsLBGXKk Q9AQ== X-Forwarded-Encrypted: i=1; AJvYcCVUU2x+T7joLf6S50Tg3MYzCTtddIKUtu9D0bh63Pel5d+27cAD81kfWtANgZ1SKFtnCWL1Y6xxu0EKU8zM0/7E+pU=@vger.kernel.org, AJvYcCVnN+Z46dmyNVkWGoS8knKocimmDLDCjhU8BoCj3J9DfBHsX4mYbMSGx84tUrDxpclKsumw8f9QLoclnLI=@vger.kernel.org, AJvYcCWMeNi8BCBrXocVGnoqhq/8u5Ho3Y1HObQ3rPqsUR3G9wUJbPRXt47QtzJqRCwXm33YHMrPVkvlSZo=@vger.kernel.org X-Gm-Message-State: AOJu0YzcJtlihRpZWPQ3Qv9RWRdB38bH/zQ2yOc0EMpFfPTand9yFF1g 4KbGCoonCK+pMCVzONCu1Q5ulhTbAfPh+gkrrhJSjNVAdeJWT5yHKfM44Q== X-Gm-Gg: ASbGncuEp4KRxtAAtuR/e7sHtw8IyoGipOymW67mWfSt9L7j/q+ccxWH4UTHQpXmjac l4QC9s/PKUKntpt/oyhfPUp82N7Tj5GOOCgwA+fjI/txUBdCnoPpkfs8fxqMr4153sfMD5FLmdG FhLC0qxBFmDiKWu8BnIEkvCnyilT2a67HO7EfqGayA8h/gcc9wsuiVIhWS7H705UZE7QYOeW3I8 jQqCpgl+eeQ83VQZr6cz+hRj8/Dwyp/s89G7pbMiocWTjHd4myTaEWDOFQZKzopHRpD6qdT+yLc 33N8KaeWCCP8BCCyoVY9QaGyGj6+5/k97ehEuX9CuMcA6lC8JMo3rw== X-Google-Smtp-Source: AGHT+IF2qnBTKenZ1AypOYLHMpucMP9SRa5u9iFuGqy1ut0HTtqxttm3kMbnkZczvm/vAv3TieOZ8g== X-Received: by 2002:a05:6a20:d50b:b0:1f5:709d:e0cb with SMTP id adf61e73a8af0-20a8980fb29mr4306826637.39.1746016426310; Wed, 30 Apr 2025 05:33:46 -0700 (PDT) Received: from localhost.localdomain ([110.44.101.8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74039a62e23sm1522627b3a.147.2025.04.30.05.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 05:33:45 -0700 (PDT) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Cc: Anand Moon Subject: [PATCH v6 3/4] thermal/drivers/exynos: Remove redundant IS_ERR() checks for clk_sec clock Date: Wed, 30 Apr 2025 18:02:59 +0530 Message-ID: <20250430123306.15072-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250430123306.15072-1-linux.amoon@gmail.com> References: <20250430123306.15072-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Remove unnecessary IS_ERR() checks for the clk_sec clock, the clk_enable() and clk_disable() functions can handle NULL clock pointers, so the additional checks are redundant and have been removed to simplify the code. Reviewed-by: Lukasz Luba Signed-off-by: Anand Moon --- v6: Add Rb - Lukasz and Fix the typo in the subject v5: None v4: drop IE_ERR() for clk_unprepare() as its handle in earlier code. v3: improve the commit message. --- drivers/thermal/samsung/exynos_tmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index aa0726b33c84..5f017a78f437 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -258,8 +258,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) mutex_lock(&data->lock); clk_enable(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_enable(data->clk_sec); + clk_enable(data->clk_sec); status = readb(data->base + EXYNOS_TMU_REG_STATUS); if (!status) { @@ -269,8 +268,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) data->tmu_clear_irqs(data); } - if (!IS_ERR(data->clk_sec)) - clk_disable(data->clk_sec); + clk_disable(data->clk_sec); clk_disable(data->clk); mutex_unlock(&data->lock); From patchwork Wed Apr 30 12:33:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 886268 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA86925B1C2; Wed, 30 Apr 2025 12:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746016435; cv=none; b=a49ahLeb/o28AJxT+3eXSqjAhP02szT7p+JoPwY+hdWwSOcsTBkBLBoZSa+74QmTD57I96b+Xewtfc2f7aHvk2NZ9AyI/zDGMZ6/rHuc/PiBMfv6ChfzS16YH6+P4ziYxSslVDNi41aTN8Ghr/rnKw1NVdH2JxENbzf3b0zubKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746016435; c=relaxed/simple; bh=w3jz2F7DYQyYj2UyhyQ+qsvOLyYvH1eF//AIxNpzRxg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rJLQo4ig4Rehpq5wLGXHp9W7TTs5gRLvtEFuEVsHLgH2rsytmxGThRu/3GADTbX4m9S34GuDtZrTAiVxLWsSF9qaW1TkwzP+yTzeE30RRG6yi7JTCcBBUcj7pqAv8srj6lZ85Vd5maWm0XWloP/qcAvrd3w10Tva3yYLXwg1k0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OeAILLLI; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OeAILLLI" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-73bf5aa95e7so6124353b3a.1; Wed, 30 Apr 2025 05:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746016433; x=1746621233; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VjF1aak/Vxutzt5SCKZiyBKrPP8O+zRq73MMdmerku4=; b=OeAILLLI7vYZnEmF92hQdX/jXviRT7qXx3quKueIeV+PZHPDoc4LknH4xDLfpB/XUY 0r6LVpH1rtoqkRxDq8vcXeXTH6+Rqtny11aZ0LFb69+5RIuUxGiHRpkJAyTgfIekEWK8 s7E4E5aJ9X0cLvyiUCB2cKZYiJv054mkibVuWaXuAEPVdm43DZaC0g/URScdBZnwEA6d /X0azvnhYYYc2S8uuDo8rf6a6EE0QLOcxnKzhieaQBQ3gfyaWtNJGy6n4RrbcjkO6wxS NfAZrT49I0BHovqkXbQQtrrSOoMy9JqfAvkbu+z5qGT0pfrs96L/A7Ik3Yol1NEcmcpD Eb1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746016433; x=1746621233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VjF1aak/Vxutzt5SCKZiyBKrPP8O+zRq73MMdmerku4=; b=GDEY5350rv3OjBthAPeouqxHfIJofoQqWkcivaVc8S+xOokYLRzci9W+h38CAZVzgV E3s6Oox/TssGF6I9qOsK69L2yvFCPV2dBt143ZyKjGWZ0oU6Ag2dhQ8jG52EGmg81oL0 7S5Wx0B6hee5c2atmxk6o0cMKNCIbPES2KMT2120R9SE6lB4iksm2IVeuenzWflNo2xf gcGNRpmmtpEM3p5SQLyai+kgoWhgdj2kbXOJz2C+ZHev93UUiWOhus64QO6gKart6gzO ZIWMZ56LT3Q9QEBxxl9W1FLGiamlDN6S8QplE71JGQS+2OWckArJ/FxhLXL+UqCF2Cs1 HP4g== X-Forwarded-Encrypted: i=1; AJvYcCUJ9s3MRoaMWbWbh6aiPbeoASLI4i08j8F92RuxMjRGw/c8H81RcFrTsgFcLXRaCF4DyCw6dZkvOclCl1U=@vger.kernel.org, AJvYcCVuY0SHSnf7Y5wjej8Ts1/JXlKH7DPXgEOZ9CYzy09TcXTlpEUIM7VtdKBsgrFEp/B3zavEhXgRMW3KvG8v/Q0575U=@vger.kernel.org, AJvYcCXnkDlU0jJAgLnDIXGURNWgLud34ldLyudILkLT4BC8A5lzhx4sBCQkN/8zL90XmiOCU7RSjlj6BXc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi7qjg9pSDWrg2Ukg90WCgl8GcDqOUBBkkEtXgg8+OjB1HLeW4 a7jdAgcffTyGAHhp6NJ3Px72XH8ajm0OwiugBRl/RpYBdrza1rll X-Gm-Gg: ASbGnctXkovRYs1f5xlaKVhfB6izXHVRO0zwPdcjOOpE7ktsCott6xOqdlgdt2crIFr 3MSYGnt8ycl/tJt1+8r6Y8BEZCGKWNG+5EgZ0XmMI0uA4erD3DH8eb9tQb9iPZNhQrB7qXuM6rW +vbV8FpaHTDU8dKEuStyF/qAMqcnv4CEhX2Q5AD7ADaVl5Yamm9h/AjnxCArSqc/v/4SlgeoRp5 u5k07SHJKcHN8d2umdnOODh3Y5ouQ/6ogsPaTGyzwmRBDGuiDzCRkT6hti864QmEAkHS1j1pvwG qJ5k6BijFskZ/ZJUtqilcPjMnKLqX3BcMk4Sd+dMZhSw5kySM9IQTA== X-Google-Smtp-Source: AGHT+IHJKBDe80VIu8qKthsvPbjAJ96qR6Xh6rsf0+iAijz4bJVrcEqmDWrR6oeCmx91YoLYuQSEJQ== X-Received: by 2002:a05:6a00:3a29:b0:736:69aa:112c with SMTP id d2e1a72fcca58-74038989dc9mr3923336b3a.9.1746016432889; Wed, 30 Apr 2025 05:33:52 -0700 (PDT) Received: from localhost.localdomain ([110.44.101.8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74039a62e23sm1522627b3a.147.2025.04.30.05.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 05:33:52 -0700 (PDT) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Cc: Anand Moon Subject: [PATCH v6 4/4] thermal/drivers/exynos: Fixed the efuse min max value for exynos5422 Date: Wed, 30 Apr 2025 18:03:00 +0530 Message-ID: <20250430123306.15072-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250430123306.15072-1-linux.amoon@gmail.com> References: <20250430123306.15072-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As per Exynos5422 user manual e-Fuse range min~max range is 16~76. if e-Fuse value is out of this range, then thermal sensor may not sense thermal data properly. Refactors the efuse value initialization logic within exynos_map_dt_data function by replacing the nested if-else statements with a switch statement. Ensures proper initialization of efuse values based on the SOC type. Reviewed-by: Lukasz Luba Signed-off-by: Anand Moon --- v6: Add Rb Lukasz and fix typo in subject v5: None V4: None --- drivers/thermal/samsung/exynos_tmu.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 5f017a78f437..ef216aac13ee 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -899,12 +899,23 @@ static int exynos_map_dt_data(struct platform_device *pdev) data->gain = 8; data->reference_voltage = 16; data->efuse_value = 55; - if (data->soc != SOC_ARCH_EXYNOS5420 && - data->soc != SOC_ARCH_EXYNOS5420_TRIMINFO) + data->max_efuse_value = 100; + switch (data->soc) { + case SOC_ARCH_EXYNOS3250: + case SOC_ARCH_EXYNOS4412: + case SOC_ARCH_EXYNOS5250: + case SOC_ARCH_EXYNOS5260: data->min_efuse_value = 40; - else + break; + case SOC_ARCH_EXYNOS5420: + case SOC_ARCH_EXYNOS5420_TRIMINFO: + data->min_efuse_value = 16; + data->max_efuse_value = 76; + break; + default: data->min_efuse_value = 0; - data->max_efuse_value = 100; + break; + } break; case SOC_ARCH_EXYNOS5433: data->tmu_set_low_temp = exynos5433_tmu_set_low_temp;