From patchwork Thu May 21 10:21:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 187004 Delivered-To: patch@linaro.org Received: by 2002:a92:5b0a:0:0:0:0:0 with SMTP id p10csp1411644ilb; Thu, 21 May 2020 03:21:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnEWhW7mPJ9bvnLOUY1l/VN4/4waC3dgyBR5IxvFUL21U8/brkMNWA0vHKQLk7XE3RNbF4 X-Received: by 2002:a0c:9e53:: with SMTP id z19mr9255004qve.47.1590056518394; Thu, 21 May 2020 03:21:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590056518; cv=none; d=google.com; s=arc-20160816; b=FnMZVNJP6HMDC3W16ac3HuLQDIa6WnQZVLj1upBlmwdj0cAMIEk/sv3aBIuA0jzEJi Ug1f1Y0VrkPTpFbBDyz6ABzeMGY8Yovlv45CMuDI2M6Sc/C3G0nmaXIxJtqXN3Da9aYP zjinDyn1FnAbVEJ+RaWTRB53WDMYDoP7juxOeHNUNxU766aYlQzW4yBeCqeF5Vhq4ksz ecpIx3r5JEYawDlaad0uDk/L820rC3iLFmpZEt+IyOSCYxgpp/vzPMskwSsi2Ewl3Ud1 hvi4HEJMKLKzF47UJdR2q1ciMXro63heJFANCoVZyhveddHjlQqwIDOpHMvZB6Y+jKy/ VpIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=eDRUUs0Bt6B3ETYta5XoOAaOPWB5Al8bLwiWuixJmW0=; b=MEVuBaK4XTx62wah56nbhqK8TDr0iK5pBfdoF3/3oB8ltAYacaOQTYzMukI3WyMOER OyuxsY3f760D+4yrCv2Da3AT2z8dscCTYGOx8cjAQp35CPX1K1qgoz2p+/WyhORD8dRU 9i5/piZpmjX6nBA8L6kMD8AqVclk37TIEXLSLjm9IGCooJzsGT9dniAd3DhG9yhw9bVJ e+Mz6CGRzBBgaZPYqYIUq0UgU67+vaT9+5IdpW14+sLtLJIZZu3iMRW54xt39U5O+Ue3 qjkKtAGVNLjQQJhXzgJvX8x1YZxBgjJTfJ0ZeWWCEW7NE68KM8epGnvDqEPJbN/14+fx N8cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cvMHfvsK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w9si2986541qtb.187.2020.05.21.03.21.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 May 2020 03:21:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cvMHfvsK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbiKr-0007LA-VP for patch@linaro.org; Thu, 21 May 2020 06:21:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbiKd-0007Ku-0p for qemu-devel@nongnu.org; Thu, 21 May 2020 06:21:43 -0400 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:42278) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbiKb-0001gs-I1 for qemu-devel@nongnu.org; Thu, 21 May 2020 06:21:42 -0400 Received: by mail-ed1-x541.google.com with SMTP id k19so6307023edv.9 for ; Thu, 21 May 2020 03:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eDRUUs0Bt6B3ETYta5XoOAaOPWB5Al8bLwiWuixJmW0=; b=cvMHfvsKjKy5XtgjZQHivr9bfKrMA+p3KQnPV5nRW+xNkGUOom91V7KXFwtmQX4kCc 04DLaKGI6NNssjdnPHosFwvSQhYeVsETB2jdiVeuAzy/DBDY/jpSGhA79zru9gSu92pk ic55F8SWceqyiAqxEk8qawKdYhwaRCtBeh9U2Rb0AfBKhZtBlcQ5J1aRjLEd1lm4lKbe 4oUs6YvF9fP3xo5dka5/EKMaoVo4Dtl2lMRO19gWqthddoJmf74OonHsbrUuZwcR2gSB cj0sjlN+riC1thRvfANcCETdilpa3CAcWA6rzAnt346sqYCZ29JY3qNJxm4M5SA0Si63 mwNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eDRUUs0Bt6B3ETYta5XoOAaOPWB5Al8bLwiWuixJmW0=; b=B0pfWVmKPCxq+BwIs9ONe0a7HiIlYv9pn44cy71MyZpniQVikvULjv7UYvZ7KY26ET yYL0BOuEXi9GU8wqSIRWA2h2ea5TQMQWRlE5xDjmRgRf+N70Q3gBnL9uJK0t5+4MMHXh APC6isXdHDsYsTgq0GZ9ZbmYM8pPl7a+9pzAY3inpyu/fcy3AMLY2469HFOhkrGzyGce e/me9io9KavnK1Tv6syO3iLKgeL1itcDcvPvtR6ny03WTm0wncJOGqipWg2TeLOLfbNt TAjy/9tnI69Y0LnzfZ1O0YyxAJM2LEaYqp1vgsT/nxfNxW3cDF9L6kzeXSXg0y/BkjDS MHgQ== X-Gm-Message-State: AOAM531gMHVVH+qKKW19Eh+KnVlO0m8OpkXCvM8JZpfanRt+yxirYNqD zOAzqbP4R6EK84YucpRINw1ghA== X-Received: by 2002:aa7:c492:: with SMTP id m18mr7053630edq.249.1590056499850; Thu, 21 May 2020 03:21:39 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id l11sm4401069edw.55.2020.05.21.03.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 03:21:38 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id D20A41FF7E; Thu, 21 May 2020 11:21:37 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH] linux-user: limit check to HOST_LONG_BITS == 32 Date: Thu, 21 May 2020 11:21:30 +0100 Message-Id: <20200521102130.17619-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::541; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x541.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Riku Voipio , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Newer clangs rightly spot that you can never exceed the full address space of 64 bit hosts with: linux-user/elfload.c:2076:41: error: result of comparison 'unsigned long' > 18446744073709551615 is always false [-Werror,-Wtautological-type-limit-compare] 4685 if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) { 4686 ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ 4687 1 error generated. So lets limit the check to 32 bit hosts only. Fixes: ee94743034bf Reported-by: Thomas Huth Signed-off-by: Alex Bennée --- linux-user/elfload.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1 diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 01a9323a637..797fbf2337a 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2072,6 +2072,7 @@ static void pgb_have_guest_base(const char *image_name, abi_ulong guest_loaddr, image_name, (uint64_t)guest_hiaddr, reserved_va); exit(EXIT_FAILURE); } +#if HOST_LONG_BITS == 32 } else { if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) { error_report("%s: requires more virtual address space " @@ -2079,6 +2080,7 @@ static void pgb_have_guest_base(const char *image_name, abi_ulong guest_loaddr, image_name, (uint64_t)guest_hiaddr - guest_base); exit(EXIT_FAILURE); } +#endif } /*